Re: [PATCH] libbb: code shrink parse_datestr

2021-09-14 Thread Denys Vlasenko
Applied, thank you. On Tue, Sep 14, 2021 at 9:53 AM Ron Yorston wrote: > > The default build uses strptime() in parse_datestr() to support the > 'month_name d HH:MM:SS ' format of GNU date. If we've linked > with strptime() there's an advantage is using it for other formats > too. > > There'

Re: [PATCH 2/3] ash: stopped jobs should only prevent exit from interactive shell

2021-09-14 Thread Roberto A. Foglietta
Il mar 14 set 2021, 22:01 Denys Vlasenko ha scritto: > On Tue, Sep 14, 2021 at 3:45 PM Roberto A. Foglietta > wrote: > > Il giorno mar 14 set 2021 alle ore 12:24 Denys Vlasenko > > ha scritto: > > > > > I am going to replace every raise_exception(EXEXIT) with > exitshell() > > > > > and to rem

Re: [PATCH 2/3] ash: stopped jobs should only prevent exit from interactive shell

2021-09-14 Thread Harald van Dijk
On 14/09/2021 17:06, Roberto A. Foglietta wrote: Il giorno mar 14 set 2021 alle ore 18:01 Harald van Dijk ha scritto: On 14/09/2021 11:24, Denys Vlasenko wrote: On Tue, Sep 14, 2021 at 10:04 AM Roberto A. Foglietta wrote: Il giorno dom 12 set 2021 alle ore 18:55 Roberto A. Foglietta ha scr

Re: [PATCH 2/3] ash: stopped jobs should only prevent exit from interactive shell

2021-09-14 Thread Harald van Dijk
On 14/09/2021 11:24, Denys Vlasenko wrote: On Tue, Sep 14, 2021 at 10:04 AM Roberto A. Foglietta wrote: Il giorno dom 12 set 2021 alle ore 18:55 Roberto A. Foglietta ha scritto: I am going to replace every raise_exception(EXEXIT) with exitshell() and to remove the EXEXIT altogether. Ther

Re: [PATCH 2/3] ash: stopped jobs should only prevent exit from interactive shell

2021-09-14 Thread Denys Vlasenko
On Tue, Sep 14, 2021 at 3:45 PM Roberto A. Foglietta wrote: > Il giorno mar 14 set 2021 alle ore 12:24 Denys Vlasenko > ha scritto: > > > > I am going to replace every raise_exception(EXEXIT) with exitshell() > > > > and to remove the EXEXIT altogether. > > > > There is only one: in exitcmd(), t

Re: [PATCH 2/3] ash: stopped jobs should only prevent exit from interactive shell

2021-09-14 Thread Roberto A. Foglietta
Il mar 14 set 2021, 20:14 Harald van Dijk ha scritto: > On 14/09/2021 19:01, Roberto A. Foglietta wrote: > > I got what you are saying. The unwind means the code executed after > > setjmp returns true and that's the enviroment. > > > > It Is useless to unwind. Nothing significative is done by unw

Re: [PATCH 2/3] ash: stopped jobs should only prevent exit from interactive shell

2021-09-14 Thread Harald van Dijk
On 14/09/2021 19:01, Roberto A. Foglietta wrote: I got what you are saying. The unwind means the code executed after setjmp returns true and that's the enviroment. It Is useless to unwind. Nothing significative is done by unwind which means nothing that is useful for exiting. Unwind means rest

Re: [PATCH 2/3] ash: stopped jobs should only prevent exit from interactive shell

2021-09-14 Thread Roberto A. Foglietta
Il mar 14 set 2021, 19:52 Harald van Dijk ha scritto: > On 14/09/2021 17:06, Roberto A. Foglietta wrote: > > Il giorno mar 14 set 2021 alle ore 18:01 Harald van Dijk > > ha scritto: > >> > >> On 14/09/2021 11:24, Denys Vlasenko wrote: > >>> On Tue, Sep 14, 2021 at 10:04 AM Roberto A. Foglietta >

Re: [PATCH 2/3] ash: stopped jobs should only prevent exit from interactive shell

2021-09-14 Thread Roberto A. Foglietta
Il giorno mar 14 set 2021 alle ore 18:01 Harald van Dijk ha scritto: > > On 14/09/2021 11:24, Denys Vlasenko wrote: > > On Tue, Sep 14, 2021 at 10:04 AM Roberto A. Foglietta > > wrote: > >> Il giorno dom 12 set 2021 alle ore 18:55 Roberto A. Foglietta > >> ha scritto: > >> > >>> I am going to

Re: [PATCH 2/3] ash: stopped jobs should only prevent exit from interactive shell

2021-09-14 Thread Roberto A. Foglietta
Hi all, The second part of this patch still need to be applied to fix one bug discovered by Harald about status returns http://lists.busybox.net/pipermail/busybox/attachments/20210912/6b5fbf84/attachment.obj It also replaces raise_exception(EXEXIT) in exitcmd() with exitshell(). Also (EXEND) cou

Re: [PATCH 2/3] ash: stopped jobs should only prevent exit from interactive shell

2021-09-14 Thread Roberto A. Foglietta
Il giorno mar 14 set 2021 alle ore 12:24 Denys Vlasenko ha scritto: > > On Tue, Sep 14, 2021 at 10:04 AM Roberto A. Foglietta > wrote: > > Il giorno dom 12 set 2021 alle ore 18:55 Roberto A. Foglietta > > ha scritto: > > > > > I am going to replace every raise_exception(EXEXIT) with exitshell()

Re: [PATCH 2/3] ash: stopped jobs should only prevent exit from interactive shell

2021-09-14 Thread Denys Vlasenko
On Tue, Sep 14, 2021 at 10:04 AM Roberto A. Foglietta wrote: > Il giorno dom 12 set 2021 alle ore 18:55 Roberto A. Foglietta > ha scritto: > > > I am going to replace every raise_exception(EXEXIT) with exitshell() > > and to remove the EXEXIT altogether. There is only one: in exitcmd(), the nad

Re: [PATCH 2/3] ash: stopped jobs should only prevent exit from interactive shell

2021-09-14 Thread Roberto A. Foglietta
Il giorno dom 12 set 2021 alle ore 18:55 Roberto A. Foglietta ha scritto: > I am going to replace every raise_exception(EXEXIT) with exitshell() > and to remove the EXEXIT altogether. It seems to me that EXEXIT does > not add any value but complicates things. What's your opinion on that? > Do yo

[PATCH] libbb: code shrink parse_datestr

2021-09-14 Thread Ron Yorston
The default build uses strptime() in parse_datestr() to support the 'month_name d HH:MM:SS ' format of GNU date. If we've linked with strptime() there's an advantage is using it for other formats too. There's no change to the non-default, non-DESKTOP build. function