Re: [PATCH 0/2] Add -R to less applet (bug #5546)

2018-01-26 Thread Denys Vlasenko
fixed, thanks On Wed, Jan 24, 2018 at 7:39 AM, Kang-Che Sung <explore...@gmail.com> wrote: > Hi Denys Vlasenko, > > I think I found a typo in the recent commit > 8528d3d4f8240ab4715f671aa819fe034f0fc285 > >> @@ -106,7 +122,7 @@ >> >> //usage:#defi

Re: [PATCH] ash: make bash_source command search current directory after PATH

2018-01-26 Thread Denys Vlasenko
On Fri, Jan 26, 2018 at 9:34 AM, Paul Otto wrote: > This patch restores, and improves upon, expected behavior to BASH > compatibility which was lost beginning with 1.27.0. This was pulled into > Alpine 3.7 which, in turn was pulled into official Docker images beginning > with

Re: [PATCH] dd: add 'fullblock' iflag.

2018-01-25 Thread Denys Vlasenko
Applied without the code which prints warning. Please try current git. On Wed, Jan 24, 2018 at 7:05 PM, Nicholas Clark wrote: > Adds a fullblock iflag for improved compatibility with GNU dd. > The new iflag can be used to ensure that dd calls retrieve the > expected

Re: [PATCH] ash: add support for command_not_found_handle hook function, like bash

2018-01-24 Thread Denys Vlasenko
On Thu, Oct 19, 2017 at 7:33 PM, William Pitcock wrote: > This implements support for the command_not_found_handle hook function, which > is > useful for allowing package managers to suggest packages which could provide > the > command. > > Unlike bash, however, we

Re: adding lineno implementation

2018-01-24 Thread Denys Vlasenko
On Wed, Jan 24, 2018 at 9:53 AM, daggs <da...@gmx.com> wrote: > Greetings Denys, > >> Sent: Tuesday, January 23, 2018 at 3:51 PM >> From: "Denys Vlasenko" <vda.li...@googlemail.com> >> To: daggs <da...@gmx.com> >> Cc: busybox <busy

Re: [PATCH v2] - Add support for link without MAC (like PPPoE/PPPoA)

2018-01-23 Thread Denys Vlasenko
uld keep the same across dhcp session. > > Maybe we can derive pseudo mac address from ipv6 local link address? > > Denys Vlasenko <vda.li...@googlemail.com> 於 2018年1月20日 週六 上午1:45寫道: >> >> On Thu, Jan 18, 2018 at 5:08 PM, 蔡崴丞 <da...@saru.moe> wrote: >> &

Re: [PATCH 0/4] Add SCHED_BATCH and SCHED_IDLE support to chrt

2018-01-23 Thread Denys Vlasenko
On Sat, Jan 13, 2018 at 10:25 PM, Povilas Kanapickas wrote: > Hi, > > The following patches add SCHED_BATCH and SCHED_IDLE support to chrt. > The priority limits are fixed to follow the specification. The last > patch avoids hardcoding the values of SCHED_* macros as array

Re: adding lineno implementation

2018-01-23 Thread Denys Vlasenko
On Tue, Jan 23, 2018 at 2:48 PM, daggs wrote: >> >> Care to send the patch? >> >> >> > >> > sure, see attached. >> >> >> Implemented in git a bit differently >> > > not sure I follow, is there an existing implementation for busybox? I applied an implementation to busybox git,

Re: [PATCH] nandwrite: alternative fix for MTD_FILE_MODE_RAW related build problems with kernels < 3.2.0

2018-01-23 Thread Denys Vlasenko
On Tue, Jan 23, 2018 at 12:18 AM, Eugene Rudoy wrote: > Unfortunately it is not possible in C to check for the existence of an enum > value at compile-time. Implement an alternative "kernel version check"-based > approach to workaround MTD_FILE_MODE_RAW related build

Re: [PATCH 0/2] Add -R to less applet (bug #5546)

2018-01-22 Thread Denys Vlasenko
On Fri, Jan 19, 2018 at 8:40 PM, Lubomir Rintel wrote: > chained are two patches that add make the less applet behave well with > tools that use coloring and paging at the same time. My first busybox > patches, so I beg for some understanding if I didn't get things right. > >

Re: [PATCH] volume_id: add LittleFS detection

2018-01-19 Thread Denys Vlasenko
applied, thanks On Thu, Jan 18, 2018 at 12:30 PM, Sven-Göran Bergh wrote: > Add support for LittleFS to blkid. Not included if FEATURE_BLKID_TYPE > is not selected (neither UUID nor label). > > LittleFS is a small fail-safe filesystem designed for embedded >

Re: [PATCH v2] - Add support for link without MAC (like PPPoE/PPPoA)

2018-01-19 Thread Denys Vlasenko
On Thu, Jan 18, 2018 at 5:08 PM, 蔡崴丞 wrote: > Since d6_read_interface relies on AF_PACKET (only exists when mac address > exists) for getting ifindex, dhcpc6 can't get ifindex on link without mac > address (like PPPoE.) > This patch fallbacks to ioctl SIOCGIFINDEX call for getting

Re: adding lineno implementation

2018-01-19 Thread Denys Vlasenko
On Tue, Jan 16, 2018 at 9:28 AM, daggs <da...@gmx.com> wrote: > Greetings Denys, > >> Sent: Monday, January 15, 2018 at 1:16 PM >> From: "Denys Vlasenko" <vda.li...@googlemail.com> >> To: daggs <da...@gmx.com> >> Cc: busybox <busy

Re: [PATCH] - Add prefix delegation support for udhcpc6

2018-01-16 Thread Denys Vlasenko
On Mon, Jan 15, 2018 at 11:01 AM, 蔡崴丞 wrote: > Patch 1&3 add DHCPv6 prefix delegation support, and offer option to > disable/enable IA_NA/IA_PD separately (make it possible to request IA_PD > only.) Applied. You need to send each patch separately. Patches need to have

Re: adding lineno implementation

2018-01-15 Thread Denys Vlasenko
On Mon, Jan 15, 2018 at 10:52 AM, daggs wrote: > Greetings, > > I'm trying to add LINENO implementation to hush, I've decided to check for > new lines in i_getch calls and it seems to work but with one bug, in loops, > the value gets updated wrongly. > > here is my test output: >

Re: Busybox in Debian

2018-01-14 Thread Denys Vlasenko
On Wed, Aug 23, 2017 at 2:43 AM, Ben Hutchings <b...@decadent.org.uk> wrote: >> > > > On Mon, 2017-08-14 at 16:42 +0200, Denys Vlasenko wrote: >> > > > > > > run-init >> > > > > >> > > > > This tool is doing this:

Re: [PATCH] dd: Error out when unable to write entire read block

2018-01-10 Thread Denys Vlasenko
Fixed, thanks! On Wed, Jan 10, 2018 at 12:08 AM, Ari Sundholm wrote: > Busybox dd has a difference in behavior compared to coreutils dd > in the case where the block count has been given and the last block > can only partially be written (usually due to ENOSPC): > > $ dd

Re: [PATCH] Fix runsvdir so it reaps children and avoid zombi processes when killed.

2018-01-09 Thread Denys Vlasenko
On Mon, Jan 8, 2018 at 7:53 PM, Laurent Bercot wrote: >> How about this: > > IIUC, this changes init's behaviour to only sleep after it has just > started a direct child, so as long as the /etc/inittab processes are > stable, it will always reap distant orphans

Re: reboot from init script doesn't work with busybox-1.26.2

2018-01-09 Thread Denys Vlasenko
On Wed, Dec 13, 2017 at 6:50 PM, Ankur Tank wrote: > Hello, > > > We have Beaglebone black based custom board, > > > Recently we upgraded busybox from version 1.20.2 to 1.26.2. > We are facing a issue where reboot(as mentioned below) from init scripts > doesn't

Re: Substring replacement in ash doesn't support slashes

2018-01-09 Thread Denys Vlasenko
On Wed, Dec 13, 2017 at 9:56 AM, Rafał Miłecki wrote: > Oh, I accidentally used some shortcut for sending an e-mail. > > On 13 December 2017 at 09:54, Rafał Miłecki wrote: >> I wanted to replace all slashes in my string with some other char. >> >> Example: >>

Re: [PATCH] Fix runsvdir so it reaps children and avoid zombi processes when killed.

2018-01-08 Thread Denys Vlasenko
On Sun, Jan 7, 2018 at 2:34 PM, Laurent Bercot wrote: >> It depends whether you consider init to be required to reap zombies >> as fast as possible. >> >> I don't see that as a requirement (so far, feel free to convince >> me otherwise). > > > I don't see it as a hard

Re: [PATCH] ash: fail if 'shift' operand is out of range

2018-01-07 Thread Denys Vlasenko
applied, thanks! On Fri, Jan 5, 2018 at 3:09 PM, Ingo van Lil wrote: > Package: busybox > Version: v1.29.0.git > Severity: minor > > If the numeric argument passed to ash's 'shift' built-in is greater than > '$#' the command performs no operation and exits successfully. It should

Re: [PATCH] Fix runsvdir so it reaps children and avoid zombi processes when killed.

2018-01-06 Thread Denys Vlasenko
On Thu, Jan 4, 2018 at 4:03 PM, Laurent Bercot wrote: >> Please point out the code in init.c which you think is buggy. > > > https://git.busybox.net/busybox/tree/init/init.c#n1216 is buggy. > > Unconditionally sleeping when signals may arrive is a no-no. If > a child

Re: Re: [PATCH] Fix runsvdir so it reaps children and avoid zombi processes when killed.

2018-01-04 Thread Denys Vlasenko
On Thu, Jan 4, 2018 at 10:14 AM, Markus Gothe wrote: > If you check init.c you will see that respawn is treated different from other > cases, and hence should be fixed in the program invoked. Please point out the code in init.c which you think is buggy.

Re: [PATCH 0/3] infra: make it possible to install without clobbering existing utilities

2018-01-04 Thread Denys Vlasenko
On Thu, Dec 28, 2017 at 11:49 PM, Yann E. MORIN wrote: > Hello All! > > Even though there is a hint of code preventing installation of applets > over existing utilities, this is flawed in two ways: > > - first, the non-clobbering conditional code does not account for >

Re: [PATCH] udhcpd: lease conflict

2018-01-03 Thread Denys Vlasenko
On Wed, Jan 3, 2018 at 10:30 AM, Jiří Prchal <jiri.prc...@aksignal.cz> wrote: > > > On 31.12.2017 10:32, Denys Vlasenko wrote: >> >> On Fri, Dec 15, 2017 at 1:41 PM, Jiri Prchal <jiri.prc...@aksignal.cz> >> wrote: >>> >>> If there is l

Re: [PATCH] udhcpd: lease conflict

2017-12-31 Thread Denys Vlasenko
On Fri, Dec 15, 2017 at 1:41 PM, Jiri Prchal wrote: > If there is lease for MAC which is no longer connected and only one IP in > pool, it doesn't lease to new one mac until expires the old one. This is how it is intended to work. > I think for this situation is there

Re: Question regarding runsvdir not reaping children.

2017-12-26 Thread Denys Vlasenko
2} --- 20:35:15.614199 restart_syscall(<... resuming interrupted nanosleep ...>) = 0 20:35:17.274544 wait4(-1, NULL, WNOHANG, NULL) = 518 20:35:17.274640 wait4(-1, NULL, WNOHANG, NULL) = 0 > On 25 Dec 2017, at 22:13 , Denys Vlasenko <vda.li...@googlemail.com> wrote: > >> On Fri,

Re: [PATCH] ntpd: runs script every 11 min

2017-12-26 Thread Denys Vlasenko
Thanks! Implemented in a slightly different way. On Fri, Dec 15, 2017 at 2:09 PM, Jiri Prchal wrote: > "S" option should run script every 11 minutes, but how it could if it sleeps > 1 hour. > So change next action time to 11 min. > > Signed-off-by: Jiri Prchal

Re: Question regarding runsvdir not reaping children.

2017-12-25 Thread Denys Vlasenko
On Fri, Dec 22, 2017 at 9:48 PM, Markus Gothe wrote: > What is the rationale behind not reaping the children when the program > exists? i run it from inittab as a respawn process and I get zombies when > killing it when not reaping children alas the fix was pretty

Re: [PATCH] env: -u option fails due to typo

2017-12-25 Thread Denys Vlasenko
On Thu, Dec 7, 2017 at 2:38 PM, Ron Yorston wrote: > The -u option is supposed to be allowed to appear multiple times; the > option string supplied to getopt32long requires it to be followed by a > nonnegative integer. > > Reported-by: Keith Maxwell >

Re: [PATCH] Cause udhcpc to return with failure when script fails

2017-11-23 Thread Denys Vlasenko
On Thu, Nov 23, 2017 at 11:37 AM, Fabien Lahoudere wrote: > Udhcpc uses scripts to perform many system dependent tasks. The return value > of these scripts isn't checked and udhcpc will continue on assuming that > they've worked. > > It may also be advantage to

Re: [PATCH] dd: fix corrupted/incomplete reads/skips.

2017-11-13 Thread Denys Vlasenko
On Thu, Nov 9, 2017 at 7:09 PM, Nicholas Clark wrote: > What would people think about a patch to add a GNU-style "fullblock" iflag > option? Would that be a better/more-mergeable way to tackle the same issue? > I could write one up if it's got a shot at getting merged.

Re: BusyBox's tar --exclude and -X option do not appear to be working (version 1.26.x)

2017-11-10 Thread Denys Vlasenko
On Sat, Nov 4, 2017 at 5:39 PM, gestos wrote: > Hello to all, > > for my first post on this list, an issue I am experiencing with BusyBox > 1.26.x version of tar (mipsel architecture). I want to dump a system image > from a combo USB3.0 / WiFi / Ethernet hard drive. The OS

Re: [PATCH] dd: fix corrupted/incomplete reads/skips.

2017-11-09 Thread Denys Vlasenko
On Wed, Nov 1, 2017 at 10:37 PM, Nicholas Clark wrote: > > Busybox dd expects that read() calls (as provided by safe_read) will > always return the requested amount of data unless at EOF. This isn't > true for safe_read(), but it is true for full_read() (which loops >

Re: [PATCH] inetd as unprivileged user

2017-11-09 Thread Denys Vlasenko
Fixed, thanks! On Wed, Nov 1, 2017 at 3:19 AM, Jack Schmidt wrote: > When I tried to use inetd as an unprivileged user on linux (4.9.x, x86_64, > glibc or musl), I get: > > inetd: can't set groups: Operation not permitted > > I believe the problem is line 1486, where it

Re: unshare -r accidentally implies -u (UTS) instead of -U (user), and -r mapping is broken

2017-11-09 Thread Denys Vlasenko
Fixed, thanks! On Sun, Nov 5, 2017 at 11:18 AM, Urja Rannikko wrote: > Hi, > > On -r being broken: > the uid_map and gid_map for the root mapping should be > "0 %u 1" not "%u 0 1" (i think that tries to map the outside root to > be your user id in the namespace... nope.) > >

Re: [PATCH 3/3] unzip: add support for a non-standard (busybox only) -J NUM option

2017-11-09 Thread Denys Vlasenko
On Tue, Nov 7, 2017 at 8:03 AM, Eugene Rudoy wrote: > Its behavior is the same as that of tar's --strip-components=NUM. > > Based on > https://git.busybox.net/busybox/commit?id=6c563e370d0f2f3cf36f3b274e8fe1392ca7125f > > function

Re: [PATCH 2/3] unzip: add missing -j to trivial usage

2017-11-09 Thread Denys Vlasenko
Applied, thanks On Tue, Nov 7, 2017 at 8:03 AM, Eugene Rudoy wrote: > Signed-off-by: Eugene Rudoy > --- > archival/unzip.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/archival/unzip.c b/archival/unzip.c > index

Re: [PATCH 1/3] unzip: fix content listing and filtering when -j is used

2017-11-09 Thread Denys Vlasenko
Applied, thanks On Tue, Nov 7, 2017 at 8:03 AM, Eugene Rudoy wrote: > Original Info-ZIP's unzip uses unstripped filenames > while doing content listing and filtering, i.e. > - in content listing mode -j is ignored completely > - filtering is applied to non-stripped names,

Re: NOEXEC environment bug

2017-11-03 Thread Denys Vlasenko
On Wed, Nov 1, 2017 at 8:50 PM, Ron Yorston wrote: > There's a related problem when SH_STANDALONE and SH_NOFORK are enabled: > changed shell variables aren't visible to NOFORK applets. For example, > >$ ./busybox sh >$ mkdir ~/mybin >$ cp busybox ~/mybin/thing >$

Re: Race in reboot/poweroff path at init?

2017-11-02 Thread Denys Vlasenko
On Tue, Oct 10, 2017 at 10:52 AM, Jeremy Kerr wrote: > Hi all, > > I've been debugging an issue where we can't reboot or poweroff a machine > in the early stages of busybox init. Using the poweroff case as an > example: > > - kernel starts /sbin/init > > - kernel receives a

Re: NOEXEC environment bug

2017-11-02 Thread Denys Vlasenko
On Wed, Nov 1, 2017 at 2:28 AM, Jack Schmidt wrote: > I believe I have found a bug in the current version of busybox. > > When: > * an applet is marked NOEXEC, > * busybox is configured with CONFIG_FEATURE_SH_STANDALONE=y, and > * busybox's ash is asked to do "ENV_VAR=newval

Re: [PATCH 7/7] libbb.h: Handle missing HOST_NAME_MAX; ensure MAXFOOLEN agrees with FOO_MAX

2017-10-31 Thread Denys Vlasenko
How about this? --- a/networking/traceroute.c +++ b/networking/traceroute.c @@ -709,6 +709,9 @@ packet_ok(int read_len, len_and_sockaddr *from_lsa, # if ENABLE_FEATURE_TRACEROUTE_VERBOSE if (verbose) { +# ifndef MAXHOSTNAMELEN +# define MAXHOSTNAMELEN 80 +# endif

Re: [PATCH 6/7] grep: Skip grepping symlinks to directories

2017-10-31 Thread Denys Vlasenko
Applied, thanks On Sat, Oct 7, 2017 at 7:53 PM, James Clarke wrote: > When grep is passed -r, recursive_action will treat any symlinks to > directories not in the root as normal files, since it lstat's them and > is therefore told they are not directories. However,

Re: Ash glob symlink regression when using libc glob

2017-10-31 Thread Denys Vlasenko
On Tue, Oct 31, 2017 at 8:31 AM, Lauri Kasanen <c...@gmx.com> wrote: > On Mon, 30 Oct 2017 20:24:08 +0100 > Denys Vlasenko <vda.li...@googlemail.com> wrote: > >> On Sun, Oct 29, 2017 at 7:43 PM, Lauri Kasanen <c...@gmx.com> wrote: >> > Hi, >> > &g

Re: Ash glob symlink regression when using libc glob

2017-10-30 Thread Denys Vlasenko
On Sun, Oct 29, 2017 at 7:43 PM, Lauri Kasanen wrote: > Hi, > > It was reported the following case fails with bb 1.27.2: > > ln -s nonexistent mylink > mv myli* someother > > It also fails with master. I bisected it to > b3f29b452a660a7293162897424bed205f7f9147, "ash: use glob()

Re: [PATCH 5/7] {udp_io, traceroute}: Standardise IPv6 PKTINFO handling to be portable

2017-10-30 Thread Denys Vlasenko
Applied, thanks! On Sat, Oct 7, 2017 at 7:53 PM, James Clarke wrote: > The current standard (RFC 3542) is for IPV6_RECVPKTINFO to be given to > setsockopt, and IPV6_PKTINFO to be used as the packet type. Previously, > RFC 2292 required IPV6_PKTINFO to be used for both, but RFC

Re: [PATCH 2/7] df: Use statvfs instead of non-standard statfs

2017-10-30 Thread Denys Vlasenko
Applied, thanks! On Sat, Oct 7, 2017 at 7:53 PM, James Clarke wrote: > Platforms differ on what their implementations of statfs include. > Importantly, FreeBSD's does not include a f_frsize member inside struct > statfs. However, statvfs is specified by POSIX and includes

Re: [PATCH 4/7] xfuncs: Handle missing non-POSIX termios constants

2017-10-30 Thread Denys Vlasenko
Applied, thanks! On Sun, Oct 8, 2017 at 5:01 PM, Kang-Che Sung wrote: > On Sun, Oct 8, 2017 at 10:34 PM, Ralf Friedl wrote: >> >> Because the way the line is now is one line with 8 values. Changing that to >> use ifdefs for each value would change

Re: [PATCH 3/7] networking: Fall back on IPPROTO_RAW when SOL_RAW is not defined

2017-10-30 Thread Denys Vlasenko
Applied, thanks! On Sat, Oct 7, 2017 at 7:53 PM, James Clarke wrote: > Signed-off-by: James Clarke > --- > networking/ping.c | 8 > networking/traceroute.c | 8 > 2 files changed, 16 insertions(+) > > diff --git a/networking/ping.c

Re: [PATCH v2 2/2] iproute/iprule: restore support for kernel versions missing RTA_TABLE routing attribute

2017-10-27 Thread Denys Vlasenko
Applied, thanks! On Thu, Oct 19, 2017 at 12:05 AM, Eugene Rudoy wrote: > iproute/iprule applets fail to compile when compiled using kernel versions < > 2.6.19 > > iproute.c: In function 'print_route': > iproute.c:85:9: error: 'RTA_TABLE' undeclared (first use in this

Re: [PATCH v2 1/2] time applet: fix a build problem with kernel versions missing O_CLOEXEC symbol

2017-10-27 Thread Denys Vlasenko
On Thu, Oct 19, 2017 at 12:05 AM, Eugene Rudoy wrote: > Kernel versions < 2.6.23 do not support/provide O_CLOEXEC symbol > causing the time applet not to compile: > > time.c: In function 'time_main': > time.c:445:28: error: 'O_CLOEXEC' undeclared (first use in this

Re: [PATCH v2 1/1] lsscsi: Fix xchdir(".."); from symlink in /sys/bus/scsi/devices

2017-10-22 Thread Denys Vlasenko
Applied, thanks! On Sat, Oct 21, 2017 at 9:34 PM, Markus Gothe wrote: > Did a patch via git format-patch command: > > Signed-off-by: Markus Gothe > --- > miscutils/lsscsi.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > >

Re: Suggestions for --install

2017-10-11 Thread Denys Vlasenko
On Thu, Oct 5, 2017 at 9:31 PM, Christoph Biedl wrote: > ... the (for me) awkward part is to embed this into the manpage if and > only if CONFIG_FEATURE_INSTALLER is set. This is still somewhat beyond > my knowledge of the busybox build and install system. Don't

Re: [PATCH] i2cset: fix 'i' & 's' modes otherwise 3 extra bytes are sent

2017-10-05 Thread Denys Vlasenko
Applied, thanks! On Sun, Oct 1, 2017 at 2:30 PM, Avi Fishman wrote: > When 'i' or 's' modes are selected block array is filled from offset 3 > (blen = 3) but copied to data.block buffer from offset 0 so first 3 bytes > contains garbage from stack. > The buffer that is

Re: tinyutils.html

2017-10-02 Thread Denys Vlasenko
On Wed, Sep 27, 2017 at 5:57 AM, Rob Landley wrote: > Denys, any interest in adding: > > https://github.com/symisc/PH7 > http://duktape.org/ > > to the tinyutils page? Sure! https://busybox.net/tinyutils.html Does it look okay?

Re: [PATCH] httpd: fix handling of range requests

2017-09-18 Thread Denys Vlasenko
Applied, thanks On Sat, Sep 16, 2017 at 3:21 PM, Casper Ti. Vector wrote: > --- > networking/httpd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/networking/httpd.c b/networking/httpd.c > index c82383507..74196a4f1 100644 > ---

Re: Cannot download busybox with busybox

2017-09-06 Thread Denys Vlasenko
On Tue, Aug 29, 2017 at 4:42 PM, Kang-Che Sung wrote: > And the analogy of p7zip is a failure. Every FOSS package has its own > bootstrapping problem to address. GCC needs a C++ compiler; tar needs a copy > of > tar to unpack its own sources. Well, in this case I probably

Re: [PATCH] sysklogd: add -Z option to adjust message timezones

2017-09-01 Thread Denys Vlasenko
On Mon, May 8, 2017 at 11:45 PM, Shiz wrote: > Some syslog() implementations like musl's[1] always send timestamps in UTC. > This change adds a new option to syslogd, -Z, to assume incoming timestamps > are always UTC and adjust them to the local timezone (of the syslogd) before >

Re: [PATCH] xargs: support -a args-file

2017-08-30 Thread Denys Vlasenko
Fixed, thanks! On Wed, Aug 30, 2017 at 12:18 PM, Xabier Oneca -- xOneca <xon...@gmail.com> wrote: > Hello, > > 2017-08-29 21:06 GMT+02:00 Denys Vlasenko <vda.li...@googlemail.com>: >> Applied, thanks. >> >> On Fri, Aug 25, 2017 at 10:42 PM, Johannes Sc

Re: [PATCH] xargs: support -a args-file

2017-08-29 Thread Denys Vlasenko
Applied, thanks. On Fri, Aug 25, 2017 at 10:42 PM, Johannes Schindelin wrote: > The GNU-specific option -a lets xargs read the arguments from a file > rather than from stdin. > > This is particularly convenient when debugging in gdb interactively, > and it might be of

Re: Cannot download busybox with busybox

2017-08-29 Thread Denys Vlasenko
I'll cc this to bbox mailing list to humiliate this guy. On Tue, Aug 29, 2017 at 1:21 PM, wrote: >>>I'm trying to update busybox binary on busybox-based system. >>>When i am trying to download busybox, i have this error >>> >>># wget

Re: [PATCH] i2c-tools: don't include linux/i2c-dev.h

2017-08-29 Thread Denys Vlasenko
Applied, thanks! On Mon, Aug 28, 2017 at 4:55 PM, Bartosz Golaszewski wrote: > Installing headers from upstream i2c-tools makes it impossible to > build the busybox version due to redefined symbols. This is caused by > the fact that linux/i2c-dev.h from i2c-tools overwrites

Re: [PATCH 2/2] i2c-tools: fix build with upstream i2c-tools' headers

2017-08-28 Thread Denys Vlasenko
On Mon, Aug 28, 2017 at 11:49 AM, Bartosz Golaszewski wrote: > Installing headers from upstream i2c-tools makes it impossible to > build the busybox version due to redefined symbols. This is caused by > the fact that linux/i2c-dev.h from i2c-tools overwrites the one from >

Re: [PATCH 1/2] i2c-tools: remove unneeded include

2017-08-28 Thread Denys Vlasenko
Applied, thanks! On Mon, Aug 28, 2017 at 11:49 AM, Bartosz Golaszewski wrote: > We no longer use common_bufsiz1 in i2c-tools. > > Don't include common_bufsiz.h. > > Signed-off-by: Bartosz Golaszewski > --- > miscutils/i2c_tools.c | 1 - > 1 file

Re: [PATCH] kill: add '--' option to separate options from arguments

2017-08-28 Thread Denys Vlasenko
Applied, thanks. On Sun, Aug 27, 2017 at 9:25 AM, Ron Yorston wrote: > Using a negative pid to send TERM to a process group results in an > obscure error: > >$ ./busybox kill -12345 >kill: bad signal name '12345' > > There are a couple of workarounds: > > - specify the

Re: [PATCH 1/1] xargs: support -P (parallel execution)

2017-08-28 Thread Denys Vlasenko
On Fri, Aug 25, 2017 at 1:56 PM, Johannes Schindelin wrote: >> { >> int status; >> >> +#if !ENABLE_FEATURE_XARGS_SUPPORT_PARALLEL >> status = spawn_and_wait(G.args); >> +#else >> +if (G.max_procs == 1) { >> +status = spawn_and_wait(G.args); >> +

Re: [PATCH 1/1] xargs: support -P (parallel execution)

2017-08-24 Thread Denys Vlasenko
On Wed, Aug 23, 2017 at 5:25 PM, Johannes Schindelin wrote: > The GNU variant of xargs supports a special, non-POSIX extension to run > processes in parallel, triggered by the -P option. > > This feature comes in handy e.g. when running Git's test suite outside > of

Re: sed: missing support for empty regular expressions

2017-08-23 Thread Denys Vlasenko
On Tue, Aug 22, 2017 at 6:32 PM, Leah Neukirchen wrote: > Hi, > > it seems busybox sed (v1.27.2) does not support empty regular > expressions as by POSIX, but instead matches the empty string: > >>> If an RE is empty (that is, no pattern is specified) sed shall >>> behave as if the

Re: [PATCH 2/2] ash: when cd fails, say why

2017-08-23 Thread Denys Vlasenko
Applied both, thanks On Tue, Aug 22, 2017 at 10:03 PM, Johannes Schindelin wrote: > Signed-off-by: Johannes Schindelin > --- > shell/ash.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/shell/ash.c b/shell/ash.c

Re: Busybox in Debian

2017-08-23 Thread Denys Vlasenko
On Wed, Aug 23, 2017 at 2:43 AM, Ben Hutchings <b...@decadent.org.uk> wrote: > On Tue, 2017-08-22 at 10:38 +0200, Denys Vlasenko wrote: >> > > I added run-init to busybox just now, but I don't see -n option >> > > in >> > > klibc-2.0.4 source

Re: [PATCH] tar: fix handling of first argument without '-'

2017-08-23 Thread Denys Vlasenko
Applied, thanks On Tue, Aug 22, 2017 at 5:33 PM, Ron Yorston wrote: > The following no longer works as expected: > >$ ./busybox tar xfz test.tgz >tar: can't open 'z': No such file or directory > > Signed-off-by: Ron Yorston > --- > archival/tar.c | 6

Re: Busybox Sendmail segfaults with multiple inline recipients

2017-08-22 Thread Denys Vlasenko
Fixed in git, thanks On Sat, Aug 19, 2017 at 1:08 AM, mark wrote: > Hello, > > I came across a bug in the sendmail function of busybox when using the > "-t" option and including multiple recipients in any of the inline mail > headers (To, Cc, or Bcc). > > When

Re: [PATCH] libarchive: fix build failure on NOMMU systems

2017-08-22 Thread Denys Vlasenko
Applied, thanks On Tue, Aug 22, 2017 at 12:34 PM, Ron Yorston wrote: > In the old code fd was an argument, now we need to get the file descriptor > from the xstate structure. > > Signed-off-by: Ron Yorston > --- > archival/libarchive/open_transformer.c | 2 +- >

Re: [PATCH] ps: fix build failure if FEATURE_PS_TIME is disabled

2017-08-22 Thread Denys Vlasenko
Applied, thanks On Tue, Aug 22, 2017 at 12:21 PM, Ron Yorston wrote: > The global seconds_since_boot is only defined if FEATURE_PS_TIME > is enabled. > > Signed-off-by: Ron Yorston > --- > procps/ps.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >

Re: [PATCH] rpm2cpio: allow building with rpm disabled

2017-08-22 Thread Denys Vlasenko
On Tue, Aug 22, 2017 at 11:57 AM, Ron Yorston wrote: > With rpm disabled and rpm2cpio enabled the build fails because the > symbol ARCHIVE_REPLACE_VIA_RENAME isn't defined. > > Signed-off-by: Ron Yorston > --- > archival/rpm.c | 2 +- > 1 file changed, 1

Re: [PATCH] ps: Allow ps config options if minips is enabled

2017-08-22 Thread Denys Vlasenko
Applied, thanks! On Sat, Aug 19, 2017 at 8:18 AM, Kang-Che Sung wrote: > Follow-up of commit ab77e81a8527fa11a4f9392d97c2da037d6f4f98 > "klibc-utils: new applets: resume, nuke, minips" > > Also put FEATURE_PS_UNUSUAL_SYSTEMS to under FEATURE_PS_TIME in the > menu. > >

Re: Busybox in Debian

2017-08-22 Thread Denys Vlasenko
On Mon, Aug 21, 2017 at 8:38 PM, Ben Hutchings <b...@decadent.org.uk> wrote: > On Mon, 2017-08-21 at 19:40 +0200, Denys Vlasenko wrote: >> > On Mon, Aug 14, 2017 at 5:12 PM, Ben Hutchings <b...@decadent.org.uk> >> > wrote: >> > On Mon, 2017-

Re: Busybox in Debian

2017-08-21 Thread Denys Vlasenko
On Mon, Aug 14, 2017 at 5:12 PM, Ben Hutchings <b...@decadent.org.uk> wrote: > On Mon, 2017-08-14 at 16:42 +0200, Denys Vlasenko wrote: >> > > run-init >> >> This tool is doing this: > [...] >> There is the "switch_root" tool in util-linux

Re: Busybox in Debian

2017-08-18 Thread Denys Vlasenko
On Mon, Aug 14, 2017 at 5:12 PM, Ben Hutchings wrote: >> If you want "resume" and "ipconfig" in bbox, I can do that. > > Go for it. Added resume, nuke, minips so far. ___ busybox mailing list busybox@busybox.net

Re: [PATCH] telnet: busybox telnet autologin with -a -l user option picks incorrect username

2017-08-17 Thread Denys Vlasenko
On Thu, Aug 17, 2017 at 1:56 PM, Tito <farmat...@tiscali.it> wrote: > On 08/17/2017 01:14 PM, Athira Rajeev wrote: >>> On 17-Aug-2017, at 4:21 PM, Denys Vlasenko <vda.li...@googlemail.com> >>> wrote: >>> >>> On Thu, Aug 17, 2017 at 12:01 PM, At

Re: [PATCH] telnet: busybox telnet autologin with -a -l user option picks incorrect username

2017-08-17 Thread Denys Vlasenko
On Thu, Aug 17, 2017 at 12:01 PM, Athira Rajeev wrote: > Adding patch which has the following change similar to telnet which: > - Assigns from getenv("USER") only if G.autologin is NULL > > Signed-off-by: Athira Rajeev > >

Re: bbox: musl versus uclibc

2017-08-16 Thread Denys Vlasenko
On Wed, Aug 16, 2017 at 2:34 PM, Thomas Petazzoni wrote: > Hello, > > On Mon, 14 Aug 2017 12:59:41 -0500, wdlkmpx wrote: > >> I'm sure there was plenty of people willing to contribute to uclibc, >> there is even an updated fork. >> >> The project has been

Re: [musl] bbox: musl versus uclibc

2017-08-14 Thread Denys Vlasenko
On Mon, Aug 14, 2017 at 8:48 PM, Rich Felker wrote: >> Now, the good news - musl has smaller data! >> 6695 bytes versus 7129 bytes for uclibc: >> >>text data bss dechex filename >> 894902 465 6664 902031 dc38f busybox.uclibc >> 912538 563 6132 919233

bbox: musl versus uclibc

2017-08-14 Thread Denys Vlasenko
As uclibc is increasingly aging, I am finally forced to switch to musl: I'm bitten by a nasty bug in getopt() - hush is using it in a slightly unusual way, which uclibc does not expect. I built a toolchain using https://github.com/richfelker/musl-cross-make (Rich, is this the thing I should

Re: Busybox in Debian

2017-08-14 Thread Denys Vlasenko
>> ipconfig Looks like it is used to run DHCP / BOOTP / RARP on several interfaces, including a possibility to run it on _all_ existing interfaces (excluding loopback and point-to-point). I see how this can be useful during boot. >> minips It's just mini-ps. Proliferation of reinvented tools

Re: Busybox in Debian

2017-08-14 Thread Denys Vlasenko
On Mon, Aug 14, 2017 at 3:05 PM, Ben Hutchings <b...@decadent.org.uk> wrote: > On Mon, 2017-08-14 at 14:55 +0200, Denys Vlasenko wrote: >> On Sat, Aug 12, 2017 at 4:15 PM, Ben Hutchings <b...@decadent.org.uk> >> wrote: >> > On Fri, 2017-08

Re: Busybox in Debian

2017-08-14 Thread Denys Vlasenko
On Sat, Aug 12, 2017 at 4:15 PM, Ben Hutchings wrote: > On Fri, 2017-08-11 at 14:54 -0400, Chris Boot wrote: > [...] >> - The default initramfs assembly system, initramfs-tools, incorporates >> busybox into the initramfs and it's used until the root filesystem (and >> /usr

Re: Busybox in Debian

2017-08-11 Thread Denys Vlasenko
On Fri, Aug 11, 2017 at 7:01 PM, Chris Boot wrote: > Hi all, > > This is a short note to say that Christoph (CCed) and I are taking over > packaging of Busybox in Debian. I'm hoping that we will both be fairly > active in here (the busybox mailing list) from now on. > > We've

Re: [PATCH] chcon: trivial usage: '--reference' now depends on LONG_OPTS

2017-08-09 Thread Denys Vlasenko
Applied, thanks. Please add signed-off lines to your patches. On Tue, Aug 8, 2017 at 10:02 PM, Xabier Oneca -- xOneca wrote: > Hello, > > In one of the lastest mega-commits > (036585a911a5fe6c2cd77b808dd9150500f37272 getopt32: remove > applet_long_options) I've spotted (don't

Re: [PATCH] Silence misguided GCC warning about alignment issues

2017-08-07 Thread Denys Vlasenko
On Mon, Aug 7, 2017 at 12:09 PM, Johannes Schindelin wrote: > When compiling xz_dec_stream.c with GCC 7.1.0, it complains thusly: > > In function 'dec_stream_footer': > error: dereferencing type-punned pointer will break strict-aliasing >

Re: [PATCH] ash: support BASH_XTRACEFD when built Bash compatibly

2017-08-04 Thread Denys Vlasenko
Applied in this form: preverrout_fd = 2; + if (BASH_XTRACEFD && xflag) { + /* NB: bash closes fd == $BASH_XTRACEFD when it is changed. +* we do not emulate this. We only use its value. +*/ + const char *xtracefd =

Re: [PATCH] unzip: fix regression on big-endian machines

2017-08-04 Thread Denys Vlasenko
okay On Fri, Aug 4, 2017 at 10:27 AM, Natanael Copa <nc...@alpinelinux.org> wrote: > On Thu, 27 Jul 2017 15:39:35 +0200 > Denys Vlasenko <vda.li...@googlemail.com> wrote: > >> Applied, thanks! > > This should go to 1_27_stable too. > > Thanks! > >&

Re: [PATCH] miscutils/microcom: Fixed segfault

2017-08-04 Thread Denys Vlasenko
It's hardly a critical error :) On Fri, Aug 4, 2017 at 10:25 AM, Natanael Copa <nc...@alpinelinux.org> wrote: > On Fri, 4 Aug 2017 02:02:36 +0200 > Denys Vlasenko <vda.li...@googlemail.com> wrote: > >> On Thu, Aug 3, 2017 at 7:11 AM, Marian Buschsieweke >> &l

Re: [PATCH] ash: remove no-longer-used variable

2017-08-04 Thread Denys Vlasenko
applied, thanks! On Fri, Aug 4, 2017 at 12:16 PM, Johannes Schindelin wrote: > As of 035486c75 (ash: significant overhaul of redirect saving logic, > 2017-07-31), the sv_pos variable is no longer used (just assigned to, > with no further effect). > > Let's just remove

Re: [PATCH] miscutils/microcom: Fixed segfault

2017-08-03 Thread Denys Vlasenko
On Thu, Aug 3, 2017 at 7:11 AM, Marian Buschsieweke wrote: > microcom did not check if required parameter TTY is present. Thus, > bb_basename() was called with a NULL pointer if TTY was missing. > This commit adds the missing check. Fixed, thanks! (A bit differently)

Re: TLS support fails to build on i686 with gcc 4.8

2017-07-30 Thread Denys Vlasenko
On Sun, Jul 30, 2017 at 3:24 PM, Thomas Petazzoni wrote: > Hello, > > Using a fairly old gcc 4.8 toolchain for i686, the latest Busybox > 1.27.1 release fails to build fails: > > networking/tls_pstm_mul_comba.c: In function 'pstm_mul_comba': >

Re: [PATCH] libbb: remove vdprintf

2017-07-29 Thread Denys Vlasenko
Applied, thanks! On Sat, Jul 29, 2017 at 3:48 PM, Ron Yorston wrote: > Two reasons: > > * it's only built for GNU C Library versions < 2 (released 1997) > > * it isn't used anywhere in BusyBox > > Signed-off-by: Ron Yorston > --- > TODO | 2 -- >

Re: [PATCH] ash: special treatment for 'busybox' in standalone shell mode

2017-07-28 Thread Denys Vlasenko
On Fri, Jul 28, 2017 at 8:50 PM, Ron Yorston <r...@pobox.com> wrote: > Denys Vlasenko wrote: >>How about this instead? > > Looks good. It's less intrusive, though introduces a bit more bloat. > My approach also works even if BUSYBOX is disabled in the configuration, &

<    4   5   6   7   8   9   10   11   12   13   >