Re: [PATCH] Add a gzip fastpath for the xmalloc readers, v3

2014-12-07 Thread Lauri Kasanen
On Sun, Dec 7, 2014, at 01:51, Denys Vlasenko wrote: It misses the plus one zero byte behavior of the non-compressed path (xmalloc_read). I bet some callers depend on it, using str* functions on the returned buffer. Fixed, and committed to git. Please try it. Results are correct and

Re: [PATCH] Add a gzip fastpath for the xmalloc readers, v3

2014-12-06 Thread Denys Vlasenko
Please see attached patch (only compile-tested so far). It builds on your work, implementing in-memory compression for all unpackers we have. Unfortunately, bloatcheck is not inspiring: function old new delta transformer_write

Re: [PATCH] Add a gzip fastpath for the xmalloc readers, v3

2014-12-06 Thread Denys Vlasenko
On Sat, Dec 6, 2014 at 5:11 PM, Denys Vlasenko vda.li...@googlemail.com wrote: Please see attached patch (only compile-tested so far). It builds on your work, implementing in-memory compression for all unpackers we have. 1.patch Description: Binary data

Re: [PATCH] Add a gzip fastpath for the xmalloc readers, v3

2014-12-06 Thread Lauri Kasanen
On Sat, Dec 6, 2014, at 18:11, Denys Vlasenko wrote: Please see attached patch (only compile-tested so far). It builds on your work, implementing in-memory compression for all unpackers we have. It misses the plus one zero byte behavior of the non-compressed path (xmalloc_read). I bet some

Re: [PATCH] Add a gzip fastpath for the xmalloc readers, v2

2014-11-30 Thread Denys Vlasenko
On Fri, Nov 28, 2014 at 10:44 AM, Lauri Kasanen cur...@operamail.com wrote: v2: Add missing check on open The performance and number of processes for a depmod -a with gzipped modules was abysmal. This patch adds a fast path without fork for well- behaved gzip files, benefiting all users of

[PATCH] Add a gzip fastpath for the xmalloc readers, v3

2014-11-30 Thread Lauri Kasanen
) Total: 348 bytes -- http://www.fastmail.com - Does exactly what it says on the tin From 5ad6804ed4485eae176da45524ea848a00b11929 Mon Sep 17 00:00:00 2001 From: Lauri Kasanen cur...@operamail.com Date: Sun, 30 Nov 2014 21:37:10 +0200 Subject: [PATCH] Add a gzip fastpath for the xmalloc

[PATCH] Add a gzip fastpath for the xmalloc readers, v2

2014-11-28 Thread Lauri Kasanen
Date: Thu, 27 Nov 2014 14:48:17 +0200 Subject: [PATCH] Add a gzip fastpath for the xmalloc readers v2: Add missing check on open The performance and number of processes for a depmod -a with gzipped modules was abysmal. This patch adds a fast path without fork for well- behaved gzip files

[PATCH] Add a gzip fastpath for the xmalloc readers

2014-11-27 Thread Lauri Kasanen
4eaee06a748ce07b004b40aa10fa1bcc3e5e8928 Mon Sep 17 00:00:00 2001 From: Lauri Kasanen cur...@operamail.com Date: Thu, 27 Nov 2014 14:48:17 +0200 Subject: [PATCH] Add a gzip fastpath for the xmalloc readers The performance and number of processes for a depmod -a with gzipped modules was abysmal. This patch

Re: [PATCH] Add a gzip fastpath for the xmalloc readers

2014-11-27 Thread walter harms
--- a/archival/libarchive/open_transformer.c +++ b/archival/libarchive/open_transformer.c @@ -213,6 +213,22 @@ void* FAST_FUNC xmalloc_open_zipped_read_close(const char *fname, size_t *maxsz_ int fd; char *image; + /* Fast path for well-behaved gzip files, avoiding forks.