Re: adduser/passwd: too long username

2014-08-21 Thread Natanael Copa
On Mon, 18 Aug 2014 20:37:00 +0200 Natanael Copa nc...@alpinelinux.org wrote: I never sent those patches upstream because I don't think this is the correct fix. For Alpine Linux the correct fix was to use the libc implementation and a libc that handles this properly (musl libc) together with

Re: adduser/passwd: too long username

2014-08-21 Thread Laszlo Papp
On Thu, Aug 21, 2014 at 7:37 AM, Natanael Copa nc...@alpinelinux.org wrote: On Mon, 18 Aug 2014 20:37:00 +0200 Natanael Copa nc...@alpinelinux.org wrote: I never sent those patches upstream because I don't think this is the correct fix. For Alpine Linux the correct fix was to use the libc

Re: adduser/passwd: too long username

2014-08-21 Thread Laszlo Papp
On Thu, Aug 21, 2014 at 10:10 PM, Natanael Copa n...@tanael.org wrote: Den 21. aug. 2014 kl. 08:42 skrev Laszlo Papp lp...@kde.org: On Thu, Aug 21, 2014 at 7:37 AM, Natanael Copa nc...@alpinelinux.org wrote: On Mon, 18 Aug 2014 20:37:00 +0200 Natanael Copa nc...@alpinelinux.org wrote: I

Re: adduser/passwd: too long username

2014-08-18 Thread Denys Vlasenko
On Sun, Aug 17, 2014 at 12:48 PM, Laszlo Papp lp...@kde.org wrote: On Tue, Aug 5, 2014 at 8:34 PM, Laszlo Papp lp...@kde.org wrote: On Tue, Aug 5, 2014 at 7:16 PM, Denys Vlasenko vda.li...@googlemail.com wrote: On Mon, Aug 4, 2014 at 7:06 PM, Laszlo Papp lp...@kde.org wrote: sudo

Re: adduser/passwd: too long username

2014-08-18 Thread Laszlo Papp
On Mon, Aug 18, 2014 at 2:12 PM, Denys Vlasenko vda.li...@googlemail.com wrote: On Sun, Aug 17, 2014 at 12:48 PM, Laszlo Papp lp...@kde.org wrote: On Tue, Aug 5, 2014 at 8:34 PM, Laszlo Papp lp...@kde.org wrote: On Tue, Aug 5, 2014 at 7:16 PM, Denys Vlasenko

Re: adduser/passwd: too long username

2014-08-18 Thread Denys Vlasenko
On Mon, Aug 18, 2014 at 3:17 PM, Laszlo Papp lp...@kde.org wrote: Denys, this fix was sent two weeks ago? Why have you not applied it until there is a better fix (if any)? This is still broken and results a system with potential stray users around. I'm having bad feelings about the fix

Re: adduser/passwd: too long username

2014-08-18 Thread Laszlo Papp
On Mon, Aug 18, 2014 at 2:37 PM, Denys Vlasenko vda.li...@googlemail.com wrote: On Mon, Aug 18, 2014 at 3:17 PM, Laszlo Papp lp...@kde.org wrote: Denys, this fix was sent two weeks ago? Why have you not applied it until there is a better fix (if any)? This is still broken and results a

Re: adduser/passwd: too long username

2014-08-18 Thread Laszlo Papp
On Mon, Aug 18, 2014 at 2:40 PM, Laszlo Papp lp...@kde.org wrote: On Mon, Aug 18, 2014 at 2:37 PM, Denys Vlasenko vda.li...@googlemail.com wrote: On Mon, Aug 18, 2014 at 3:17 PM, Laszlo Papp lp...@kde.org wrote: Denys, this fix was sent two weeks ago? Why have you not applied it until

Re: adduser/passwd: too long username

2014-08-18 Thread Natanael Copa
On Mon, 18 Aug 2014 15:37:46 +0200 Denys Vlasenko vda.li...@googlemail.com wrote: On Mon, Aug 18, 2014 at 3:17 PM, Laszlo Papp lp...@kde.org wrote: Denys, this fix was sent two weeks ago? Why have you not applied it until there is a better fix (if any)? This is still broken and results

Re: adduser/passwd: too long username

2014-08-18 Thread tito
On Monday 18 August 2014 15:12:33 Denys Vlasenko wrote: On Sun, Aug 17, 2014 at 12:48 PM, Laszlo Papp lp...@kde.org wrote: On Tue, Aug 5, 2014 at 8:34 PM, Laszlo Papp lp...@kde.org wrote: On Tue, Aug 5, 2014 at 7:16 PM, Denys Vlasenko vda.li...@googlemail.com wrote: On Mon, Aug

Re: adduser/passwd: too long username

2014-08-18 Thread Laszlo Papp
On Mon, Aug 18, 2014 at 7:37 PM, Natanael Copa nc...@alpinelinux.org wrote: On Mon, 18 Aug 2014 15:37:46 +0200 Denys Vlasenko vda.li...@googlemail.com wrote: On Mon, Aug 18, 2014 at 3:17 PM, Laszlo Papp lp...@kde.org wrote: Denys, this fix was sent two weeks ago? Why have you not applied

Re: adduser/passwd: too long username

2014-08-17 Thread Laszlo Papp
On Tue, Aug 5, 2014 at 8:34 PM, Laszlo Papp lp...@kde.org wrote: On Tue, Aug 5, 2014 at 7:16 PM, Denys Vlasenko vda.li...@googlemail.com wrote: On Mon, Aug 4, 2014 at 7:06 PM, Laszlo Papp lp...@kde.org wrote: sudo busybox adduser

Re: adduser/passwd: too long username

2014-08-05 Thread Laszlo Papp
Yeah, mayhaps... Thanks for the prompt reply. I tried to debug the code, but the busybox code here is a bit messy heavily abusing macros in C and all that. It ain't easy I must confess! For instance, see this section: http://git.busybox.net/busybox/tree/libpwdgrp/pwd_grp.c#n227 The _source_ is

Re: adduser/passwd: too long username

2014-08-05 Thread Laszlo Papp
Here is my tested fix without being to debug the busybox code, so only code reading and understanding were my friends: commit 9610650b6ce2a4c1904f78a2dcdb47cad3d2e3d1 Author: Laszlo Papp lp...@kde.org Date: Tue Aug 5 11:42:24 2014 +0100 Allow 256 bytes long usernames as per Unix standards

Re: adduser/passwd: too long username

2014-08-05 Thread tito
On Tuesday 05 August 2014 12:46:08 you wrote: Here is my tested fix without being to debug the busybox code, so only code reading and understanding were my friends: commit 9610650b6ce2a4c1904f78a2dcdb47cad3d2e3d1 Author: Laszlo Papp lp...@kde.org Date: Tue Aug 5 11:42:24 2014 +0100

Re: adduser/passwd: too long username

2014-08-05 Thread Laszlo Papp
I disagree. There is nothing to reject here. It fixes _my issue_ at hand. If you want to fix other bugs in your system that you are facing in reality, by all means, fix them in a separate change. I definitely do not agree with dynamically allocated buffer for the simple reasons of: 1) Slow. 2)

Re: adduser/passwd: too long username

2014-08-05 Thread tito
On Tuesday 05 August 2014 14:27:57 you wrote: I disagree. There is nothing to reject here. It fixes _my issue_ at hand. If you want to fix other bugs in your system that you are facing in reality, by all means, fix them in a separate change. I definitely do not agree with dynamically

Re: adduser/passwd: too long username

2014-08-05 Thread Laszlo Papp
On Tue, Aug 5, 2014 at 1:42 PM, tito farmat...@tiscali.it wrote: On Tuesday 05 August 2014 14:27:57 you wrote: I disagree. There is nothing to reject here. It fixes _my issue_ at hand. If you want to fix other bugs in your system that you are facing in reality, by all means, fix them in a

Re: adduser/passwd: too long username

2014-08-05 Thread tito
On Tuesday 05 August 2014 14:47:53 you wrote: On Tue, Aug 5, 2014 at 1:42 PM, tito farmat...@tiscali.it wrote: On Tuesday 05 August 2014 14:27:57 you wrote: I disagree. There is nothing to reject here. It fixes _my issue_ at hand. If you want to fix other bugs in your system that you

Re: adduser/passwd: too long username

2014-08-05 Thread Laszlo Papp
On Tue, Aug 5, 2014 at 2:06 PM, tito farmat...@tiscali.it wrote: On Tuesday 05 August 2014 14:47:53 you wrote: On Tue, Aug 5, 2014 at 1:42 PM, tito farmat...@tiscali.it wrote: On Tuesday 05 August 2014 14:27:57 you wrote: I disagree. There is nothing to reject here. It fixes _my

Re: adduser/passwd: too long username

2014-08-05 Thread Laszlo Papp
On Tue, Aug 5, 2014 at 2:14 PM, Laszlo Papp lp...@kde.org wrote: On Tue, Aug 5, 2014 at 2:06 PM, tito farmat...@tiscali.it wrote: On Tuesday 05 August 2014 14:47:53 you wrote: On Tue, Aug 5, 2014 at 1:42 PM, tito farmat...@tiscali.it wrote: On Tuesday 05 August 2014 14:27:57 you

Re: adduser/passwd: too long username

2014-08-05 Thread tito
On Tuesday 05 August 2014 15:21:49 you wrote: On Tue, Aug 5, 2014 at 2:14 PM, Laszlo Papp lp...@kde.org wrote: On Tue, Aug 5, 2014 at 2:06 PM, tito farmat...@tiscali.it wrote: On Tuesday 05 August 2014 14:47:53 you wrote: On Tue, Aug 5, 2014 at 1:42 PM, tito farmat...@tiscali.it

Re: adduser/passwd: too long username

2014-08-05 Thread Laszlo Papp
On Tue, Aug 5, 2014 at 3:06 PM, tito farmat...@tiscali.it wrote: On Tuesday 05 August 2014 15:21:49 you wrote: On Tue, Aug 5, 2014 at 2:14 PM, Laszlo Papp lp...@kde.org wrote: On Tue, Aug 5, 2014 at 2:06 PM, tito farmat...@tiscali.it wrote: On Tuesday 05 August 2014

Re: adduser/passwd: too long username

2014-08-05 Thread Laszlo Papp
On Tue, Aug 5, 2014 at 3:13 PM, Laszlo Papp lp...@kde.org wrote: On Tue, Aug 5, 2014 at 3:06 PM, tito farmat...@tiscali.it wrote: On Tuesday 05 August 2014 15:21:49 you wrote: On Tue, Aug 5, 2014 at 2:14 PM, Laszlo Papp lp...@kde.org wrote: On Tue, Aug 5, 2014 at 2:06 PM,

Re: adduser/passwd: too long username

2014-08-05 Thread Laszlo Papp
commit 980965767ef3ace983746ee25e92665b87d16755 Author: Laszlo Papp lp...@kde.org Date: Tue Aug 5 11:42:24 2014 +0100 Allow 256 bytes long usernames as per Unix standards (usually) diff --git a/libpwdgrp/pwd_grp.c b/libpwdgrp/pwd_grp.c index 2060d78..9e4424f 100644 ---

Re: adduser/passwd: too long username

2014-08-05 Thread Laszlo Papp
To challenge this a bit further for completeness: the other option would be to limit the username length to 32 or 48 bytes rather than allowing the whole 128-byte desktop-range. 256 does look like a bit excessive that getconf returns: getconf LOGIN_NAME_MAX 256 I find it hard to achieve in even

Re: adduser/passwd: too long username

2014-08-05 Thread Denys Vlasenko
On Mon, Aug 4, 2014 at 7:06 PM, Laszlo Papp lp...@kde.org wrote: sudo busybox adduser f passwd: unknown user

Re: adduser/passwd: too long username

2014-08-05 Thread tito
On Tuesday 05 August 2014 18:09:08 you wrote: To challenge this a bit further for completeness: the other option would be to limit the username length to 32 or 48 bytes rather than allowing the whole 128-byte desktop-range. 256 does look like a bit excessive that getconf returns: getconf

Re: adduser/passwd: too long username

2014-08-05 Thread tito
On Tuesday 05 August 2014 17:05:11 you wrote: On Tue, Aug 5, 2014 at 3:13 PM, Laszlo Papp lp...@kde.org wrote: On Tue, Aug 5, 2014 at 3:06 PM, tito farmat...@tiscali.it wrote: On Tuesday 05 August 2014 15:21:49 you wrote: On Tue, Aug 5, 2014 at 2:14 PM, Laszlo Papp lp...@kde.org

Re: adduser/passwd: too long username

2014-08-05 Thread Laszlo Papp
it will be / only in case the home dir does not exist at login time as the login program does chdir to the home That is what the linked page also says, yes. dir else you would be locked out of a broken system (damaged partition mounted to /home, /root folder corrupted on main file

Re: adduser/passwd: too long username

2014-08-05 Thread Laszlo Papp
On Tue, Aug 5, 2014 at 8:24 PM, tito farmat...@tiscali.it wrote: On Tuesday 05 August 2014 18:09:08 you wrote: To challenge this a bit further for completeness: the other option would be to limit the username length to 32 or 48 bytes rather than allowing the whole 128-byte desktop-range.

adduser/passwd: too long username

2014-08-04 Thread Laszlo Papp
Hi, sudo busybox adduser f passwd: unknown user f Yet,

Re: adduser/passwd: too long username

2014-08-04 Thread tito
On Monday 04 August 2014 19:06:39 Laszlo Papp wrote: Hi, sudo busybox adduser f passwd: unknown user