Re: [PATCH 2/3] library init: documentation update

2013-04-22 Thread Alexander Klauer
Hi, On 03/18/2013 09:26 AM, Alexander Klauer wrote: OK, I've updated the commit. sorry for being a pest, but this patchset still has not made it into the master branch at https://github.com/bagder/c-ares/commits/master. Is there still something wrong with it? What can I do to help? Best

Re: [PATCH 2/3] library init: documentation update

2013-04-10 Thread Alexander Klauer
On 03/18/2013 09:26 AM, Alexander Klauer wrote: On 03/15/2013 08:26 PM, Yang Tse wrote: On Fri, Mar 15, 2013, Alexander Klauer alexander.kla...@itwm.fraunhofer.de wrote: This commit updates the documentation of ares_library_init() and ares_library_cleanup() with regard to the new recursive

Re: [PATCH 2/3] library init: documentation update

2013-04-10 Thread Alexander Klauer
Hi, no need to CC me, I'm subscribed. On 04/10/2013 10:44 AM, Saúl Ibarra Corretgé wrote: On 4/10/13 10:03 AM, Alexander Klauer wrote: On 03/18/2013 09:26 AM, Alexander Klauer wrote: On 03/15/2013 08:26 PM, Yang Tse wrote: On Fri, Mar 15, 2013, Alexander Klauer alexander.kla

Re: [PATCH 2/3] library init: documentation update

2013-04-10 Thread Alexander Klauer
On 04/10/2013 11:07 AM, Alexander Klauer wrote: Hi, no need to CC me, I'm subscribed. On 04/10/2013 10:44 AM, Saúl Ibarra Corretgé wrote: On 4/10/13 10:03 AM, Alexander Klauer wrote: On 03/18/2013 09:26 AM, Alexander Klauer wrote: On 03/15/2013 08:26 PM, Yang Tse wrote: On Fri, Mar 15

[PATCH 3/4] ares_destroy() documentation: no new requests

2013-04-08 Thread Alexander Klauer
Clarify that no new requests may be added to a resolver channel that is currently being destroyed. --- ares_destroy.3 |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ares_destroy.3 b/ares_destroy.3 index 79171ec..3724df1 100644 --- a/ares_destroy.3 +++ b/ares_destroy.3 @@

[PATCH 2/4] Documentation: properly document ARES_ECANCELLED

2013-04-08 Thread Alexander Klauer
This commit clarifies the behaviour of ares_cancel() with respect to callbacks and adds missing documentation of ARES_ECANCELLED to the man pages of the affected functions. --- ares_cancel.3|4 +++- ares_gethostbyaddr.3 |3 +++ ares_gethostbyname.3 |3 +++ ares_getnameinfo.3

[PATCH 1/4] ares_cancel(): cancel requests safely

2013-04-08 Thread Alexander Klauer
An invocation of ares_cancel() walks through the request list, calling the callbacks of all pending requests on a channel. Previously, if such a callback added a new request to the channel, the request list might not end up empty, causing an abort by assertion failure. The present commit ensures

Cosmetic bugs in http://c-ares.haxx.se/ares_parse_a_reply.html and http://c-ares.haxx.se/ares_parse_aaaa_reply.html

2013-03-21 Thread Alexander Klauer
Hi, in the HTML pages mentioned in the subject, there are spurious '\fB' sequences in the synopses. Possibly they have to be changed to '\fP' in the source man pages, but I don't know enough roff to say for sure. Best regards, Alexander -- Dr. Alexander Klauer Competence Centre for High

[PATCH 1/4] ares_cancel(): ensure cancellation of all requests

2013-03-21 Thread Alexander Klauer
An invocation of ares_cancel() walks through the request list, calling the callbacks of all pending requests on a channel. Previously, if such a callback added a new request to the channel, the request list might not end up empty, causing an abort by assertion failure. The present commit ensures

[PATCH 3/4] ares_destroy() documentation: no new requests

2013-03-21 Thread Alexander Klauer
Clarify that no new requests may be added to a resolver channel that is currently being destroyed. --- ares_destroy.3 |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ares_destroy.3 b/ares_destroy.3 index 79171ec..3724df1 100644 --- a/ares_destroy.3 +++ b/ares_destroy.3 @@

Re: [PATCH 1/4] ares_cancel(): ensure cancellation of all requests

2013-03-21 Thread Alexander Klauer
On 03/21/2013 11:45 AM, Tommie Gannert wrote: 2013/3/21 Alexander Klauer alexander.kla...@itwm.fraunhofer.de: An invocation of ares_cancel() walks through the request list, calling the callbacks of all pending requests on a channel. Previously, if such a callback added a new request

[PATCH 2/3] library init: documentation update

2013-03-18 Thread Alexander Klauer
This commit updates the documentation of ares_library_init() and ares_library_cleanup() with regard to the newly introduced reference counting of initializations and deinitializations. --- ares_library_cleanup.3 | 19 --- ares_library_init.3| 18 -- 2 files

Re: [PATCH 2/3] library init: documentation update

2013-03-18 Thread Alexander Klauer
On 03/15/2013 08:26 PM, Yang Tse wrote: On Fri, Mar 15, 2013, Alexander Klauer alexander.kla...@itwm.fraunhofer.de wrote: This commit updates the documentation of ares_library_init() and ares_library_cleanup() with regard to the new recursive behaviour. It might be better to use Its

[PATCH] library init: be recursive

2013-03-15 Thread Alexander Klauer
Previously, a single call to ares_library_cleanup() would deinitialise the c-ares library, regardless of how many times ares_library_init() was called. This behaviour may cause problems in programs linking two or more libraries which, in turn, use c-ares. The present commit fixes this problem,

[PATCH 3/3] .gitignore: ignore patch files

2013-03-15 Thread Alexander Klauer
This commit adds a line to .gitignore to the effect that patch files generated by 'git format-patch' are excluded from the repository. --- .gitignore |1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 19a0eae..0b1087a 100644 --- a/.gitignore +++ b/.gitignore @@

[PATCH 2/3] library init: documentation update

2013-03-15 Thread Alexander Klauer
This commit updates the documentation of ares_library_init() and ares_library_cleanup() with regard to the new recursive behaviour. --- ares_library_cleanup.3 | 18 +++--- ares_library_init.3| 18 -- 2 files changed, 27 insertions(+), 9 deletions(-) diff --git