Re: [Carbon-dev] [Code review] Data services - Notes

2010-09-23 Thread Afkham Azeez
Overall the code was very good but there are some areas which we can improve on. In summary, the code should be better organized so that the edge cases do not affect the understandability of the code. We saw several instances where the same method was called with different param values (e.g. pref

[Carbon-dev] [Code review] Data services - Notes

2010-09-23 Thread Amani Soysa
Code Review Notes - Consider generating a single operation for batch request operations other than getting two operations when needed. - isBatchRequest -DBUtils.setBatchProcessing(true) ---> should not set flags like this. (it should be like start begin transaction, commit and abort