Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-29 Thread Oliver Gorwits
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Guillermo Roditi wrote: > Catalyst::Plugin::HashedCookies calls > Catalyst::Request->make_accessor, which in some ways is quite > broken (as you're re-opening the package from outside), but it > isn't actually very hard to fix/support.. > > Yeah, tha

Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-29 Thread Tomas Doran
On 29 Dec 2008, at 16:40, Guillermo Roditi wrote: HTML::Widget uses Class::Accessor::Chained::Fast, which overrides make_accessor. As mk_accessors no longer uses make_accessor to generate the coderef, this breaks horribly... Uhm. wontfix? I don't even know how it would be possible to fix

Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-29 Thread Guillermo Roditi
> I've found some plugins which call mk_accessors more than once for the same > attribute / package, which fails. > > This is because, on the second application, the attribute is added with no > options, which results in the accessor methods for it being removed. Please > find test attached. > Fix

Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-29 Thread Guillermo Roditi
> > Catalyst::Plugin::HashedCookies calls Catalyst::Request->make_accessor, > which in some ways is quite broken (as you're re-opening the package from > outside), but it isn't actually very hard to fix/support.. > Yeah, that's totally broken and I don't even know if we want to support this kind o

Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-29 Thread Guillermo Roditi
> > HTML::Widget uses Class::Accessor::Chained::Fast, which overrides > make_accessor. As mk_accessors no longer uses make_accessor to generate the > coderef, this breaks horribly... > Uhm. wontfix? I don't even know how it would be possible to fix this. We'll stop using Adopt::CAF by default, whi

Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-29 Thread Tomas Doran
On 5 Dec 2008, at 23:00, Guillermo Roditi wrote: I think the trunk version fixes all your problems, but nobody has been able to accurately describe their problems or produce a simple failing test case. I've found another one - if you assign a list to a CAF accessor, then it packs the argu

Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-27 Thread Tomas Doran
On 5 Dec 2008, at 23:00, Guillermo Roditi wrote: I think the trunk version fixes all your problems, but nobody has been able to accurately describe their problems or produce a simple failing test case. I've found some plugins which call mk_accessors more than once for the same attribute

Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-27 Thread Tomas Doran
On 5 Dec 2008, at 23:00, Guillermo Roditi wrote: All of you who have experienced errors rooted in MooseX::Emulate/ Adopt::Class::Accessor::Fast please please please send me error messages and show me the code that breaks. Catalyst::Plugin::HashedCookies calls Catalyst::Request- >make_acces

Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-27 Thread Tomas Doran
On 5 Dec 2008, at 23:00, Guillermo Roditi wrote: I think the trunk version fixes all your problems, but nobody has been able to accurately describe their problems or produce a simple failing test case. HTML::Widget uses Class::Accessor::Chained::Fast, which overrides make_accessor. As mk_a

Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-17 Thread Tomas Doran
On 14 Dec 2008, at 16:23, Chisel Wright wrote: On Sun, Dec 14, 2008 at 01:47:03AM +, Tomas Doran wrote: I in no way think it is related, but can you try upgrading to the latest Moose just in case this solves your issue? I don't get the same level of FAIL after upgrading to 0.63. The ap

Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-17 Thread Tomas Doran
On 17 Dec 2008, at 15:30, Carl Franks wrote: Patch is attached. Applied as r8907, thanks once again. t0m ___ List: Catalyst@lists.scsys.co.uk Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst Searchable archive: http://www.mail-ar

Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-17 Thread Andy Grundman
On Dec 17, 2008, at 10:30 AM, Carl Franks wrote: 2008/12/17 Tomas Doran : On 17 Dec 2008, at 14:52, Carl Franks wrote: Can you try trunk, as I think this issue is already fixed there? Confirmed working - many thanks. No problem. There isn't a failing test for this - I just changed it b

Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-17 Thread Carl Franks
2008/12/17 Tomas Doran : > > On 17 Dec 2008, at 14:52, Carl Franks wrote: >>> >>> Can you try trunk, as I think this issue is already fixed there? >> >> Confirmed working - many thanks. > > No problem. > > There isn't a failing test for this - I just changed it because it looked > 'more right' and

Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-17 Thread Tomas Doran
On 17 Dec 2008, at 14:52, Carl Franks wrote: Can you try trunk, as I think this issue is already fixed there? Confirmed working - many thanks. No problem. There isn't a failing test for this - I just changed it because it looked 'more right' and didn't break anything. Fancy attempting

Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-17 Thread Carl Franks
2008/12/17 Tomas Doran : > > On 17 Dec 2008, at 09:16, Carl Franks wrote: >> >> I've just tested 5.8000_04 against a couple of my applications, and >> found that basename() on Catalyst::Request::Upload objects returns >> undef. >> >> A brief look at the source leads me to believe the line: >>ha

Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-17 Thread Tomas Doran
On 17 Dec 2008, at 09:16, Carl Franks wrote: I've just tested 5.8000_04 against a couple of my applications, and found that basename() on Catalyst::Request::Upload objects returns undef. A brief look at the source leads me to believe the line: has basename => (is => 'rw'); is overriding the

Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-17 Thread Carl Franks
2008/12/5 Marcus Ramberg : > That is why we would like for you to try it out, and > tell us what breaks on your apps (If you don't, we will happily ignore your > anguished cries later (Well, probably not, but please test it anyways!)) I've just tested 5.8000_04 against a couple of my applications

Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-17 Thread Tomas Doran
On 16 Dec 2008, at 22:12, Oleg Pronin wrote: 5.8 brakes Catalyst::Authentication::Credential::Password? Are you using old style authentication? I.e. Do you have 'Authentication::Credential::Password' in the plugin list for MyApp? As if you are, this is a known bug, which we are planning

Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-16 Thread Oleg Pronin
5.8 brakes Catalyst::Authentication::Credential::Password? Can't use string ("MyApp") as a HASH ref while "strict refs" in use at (eval 340)[/usr/local/lib/perl5/site_perl/5.10.0/Moose/Meta/Method/Accessor.pm:35] line 13. at (eval 340)[/usr/local/lib/perl5/site_perl/5.10.0/Moose/Meta/Method/Acces

Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-14 Thread Chisel Wright
On Sun, Dec 14, 2008 at 01:47:03AM +, Tomas Doran wrote: > I in no way think it is related, but can you try upgrading to the latest > Moose just in case this solves your issue? I don't get the same level of FAIL after upgrading to 0.63. The app appears to be behaving as I'd expect it to. The

Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-13 Thread Tomas Doran
On 9 Dec 2008, at 10:10, Chisel Wright wrote: On Tue, Dec 09, 2008 at 08:30:10AM +, Tomas Doran wrote: What versions of Moose and Class::MOP are you running? 0.60 and 0.68 respectively I in no way think it is related, but can you try upgrading to the latest Moose just in case this s

Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-10 Thread Tomas Doran
On 10 Dec 2008, at 20:20, Guillermo Roditi wrote: So, problem resolved, fix known. will fix and release when i have some time. some time later this week, maybe next. Awesome, thanks. t0m ___ List: Catalyst@lists.scsys.co.uk Listinfo: http://lists.

Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-10 Thread Guillermo Roditi
On Tue, Dec 9, 2008 at 9:35 AM, Tomas Doran <[EMAIL PROTECTED]> wrote: > > I agree that all 'real' Moose classes shouldn't be breaking the meta method > like this, but the fact is that there *IS* real code out there which is > going to be broken by this, and it's something which we can _avoid_ bre

Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-09 Thread Tomas Doran
On 9 Dec 2008, at 12:46, Guillermo Roditi wrote: On Sun, Dec 7, 2008 at 4:38 PM, Tomas Doran <[EMAIL PROTECTED]> wrote: Please find attached a simple test case for the behavior needed by Catalyst::Plugin::Cache::Curried (and anything else which says __PACKAGE__->mk_accessors(qw/ meta /))

Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-09 Thread Guillermo Roditi
On Sun, Dec 7, 2008 at 4:38 PM, Tomas Doran <[EMAIL PROTECTED]> wrote: > > Please find attached a simple test case for the behavior needed by > Catalyst::Plugin::Cache::Curried (and anything else which says > __PACKAGE__->mk_accessors(qw/ meta /)) - found by looking at MojoMojo's > current test fa

Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-09 Thread Guillermo Roditi
On Sun, Dec 7, 2008 at 1:47 PM, Tomas Doran <[EMAIL PROTECTED]> wrote: > > I'm not sure if the correct fix for the lies in Catalyst, or MX::E::CAF, > but: > > http://dev.catalystframework.org/svnweb/Catalyst/revision?rev=8781 > > is the minimal test case I've been able to produce for the breakage

Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-09 Thread Chisel Wright
On Tue, Dec 09, 2008 at 08:30:10AM +, Tomas Doran wrote: > What versions of Moose and Class::MOP are you running? 0.60 and 0.68 respectively (from perldoc -m Foo |grep VERSION) I'll see if I can find somewhere to actually install Catalyst-Runtime properly, rather than just using a path hack.

Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-09 Thread Tomas Doran
On 8 Dec 2008, at 22:07, Chisel Wright wrote: MyApp is fine under 5.7014, starting it with: PERL5LIB=${HOME}/development/open_source/dev-tests/Catalyst- Runtime-5.8000_04/lib CATALYST_DEBUG=1 DBIC_TRACE=1 ./script/parley_server.pl --host=localhost -r -rd 2 --port=3000 any hits to the a

Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-08 Thread Tomas Doran
On 8 Dec 2008, at 23:15, Bill Moseley wrote: This suppose to be drop-in compatible with 5.7? That's the aim, although we're probably not there yet.. perl, v5.10.0 All tests pass building Catalyst-Runtime but it's very noisy: Subroutine uninitialize redefined at /usr/share/perl5/Class/C3.p

Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-08 Thread Bill Moseley
This suppose to be drop-in compatible with 5.7? http://search.cpan.org/CPAN/authors/id/M/MR/MRAMBERG/Catalyst-Runtime-5.8000_04.tar.gz perl, v5.10.0 All tests pass building Catalyst-Runtime but it's very noisy: Subroutine uninitialize redefined at /usr/share/perl5/Class/C3.pm line 88. Subroutin

Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-08 Thread Chisel Wright
On Fri, Dec 05, 2008 at 04:25:49PM +0100, Marcus Ramberg wrote: >There are still a few problems to solve before the next stable CPAN >release (Some of the plugins are still failing tests, most notoriously the >backwards compatibility tests of Catalyst-Plugin-Authentication), but >Ca

Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-07 Thread Tomas Doran
On 5 Dec 2008, at 23:00, Guillermo Roditi wrote: I think the trunk version fixes all your problems, but nobody has been able to accurately describe their problems or produce a simple failing test case. So, if my code is breaking your code, holla back! Please find attached a simple test ca

Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-07 Thread Tomas Doran
On 5 Dec 2008, at 23:00, Guillermo Roditi wrote: All of you who have experienced errors rooted in MooseX::Emulate/ Adopt::Class::Accessor::Fast please please please send me error messages and show me the code that breaks. I think the trunk version fixes all your problems, but nobody has b

Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-05 Thread Guillermo Roditi
All of you who have experienced errors rooted in MooseX::Emulate/Adopt::Class::Accessor::Fast please please please send me error messages and show me the code that breaks. I think the trunk version fixes all your problems, but nobody has been able to accurately describe their problems or produce a

[Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-05 Thread Marcus Ramberg
After hours and hours of panic, despair, hair hugging and straight procrastination, we have finally managed to produce a Catalyst-Runtime distribution that a) Has a Moose b) Performs similarly to the previous stable version, and most importantly c) Works with the old 5.7 based applications. d) Has