Re: [Catalyst] Tests fail installing Catalyst::Controller::FormBuilder [patches attached]

2009-05-08 Thread Tomas Doran
Chisel Wright wrote: Attempt #2 attached - I think it covers everything mentioned above. Tests still pass. Running the patch from the top level with -p 1 should work: Nice one, applied with tiny changes as r10052. Cheers t0m ___ List:

Re: [Catalyst] Tests fail installing Catalyst::Controller::FormBuilder [patches attached]

2009-05-08 Thread Tomas Doran
Tomas Doran wrote: Nice one, applied with tiny changes as r10052. And shipped as 0.05. Cheers t0m ___ List: Catalyst@lists.scsys.co.uk Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst Searchable archive:

Re: [Catalyst] Tests fail installing Catalyst::Controller::FormBuilder [patches attached]

2009-05-07 Thread Tomas Doran
Chisel Wright wrote: I've attached three patches: Nice work :) For future, patches are possibly best from the top of the distribution, so that you can just apply them from there without having to work out where to cd into (for your patches, I had to cd lib, then patch, then cd ../t, then

Re: [Catalyst] Tests fail installing Catalyst::Controller::FormBuilder [patches attached]

2009-05-07 Thread Tomas Doran
Tomas Doran wrote: Chisel Wright wrote: - one for View::HTML::Template to deal with the Catalyst::Base warning Committed as r10042. And marcus has sent this to CPAN as 0.03. Cheers t0m ___ List: Catalyst@lists.scsys.co.uk Listinfo:

Re: [Catalyst] Tests fail installing Catalyst::Controller::FormBuilder [patches attached]

2009-05-07 Thread Chisel Wright
On Thu, May 07, 2009 at 02:45:09PM +0100, Tomas Doran wrote: Chisel Wright wrote: I've attached three patches: Nice work :) For future, patches are possibly best from the top of the distribution, so that you can just apply them from there without having to work out where to cd into

Re: [Catalyst] Tests fail installing Catalyst::Controller::FormBuilder [patches attached]

2009-05-07 Thread Chisel Wright
On Thu, May 07, 2009 at 02:45:09PM +0100, Tomas Doran wrote: You should just be able to remove the accessor module from the inheritance here. A lot of your changes change NEXT::foo = next::method. Do you really mean that, or do you mean maybe::next::method? (especially the one where

Re: [Catalyst] Tests fail installing Catalyst::Controller::FormBuilder

2009-05-06 Thread Chisel Wright
On Wed, May 06, 2009 at 12:29:55AM +0100, Tomas Doran wrote: You have fixes. Please commit them somewhere and we can get a development release out (at least). OK, I should be able to pick this up tonight. I'll drop a patch here when I'm done. -- Chisel Wright e: chi...@herlpacker.co.uk w:

Re: [Catalyst] Tests fail installing Catalyst::Controller::FormBuilder [patches attached]

2009-05-06 Thread Chisel Wright
On Wed, May 06, 2009 at 10:09:17AM +0100, Chisel Wright wrote: OK, I should be able to pick this up tonight. I'll drop a patch here when I'm done. I've attached three patches: - one for the TestApp/Component/* issue - one for Formbuilder::Action (it's not happy with Class::Accessor::Fast)

[Catalyst] Tests fail installing Catalyst::Controller::FormBuilder

2009-05-05 Thread Louis Erickson
While trying to install Catalyst::Controller::FormBuilder, we got some fairly annoying and significant looking errors. We're installing on OS X 10.5. This was working on a 10.4 machine, and we got catalyst-devel to install cleanly on 10.5. The tests give a big chunk of errors... I'm not sure

Re: [Catalyst] Tests fail installing Catalyst::Controller::FormBuilder

2009-05-05 Thread Peter Karman
Louis Erickson wrote on 5/5/09 1:46 PM: While trying to install Catalyst::Controller::FormBuilder, we got some fairly annoying and significant looking errors. We're installing on OS X 10.5. This was working on a 10.4 machine, and we got catalyst-devel to install cleanly on 10.5. The

Re: [Catalyst] Tests fail installing Catalyst::Controller::FormBuilder

2009-05-05 Thread Chisel Wright
On Tue, May 05, 2009 at 11:46:49AM -0700, Louis Erickson wrote: t/01-basic.TestApp::Component::TT is trying to use NEXT, which is deprecated. Please see the Class::C3::Adopt::NEXT documentation for details at /Users/davebowers/.cpan/build/Catalyst-Controller-FormBuilder-0.04/t/lib/Tes

Re: [Catalyst] Tests fail installing Catalyst::Controller::FormBuilder

2009-05-05 Thread Louis Erickson
On Tue, 5 May 2009, Peter Karman wrote: downgrade to Catalyst::Runtime 5.7 to start with. those errors look like 5.8 incompat issues. Yes, they do. I have the complete set of modules running on 5.8 on another machine. There's two main differences that I can think of. 1 It was an upgrade

Re: [Catalyst] Tests fail installing Catalyst::Controller::FormBuilder

2009-05-05 Thread Tomas Doran
On 5 May 2009, at 22:05, Chisel Wright wrote: On Tue, May 05, 2009 at 11:46:49AM -0700, Louis Erickson wrote: t/01-basic.TestApp::Component::TT is trying to use NEXT, which is deprecated. Please see the Class::C3::Adopt::NEXT documentation for details at

Re: [Catalyst] Tests fail installing Catalyst::Controller::FormBuilder

2009-05-05 Thread Peter Karman
Louis Erickson wrote on 5/5/09 5:08 PM: On Tue, 5 May 2009, Peter Karman wrote: downgrade to Catalyst::Runtime 5.7 to start with. those errors look like 5.8 incompat issues. Yes, they do. I have the complete set of modules running on 5.8 on another machine. There's two main differences