New Defects reported by Coverity Scan for ceph (fwd)

2014-10-08 Thread Sage Weil
---BeginMessage--- Hi, Please find the latest report on new defect(s) introduced to ceph found with Coverity Scan. 6 new defect(s) introduced to ceph found with Coverity Scan. 3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New Defects reported by Coverity Scan for ceph (fwd)

2014-09-30 Thread Sage Weil
Looks like recent changes from Greg, Loic, and I.---BeginMessage--- Hi, Please find the latest report on new defect(s) introduced to ceph found with Coverity Scan. Defect(s) Reported-by: Coverity Scan Showing 4 of 4 defect(s) ** CID 1242019: Data race condition (MISSING_LOCK)

Re: New Defects reported by Coverity Scan for ceph (fwd)

2014-09-30 Thread Loic Dachary
I'll fix the aio.cc problems, thanks ! On 30/09/2014 15:59, Sage Weil wrote: Looks like recent changes from Greg, Loic, and I. -- Loïc Dachary, Artisan Logiciel Libre signature.asc Description: OpenPGP digital signature

Re: New Defects reported by Coverity Scan for ceph (fwd)

2014-09-30 Thread Gregory Farnum
On Tue, Sep 30, 2014 at 6:59 AM, Sage Weil sw...@redhat.com wrote: Looks like recent changes from Greg, Loic, and I. -- Forwarded message -- From: scan-ad...@coverity.com To: undisclosed-recipients:; Cc: Date: Tue, 30 Sep 2014 06:21:08 -0700 Subject: New Defects reported by

Re: New Defects reported by Coverity Scan for ceph (fwd)

2014-09-30 Thread Sage Weil
On Tue, 30 Sep 2014, Gregory Farnum wrote: On Tue, Sep 30, 2014 at 6:59 AM, Sage Weil sw...@redhat.com wrote: Looks like recent changes from Greg, Loic, and I. -- Forwarded message -- From: scan-ad...@coverity.com To: undisclosed-recipients:; Cc: Date: Tue, 30 Sep

Re: New Defects reported by Coverity Scan for ceph (fwd)

2014-09-30 Thread Ric Wheeler
On 09/30/2014 01:38 PM, Sage Weil wrote: On Tue, 30 Sep 2014, Gregory Farnum wrote: On Tue, Sep 30, 2014 at 6:59 AM, Sage Weil sw...@redhat.com wrote: Looks like recent changes from Greg, Loic, and I. -- Forwarded message -- From: scan-ad...@coverity.com To:

New Defects reported by Coverity Scan for ceph (fwd)

2014-09-25 Thread Sage Weil
---BeginMessage--- Hi, Please find the latest report on new defect(s) introduced to ceph found with Coverity Scan. Defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1241497: Thread deadlock (ORDER_REVERSAL)

Re: New Defects reported by Coverity Scan for ceph (fwd)

2014-09-25 Thread John Spray
Nice to see that coverity and lockdep agree :-) This should go away with the fix for #9562. John On Thu, Sep 25, 2014 at 4:02 PM, Sage Weil sw...@redhat.com wrote: -- Forwarded message -- From: scan-ad...@coverity.com To: undisclosed-recipients:; Cc: Date: Thu, 25 Sep

New Defects reported by Coverity Scan for ceph (fwd)

2014-09-16 Thread Sage Weil
---BeginMessage--- Hi, Please find the latest report on new defect(s) introduced to ceph found with Coverity Scan. Defect(s) Reported-by: Coverity Scan Showing 20 of 38 defect(s) ** CID 717233: Uninitialized scalar field (UNINIT_CTOR) /mds/Capability.h: 249 in

New Defects reported by Coverity Scan for ceph (fwd)

2014-08-23 Thread Sage Weil
---BeginMessage--- Hi, Please find the latest report on new defect(s) introduced to ceph found with Coverity Scan. Defect(s) Reported-by: Coverity Scan Showing 9 of 9 defect(s) ** CID 1232599: Bad bit shift operation (BAD_SHIFT) /os/HashIndex.cc: 433 in

New Defects reported by Coverity Scan for ceph (fwd)

2014-07-10 Thread Sage Weil
---BeginMessage--- Hi, Please find the latest report on new defect(s) introduced to ceph found with Coverity Scan. Defect(s) Reported-by: Coverity Scan Showing 5 of 5 defect(s) ** CID 1201388: Missing unlock (LOCK) /mon/Monitor.cc: 438 in Monitor::preinit()() ** CID 1225099: Unchecked

New Defects reported by Coverity Scan for ceph (fwd)

2014-06-20 Thread Sage Weil
---BeginMessage--- Hi, Please find the latest report on new defect(s) introduced to ceph found with Coverity Scan. Defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1223276: Division or modulo by zero (DIVIDE_BY_ZERO) /tools/rados/rados.cc: 1368 in

Re: New Defects reported by Coverity Scan for ceph (fwd)

2014-06-18 Thread Sebastien Ponce
I've now looked at the defects. And according to me, there are mostly irrelevant. There are 2 cases : - the 2 division by zero will never happen because we will never run the test with a zero parameter. Still, I've added an ASSERT to avoid their report. - all the rest is a clash between gtest

Re: New Defects reported by Coverity Scan for ceph (fwd)

2014-06-08 Thread Sebastien Ponce
Not surprising, this was just integrated and I did not have the possibility to run a coverity scan myself. I'll fix all this. Sebastien On Sat, 2014-06-07 at 09:12 -0700, Sage Weil wrote: Mostly stuff in teh new libradosstriper code, it looks like. -- To unsubscribe from this list: send the

New Defects reported by Coverity Scan for ceph (fwd)

2014-06-07 Thread Sage Weil
Mostly stuff in teh new libradosstriper code, it looks like.---BeginMessage--- Hi, Please find the latest report on new defect(s) introduced to ceph found with Coverity Scan. Defect(s) Reported-by: Coverity Scan Showing 20 of 41 defect(s) ** CID 1221498: Division or modulo by zero

New Defects reported by Coverity Scan for ceph (fwd)

2014-06-06 Thread Sage Weil
---BeginMessage--- Hi, Please find the latest report on new defect(s) introduced to ceph found with Coverity Scan. Defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1220854: Invalid iterator comparison (MISMATCHED_ITERATOR) /osd/PG.cc: 981 in

New Defects reported by Coverity Scan for ceph (fwd)

2014-05-20 Thread Sage Weil
---BeginMessage--- Hi, Please find the latest report on new defect(s) introduced to ceph found with Coverity Scan. Defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1214678: Unchecked return value (CHECKED_RETURN) /osd/OSD.cc: 318 in

New Defects reported by Coverity Scan for ceph (fwd)

2014-04-22 Thread Sage Weil
---BeginMessage--- Hi, Please find the latest report on new defect(s) introduced to ceph found with Coverity Scan. Defect(s) Reported-by: Coverity Scan Showing 4 of 4 defect(s) ** CID 1204293: Buffer not null terminated (BUFFER_SIZE_WARNING) /mds/MDS.cc: 1714 in MDS::respawn()() ** CID

Re: New Defects reported by Coverity Scan for ceph (fwd)

2014-04-12 Thread Loic Dachary
I'll deal with the problems found in gf-complete: http://tracker.ceph.com/issues/8083 On 12/04/2014 06:06, Sage Weil wrote: Several new defects. This wasn't running for the last couple of weeks because the submodules didn't update on the test checkout. -- Loïc Dachary, Artisan Logiciel

New Defects reported by Coverity Scan for ceph (fwd)

2014-04-11 Thread Sage Weil
Several new defects. This wasn't running for the last couple of weeks because the submodules didn't update on the test checkout. ---BeginMessage--- Hi, Please find the latest report on new defect(s) introduced to ceph found with Coverity Scan. Defect(s) Reported-by: Coverity Scan Showing

Re: New Defects reported by Coverity Scan for ceph (fwd)

2014-03-03 Thread John Spray
On Mon, Mar 3, 2014 at 10:23 PM, Sage Weil s...@inktank.com wrote: ** CID 1188299: Data race condition (MISSING_LOCK) /mds/MDSUtility.cc: 142 in MDSUtility::handle_mds_map(MMDSMap *)() Is there a trick to getting coverity to realise that the lock is held, but by the calling function? Does it

Re: New Defects reported by Coverity Scan for ceph (fwd)

2014-03-03 Thread Li Wang
Then it seems that Coverity is only able to perform intra-procedure check, is there any inter-procedure check option to turn on? On 2014/3/4 6:53, John Spray wrote: On Mon, Mar 3, 2014 at 10:23 PM, Sage Weil s...@inktank.com wrote: ** CID 1188299: Data race condition (MISSING_LOCK)

Re: New Defects reported by Coverity Scan for ceph (fwd)

2013-12-17 Thread Ilya Dryomov
On Mon, Dec 16, 2013 at 6:07 PM, Sage Weil s...@inktank.com wrote: -- Forwarded message -- From: scan-ad...@coverity.com To: undisclosed-recipients:; Cc: Date: Mon, 16 Dec 2013 00:57:57 -0800 Subject: New Defects reported by Coverity Scan for ceph Hi, Please find the

New Defects reported by Coverity Scan for ceph (fwd)

2013-12-17 Thread Sage Weil
---BeginMessage--- Hi, Please find the latest report on new defect(s) introduced to ceph found with Coverity Scan. Defect(s) Reported-by: Coverity Scan Showing 7 of 13 defect(s) ** CID 1138583: Dereference null return value (NULL_RETURNS) /mds/MDCache.cc: 5074 in

New Defects reported by Coverity Scan for ceph (fwd)

2013-12-16 Thread Sage Weil
---BeginMessage--- Hi, Please find the latest report on new defect(s) introduced to ceph found with Coverity Scan. Defect(s) Reported-by: Coverity Scan Showing 4 of 4 defect(s) ** CID 1138366: Resource leak (RESOURCE_LEAK) /test/librados/tier.cc: 96 in

New Defects reported by Coverity Scan for ceph (fwd)

2013-08-20 Thread Sage Weil
Coverity picked up some issues with the filestore code. These are mostly old issues that appear new becuase code moved around, but this is probably a good opportunity to fix them... :) sage---BeginMessage--- Hi, Please find the latest report on new defect(s) introduced to ceph found with

New Defects reported by Coverity Scan for ceph (fwd)

2013-07-25 Thread Sage Weil
---BeginMessage--- Hi, Please find the latest report on new defect(s) introduced to ceph found with Coverity Scan Defect(s) Reported-by: Coverity Scan ** CID 1057291: Resource leak (RESOURCE_LEAK) /rgw/rgw_rados.cc: 2643

New Defects reported by Coverity Scan for ceph (fwd)

2013-07-19 Thread Sage Weil
Several new rgw issues from the recent merge...---BeginMessage--- Hi, Please find the latest report on new defect(s) introduced to ceph found with Coverity Scan Defect(s) Reported-by: Coverity Scan Showing 7 of 61 defects ** CID 1049252: Wrapper object use after free (WRAPPER_ESCAPE)

Re: New Defects reported by Coverity Scan for ceph (fwd)

2013-06-19 Thread Loic Dachary
Hi Sage, I believe https://github.com/ceph/ceph/pull/366 fixes the issue. It was introduced by https://github.com/ceph/ceph/commit/b16fdf23e5325623874ee1a02e134f577c5a7dcd#L0R364 which was merged in master yesterday. Cheers On 06/19/2013 09:36 PM, Sage Weil wrote: Dereferencing iterator p