Re: [PATCH] D12358: [Analyzer] Handling constant bound loops

2015-08-28 Thread Ted Kremenek via cfe-commits
Hi Sean, I responded with some more feedback. Conceptually the patch is quite simple, but I think Anna’s points are all spot on. I think we’d all be quite amendable for this work to go in under a flag, with further improvements going in on top of that. That way we can all collectively start

[libcxx] r246280 - Fix most GCC warnings during build. Only -Wattribute left.

2015-08-28 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Aug 28 02:02:42 2015 New Revision: 246280 URL: http://llvm.org/viewvc/llvm-project?rev=246280&view=rev Log: Fix most GCC warnings during build. Only -Wattribute left. Modified: libcxx/trunk/include/string libcxx/trunk/include/system_error Modified: libcxx/trunk/i

Re: r246278 - [OPENMP 4.0] Codegen for array sections.

2015-08-28 Thread Daniel Jasper via cfe-commits
This fails on the bot, reverting: http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_check/12747/ On Fri, Aug 28, 2015 at 8:09 AM, Alexey Bataev via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: abataev > Date: Fri Aug 28 01:09:05 2015 > New Revision: 246278 > > URL

Re: [PATCH] D12358: [Analyzer] Handling constant bound loops

2015-08-28 Thread Ted Kremenek via cfe-commits
krememek added a comment. In http://reviews.llvm.org/D12358#234975, @krememek wrote: > > > > 1. We need to consult the number of times a loop has been executed to > determine when to apply this widening. We can look at the basic block > counts, which are already used to cull off too ma

Re: r246278 - [OPENMP 4.0] Codegen for array sections.

2015-08-28 Thread Daniel Jasper via cfe-commits
Sorry, totally forgot that your are in the right timezone. Will not revert for now and hope that you can figure this out :-) On Fri, Aug 28, 2015 at 9:10 AM, Daniel Jasper wrote: > This fails on the bot, reverting: > > http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_check/12

r246282 - Revert r246214 and r246213

2015-08-28 Thread Steven Wu via cfe-commits
Author: steven_wu Date: Fri Aug 28 02:14:10 2015 New Revision: 246282 URL: http://llvm.org/viewvc/llvm-project?rev=246282&view=rev Log: Revert r246214 and r246213 These two commits causes llvm LTO bootstrap to hang in ScalarEvolution. Removed: cfe/trunk/test/CodeGenCXX/vtable-assume-load.cpp

Re: r246214 - Assume loads fix #2

2015-08-28 Thread Steven Wu via cfe-commits
I am pretty sure this commit and r246213 causes llvm LTO bootstrap to hang in ScalarEvolution. Doesn’t look like a bug introduced in the commit but definitely triggered something bad. I reverted both commit in r246282. You should able to reproduce the hang by building llvm-cov using LTO. Let me

r246288 - Revert "[OPENMP 4.0] Codegen for array sections."

2015-08-28 Thread Daniel Jasper via cfe-commits
Author: djasper Date: Fri Aug 28 03:42:22 2015 New Revision: 246288 URL: http://llvm.org/viewvc/llvm-project?rev=246288&view=rev Log: Revert "[OPENMP 4.0] Codegen for array sections." The test is currently failing on bots: http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_check

Re: [PATCH] D11297: PR17829: Functions declared extern "C" with a name matching a mangled C++ function are allowed

2015-08-28 Thread Andrey Bokhanko via cfe-commits
andreybokhanko updated this revision to Diff 33401. andreybokhanko added a comment. Fixed last note from John McCall. John, please re-review. Yours, Andrey http://reviews.llvm.org/D11297 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td lib/CodeGe

Re: [PATCH] D11832: [Patch] [Analyzer] false positive: Potential leak connected with memcpy (PR 22954)

2015-08-28 Thread pierre gousseau via cfe-commits
pgousseau added inline comments. Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:863 @@ +862,3 @@ + + const ElementRegion *ER = dyn_cast(R); + // Cast is safe as BufVal's region is a FieldRegion. dcoughlin wrote: > You can use cast(R) here, which will

Re: [PATCH] D11832: [Patch] [Analyzer] false positive: Potential leak connected with memcpy (PR 22954)

2015-08-28 Thread pierre gousseau via cfe-commits
pgousseau updated this revision to Diff 33402. pgousseau added a comment. Replace 'dyn_cast' by 'cast' following Devin's review. If all looks good could someone commit this patch for me ? Regards, Pierre http://reviews.llvm.org/D11832 Files: include/clang/StaticAnalyzer/Core/PathSensitive/

Re: [PATCH] D11297: PR17829: Functions declared extern "C" with a name matching a mangled C++ function are allowed

2015-08-28 Thread John McCall via cfe-commits
rjmccall added a comment. This looks great, thanks! One last comment; if you agree with me, go ahead and fix it and then commit. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2323 @@ -2323,1 +2322,3 @@ + "definition with same mangled name as another definition">, +

Re: [PATCH] D11361: [OpenMP] Target directive host codegen

2015-08-28 Thread Alexey Bataev via cfe-commits
ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:2991-3005 @@ +2990,17 @@ + +/// \brief Values for bit flags used to specify the mapping type for +/// offloading. +enum OpenMPOffloadMappingFlags { + /// \brief Allocate memory on the device and move data

Re: [PATCH] D6551: Improvements to scan-build.

2015-08-28 Thread Sylvestre Ledru via cfe-commits
sylvestre.ledru added a comment. Anton, I think you should just commit it. We can always iterate on this later if it breaks anything. The patch is big and rebasing is time consuming. http://reviews.llvm.org/D6551 ___ cfe-commits mailing list cfe-co

Re: [PATCH] D12081: Add use-nullptr check to clang-tidy.

2015-08-28 Thread Aaron Ballman via cfe-commits
On Thu, Aug 27, 2015 at 7:36 PM, Alexander Kornienko wrote: > On Fri, Aug 28, 2015 at 1:23 AM, Aaron Ballman > wrote: >> >> On Thu, Aug 27, 2015 at 7:20 PM, Alexander Kornienko >> wrote: >> > alexfh added a comment. >> > >> > In http://reviews.llvm.org/D12081#234614, @aaron.ballman wrote: >> > >

r246295 - Support Debian s390x multiarch paths

2015-08-28 Thread Sylvestre Ledru via cfe-commits
Author: sylvestre Date: Fri Aug 28 07:26:09 2015 New Revision: 246295 URL: http://llvm.org/viewvc/llvm-project?rev=246295&view=rev Log: Support Debian s390x multiarch paths Summary: Patch by Steven Chamberlain Reviewers: uweigand Differential Revision: http://reviews.llvm.org/D12430 Modified:

Re: [PATCH] D11297: PR17829: Functions declared extern "C" with a name matching a mangled C++ function are allowed

2015-08-28 Thread Andrey Bokhanko via cfe-commits
andreybokhanko added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2323 @@ -2323,1 +2322,3 @@ + "definition with same mangled name as another definition">, + InGroup; def err_cyclic_alias : Error< rjmccall wrote: > I'm sorry to bring t

Re: [PATCH] D12358: [Analyzer] Handling constant bound loops

2015-08-28 Thread Sean Eveson via cfe-commits
seaneveson added a comment. In http://reviews.llvm.org/D12358#234949, @zaks.anna wrote: > We try to avoid false positives as much as possible. They are very painful > for users to deal with. > You should develop this feature behind a flag. This would allow for > incremental development and

[clang-tools-extra] r246298 - Reapplying r246209, which exposed language options to the checkers. This time disable UseNullptrCheck when not compiling in C++ mode, but still allow in C++11 mode since

2015-08-28 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Fri Aug 28 08:20:46 2015 New Revision: 246298 URL: http://llvm.org/viewvc/llvm-project?rev=246298&view=rev Log: Reapplying r246209, which exposed language options to the checkers. This time disable UseNullptrCheck when not compiling in C++ mode, but still allow in C++1

Re: [PATCH] D11963: Create a __config_site file to capture configuration decisions.

2015-08-28 Thread Jonathan Roelofs via cfe-commits
jroelofs added a comment. In http://reviews.llvm.org/D11963#234789, @EricWF wrote: > Copy the headers to the build directory during every build instead of just > during CMake configuration. Sounds like this would cause every build to effectively be a full build. I don't think we want that...

r246303 - fix typo; NFC

2015-08-28 Thread Sanjay Patel via cfe-commits
Author: spatel Date: Fri Aug 28 09:42:54 2015 New Revision: 246303 URL: http://llvm.org/viewvc/llvm-project?rev=246303&view=rev Log: fix typo; NFC Modified: cfe/trunk/lib/Sema/SemaStmt.cpp Modified: cfe/trunk/lib/Sema/SemaStmt.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/

Re: Implict casts disappeared from syntactic init list expressions in C++

2015-08-28 Thread Abramo Bagnara via cfe-commits
Ping. Il 25/08/2015 19:27, Abramo Bagnara ha scritto: > Comparing the result of InitListExpr::getSyntacticForm between r224986 > and r245836 I've discovered that integer to char implicit cast for > integer literal 3 is no longer added to AST for C++ (while it is present > in C). > > This is the s

[PATCH] D12435: [Concepts] Add diagnostic; invalid specifier on function or variable concept declaration

2015-08-28 Thread Nathan Wilson via cfe-commits
nwilson created this revision. nwilson added reviewers: rsmith, hubert.reinterpretcast, aaron.ballman, faisalv, fraggamuffin. nwilson added a subscriber: cfe-commits. Diagnose variable and function concept declarations when an invalid specifier appears http://reviews.llvm.org/D12435 Files: i

Re: [PATCH] D12022: Refactored dtor sanitizing into EHScopeStack

2015-08-28 Thread Naomi Musgrave via cfe-commits
nmusgrave updated this revision to Diff 33436. nmusgrave added a comment. - Checking for existence of fields to poison in alias emission. http://reviews.llvm.org/D12022 Files: lib/CodeGen/CGCXX.cpp lib/CodeGen/CGClass.cpp lib/CodeGen/CodeGenModule.h test/CodeGenCXX/sanitize-dtor-nontriv

Re: [PATCH] D12022: Refactored dtor sanitizing into EHScopeStack

2015-08-28 Thread Naomi Musgrave via cfe-commits
nmusgrave marked 3 inline comments as done. nmusgrave added a comment. http://reviews.llvm.org/D12022 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12022: Refactored dtor sanitizing into EHScopeStack

2015-08-28 Thread Naomi Musgrave via cfe-commits
nmusgrave added inline comments. Comment at: test/CodeGenCXX/sanitize-dtor-repress-aliasing.cpp:30 @@ +29,2 @@ +// Definition of virtual function table +// CHECK: @_ZTV7Derived = {{.*}}(void (%struct.Derived*)* @_ZN7DerivedD1Ev to i8*){{.*}}(void (%struct.Derived*)* @_ZN7DerivedD

Re: [PATCH] D12435: [Concepts] Add diagnostic; invalid specifier on function or variable concept declaration

2015-08-28 Thread Hubert Tong via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:1982 @@ -1981,1 +1981,3 @@ "function concept cannot have exception specification">; +def err_concept_decl_invalid_sepcifiers : Error< + "%select{variable|function}0 concept can

[PATCH][Solaris] Default to -fno-cxa-finalize

2015-08-28 Thread Xan López via cfe-commits
There is no __cxa_finalize symbol available on recent Solaris OS versions, so we need this flag to make non trivial C++ programs run. Also stop looking for cxa_finalize.o, since it won't be there. (This patch sits on top of a couple of unreviewed patches that make clang actually work on Solaris,

[PATCH][Solaris] Add -lc also when linking shared libraries

2015-08-28 Thread Xan López via cfe-commits
This is actually needed, otherwise libc won't be added at all. For instance when building libclang.so all the libc symbols won't be found, with ld warning about libc being an "implicit dependency". ((This patch sits on top of a couple of unreviewed patches that make clang actually work on Solaris

[clang-tools-extra] r246310 - Disable several more clang-tidy modernize checkers when not compiling in C++ mode. Loop conversion would make recommendations for C code, so added a test to ensure that d

2015-08-28 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Fri Aug 28 12:58:10 2015 New Revision: 246310 URL: http://llvm.org/viewvc/llvm-project?rev=246310&view=rev Log: Disable several more clang-tidy modernize checkers when not compiling in C++ mode. Loop conversion would make recommendations for C code, so added a test to

Re: [PATCH] D11832: [Patch] [Analyzer] false positive: Potential leak connected with memcpy (PR 22954)

2015-08-28 Thread Devin Coughlin via cfe-commits
dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. I will commit. Thanks for your work on this, Pierre! http://reviews.llvm.org/D11832 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D11815: Pass subtarget feature "force-align-stack"

2015-08-28 Thread Akira Hatanaka via cfe-commits
ahatanak added inline comments. Comment at: lib/Driver/Tools.cpp:4232 @@ +4231,3 @@ + false)) +CmdArgs.push_back(Args.MakeArgString("-force-align-stack")); + hfinkel wrote: > ahatanak wrote: > > echristo wrote: > > > hfinkel wrote: > > > > ec

[PATCH] D12444: [Sema] Avoid crash on tag-type mismatch (Fixes PR24610)

2015-08-28 Thread Vedant Kumar via cfe-commits
vsk created this revision. vsk added a subscriber: cfe-commits. We currently assert-fail on the following input: enum Color { R, G, B }; typedef struct Color C; This patch just changes the assert to a conditional. https://llvm.org/bugs/show_bug.cgi?id=24610 http://reviews.llvm.org/D12444 File

Re: [PATCH] D6551: Improvements to scan-build.

2015-08-28 Thread Devin Coughlin via cfe-commits
dcoughlin accepted this revision. dcoughlin added a comment. I ran our build-bot scripts with this and it looks good to me, although I've noted two places with trailing whitespace. Thanks for your patience! Comment at: tools/scan-build/scan-build:1403 @@ +1402,3 @@ + my $Args

Re: [PATCH] D6551: Improvements to scan-build.

2015-08-28 Thread Anna Zaks via cfe-commits
zaks.anna added a comment. Please, make sure to include a very specific commit title/message. http://reviews.llvm.org/D6551 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r246318 - Disable clang-tidy misc checkers when not compiling in C++ mode. Many of the checkers do not require additional testing as the tests will not compile for other languages

2015-08-28 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Fri Aug 28 14:27:19 2015 New Revision: 246318 URL: http://llvm.org/viewvc/llvm-project?rev=246318&view=rev Log: Disable clang-tidy misc checkers when not compiling in C++ mode. Many of the checkers do not require additional testing as the tests will not compile for oth

r246319 - Revert "[X86][F16C] Added debug codegen test for F16C intrinsics"

2015-08-28 Thread Renato Golin via cfe-commits
Author: rengolin Date: Fri Aug 28 14:34:53 2015 New Revision: 246319 URL: http://llvm.org/viewvc/llvm-project?rev=246319&view=rev Log: Revert "[X86][F16C] Added debug codegen test for F16C intrinsics" This reverts commit r246204, as it was breaking all ARM/AArch64 bots. Modified: cfe/trunk/t

Re: r246204 - [X86][F16C] Added debug codegen test for F16C intrinsics

2015-08-28 Thread Renato Golin via cfe-commits
Hi Simon, I've reverted this commit in r246319, as it broke all ARM/AArch64 bots and lots of other errors accumulated. cheers, --renato On 27 August 2015 at 21:34, Simon Pilgrim via cfe-commits wrote: > Author: rksimon > Date: Thu Aug 27 15:34:02 2015 > New Revision: 246204 > > URL: http://llv

r246320 - Revert "[X86][FMA4] Added debug codegen test for FMA4 intrinsics"

2015-08-28 Thread Renato Golin via cfe-commits
Author: rengolin Date: Fri Aug 28 14:36:27 2015 New Revision: 246320 URL: http://llvm.org/viewvc/llvm-project?rev=246320&view=rev Log: Revert "[X86][FMA4] Added debug codegen test for FMA4 intrinsics" This reverts commit r246206, as it broke all ARM/AArch64 bots. Modified: cfe/trunk/test/Cod

Re: r246206 - [X86][FMA4] Added debug codegen test for FMA4 intrinsics

2015-08-28 Thread Renato Golin via cfe-commits
Hi Simon, This one too, reverted in r246320. cheers, --renato On 27 August 2015 at 21:41, Simon Pilgrim via cfe-commits wrote: > Author: rksimon > Date: Thu Aug 27 15:41:45 2015 > New Revision: 246206 > > URL: http://llvm.org/viewvc/llvm-project?rev=246206&view=rev > Log: > [X86][FMA4] Added de

Re: r246211 - [X86][XOP] Added debug codegen test for XOP intrinsics

2015-08-28 Thread Renato Golin via cfe-commits
And this one, too, in r246321. --renato On 27 August 2015 at 22:32, Simon Pilgrim via cfe-commits wrote: > Author: rksimon > Date: Thu Aug 27 16:32:03 2015 > New Revision: 246211 > > URL: http://llvm.org/viewvc/llvm-project?rev=246211&view=rev > Log: > [X86][XOP] Added debug codegen test for XOP

r246321 - Revert "[X86][XOP] Added debug codegen test for XOP intrinsics"

2015-08-28 Thread Renato Golin via cfe-commits
Author: rengolin Date: Fri Aug 28 14:38:05 2015 New Revision: 246321 URL: http://llvm.org/viewvc/llvm-project?rev=246321&view=rev Log: Revert "[X86][XOP] Added debug codegen test for XOP intrinsics" This reverts commit r246211, as it broke all ARM/AArch64 bots. Modified: cfe/trunk/test/CodeG

r246323 - Revert "[X86][3DNow] Added debug codegen test for 3DNow! intrinsics"

2015-08-28 Thread Renato Golin via cfe-commits
Author: rengolin Date: Fri Aug 28 14:39:29 2015 New Revision: 246323 URL: http://llvm.org/viewvc/llvm-project?rev=246323&view=rev Log: Revert "[X86][3DNow] Added debug codegen test for 3DNow! intrinsics" This reverts commit r246223, as it broke all ARM/AArch64 bots. Modified: cfe/trunk/test/

r246322 - Adding an AST matcher for namespaceAliasDecl.

2015-08-28 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Fri Aug 28 14:39:21 2015 New Revision: 246322 URL: http://llvm.org/viewvc/llvm-project?rev=246322&view=rev Log: Adding an AST matcher for namespaceAliasDecl. Modified: cfe/trunk/docs/LibASTMatchersReference.html cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h

r246324 - Updating the AST matcher documentation with a new entry; NFC.

2015-08-28 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Fri Aug 28 14:39:56 2015 New Revision: 246324 URL: http://llvm.org/viewvc/llvm-project?rev=246324&view=rev Log: Updating the AST matcher documentation with a new entry; NFC. Modified: cfe/trunk/docs/LibASTMatchersReference.html Modified: cfe/trunk/docs/LibASTMatche

[clang-tools-extra] r246325 - Updated to make use of the AST matcher instead of a custom matcher; NFC.

2015-08-28 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Fri Aug 28 14:40:30 2015 New Revision: 246325 URL: http://llvm.org/viewvc/llvm-project?rev=246325&view=rev Log: Updated to make use of the AST matcher instead of a custom matcher; NFC. Modified: clang-tools-extra/trunk/clang-tidy/misc/UnusedAliasDeclsCheck.cpp Modi

Re: r246223 - [X86][3DNow] Added debug codegen test for 3DNow! intrinsics

2015-08-28 Thread Renato Golin via cfe-commits
And finally this one in r246323. Please, move all those tests to an X86 specific area and check the AArch64 bots after commit to make sure it passes. You probably didn't get the email because the bot was broken when you committed, then all your other commits were breaking a broken bot. :) cheers

Re: [PATCH] D11815: Pass subtarget feature "force-align-stack"

2015-08-28 Thread Akira Hatanaka via cfe-commits
ahatanak updated this revision to Diff 33456. ahatanak added a comment. This updated patch changes the handling of driver option -mstackrealign/-mno-stackrealign. -mno-stackrealign no longer indicates stack realignment should be disallowed and clang no longer attaches function attribute "no-rea

Re: r246223 - [X86][3DNow] Added debug codegen test for 3DNow! intrinsics

2015-08-28 Thread Simon Pilgrim via cfe-commits
Thanks for the heads up Renato. I've a candidate fix (it was missing REQUIRES: x86-registered-target) and will commit it later and keep an extra eye on the non-x86 buildbots. On 28/08/2015 20:41, Renato Golin wrote: And finally this one in r246323. Please, move all those tests to an X86 speci

[PATCH] D12445: [Static Analyzer] Remove sinks from nullability checks.

2015-08-28 Thread Gábor Horváth via cfe-commits
xazax.hun created this revision. xazax.hun added reviewers: zaks.anna, dcoughlin, krememek, jordan_rose. xazax.hun added a subscriber: cfe-commits. With this patch a nullability violation no longer generates a sink node, so it does not cause any coverage loss for other checkers. >From now on, it

Re: r246223 - [X86][3DNow] Added debug codegen test for 3DNow! intrinsics

2015-08-28 Thread Renato Golin via cfe-commits
Thanks! On 28 Aug 2015 9:33 pm, "Simon Pilgrim" wrote: > Thanks for the heads up Renato. I've a candidate fix (it was missing > REQUIRES: x86-registered-target) and will commit it later and keep an extra > eye on the non-x86 buildbots. > > On 28/08/2015 20:41, Renato Golin wrote: > >> And finally

[PATCH] D12446: [PATCH] Enable clang-tidy misc-static-assert for C11

2015-08-28 Thread Aaron Ballman via cfe-commits
aaron.ballman created this revision. aaron.ballman added reviewers: alexfh, djasper. aaron.ballman added a subscriber: cfe-commits. This patch adds support for the C11 _Static_assert macro to clang-tidy's misc-static-assert checker. There are a few things I'm not overly satisfied with, and welco

Re: [PATCH] D12022: Refactored dtor sanitizing into EHScopeStack

2015-08-28 Thread Naomi Musgrave via cfe-commits
nmusgrave updated this revision to Diff 33463. nmusgrave marked an inline comment as done. nmusgrave added a comment. - Alias-repressing test case ignores casting of pointers. http://reviews.llvm.org/D12022 Files: lib/CodeGen/CGCXX.cpp lib/CodeGen/CGClass.cpp lib/CodeGen/CodeGenModule.h

Re: Implict casts disappeared from syntactic init list expressions in C++

2015-08-28 Thread Richard Smith via cfe-commits
On Tue, Aug 25, 2015 at 10:27 AM, Abramo Bagnara wrote: > Comparing the result of InitListExpr::getSyntacticForm between r224986 > and r245836 I've discovered that integer to char implicit cast for > integer literal 3 is no longer added to AST for C++ (while it is present > in C). > > This is the

Re: [PATCH] D12422: Allow TLS vars in dllimport/export functions; only inline dllimport functions when safe (PR24593)

2015-08-28 Thread David Majnemer via cfe-commits
majnemer accepted this revision. majnemer added a comment. This revision is now accepted and ready to land. LGTM We should probably do something about lambdas, they can't be imported or exported but this can be done in a follow up patch. http://reviews.llvm.org/D12422 __

Re: [PATCH] D12435: [Concepts] Add diagnostic; invalid specifier on function or variable concept declaration

2015-08-28 Thread Nathan Wilson via cfe-commits
nwilson added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:1982 @@ -1981,1 +1981,3 @@ "function concept cannot have exception specification">; +def err_concept_decl_invalid_sepcifiers : Error< + "%select{variable|function}0 concept cannot be declared

r246338 - Allow TLS vars in dllimport/export functions; only inline dllimport functions when safe (PR24593)

2015-08-28 Thread Hans Wennborg via cfe-commits
Author: hans Date: Fri Aug 28 16:47:01 2015 New Revision: 246338 URL: http://llvm.org/viewvc/llvm-project?rev=246338&view=rev Log: Allow TLS vars in dllimport/export functions; only inline dllimport functions when safe (PR24593) This patch does two things: 1) Don't error about dllimport/export

Re: [PATCH] D12422: Allow TLS vars in dllimport/export functions; only inline dllimport functions when safe (PR24593)

2015-08-28 Thread Hans Wennborg via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL246338: Allow TLS vars in dllimport/export functions; only inline dllimport functions… (authored by hans). Changed prior to commit: http://reviews.llvm.org/D12422?vs=33388&id=33471#toc Repository: rL

Re: [PATCH] D11297: PR17829: Functions declared extern "C" with a name matching a mangled C++ function are allowed

2015-08-28 Thread John McCall via cfe-commits
rjmccall added a comment. Yes, please make it an error. And the obvious test changes are fine. :) http://reviews.llvm.org/D11297 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12435: [Concepts] Add diagnostic; invalid specifier on function or variable concept declaration

2015-08-28 Thread Hubert Tong via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:1982 @@ -1981,1 +1981,3 @@ "function concept cannot have exception specification">; +def err_concept_decl_invalid_sepcifiers : Error< + "%select{variable|function}0 concept can

Re: [PATCH] D11832: [Patch] [Analyzer] false positive: Potential leak connected with memcpy (PR 22954)

2015-08-28 Thread Devin Coughlin via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL246345: [analyzer] When memcpy'ing into a fixed-size array, do not invalidate entire… (authored by dcoughlin). Changed prior to commit: http://reviews.llvm.org/D11832?vs=33402&id=33478#toc Repository:

r246345 - [analyzer] When memcpy'ing into a fixed-size array, do not invalidate entire region.

2015-08-28 Thread Devin Coughlin via cfe-commits
Author: dcoughlin Date: Fri Aug 28 17:26:05 2015 New Revision: 246345 URL: http://llvm.org/viewvc/llvm-project?rev=246345&view=rev Log: [analyzer] When memcpy'ing into a fixed-size array, do not invalidate entire region. Change the analyzer's modeling of memcpy to be more precise when copying in

r246346 - Fold TargetInfo::handleUserFeatures into TargetInfo::initFeatureMap.

2015-08-28 Thread Eric Christopher via cfe-commits
Author: echristo Date: Fri Aug 28 17:32:01 2015 New Revision: 246346 URL: http://llvm.org/viewvc/llvm-project?rev=246346&view=rev Log: Fold TargetInfo::handleUserFeatures into TargetInfo::initFeatureMap. Modified: cfe/trunk/include/clang/Basic/TargetInfo.h cfe/trunk/lib/Basic/Targets.cpp

r246347 - PR24612: Don't bail out of checking a constexpr function before checking

2015-08-28 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Aug 28 17:33:53 2015 New Revision: 246347 URL: http://llvm.org/viewvc/llvm-project?rev=246347&view=rev Log: PR24612: Don't bail out of checking a constexpr function before checking whether it can ever produce a constant expression in the case where it has a void return typ

LLVM buildmaster will be restarted tonight

2015-08-28 Thread Galina Kistanova via cfe-commits
Hello everyone, LLVM buildmaster will be restarted after 6 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D12453: [CUDA] Allow function overloads based on host/device attributes.

2015-08-28 Thread Artem Belevich via cfe-commits
tra created this revision. tra added reviewers: eliben, rsmith, jholewinski, echristo, jingyue. tra added a subscriber: cfe-commits. The patch makes it possible to parse CUDA files that contain host/device functions with identical signatures, but different attributes without having to physicall

r246348 - Follow-up to r246338: use getParentFunctionOrMethod

2015-08-28 Thread Hans Wennborg via cfe-commits
Author: hans Date: Fri Aug 28 17:56:21 2015 New Revision: 246348 URL: http://llvm.org/viewvc/llvm-project?rev=246348&view=rev Log: Follow-up to r246338: use getParentFunctionOrMethod Modified: cfe/trunk/lib/Sema/SemaDecl.cpp Modified: cfe/trunk/lib/Sema/SemaDecl.cpp URL: http://llvm.org/vie

Re: [PATCH] D1623: Support __builtin_ms_va_list.

2015-08-28 Thread Charles Davis via cfe-commits
cdavis5x updated this revision to Diff 33490. cdavis5x added a comment. - Rebase onto http://reviews.llvm.org/rL246348. - Register the `__builtin_ms_va_list` predef decl. Fixes a nasty interaction with modules. - Mark `__builtin_ms_va_start` builtin as manually type-checked. http://reviews.llvm

Re: [PATCH] D12313: Introduce __builtin_nontemporal_store and __builtin_nontemporal_load.

2015-08-28 Thread Michael Zolotukhin via cfe-commits
mzolotukhin updated this revision to Diff 33492. mzolotukhin added a comment. - Use EmitStoreOfScalar and EmitLoadOfScalar for generating nontemporal loads and stores. - Rebase on TOT. http://reviews.llvm.org/D12313 Files: include/clang/Basic/Builtins.def include/clang/Basic/DiagnosticSema

Re: [PATCH] D12313: Introduce __builtin_nontemporal_store and __builtin_nontemporal_load.

2015-08-28 Thread Michael Zolotukhin via cfe-commits
mzolotukhin added a comment. Hi Hal, I added `Nontemporal` field to LValue and started to use it in `EmitStoreOfScalar`/`EmitLoadOfScalar`. Does it look like something you had in mind? Thanks, Michael http://reviews.llvm.org/D12313 ___ cfe-commi

[PATCH] D12458: [clang] add __builtin_unpredictable and convert to metadata

2015-08-28 Thread Sanjay Patel via cfe-commits
spatel created this revision. spatel added reviewers: hfinkel, kbsmith1, kparzysz, reames, silvas. spatel added a subscriber: cfe-commits. spatel added a dependency: D12341: add unpredictable metadata type for control flow. This patch depends on D12341 ('unpredictable' metadata type for LLVM).

Re: [PATCH] D12445: [Static Analyzer] Remove sinks from nullability checks.

2015-08-28 Thread Anna Zaks via cfe-commits
zaks.anna added inline comments. Comment at: lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp:166 @@ +165,3 @@ + // nullability precondition is violated it will not report any bugs at all. + void reportBug(ErrorKind Error, ExplodedNode *N, const MemRegion *Region, +

Re: [PATCH] D12446: [PATCH] Enable clang-tidy misc-static-assert for C11

2015-08-28 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. > 1. If is included, then static_assert() is also fine to use. > Presumably, in order for the assert() check to trigger, has to be > included, but I don't feel particularly comfortable with that assumption. Do you have any C11 code that uses `assert()`, but doesn't in

Re: [PATCH] D12445: [Static Analyzer] Remove sinks from nullability checks.

2015-08-28 Thread Gábor Horváth via cfe-commits
xazax.hun updated this revision to Diff 33501. xazax.hun marked 6 inline comments as done. xazax.hun added a comment. Addressed the comments. http://reviews.llvm.org/D12445 Files: lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp test/Analysis/nullability.mm Index: test/Analysis/nullabili

Re: [PATCH] D12445: [Static Analyzer] Remove sinks from nullability checks.

2015-08-28 Thread Gábor Horváth via cfe-commits
xazax.hun added inline comments. Comment at: lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp:395 @@ +394,3 @@ + // reaped. + if (!State->get()) { +ProgramStateRef NewState = zaks.anna wrote: > Maybe you should only do this if there was at least one symbol

[PATCH] D12462: [PATCH] [clang-tidy] Add inconsistent declaration parameter name check

2015-08-28 Thread Piotr Dziwinski via cfe-commits
piotrdz created this revision. piotrdz added a subscriber: cfe-commits. piotrdz set the repository for this revision to rL LLVM. This is first of series of patches, porting code from my project colobot-lint, as I mentioned recently in cfe-dev mailing list. This patch adds a new check in readabil

Re: [PATCH] D1623: Support __builtin_ms_va_list.

2015-08-28 Thread Richard Smith via cfe-commits
rsmith added inline comments. Comment at: include/clang/AST/Expr.h:3709 @@ -3708,3 +3708,3 @@ VAArgExpr(SourceLocation BLoc, Expr* e, TypeSourceInfo *TInfo, -SourceLocation RPLoc, QualType t) +SourceLocation RPLoc, QualType t, bool IsMS = false) : E

Re: [PATCH] D1623: Support __builtin_ms_va_list.

2015-08-28 Thread Richard Smith via cfe-commits
rsmith added inline comments. Comment at: lib/CodeGen/CGExprScalar.cpp:3387-3392 @@ -3386,4 +3386,8 @@ - llvm::Value *ArgValue = CGF.EmitVAListRef(VE->getSubExpr()); - llvm::Value *ArgPtr = CGF.EmitVAArg(ArgValue, VE->getType()); + llvm::Value *ArgValue = VE->isMicrosoftABI()

[PATCH] D12466: Fix empty -L Path on OSX hosts

2015-08-28 Thread Martell Malone via cfe-commits
martell created this revision. martell added reviewers: rnk, yaron.keren. martell added a subscriber: cfe-commits. martell set the repository for this revision to rL LLVM. Not quite sure if this is the proper way to fix this. This is currently my work around when working from an OSX host though.

r246355 - Add a check for a function we're not testing.

2015-08-28 Thread Eric Christopher via cfe-commits
Author: echristo Date: Fri Aug 28 21:59:37 2015 New Revision: 246355 URL: http://llvm.org/viewvc/llvm-project?rev=246355&view=rev Log: Add a check for a function we're not testing. Modified: cfe/trunk/test/CodeGen/attr-target-x86.c Modified: cfe/trunk/test/CodeGen/attr-target-x86.c URL: htt