hfinkel added a comment.
Thanks, but I still have this question:
Plus, I don't understand why you're implementing another place in CodeGen
that generates IR to load and store scalar values. Can't you enhance
EmitLoadOfScalar/EmitStoreOfScalar and then use those functions? If nothing
else,
krememek added a comment.
In http://reviews.llvm.org/D12358#234949, @zaks.anna wrote:
I accept that my current patch is not a comprehensive solution to the
problem and that it may introduce false positives, however I do think it
is an improvement, where it is preferable to have false
I am pretty sure this commit and r246213 causes llvm LTO bootstrap to hang in
ScalarEvolution. Doesn’t look like a bug introduced in the commit but
definitely triggered something bad. I reverted both commit in r246282.
You should able to reproduce the hang by building llvm-cov using LTO. Let me
krememek added a comment.
I think the functionality started here by doing something clever with loops is
complex enough to warrant putting this into a separate .cpp file. We can keep
this here for now, but this seems like complexity that is going to naturally
creep up and make this file even
This fails on the bot, reverting:
http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_check/12747/
On Fri, Aug 28, 2015 at 8:09 AM, Alexey Bataev via cfe-commits
cfe-commits@lists.llvm.org wrote:
Author: abataev
Date: Fri Aug 28 01:09:05 2015
New Revision: 246278
URL:
krememek added a comment.
In http://reviews.llvm.org/D12358#234975, @krememek wrote:
1. We need to consult the number of times a loop has been executed to
determine when to apply this widening. We can look at the basic block
counts, which are already used to cull off too many
Hi Sean,
I responded with some more feedback. Conceptually the patch is quite simple,
but I think Anna’s points are all spot on. I think we’d all be quite amendable
for this work to go in under a flag, with further improvements going in on top
of that. That way we can all collectively start
mzolotukhin added a comment.
I still have this question:
Oops, sorry - I missed that. I'll check how can we reuse that logic.
Thanks,
Michael
http://reviews.llvm.org/D12313
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: steven_wu
Date: Fri Aug 28 02:14:10 2015
New Revision: 246282
URL: http://llvm.org/viewvc/llvm-project?rev=246282view=rev
Log:
Revert r246214 and r246213
These two commits causes llvm LTO bootstrap to hang in ScalarEvolution.
Removed:
cfe/trunk/test/CodeGenCXX/vtable-assume-load.cpp
Sorry, totally forgot that your are in the right timezone. Will not revert
for now and hope that you can figure this out :-)
On Fri, Aug 28, 2015 at 9:10 AM, Daniel Jasper djas...@google.com wrote:
This fails on the bot, reverting:
Author: djasper
Date: Fri Aug 28 03:42:22 2015
New Revision: 246288
URL: http://llvm.org/viewvc/llvm-project?rev=246288view=rev
Log:
Revert [OPENMP 4.0] Codegen for array sections.
The test is currently failing on bots:
andreybokhanko added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2323
@@ -2323,1 +2322,3 @@
+ definition with same mangled name as another definition,
+ InGroupDuplicateMangledNames;
def err_cyclic_alias : Error
rjmccall wrote:
I'm
Author: aaronballman
Date: Fri Aug 28 08:20:46 2015
New Revision: 246298
URL: http://llvm.org/viewvc/llvm-project?rev=246298view=rev
Log:
Reapplying r246209, which exposed language options to the checkers. This time
disable UseNullptrCheck when not compiling in C++ mode, but still allow in
Author: spatel
Date: Fri Aug 28 09:42:54 2015
New Revision: 246303
URL: http://llvm.org/viewvc/llvm-project?rev=246303view=rev
Log:
fix typo; NFC
Modified:
cfe/trunk/lib/Sema/SemaStmt.cpp
Modified: cfe/trunk/lib/Sema/SemaStmt.cpp
URL:
jroelofs added a comment.
In http://reviews.llvm.org/D11963#234789, @EricWF wrote:
Copy the headers to the build directory during every build instead of just
during CMake configuration.
Sounds like this would cause every build to effectively be a full build. I
don't think we want that...
martell created this revision.
martell added reviewers: rnk, yaron.keren.
martell added a subscriber: cfe-commits.
martell set the repository for this revision to rL LLVM.
Not quite sure if this is the proper way to fix this.
This is currently my work around when working from an OSX host though.
rsmith added inline comments.
Comment at: include/clang/AST/Expr.h:3709
@@ -3708,3 +3708,3 @@
VAArgExpr(SourceLocation BLoc, Expr* e, TypeSourceInfo *TInfo,
-SourceLocation RPLoc, QualType t)
+SourceLocation RPLoc, QualType t, bool IsMS = false)
:
Author: echristo
Date: Fri Aug 28 21:59:37 2015
New Revision: 246355
URL: http://llvm.org/viewvc/llvm-project?rev=246355view=rev
Log:
Add a check for a function we're not testing.
Modified:
cfe/trunk/test/CodeGen/attr-target-x86.c
Modified: cfe/trunk/test/CodeGen/attr-target-x86.c
URL:
rsmith added inline comments.
Comment at: lib/CodeGen/CGExprScalar.cpp:3387-3392
@@ -3386,4 +3386,8 @@
- llvm::Value *ArgValue = CGF.EmitVAListRef(VE-getSubExpr());
- llvm::Value *ArgPtr = CGF.EmitVAArg(ArgValue, VE-getType());
+ llvm::Value *ArgValue = VE-isMicrosoftABI() ?
nmusgrave marked 3 inline comments as done.
nmusgrave added a comment.
http://reviews.llvm.org/D12022
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nmusgrave updated this revision to Diff 33436.
nmusgrave added a comment.
- Checking for existence of fields to poison in alias emission.
http://reviews.llvm.org/D12022
Files:
lib/CodeGen/CGCXX.cpp
lib/CodeGen/CGClass.cpp
lib/CodeGen/CodeGenModule.h
nwilson created this revision.
nwilson added reviewers: rsmith, hubert.reinterpretcast, aaron.ballman,
faisalv, fraggamuffin.
nwilson added a subscriber: cfe-commits.
Diagnose variable and function concept declarations when an invalid specifier
appears
http://reviews.llvm.org/D12435
Files:
nmusgrave added inline comments.
Comment at: test/CodeGenCXX/sanitize-dtor-repress-aliasing.cpp:30
@@ +29,2 @@
+// Definition of virtual function table
+// CHECK: @_ZTV7Derived = {{.*}}(void (%struct.Derived*)* @_ZN7DerivedD1Ev to
i8*){{.*}}(void (%struct.Derived*)*
vsk created this revision.
vsk added a subscriber: cfe-commits.
We currently assert-fail on the following input:
enum Color { R, G, B };
typedef struct Color C;
This patch just changes the assert to a conditional.
https://llvm.org/bugs/show_bug.cgi?id=24610
http://reviews.llvm.org/D12444
Author: hans
Date: Fri Aug 28 17:56:21 2015
New Revision: 246348
URL: http://llvm.org/viewvc/llvm-project?rev=246348view=rev
Log:
Follow-up to r246338: use getParentFunctionOrMethod
Modified:
cfe/trunk/lib/Sema/SemaDecl.cpp
Modified: cfe/trunk/lib/Sema/SemaDecl.cpp
URL:
cdavis5x updated this revision to Diff 33490.
cdavis5x added a comment.
- Rebase onto http://reviews.llvm.org/rL246348.
- Register the `__builtin_ms_va_list` predef decl. Fixes a nasty interaction
with modules.
- Mark `__builtin_ms_va_start` builtin as manually type-checked.
mzolotukhin updated this revision to Diff 33492.
mzolotukhin added a comment.
- Use EmitStoreOfScalar and EmitLoadOfScalar for generating nontemporal loads
and stores.
- Rebase on TOT.
http://reviews.llvm.org/D12313
Files:
include/clang/Basic/Builtins.def
mzolotukhin added a comment.
Hi Hal,
I added `Nontemporal` field to LValue and started to use it in
`EmitStoreOfScalar`/`EmitLoadOfScalar`. Does it look like something you had in
mind?
Thanks,
Michael
http://reviews.llvm.org/D12313
___
zaks.anna added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp:166
@@ +165,3 @@
+ // nullability precondition is violated it will not report any bugs at all.
+ void reportBug(ErrorKind Error, ExplodedNode *N, const MemRegion *Region,
+
spatel created this revision.
spatel added reviewers: hfinkel, kbsmith1, kparzysz, reames, silvas.
spatel added a subscriber: cfe-commits.
spatel added a dependency: D12341: add unpredictable metadata type for control
flow.
This patch depends on D12341 ('unpredictable' metadata type for LLVM).
hubert.reinterpretcast added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:1982
@@ -1981,1 +1981,3 @@
function concept cannot have exception specification;
+def err_concept_decl_invalid_sepcifiers : Error
+ %select{variable|function}0 concept cannot
This revision was automatically updated to reflect the committed changes.
Closed by commit rL246345: [analyzer] When memcpy'ing into a fixed-size array,
do not invalidate entire… (authored by dcoughlin).
Changed prior to commit:
http://reviews.llvm.org/D11832?vs=33402id=33478#toc
Repository:
Author: dcoughlin
Date: Fri Aug 28 17:26:05 2015
New Revision: 246345
URL: http://llvm.org/viewvc/llvm-project?rev=246345view=rev
Log:
[analyzer] When memcpy'ing into a fixed-size array, do not invalidate entire
region.
Change the analyzer's modeling of memcpy to be more precise when copying
Author: rsmith
Date: Fri Aug 28 17:33:53 2015
New Revision: 246347
URL: http://llvm.org/viewvc/llvm-project?rev=246347view=rev
Log:
PR24612: Don't bail out of checking a constexpr function before checking
whether it can ever produce a constant expression in the case where it has a
void return
Hello everyone,
LLVM buildmaster will be restarted after 6 PM Pacific time today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tra created this revision.
tra added reviewers: eliben, rsmith, jholewinski, echristo, jingyue.
tra added a subscriber: cfe-commits.
The patch makes it possible to parse CUDA files that contain host/device
functions with identical signatures, but different attributes without having
to
majnemer accepted this revision.
majnemer added a comment.
This revision is now accepted and ready to land.
LGTM
We should probably do something about lambdas, they can't be imported or
exported but this can be done in a follow up patch.
http://reviews.llvm.org/D12422
Author: hans
Date: Fri Aug 28 16:47:01 2015
New Revision: 246338
URL: http://llvm.org/viewvc/llvm-project?rev=246338view=rev
Log:
Allow TLS vars in dllimport/export functions; only inline dllimport functions
when safe (PR24593)
This patch does two things:
1) Don't error about dllimport/export
This revision was automatically updated to reflect the committed changes.
Closed by commit rL246338: Allow TLS vars in dllimport/export functions; only
inline dllimport functions… (authored by hans).
Changed prior to commit:
http://reviews.llvm.org/D12422?vs=33388id=33471#toc
Repository:
rL
rjmccall added a comment.
Yes, please make it an error. And the obvious test changes are fine. :)
http://reviews.llvm.org/D11297
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nmusgrave updated this revision to Diff 33463.
nmusgrave marked an inline comment as done.
nmusgrave added a comment.
- Alias-repressing test case ignores casting of pointers.
http://reviews.llvm.org/D12022
Files:
lib/CodeGen/CGCXX.cpp
lib/CodeGen/CGClass.cpp
lib/CodeGen/CodeGenModule.h
ahatanak updated this revision to Diff 33456.
ahatanak added a comment.
This updated patch changes the handling of driver option
-mstackrealign/-mno-stackrealign. -mno-stackrealign no longer indicates stack
realignment should be disallowed and clang no longer attaches function
attribute
Thanks for the heads up Renato. I've a candidate fix (it was missing
REQUIRES: x86-registered-target) and will commit it later and keep an
extra eye on the non-x86 buildbots.
On 28/08/2015 20:41, Renato Golin wrote:
And finally this one in r246323.
Please, move all those tests to an X86
xazax.hun created this revision.
xazax.hun added reviewers: zaks.anna, dcoughlin, krememek, jordan_rose.
xazax.hun added a subscriber: cfe-commits.
With this patch a nullability violation no longer generates a sink node, so it
does not cause any coverage loss for other checkers.
From now on, it
Thanks!
On 28 Aug 2015 9:33 pm, Simon Pilgrim llvm-...@redking.me.uk wrote:
Thanks for the heads up Renato. I've a candidate fix (it was missing
REQUIRES: x86-registered-target) and will commit it later and keep an extra
eye on the non-x86 buildbots.
On 28/08/2015 20:41, Renato Golin wrote:
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
I will commit. Thanks for your work on this, Pierre!
http://reviews.llvm.org/D11832
___
cfe-commits mailing list
dcoughlin accepted this revision.
dcoughlin added a comment.
I ran our build-bot scripts with this and it looks good to me, although I've
noted two places with trailing whitespace. Thanks for your patience!
Comment at: tools/scan-build/scan-build:1403
@@ +1402,3 @@
+ my $Args
Author: aaronballman
Date: Fri Aug 28 14:39:56 2015
New Revision: 246324
URL: http://llvm.org/viewvc/llvm-project?rev=246324view=rev
Log:
Updating the AST matcher documentation with a new entry; NFC.
Modified:
cfe/trunk/docs/LibASTMatchersReference.html
Modified:
Author: rengolin
Date: Fri Aug 28 14:39:29 2015
New Revision: 246323
URL: http://llvm.org/viewvc/llvm-project?rev=246323view=rev
Log:
Revert [X86][3DNow] Added debug codegen test for 3DNow! intrinsics
This reverts commit r246223, as it broke all ARM/AArch64 bots.
Modified:
Author: aaronballman
Date: Fri Aug 28 14:39:21 2015
New Revision: 246322
URL: http://llvm.org/viewvc/llvm-project?rev=246322view=rev
Log:
Adding an AST matcher for namespaceAliasDecl.
Modified:
cfe/trunk/docs/LibASTMatchersReference.html
cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h
Hi Simon,
This one too, reverted in r246320.
cheers,
--renato
On 27 August 2015 at 21:41, Simon Pilgrim via cfe-commits
cfe-commits@lists.llvm.org wrote:
Author: rksimon
Date: Thu Aug 27 15:41:45 2015
New Revision: 246206
URL: http://llvm.org/viewvc/llvm-project?rev=246206view=rev
Log:
Author: rengolin
Date: Fri Aug 28 14:36:27 2015
New Revision: 246320
URL: http://llvm.org/viewvc/llvm-project?rev=246320view=rev
Log:
Revert [X86][FMA4] Added debug codegen test for FMA4 intrinsics
This reverts commit r246206, as it broke all ARM/AArch64 bots.
Modified:
Author: rengolin
Date: Fri Aug 28 14:38:05 2015
New Revision: 246321
URL: http://llvm.org/viewvc/llvm-project?rev=246321view=rev
Log:
Revert [X86][XOP] Added debug codegen test for XOP intrinsics
This reverts commit r246211, as it broke all ARM/AArch64 bots.
Modified:
And this one, too, in r246321.
--renato
On 27 August 2015 at 22:32, Simon Pilgrim via cfe-commits
cfe-commits@lists.llvm.org wrote:
Author: rksimon
Date: Thu Aug 27 16:32:03 2015
New Revision: 246211
URL: http://llvm.org/viewvc/llvm-project?rev=246211view=rev
Log:
[X86][XOP] Added debug
Author: aaronballman
Date: Fri Aug 28 14:40:30 2015
New Revision: 246325
URL: http://llvm.org/viewvc/llvm-project?rev=246325view=rev
Log:
Updated to make use of the AST matcher instead of a custom matcher; NFC.
Modified:
clang-tools-extra/trunk/clang-tidy/misc/UnusedAliasDeclsCheck.cpp
And finally this one in r246323.
Please, move all those tests to an X86 specific area and check the
AArch64 bots after commit to make sure it passes.
You probably didn't get the email because the bot was broken when you
committed, then all your other commits were breaking a broken bot. :)
alexfh added a comment.
1. If assert.h is included, then static_assert() is also fine to use.
Presumably, in order for the assert() check to trigger, assert.h has to be
included, but I don't feel particularly comfortable with that assumption.
Do you have any C11 code that uses `assert()`,
xazax.hun updated this revision to Diff 33501.
xazax.hun marked 6 inline comments as done.
xazax.hun added a comment.
Addressed the comments.
http://reviews.llvm.org/D12445
Files:
lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp
test/Analysis/nullability.mm
Index:
piotrdz created this revision.
piotrdz added a subscriber: cfe-commits.
piotrdz set the repository for this revision to rL LLVM.
This is first of series of patches, porting code from my project colobot-lint,
as I mentioned recently in cfe-dev mailing list.
This patch adds a new check in
59 matches
Mail list logo
