zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
Anna.
http://reviews.llvm.org/D12445
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
kromanova added inline comments.
Comment at: lib/Driver/Tools.cpp:3590-3591
@@ -3580,4 +3589,4 @@
Args.ClaimAllArgs(options::OPT_g_flags_Group);
if (Args.hasFlag(options::OPT_gcolumn_info, options::OPT_gno_column_info,
- /*Default*/ true))
+
Author: abataev
Date: Thu Sep 3 02:23:48 2015
New Revision: 246747
URL: http://llvm.org/viewvc/llvm-project?rev=246747&view=rev
Log:
[OPENMP 4.1] Parsing/sema analysis for extended format of 'if' clause.
OpenMP 4.1 added special 'directive-name-modifier' to the 'if' clause.
Format of 'if' clause
seaneveson updated this revision to Diff 33906.
seaneveson added a comment.
Refactored into a new file: LoopWidening.cpp (and LoopWidening.h).
Added an analyzer-config option, which defaults to false:
widen-constant-bound-loops=false
Modified analyzer-config tests to check for the new option.
Add
RedX2501 added a comment.
Ping
http://reviews.llvm.org/D10833
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
RedX2501 added a comment.
Ping
http://reviews.llvm.org/D10834
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
After Aaron updated the clang-tools-extra owners, I looked at the clang
owners and noticed that I'm not in there for libtooling and ast matchers.
Doug suggested 3 years back that I should be in there, but apparently I
forgot to update it. Anybody raising objections to me putting myself in for
libto
Author: abataev
Date: Thu Sep 3 03:45:56 2015
New Revision: 246748
URL: http://llvm.org/viewvc/llvm-project?rev=246748&view=rev
Log:
[OPENMP 4.1] Codegen for extended format of 'if' clause.
Fixed codegen for extended format of 'if' clauses with special
'directive-name-modifier' + ast-print tests
rengolin added a comment.
Hi Alexandros,
Sorry, I was on holidays. Apart from my comment, everything else looks good.
cheers,
--renato
Comment at: lib/Basic/Targets.cpp:4790
@@ +4789,3 @@
+ Builder.defineMacro("__ARM_FEATURE_SAT", "1");
+ Builder.defineMacro("__ARM_F
rengolin added a comment.
Also, the target parser code has changed, please make sure it still works with
the new version.
http://reviews.llvm.org/D12244
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
rengolin accepted this revision.
rengolin added a reviewer: rengolin.
rengolin added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
http://reviews.llvm.org/D12148
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
olista01 closed this revision.
olista01 added a comment.
Thanks, committed as r246755.
http://reviews.llvm.org/D12148
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: olista01
Date: Thu Sep 3 04:34:53 2015
New Revision: 246755
URL: http://llvm.org/viewvc/llvm-project?rev=246755&view=rev
Log:
[ARM] Allow passing/returning of __fp16 arguments
The ACLE (ARM C Language Extensions) 2.0 allows the __fp16 type to be
used as a functon argument or return type
pgousseau added a comment.
In http://reviews.llvm.org/D11832#237110, @pgousseau wrote:
> In http://reviews.llvm.org/D11832#236672, @xazax.hun wrote:
>
> > I reverted the commit until this assertion is fixed.
> >
> > Steps to reproduce:
> > Download the following preprocessed file: F804743: clang
kuhar updated this revision to Diff 33919.
kuhar added a comment.
Some refactoring + comments added.
Repository:
rL LLVM
http://reviews.llvm.org/D12400
Files:
lib/CodeGen/CGCall.cpp
test/CodeGen/arm_function_epilog.cpp
Index: test/CodeGen/arm_function_epilog.cpp
kuhar marked 2 inline comments as done.
kuhar added a comment.
Repository:
rL LLVM
http://reviews.llvm.org/D12400
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kuhar updated this revision to Diff 33921.
Repository:
rL LLVM
http://reviews.llvm.org/D12400
Files:
lib/CodeGen/CGCall.cpp
test/CodeGen/arm_function_epilog.cpp
Index: test/CodeGen/arm_function_epilog.cpp
===
--- /dev/null
++
Author: abataev
Date: Thu Sep 3 05:21:46 2015
New Revision: 246757
URL: http://llvm.org/viewvc/llvm-project?rev=246757&view=rev
Log:
[OPENMP] Fix for http://llvm.org/PR24687: ICE on compilation of R package TPmsm.
Fixed capturing of VLAs in 'private' clause of the OpenMP directives.
Modified:
ABataev created this revision.
ABataev added reviewers: rjmccall, echristo.
ABataev added a subscriber: cfe-commits.
Patch allows to recognize additional registers x8d, x8b, x8w - x15d, x15b, x15w
in inline assembler, already recognized by backend
http://reviews.llvm.org/D12594
Files:
lib/Bas
On 3 September 2015 at 10:34, Oliver Stannard via cfe-commits
wrote:
> Author: olista01
> Date: Thu Sep 3 04:34:53 2015
> New Revision: 246755
>
> URL: http://llvm.org/viewvc/llvm-project?rev=246755&view=rev
> Log:
> [ARM] Allow passing/returning of __fp16 arguments
>
> The ACLE (ARM C Language E
Author: olista01
Date: Thu Sep 3 06:46:24 2015
New Revision: 246760
URL: http://llvm.org/viewvc/llvm-project?rev=246760&view=rev
Log:
Revert 246755 as it breaks buildbots
Original commit message:
[ARM] Allow passing/returning of __fp16 arguments
The ACLE (ARM C Language Extensions) 2.0 allows t
> On 3 September 2015 at 10:34, Oliver Stannard via cfe-commits
> wrote:
> > Author: olista01
> > Date: Thu Sep 3 04:34:53 2015
> > New Revision: 246755
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=246755&view=rev
> > Log:
> > [ARM] Allow passing/returning of __fp16 arguments
> >
> > The
sunfishcode added a subscriber: sunfishcode.
Comment at: lib/Basic/Targets.cpp:6943-6944
@@ +6942,4 @@
+
+ Diags.Report(diag::err_opt_not_valid_with_opt) << Feature
+ << "-target-feature";
+ return false;
--
Sounds great to me, thank you for updating this!
~Aaron
On Thu, Sep 3, 2015 at 4:44 AM, Manuel Klimek wrote:
> After Aaron updated the clang-tools-extra owners, I looked at the clang
> owners and noticed that I'm not in there for libtooling and ast matchers.
> Doug suggested 3 years back that I
olista01 updated this revision to Diff 33932.
olista01 added a comment.
Don't make this change for OpenCL, which handles the half type natively.
http://reviews.llvm.org/D12148
Files:
lib/Basic/Targets.cpp
lib/CodeGen/TargetInfo.cpp
lib/Driver/Tools.cpp
test/CodeGen/arm-fp16-arguments.c
angelgarcia created this revision.
angelgarcia added a reviewer: klimek.
angelgarcia added subscribers: cfe-commits, alexfh.
Ensure that the alias has the same type than the loop variable. Now it works
with lambda captures.
http://reviews.llvm.org/D12597
Files:
clang-tidy/modernize/LoopConver
angelgarcia updated this revision to Diff 33936.
angelgarcia added a comment.
Remove unused include.
http://reviews.llvm.org/D12597
Files:
clang-tidy/modernize/LoopConvertUtils.cpp
clang-tidy/modernize/LoopConvertUtils.h
test/clang-tidy/modernize-loop-convert-extra.cpp
Index: test/clang-
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D12597
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
rengolin added a comment.
I don't like the idea of making it language-specific, but I don't have a better
idea. I don't know if there are support flags in Clang's languages like we have
for back-ends. Anyway, this should fix the current problem. Maybe adding a
comment to that effect on the usag
Author: angelgarcia
Date: Thu Sep 3 07:28:11 2015
New Revision: 246762
URL: http://llvm.org/viewvc/llvm-project?rev=246762&view=rev
Log:
Two more fixes to loop convert.
Summary: Ensure that the alias has the same type than the loop variable. Now it
works with lambda captures.
Reviewers: klimek
labrinea added inline comments.
Comment at: lib/Basic/Targets.cpp:4790
@@ +4789,3 @@
+ Builder.defineMacro("__ARM_FEATURE_SAT", "1");
+ Builder.defineMacro("__ARM_FEATURE_QBIT", "1");
+}
rengolin wrote:
> Isn't there a combination where you'll emit t
Author: olista01
Date: Thu Sep 3 07:40:58 2015
New Revision: 246764
URL: http://llvm.org/viewvc/llvm-project?rev=246764&view=rev
Log:
[ARM] Allow passing/returning of __fp16 arguments
The ACLE (ARM C Language Extensions) 2.0 allows the __fp16 type to be
used as a functon argument or return type
olista01 added a comment.
Committed as r246764, with an additional comment explaining why we don't do
this for OpenCL.
http://reviews.llvm.org/D12148
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
rengolin added inline comments.
Comment at: lib/Basic/Targets.cpp:4790
@@ +4789,3 @@
+ Builder.defineMacro("__ARM_FEATURE_SAT", "1");
+ Builder.defineMacro("__ARM_FEATURE_QBIT", "1");
+}
labrinea wrote:
> rengolin wrote:
> > Isn't there a combination
labrinea added a comment.
This means accepted?
http://reviews.llvm.org/D12244
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.
With the changes you proposed, LGTM. Thanks!
http://reviews.llvm.org/D12244
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
Author: dsanders
Date: Thu Sep 3 07:58:39 2015
New Revision: 246765
URL: http://llvm.org/viewvc/llvm-project?rev=246765&view=rev
Log:
[mips] Added support for choosing between traps and breaks in the integrated
assembler macros.
Summary: The command line options for these are -Wa,--trap and -Wa
steleman created this revision.
steleman added a subscriber: cfe-commits.
This changeset provides an implementation of GCC's -fabi-version= flag.
-fabi-version is documented at GCC here:
https://gcc.gnu.org/onlinedocs/gcc/C_002b_002b-Dialect-Options.html
GCC implements it here:
${top_srcdir}/gcc
steleman added a comment.
The diff is based on 3.6.2.
http://reviews.llvm.org/D12598
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaron.keren added a comment.
In CGCXX.cpp, may be fixable after this commit:
// FIXME: An extern template instantiation will create functions with
// linkage "AvailableExternally". In libc++, some classes also define
// members with attribute "AlwaysInline" and expect no reference to
// b
ABataev added a comment.
Ping
http://reviews.llvm.org/D10599
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ABataev added a comment.
Ping
http://reviews.llvm.org/D11182
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added inline comments.
Comment at: include/clang/Basic/Attr.td:894
@@ -893,1 +893,3 @@
+def DisableTailCalls : InheritableAttr {
+ let Spellings = [GNU<"disable_tail_calls">,
Pardon me if this is obvious, but -- are there times when you would want
Oops, apologies for making this harder than it needs to be. It seems
phab didn't provide context to these comments. Check out the phab
review link for more context, if you'd like it.
~Aaron
On Thu, Sep 3, 2015 at 9:48 AM, Aaron Ballman wrote:
> aaron.ballman added inline comments.
>
> ==
Author: alelab01
Date: Thu Sep 3 09:40:57 2015
New Revision: 246768
URL: http://llvm.org/viewvc/llvm-project?rev=246768&view=rev
Log:
Implement ACLE 2.0 macros of chapters 6.4 and 6.5 for [ARM] and [Aarch64]
targets.
Differential Revision: http://reviews.llvm.org/D12244
Change-Id: Iffd4e822c15e
klimek added a reviewer: dfsuther.
klimek added a comment.
+Dean, as I really don't know Obj-C (sorry for the delay in reply, was on
vacation)
http://reviews.llvm.org/D12471
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
Author: marshall
Date: Thu Sep 3 10:11:32 2015
New Revision: 246772
URL: http://llvm.org/viewvc/llvm-project?rev=246772&view=rev
Log:
Make a helper routine __throw_future_error, and encapsulate the #ifdef
_LIBCPP_NO_EXCEPTIONS there, instead of duplicating it throughout the code. No
functionali
andreybokhanko updated this revision to Diff 33945.
andreybokhanko added a comment.
Patch updated after fixing all (but one) of Reid's comments.
http://reviews.llvm.org/D12402
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/DeclSpec.h
include/clang/Sema/Sema.h
lib/S
andreybokhanko marked 4 inline comments as done.
Comment at: lib/Sema/SemaType.cpp:5873-5877
@@ +5872,7 @@
+ return;
+
+ToCC = DefaultCC;
+
+// Issue a warning on ignored calling convention -- except of __stdcall.
+// Again, this is what MS compiler does.
+if
jroelofs added inline comments.
Comment at: utils/gen_link_script/gen_link_script.py:1
@@ +1,2 @@
+#!/usr/bin/env python
+import os
Do you foresee these linker scripts being significantly more complicated for
other platforms? ISTM that it would be much simpler to
klimek added a comment.
In the future, please add cfe-commits as subscriber on the initial post,
otherwise the initial email will not go to the mailing list. Thx!
http://reviews.llvm.org/D12489
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
klimek added a comment.
Oh, and you'll want to add tests :) unittests/Format/FormatTest.cpp
http://reviews.llvm.org/D12489
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk added inline comments.
Comment at: lib/Sema/SemaType.cpp:5855-5856
@@ -5854,3 +5854,4 @@
CallingConv CurCC = FT->getCallConv();
- CallingConv FromCC =
+ CallingConv DefaultCC =
Context.getDefaultCallingConvention(IsVariadic, IsStatic);
+ CallingConv ToCC;
jroelofs added inline comments.
Comment at: lib/Frontend/InitHeaderSearch.cpp:340
@@ +339,3 @@
+BaseSDKPath = P.str();
+ }
+}
kromanova wrote:
> jroelofs wrote:
> > The lifetime of `P` ends here, yet a reference to it lives on because of
> > the
On Tue, Sep 1, 2015 at 12:31 AM Olivier Goffart wrote:
> On Monday 31. August 2015 08:07:58 Manuel Klimek wrote:
> > On Sat, Aug 29, 2015 at 12:23 PM Olivier Goffart via cfe-commits <
> >
> > cfe-commits@lists.llvm.org> wrote:
> > > Hi,
> > >
> > > Please review the attached patch.
> > >
> > > In
ksuther updated this revision to Diff 33947.
ksuther added a comment.
Added two tests: One of a for/in loop with a cast, and one without.
http://reviews.llvm.org/D12489
Files:
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTest.cpp
Index: unittests/Format/FormatTest.cpp
=
rnk added inline comments.
Comment at: lib/AST/Mangle.cpp:142
@@ +141,3 @@
+ // language).
+ if (MCXX || (CC == CM_Other && TI.getCXXABI() == TargetCXXABI::Microsoft))
+return mangleCXXName(D, Out);
TI.getCXXABI().isMicrosoft() is better than the == check.
Author: klimek
Date: Thu Sep 3 11:11:10 2015
New Revision: 246778
URL: http://llvm.org/viewvc/llvm-project?rev=246778&view=rev
Log:
[libclang] Return deduced type for auto type, not the one written in the source.
It used to work, but was accidentally broken by r179769.
The issue with decayed typ
klimek closed this revision.
klimek added a comment.
Submitted as r246778.
http://reviews.llvm.org/D11976
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
s.egerton created this revision.
s.egerton added reviewers: dsanders, vkalintiris.
s.egerton added a subscriber: cfe-commits.
http://reviews.llvm.org/D12600
Files:
lib/Driver/Tools.cpp
test/Driver/mips-ias-Wa.s
Index: test/Driver/mips-ias-Wa.s
klimek added a subscriber: klimek.
klimek added a comment.
Is this still ready for submission or do you want to change something (not
clear after your last comment :)
http://reviews.llvm.org/D11797
___
cfe-commits mailing list
cfe-commits@lists.llv
nmusgrave updated this revision to Diff 33956.
nmusgrave marked 4 inline comments as done.
nmusgrave added a comment.
- Testing sanitizing bit fields.
http://reviews.llvm.org/D12022
Files:
lib/CodeGen/CGCXX.cpp
lib/CodeGen/CGClass.cpp
lib/CodeGen/CodeGenModule.h
test/CodeGenCXX/sanitize
http://llvm.org/pr23472
As suggested by Reid, OK to commit?
Index: tools/clang/lib/CodeGen/ItaniumCXXABI.cpp
===
--- tools/clang/lib/CodeGen/ItaniumCXXABI.cpp (revision 246575)
+++ tools/clang/lib/CodeGen/ItaniumCXXABI.cpp (workin
nmusgrave updated this revision to Diff 33959.
nmusgrave added a comment.
- Refined testing for bit fields.
http://reviews.llvm.org/D12022
Files:
lib/CodeGen/CGCXX.cpp
lib/CodeGen/CGClass.cpp
lib/CodeGen/CodeGenModule.h
test/CodeGenCXX/sanitize-dtor-bit-field.cpp
test/CodeGenCXX/sanit
I fully trust Reid review on this, so OK with me.
On 3 September 2015 at 14:04, Yaron Keren wrote:
> http://llvm.org/pr23472
>
> As suggested by Reid, OK to commit?
>
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
Prazek added a comment.
I see that CGObjCMac.cpp names it like this:
"Objective-C Garbage Collection"
http://reviews.llvm.org/D12580
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
If you could interleave the test and the check I'd really appreciate it, e.g.:
__asm__ ("mov r8w, 100;");
// CHECK: call void asm sideeffect "mov r8w, 100;"
Otherwise LGTM. Thanks!
-er
Author: samsonov
Date: Thu Sep 3 14:11:42 2015
New Revision: 246795
URL: http://llvm.org/viewvc/llvm-project?rev=246795&view=rev
Log:
Add -target flag to Clang invocations in this test.
ASan may not be supported for the default target triple.
Modified:
cfe/trunk/test/Driver/fsanitize-blackl
LGTM, but I would expand on the comment a bit:
// The ABI says: "It is suggested that it be emitted in the same
COMDAT group
// as the associated data object." In practice, this doesn't work for
non-ELF object formats, so only do it for ELF.
On Thu, Sep 3, 2015 at 11:31 AM, Rafael Espínd
Prazek updated this revision to Diff 33969.
http://reviews.llvm.org/D12580
Files:
lib/CodeGen/CodeGenModule.cpp
test/CodeGenCXX/strict-vtable-pointers.cpp
Index: test/CodeGenCXX/strict-vtable-pointers.cpp
===
--- test/CodeGenCXX
On Thu, Sep 3, 2015 at 8:58 AM, Manuel Klimek wrote:
> On Tue, Sep 1, 2015 at 12:31 AM Olivier Goffart wrote:
>
>> On Monday 31. August 2015 08:07:58 Manuel Klimek wrote:
>> > On Sat, Aug 29, 2015 at 12:23 PM Olivier Goffart via cfe-commits <
>> >
>> > cfe-commits@lists.llvm.org> wrote:
>> > > H
echristo added inline comments.
Comment at: lib/Basic/Targets.cpp:7643-7649
@@ +7642,9 @@
+ case llvm::Triple::wasm64:
+// Until specific variations are defined, don't permit any.
+if (!(Triple == llvm::Triple("wasm64-unknown-unknown")) ||
+(!Triple.getVendorName(
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D12580
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
ismailp added a comment.
Ping!
http://reviews.llvm.org/D12119
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
r246803, thanks!
2015-09-03 23:16 GMT+03:00 Reid Kleckner :
> LGTM, but I would expand on the comment a bit:
> // The ABI says: "It is suggested that it be emitted in the same
> COMDAT group
> // as the associated data object." In practice, this doesn't work for
> non-ELF object format
Author: samsonov
Date: Thu Sep 3 15:53:14 2015
New Revision: 246804
URL: http://llvm.org/viewvc/llvm-project?rev=246804&view=rev
Log:
Add target flag to clang-cl invocation in this test.
Modified:
cfe/trunk/test/Driver/fsanitize-coverage.c
Modified: cfe/trunk/test/Driver/fsanitize-coverage.
Author: delesley
Date: Thu Sep 3 16:14:22 2015
New Revision: 246806
URL: http://llvm.org/viewvc/llvm-project?rev=246806&view=rev
Log:
Thread safety analysis: the NO_THREAD_SAFETY_ANALYSIS attribute will now
disable checking of arguments to the function, which is done by
-Wthread-safety-reference.
rsmith added inline comments.
Comment at: lib/CodeGen/CGCXX.cpp:140-147
@@ -131,1 +139,10 @@
+ // If sanitizing memory to check for use-after-dtor, do not emit as
+ // an alias, unless this class owns no members with trivial destructors.
+ const CXXMethodDecl *MD =
+ ca
On Thursday 3. September 2015 13:41:12 Richard Smith wrote:
> On Thu, Sep 3, 2015 at 8:58 AM, Manuel Klimek wrote:
> > On Tue, Sep 1, 2015 at 12:31 AM Olivier Goffart wrote:
> >> On Monday 31. August 2015 08:07:58 Manuel Klimek wrote:
> >> > On Sat, Aug 29, 2015 at 12:23 PM Olivier Goffart via cf
zaks.anna added a comment.
I do not understand why there should be a cycle here in the Exploded Graph.
Most likely this assertion uncovers a bug in cfg-temporary-doors, which is a
disabled by default feature (it has not been completed yet). You can think of
"ProgramState" as the state of the pr
nmusgrave updated this revision to Diff 33978.
nmusgrave marked 4 inline comments as done.
nmusgrave added a comment.
- Simplified fields and checks for aliasing.
http://reviews.llvm.org/D12022
Files:
lib/CodeGen/CGCXX.cpp
lib/CodeGen/CGClass.cpp
lib/CodeGen/CodeGenModule.h
test/CodeGen
On Thu, Sep 3, 2015 at 2:26 PM, Olivier Goffart wrote:
> On Thursday 3. September 2015 13:41:12 Richard Smith wrote:
> > On Thu, Sep 3, 2015 at 8:58 AM, Manuel Klimek wrote:
> > > On Tue, Sep 1, 2015 at 12:31 AM Olivier Goffart
> wrote:
> > >> On Monday 31. August 2015 08:07:58 Manuel Klimek wr
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM with a couple of tweaks.
Comment at: lib/CodeGen/CGCXX.cpp:45-46
@@ +44,4 @@
+ // an alias, unless this class owns no members.
+ unsigned totalFields =
+ std::dis
nmusgrave updated this revision to Diff 33982.
nmusgrave marked 2 inline comments as done.
nmusgrave added a comment.
- Clean method headers, style.
http://reviews.llvm.org/D12022
Files:
lib/CodeGen/CGCXX.cpp
lib/CodeGen/CGClass.cpp
lib/CodeGen/CodeGenModule.h
test/CodeGenCXX/sanitize-d
This revision was automatically updated to reflect the committed changes.
Closed by commit rL246814: [WebAssembly] Initial WebAssembly support in clang
(authored by djg).
Changed prior to commit:
http://reviews.llvm.org/D12002?vs=33637&id=33985#toc
Repository:
rL LLVM
http://reviews.llvm.or
Author: djg
Date: Thu Sep 3 17:51:53 2015
New Revision: 246814
URL: http://llvm.org/viewvc/llvm-project?rev=246814&view=rev
Log:
[WebAssembly] Initial WebAssembly support in clang
This implements basic support for compiling (though not yet assembling
or linking) for a WebAssembly target. Note th
Author: nmusgrave
Date: Thu Sep 3 18:02:30 2015
New Revision: 246815
URL: http://llvm.org/viewvc/llvm-project?rev=246815&view=rev
Log:
Refactored dtor sanitizing into EHScopeStack
Summary:
Dtor sanitization handled amidst other dtor cleanups,
between cleaning bases and fields. Sanitizer call pus
sfantao created this revision.
sfantao added reviewers: ABataev, rjmccall, hfinkel, tra.
sfantao added a subscriber: cfe-commits.
In order to offloading work properly two things need to be in place:
- a descriptor with all the offloading information (device entry functions, and
global variable) h
Author: xazax
Date: Thu Sep 3 18:16:21 2015
New Revision: 246818
URL: http://llvm.org/viewvc/llvm-project?rev=246818&view=rev
Log:
[Static Analyzer] Remove sinks from nullability checks.
Differential Revision: http://reviews.llvm.org/D12445
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL246818: [Static Analyzer] Remove sinks from nullability
checks. (authored by xazax).
Changed prior to commit:
http://reviews.llvm.org/D12445?vs=33728&id=33987#toc
Repository:
rL LLVM
http://reviews.
sfantao abandoned this revision.
sfantao added a comment.
I am closing this revision as I added the functionality for the device codegen
on top of this patch in http://reviews.llvm.org/D12614 because the two are
tightly coupled.
Thanks,
Samuel
http://reviews.llvm.org/D12306
___
sunfishcode added inline comments.
Comment at: lib/Basic/Targets.cpp:7643-7649
@@ +7642,9 @@
+ case llvm::Triple::wasm64:
+// Until specific variations are defined, don't permit any.
+if (!(Triple == llvm::Triple("wasm64-unknown-unknown")) ||
+(!Triple.getVendorNa
nmusgrave created this revision.
nmusgrave added reviewers: eugenis, kcc.
nmusgrave added a subscriber: cfe-commits.
If class or struct has not declared a destructor,
no destsructor is emitted, and members are not poisoned
after destruction. This case highlights bug in current
implementation of us
eugenis added inline comments.
Comment at: test/CodeGenCXX/sanitize-dtor-generated.cpp:5
@@ +4,3 @@
+
+// TODO Success pending on resolution of issue 596
+// XFAIL: *
Add the link to the issue.
Comment at: test/CodeGenCXX/sanitize-dtor-generated.
Author: echristo
Date: Thu Sep 3 19:15:47 2015
New Revision: 246826
URL: http://llvm.org/viewvc/llvm-project?rev=246826&view=rev
Log:
Untabify.
Modified:
cfe/trunk/include/clang/Sema/Sema.h
Modified: cfe/trunk/include/clang/Sema/Sema.h
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/inc
xazax.hun created this revision.
xazax.hun added reviewers: dcoughlin, zaks.anna.
xazax.hun added a subscriber: cfe-commits.
This patch contains minor cleanups and style fixes for the nullability checker.
NFC.
http://reviews.llvm.org/D12619
Files:
lib/StaticAnalyzer/Checkers/NullabilityChecke
eugenis updated this revision to Diff 33997.
Repository:
rL LLVM
http://reviews.llvm.org/D12087
Files:
lib/CodeGen/CGCXX.cpp
lib/CodeGen/CGClass.cpp
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CodeGenModule.cpp
lib/CodeGen/CodeGenModule.h
lib/CodeGen/ItaniumCXXABI.cpp
test/CodeGe
eugenis added a comment.
In http://reviews.llvm.org/D12087#239243, @yaron.keren wrote:
> In CGCXX.cpp, may be fixable after this commit:
>
> // FIXME: An extern template instantiation will create functions with
> // linkage "AvailableExternally". In libc++, some classes also define
> // mem
Author: rsmith
Date: Thu Sep 3 20:03:03 2015
New Revision: 246830
URL: http://llvm.org/viewvc/llvm-project?rev=246830&view=rev
Log:
Fix a potential APInt memory leak when using __attribute__((flag_enum)), and
simplify the implementation a bit.
Modified:
cfe/trunk/include/clang/Basic/Attr.td
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Why static was removed from getMostNullable() and getNullabilityString()? If
these functions are not intended to be used outside this source file, it's good
idea to limit their scope. Same should be done for Error
1 - 100 of 118 matches
Mail list logo
