r249982 - Keep the IfStmt node even if the condition is invalid

2015-10-11 Thread Olivier Goffart via cfe-commits
Author: ogoffart Date: Sun Oct 11 12:27:29 2015 New Revision: 249982 URL: http://llvm.org/viewvc/llvm-project?rev=249982=rev Log: Keep the IfStmt node even if the condition is invalid This is important to keep the information in IDE or other tools even if the code contains a few errors

Re: [PATCH] D13344: Keep the IfStmt node even if the condition is invalid

2015-10-11 Thread Olivier Goffart via cfe-commits
ogoffart abandoned this revision. ogoffart marked an inline comment as done. ogoffart added a comment. commited as r249982. (I forgot to add the link to reviews.llvm.org in the commit message. I'll do it next time) http://reviews.llvm.org/D13344

r249995 - [Sema] Allow C conversions in C overload logic

2015-10-11 Thread George Burgess IV via cfe-commits
Author: gbiv Date: Sun Oct 11 15:13:20 2015 New Revision: 249995 URL: http://llvm.org/viewvc/llvm-project?rev=249995=rev Log: [Sema] Allow C conversions in C overload logic C allows for some implicit conversions that C++ does not, e.g. void* -> char*. This patch teaches clang that these

Re: [PATCH] D13604: Fix to allow C conversions on arguments passed to functions with __attribute__((overloadable)) in C

2015-10-11 Thread George Burgess IV via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL249995: [Sema] Allow C conversions in C overload logic (authored by gbiv). Changed prior to commit: http://reviews.llvm.org/D13604?vs=36986=37062#toc Repository: rL LLVM

Re: [PATCH] D13639: Add decayedType and hasDecayedType AST matchers

2015-10-11 Thread Matthias Gehre via cfe-commits
mgehre updated this revision to Diff 37066. mgehre added a comment. Add test http://reviews.llvm.org/D13639 Files: include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp unittests/ASTMatchers/ASTMatchersTest.cpp Index: unittests/ASTMatchers/ASTMatchersTest.cpp

[clang-tools-extra] r250002 - Test commit

2015-10-11 Thread Matthias Gehre via cfe-commits
Author: mgehre Date: Sun Oct 11 17:55:29 2015 New Revision: 250002 URL: http://llvm.org/viewvc/llvm-project?rev=250002=rev Log: Test commit Modified: clang-tools-extra/trunk/clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp Modified:

[PATCH] D13639: Add decayedType and hasDecayedType AST matchers

2015-10-11 Thread Matthias Gehre via cfe-commits
mgehre created this revision. mgehre added a reviewer: klimek. mgehre added a subscriber: cfe-commits. Herald added a subscriber: klimek. Add decayedType and hasDecayedType AST matchers http://reviews.llvm.org/D13639 Files: include/clang/ASTMatchers/ASTMatchers.h

r249997 - Fix warning caused by r249995

2015-10-11 Thread George Burgess IV via cfe-commits
Author: gbiv Date: Sun Oct 11 15:37:14 2015 New Revision: 249997 URL: http://llvm.org/viewvc/llvm-project?rev=249997=rev Log: Fix warning caused by r249995 Modified: cfe/trunk/lib/Sema/SemaExprCXX.cpp Modified: cfe/trunk/lib/Sema/SemaExprCXX.cpp URL:

[PATCH] D13640: [clang-tidy] Add new check cppcoreguidelines-pro-bounds-array-to-pointer-decay

2015-10-11 Thread Matthias Gehre via cfe-commits
mgehre created this revision. mgehre added reviewers: alexfh, sbenza, bkramer, aaron.ballman. mgehre added a subscriber: cfe-commits. This check flags all array to pointer decays. Pointers should not be used as arrays. array_view is a bounds-checked, safe alternative to using pointers to access

[PATCH] D13641: clang-format: [JS] handle character classes in regexes.

2015-10-11 Thread Martin Probst via cfe-commits
mprobst created this revision. mprobst added a reviewer: djasper. mprobst added subscribers: cfe-commits, klimek. Slashes in regular expressions do not need to be escaped and do not terminate the regular expression even without a preceding backslash. http://reviews.llvm.org/D13641 Files:

Re: [PATCH] D13607: [Fix] Make it an error to take the address of (most) enable_if functions.

2015-10-11 Thread George Burgess IV via cfe-commits
george.burgess.iv added inline comments. Comment at: lib/Sema/SemaInit.cpp:4978-4990 @@ -4977,1 +4977,15 @@ +// As an extension, C can have overloaded functions. We need to add the +// address resolution step. +if (Initializer->getType() == Context.OverloadTy) { +

Re: [PATCH] D11740: ABI versioning macros for libc++

2015-10-11 Thread Eric Fiselier via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM but this is still blocked by http://reviews.llvm.org/D13407. Ill let you know once that has landed. Comment at: include/__config:251 @@ +250,3 @@ +

Re: [PATCH] D12512: [libcxxabi] Manually align pointers in __cxa_allocate_exception - Fixes PR24604

2015-10-11 Thread Eric Fiselier via cfe-commits
EricWF added a comment. Whats preventing this from landing? @joerg @danalbert Do we want to use "posix_memalign" on Android or not? http://reviews.llvm.org/D12512 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r250003 - [Darwin] Need to add -isysroot on OS X otherwise the tests will fail if you don't have the command line tools package installed.

2015-10-11 Thread Chris Bieneman via cfe-commits
Author: cbieneman Date: Sun Oct 11 19:49:56 2015 New Revision: 250003 URL: http://llvm.org/viewvc/llvm-project?rev=250003=rev Log: [Darwin] Need to add -isysroot on OS X otherwise the tests will fail if you don't have the command line tools package installed. This mirrors how other LLVM suites

Re: [libcxx] r250003 - [Darwin] Need to add -isysroot on OS X otherwise the tests will fail if you don't have the command line tools package installed.

2015-10-11 Thread Eric Fiselier via cfe-commits
Do we need to do with while building libc++ as well? Also please reuse lit.util.capture or lit.util.executeCommand instead of subprocess. /Eric On Sun, Oct 11, 2015 at 6:49 PM, Chris Bieneman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: cbieneman > Date: Sun Oct 11 19:49:56

Re: [PATCH] D13641: clang-format: [JS] handle character classes in regexes.

2015-10-11 Thread Daniel Jasper via cfe-commits
djasper closed this revision. djasper added a comment. Submitted as r250009. http://reviews.llvm.org/D13641 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D10834: Added functions to retrieve information about variable storage in libclang and its python bindings.

2015-10-11 Thread guibufolo+l...@gmail.com via cfe-commits
RedX2501 added inline comments. Comment at: include/clang-c/Index.h:3815-3823 @@ -3814,2 +3814,11 @@ /** + * \brief Returns true if a variable with function scope is a non-static local variable. + */ +CINDEX_LINKAGE bool clang_Cursor_hasLocalStorage(CXCursor C); + +/* + *

Re: [libcxx] r250003 - [Darwin] Need to add -isysroot on OS X otherwise the tests will fail if you don't have the command line tools package installed.

2015-10-11 Thread Chris Bieneman via cfe-commits
CMake handles doing it while building. I will update to use lit.util.* -Chris > On Oct 11, 2015, at 6:04 PM, Eric Fiselier wrote: > > Do we need to do with while building libc++ as well? Also please reuse > lit.util.capture or lit.util.executeCommand instead of subprocess. > >

[libcxx] r250007 - [Darwin] Reworking r250003 to use lit.util.capture instead of subprocess.

2015-10-11 Thread Chris Bieneman via cfe-commits
Author: cbieneman Date: Sun Oct 11 21:54:30 2015 New Revision: 250007 URL: http://llvm.org/viewvc/llvm-project?rev=250007=rev Log: [Darwin] Reworking r250003 to use lit.util.capture instead of subprocess. Modified: libcxx/trunk/test/libcxx/test/config.py Modified:

Re: [libcxx] r250003 - [Darwin] Need to add -isysroot on OS X otherwise the tests will fail if you don't have the command line tools package installed.

2015-10-11 Thread Chris Bieneman via cfe-commits
Updated in r250007. -Chris > On Oct 11, 2015, at 7:49 PM, Chris Bieneman via cfe-commits > wrote: > > CMake handles doing it while building. I will update to use lit.util.* > > -Chris > >> On Oct 11, 2015, at 6:04 PM, Eric Fiselier >

Re: [PATCH] D12501: [clang-format] Obj-C dictionary literals: Fixed typecast getting put on a separate line from the key

2015-10-11 Thread Daniel Jasper via cfe-commits
djasper closed this revision. djasper added a comment. Submitted as r250010. http://reviews.llvm.org/D12501 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r250008 - bindings: add new C++ function attribute accessors

2015-10-11 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Oct 11 22:10:20 2015 New Revision: 250008 URL: http://llvm.org/viewvc/llvm-project?rev=250008=rev Log: bindings: add new C++ function attribute accessors Add methods to index Cursor to see if a cxx method is pure_virtual, virtual or const methods. Patch by Jonathan B