EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land.
LGTM but this is still blocked by http://reviews.llvm.org/D13407. Ill let you know once that has landed. ================ Comment at: include/__config:251 @@ +250,3 @@ + !defined(__arm__)) || \ + defined(_LIBCPP_ALTERNATE_STRING_LAYOUT) +#define _LIBCPP_ABI_ALTERNATE_STRING_LAYOUT ---------------- Is this the last remaining reference to `_LIBCPP_ALTERNATIVE_STRING_LAYOUT`? If so please leave a note about how this is the old name and is used here to be backward compatible. ================ Comment at: include/__config:252 @@ -246,1 +251,3 @@ + defined(_LIBCPP_ALTERNATE_STRING_LAYOUT) +#define _LIBCPP_ABI_ALTERNATE_STRING_LAYOUT #endif ---------------- I think he's demonstrating the patches functionality and intended usage by converting an existing option. Future ABI options should probably start with the macro prefix '_LIBCPP_ABI' anyway. Repository: rL LLVM http://reviews.llvm.org/D11740 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
