ygribov added a comment.
> What happens when this checker and the security.insecureAPI.vfork are enabled
> at the same time?
Both checkers will emit warnings independently (which I think is ok).
> Did you run this checker on a large body of code? Did it find any issues?
Yes, I've ran it on A
vkalintiris added a comment.
In http://reviews.llvm.org/D13673#271518, @EricWF wrote:
> Thanks for the update, I think this should be good to go. I'll give it a
> final once over tonight.
Ping.
http://reviews.llvm.org/D13673
___
cfe-commits mail
seaneveson updated this revision to Diff 38717.
seaneveson added a comment.
Updated to latest revision
http://reviews.llvm.org/D12358
Files:
include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
include/clang/StaticAnalyzer/Core/PathSensitive/LoopWidening.h
lib/StaticAnalyzer/Core/AnalyzerO
This revision was automatically updated to reflect the committed changes.
Closed by commit rL251621: [Analyzer] Widening loops which do not exit
(authored by seaneveson).
Changed prior to commit:
http://reviews.llvm.org/D12358?vs=38717&id=38718#toc
Repository:
rL LLVM
http://reviews.llvm.or
Author: seaneveson
Date: Thu Oct 29 05:04:41 2015
New Revision: 251621
URL: http://llvm.org/viewvc/llvm-project?rev=251621&view=rev
Log:
[Analyzer] Widening loops which do not exit
Summary:
Dear All,
We have been looking at the following problem, where any code after the
constant bound loop is
angelgarcia updated this revision to Diff 38727.
angelgarcia added a comment.
Add tests.
http://reviews.llvm.org/D14152
Files:
include/clang/ASTMatchers/ASTMatchers.h
unittests/ASTMatchers/ASTMatchersTest.cpp
Index: unittests/ASTMatchers/ASTMatchersTest.cpp
angelgarcia updated this revision to Diff 38728.
angelgarcia added a comment.
Put more logic into the matchers.
Btw, do you know how can I get the exception specification of a function?
http://reviews.llvm.org/D14145
Files:
clang-tidy/modernize/UseDefaultCheck.cpp
test/clang-tidy/modernize
angelgarcia updated this revision to Diff 38730.
angelgarcia marked an inline comment as done.
angelgarcia added a comment.
Remove debugging code.
http://reviews.llvm.org/D14145
Files:
clang-tidy/modernize/UseDefaultCheck.cpp
test/clang-tidy/modernize-use-default-copy.cpp
test/clang-tidy/
angelgarcia created this revision.
angelgarcia added a reviewer: klimek.
angelgarcia added subscribers: cfe-commits, alexfh.
If the size of the type is above a certain bound, we'll take a const reference.
This bound can be set as an option. For now, the default value is 16 bytes.
http://reviews.
ygribov updated this revision to Diff 38740.
ygribov added a comment.
Updated after Anna's review.
http://reviews.llvm.org/D14014
Files:
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/VforkChecker.cpp
test/Analysis/Inputs/s
ygribov marked 15 inline comments as done.
Comment at: lib/StaticAnalyzer/Checkers/VforkChecker.cpp:45
@@ +44,3 @@
+ CheckerContext &C) {
+ const Expr *CE = Call.getOriginExpr();
+
It seems that other checkers do more or less the
Author: vkalintiris
Date: Thu Oct 29 10:33:53 2015
New Revision: 251633
URL: http://llvm.org/viewvc/llvm-project?rev=251633&view=rev
Log:
[mips] Add support for the new mips-mti-linux toolchain.
The original commit in r249137 added the mips-mti-linux toolchain. However,
the newly added tests of t
michaelwu added a comment.
Review ping?
http://reviews.llvm.org/D13388
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
martell created this revision.
martell added a reviewer: rnk.
martell added a subscriber: cfe-commits.
GCC versions starting at 4.8+ conform to standard Windows 64-bit ABI.
Not quite sure if we should keep this to support mingw-w64 and gcc 4.6
Thoughts ?
Also it seems to fix:
https://llvm.org/bug
On 28 October 2015 at 16:33, Galina Kistanova via llvm-commits
wrote:
> E-mail notification has been changed in the buildmaster. Now it should not
> count interrupted builds to figure out if notification should be send.
Thanks Galina, that'll reduce the noise considerably!
cheers,
--renato
_
martell created this revision.
martell added a reviewer: rnk.
martell added subscribers: cfe-commits, yaron.keren, compnerd.
As of commit b8a164 mingw-w64 support clang with -fms-extensions.
We can built the mingw-w64 crt with clang now also.
As we are dropping support for mingw.org I think switch
Author: ehsan
Date: Thu Oct 29 12:20:17 2015
New Revision: 251638
URL: http://llvm.org/viewvc/llvm-project?rev=251638&view=rev
Log:
Add a link to the DXR project
DXR is a project developed at Mozilla that implements a code indexing
and browsing utility on top of libclang that has features such as
Author: sylvestre
Date: Thu Oct 29 12:27:55 2015
New Revision: 251639
URL: http://llvm.org/viewvc/llvm-project?rev=251639&view=rev
Log:
add support of the latest Ubuntu (Xenial Xerus)
Modified:
cfe/trunk/lib/Driver/ToolChains.cpp
Modified: cfe/trunk/lib/Driver/ToolChains.cpp
URL:
http://llv
awson added a subscriber: awson.
awson added a comment.
Btw, It is a terrible bug.
It is hard to imagine how much C++ code it renders broken on 64-bit mingw-w64
clang. For example, any of hashtable-using code doesn't work etc etc.
http://reviews.llvm.org/D14179
_
Author: djasper
Date: Thu Oct 29 14:05:20 2015
New Revision: 251643
URL: http://llvm.org/viewvc/llvm-project?rev=251643&view=rev
Log:
clang-format: [JS] Add goog.setTestOnly to the list of stuff that
is import-statement-like and shouldn't be wrapped.
Modified:
cfe/trunk/lib/Format/TokenAnnota
rnk added a comment.
Rafael, we don't support pre GCC 4.7 mingw right? They switched to thiscall on
32bit, right? I think we can take a break for x64.
http://reviews.llvm.org/D14179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
LGTM.
Thanks!
-eric
http://reviews.llvm.org/D13610
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
Author: nico
Date: Thu Oct 29 15:43:31 2015
New Revision: 251650
URL: http://llvm.org/viewvc/llvm-project?rev=251650&view=rev
Log:
Suppress uninteresting output from crash-recovery-modules.m
No behavior change, but it makes this test a bit easier to debug when it fails.
Modified:
cfe/trunk/t
rjmccall added a comment.
Sorry for the delay. Committed with a few minor tweaks in r251650.
http://reviews.llvm.org/D12793
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rjmccall
Date: Thu Oct 29 15:48:01 2015
New Revision: 251651
URL: http://llvm.org/viewvc/llvm-project?rev=251651&view=rev
Log:
Add support for __builtin_{add,sub,mul}_overflow.
Patch by David Grayson!
Added:
cfe/trunk/test/Sema/builtins-overflow.c
Modified:
cfe/trunk/docs/Languag
Author: nico
Date: Thu Oct 29 15:53:49 2015
New Revision: 251653
URL: http://llvm.org/viewvc/llvm-project?rev=251653&view=rev
Log:
Mark InternalDebugOpt driver options as CoreOptions.
Mostly has the effect of making -ccc-print-phases usable from clang-cl.
Modified:
cfe/trunk/include/clang/Dr
Correct. I we just switched to the 4.7 abi in r197163.
Cheers,
Rafael
On 29 October 2015 at 12:25, Reid Kleckner wrote:
> rnk added a comment.
>
> Rafael, we don't support pre GCC 4.7 mingw right? They switched to thiscall
> on 32bit, right? I think we can take a break for x64.
>
>
> http://re
compnerd created this revision.
compnerd added a reviewer: djasper.
compnerd added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Correct handling for C++17 inline namespaces. We would previously fail to
identify the inline namespaces as a namespace name since multiple ones may be
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Expression can be simplified, otherwise looks good.
Comment at: lib/Format/UnwrappedLineParser.cpp:1370
@@ -1369,2 +1369,3 @@
nextToken();
- if (FormatTok->Tok.is(tok::i
Author: rsmith
Date: Thu Oct 29 18:32:29 2015
New Revision: 251665
URL: http://llvm.org/viewvc/llvm-project?rev=251665&view=rev
Log:
Revert r249929 ("Split out of ").
This change caused problems when building code like povray that:
a) uses 'using namespace std;'
b) is built on an environment whe
Author: rjmccall
Date: Thu Oct 29 18:36:14 2015
New Revision: 251666
URL: http://llvm.org/viewvc/llvm-project?rev=251666&view=rev
Log:
Fix the emission of ARC ivar layouts in the non-fragile Mac runtime.
My previous change in this area accidentally broke the rule when
InstanceBegin was not a mult
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D14152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D14176
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
rjmccall added a comment.
In http://reviews.llvm.org/D12614#274349, @sfantao wrote:
> Hi John,
>
> Thanks for the remark!
>
> In http://reviews.llvm.org/D12614#272354, @rjmccall wrote:
>
> > CurFuncDecl is supposed to be the enclosing user function. Things like
> > outlined functions should be
Hi,
The attached patch undoes the revert of r249929, and adds an extension to
allow (and ) to work properly even in environments such
as iOS where the underlying libc does not provide C++'s const-correct
overloads of strchr and friends.
This works as follows:
* The macro _LIBCPP_PREFERRED_OVER
I reverted this change in r251665, and started a new thread for the patch
to reinstate this and fix the ambiguity issue.
On Wed, Oct 28, 2015 at 11:01 AM, Michael Zolotukhin via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hi Eric, Richard,
>
> Any news on this? The test is still broken, sh
alexfh created this revision.
alexfh added a reviewer: klimek.
alexfh added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
This is needed to handle per-project configurations when adding extra
arguments in clang-tidy for example.
http://reviews.llvm.org/D14191
Files:
include/cla
Author: rjmccall
Date: Thu Oct 29 19:56:02 2015
New Revision: 251677
URL: http://llvm.org/viewvc/llvm-project?rev=251677&view=rev
Log:
Initialize @catch variables correctly in fragile-runtime ARC.
Modified:
cfe/trunk/lib/CodeGen/CGObjCMac.cpp
cfe/trunk/lib/CodeGen/CGObjCRuntime.cpp
cf
alexfh created this revision.
alexfh added a reviewer: klimek.
alexfh added a subscriber: cfe-commits.
This patch depends on http://reviews.llvm.org/D14191
http://reviews.llvm.org/D14192
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidyOptions.cpp
clang-tidy/ClangTidyOptions.h
modular
aturetsk created this revision.
aturetsk added a reviewer: rsmith.
aturetsk added subscribers: cfe-commits, mkuper, DavidKreitzer, anadolskiy,
zansari.
Add initial support of -miamcu option which triggers MCU ABI.
http://reviews.llvm.org/D14146
Files:
include/clang/Driver/Options.td
lib/Dri
s/__NetBSD_\)/__NetBSD__\)/
From: Vasileios Kalintiris [vasileios.kalinti...@imgtec.com]
Sent: Thursday, October 29, 2015 2:50 AM
To: vasileios.kalinti...@imgtec.com; mclow.li...@gmail.com; Roelofs, Jonathan;
e...@efcs.ca
Cc: j...@chromium.org; tbergham...@
Dushistov created this revision.
Dushistov added reviewers: Ayal, zaks.anna, dcoughlin, xazax.hun.
Dushistov added a subscriber: cfe-commits.
Recent version of clang (3.7) start complain about such code:
void send(QObject *obj)
{
QKeyEvent *event = new QKeyEvent(QEvent::KeyRelease, Qt::Key
compnerd requested changes to this revision.
compnerd added a reviewer: compnerd.
compnerd added a comment.
This revision now requires changes to proceed.
Please add a unit test for this.
http://reviews.llvm.org/D14180
___
cfe-commits mailing list
c
Author: compnerd
Date: Fri Oct 30 00:07:56 2015
New Revision: 251690
URL: http://llvm.org/viewvc/llvm-project?rev=251690&view=rev
Log:
Format: support inline namespaces
Correct handling for C++17 inline namespaces. We would previously fail to
identify the inline namespaces as a namespace name si
mgrabovsky added a comment.
Any other remarks?
http://reviews.llvm.org/D13643
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
45 matches
Mail list logo
