Re: [PATCH] D14229: Remove unreachable that was reached in modernize-use-nullptr.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good with one nit. Comment at: test/clang-tidy/modernize-use-nullptr.cpp:191 @@ +190,3 @@ +char function(NoDef *p); +#define F(x) \ +(sizeof(function(x)) == 1)

Re: [PATCH] D12761: MPI-Checker patch for Clang Static Analyzer

Alexander_Droste marked 26 inline comments as done. Alexander_Droste added a comment. http://reviews.llvm.org/D12761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r251802 - Remove undefined behavior from some tests. Thanks to Walter Brown for the heads-up.

Author: marshall Date: Mon Nov 2 09:25:53 2015 New Revision: 251802 URL: http://llvm.org/viewvc/llvm-project?rev=251802=rev Log: Remove undefined behavior from some tests. Thanks to Walter Brown for the heads-up. Modified:

[libcxx] r251804 - Remove undefined behavior from some tests. Same pattern as the unitialized_copy tests

Author: marshall Date: Mon Nov 2 09:29:13 2015 New Revision: 251804 URL: http://llvm.org/viewvc/llvm-project?rev=251804=rev Log: Remove undefined behavior from some tests. Same pattern as the unitialized_copy tests Modified:

Re: [PATCH] D14229: Remove unreachable that was reached in modernize-use-nullptr.

angelgarcia updated this revision to Diff 38918. angelgarcia added a comment. Merge lines. http://reviews.llvm.org/D14229 Files: clang-tidy/modernize/UseNullptrCheck.cpp test/clang-tidy/modernize-use-nullptr.cpp Index: test/clang-tidy/modernize-use-nullptr.cpp

[clang-tools-extra] r251803 - Remove unreachable that was reached in modernize-use-nullptr.

Author: angelgarcia Date: Mon Nov 2 09:28:06 2015 New Revision: 251803 URL: http://llvm.org/viewvc/llvm-project?rev=251803=rev Log: Remove unreachable that was reached in modernize-use-nullptr. Summary: When traversing the parent map, the check assumed that all the nodes would be either Stmt

Re: [PATCH] D14014: Checker of proper vfork usage

ygribov added inline comments. Comment at: lib/StaticAnalyzer/Checkers/DereferenceChecker.cpp:118 @@ +117,3 @@ +std::tie(VD, Init) = parseAssignment(S); +if (VD && Init) + S = Init; Semantics is slightly changed for assignment case here: originally S

Re: [PATCH] D13786: [Sema] Implement __make_integer_seq

majnemer added a comment. Ping. http://reviews.llvm.org/D13786 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14198: Make the modernize-loop-convert's const-detection smarter.

klimek added inline comments. Comment at: clang-tidy/modernize/LoopConvertCheck.cpp:371-374 @@ -370,1 +370,6 @@ +/// \brief Returns false when it can be guaranteed that no element of the +/// container we are iterating over is going to be modified due to this +/// expression.

r251813 - Clang format a few prior patches (NFC)

Author: tejohnson Date: Mon Nov 2 12:03:12 2015 New Revision: 251813 URL: http://llvm.org/viewvc/llvm-project?rev=251813=rev Log: Clang format a few prior patches (NFC) I had clang formatted my earlier patches using the wrong style. Reformatted with the LLVM style. Modified:

Re: [PATCH] D14014: Checker of proper vfork usage

ygribov updated this revision to Diff 38926. ygribov marked 2 inline comments as done. ygribov added a comment. Updated after review. http://reviews.llvm.org/D14014 Files: include/clang/StaticAnalyzer/Core/PathSensitive/CheckerHelpers.h lib/StaticAnalyzer/Checkers/CMakeLists.txt

Re: [PATCH] D5767: Template Instantiation Observer + a few other templight-related changes

klimek added a comment. Ok, just let me know when you have an updated patch out for review for submission, so I can make sure we'll get the reviews done in a timely fashion. I really want to see this go in :) http://reviews.llvm.org/D5767 ___

Re: [PATCH] D13973: CFG: Delay creating Dtors for CompoundStmts which end in ReturnStmt

jordan_rose added a subscriber: dcoughlin. jordan_rose added a comment. Hm. On the one hand, getting this right seems like a nice property, and even adding another loop wouldn't change the order of growth. On the other hand, not having the extra destructors seems like the same sort of property

r251810 - Sink some PTHManager includes out of Preprocessor.h

Author: rnk Date: Mon Nov 2 11:53:55 2015 New Revision: 251810 URL: http://llvm.org/viewvc/llvm-project?rev=251810=rev Log: Sink some PTHManager includes out of Preprocessor.h This reduces the number of .cpp files needed to be rebuilt after touching OnDiskHashTable from 120 to 21 for me.

Re: [PATCH] D12922: Add support for function attribute "notail"

ahatanak added inline comments. Comment at: lib/Sema/SemaDecl.cpp:5374 @@ +5373,3 @@ + + // Virtual functions cannot be marked as 'notail'. + if (auto *Attr = ND.getAttr()) aaron.ballman wrote: > I am not home yet, and so I don't have the source code to try

r251900 - Fix a couple intrinsic header comments. NFC

Author: ctopper Date: Tue Nov 3 00:16:31 2015 New Revision: 251900 URL: http://llvm.org/viewvc/llvm-project?rev=251900=rev Log: Fix a couple intrinsic header comments. NFC Modified: cfe/trunk/lib/Headers/avx512erintrin.h cfe/trunk/lib/Headers/avx512fintrin.h Modified:

r251902 - [X86] Rounding mode for roundps/pd/ss/sd builtins should be an ICE.

Author: ctopper Date: Tue Nov 3 01:20:07 2015 New Revision: 251902 URL: http://llvm.org/viewvc/llvm-project?rev=251902=rev Log: [X86] Rounding mode for roundps/pd/ss/sd builtins should be an ICE. Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.def Modified:

r251824 - clang-format: Simplify and improve stop condition for formatting

Author: djasper Date: Mon Nov 2 14:02:49 2015 New Revision: 251824 URL: http://llvm.org/viewvc/llvm-project?rev=251824=rev Log: clang-format: Simplify and improve stop condition for formatting unaffected lines with incorrect initial indent. Starting from: namespace { int i; // There

r251828 - [PTH] Fix data length used for stat cache entries

Author: rnk Date: Mon Nov 2 14:47:31 2015 New Revision: 251828 URL: http://llvm.org/viewvc/llvm-project?rev=251828=rev Log: [PTH] Fix data length used for stat cache entries This came up in a boost build, which apparently uses PTH. This was broken in r187619 when we migrated it to uses llvm::fs

Re: [clang-tools-extra] r250824 - Apply modernize-use-default to clang-tools-extra.

On Tue, Oct 20, 2015 at 5:56 AM, Angel Garcia Gomez via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: angelgarcia > Date: Tue Oct 20 07:56:27 2015 > New Revision: 250824 > > URL: http://llvm.org/viewvc/llvm-project?rev=250824=rev > Log: > Apply modernize-use-default to

Re: [PATCH] D12922: Add support for function attribute "notail"

ahatanak updated this revision to Diff 38967. ahatanak added a comment. Fixed test cases: - Added a test case for the attribute being specified on a variable. - Added a missing 's' to "virtual function" in the check strings. http://reviews.llvm.org/D12922 Files: include/clang/Basic/Attr.td

Re: [PATCH] D13786: [Sema] Implement __make_integer_seq

rsmith added inline comments. Comment at: lib/AST/ASTDumper.cpp:1340-1344 @@ +1339,7 @@ + dumpName(D); + switch (D->getBuiltinTemplateKind()) { + case BTK__make_integer_seq: +OS << " __make_integer_seq"; +break; + } +

Re: [PATCH] D12922: Add support for function attribute "notail"

ahatanak added inline comments. Comment at: test/Sema/attr-notail.c:9 @@ +8,3 @@ +} + +int g0 __attribute__((not_tail_called)); // expected-warning {{'not_tail_called' attribute only applies to functions}} I didn't understand what kind of test case is required

Re: [PATCH] D14259: The maximum alignment of std::aligned_storage applies to all Windows compilers

compnerd added a subscriber: compnerd. compnerd accepted this revision. compnerd added a reviewer: compnerd. compnerd added a comment. This revision is now accepted and ready to land. Yeah, this is a COFF limitation. Its unfortunate we don't have a better way to detect COFF targets.

[PATCH] D14238: Fix another crash in the redundant-void-arg check.

angelgarcia created this revision. angelgarcia added a reviewer: alexfh. angelgarcia added subscribers: cfe-commits, klimek. The check was assuming that a definition of a function always has a body, but a declaration that explicitly defaults or deletes a function is a definition too.

Re: [PATCH] D14238: Fix another crash in the redundant-void-arg check.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Thanks for the fix! LG http://reviews.llvm.org/D14238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D14198: Make the modernize-loop-convert's const-detection smarter.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG. Much better, thanks! http://reviews.llvm.org/D14198 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D14014: Checker of proper vfork usage

ygribov marked 5 inline comments as done. ygribov added a comment. http://reviews.llvm.org/D14014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11944: Nativize filename in FileManager::getFile().

klimek added a reviewer: bkramer. klimek added a comment. +Benjamin to share another yak :D http://reviews.llvm.org/D11944 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r251808 - Make the modernize-loop-convert's const-detection smarter.

Author: angelgarcia Date: Mon Nov 2 11:02:52 2015 New Revision: 251808 URL: http://llvm.org/viewvc/llvm-project?rev=251808=rev Log: Make the modernize-loop-convert's const-detection smarter. Summary: Now, it detects that several kinds of usages are can't modify the elements. Examples: -When an

[clang-tools-extra] r251807 - Fix another crash in the redundant-void-arg check.

Author: angelgarcia Date: Mon Nov 2 10:18:23 2015 New Revision: 251807 URL: http://llvm.org/viewvc/llvm-project?rev=251807=rev Log: Fix another crash in the redundant-void-arg check. Summary: The check was assuming that a definition of a function always has a body, but a declaration that

Re: [PATCH] D14198: Make the modernize-loop-convert's const-detection smarter.

angelgarcia updated this revision to Diff 38930. angelgarcia added a comment. OK, is it better now? http://reviews.llvm.org/D14198 Files: clang-tidy/modernize/LoopConvertCheck.cpp test/clang-tidy/modernize-loop-convert-basic.cpp test/clang-tidy/modernize-loop-convert-camelback.cpp

Re: [PATCH] D14191: Make ArgumentAdjuster aware of the current file being processed.

alexfh added a comment. Ping. http://reviews.llvm.org/D14191 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14192: Add ExtraArgs and ExtraArgsBefore options to enable clang warnings via configuration files.

alexfh added a comment. Ping. http://reviews.llvm.org/D14192 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14170: Fix false positive warning about memory leak for QApplication::postEvent

zaks.anna added a comment. This needs a test case. You can either extend ./test/Analysis/malloc.cpp or add another QT specific test file. Thanks! Anna. http://reviews.llvm.org/D14170 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13973: CFG: Delay creating Dtors for CompoundStmts which end in ReturnStmt

mgehre added a comment. Basically, there are the following cases: A) void f() { S s; } Everything OK, only one (reachable) destructor is generated B) int f() { S s; return 1; } In current trunk, this first generates dtor in a block when visiting the CompoundStmt, and then

Re: [PATCH] D14096: [clang-tidy] add new check cppcoreguidelines-pro-type-cstyle-cast

mgehre updated this revision to Diff 38981. mgehre added a comment. Update for review comments http://reviews.llvm.org/D14096 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp

Re: [PATCH] D13925: Implement __attribute__((internal_linkage))

rsmith added inline comments. Comment at: include/clang/Basic/Attr.td:2125 @@ +2124,3 @@ + +def InternalLinkage : InheritableAttr { + let Spellings = [GNU<"internal_linkage">, CXX11<"clang", "internal_linkage">]; `InheritableAttr` doesn't seem right for the

Re: [PATCH] D14179: Remove some legacy mingw-w64 gcc struct info

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Yeah, lgtm. http://reviews.llvm.org/D14179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D14259: The maximum alignment of std::aligned_storage applies to all Windows compilers

rnk created this revision. rnk added reviewers: danalbert, mclow.lists. rnk added a subscriber: cfe-commits. According to Clang's sources, the maximum supported storage alignment is a property of the COFF object file format. Fixes building libc++ with Clang on Windows.

RE: [PATCH] D14239: mips-mti-linux TC + debug log

Hi Renato, Thanks for testing this. The /tmp/mips-mti-linux.log file contains log messages from the driver. It wasn't my intention to match anything meaningful from the mips-mti-linux.c test. I'll try to investigate what's going wrong tomorrow. Thanks, Vasileios

[libcxx] r251836 - Make reverse() call iter_swap like the standard says, instead of calling swap directly. No real change.

Author: marshall Date: Mon Nov 2 15:34:25 2015 New Revision: 251836 URL: http://llvm.org/viewvc/llvm-project?rev=251836=rev Log: Make reverse() call iter_swap like the standard says, instead of calling swap directly. No real change. Modified: libcxx/trunk/include/algorithm Modified:

Re: [PATCH] D14096: [clang-tidy] add new check cppcoreguidelines-pro-type-cstyle-cast

mgehre added inline comments. Comment at: clang-tidy/cppcoreguidelines/ProTypeCstyleCastCheck.cpp:80 @@ +79,3 @@ + std::string CastText = ("dynamic_cast<" + DestTypeString + ">").str(); + if (!isa(SubExpr)) { +CastText.push_back('(');

Re: [PATCH] D13925: Implement __attribute__((internal_linkage))

rnk accepted this revision. rnk added a reviewer: rnk. rnk added a comment. This revision is now accepted and ready to land. I'm happy with this. Richard, what do you think? Repository: rL LLVM http://reviews.llvm.org/D13925 ___ cfe-commits

r251783 - [MS ABI] Don't zero-initialize vbptrs in bases

Author: majnemer Date: Mon Nov 2 03:01:44 2015 New Revision: 251783 URL: http://llvm.org/viewvc/llvm-project?rev=251783=rev Log: [MS ABI] Don't zero-initialize vbptrs in bases Certain CXXConstructExpr nodes require zero-initialization before a constructor is called. We had a bug in the case

r251786 - [x86] Front-end part of MCU psABI support

Author: asbokhan Date: Mon Nov 2 03:54:17 2015 New Revision: 251786 URL: http://llvm.org/viewvc/llvm-project?rev=251786=rev Log: [x86] Front-end part of MCU psABI support This patch implements two things in front-end for MCU psABI support: 1) "long double type is the same as double." 2) "New

Re: [PATCH] D14205: [x86] Front-end part of MCU psABI support

This revision was automatically updated to reflect the committed changes. Closed by commit rL251786: [x86] Front-end part of MCU psABI support (authored by asbokhan). Changed prior to commit: http://reviews.llvm.org/D14205?vs=38814=38878#toc Repository: rL LLVM

Re: Porting Clang to a new architecture

On Mon, Oct 26, 2015 at 12:58:46PM -0300, Ariel Arelovich via cfe-commits wrote: > So this is what I wanted to know. I think understand what you are saying. > You are saying that most of the work that I would need to do from the AST > (I'm assuming that this stands from Abstract Syntax Tree) is

Re: Porting Clang to a new architecture

Yes! Thank you. I've begun reading up on this, and it is effectively what I want to do. I working on modifying LLVM code. One question that I still can't answer is the whole standard libraries. Are these precompiled for a given backend? Do I need to write them for my proposed arquitecture? Or

Re: [PATCH] D14096: [clang-tidy] add new check cppcoreguidelines-pro-type-cstyle-cast

On Sun, Nov 01, 2015 at 08:48:53PM -0500, Aaron Ballman via cfe-commits wrote: > On Sun, Nov 1, 2015 at 2:31 PM, Joerg Sonnenberger via cfe-commits > wrote: > > On Tue, Oct 27, 2015 at 06:10:26PM +, Samuel Benzaquen via cfe-commits > > wrote: > >> sbenza added a

Re: Porting Clang to a new architecture

On Mon, Nov 02, 2015 at 06:30:07AM -0300, Ariel Arelovich via cfe-commits wrote: > One question that I still can't answer is the whole standard libraries. Are > these precompiled for a given backend? Do I need to write them for my > proposed arquitecture? > > Or by simply writing a new backend

Re: [PATCH] D14205: [x86] Front-end part of MCU psABI support

andreybokhanko added a comment. Michael, Thanks for the review! As for your comment, I will investigate and fix (if needed). Andrey Comment at: lib/Basic/Targets.cpp:2327 @@ -2325,3 +2326,3 @@ // X87 evaluates with 80 bits "long double" precision. return SSELevel

Re: [PATCH] D12922: Add support for function attribute "notail"

aaron.ballman added inline comments. Comment at: test/Sema/attr-notail.c:9 @@ +8,3 @@ +} + +int g0 __attribute__((not_tail_called)); // expected-warning {{'not_tail_called' attribute only applies to functions}} ahatanak wrote: > I didn't understand what kind of

Re: [PATCH] D12031: Const std::move() argument ClangTidy check

alexfh added a comment. Vadym, what's the state of this patch? http://reviews.llvm.org/D12031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11944: Nativize filename in FileManager::getFile().

bkramer added a comment. Can you try setting up the virtual files with the vfs::InMemoryFileSystem stuff? There are some examples how to set up with OverlayFileSystem in tree. InMemoryFileSystem was written with windows path separators in mind, I just never tried to run it on windows :)

Re: [PATCH] D13925: Implement __attribute__((internal_linkage))

aaron.ballman added a subscriber: aaron.ballman. aaron.ballman requested changes to this revision. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. This revision now requires changes to proceed. I would like to hold off on adding the namespace attribute. There were

Re: r251041 - Define weak and __weak to mean ARC-style weak references, even in MRC.

> On Nov 2, 2015, at 2:53 PM, Nico Weber wrote: > On Fri, Oct 30, 2015 at 5:55 PM, John McCall > wrote: > > On Oct 30, 2015, at 5:39 PM, Nico Weber > > wrote: > > Hi John, >

r251843 - Remove empty directories.

Author: alexfh Date: Mon Nov 2 16:24:28 2015 New Revision: 251843 URL: http://llvm.org/viewvc/llvm-project?rev=251843=rev Log: Remove empty directories. Removed: cfe/trunk/test/Driver/Inputs/mips_mti_linux/ ___ cfe-commits mailing list

r251842 - Make hasLHS and hasRHS matchers available for ArraySubscriptExpr

Author: alexfh Date: Mon Nov 2 16:23:21 2015 New Revision: 251842 URL: http://llvm.org/viewvc/llvm-project?rev=251842=rev Log: Make hasLHS and hasRHS matchers available for ArraySubscriptExpr Summary: The hasBase and hasIndex don't tell anything about the position of the base and the index in

Re: r251041 - Define weak and __weak to mean ARC-style weak references, even in MRC.

On Mon, Nov 2, 2015 at 3:00 PM, John McCall wrote: > On Nov 2, 2015, at 2:53 PM, Nico Weber wrote: > On Fri, Oct 30, 2015 at 5:55 PM, John McCall wrote: > >> > On Oct 30, 2015, at 5:39 PM, Nico Weber wrote: >> >

Re: [PATCH] D14096: [clang-tidy] add new check cppcoreguidelines-pro-type-cstyle-cast

On Mon, Nov 2, 2015 at 4:43 AM, Joerg Sonnenberger via cfe-commits wrote: > On Sun, Nov 01, 2015 at 08:48:53PM -0500, Aaron Ballman via cfe-commits wrote: >> On Sun, Nov 1, 2015 at 2:31 PM, Joerg Sonnenberger via cfe-commits >> wrote: >> >

Re: [PATCH] D14198: Make the modernize-loop-convert's const-detection smarter.

angelgarcia added a comment. > Reading just this function, it is unclear what the 'container' is. It should be clearer now. > Can't CaptureBuRef be modified? I added a comment with an explanation. > But they are aliases. Shouldn't we then go into the const-ness of the aliases? I wanted to

Re: [PATCH] D14198: Make the modernize-loop-convert's const-detection smarter.

angelgarcia updated this revision to Diff 38881. angelgarcia added a comment. Improve comments and add more tests. http://reviews.llvm.org/D14198 Files: clang-tidy/modernize/LoopConvertCheck.cpp test/clang-tidy/modernize-loop-convert-basic.cpp

[PATCH] D14225: Try to fix buildbots failure.

angelgarcia created this revision. angelgarcia added a subscriber: cfe-commits. Add -fexceptions flag to enable exceptions. http://reviews.llvm.org/D14225 Files: test/clang-tidy/modernize-use-default-copy.cpp test/clang-tidy/modernize-use-default.cpp Index:

Re: [PATCH] D14204: Fix crash in redundant-void-arg check.

angelgarcia updated this revision to Diff 38889. angelgarcia added a comment. Sorry, I forgot. That case works just fine. http://reviews.llvm.org/D14204 Files: clang-tidy/modernize/RedundantVoidArgCheck.cpp test/clang-tidy/modernize-redundant-void-arg.cpp Index:

Re: [PATCH] D14204: Fix crash in redundant-void-arg check.

alexfh accepted this revision. alexfh added a reviewer: alexfh. alexfh added a comment. This revision is now accepted and ready to land. Thanks! Looks good! http://reviews.llvm.org/D14204 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D14204: Fix crash in redundant-void-arg check.

This revision was automatically updated to reflect the committed changes. Closed by commit rL251792: Fix crash in redundant-void-arg check. (authored by angelgarcia). Changed prior to commit: http://reviews.llvm.org/D14204?vs=38889=38890#toc Repository: rL LLVM

[clang-tools-extra] r251790 - Try to fix buildbots failure.

Author: angelgarcia Date: Mon Nov 2 04:54:50 2015 New Revision: 251790 URL: http://llvm.org/viewvc/llvm-project?rev=251790=rev Log: Try to fix buildbots failure. Summary: Add -fexceptions flag to enable exceptions. Subscribers: cfe-commits Differential Revision: http://reviews.llvm.org/D14225

Re: [PATCH] D14225: Try to fix buildbots failure.

This revision was automatically updated to reflect the committed changes. Closed by commit rL251790: Try to fix buildbots failure. (authored by angelgarcia). Changed prior to commit: http://reviews.llvm.org/D14225?vs=38885=38886#toc Repository: rL LLVM http://reviews.llvm.org/D14225

Re: [PATCH] D13351: [Power PC] add soft float support for ppc32

spetrovic updated this revision to Diff 3. spetrovic added a comment. added test case http://reviews.llvm.org/D13351 Files: lib/CodeGen/TargetInfo.cpp lib/Driver/Tools.cpp lib/Driver/Tools.h test/CodeGen/ppc-sfvarargs.c test/Driver/ppc-features.cpp Index:

[clang-tools-extra] r251792 - Fix crash in redundant-void-arg check.

Author: angelgarcia Date: Mon Nov 2 05:39:17 2015 New Revision: 251792 URL: http://llvm.org/viewvc/llvm-project?rev=251792=rev Log: Fix crash in redundant-void-arg check. Summary: When applying this check to the unit tests, it would hit an assertion: llvm/tools/clang/lib/Lex/Lexer.cpp:1056:

[PATCH] D14224: Added processing of several AST nodes in ASTNodeImporter.

sepavloff created this revision. sepavloff added a subscriber: cfe-commits. http://reviews.llvm.org/D14224 Files: lib/AST/ASTImporter.cpp test/ASTMerge/Inputs/class3.cpp test/ASTMerge/Inputs/exprs3.cpp test/ASTMerge/class2.cpp test/ASTMerge/exprs.cpp Index: test/ASTMerge/exprs.cpp

[clang-tools-extra] r251788 - modernize-use-default supports copy constructor and copy-assignment operator.

Author: angelgarcia Date: Mon Nov 2 04:34:19 2015 New Revision: 251788 URL: http://llvm.org/viewvc/llvm-project?rev=251788=rev Log: modernize-use-default supports copy constructor and copy-assignment operator. Summary: the check will now warn when the user provided definitions of this

Re: [PATCH] D13351: [Power PC] add soft float support for ppc32

spetrovic updated this revision to Diff 38882. spetrovic marked 5 inline comments as done. spetrovic added a comment. Comments addressed. http://reviews.llvm.org/D13351 Files: lib/CodeGen/TargetInfo.cpp lib/Driver/Tools.cpp lib/Driver/Tools.h test/CodeGen/ppc-sfvarargs.c

Re: [PATCH] D14204: Fix crash in redundant-void-arg check.

angelgarcia updated this revision to Diff 38887. angelgarcia added a comment. Use Lexer::makeFileCharRange (and a few changes due to clang-format). It seems to work as well. http://reviews.llvm.org/D14204 Files: clang-tidy/modernize/RedundantVoidArgCheck.cpp

Re: [PATCH] D14204: Fix crash in redundant-void-arg check.

alexfh added a comment. In http://reviews.llvm.org/D14204#278833, @angelgarcia wrote: > Use Lexer::makeFileCharRange (and a few changes due to clang-format). > > It seems to work as well. Can you add a test where a void argument is removed in a macro (which would be the whole point of using

Re: [PATCH] D13144: [CUDA] propagate to CUDA sub-compilations target triple of opposite side.

tra updated this revision to Diff 39017. tra added a comment. Moved CUDA toolchain selection to Compilation. Removed DeviceTriple info from CudaHostActions and CudaDeviceActions. Removed few now-unnecessary parameters and code that used them. http://reviews.llvm.org/D13144 Files:

[PATCH] D14266: CodeGen: Update for debug info API change.Depends on D14265.

pcc created this revision. pcc added a reviewer: dexonsmith. pcc added a subscriber: cfe-commits. http://reviews.llvm.org/D14266 Files: lib/CodeGen/CGDebugInfo.cpp test/CodeGen/debug-info-block-decl.c test/CodeGenCXX/debug-info-static-fns.cpp test/CodeGenCXX/debug-info-windows-dtor.cpp

Re: [PATCH] D12922: Add support for function attribute "notail"

ahatanak updated this revision to Diff 39003. ahatanak added a comment. Added test case that produces an error diagnostic if an argument is passed for not_tail_called. http://reviews.llvm.org/D12922 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td

Re: [PATCH] D12922: Add support for function attribute "notail"

aaron.ballman added inline comments. Comment at: lib/Sema/SemaDecl.cpp:5374 @@ +5373,3 @@ + + // Virtual functions cannot be marked as 'notail'. + if (auto *Attr = ND.getAttr()) I am not home yet, and so I don't have the source code to try this out, but I have

r251877 - Eliminate "rewritten decls" from the AST writer. NFC

Author: dgregor Date: Mon Nov 2 19:20:54 2015 New Revision: 251877 URL: http://llvm.org/viewvc/llvm-project?rev=251877=rev Log: Eliminate "rewritten decls" from the AST writer. NFC Modified: cfe/trunk/include/clang/Serialization/ASTWriter.h cfe/trunk/lib/Serialization/ASTWriter.cpp

Re: [PATCH] D14180: enable -fms-extensions by default on the mingw-w64 target

rnk added a comment. Will Clang be able to compile the last few stable mingw-w64 releases with this change? I'd like that to keep working. http://reviews.llvm.org/D14180 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r251874 - Stop back-patching 'readonly' Objective-C properties with 'readwrite' ones.

… and I forgot the most important part, which is that this is based on the good work of Mr. Kyrtzidis that I failed to acknowledge in the commit message. - Doug > On Nov 2, 2015, at 5:15 PM, Douglas Gregor via cfe-commits > wrote: > > Author: dgregor >

r251875 - Switch to using an explicit scope object to ensure we don't forget to pop ObjC

Author: rsmith Date: Mon Nov 2 19:19:56 2015 New Revision: 251875 URL: http://llvm.org/viewvc/llvm-project?rev=251875=rev Log: Switch to using an explicit scope object to ensure we don't forget to pop ObjC type parameters off the scope, and fix the cases where we failed to do so. Modified:

Re: [PATCH] D13357: [Concepts] Diagnose when 'concept' is specified on a specialization

nwilson updated this revision to Diff 39030. nwilson added a comment. Updating to r251898 http://reviews.llvm.org/D13357 Files: include/clang/AST/Decl.h include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDecl.cpp lib/Sema/SemaTemplate.cpp

Re: [PATCH] D13357: [Concepts] Diagnose when 'concept' is specified on a specialization

nwilson added inline comments. Comment at: lib/Sema/SemaDecl.cpp:5909 @@ +5908,3 @@ + diag::err_concept_specified_specialization) + << (IsPartialSpecialization ? 2 : 1); +NewVD->setInvalidDecl(true); Hmm, I'd lean toward leaving it as

Re: [PATCH] D13144: [CUDA] propagate to CUDA sub-compilations target triple of opposite side.

tra marked an inline comment as done. tra added a comment. http://reviews.llvm.org/D13144 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13144: [CUDA] propagate to CUDA sub-compilations target triple of opposite side.

tra updated this revision to Diff 39019. tra added a comment. Moved CUDA toolchain selection to Driver::BuildCompilation() where Compilation is set up. http://reviews.llvm.org/D13144 Files: include/clang/Driver/Action.h include/clang/Driver/Compilation.h include/clang/Driver/Driver.h

[PATCH] D14274: Add alloc_size attribute to clang

george.burgess.iv created this revision. george.burgess.iv added a reviewer: rsmith. george.burgess.iv added a subscriber: cfe-commits. This is the first in a two patch series aimed at adding the alloc_size attribute to clang. This patch adds the alloc_size attribute, docs, and all of the logic

r251898 - [modules] Rationalize the behavior of Decl::declarationReplaces, and in

Author: rsmith Date: Mon Nov 2 21:13:11 2015 New Revision: 251898 URL: http://llvm.org/viewvc/llvm-project?rev=251898=rev Log: [modules] Rationalize the behavior of Decl::declarationReplaces, and in particular don't assume that two declarations of the same kind in the same context are declaring