Re: [PATCH] D14293: [libcxx] Add -fno-exceptions libcxx builders to zorg

jroelofs added inline comments. Comment at: buildbot/osuosl/master/config/builders.py:880 @@ +879,3 @@ +# See: libcxxabi/test/lit.cfg +lit_extra_opts={'link_flags': '"-lc++abi -lc -lm -lpthread -lunwind -ldl -L/opt/llvm/lib/clang/3.6.0/lib/linux

Re: [PATCH] D14540: clang-tidy: Fix FP in MacroParenthesesChecker when using object member pointer

danielmarjamaki closed this revision. danielmarjamaki added a comment. Committed with 252608 http://reviews.llvm.org/D14540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r252610 - Explicitly #include so that we get std::move. Thanks to Walter for the bug report.

Author: marshall Date: Tue Nov 10 09:22:08 2015 New Revision: 252610 URL: http://llvm.org/viewvc/llvm-project?rev=252610=rev Log: Explicitly #include so that we get std::move. Thanks to Walter for the bug report. Modified:

Re: [PATCH] D14293: [libcxx] Add -fno-exceptions libcxx builders to zorg

rmaprath added inline comments. Comment at: buildbot/osuosl/master/config/builders.py:880 @@ +879,3 @@ +# See: libcxxabi/test/lit.cfg +lit_extra_opts={'link_flags': '"-lc++abi -lc -lm -lpthread -lunwind -ldl -L/opt/llvm/lib/clang/3.6.0/lib/linux

Re: [PATCH] D10305: [Clang Static Analyzer] Bug identification

seaneveson added a comment. In http://reviews.llvm.org/D10305#286119, @xazax.hun wrote: > A third alternative would be to have both semantic names (containing hash) > and a number suffix which indicates the ordering. Yes that would work, but I don't understand the benefit of having the

[libcxx] r252614 - Fix typo I just introduced.

Author: marshall Date: Tue Nov 10 10:10:17 2015 New Revision: 252614 URL: http://llvm.org/viewvc/llvm-project?rev=252614=rev Log: Fix typo I just introduced. Modified: libcxx/trunk/test/std/utilities/function.objects/func.invoke/invoke.pass.cpp Modified:

[libcxx] r252613 - std:: qualify ptrdiff_t in the test. Thanks to Walter for the catch

Author: marshall Date: Tue Nov 10 10:04:13 2015 New Revision: 252613 URL: http://llvm.org/viewvc/llvm-project?rev=252613=rev Log: std:: qualify ptrdiff_t in the test. Thanks to Walter for the catch Modified: libcxx/trunk/test/std/depr/depr.c.headers/stdint_h.pass.cpp Modified:

Re: [PATCH] D12906: [RFC] Bug identification("issue_hash") change for CmpRuns.py

Hi, Sorry for my late answer. We fixed the plist parser for the CodeChecker it shoud process the plist generated by the current trunk clang with the issue hash tags. Right now CodeChecker does not support forwarding additional options directly to clang (uses only the compiler options from the

Re: [PATCH] D12906: [RFC] Bug identification("issue_hash") change for CmpRuns.py

o.gyorgy added a comment. Hi, Sorry for my late answer. We fixed the plist parser for the CodeChecker it shoud process the plist generated by the current trunk clang with the issue hash tags. Right now CodeChecker does not support forwarding additional options directly to clang (uses only the

Re: [PATCH] D12906: [RFC] Bug identification("issue_hash") change for CmpRuns.py

zaks.anna added a comment. Please, move the conversation on how to configure/use CodeChecker in the particular setting elsewhere. I think it could be useful to the clang dev list; however, this patch review is not the proper place for it. http://reviews.llvm.org/D12906

Re: [Diffusion] rL246882: Don't crash on a self-alias declaration

rjmccall added a subscriber: rjmccall. rjmccall added a comment. Hmm. That cast to GlobalAlias seems quite brittle anyway; it would be good to fix it (and diagnose the fact that forming the alias failed). But this change seems independently useful. Approved for 3.7. Users: hfinkel

Re: [PATCH] D12686: Add support for GCC's '__auto_type' extension.

comex updated this revision to Diff 39838. comex marked 16 inline comments as done. http://reviews.llvm.org/D12686 Files: include/clang/AST/ASTContext.h include/clang/AST/Type.h include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticParseKinds.td

Re: [PATCH] D12686: Add support for GCC's '__auto_type' extension.

comex added a comment. Addressed comments. Thanks, rsmith! Comment at: lib/Sema/SemaType.cpp:3756-3760 @@ -3743,2 +3755,7 @@ } +} else if (D.getDeclSpec().getTypeSpecType() == DeclSpec::TST_auto_type) { +

Re: [PATCH] D14441: [OpenCL] Pipe types support.

pekka.jaaskelainen requested changes to this revision. pekka.jaaskelainen added a comment. This revision now requires changes to proceed. Only small issues found, plus it could use some more test cases. Comment at: include/clang/AST/TypeLoc.h:2049 @@ +2048,3 @@ + SourceRange

Re: [PATCH] D13759: [Clang] Fix Clang-tidy modernize-use-auto warnings in headers and generated files; other minor cleanups.

Eugene.Zelenko added inline comments. Comment at: include/clang/AST/ASTVector.h:385 @@ -383,3 +384,3 @@ // Allocate the memory from the ASTContext. - T *NewElts = new (C, llvm::alignOf()) T[NewCapacity]; + auto *NewElts = new (C, llvm::alignOf()) T[NewCapacity];

r252640 - Add the variant of __sparc_v9__ with five underscores, not just four.

Author: joerg Date: Tue Nov 10 13:28:17 2015 New Revision: 252640 URL: http://llvm.org/viewvc/llvm-project?rev=252640=rev Log: Add the variant of __sparc_v9__ with five underscores, not just four. Modified: cfe/trunk/lib/Basic/Targets.cpp

Re: [PATCH] D14471: [AArch64] Fix a crash in driver

ahatanak added a comment. I think I understand some of your concerns, but I'm not sure I fully understand what you are suggesting. I think I can use macro __aarch64__ to have getAArch64TargetCPU return "native" when the compiler is not run on an AArch64 platform, but it doesn't sound like

[PATCH] D14480

http://reviews.llvm.org/D14480 This tries to improve the compilation time of the test case in https://llvm.org/bugs/show_bug.cgi?id=25416 The problem is that when trying to get the SrcLocInfo for asm, it tries to get the SrcLoc for each line inside the asm string. For each line, it goes through

Re: [PATCH] D12686: Add support for GCC's '__auto_type' extension.

rsmith accepted this revision. rsmith added a reviewer: rsmith. rsmith added a comment. This revision is now accepted and ready to land. This LGTM, do you have SVN access or would you like someone to commit for you? Comment at: lib/Sema/SemaType.cpp:2616-2618 @@ -2616,5 +2615,5

Re: [PATCH] D10305: [Clang Static Analyzer] Bug identification

zaks.anna added a comment. > This makes forwards compatibility difficult, since there is no way to predict > the names of future hashes > (As far as I understand). Can you describe what you are trying to achieve? We can agree that all issue hashes start with "issue_hash" prefix. If you find

Re: [PATCH] D13925: Implement __attribute__((internal_linkage))

eugenis closed this revision. eugenis added a comment. r252648. Thanks everyone for the very detailed review! Repository: rL LLVM http://reviews.llvm.org/D13925 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r252648 - Implement __attribute__((internal_linkage)).

Author: eugenis Date: Tue Nov 10 15:28:44 2015 New Revision: 252648 URL: http://llvm.org/viewvc/llvm-project?rev=252648=rev Log: Implement __attribute__((internal_linkage)). The attrubite is applicable to functions and variables and changes the linkage of the subject to internal. This is the

Re: r252474 - Create install targets for scan-build and scan-view

On 11/10/15 12:48 PM, Tobias Grosser wrote: On 11/09/2015 05:12 PM, Jonathan Roelofs via cfe-commits wrote: Author: jroelofs Date: Mon Nov 9 10:12:56 2015 New Revision: 252474 URL: http://llvm.org/viewvc/llvm-project?rev=252474=rev Log: Create install targets for scan-build and scan-view

Re: [PATCH] D14134: [OpenMP] Parsing and sema support for map clause

ABataev added inline comments. Comment at: include/clang/AST/OpenMPClause.h:2628 @@ +2627,3 @@ + friend class OMPClauseWriter; + friend class Sema; + I don't like the idea of friend Sema. If Sema needs some interfaces, they must be public.

Re: r252474 - Create install targets for scan-build and scan-view

On 11/09/2015 05:12 PM, Jonathan Roelofs via cfe-commits wrote: Author: jroelofs Date: Mon Nov 9 10:12:56 2015 New Revision: 252474 URL: http://llvm.org/viewvc/llvm-project?rev=252474=rev Log: Create install targets for scan-build and scan-view Hi Jonathan, this is probably not the commit

[PATCH] D14548: Make test/Driver/biarch.c use FileCheck instead of grep

tyomitch created this revision. tyomitch added reviewers: joerg, rengolin, dougk, yaron.keren. tyomitch added a subscriber: cfe-commits. For clarity and ease of maintenance, I suggest porting this test to use the same tooling as the rest of the tests. http://reviews.llvm.org/D14548 Files:

r252646 - [WebAssembly] Change long double to be quadruple-precision floating point.

Author: djg Date: Tue Nov 10 15:01:46 2015 New Revision: 252646 URL: http://llvm.org/viewvc/llvm-project?rev=252646=rev Log: [WebAssembly] Change long double to be quadruple-precision floating point. Modified: cfe/trunk/lib/Basic/Targets.cpp cfe/trunk/test/CodeGen/wasm-arguments.c

r252641 - Fix missing CMake dependency introduced in r252474

Author: jroelofs Date: Tue Nov 10 14:01:22 2015 New Revision: 252641 URL: http://llvm.org/viewvc/llvm-project?rev=252641=rev Log: Fix missing CMake dependency introduced in r252474 Modified: cfe/trunk/tools/scan-build/CMakeLists.txt cfe/trunk/tools/scan-view/CMakeLists.txt Modified:

Re: r252474 - Create install targets for scan-build and scan-view

On 11/10/2015 09:05 PM, Jonathan Roelofs wrote: On 11/10/15 12:48 PM, Tobias Grosser wrote: On 11/09/2015 05:12 PM, Jonathan Roelofs via cfe-commits wrote: Author: jroelofs Date: Mon Nov 9 10:12:56 2015 New Revision: 252474 URL: http://llvm.org/viewvc/llvm-project?rev=252474=rev Log:

Re: r252474 - Create install targets for scan-build and scan-view

Your custom commands don’t have outputs, so ninja doesn’t know when they need to run or not. -Chris > On Nov 10, 2015, at 2:14 PM, Jonathan Roelofs > wrote: > > > > On 11/10/15 1:35 PM, Tobias Grosser wrote: >> On 11/10/2015 09:05 PM, Jonathan Roelofs wrote: >>>

Re: r252474 - Create install targets for scan-build and scan-view

On 11/10/15 3:18 PM, Chris Bieneman wrote: Your custom commands don’t have outputs, so ninja doesn’t know when they need to run or not. Thanks! -Chris On Nov 10, 2015, at 2:14 PM, Jonathan Roelofs wrote: On 11/10/15 1:35 PM, Tobias Grosser wrote: On

Re: r252474 - Create install targets for scan-build and scan-view

On 11/10/15 1:35 PM, Tobias Grosser wrote: On 11/10/2015 09:05 PM, Jonathan Roelofs wrote: On 11/10/15 12:48 PM, Tobias Grosser wrote: On 11/09/2015 05:12 PM, Jonathan Roelofs via cfe-commits wrote: Author: jroelofs Date: Mon Nov 9 10:12:56 2015 New Revision: 252474 URL:

Re: [PATCH] D13351: [Power PC] add soft float support for ppc32

hfinkel added a comment. Can you please make sure we produce some sensible error should someone try to use soft float with ppc64 (since we don't support that), and add an associated test. Comment at: lib/Driver/Tools.h:739 @@ +738,3 @@ + Soft, + SoftFP, + Hard,

r252659 - [COFF] Don't try to emit weak aliases on COFF

Author: rnk Date: Tue Nov 10 16:23:58 2015 New Revision: 252659 URL: http://llvm.org/viewvc/llvm-project?rev=252659=rev Log: [COFF] Don't try to emit weak aliases on COFF This comes up when a derived class destructor is equivalent to a base class destructor defined in the same TU, and we try to

r252662 - Implement the fix that r252641 should have been

Author: jroelofs Date: Tue Nov 10 16:38:59 2015 New Revision: 252662 URL: http://llvm.org/viewvc/llvm-project?rev=252662=rev Log: Implement the fix that r252641 should have been Modified: cfe/trunk/tools/scan-build/CMakeLists.txt cfe/trunk/tools/scan-view/CMakeLists.txt Modified:

r252664 - Implement post-commit review feedback on r252662

Author: jroelofs Date: Tue Nov 10 16:48:11 2015 New Revision: 252664 URL: http://llvm.org/viewvc/llvm-project?rev=252664=rev Log: Implement post-commit review feedback on r252662 Modified: cfe/trunk/tools/scan-build/CMakeLists.txt cfe/trunk/tools/scan-view/CMakeLists.txt Modified:

r252667 - Fix build

Author: jroelofs Date: Tue Nov 10 16:59:18 2015 New Revision: 252667 URL: http://llvm.org/viewvc/llvm-project?rev=252667=rev Log: Fix build Modified: cfe/trunk/tools/scan-view/CMakeLists.txt Modified: cfe/trunk/tools/scan-view/CMakeLists.txt URL:

Re: [PATCH] D13170: [CUDA] Driver changes to pass flags needed to use detected CUDA installation.

tra updated the summary for this revision. tra updated this revision to Diff 39860. tra added a comment. Moved libdevice detection and linking into a separate patch http://reviews.llvm.org/D14556. http://reviews.llvm.org/D13170 Files: include/clang/Driver/Options.td

[Tests] Making Lit Tests C++11 compatibile

Hello Clang developers, I am back again with another patch to make Clang Lit tests C++11 compatible. There are 26 tests in total. These are mainly diagnostics verifications where C++98/03 and C++11 differ. I tried to preserve as much coverage as possible. Unless otherwise stated, these tests

Re: [PATCH] D13759: [Clang] Fix Clang-tidy modernize-use-auto warnings in headers and generated files; other minor cleanups.

hans added a comment. Some of these are great improvements, especially using auto for iterators etc. But I'm not sure we'll want to start changing "Foo *foo = new Foo;" to use auto everywhere. I expect we'd have to do that in a huge number of places? Comment at:

Re: [PATCH] D14471: [AArch64] Fix a crash in driver

rengolin added a comment. In http://reviews.llvm.org/D14471#285492, @ahatanak wrote: > Which two calls? Do you mean getAArch64TargetCPU and > getAArch64ArchFeaturesFromMcpu? No, the two getAArch64TargetCPU calls, but they don't even get called twice, and the value is write-only. Ignore that.

Re: [PATCH] D14498: [Analyzer] Fix an assertion caused by r250237 (PR25392)

seaneveson abandoned this revision. seaneveson added a comment. Fixed by r252506. Thanks Devin. http://reviews.llvm.org/D14498 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D14540: clang-tidy: Fix FP in MacroParenthesesChecker when using object member pointer

danielmarjamaki created this revision. danielmarjamaki added a reviewer: alexfh. danielmarjamaki added a subscriber: cfe-commits. This fixes the FP in http://llvm.org/bugs/show_bug.cgi?id=25208 http://reviews.llvm.org/D14540 Files: clang-tidy/misc/MacroParenthesesCheck.cpp

r252601 - No longer creating the install-clang target for IDEs, as it was never meant for those.

Author: aaronballman Date: Tue Nov 10 06:51:25 2015 New Revision: 252601 URL: http://llvm.org/viewvc/llvm-project?rev=252601=rev Log: No longer creating the install-clang target for IDEs, as it was never meant for those. Modified: cfe/trunk/tools/driver/CMakeLists.txt Modified:

Re: [PATCH] D14502: [PATCH] Do not create a clang-install target for MSVC solutions

aaron.ballman closed this revision. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. Committed in r252601. http://reviews.llvm.org/D14502 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D14292: [libcxx] Make it possible to build a no-exceptions variant of libcxx.

rmaprath closed this revision. rmaprath added a comment. Thanks Jon! Committed as r252598. The current buildbots are happy (except for the ARM one, which seem to have gone away). I will update http://reviews.llvm.org/D14293 to include the new runs. Cheers, - Asiri

r252690 - Add support for GCC's '__auto_type' extension, per the GCC manual:

Author: rsmith Date: Tue Nov 10 20:02:15 2015 New Revision: 252690 URL: http://llvm.org/viewvc/llvm-project?rev=252690=rev Log: Add support for GCC's '__auto_type' extension, per the GCC manual: https://gcc.gnu.org/onlinedocs/gcc/Typeof.html Differences from the GCC extension: * __auto_type is

Re: [Tests] Making Lit Tests C++11 compatibile

You use this pattern in a few places: +#if (__cplusplus <= 199711L) // C or C++03 or earlier modes Please remove the "C or" from the tests that are not actually run in C mode (most or all of these tests make no sense in C, so the comment is confusing). Also remove the parens. Otherwise, this

Re: [PATCH] D14354: Add new compiler flag to enable the generation of dwarf accelerator tables

tberghammer added a comment. I am not in a hurry with getting this change in, but happy to take a look for enabling the tuning if somebody can explain me what you mean under it (I have almost no llvm/clang development experience) http://reviews.llvm.org/D14354

Re: [PATCH] D13351: [Power PC] add soft float support for ppc32

spetrovic added a comment. ping http://reviews.llvm.org/D13351 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r252599 - [Analyzer] Fix comments and formatting. NFC.

Author: seaneveson Date: Tue Nov 10 05:48:55 2015 New Revision: 252599 URL: http://llvm.org/viewvc/llvm-project?rev=252599=rev Log: [Analyzer] Fix comments and formatting. NFC. Modified: cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/LoopWidening.h

[clang-tools-extra] r252608 - [clang-tidy] misc-macro-parentheses: fix fp when using object member pointers

Author: danielmarjamaki Date: Tue Nov 10 08:32:25 2015 New Revision: 252608 URL: http://llvm.org/viewvc/llvm-project?rev=252608=rev Log: [clang-tidy] misc-macro-parentheses: fix fp when using object member pointers Fixes http://llvm.org/PR25208. Modified:

Re: [PATCH] D10305: [Clang Static Analyzer] Bug identification

seaneveson added a comment. We are working on tools that use the new hash for bug suppression. There seems to be no way to predict the names of future hashes. We have products (that will use the bug identification) that are on a different release schedule to our clang compiler. These tools

Re: [PATCH] D14517: Fix bug 25362 "cppcoreguidelines-pro-bounds-array-to-pointer-decay does not consider const"

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good with a couple of comments. Thank you for the fix! Comment at: clang-tidy/cppcoreguidelines/ProBoundsArrayToPointerDecayCheck.cpp:33 @@ +32,3 @@ +

Re: [PATCH] D10305: [Clang Static Analyzer] Bug identification

xazax.hun added a comment. Thank you for pointing this out. I think it would be great to be forward compatible. Right now one could use a heuristic such as for every hash the key has the "hash" string in its name. This information might not be sufficient, however, since it would be great to

Re: [PATCH] D13759: [Clang] Fix Clang-tidy modernize-use-auto warnings in headers and generated files; other minor cleanups.

aaron.ballman added inline comments. Comment at: include/clang/Analysis/Analyses/Consumed.h:266 @@ -266,2 +265,3 @@ }; -}} // end namespace clang::consumed +} // end namespace consumed +} // end namespace clang I don't know whether this is an improvement or

Re: [PATCH] D14540: clang-tidy: Fix FP in MacroParenthesesChecker when using object member pointer

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good. Thank you for the fix! http://reviews.llvm.org/D14540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D14293: [libcxx] Add -fno-exceptions libcxx builders to zorg

rmaprath updated this revision to Diff 39806. rmaprath added a comment. Updated patch to remove the skipping of tests. Now that we have the appropriate XFAILs in place, these two builders should be green. I've locally tested the x86 run, I expect the ARM run to be fairly similar. @Renato:

Re: [PATCH] D14517: Fix bug 25362 "cppcoreguidelines-pro-bounds-array-to-pointer-decay does not consider const"

aaron.ballman added a comment. I generally think this LGTM, but I would wait for a second confirmation before committing. Comment at: clang-tidy/cppcoreguidelines/ProBoundsArrayToPointerDecayCheck.cpp:33 @@ +32,3 @@ + ast_matchers::internal::Matcher,