hfinkel added a comment. Can you please make sure we produce some sensible error should someone try to use soft float with ppc64 (since we don't support that), and add an associated test.
================ Comment at: lib/Driver/Tools.h:739 @@ +738,3 @@ + Soft, + SoftFP, + Hard, ---------------- We don't seem to support (or even accept) SoftFP. Given that, either remove it from the enum or add support for it. ================ Comment at: lib/Driver/Tools.h:742 @@ +741,3 @@ +}; + ppc::FloatABI getPPCFloatABI(const Driver &D, const llvm::opt::ArgList &Args); +} ---------------- Unindent this and ppc::FloatABI -> FloatABI http://reviews.llvm.org/D13351 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
