aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you!
http://reviews.llvm.org/D12547
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: rsmith
Date: Thu Nov 12 16:19:45 2015
New Revision: 252960
URL: http://llvm.org/viewvc/llvm-project?rev=252960=rev
Log:
[modules] Simplify and generalize the existing rule for finding hidden
declarations in redeclaration lookup. A declaration is now visible to
lookup if:
* It is visible
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
One inline comment then OK for now.
-eric
Comment at: lib/Driver/Tools.cpp:3227-3240
@@ -3226,2 +3226,16 @@
+ if (IsCuda) {
+const ToolChain *AuxToolChain;
+
> -Original Message-
> From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of
> Eric Christopher via cfe-commits
> Sent: Wednesday, November 11, 2015 4:44 PM
> To: cfe-commits@lists.llvm.org
> Subject: r252834 - Provide a frontend based error for always_inline
>
dim added a comment.
Note that http://reviews.llvm.org/rL252920 does not apply to 3.7 cleanly, a few
minor modifications are needed.
Users:
jyknight (Author, Auditor)
3.7-release (Auditor)
cfe-commits (Auditor)
tstellarAMD (Auditor)
compnerd (Auditor)
majnemer (Auditor)
rsmith
Author: rsmith
Date: Thu Nov 12 16:04:34 2015
New Revision: 252959
URL: http://llvm.org/viewvc/llvm-project?rev=252959=rev
Log:
DR407: Rationalize how we handle tags being hidden by typedefs. Even with
DR407, the C++ standard doesn't really say how this should work. Here's what we
do (which is
pekka.jaaskelainen accepted this revision.
This revision is now accepted and ready to land.
Comment at: include/clang/Serialization/ASTBitCodes.h:911
@@ +910,3 @@
+ TYPE_ADJUSTED = 42,
+ /// \brief An PipeType record.
+ TYPE_PIPE = 43
ahatanak marked an inline comment as done.
ahatanak added a comment.
I'll commit this patch shortly. Thank you for the review.
http://reviews.llvm.org/D12547
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: rsmith
Date: Thu Nov 12 15:42:39 2015
New Revision: 252955
URL: http://llvm.org/viewvc/llvm-project?rev=252955=rev
Log:
Additional tests from r252690 that I forgot to 'svn add'.
From a patch by Nicholas Allegra!
Added:
cfe/trunk/test/Sema/auto-type.c
Author: rsmith
Date: Thu Nov 12 15:55:58 2015
New Revision: 252957
URL: http://llvm.org/viewvc/llvm-project?rev=252957=rev
Log:
Revert r240335.
This failed to solve the problem it was aimed at, and introduced just as many
issues as it resolved. Realistically, we need to deal with the possibility
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
This needs a very long commit message describing exactly what's going on and
why since it's not documented anywhere. Possibly in the code as well at
AddPreprocessingOptions and other
aaron.ballman updated this revision to Diff 40078.
aaron.ballman marked an inline comment as done.
aaron.ballman added a comment.
Addressing review comments.
http://reviews.llvm.org/D14619
Files:
clang-tidy/cert/CERTTidyModule.cpp
clang-tidy/cert/CMakeLists.txt
aaron.ballman marked an inline comment as done.
Comment at: clang-tidy/cert/ThrownExceptionTypeCheck.cpp:37
@@ +36,3 @@
+} // end namespace
+
+namespace tidy {
Your slight preference is my firmest desire! :-P Seriously, I think the code is
more clear after
rizsotto.mailinglist added a comment.
In http://reviews.llvm.org/D9600#287157, @jroelofs wrote:
> Would you mind re-uploading this patch as a diff against upstream trunk with
> full context?
i'm not sure i do understand what do you ask. i wish i could upload these
changes as a single patch,
xazax.hun added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/PointerArithChecker.cpp:28
@@ -24,1 +27,3 @@
namespace {
+enum class AllocKind {
+ SingletonNew,
dcoughlin wrote:
> Is it necessary to distinguish so many cases here? For example, why do
Author: rsmith
Date: Thu Nov 12 16:40:09 2015
New Revision: 252967
URL: http://llvm.org/viewvc/llvm-project?rev=252967=rev
Log:
Avoid duplicated diagnostic when lookup for a nested-name-specifier fails due
to ambiguity.
Modified:
cfe/trunk/lib/Sema/SemaCXXScopeSpec.cpp
Author: akirtzidis
Date: Thu Nov 12 19:46:18 2015
New Revision: 253001
URL: http://llvm.org/viewvc/llvm-project?rev=253001=rev
Log:
[CMake] If 'INTERNAL_INSTALL_PREFIX' is set, use it for determining the install
destination of c-index-test and the libclang headers.
Modified:
On Thu, Nov 12, 2015 at 11:11 AM, David Blaikie wrote:
>
>
> On Thu, Nov 12, 2015 at 6:36 AM, Aaron Ballman via cfe-commits
> wrote:
>>
>> aaron.ballman added inline comments.
>>
>>
>> Comment at: lib/AST/ASTContext.cpp:7930
>> @@
Author: jroelofs
Date: Thu Nov 12 18:32:54 2015
New Revision: 252981
URL: http://llvm.org/viewvc/llvm-project?rev=252981=rev
Log:
[scan-build] Create share directory similar to scan-view's
Added:
cfe/trunk/tools/scan-build/share/
cfe/trunk/tools/scan-build/share/scanview.css
-
I assume you are referring to the install-c-index-test target, this should not
be added to IDEs after r253001.
> On Nov 12, 2015, at 7:29 AM, Aaron Ballman wrote:
>
> Is this target needed by IDEs? It currently adds the target to the
> root level of the solution in
Thanks for pointing it out.
r253001 sets up the destination to a different location only if
‘INTERNAL_INSTALL_PREFIX’ is set.
> On Nov 12, 2015, at 5:50 AM, Ismail Donmez wrote:
>
> Fixed in r252890
>
> On Thu, Nov 12, 2015 at 2:17 PM, Ismail Donmez
Author: rjmccall
Date: Thu Nov 12 17:39:39 2015
New Revision: 252971
URL: http://llvm.org/viewvc/llvm-project?rev=252971=rev
Log:
Remove -Wobjc-weak-compat; there isn't a compelling use case for this.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
Author: jamesm
Date: Thu Nov 12 04:56:51 2015
New Revision: 252872
URL: http://llvm.org/viewvc/llvm-project?rev=252872=rev
Log:
Update clang regression tests for 'norecurse'
FunctionAttrs has just been taught how to infer 'norecurse'. Update clang tests
for LLVM r252871.
Modified:
Hi,
On Thu, Nov 12, 2015 at 2:46 AM, Argyrios Kyrtzidis via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> --- cfe/trunk/tools/c-index-test/CMakeLists.txt (original)
> +++ cfe/trunk/tools/c-index-test/CMakeLists.txt Wed Nov 11 18:46:57 2015
> @@ -28,3 +28,12 @@ if (CLANG_HAVE_LIBXML)
>
nwilson updated this revision to Diff 40105.
nwilson added a comment.
- Remove marking a variable concept invalid when specialized since we'll only
look at the primary template downstream. This removal let's us use the same
recovery path as before when 'concept' is specified on a non-template.
Author: rsmith
Date: Thu Nov 12 23:14:45 2015
New Revision: 253012
URL: http://llvm.org/viewvc/llvm-project?rev=253012=rev
Log:
[modules] When a declaration has non-trivial visibility, check whether it's
actually hidden before we check its linkage. This avoids computing the linkage
"too early"
Author: chapuni
Date: Fri Nov 13 00:48:02 2015
New Revision: 253016
URL: http://llvm.org/viewvc/llvm-project?rev=253016=rev
Log:
scan-build: Fix install.
Modified:
cfe/trunk/tools/scan-build/CMakeLists.txt
Modified: cfe/trunk/tools/scan-build/CMakeLists.txt
URL:
ahatanak added a comment.
> If you can get the CPU name, return it. If not, return "native". If you're on
> AArch64 and you can't get the CPU name, that's a bug that needs fixing. If
> it's always "generic", that's another piece of code that needs fixing. If
> whatever getCPU function you use
Author: majnemer
Date: Thu Nov 12 23:32:43 2015
New Revision: 253013
URL: http://llvm.org/viewvc/llvm-project?rev=253013=rev
Log:
[Sema] __is_constructible should return false for function types
While functions types are complete, they cannot be constructed.
This fixes PR25513.
Modified:
jroelofs added a comment.
If you you're familiar with git, I'm asking you to: squash, rebase, and `git
diff -U999`, then upload the resulting patch.
If you use svn, I'm asking you to: `svn diff -r$(FirstCommit):$(LastCommit)
--diff-cmd=diff -x -U999`, and upload that.
The reason to squash all
Fixed in r252890
On Thu, Nov 12, 2015 at 2:17 PM, Ismail Donmez wrote:
> Hi,
>
> On Thu, Nov 12, 2015 at 2:46 AM, Argyrios Kyrtzidis via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> --- cfe/trunk/tools/c-index-test/CMakeLists.txt (original)
>> +++
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good with one comment.
Thank you!
Comment at:
clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexCheck.cpp:107
@@ +106,3 @@
+diag(Matched->getExprLoc(),
+
danielmarjamaki updated this revision to Diff 40040.
danielmarjamaki added a comment.
Moved NonConstUse from VarDecl to ParmVarDecl to avoid waste of memory
http://reviews.llvm.org/D12359
Files:
include/clang/AST/Decl.h
include/clang/Basic/DiagnosticGroups.td
aaron.ballman added inline comments.
Comment at: test/SemaCXX/attr-disable-tail-calls.cpp:2
@@ +1,3 @@
+// RUN: %clang_cc1 -std=c++11 -fsyntax-only %s
+
+class B {
Is this file missing an expected-no-diagnostics?
http://reviews.llvm.org/D12547
joerg added a comment.
The specific CPU was only chosen to match what the backend supported at the
time. As long as the feature set is identical, it doesn't really matter.
http://reviews.llvm.org/D14570
___
cfe-commits mailing list
alexfh added a comment.
Still LG.
http://reviews.llvm.org/D14517
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig added a comment.
Looks good to me.
http://reviews.llvm.org/D14619
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rsmith
Date: Thu Nov 12 21:52:13 2015
New Revision: 253010
URL: http://llvm.org/viewvc/llvm-project?rev=253010=rev
Log:
[modules] Follow the C++ standard's rule for linkage of enumerators: they have
the linkage of the enumeration. For enumerators of unnamed enumerations, extend
the
Author: chapuni
Date: Thu Nov 12 22:44:51 2015
New Revision: 253011
URL: http://llvm.org/viewvc/llvm-project?rev=253011=rev
Log:
clang/test/Driver/mips-mti-linux.c: Tweak to match DOSish paths.
Modified:
cfe/trunk/test/Driver/mips-mti-linux.c
Modified: cfe/trunk/test/Driver/mips-mti-linux.c
jmolloy closed this revision.
jmolloy added a comment.
Thanks Aaron, committed in r252902.
Repository:
rL LLVM
http://reviews.llvm.org/D14615
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rL252904: Cull non-standard variants of ARM architectures
(NFC) (authored by askrobov).
Changed prior to commit:
http://reviews.llvm.org/D14578?vs=39943=40052#toc
Repository:
rL LLVM
Author: vkalintiris
Date: Thu Nov 12 09:26:54 2015
New Revision: 252901
URL: http://llvm.org/viewvc/llvm-project?rev=252901=rev
Log:
Re-recommit: Add support for the new mips-mti-linux toolchain.
Last time, this caused two Windows buildbots and a single ARM buildbot to fail.
I XFAIL'd the
aaron.ballman added inline comments.
Comment at: lib/CodeGen/CodeGenFunction.cpp:721
@@ +720,3 @@
+ // to be norecurse by the standard (3.6.1.3 "The function main shall not be
+ // used within a program")
+ if (getLangOpts().CPlusPlus)
Missing a period at the
rmaprath created this revision.
rmaprath added reviewers: EricWF, jroelofs, mclow.lists, rengolin.
rmaprath added a subscriber: cfe-commits.
The macro TEST_HAS_NO_EXCEPTIONS seems to be defined very similar to
_LIBCPP_NO_EXCEPTIONS, I'm thinking of getting rid of the former as the latter
is
jmolloy updated this revision to Diff 40050.
jmolloy added a comment.
Hi Aaron,
Thanks, this should all be fixed now.
Cheers,
James
Repository:
rL LLVM
http://reviews.llvm.org/D14615
Files:
lib/CodeGen/CodeGenFunction.cpp
test/CodeGenCXX/main-norecurse.cpp
Author: marshall
Date: Thu Nov 12 09:56:44 2015
New Revision: 252905
URL: http://llvm.org/viewvc/llvm-project?rev=252905=rev
Log:
Implement P0074: Making owner_less more flexible
Modified:
libcxx/trunk/include/memory
Author: aaronballman
Date: Thu Nov 12 09:25:06 2015
New Revision: 252900
URL: http://llvm.org/viewvc/llvm-project?rev=252900=rev
Log:
Silencing an MSVC warning about linkage specifications and C-incompatible UDTs
by moving a function definition out of an extern "C" block.
Modified:
Is this target needed by IDEs? It currently adds the target to the
root level of the solution in MSVC.
~Aaron
On Wed, Nov 11, 2015 at 7:46 PM, Argyrios Kyrtzidis via cfe-commits
wrote:
> Author: akirtzidis
> Date: Wed Nov 11 18:46:57 2015
> New Revision: 252836
>
>
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
After fixing the FileCheck and grammar issues, LGTM!
Repository:
rL LLVM
http://reviews.llvm.org/D14615
___
cfe-commits mailing
tyomitch added a comment.
In http://reviews.llvm.org/D14570#288022, @joerg wrote:
> The specific CPU was only chosen to match what the backend supported at the
> time. As long as the feature set is identical, it doesn't really matter.
The feature set isn't quite identical; default ARMv6 CPU
aaron.ballman added a comment.
Yup. LG, thanks!
Repository:
rL LLVM
http://reviews.llvm.org/D14615
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: askrobov
Date: Thu Nov 12 09:52:02 2015
New Revision: 252904
URL: http://llvm.org/viewvc/llvm-project?rev=252904=rev
Log:
Cull non-standard variants of ARM architectures (NFC)
Summary: Clang-side update, corresponding to D14577
Reviewers: rengolin
Subscribers: aemerson, cfe-commits,
jmolloy added inline comments.
Comment at: test/CodeGenCXX/main-norecurse.cpp:1
@@ +1,2 @@
+// RUN: %clang_cc1 -emit-llvm %s -o -
+
Wow, I managed to forget in my copy-paste from another test to add "| FileCheck
%s" here.
I'll update this before committing.
jmolloy created this revision.
jmolloy added a reviewer: aaron.ballman.
jmolloy added a subscriber: cfe-commits.
jmolloy set the repository for this revision to rL LLVM.
The C++ spec (3.6.1.3) says "The function `main` shall not be used within a
program". This implies that it cannot recurse, so
Author: jamesm
Date: Thu Nov 12 09:36:04 2015
New Revision: 252902
URL: http://llvm.org/viewvc/llvm-project?rev=252902=rev
Log:
[C++] Add the "norecurse" attribute to main() if in C++ mode
The C++ spec (3.6.1.3) says "The function `main` shall not be used within a
program". This implies that it
ahatanak updated this revision to Diff 40060.
ahatanak marked 2 inline comments as done.
ahatanak added a comment.
Added "expected-no-diagnostics" to test case.
http://reviews.llvm.org/D12547
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
lib/CodeGen/CGCall.cpp
aaron.ballman created this revision.
aaron.ballman added reviewers: alexfh, sbenza.
aaron.ballman added a subscriber: cfe-commits.
This patch adds a new clang-tidy checker that flags throw expressions whose
thrown type is not nothrow copy constructible. While the compiler is free to
elide copy
aaron.ballman updated this revision to Diff 40064.
aaron.ballman added a comment.
Added new test cases
http://reviews.llvm.org/D14619
Files:
clang-tidy/cert/CERTTidyModule.cpp
clang-tidy/cert/CMakeLists.txt
clang-tidy/cert/ThrownExceptionTypeCheck.cpp
bader added inline comments.
Comment at: include/clang/Sema/DeclSpec.h:1426
@@ +1425,3 @@
+struct PipeTypeInfo : TypeInfoCommon {
+/// The access writes.
+unsigned AccessWrites : 3;
pekka.jaaskelainen wrote:
> I think this needs a better comment than
Author: ahatanak
Date: Thu Nov 12 11:21:22 2015
New Revision: 252912
URL: http://llvm.org/viewvc/llvm-project?rev=252912=rev
Log:
Add support for driver option -mno-ms-bitfields.
This option is used to cancel -mms-bitfields on the command line.
rdar://problem/15898553
Added:
bcraig added a subscriber: bcraig.
bcraig added a comment.
I would love to see a test case with dynamic allocation. Something along the
following...
struct Allocates {
int *x;
Allocates() : x(new int(0)) {}
Allocates(const Allocates ) : x(new int(*other.x)) {}
};
... and then the flip
jordan_rose accepted this revision.
jordan_rose added a comment.
This revision is now accepted and ready to land.
Let's just go with your simple version that makes the common case better. There
are a lot of problems with `throw`, so I wouldn't worry about that right now.
(By the way, we don't
On Thu, Nov 12, 2015 at 2:56 AM, James Molloy via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: jamesm
> Date: Thu Nov 12 04:56:51 2015
> New Revision: 252872
>
> URL: http://llvm.org/viewvc/llvm-project?rev=252872=rev
> Log:
> Update clang regression tests for 'norecurse'
>
>
On Thu, Nov 12, 2015 at 6:36 AM, Aaron Ballman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> aaron.ballman added inline comments.
>
>
> Comment at: lib/AST/ASTContext.cpp:7930
> @@ -7931,3 +7929,3 @@
>
> -ASTMutationListener::~ASTMutationListener() { }
>
compnerd added a subscriber: compnerd.
compnerd accepted this revision.
compnerd added a reviewer: compnerd.
compnerd added a comment.
This revision is now accepted and ready to land.
Wow, this is tricky: the code change is in LLVM, and test change in clang :(.
However, this does seem to
seaneveson added a comment.
> If you have multiple users using a bug suppression system, I would design
> such system using only a single hash version across all users; using a mix
> seems error prone.. Once all of your users upgrade to a version of the
> analyzer where a new hash version is
jyknight added a comment.
The concerns should be fixed by the followup commit
http://reviews.llvm.org/rL252920. If merging to 3.7 branch, both revisions will
need to be included.
Users:
jyknight (Author, Auditor)
3.7-release (Auditor)
cfe-commits (Auditor)
tstellarAMD (Auditor)
Author: jyknight
Date: Thu Nov 12 12:37:29 2015
New Revision: 252920
URL: http://llvm.org/viewvc/llvm-project?rev=252920=rev
Log:
Correct atomic libcall support for __atomic_*_fetch builtins.
In r244063, I had caused these builtins to call the same-named library
functions, __atomic_*_fetch_SIZE.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL252920: Correct atomic libcall support for __atomic_*_fetch
builtins. (authored by jyknight).
Changed prior to commit:
http://reviews.llvm.org/D14385?vs=39644=40068#toc
Repository:
rL LLVM
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
I went ahead and ran some of your test cases through MSVC, and I agree with
your results. This is pretty interesting behavior. Thanks for looking into it!
Looks good.
Comment at:
Author: jroelofs
Date: Thu Nov 12 19:23:40 2015
New Revision: 252991
URL: http://llvm.org/viewvc/llvm-project?rev=252991=rev
Log:
Fix build
Modified:
cfe/trunk/tools/scan-view/CMakeLists.txt
Modified: cfe/trunk/tools/scan-view/CMakeLists.txt
URL:
71 matches
Mail list logo