rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D15518
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF added a comment.
In http://reviews.llvm.org/D14839#307171, @K-ballo wrote:
> In http://reviews.llvm.org/D14839#306306, @EricWF wrote:
>
> > int x = 42;
> > int const y = 43;
> > std::pair const p(x, y);
> > static_assert(std::is_same > decltype(std::get<0>(std::move(p)))>::value, "
EricWF added a comment.
LGTM after the requested changes. Thanks.
Comment at:
test/std/utilities/tuple/tuple.tuple/tuple.elem/get_const_rv.fail.cpp:30
@@ +29,3 @@
+{
+cref(std::get<0>(tup4())); // expected-error {{call to deleted
function 'cref'}}
+}
-
ABataev added inline comments.
Comment at: lib/Parse/ParseOpenMP.cpp:209
@@ -142,2 +208,3 @@
case OMPD_taskloop_simd:
+ default:
Diag(Tok, diag::err_omp_unexpected_directive)
fraggamuffin wrote:
> ABataev wrote:
> > Do not add default:, coding standard re
EricWF added a comment.
Pair and array look good. Still have to look at tuple.
Could you add test that check the overloads are actually `noexcept` as well?
Comment at: include/utility:139
@@ -132,2 +138,3 @@
+
// C++14
Can you add the by-type overloads to th
majnemer created this revision.
majnemer added reviewers: rnk, andrew.w.kaylor, JosephTremoulet, sanjoy.
majnemer added a subscriber: cfe-commits.
majnemer added a dependency: D15517: [WinEH] Use operand bundles to describe
call sites.
This updates clang to use bundle operands to associate an inv
So, this change makes it impossible to download the build lots from the
Windows self-hosting builders because of -Wunused-parameter errors.
http://lab.llvm.org:8011/builders/clang-x86-win2008-selfhost/builds/5103/steps/build%20stage%202/logs/stdio
Maybe that's an indication that users don't really
EricWF updated this revision to Diff 42813.
EricWF added a comment.
Woops. I forgot to turn off `noexcept` support in C++03 mode for GCC.
http://reviews.llvm.org/D15516
Files:
include/__config
Index: include/__config
===
--- inc
EricWF created this revision.
EricWF added reviewers: mclow.lists, danalbert, jroelofs.
EricWF added a subscriber: cfe-commits.
This patch allows GCC 4.6 and above to use `noexcept` as opposed to `throw()`.
Is it an ABI safe change to suddenly switch on `noexcept`? I imagine it must be
because
EricWF abandoned this revision.
EricWF added a comment.
Another fix was committed as r255599. It simply puts the inline keyword on the
declaration of the methods so that they are allowed to be inlined.
14.7.2 [temp.explicit]p10
> Except for inline functions, declarations with types deduced from
adek05 added inline comments.
Comment at: lib/Sema/SemaPseudoObject.cpp:739-751
@@ -738,15 +738,15 @@
// C++ class type.
if (!S.getLangOpts().CPlusPlus || !op->getType()->isRecordType()) {
QualType paramType = (*Setter->param_begin())->getType()
Author: ericwf
Date: Mon Dec 14 19:41:41 2015
New Revision: 255599
URL: http://llvm.org/viewvc/llvm-project?rev=255599&view=rev
Log:
Mark declarations of externally instantiated functions as inline so GCC doesn't
complain.
Modified:
libcxx/trunk/include/valarray
Modified: libcxx/trunk/inclu
adek05 added a comment.
@aaron.ballman I think this could be hard to achieve without an extra note if
you have something like:
cat test2.c
int main() {
char *c = 'a';
char volatile** cc = &c;
cc = &c;
}
test2.c:2:15: warning: incompatible integer to po
bob.wilson added a comment.
Regarding the FIXME in lib/Frontend/CompilerInvocation.cpp: I agree with Hal
that you can remove that. We used to complain about unsupported -fno-builtin-*
options (and until now they have *all* been unsupported), but in r191434,
Rafael changed clang to silently igno
eugenis added a comment.
added some docs
Comment at: lib/CodeGen/CodeGenModule.cpp:1041
@@ -988,3 +1040,3 @@
void CodeGenModule::addUsedGlobal(llvm::GlobalValue *GV) {
assert(!GV->isDeclaration() &&
"Only globals with definition can force usage.");
eugenis updated this revision to Diff 42806.
eugenis marked 2 inline comments as done.
Repository:
rL LLVM
http://reviews.llvm.org/D15367
Files:
docs/ControlFlowIntegrity.rst
docs/ControlFlowIntegrityDesign.rst
include/clang/Driver/Options.td
include/clang/Driver/SanitizerArgs.h
incl
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good with a few nits.
Thank you for the new awesome check!
Comment at: clang-tidy/misc/StringIntegerAssignmentCheck.cpp:74
@@ +73,3 @@
+return;
+ } else if (IsLite
hfinkel added a comment.
In http://reviews.llvm.org/D15195#310395, @mcrosier wrote:
> In http://reviews.llvm.org/D15195#307136, @hfinkel wrote:
>
> > Can you use a StringSet instead of a vector and avoid all (most) of the
> > code iterating over the vector of builtins being disabled?
>
>
> Hi Ha
samsonov added a comment.
Richard, could you take a look at this?
http://reviews.llvm.org/D15363
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: davidxl
Date: Mon Dec 14 18:33:12 2015
New Revision: 255587
URL: http://llvm.org/viewvc/llvm-project?rev=255587&view=rev
Log:
[PGO] make profile prefix even shorter and more readable
Modified:
cfe/trunk/test/CoverageMapping/ir.c
cfe/trunk/test/CoverageMapping/unused_names.c
cf
Author: ericwf
Date: Mon Dec 14 18:32:21 2015
New Revision: 255585
URL: http://llvm.org/viewvc/llvm-project?rev=255585&view=rev
Log:
Fix various GCC mis-configurations for newer versions.
This patch goes through and enables C++11 and C++14 features for newer GCC's.
The main changes are:
1. Turn
eraman updated this revision to Diff 42801.
eraman added a comment.
Fix the comment in the test case
Repository:
rL LLVM
http://reviews.llvm.org/D15163
Files:
lib/CodeGen/CodeGenModule.cpp
test/Profile/Inputs/max-function-count.proftext
test/Profile/max-function-count.c
Index: test/Pr
eraman updated this revision to Diff 42797.
eraman added a comment.
Updated the patch addressing Justin's comments and a new test case.
(Should I open a new review thread since phabricator thinks this has been
submitted?)
Repository:
rL LLVM
http://reviews.llvm.org/D15163
Files:
lib/Code
djasper added a comment.
I'd just prefer the setting of the new option and ignore the old one then, but
I don't think it matters to much. Warning or err'ing out also seems like a
reasonable approach.
http://reviews.llvm.org/D10370
___
cfe-commits
On Mon, Dec 14, 2015 at 3:47 PM, David Blaikie via cfe-commits
wrote:
> On Tue, Dec 15, 2015 at 5:46 AM, Hans Wennborg via cfe-commits
> wrote:
>>
>> Author: hans
>> Date: Mon Dec 14 12:46:11 2015
>> New Revision: 255524
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=255524&view=rev
>> Log:
>
On Tue, Dec 15, 2015 at 5:46 AM, Hans Wennborg via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: hans
> Date: Mon Dec 14 12:46:11 2015
> New Revision: 255524
>
> URL: http://llvm.org/viewvc/llvm-project?rev=255524&view=rev
> Log:
> clang-cl: make /Wall turn on both -Wall and -Wextra (
LGTM, please commit (if you like, if you want to wait for other feedback
that's OK too)
On Tue, Dec 15, 2015 at 2:15 AM, Nico Weber wrote:
> On Sun, Dec 13, 2015 at 6:57 PM, David Blaikie wrote:
>
>> (attachment missing)
>>
>
> (whoops. looks as expected though, here it is.)
>
> Cursory review
On Mon, Dec 14, 2015 at 3:26 PM, Xinliang David Li
wrote:
> On Fri, Dec 11, 2015 at 6:19 PM, Justin Bogner
> wrote:
> > Easwaran Raman writes:
> >> eraman updated this revision to Diff 42549.
> >> eraman added a comment.
> >>
> >> Added a test case.
> >>
> >>
> >> Repository:
> >> rL LLVM
> >
On Fri, Dec 11, 2015 at 6:12 PM, Justin Bogner
wrote:
> Easwaran Raman writes:
> > eraman added a comment.
> >
> > I have reverted the commit in r255416 because the test failed in many
> > architectures.
>
> You also committed without waiting for further review, despite that
> David said "LGTM b
Author: davidxl
Date: Mon Dec 14 17:26:46 2015
New Revision: 255576
URL: http://llvm.org/viewvc/llvm-project?rev=255576&view=rev
Log:
[PGO] Shorten profile symbol prefixes
(test case update)
Profile symbols have long prefixes which waste space and creating pressure for
linker.
This patch shorten
On Fri, Dec 11, 2015 at 6:19 PM, Justin Bogner wrote:
> Easwaran Raman writes:
>> eraman updated this revision to Diff 42549.
>> eraman added a comment.
>>
>> Added a test case.
>>
>>
>> Repository:
>> rL LLVM
>>
>> http://reviews.llvm.org/D15163
>>
>> Files:
>> lib/CodeGen/CodeGenModule.cpp
Author: rafael
Date: Mon Dec 14 17:17:07 2015
New Revision: 255572
URL: http://llvm.org/viewvc/llvm-project?rev=255572&view=rev
Log:
Update for llvm api change.
Modified:
cfe/trunk/lib/CodeGen/CodeGenAction.cpp
Modified: cfe/trunk/lib/CodeGen/CodeGenAction.cpp
URL:
http://llvm.org/viewvc/ll
silvas added a comment.
In http://reviews.llvm.org/D15462#309889, @beanz wrote:
> Sean,
>
> The reason for restricting to Unix is two fold. (1) the shell script goop,
> which I can replace with python and (2) I don't have a windows box to test
> on, so I didn't want people to think it worked.
>
pcc added a comment.
Please add documentation. At the very least please document flags in
`docs/ControlFlowIntegrity.rst` and `docs/UsersManual.rst`. We should also
document the design in `docs/ControlFlowIntegrityDesign.rst`.
Comment at: lib/CodeGen/CGExpr.cpp:3868
@@ +3867,3
On Fri, Dec 11, 2015 at 6:19 PM, Justin Bogner wrote:
> Easwaran Raman writes:
>> eraman updated this revision to Diff 42549.
>> eraman added a comment.
>>
>> Added a test case.
>>
>>
>> Repository:
>> rL LLVM
>>
>> http://reviews.llvm.org/D15163
>>
>> Files:
>> lib/CodeGen/CodeGenModule.cpp
nikola created this revision.
nikola added a reviewer: rsmith.
nikola added a subscriber: cfe-commits.
Current diagnostic says "expected expression" or "reference to non-static
member function must be called". This should fix PR13566 and PR18995
http://reviews.llvm.org/D15509
Files:
lib/Parse
mcrosier added a comment.
In http://reviews.llvm.org/D15195#307136, @hfinkel wrote:
> Can you use a StringSet instead of a vector and avoid all (most) of the code
> iterating over the vector of builtins being disabled?
Hi Hal,
I began converting the code to use StringSets, but I soon realized
eugenis added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:3871
@@ +3870,3 @@
+isa(MD) && dyn_cast(MD)->isDistinct();
+if (CGM.getCodeGenOpts().SanitizeCfiCrossDso && !hasLocalScope) {
+ EmitCfiSlowPathCheck(BitSetTest, MD, CastedCallee);
p
eugenis updated this revision to Diff 42782.
eugenis marked 3 inline comments as done.
Repository:
rL LLVM
http://reviews.llvm.org/D15367
Files:
include/clang/Driver/Options.td
include/clang/Driver/SanitizerArgs.h
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/CGClass.cpp
lib/
ayartsev added a comment.
Upd: Forgot to remove the printHash() subroutine from libscanbuild.pm. Using it
locally for debug purpose.
http://reviews.llvm.org/D14629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
ayartsev updated this revision to Diff 42762.
ayartsev added a comment.
Updated the patch following Laszlo's advises:
+ Changed config file format to YAML.
+ Dump current configuration.
+ Search for config file from the current folder and upper.
In http://reviews.llvm.org/D14629#294023, @jroelofs
Author: ericwf
Date: Mon Dec 14 16:26:28 2015
New Revision: 255561
URL: http://llvm.org/viewvc/llvm-project?rev=255561&view=rev
Log:
Update paths in libc++ build instructions. Patch from Jonathan Anderson.
Modified:
libcxx/trunk/docs/BuildingLibcxx.rst
Modified: libcxx/trunk/docs/BuildingLib
EricWF closed this revision.
EricWF added a comment.
r255560.
http://reviews.llvm.org/D15441
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Mon Dec 14 16:24:19 2015
New Revision: 255560
URL: http://llvm.org/viewvc/llvm-project?rev=255560&view=rev
Log:
Update how libc++/libc++abi link the tests. Follow up on r29.
Modified:
libcxx/trunk/test/libcxx/test/config.py
Modified: libcxx/trunk/test/libcxx/test/con
This revision was automatically updated to reflect the committed changes.
Closed by commit rL29: [libc++abi] Use libgcc and libgcc_s to provide
_Unwind symbols instead of… (authored by EricWF).
Changed prior to commit:
http://reviews.llvm.org/D15440?vs=42772&id=42777#toc
Repository:
rL L
Author: ericwf
Date: Mon Dec 14 16:20:04 2015
New Revision: 29
URL: http://llvm.org/viewvc/llvm-project?rev=29&view=rev
Log:
[libc++abi] Use libgcc and libgcc_s to provide _Unwind symbols instead of
libgcc_eh.a
Summary:
libgcc_eh.a cannot be used when building libc++abi as a shared libra
davidxl added inline comments.
Comment at: cfe/trunk/test/CodeGen/pgo-max-function-count.c:1
@@ +1,2 @@
+// RUN: %clang -fprofile-generate -o %t -O2 %s
+// RUN: env LLVM_PROFILE_FILE=%t.profraw %t
Use -fprofile-instr-generate option. -fprofile-generate is for GCC
rizsotto.mailinglist added inline comments.
Comment at: tools/scan-build-py/libear/ear.c:142
@@ +141,3 @@
+#endif
+if (!initialized)
+initialized = bear_capture_env_t(&initial_env);
dcoughlin wrote:
> rizsotto.mailinglist wrote:
> > rizsotto.mailinglis
zturner updated this revision to Diff 42774.
zturner added a comment.
This patch was very old, so it didn't apply against ToT. So this initial
update is just to rebase against ToT. I will make changes in a followup patch.
http://reviews.llvm.org/D10370
Files:
include/clang/Format/Format.h
EricWF updated the summary for this revision.
EricWF updated this revision to Diff 42772.
EricWF added a comment.
This patch is updated in the following ways:
1. No longer try and remove `-Wl,-z,defs` from the link flags. I think I was
mistaken that this caused an issue.
2. No longer try and lin
Author: gbiv
Date: Mon Dec 14 16:00:49 2015
New Revision: 26
URL: http://llvm.org/viewvc/llvm-project?rev=26&view=rev
Log:
[Sema] Make nullness warnings appear in C++.
Given the following code:
int *_Nullable ptr;
int *_Nonnull nn = ptr;
...In C, clang will warn you about `nn =
This revision was automatically updated to reflect the committed changes.
Closed by commit rL26: [Sema] Make nullness warnings appear in C++.
(authored by gbiv).
Changed prior to commit:
http://reviews.llvm.org/D14938?vs=40987&id=42770#toc
Repository:
rL LLVM
http://reviews.llvm.org/D14
> Are there already tests in place for the C version? I assume so, but
> please double check.
Looks to me like the warning in the example is tested in C. Added 2
other cases (assignment + passing a _Nullable variable as a
_Nonnull argument) for good measure.
> LGTM with a couple of nits, below.
yaron.keren added inline comments.
Comment at: lib/ASTMatchers/ASTMatchersInternal.cpp:322
@@ +321,3 @@
+ for (bool SkipUnwritten : SkipUnwrittenCases) {
+llvm::SmallString<128> NodeName = StringRef("::");
+llvm::raw_svector_ostream OS(NodeName);
StringRe
aaron.ballman added inline comments.
Comment at: lib/ASTMatchers/ASTMatchersInternal.cpp:320-331
@@ -323,4 +319,14 @@
- if (Pattern.startswith("::"))
-return FullName == Pattern;
+ const bool SkipUnwrittenCases[] = {false, true};
+ for (bool SkipUnwritten : SkipUnwrittenC
Author: bcraig
Date: Mon Dec 14 15:54:11 2015
New Revision: 22
URL: http://llvm.org/viewvc/llvm-project?rev=22&view=rev
Log:
Reordering fields to reduce padding in Clang. NFC
Modified:
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
cfe/trunk/lib/Sema/SemaType.cpp
Modified: cfe/trunk/lib/Co
sbenza added a comment.
I am thinking on doing this some other way.
Copying the PrintingPolicy object is very expensive, as it contains quite a few
strings and vectors of strings.
In the past I changed this matcher to make no allocations in the common path
(ie using SmallString<>, etc) to reduce
That's odd. I'm using the same update 5 exactly, added " for (bool
SkipUnwritten : {false, true});" inside a LLVM source file and re-compiled.
MSVC complained about the unused SkipUnwritten but was therwise OK with the
code.
2015-12-14 23:43 GMT+02:00 Aaron Ballman :
> On Mon, Dec 14, 2015 at 4
sbenza updated this revision to Diff 42767.
sbenza added a comment.
Minor fixes
http://reviews.llvm.org/D15506
Files:
lib/ASTMatchers/ASTMatchersInternal.cpp
unittests/ASTMatchers/ASTMatchersTest.cpp
Index: unittests/ASTMatchers/ASTMatchersTest.cpp
=
aaron.ballman added a comment.
I would be interested in seeing test cases where this is an improvement. For
instance, would it be equally as useful to pass in the type range to the
existing diagnostic so that the type gets highlighted as well (and skip the
note entirely)?
http://reviews.llvm.
bcraig closed this revision.
bcraig added a comment.
Submitted to r255545
http://reviews.llvm.org/D14779
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Mon, Dec 14, 2015 at 4:39 PM, Yaron Keren wrote:
> MSVC 2013 Update 5 accepts for (bool SkipUnwritten : {false, true}).
> Possibly changed in one of the Updates?
I tested using MSVC 2013 Update 5.
Microsoft Visual Studio Ultimate 2013
Version 12.0.40629.00 Update 5
Microsoft .NET Framework
Ve
Author: bcraig
Date: Mon Dec 14 15:38:59 2015
New Revision: 255545
URL: http://llvm.org/viewvc/llvm-project?rev=255545&view=rev
Log:
[PATCH] Adding checker to detect excess padding in records
The intent of this checker is to generate a report for any class / structure
that could reduce its paddin
MSVC 2013 Update 5 accepts for (bool SkipUnwritten : {false, true}).
Possibly changed in one of the Updates?
2015-12-14 23:35 GMT+02:00 Aaron Ballman via cfe-commits <
cfe-commits@lists.llvm.org>:
> aaron.ballman added a subscriber: aaron.ballman.
>
>
> Comment at: lib/ASTMatcher
aaron.ballman added a subscriber: aaron.ballman.
Comment at: lib/ASTMatchers/ASTMatchersInternal.cpp:320
@@ -323,3 +319,3 @@
- if (Pattern.startswith("::"))
-return FullName == Pattern;
+ for (bool SkipUnwritten : {false, true}) {
+llvm::SmallString<128> NodeName = Str
zturner added a comment.
In http://reviews.llvm.org/D10370#309789, @djasper wrote:
> I think we can add the option AlwaysBreakAfterReturnType but still be
> backwards compatible. If clang-format finds only the old option in a
> configuration file, it can choose the appropriate value of the new
ping
On Mon, Nov 30, 2015 at 4:30 PM, Akira Hatanaka wrote:
> ahatanak created this revision.
> ahatanak added a subscriber: cfe-commits.
>
> Issue a warning if an initializing integer expression overflows.
>
> For example, clang should issue a warning when compiling the following
> code because
beanz updated this revision to Diff 42761.
beanz added a comment.
Updates based on feedback from Sean and Vedant.
- Should work on Windows now
- Cleaned up lit config code
http://reviews.llvm.org/D15462
Files:
CMakeLists.txt
utils/perf-training/CMakeLists.txt
utils/perf-training/README.t
On Mon, Dec 14, 2015 at 10:39 AM, Justin Bogner
wrote:
> Akira Hatanaka via cfe-commits writes:
> > ahatanak created this revision.
> > ahatanak added a subscriber: cfe-commits.
> >
> > This patch fixes a crash that occurs when __kindof is incorrectly used
> > in the type parameter list of an in
George Burgess IV via cfe-commits writes:
> george.burgess.iv created this revision.
> george.burgess.iv added a reviewer: doug.gregor.
> george.burgess.iv added subscribers: cfe-commits, doug.gregor.
>
> Currently, code like this compiles cleanly in C++, but with warnings
> (as it should) in C:
On 12/11/2015 04:40 PM, Daniel Jasper wrote:
Please submit patches to clang-format to reviews.llvm.org. Also, any change
no matter how easy it is to deduce from the code itself deserves a proper
change description :-). Bullet points are fine.
Thanks for the quick reply. I've submitted the patc
LegalizeAdulthood added inline comments.
Comment at: test/clang-tidy/misc-string-integer-assignment.cpp:33
@@ +32,3 @@
+ s = 'c';
+ s = (char)6;
+
What happens if the test code had used `static_cast`?
http://reviews.llvm.org/D15411
_
LegalizeAdulthood added inline comments.
Comment at: test/clang-tidy/misc-string-integer-assignment.cpp:46
@@ +45,3 @@
+ ws += L'c';
+ ws += (wchar_t)6;
+
Use `static_cast<>` instead of C-style cast?
http://reviews.llvm.org/D15411
__
zaks.anna added a comment.
I wonder if we can refactor the code so that it is less error prone..
shouldSkipFunction(D, Visited, VisitedAsTopLevel) works with two sets. I assume
that you have not updated Decls coming from VisitedAsTopLevel because they come
from the CFG and should already be can
sbenza created this revision.
sbenza added a reviewer: klimek.
sbenza added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Allow hasName() to look through inline namespaces.
This will fix the interaction between some clang-tidy checks and libc++.
libc++ defines names in an inline n
bcraig marked 2 inline comments as done.
bcraig added a comment.
http://reviews.llvm.org/D14779
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig updated this revision to Diff 42742.
bcraig marked an inline comment as done.
http://reviews.llvm.org/D14779
Files:
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/PaddingChecker.cpp
test/Analysis/padding_c.c
test/Ana
Author: petarj
Date: Mon Dec 14 14:30:02 2015
New Revision: 255539
URL: http://llvm.org/viewvc/llvm-project?rev=255539&view=rev
Log:
[PowerPC] Fix test/CodeGen/ppc-sfvarargs
The issue seems to be that .ll file may either use number of register
value or alias %numUsedRegs, so the check needs to co
zaks.anna added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/Checkers.td:49
@@ -48,1 +48,3 @@
+def Performance : Package<"performance">;
+
zaks.anna wrote:
> I think Performance should be in the OptIn package.
What do you think about this one?
http
bkramer updated this revision to Diff 42749.
bkramer added a comment.
Add test case.
http://reviews.llvm.org/D15490
Files:
include/clang-c/Index.h
include/clang/Frontend/ASTUnit.h
lib/Frontend/ASTUnit.cpp
test/Index/complete-preamble.cpp
tools/c-index-test/c-index-test.c
tools/libcl
Fwiw, I am certainly in Tim'a camp here! Writing a test for that output is
doable, and if that's what people want then that's what we'll do. But it's
certainly not nice or readable !
On Mon, 14 Dec 2015 at 19:25, Tim Northover via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On 14 December 2
Author: petarj
Date: Mon Dec 14 13:22:35 2015
New Revision: 255533
URL: http://llvm.org/viewvc/llvm-project?rev=255533&view=rev
Log:
[PowerPC] Fix make-check issues
Previous change r255515 introduced a couple of issues likely caused by
a different configure setup.
Modified:
cfe/trunk/test/Co
On 14 December 2015 at 11:12, Eric Christopher wrote:
> There really is a pretty good separation of concerns and for a lot if not
> most of the tests here all the difference is checking is the arguments,
> keeping track of an alloca and making sure that goes is pretty simple and
> not really hard
bcraig marked 3 inline comments as done.
bcraig added a comment.
In http://reviews.llvm.org/D14779#309170, @zaks.anna wrote:
> With respect to the issues this checker found, I suggest submitting patches
> for the clang issues that can be fixed. Can the x-macro case be suppressed
> with the reco
george.burgess.iv added a comment.
Ping :)
http://reviews.llvm.org/D14938
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rjmccall
Date: Mon Dec 14 13:12:54 2015
New Revision: 255531
URL: http://llvm.org/viewvc/llvm-project?rev=255531&view=rev
Log:
Allow pseudo-destructor calls on forward-declared Objective-C class pointers.
rdar://18522255
Added:
cfe/trunk/test/SemaObjCXX/pseudo-destructor.mm
Modified:
On Mon, Dec 14, 2015 at 11:05 AM Tim Northover
wrote:
> > I don't think it's going to be even vaguely that bad here and that you're
> > blowing it a bit out of proportion. [...] It does make the tests a
> little harder
> > to write, but having done a bunch of them it's not that bad.
>
> I've also
> I don't think it's going to be even vaguely that bad here and that you're
> blowing it a bit out of proportion. [...] It does make the tests a little
> harder
> to write, but having done a bunch of them it's not that bad.
I've also tried to write such tests in the past, and I did find it that b
jroelofs added a comment.
Can you write up a couple of testcases for the new diagnostic? There should be
some examples you can follow in clang/test/Sema ans clang/test/SemaCXX.
I'd also be interested in seeing a concrete example of the setter thing you
were talking about in ObjC/ObjC++.
http:
On Mon, Dec 14, 2015 at 10:44 AM Tim Northover
wrote:
> On 14 December 2015 at 09:20, Eric Christopher via cfe-commits
> wrote:
> > I understand the conflicting priorities here for sure. You'd like a test
> that's as minimal as possible, without having to depend on external (to
> clang) librarie
doug.gregor added a comment.
For reference, you can test this by setting the environment variable
LIBCLANG_TIMING in your test, and checking that the string "Precompiling
preamble" shows up on first parse.
http://reviews.llvm.org/D15490
___
cfe-co
Author: hans
Date: Mon Dec 14 12:46:11 2015
New Revision: 255524
URL: http://llvm.org/viewvc/llvm-project?rev=255524&view=rev
Log:
clang-cl: make /Wall turn on both -Wall and -Wextra (PR25563)
The documentation suggests /Wall should really turn on -Wextra and any
other warnings that are not enabl
On 14 December 2015 at 09:20, Eric Christopher via cfe-commits
wrote:
> I understand the conflicting priorities here for sure. You'd like a test
> that's as minimal as possible, without having to depend on external (to
> clang) libraries here. I really would appreciate it if you'd make the test
Akira Hatanaka via cfe-commits writes:
> ahatanak created this revision.
> ahatanak added a subscriber: cfe-commits.
>
> This patch fixes a crash that occurs when __kindof is incorrectly used
> in the type parameter list of an interface. The crash occurs because
> ObjCTypeParamList::back() is call
This revision was automatically updated to reflect the committed changes.
Closed by commit rL255521: [MS ABI] Don't rely on terminatepad (authored by
majnemer).
Changed prior to commit:
http://reviews.llvm.org/D15478?vs=42641&id=42736#toc
Repository:
rL LLVM
http://reviews.llvm.org/D15478
Author: majnemer
Date: Mon Dec 14 12:34:18 2015
New Revision: 255521
URL: http://llvm.org/viewvc/llvm-project?rev=255521&view=rev
Log:
[MS ABI] Don't rely on terminatepad
We'd like to remove support for terminatepad from LLVM. To do this, we
need to move Clang off of it first. The intent behind
Author: marshall
Date: Mon Dec 14 12:11:51 2015
New Revision: 255519
URL: http://llvm.org/viewvc/llvm-project?rev=255519&view=rev
Log:
K-Ballo pointed out a mistake in the add_lvalue_ref tests I checked in; now
more of them are passing. Thanks
Modified:
libcxx/trunk/test/std/utilities/meta/
Author: marshall
Date: Mon Dec 14 12:02:23 2015
New Revision: 255518
URL: http://llvm.org/viewvc/llvm-project?rev=255518&view=rev
Log:
Missed this on the previous (255517) commit
Modified:
libcxx/trunk/include/type_traits
Modified: libcxx/trunk/include/type_traits
URL:
http://llvm.org/viewv
Author: marshall
Date: Mon Dec 14 12:01:56 2015
New Revision: 255517
URL: http://llvm.org/viewvc/llvm-project?rev=255517&view=rev
Log:
Fix a corner case that involved calling rethrow_if_nested with a type that had
a deleted operator&. Added a test to catch this as well. Thanks to Ville for
the h
This revision was automatically updated to reflect the committed changes.
Closed by commit rL255515: [Power PC] add soft float support for ppc32
(authored by petarj).
Changed prior to commit:
http://reviews.llvm.org/D13351?vs=41736&id=42733#toc
Repository:
rL LLVM
http://reviews.llvm.org/D1
1 - 100 of 141 matches
Mail list logo
