klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D13001
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
Author: djasper
Date: Mon Dec 14 02:24:16 2015
New Revision: 255484
URL: http://llvm.org/viewvc/llvm-project?rev=255484&view=rev
Log:
clang-format: Fix style default for WebKit and Linux styles.
Brought up in codereviews:
http://reviews.llvm.org/D15445
http://reviews.llvm.org/D15485
Modified:
djasper closed this revision.
djasper added a comment.
Submitted as r255484.
http://reviews.llvm.org/D15445
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: djasper
Date: Mon Dec 14 02:33:07 2015
New Revision: 255485
URL: http://llvm.org/viewvc/llvm-project?rev=255485&view=rev
Log:
clang-format: Extend Linux-brace-wrapping test.
Modified:
cfe/trunk/unittests/Format/FormatTest.cpp
Modified: cfe/trunk/unittests/Format/FormatTest.cpp
URL:
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Submitted as r255484 and r255485.
http://reviews.llvm.org/D15485
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
Author: djasper
Date: Mon Dec 14 02:41:18 2015
New Revision: 255486
URL: http://llvm.org/viewvc/llvm-project?rev=255486&view=rev
Log:
clang-format: Add test for AlignAfterOpenBracket = AlwaysBreak in C++.
Revision 251405 added AlwaysBreak to support Google's JavaScript style. This
changeset compl
djasper closed this revision.
djasper added a comment.
Submitted in r255486. Thank you.
http://reviews.llvm.org/D15062
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
a.sidorin updated this revision to Diff 42691.
a.sidorin added a comment.
Replaced CHECK with CHECK-NEXT
Repository:
rL LLVM
http://reviews.llvm.org/D15410
Files:
lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp
lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp
test/Analysis/inlining
Author: abataev
Date: Mon Dec 14 03:26:19 2015
New Revision: 255487
URL: http://llvm.org/viewvc/llvm-project?rev=255487&view=rev
Log:
[OPENMP] Fix debug info for 'atomic' construct.
Debug info for statement under 'atomic' construct must point exactly to that
statement, not the directive itself.
rmaprath updated this revision to Diff 42694.
rmaprath added a comment.
Simplified the changes to `__config` header.
http://reviews.llvm.org/D14653
Files:
include/__config
include/array
test/std/containers/sequences/array/at.pass.cpp
test/support/noexcept.h
Index: test/support/noexcept
Hahnfeld added a comment.
Is anyone feeling responsible for a final go / review? It would be great for
our research project to have at least basic offloading support in 3.8...
http://reviews.llvm.org/D12614
___
cfe-commits mailing list
cfe-commits@
xazax.hun marked 7 inline comments as done.
Comment at: clang-tidy/misc/StringIntegerAssignmentCheck.cpp:19
@@ +18,3 @@
+namespace {
+AST_MATCHER(QualType, isAnyCharacter) { return Node->isAnyCharacterType(); }
+} // namespace
aaron.ballman wrote:
> I think this w
xazax.hun updated this revision to Diff 42698.
xazax.hun marked an inline comment as done.
xazax.hun added a comment.
- Addressed review comments.
- Removed fixit suggestions.
http://reviews.llvm.org/D15411
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tid
rmaprath updated this revision to Diff 42701.
rmaprath added a comment.
Further refined the changes to `__config` header.
- Now there's only one `_LIBCPP_THROW` macro, which does the right thing
depending on the availability of exceptions.
- Made `__libcxx_noexceptions_report` not take in the ex
bkramer created this revision.
bkramer added reviewers: doug.gregor, klimek.
bkramer added a subscriber: cfe-commits.
The current default is to create the preamble on the first reparse, aka
second parse. This is useful for clients that do not want to block when
opening a file because serializing t
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D15490
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
alexfh added inline comments.
Comment at: clang-tidy/misc/StringIntegerAssignmentCheck.cpp:20
@@ +19,3 @@
+AST_MATCHER(QualType, isAnyCharacter) { return Node->isAnyCharacterType(); }
+} // namespace
+
I prefer `isAnyCharacter` for consistency with `isInteger`. I'
aaron.ballman added a reviewer: klimek.
Comment at: clang-tidy/misc/StringIntegerAssignmentCheck.cpp:20
@@ +19,3 @@
+AST_MATCHER(QualType, isAnyCharacter) { return Node->isAnyCharacterType(); }
+} // namespace
+
alexfh wrote:
> I prefer `isAnyCharacter` for consis
xazax.hun updated this revision to Diff 42710.
xazax.hun marked 4 inline comments as done.
xazax.hun added a comment.
- Reimplemented fixits.
- Addressed the review comments.
http://reviews.llvm.org/D15411
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy
xazax.hun added inline comments.
Comment at: clang-tidy/misc/StringIntegerAssignmentCheck.cpp:20
@@ +19,3 @@
+AST_MATCHER(QualType, isAnyCharacter) { return Node->isAnyCharacterType(); }
+} // namespace
+
aaron.ballman wrote:
> alexfh wrote:
> > I prefer `isAnyCha
MaggieYi added a comment.
Thanks for reviewing the patch. I try to answer your questions, could you
please let me know if this makes sense to you?
Regards,
Comment at: lib/Driver/Tools.cpp:4064
@@ -4046,1 +4063,3 @@
+ // Add runtime flag for PS4 when PGO or Coverage are ena
MaggieYi updated this revision to Diff 42711.
MaggieYi added a comment.
Following Vedant's comments, two test issues have been fixed.
http://reviews.llvm.org/D15222
Files:
lib/Driver/Tools.cpp
test/Driver/ps4-runtime-flags.c
Index: test/Driver/ps4-runtime-flags.c
==
It at least needs a testcase.
Cheers,
Rafael
On 13 December 2015 at 09:53, Luboš Doležel wrote:
> Hello,
>
> I'm the developer of Darling, a translation layer for running OS X
> binaries on Linux.
>
> I'm facing many difficulties due to the following differences in i386
> ABI between Darwin and
Author: cbertol
Date: Mon Dec 14 08:51:25 2015
New Revision: 255498
URL: http://llvm.org/viewvc/llvm-project?rev=255498&view=rev
Log:
Add parse and sema of OpenMP distribute directive with all clauses except
dist_schedule
Added:
cfe/trunk/test/OpenMP/distribute_ast_print.cpp
cfe/trunk/te
carlo.bertolli added a comment.
Resubmitted at rev255498
Repository:
rL LLVM
http://reviews.llvm.org/D15125
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AntonBikineev added a comment.
@rsmith, are there any plans/suggestions regarding this patch?
http://reviews.llvm.org/D5744
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Sun, Dec 13, 2015 at 6:57 PM, David Blaikie wrote:
> (attachment missing)
>
(whoops. looks as expected though, here it is.)
Cursory review based on description: Sounds reasonable to me. Would want to
> check the C++98 behavior to ensure it is actually relevant/correct to imply
> the possibil
berenm updated this revision to Diff 42718.
berenm added a comment.
- Patch rebased on trunk
- Small cleanups in the RunningDocumentTable usage
- Tested and appears work on VS >= 2012
http://reviews.llvm.org/D12407
Files:
tools/clang-format-vs/ClangFormat/ClangFormat.csproj
tools/clang-form
djasper added a comment.
I think we can add the option AlwaysBreakAfterReturnType but still be backwards
compatible. If clang-format finds only the old option in a configuration file,
it can choose the appropriate value of the new option.
I also like using just this one option better than using
berenm added inline comments.
Comment at: tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs:195
@@ -179,1 +194,3 @@
+runningDocumentTable = new RunningDocumentTable(this);
+adviseCookie = runningDocumentTable.Advise(this);
In this b
milianw added a comment.
lgtm, but someone else should approve
http://reviews.llvm.org/D13001
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
13.12.2015, 17:54, "Luboš Doležel via cfe-commits" :
> Hello,
>
> I'm the developer of Darling, a translation layer for running OS X
> binaries on Linux.
>
> I'm facing many difficulties due to the following differences in i386
> ABI between Darwin and Linux:
>
> * size_t on Darwin/i386 is 'unsig
vsk added inline comments.
Comment at: lib/Driver/Tools.cpp:4067
@@ -4049,1 +4066,3 @@
+ // Add runtime flag for PS4 when PGO or Coverage are enabled.
+ if (getToolChain().getTriple().isPS4CPU())
Sorry, I don't know why I thought this was in ParsePIC. This see
beanz added a comment.
Sean,
The reason for restricting to Unix is two fold. (1) the shell script goop,
which I can replace with python and (2) I don't have a windows box to test on,
so I didn't want people to think it worked.
If I replace the shell goop with Python this will probably "Just Wo
labrinea added a comment.
Hi Eric,
The main optimization I feel is useful is mem2reg. Without that, if I want to
properly check the right values go to the right operands of the intrinsic calls
I have to write FileCheck matchers that match stores and their relevant loads,
plus bitcasts. This no
echristo added a comment.
I understand the conflicting priorities here for sure. You'd like a test that's
as minimal as possible, without having to depend on external (to clang)
libraries here. I really would appreciate it if you'd make the test not rely on
mem2reg etc so we can be sure that cl
Author: kparzysz
Date: Mon Dec 14 11:17:20 2015
New Revision: 255510
URL: http://llvm.org/viewvc/llvm-project?rev=255510&view=rev
Log:
[Hexagon] Xfail two tests that fail due to over-aligning arrays
Modified:
cfe/trunk/test/CodeGen/c-strings.c
cfe/trunk/test/CodeGen/string-literal-short-w
Author: marshall
Date: Mon Dec 14 11:34:03 2015
New Revision: 255513
URL: http://llvm.org/viewvc/llvm-project?rev=255513&view=rev
Log:
Add add_lvalue_ref tests for a few function types, with a note why not more
Modified:
libcxx/trunk/test/std/utilities/meta/meta.trans/meta.trans.ref/add_lval
Hello Everyone,
Here is the 6th Lit tests C++11 compatibility patch. It is super simple this
time.
17 OpenMP tests have their expected diagnostics updated. The changes to each
file are identical.
C++11 has expanded diagnostics when an expression is not an integral constant
expression.
C++11
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D15478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: petarj
Date: Mon Dec 14 11:51:50 2015
New Revision: 255515
URL: http://llvm.org/viewvc/llvm-project?rev=255515&view=rev
Log:
[Power PC] add soft float support for ppc32
This patch enables soft float support for ppc32 architecture and fixes
the ABI for variadic functions. This is the first
This revision was automatically updated to reflect the committed changes.
Closed by commit rL255515: [Power PC] add soft float support for ppc32
(authored by petarj).
Changed prior to commit:
http://reviews.llvm.org/D13351?vs=41736&id=42733#toc
Repository:
rL LLVM
http://reviews.llvm.org/D1
Author: marshall
Date: Mon Dec 14 12:01:56 2015
New Revision: 255517
URL: http://llvm.org/viewvc/llvm-project?rev=255517&view=rev
Log:
Fix a corner case that involved calling rethrow_if_nested with a type that had
a deleted operator&. Added a test to catch this as well. Thanks to Ville for
the h
Author: marshall
Date: Mon Dec 14 12:02:23 2015
New Revision: 255518
URL: http://llvm.org/viewvc/llvm-project?rev=255518&view=rev
Log:
Missed this on the previous (255517) commit
Modified:
libcxx/trunk/include/type_traits
Modified: libcxx/trunk/include/type_traits
URL:
http://llvm.org/viewv
Author: marshall
Date: Mon Dec 14 12:11:51 2015
New Revision: 255519
URL: http://llvm.org/viewvc/llvm-project?rev=255519&view=rev
Log:
K-Ballo pointed out a mistake in the add_lvalue_ref tests I checked in; now
more of them are passing. Thanks
Modified:
libcxx/trunk/test/std/utilities/meta/
Author: majnemer
Date: Mon Dec 14 12:34:18 2015
New Revision: 255521
URL: http://llvm.org/viewvc/llvm-project?rev=255521&view=rev
Log:
[MS ABI] Don't rely on terminatepad
We'd like to remove support for terminatepad from LLVM. To do this, we
need to move Clang off of it first. The intent behind
This revision was automatically updated to reflect the committed changes.
Closed by commit rL255521: [MS ABI] Don't rely on terminatepad (authored by
majnemer).
Changed prior to commit:
http://reviews.llvm.org/D15478?vs=42641&id=42736#toc
Repository:
rL LLVM
http://reviews.llvm.org/D15478
Akira Hatanaka via cfe-commits writes:
> ahatanak created this revision.
> ahatanak added a subscriber: cfe-commits.
>
> This patch fixes a crash that occurs when __kindof is incorrectly used
> in the type parameter list of an interface. The crash occurs because
> ObjCTypeParamList::back() is call
On 14 December 2015 at 09:20, Eric Christopher via cfe-commits
wrote:
> I understand the conflicting priorities here for sure. You'd like a test
> that's as minimal as possible, without having to depend on external (to
> clang) libraries here. I really would appreciate it if you'd make the test
Author: hans
Date: Mon Dec 14 12:46:11 2015
New Revision: 255524
URL: http://llvm.org/viewvc/llvm-project?rev=255524&view=rev
Log:
clang-cl: make /Wall turn on both -Wall and -Wextra (PR25563)
The documentation suggests /Wall should really turn on -Wextra and any
other warnings that are not enabl
doug.gregor added a comment.
For reference, you can test this by setting the environment variable
LIBCLANG_TIMING in your test, and checking that the string "Precompiling
preamble" shows up on first parse.
http://reviews.llvm.org/D15490
___
cfe-co
On Mon, Dec 14, 2015 at 10:44 AM Tim Northover
wrote:
> On 14 December 2015 at 09:20, Eric Christopher via cfe-commits
> wrote:
> > I understand the conflicting priorities here for sure. You'd like a test
> that's as minimal as possible, without having to depend on external (to
> clang) librarie
jroelofs added a comment.
Can you write up a couple of testcases for the new diagnostic? There should be
some examples you can follow in clang/test/Sema ans clang/test/SemaCXX.
I'd also be interested in seeing a concrete example of the setter thing you
were talking about in ObjC/ObjC++.
http:
> I don't think it's going to be even vaguely that bad here and that you're
> blowing it a bit out of proportion. [...] It does make the tests a little
> harder
> to write, but having done a bunch of them it's not that bad.
I've also tried to write such tests in the past, and I did find it that b
On Mon, Dec 14, 2015 at 11:05 AM Tim Northover
wrote:
> > I don't think it's going to be even vaguely that bad here and that you're
> > blowing it a bit out of proportion. [...] It does make the tests a
> little harder
> > to write, but having done a bunch of them it's not that bad.
>
> I've also
Author: rjmccall
Date: Mon Dec 14 13:12:54 2015
New Revision: 255531
URL: http://llvm.org/viewvc/llvm-project?rev=255531&view=rev
Log:
Allow pseudo-destructor calls on forward-declared Objective-C class pointers.
rdar://18522255
Added:
cfe/trunk/test/SemaObjCXX/pseudo-destructor.mm
Modified:
george.burgess.iv added a comment.
Ping :)
http://reviews.llvm.org/D14938
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig marked 3 inline comments as done.
bcraig added a comment.
In http://reviews.llvm.org/D14779#309170, @zaks.anna wrote:
> With respect to the issues this checker found, I suggest submitting patches
> for the clang issues that can be fixed. Can the x-macro case be suppressed
> with the reco
On 14 December 2015 at 11:12, Eric Christopher wrote:
> There really is a pretty good separation of concerns and for a lot if not
> most of the tests here all the difference is checking is the arguments,
> keeping track of an alloca and making sure that goes is pretty simple and
> not really hard
Author: petarj
Date: Mon Dec 14 13:22:35 2015
New Revision: 255533
URL: http://llvm.org/viewvc/llvm-project?rev=255533&view=rev
Log:
[PowerPC] Fix make-check issues
Previous change r255515 introduced a couple of issues likely caused by
a different configure setup.
Modified:
cfe/trunk/test/Co
Fwiw, I am certainly in Tim'a camp here! Writing a test for that output is
doable, and if that's what people want then that's what we'll do. But it's
certainly not nice or readable !
On Mon, 14 Dec 2015 at 19:25, Tim Northover via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On 14 December 2
bkramer updated this revision to Diff 42749.
bkramer added a comment.
Add test case.
http://reviews.llvm.org/D15490
Files:
include/clang-c/Index.h
include/clang/Frontend/ASTUnit.h
lib/Frontend/ASTUnit.cpp
test/Index/complete-preamble.cpp
tools/c-index-test/c-index-test.c
tools/libcl
zaks.anna added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/Checkers.td:49
@@ -48,1 +48,3 @@
+def Performance : Package<"performance">;
+
zaks.anna wrote:
> I think Performance should be in the OptIn package.
What do you think about this one?
http
Author: petarj
Date: Mon Dec 14 14:30:02 2015
New Revision: 255539
URL: http://llvm.org/viewvc/llvm-project?rev=255539&view=rev
Log:
[PowerPC] Fix test/CodeGen/ppc-sfvarargs
The issue seems to be that .ll file may either use number of register
value or alias %numUsedRegs, so the check needs to co
bcraig updated this revision to Diff 42742.
bcraig marked an inline comment as done.
http://reviews.llvm.org/D14779
Files:
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/PaddingChecker.cpp
test/Analysis/padding_c.c
test/Ana
bcraig marked 2 inline comments as done.
bcraig added a comment.
http://reviews.llvm.org/D14779
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sbenza created this revision.
sbenza added a reviewer: klimek.
sbenza added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Allow hasName() to look through inline namespaces.
This will fix the interaction between some clang-tidy checks and libc++.
libc++ defines names in an inline n
zaks.anna added a comment.
I wonder if we can refactor the code so that it is less error prone..
shouldSkipFunction(D, Visited, VisitedAsTopLevel) works with two sets. I assume
that you have not updated Decls coming from VisitedAsTopLevel because they come
from the CFG and should already be can
LegalizeAdulthood added inline comments.
Comment at: test/clang-tidy/misc-string-integer-assignment.cpp:46
@@ +45,3 @@
+ ws += L'c';
+ ws += (wchar_t)6;
+
Use `static_cast<>` instead of C-style cast?
http://reviews.llvm.org/D15411
__
LegalizeAdulthood added inline comments.
Comment at: test/clang-tidy/misc-string-integer-assignment.cpp:33
@@ +32,3 @@
+ s = 'c';
+ s = (char)6;
+
What happens if the test code had used `static_cast`?
http://reviews.llvm.org/D15411
_
On 12/11/2015 04:40 PM, Daniel Jasper wrote:
Please submit patches to clang-format to reviews.llvm.org. Also, any change
no matter how easy it is to deduce from the code itself deserves a proper
change description :-). Bullet points are fine.
Thanks for the quick reply. I've submitted the patc
George Burgess IV via cfe-commits writes:
> george.burgess.iv created this revision.
> george.burgess.iv added a reviewer: doug.gregor.
> george.burgess.iv added subscribers: cfe-commits, doug.gregor.
>
> Currently, code like this compiles cleanly in C++, but with warnings
> (as it should) in C:
On Mon, Dec 14, 2015 at 10:39 AM, Justin Bogner
wrote:
> Akira Hatanaka via cfe-commits writes:
> > ahatanak created this revision.
> > ahatanak added a subscriber: cfe-commits.
> >
> > This patch fixes a crash that occurs when __kindof is incorrectly used
> > in the type parameter list of an in
beanz updated this revision to Diff 42761.
beanz added a comment.
Updates based on feedback from Sean and Vedant.
- Should work on Windows now
- Cleaned up lit config code
http://reviews.llvm.org/D15462
Files:
CMakeLists.txt
utils/perf-training/CMakeLists.txt
utils/perf-training/README.t
ping
On Mon, Nov 30, 2015 at 4:30 PM, Akira Hatanaka wrote:
> ahatanak created this revision.
> ahatanak added a subscriber: cfe-commits.
>
> Issue a warning if an initializing integer expression overflows.
>
> For example, clang should issue a warning when compiling the following
> code because
zturner added a comment.
In http://reviews.llvm.org/D10370#309789, @djasper wrote:
> I think we can add the option AlwaysBreakAfterReturnType but still be
> backwards compatible. If clang-format finds only the old option in a
> configuration file, it can choose the appropriate value of the new
aaron.ballman added a subscriber: aaron.ballman.
Comment at: lib/ASTMatchers/ASTMatchersInternal.cpp:320
@@ -323,3 +319,3 @@
- if (Pattern.startswith("::"))
-return FullName == Pattern;
+ for (bool SkipUnwritten : {false, true}) {
+llvm::SmallString<128> NodeName = Str
MSVC 2013 Update 5 accepts for (bool SkipUnwritten : {false, true}).
Possibly changed in one of the Updates?
2015-12-14 23:35 GMT+02:00 Aaron Ballman via cfe-commits <
cfe-commits@lists.llvm.org>:
> aaron.ballman added a subscriber: aaron.ballman.
>
>
> Comment at: lib/ASTMatcher
Author: bcraig
Date: Mon Dec 14 15:38:59 2015
New Revision: 255545
URL: http://llvm.org/viewvc/llvm-project?rev=255545&view=rev
Log:
[PATCH] Adding checker to detect excess padding in records
The intent of this checker is to generate a report for any class / structure
that could reduce its paddin
On Mon, Dec 14, 2015 at 4:39 PM, Yaron Keren wrote:
> MSVC 2013 Update 5 accepts for (bool SkipUnwritten : {false, true}).
> Possibly changed in one of the Updates?
I tested using MSVC 2013 Update 5.
Microsoft Visual Studio Ultimate 2013
Version 12.0.40629.00 Update 5
Microsoft .NET Framework
Ve
bcraig closed this revision.
bcraig added a comment.
Submitted to r255545
http://reviews.llvm.org/D14779
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added a comment.
I would be interested in seeing test cases where this is an improvement. For
instance, would it be equally as useful to pass in the type range to the
existing diagnostic so that the type gets highlighted as well (and skip the
note entirely)?
http://reviews.llvm.
sbenza updated this revision to Diff 42767.
sbenza added a comment.
Minor fixes
http://reviews.llvm.org/D15506
Files:
lib/ASTMatchers/ASTMatchersInternal.cpp
unittests/ASTMatchers/ASTMatchersTest.cpp
Index: unittests/ASTMatchers/ASTMatchersTest.cpp
=
That's odd. I'm using the same update 5 exactly, added " for (bool
SkipUnwritten : {false, true});" inside a LLVM source file and re-compiled.
MSVC complained about the unused SkipUnwritten but was therwise OK with the
code.
2015-12-14 23:43 GMT+02:00 Aaron Ballman :
> On Mon, Dec 14, 2015 at 4
sbenza added a comment.
I am thinking on doing this some other way.
Copying the PrintingPolicy object is very expensive, as it contains quite a few
strings and vectors of strings.
In the past I changed this matcher to make no allocations in the common path
(ie using SmallString<>, etc) to reduce
Author: bcraig
Date: Mon Dec 14 15:54:11 2015
New Revision: 22
URL: http://llvm.org/viewvc/llvm-project?rev=22&view=rev
Log:
Reordering fields to reduce padding in Clang. NFC
Modified:
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
cfe/trunk/lib/Sema/SemaType.cpp
Modified: cfe/trunk/lib/Co
aaron.ballman added inline comments.
Comment at: lib/ASTMatchers/ASTMatchersInternal.cpp:320-331
@@ -323,4 +319,14 @@
- if (Pattern.startswith("::"))
-return FullName == Pattern;
+ const bool SkipUnwrittenCases[] = {false, true};
+ for (bool SkipUnwritten : SkipUnwrittenC
yaron.keren added inline comments.
Comment at: lib/ASTMatchers/ASTMatchersInternal.cpp:322
@@ +321,3 @@
+ for (bool SkipUnwritten : SkipUnwrittenCases) {
+llvm::SmallString<128> NodeName = StringRef("::");
+llvm::raw_svector_ostream OS(NodeName);
StringRe
> Are there already tests in place for the C version? I assume so, but
> please double check.
Looks to me like the warning in the example is tested in C. Added 2
other cases (assignment + passing a _Nullable variable as a
_Nonnull argument) for good measure.
> LGTM with a couple of nits, below.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL26: [Sema] Make nullness warnings appear in C++.
(authored by gbiv).
Changed prior to commit:
http://reviews.llvm.org/D14938?vs=40987&id=42770#toc
Repository:
rL LLVM
http://reviews.llvm.org/D14
Author: gbiv
Date: Mon Dec 14 16:00:49 2015
New Revision: 26
URL: http://llvm.org/viewvc/llvm-project?rev=26&view=rev
Log:
[Sema] Make nullness warnings appear in C++.
Given the following code:
int *_Nullable ptr;
int *_Nonnull nn = ptr;
...In C, clang will warn you about `nn =
EricWF updated the summary for this revision.
EricWF updated this revision to Diff 42772.
EricWF added a comment.
This patch is updated in the following ways:
1. No longer try and remove `-Wl,-z,defs` from the link flags. I think I was
mistaken that this caused an issue.
2. No longer try and lin
zturner updated this revision to Diff 42774.
zturner added a comment.
This patch was very old, so it didn't apply against ToT. So this initial
update is just to rebase against ToT. I will make changes in a followup patch.
http://reviews.llvm.org/D10370
Files:
include/clang/Format/Format.h
rizsotto.mailinglist added inline comments.
Comment at: tools/scan-build-py/libear/ear.c:142
@@ +141,3 @@
+#endif
+if (!initialized)
+initialized = bear_capture_env_t(&initial_env);
dcoughlin wrote:
> rizsotto.mailinglist wrote:
> > rizsotto.mailinglis
davidxl added inline comments.
Comment at: cfe/trunk/test/CodeGen/pgo-max-function-count.c:1
@@ +1,2 @@
+// RUN: %clang -fprofile-generate -o %t -O2 %s
+// RUN: env LLVM_PROFILE_FILE=%t.profraw %t
Use -fprofile-instr-generate option. -fprofile-generate is for GCC
Author: ericwf
Date: Mon Dec 14 16:20:04 2015
New Revision: 29
URL: http://llvm.org/viewvc/llvm-project?rev=29&view=rev
Log:
[libc++abi] Use libgcc and libgcc_s to provide _Unwind symbols instead of
libgcc_eh.a
Summary:
libgcc_eh.a cannot be used when building libc++abi as a shared libra
This revision was automatically updated to reflect the committed changes.
Closed by commit rL29: [libc++abi] Use libgcc and libgcc_s to provide
_Unwind symbols instead of… (authored by EricWF).
Changed prior to commit:
http://reviews.llvm.org/D15440?vs=42772&id=42777#toc
Repository:
rL L
Author: ericwf
Date: Mon Dec 14 16:24:19 2015
New Revision: 255560
URL: http://llvm.org/viewvc/llvm-project?rev=255560&view=rev
Log:
Update how libc++/libc++abi link the tests. Follow up on r29.
Modified:
libcxx/trunk/test/libcxx/test/config.py
Modified: libcxx/trunk/test/libcxx/test/con
EricWF closed this revision.
EricWF added a comment.
r255560.
http://reviews.llvm.org/D15441
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Mon Dec 14 16:26:28 2015
New Revision: 255561
URL: http://llvm.org/viewvc/llvm-project?rev=255561&view=rev
Log:
Update paths in libc++ build instructions. Patch from Jonathan Anderson.
Modified:
libcxx/trunk/docs/BuildingLibcxx.rst
Modified: libcxx/trunk/docs/BuildingLib
1 - 100 of 141 matches
Mail list logo
