Re: r257251 - [modules] If we're treating an elaborated-type-specifier as if it introduces a

Thanks. But a few C headers are complaining. Investigating. http://lab.llvm.org:8011/builders/clang-x86_64-linux-selfhost-modules/builds/10380 On Sat, Jan 9, 2016 at 4:02 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Sat Jan 9 00:58:48 2016 > New

r257252 - Test Commit

Author: pxl Date: Sat Jan 9 01:12:32 2016 New Revision: 257252 URL: http://llvm.org/viewvc/llvm-project?rev=257252&view=rev Log: Test Commit Fix a typo Modified: cfe/trunk/lib/AST/Type.cpp Modified: cfe/trunk/lib/AST/Type.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/Type

Re: r256907 - [modules] When a tag type that was imported from a module is referenced via an

On Fri, Jan 8, 2016 at 3:19 PM, NAKAMURA Takumi wrote: > Seems causes failure in selfhosting. > > http://lab.llvm.org:8011/builders/clang-x86_64-linux-selfhost-modules/builds/10188 > > FYI, I saw the log below (on my local branch); > > While building module 'LLVM_Utils' imported from > ~/llvm/llv

r257251 - [modules] If we're treating an elaborated-type-specifier as if it introduces a

Author: rsmith Date: Sat Jan 9 00:58:48 2016 New Revision: 257251 URL: http://llvm.org/viewvc/llvm-project?rev=257251&view=rev Log: [modules] If we're treating an elaborated-type-specifier as if it introduces a tag (because the previous declaration was found in a different module), inject the tag

Re: r256049 - Split RequireCompleteType into a function that actually requires that the type

On Fri, Jan 8, 2016 at 4:08 PM, Richard Smith wrote: > On Thu, Jan 7, 2016 at 6:00 PM, David Blaikie wrote: > >> On Fri, Dec 18, 2015 at 2:40 PM, Richard Smith via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> Author: rsmith >>> Date: Fri Dec 18 16:40:25 2015 >>> New Revision: 25604

Re: [clang-tools-extra] r257178 - [clang-tidy] Add non-inline function definition and variable definition check in header files.

On Fri, Jan 8, 2016 at 6:26 PM, Alexander Kornienko wrote: > I don't see how -Wmissing-declarations relates to this check. None of the > warnings in the MissingDeclarations group in DiagnosticSemaKinds.td seem to > be anywhere close to what this check does. Am I missing something? > Ah, sorry -

Re: r256962 - Module debugging: Defer emitting tag types until their definition

Thanks! On Fri, Jan 8, 2016 at 5:15 PM, Adrian Prantl wrote: > > > On Jan 8, 2016, at 2:18 PM, Adrian Prantl via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > > >> > >> On Jan 8, 2016, at 1:59 PM, David Blaikie wrote: > >> > >> > >> > >> On Fri, Jan 8, 2016 at 1:34 PM, Adrian Prantl >

Re: [clang-tools-extra] r257178 - [clang-tidy] Add non-inline function definition and variable definition check in header files.

I don't see how -Wmissing-declarations relates to this check. None of the warnings in the MissingDeclarations group in DiagnosticSemaKinds.td seem to be anywhere close to what this check does. Am I missing something? On Fri, Jan 8, 2016 at 7:53 PM, David Blaikie wrote: > This sounds sort of like

Re: [PATCH] D8940: Clang changes for indirect call target profiling

vsk added a subscriber: vsk. vsk added a comment. Thanks betul! Just a minor nit. Comment at: lib/CodeGen/CGCall.cpp:3550 @@ +3549,3 @@ +DirectCallee = dyn_cast (Callee); + if (!DirectCallee) +PGO.valueProfile(Builder, llvm::IPVK_IndirectCallTarget, Rep

Re: [PATCH] D16008: [clang-tidy] Add calling virtual functions in constructors/destructors check.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. This check is duplicate of clang-analyzer-alpha.cplusplus.VirtualCall. From my point of view, Clang-tidy is better place, since such calls doesn't depend of run-time paths. I think will be good idea to try to est

Re: r256962 - Module debugging: Defer emitting tag types until their definition

> On Jan 8, 2016, at 2:18 PM, Adrian Prantl via cfe-commits > wrote: > >> >> On Jan 8, 2016, at 1:59 PM, David Blaikie wrote: >> >> >> >> On Fri, Jan 8, 2016 at 1:34 PM, Adrian Prantl wrote: >> >>> On Jan 8, 2016, at 1:31 PM, David Blaikie wrote: >>> >>> >>> >>> On Wed, Jan 6, 2016 a

r257241 - Module debugging: Add a testcase for standalone forward declarations.

Author: adrian Date: Fri Jan 8 19:11:35 2016 New Revision: 257241 URL: http://llvm.org/viewvc/llvm-project?rev=257241&view=rev Log: Module debugging: Add a testcase for standalone forward declarations. Modified: cfe/trunk/test/Modules/Inputs/DebugCXX.h cfe/trunk/test/Modules/ModuleDebugI

r257240 - Only take NULL macros instead of all macros into account for -Wnull-conversion.

Author: rtrieu Date: Fri Jan 8 19:10:17 2016 New Revision: 257240 URL: http://llvm.org/viewvc/llvm-project?rev=257240&view=rev Log: Only take NULL macros instead of all macros into account for -Wnull-conversion. Modified: cfe/trunk/lib/Sema/SemaChecking.cpp cfe/trunk/test/SemaCXX/convers

Re: [libcxx] r196411 - Give all members of exception types default visibility. Lack of this is causing some illegal code relocations rare and hard to reproduce cases.

On Jan 8, 2016, at 7:50 PM, Duncan P. N. Exon Smith wrote: > > [re-send to lists.llvm.org] > [necromancy] > > This is causing some strangeness for users of libc++ headers that > ship dylibs and build with -fno-rtti and -fvisibility=hidden. > > Strangely, -fno-rtti does *not* imply -fno-excepti

Re: [libcxx] r196411 - Give all members of exception types default visibility. Lack of this is causing some illegal code relocations rare and hard to reproduce cases.

[re-send to lists.llvm.org] [necromancy] This is causing some strangeness for users of libc++ headers that ship dylibs and build with -fno-rtti and -fvisibility=hidden. Strangely, -fno-rtti does *not* imply -fno-exceptions; the type info needed for exceptions is generated on-the-fly. This means

Re: [libcxx] Reinstate and fix overload sets to be const-correct wherever possible

No one is waiting for me on this, are they? FWIW, this seems like a good solution to me. I'll see what I can do internally (I filed a radar), but other platforms will likely need this anyway. > On 2016-Jan-08, at 16:06, Richard Smith wrote: > > Ping, is this OK to commit? > > On Thu, Dec 10,

Re: r256049 - Split RequireCompleteType into a function that actually requires that the type

On Thu, Jan 7, 2016 at 6:00 PM, David Blaikie wrote: > On Fri, Dec 18, 2015 at 2:40 PM, Richard Smith via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: rsmith >> Date: Fri Dec 18 16:40:25 2015 >> New Revision: 256049 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=256049&view

Re: [libcxx] Reinstate and fix overload sets to be const-correct wherever possible

Ping, is this OK to commit? On Thu, Dec 10, 2015 at 3:32 PM, Richard Smith wrote: > On Thu, Dec 10, 2015 at 11:45 AM, Marshall Clow > wrote: > >> On Tue, Dec 8, 2015 at 3:52 PM, Richard Smith >>> wrote: >>> Ping. >>> >> Sorry about that. >> Completely missed this in my email flood. >

Lit Test C++11 Compatibility Patch #7

Hi Everyone, I am back again with another Lit test C++11 patch. This is the 7th patch. There are 13 tests in total. CXX/class.access/class.access.dcl/p1.cpp Access declarations are deprecated in C++11. As a result, there are 4 types of diagnostics changes: For simple access declarations,

Re: [PATCH] D8940: Clang changes for indirect call target profiling

betulb updated the summary for this revision. betulb edited reviewers, added: xur; removed: dsule, bob.wilson. betulb updated this revision to Diff 44386. betulb added a comment. This CL adds in the changes necessary for instrumenting and profile metadata-attaching at clang level for value profi

r257231 - Exclude function calls for functions which have return type nullptr_t from

Author: rtrieu Date: Fri Jan 8 17:35:06 2016 New Revision: 257231 URL: http://llvm.org/viewvc/llvm-project?rev=257231&view=rev Log: Exclude function calls for functions which have return type nullptr_t from -Wnull-conversion warning. These functions are basically equivalent to other pointer retu

Re: r256907 - [modules] When a tag type that was imported from a module is referenced via an

Seems causes failure in selfhosting. http://lab.llvm.org:8011/builders/clang-x86_64-linux-selfhost-modules/builds/10188 FYI, I saw the log below (on my local branch); While building module 'LLVM_Utils' imported from ~/llvm/llvm-project/llvm/lib/Support/TargetParser.cpp:15: While building module '

Re: [PATCH] D8056: Fix for bug 21725: wrong results with union and strict-aliasing

yinma added a subscriber: yinma. yinma added a comment. Hello, I am wondering if the current llvm/clang's tbaa supports union or not? http://reviews.llvm.org/D8056 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

Re: r252114 - [modules] If we're given a module file, via -fmodule-file=, for a module, but

> On Jan 8, 2016, at 2:39 PM, Adrian Prantl wrote: > > Hi Richard, > > This change >> @@ -2239,16 +2240,21 @@ ASTReader::ReadControlBlock(ModuleFile &F, > [...] >> - if (!DisableValidation && Result != Success && >> - (Result != ConfigurationMismatch || >> !AllowConfigur

r257222 - [modules] Make sure we always include the contents of private headers when

Author: rsmith Date: Fri Jan 8 16:36:45 2016 New Revision: 257222 URL: http://llvm.org/viewvc/llvm-project?rev=257222&view=rev Log: [modules] Make sure we always include the contents of private headers when building a module. Prior to this change, the private header's content would only be includ

Re: r252114 - [modules] If we're given a module file, via -fmodule-file=, for a module, but

Hi Richard, This change > @@ -2239,16 +2240,21 @@ ASTReader::ReadControlBlock(ModuleFile &F, [...] > - if (!DisableValidation && Result != Success && > - (Result != ConfigurationMismatch || > !AllowConfigurationMismatch)) > + if (DisableValidation || > +

Re: [PATCH] D15911: Move ownership of Action objects into Compilation.

jlebar updated this revision to Diff 44379. jlebar marked 4 inline comments as done. jlebar added a comment. Address tra and dblaikie's review comments. http://reviews.llvm.org/D15911 Files: include/clang/Driver/Action.h include/clang/Driver/Compilation.h include/clang/Driver/Driver.h l

Re: [PATCH] D15911: Move ownership of Action objects into Compilation.

jlebar added inline comments. Comment at: include/clang/Driver/Action.h:36 @@ -35,1 +35,3 @@ +/// +/// Actions are usually owned by a Compilation. class Action { tra wrote: > There's no API to pass ownership to Compilation explicitly, so the only way > for an Ac

Re: r256962 - Module debugging: Defer emitting tag types until their definition

> On Jan 8, 2016, at 1:59 PM, David Blaikie wrote: > > > > On Fri, Jan 8, 2016 at 1:34 PM, Adrian Prantl > wrote: > >> On Jan 8, 2016, at 1:31 PM, David Blaikie > > wrote: >> >> >> >> On Wed, Jan 6, 2016 at 11:22 AM, Adrian Prantl via c

Re: [PATCH] D15960: Don't build jobs for the same Action + ToolChain twice.

jlebar added a comment. OK, this is now working, please have a look. I'm not sure if it's possible to write a test as-is, but I have a test for my mistake in my WIP CUDA patch. (Also this mistake is much harder to make after http://reviews.llvm.org/D16013.) http://reviews.llvm.org/D15960

Re: [PATCH] D15960: Don't build jobs for the same Action + ToolChain twice.

jlebar updated this revision to Diff 44377. jlebar added a dependency: D16013: Make Driver::BuildJobsForAction return an InputInfo, instead of using an outparam.. jlebar added a comment. Fixing bug caused by missing an outparam. Covered by tests in WIP CUDA+ptxas+fatbin patch. Depends on http:/

Re: [PATCH] D15911: Move ownership of Action objects into Compilation.

dblaikie added inline comments. Comment at: include/clang/Driver/Compilation.h:54 @@ +53,3 @@ + /// to consumers; it's here just to manage ownership. + std::vector> OwningActions; + Seems like this name isn't quite right ("OwningActions" sounds like "these are

Re: [PATCH] D15743: Fix assert hit when tree-transforming template template parameter packs.

dblaikie added a subscriber: dblaikie. Comment at: test/SemaTemplate/temp_arg_template.cpp:80 @@ +79,3 @@ +#if __cplusplus >= 201103L + static constexpr int N = sizeof...(Templates); +#endif It would be good if we tested for some specific behavior here other than

Re: r256962 - Module debugging: Defer emitting tag types until their definition

On Fri, Jan 8, 2016 at 1:34 PM, Adrian Prantl wrote: > > On Jan 8, 2016, at 1:31 PM, David Blaikie wrote: > > > > On Wed, Jan 6, 2016 at 11:22 AM, Adrian Prantl via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: adrian >> Date: Wed Jan 6 13:22:19 2016 >> New Revision: 256962 >>

[PATCH] D16012: Carry raw string literal information through to the AST StringLiteral representation

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, dblaikie. aaron.ballman added a subscriber: cfe-commits. The AST does not currently carry information about whether a string literal is raw or not in the StringLiteral AST representation, which this patch rectifies. It e

Re: [PATCH] D15861: Support fully-qualified names for all QualTypes

Hi Richard, In our use (Persistency of C++ objects, including the (meta)description of their data content as well as use the name as key to access the class' reflection information at run-time), the 'context' is indeed always the "at the end of the translation unit"

Re: [PATCH] D15097: [Sema] Issue a warning for integer overflow in struct initializer

vsk added a subscriber: vsk. vsk added a comment. Looks good to me. Caveat: This isn't quite my area. This seems reasonable given what I've read in `EvaluateForOverflow` and `EvaluateAsRValue`. I think you should be fine to commit if no one objects soon. http://reviews.llvm.org/D15097

Re: r256962 - Module debugging: Defer emitting tag types until their definition

> On Jan 8, 2016, at 1:31 PM, David Blaikie wrote: > > > > On Wed, Jan 6, 2016 at 11:22 AM, Adrian Prantl via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Author: adrian > Date: Wed Jan 6 13:22:19 2016 > New Revision: 256962 > > URL: http://llvm.org/viewvc/llvm-project?rev=256

Re: r256962 - Module debugging: Defer emitting tag types until their definition

On Wed, Jan 6, 2016 at 11:22 AM, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: adrian > Date: Wed Jan 6 13:22:19 2016 > New Revision: 256962 > > URL: http://llvm.org/viewvc/llvm-project?rev=256962&view=rev > Log: > Module debugging: Defer emitting tag types until th

Re: [PATCH] D15097: [Sema] Issue a warning for integer overflow in struct initializer

ahatanak added a comment. ping http://reviews.llvm.org/D15097 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r257205 - [MS ABI] Complete and base constructor GlobalDecls must have the same name

Author: majnemer Date: Fri Jan 8 14:48:26 2016 New Revision: 257205 URL: http://llvm.org/viewvc/llvm-project?rev=257205&view=rev Log: [MS ABI] Complete and base constructor GlobalDecls must have the same name Clang got itself into the situation where we mangled the same constructor twice with tw

Re: r249995 - [Sema] Allow C conversions in C overload logic

George, This change caused a serious regression for Objective-C method lookup. See PR26085 (http://llvm.org/pr26085). For the test case in that PR, Sema::SelectBestMethod looks at the two candidate "test" methods. It will match the second one, but in the process of considering the first candid

[PATCH] D16007: [libcxxabi] Make test tolerant of uncommon floating literal demanglings

bcraig created this revision. bcraig added reviewers: howard.hinnant, logan, EricWF. bcraig added a subscriber: cfe-commits. libcxxabi uses the C99 library's %a format specifier to turn a floating point value into a hexadecimal string representation. The %a format specifier is rather loosely de

[PATCH] D16006: [libcxxabi] Teach cxa_demangle about Hexagon's long double size

bcraig created this revision. bcraig added reviewers: howard.hinnant, logan, dsanders, rengolin. bcraig added a subscriber: cfe-commits. cxa_demangle's default size for a long double is 10 bytes. Hexagon only has an 8 byte long double though. http://reviews.llvm.org/D16006 Files: src/cxa_dem

Re: [PATCH] D15861: Support fully-qualified names for all QualTypes

saugustine added a comment. Thanks for the reviews. Please take another look when you get a chance. Comment at: include/clang/Tooling/Core/QualTypeNames.h:32-33 @@ +31,4 @@ +namespace TypeName { +///\brief Convert the type into one with fully qualified template +/// arguments. +

Re: [PATCH] D15705: Adding a scripted test for PR25717

ygao updated this revision to Diff 44351. http://reviews.llvm.org/D15705 Files: test/Preprocessor/bigoutput.c Index: test/Preprocessor/bigoutput.c === --- test/Preprocessor/bigoutput.c +++ test/Preprocessor/bigoutput.c @@ -0,0 +1,

Re: [libcxx] r255177 - Remove visibility attributes from out-of-class method definitions in iostreams.

Thank you! On Fri, Jan 8, 2016 at 2:24 PM, Evgenii Stepanov wrote: > Reverted in r257193. > > On Fri, Jan 8, 2016 at 11:12 AM, Evgenii Stepanov > wrote: > > On Fri, Jan 8, 2016 at 11:02 AM, Duncan P. N. Exon Smith > > wrote: > >> > >>> On 2016-Jan-08, at 10:49, Nico Weber via cfe-commits < > c

Re: [PATCH] D15589: [PPC] Add long long/double support for vec_cts, vec_ctu and vec_ctf.

timshen closed this revision. timshen added a comment. Thanks iteratee for committing as r257135 ! http://reviews.llvm.org/D15589 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r257197 - Fix incorrectly line-broken comment in Driver.h.

Author: jlebar Date: Fri Jan 8 13:28:34 2016 New Revision: 257197 URL: http://llvm.org/viewvc/llvm-project?rev=257197&view=rev Log: Fix incorrectly line-broken comment in Driver.h. Also sort includes. Modified: cfe/trunk/include/clang/Driver/Driver.h Modified: cfe/trunk/include/clang/Drive

Re: [libcxx] r255177 - Remove visibility attributes from out-of-class method definitions in iostreams.

Reverted in r257193. On Fri, Jan 8, 2016 at 11:12 AM, Evgenii Stepanov wrote: > On Fri, Jan 8, 2016 at 11:02 AM, Duncan P. N. Exon Smith > wrote: >> >>> On 2016-Jan-08, at 10:49, Nico Weber via cfe-commits >>> wrote: >>> >>> On OS X 10.8, __ZNSt3__115basic_streambufIcNS_11char_traitsIcEEE5sput

[libcxx] r257193 - Revert "Remove visibility attributes from out-of-class method definitions in iostreams."

Author: eugenis Date: Fri Jan 8 13:21:02 2016 New Revision: 257193 URL: http://llvm.org/viewvc/llvm-project?rev=257193&view=rev Log: Revert "Remove visibility attributes from out-of-class method definitions in iostreams." Modified: libcxx/trunk/include/istream libcxx/trunk/include/ostre

Re: [libcxx] r255177 - Remove visibility attributes from out-of-class method definitions in iostreams.

On Fri, Jan 8, 2016 at 11:02 AM, Duncan P. N. Exon Smith wrote: > >> On 2016-Jan-08, at 10:49, Nico Weber via cfe-commits >> wrote: >> >> On OS X 10.8, __ZNSt3__115basic_streambufIcNS_11char_traitsIcEEE5sputcEc >> (and others) are a hidden symbol in libc++.1.dylib. This means: >> >> * If I use

Re: [PATCH] D15936: Update code in buildCudaActions and BuildActions to latest idiom.

This revision was automatically updated to reflect the committed changes. Closed by commit rL257190: Update code in buildCudaActions and BuildActions to latest idiom. (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D15936?vs=44158&id=44341#toc Repository: rL LLVM http

r257190 - Update code in buildCudaActions and BuildActions to latest idiom.

Author: jlebar Date: Fri Jan 8 13:04:11 2016 New Revision: 257190 URL: http://llvm.org/viewvc/llvm-project?rev=257190&view=rev Log: Update code in buildCudaActions and BuildActions to latest idiom. Summary: Use llvm::any_of, llvm::find, etc. No functional changes. Reviewers: tra Subscribers:

Re: [libcxx] r255177 - Remove visibility attributes from out-of-class method definitions in iostreams.

> On 2016-Jan-08, at 10:49, Nico Weber via cfe-commits > wrote: > > On OS X 10.8, __ZNSt3__115basic_streambufIcNS_11char_traitsIcEEE5sputcEc (and > others) are a hidden symbol in libc++.1.dylib. This means: > > * If I use streambuf::sputc() and link against the 10.8 SDK, and the compiler > d

[PATCH] D15999: Adding doxygen comments to the LLVM intrinsics (part 2, _wmmintrin_pclmul.h)

kromanova created this revision. kromanova added reviewers: gribozavr, jroelofs, ygao. kromanova added a subscriber: cfe-commits. kromanova set the repository for this revision to rL LLVM. Hello, Here is the patch with the doxygen comments for the intrinsincs in the header file __wmmintrin_pclmu

Re: [PATCH] D15911: Move ownership of Action objects into Compilation.

On Fri, Jan 8, 2016 at 10:55 AM, David Blaikie wrote: > > > On Fri, Jan 8, 2016 at 10:08 AM, Artem Belevich via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> tra added inline comments. >> >> >> Comment at: include/clang/Driver/Action.h:36 >> @@ -35,1 +35,3 @@ >> +/// >>

Re: [PATCH] D15911: Move ownership of Action objects into Compilation.

On Fri, Jan 8, 2016 at 10:08 AM, Artem Belevich via cfe-commits < cfe-commits@lists.llvm.org> wrote: > tra added inline comments. > > > Comment at: include/clang/Driver/Action.h:36 > @@ -35,1 +35,3 @@ > +/// > +/// Actions are usually owned by a Compilation. > class Action { > --

Re: [clang-tools-extra] r257178 - [clang-tidy] Add non-inline function definition and variable definition check in header files.

This sounds sort of like the missing-declaration warning in Clang, no? (granted, it's a bit more direct & thus perhaps easier to use, but fulfills a similar purpose) On Fri, Jan 8, 2016 at 8:37 AM, Alexander Kornienko via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: alexfh > Date: F

Fwd: r256287 - Document that we recommend to turn off -gmodules when building a static

(oops, forgot to reply-all) -- Forwarded message -- From: David Blaikie Date: Fri, Jan 8, 2016 at 10:51 AM Subject: Re: r256287 - Document that we recommend to turn off -gmodules when building a static To: Adrian Prantl On Fri, Jan 8, 2016 at 8:34 AM, Adrian Prantl wrote: >

Re: [libcxx] r255177 - Remove visibility attributes from out-of-class method definitions in iostreams.

On OS X 10.8, __ZNSt3__115basic_streambufIcNS_11char_traitsIcEEE5sputcEc (and others) are a hidden symbol in libc++.1.dylib. This means: * If I use streambuf::sputc() and link against the 10.8 SDK, and the compiler decides to not inline the call, I will get linker errors. * If I do the same with t

Re: [PATCH] D15911: Move ownership of Action objects into Compilation.

tra added inline comments. Comment at: include/clang/Driver/Action.h:36 @@ -35,1 +35,3 @@ +/// +/// Actions are usually owned by a Compilation. class Action { There's no API to pass ownership to Compilation explicitly, so the only way for an Action to be owned b

r257179 - [ThinLTO] Leverage new in-place renaming support

Author: tejohnson Date: Fri Jan 8 11:04:29 2016 New Revision: 257179 URL: http://llvm.org/viewvc/llvm-project?rev=257179&view=rev Log: [ThinLTO] Leverage new in-place renaming support Due to the new in-place renaming support added in r257174, we no longer need to invoke ThinLTO global renaming f

[clang-tools-extra] r257178 - [clang-tidy] Add non-inline function definition and variable definition check in header files.

Author: alexfh Date: Fri Jan 8 10:37:11 2016 New Revision: 257178 URL: http://llvm.org/viewvc/llvm-project?rev=257178&view=rev Log: [clang-tidy] Add non-inline function definition and variable definition check in header files. Summary: The new check will find all functionand variable definition

Re: [PATCH] D15710: [clang-tidy] Add non-inline function definition and variable definition check in header files.

This revision was automatically updated to reflect the committed changes. Closed by commit rL257178: [clang-tidy] Add non-inline function definition and variable definition check… (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D15710?vs=44318&id=44331#toc Repository:

Re: r256287 - Document that we recommend to turn off -gmodules when building a static

> On Jan 7, 2016, at 6:54 PM, David Blaikie wrote: > > Presumably this only applies when using implicit modules builds, not when > using explicit modules builds. (though I'm not sure what the current behavior > of -gmodules is with explicit modules, maybe it's untested/broken/etc anyway) Why

[clang-tools-extra] r257177 - Disable part of the misc-move-constructor-init checker when the check is enabled through cert-oop11-cpp. The CERT guideline does not cover moveable parameters as part of

Author: aaronballman Date: Fri Jan 8 09:50:51 2016 New Revision: 257177 URL: http://llvm.org/viewvc/llvm-project?rev=257177&view=rev Log: Disable part of the misc-move-constructor-init checker when the check is enabled through cert-oop11-cpp. The CERT guideline does not cover moveable parameter

Re: [PATCH] D15914: [OpenCL] Pipe builtin functions

Anastasia added a comment. Do you have any tests? We won't be able to commit without. Also having them would help understanding what this modification does. Comment at: include/clang/Basic/Builtins.def:1260 @@ +1259,3 @@ + +LANGBUILTIN(reserve_read_pipe, "i.", "tn", OCLC_LANG)

[clang-tools-extra] r257176 - [clang-tidy] Use proper capitalization and punctuation for diagnostic messages.

Author: alexfh Date: Fri Jan 8 09:21:40 2016 New Revision: 257176 URL: http://llvm.org/viewvc/llvm-project?rev=257176&view=rev Log: [clang-tidy] Use proper capitalization and punctuation for diagnostic messages. Use diagnostic parameters where possible instead of string concatenation. Modified:

Re: [PATCH] D15823: Support virtual-near-miss check.

congliu added inline comments. Comment at: clang-tidy/misc/VirtualNearMissCheck.cpp:232 @@ +231,3 @@ +const auto *BaseRD = BaseSpec.getType()->getAsCXXRecordDecl(); +if (BaseRD == nullptr) + return; alexfh wrote: > 1. When is this going to be nullptr?

Re: [PATCH] D15953: Driver: Pass -flavor gnu to lld for AMDGPU rather than -flavor gnu-old

This revision was automatically updated to reflect the committed changes. Closed by commit rL257175: Driver: Use the new ELF lld linker for AMDGPU (authored by tstellar). Changed prior to commit: http://reviews.llvm.org/D15953?vs=44249&id=44327#toc Repository: rL LLVM http://reviews.llvm.or

r257175 - Driver: Use the new ELF lld linker for AMDGPU

Author: tstellar Date: Fri Jan 8 09:14:31 2016 New Revision: 257175 URL: http://llvm.org/viewvc/llvm-project?rev=257175&view=rev Log: Driver: Use the new ELF lld linker for AMDGPU Summary: 'gnu-old' has been deprecated in favor or 'gnu'. Reviewers: arsenm, ruiu, rafael Subscribers: cfe-commits

Re: [PATCH] D15823: Support virtual-near-miss check.

congliu updated this revision to Diff 44328. congliu marked 33 inline comments as done. congliu added a comment. - Completed [class.virtual] p7 covarient check. Updated test. - Corrected implement of checkParamType. - Clean up. - Corrected typos. Changed some methods to free-standing. Changed warn

Re: [PATCH] D15924: [analyzer] Utility to extract the variable name from a memory region.

xazax.hun added inline comments. Comment at: lib/StaticAnalyzer/Core/MemRegion.cpp:586 @@ +585,3 @@ +return ""; + return nd->getName(); +} Alexander_Droste wrote: > Isn't calling `getDecl()` and `getName()` afterwards identical to > `printPretty()`? > Is it

Re: [PATCH] D15921: [analyzer] Utility to match function calls.

xazax.hun updated this revision to Diff 44325. xazax.hun added a comment. Updated the comments. http://reviews.llvm.org/D15921 Files: include/clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h lib/StaticAnalyzer/Checkers/SimpleStreamChecker.cpp lib/StaticAnalyzer/Core/CheckerContext

Re: [PATCH] D15921: [analyzer] Utility to match function calls.

xazax.hun updated this revision to Diff 44322. xazax.hun marked 4 inline comments as done. xazax.hun added a comment. - Removed support for matching ObjC messages. It might be added in a later. - Addressed review comments. http://reviews.llvm.org/D15921 Files: include/clang/StaticAnalyzer/Cor

[PATCH] D15994: Allow for unfinished #if blocks in preambles.

erikjv created this revision. erikjv added a reviewer: bkramer. erikjv added a subscriber: cfe-commits. Previously, a preamble only included #if blocks (and friends like #ifdef) if there was a corresponding #endif before any declaration or definition. The problem is that any header file that uses

r257135 - [PPC] Add long long/double support for vec_cts, vec_ctu and vec_ctf

Author: iteratee Date: Thu Jan 7 20:00:48 2016 New Revision: 257135 URL: http://llvm.org/viewvc/llvm-project?rev=257135&view=rev Log: [PPC] Add long long/double support for vec_cts, vec_ctu and vec_ctf Add long long/double support for vec_cts, vec_ctu and vec_ctf. Similar to this change in GCC:

Re: [PATCH] D15710: [clang-tidy] Add non-inline function definition and variable definition check in header files.

hokein marked an inline comment as done. hokein added a comment. http://reviews.llvm.org/D15710 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15710: [clang-tidy] Add non-inline function definition and variable definition check in header files.

hokein updated this revision to Diff 44318. hokein added a comment. Add check name in test. http://reviews.llvm.org/D15710 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/DefinitionsInHeadersCheck.cpp clang-tidy/misc/DefinitionsInHeadersCheck.h clang-tidy/misc/MiscTidyModule.cpp

Re: [PATCH] D15710: [clang-tidy] Add non-inline function definition and variable definition check in header files.

alexfh added inline comments. Comment at: test/clang-tidy/misc-definitions-in-headers.hpp:5 @@ +4,3 @@ +// CHECK-MESSAGES: :[[@LINE-1]]:5: warning: function 'f' defined in a header file; function definitions in header files can lead to ODR violations +// CHECK-FIXES: inline int f

Re: [PATCH] D15710: [clang-tidy] Add non-inline function definition and variable definition check in header files.

hokein marked 3 inline comments as done. Comment at: test/clang-tidy/misc-definitions-in-headers.hpp:4 @@ +3,3 @@ +int f() { +// CHECK-MESSAGES: :[[@LINE-1]]:5: warning: function 'f' defined in a header file; +// CHECK-FIXES: inline int f() { alexfh wrote: > Plea

Re: [PATCH] D15710: [clang-tidy] Add non-inline function definition and variable definition check in header files.

hokein marked an inline comment as done. hokein added a comment. http://reviews.llvm.org/D15710 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15710: [clang-tidy] Add non-inline function definition and variable definition check in header files.

hokein updated this revision to Diff 44317. hokein added a comment. More updates. http://reviews.llvm.org/D15710 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/DefinitionsInHeadersCheck.cpp clang-tidy/misc/DefinitionsInHeadersCheck.h clang-tidy/misc/MiscTidyModule.cpp docs/clan

Re: [PATCH] D15710: [clang-tidy] Add non-inline function definition and variable definition check in header files.

alexfh added a comment. Looks good with a few nits. Please fix them and I'll submit the patch for you. Thank you for working on this! Comment at: clang-tidy/misc/DefinitionsInHeadersCheck.cpp:23 @@ +22,3 @@ +AST_MATCHER(NamedDecl, isHeaderFileExtension) { + SourceManager& SM =

r257162 - clang-format: [JS] Prefer wrapping before the TypeScript return type

Author: djasper Date: Fri Jan 8 04:51:24 2016 New Revision: 257162 URL: http://llvm.org/viewvc/llvm-project?rev=257162&view=rev Log: clang-format: [JS] Prefer wrapping before the TypeScript return type over wrapping before parameters. Before: function someFunc( args: string[]): {longRetu

Re: [PATCH] D15710: [clang-tidy] Add non-inline function definition and variable definition check in header files.

hokein marked 4 inline comments as done. Comment at: clang-tidy/misc/DefinitionsInHeadersCheck.cpp:22 @@ +21,3 @@ + +AST_MATCHER(NamedDecl, useHeaderFileExtension) { + SourceManager& SM = Finder->getASTContext().getSourceManager(); alexfh wrote: > nit: This name

Re: [PATCH] D15710: [clang-tidy] Add non-inline function definition and variable definition check in header files.

hokein updated this revision to Diff 44313. hokein added a comment. Address Alex's comments. http://reviews.llvm.org/D15710 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/DefinitionsInHeadersCheck.cpp clang-tidy/misc/DefinitionsInHeadersCheck.h clang-tidy/misc/MiscTidyModule.cpp

Re: [PATCH] D13280: [OpenCL] Adding reserved operator logical xor for OpenCL

pxli168 added a subscriber: pxli168. pxli168 accepted this revision. pxli168 added a reviewer: pxli168. pxli168 added a comment. LGTM! http://reviews.llvm.org/D13280 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-b

r257159 - clang-format: [JS] Add some Closure Compiler JSDoc tags to the default

Author: djasper Date: Fri Jan 8 02:14:58 2016 New Revision: 257159 URL: http://llvm.org/viewvc/llvm-project?rev=257159&view=rev Log: clang-format: [JS] Add some Closure Compiler JSDoc tags to the default Google configuration so that they aren't line-wrapped. Modified: cfe/trunk/lib/Format/Fo