Author: jyknight
Date: Thu Jan 14 23:57:41 2016
New Revision: 257871
URL: http://llvm.org/viewvc/llvm-project?rev=257871&view=rev
Log:
Fix a -Wparentheses warning in ASTDiagnostic.cpp.
Modified:
cfe/trunk/lib/AST/ASTDiagnostic.cpp
Modified: cfe/trunk/lib/AST/ASTDiagnostic.cpp
URL:
http://ll
ABataev added a comment.
LG
Repository:
rL LLVM
http://reviews.llvm.org/D15220
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rtrieu
Date: Thu Jan 14 23:48:38 2016
New Revision: 257870
URL: http://llvm.org/viewvc/llvm-project?rev=257870&view=rev
Log:
Fixing more issues with template type diffing
1) Print qualifiers for templates with zero arguments
2) Add a few more tests for the template type diffing refactorin
pxli168 updated this revision to Diff 44965.
pxli168 added a comment.
Forget about get_pipe_num/max_packets builtin.
http://reviews.llvm.org/D15914
Files:
include/clang/Basic/Builtins.def
include/clang/Basic/Builtins.h
include/clang/Basic/DiagnosticSemaKinds.td
lib/Basic/Builtins.cpp
Author: rtrieu
Date: Thu Jan 14 23:01:53 2016
New Revision: 257869
URL: http://llvm.org/viewvc/llvm-project?rev=257869&view=rev
Log:
Add new diff modes to template type diffing.
Remove an old assertion that does not hold. It is possible for a template
argument to be a declaration in one instanti
This revision was automatically updated to reflect the committed changes.
Closed by commit rL257868: PR26111: segmentation fault with
__attribute__((mode(QI))) on function… (authored by ABataev).
Changed prior to commit:
http://reviews.llvm.org/D16112?vs=44859&id=44963#toc
Repository:
rL LLV
Author: abataev
Date: Thu Jan 14 22:36:32 2016
New Revision: 257868
URL: http://llvm.org/viewvc/llvm-project?rev=257868&view=rev
Log:
PR26111: segmentation fault with __attribute__((mode(QI))) on function
declaration, by Denis Zobnin
Allow "mode" attribute to be applied to VarDecl, not ValueDecl
pxli168 marked 2 inline comments as done.
Comment at: lib/Sema/SemaChecking.cpp:378
@@ +377,3 @@
+ }
+
+ return false;
Anastasia wrote:
> I am asking about setArg and not setType!
Oh, I just mistook your meaning. It seems we don't need that as we have to
covert
Author: abataev
Date: Thu Jan 14 22:06:31 2016
New Revision: 257867
URL: http://llvm.org/viewvc/llvm-project?rev=257867&view=rev
Log:
[X86] Support 'interrupt' attribute for x86
This attribute may be attached to a function definition and instructs the
backend to generate appropriate function entr
This revision was automatically updated to reflect the committed changes.
Closed by commit rL257867: [X86] Support 'interrupt' attribute for x86
(authored by ABataev).
Changed prior to commit:
http://reviews.llvm.org/D15709?vs=44754&id=44961#toc
Repository:
rL LLVM
http://reviews.llvm.org/D
thakis marked an inline comment as done.
thakis added a comment.
Also addressed your comment and added a test for that.
http://reviews.llvm.org/D15866
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
thakis updated this revision to Diff 44959.
thakis added a comment.
Address review comment.
http://reviews.llvm.org/D15866
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticLexKinds.td
lib/Lex/PPExpressions.cpp
test/Lexer/cxx-features.cpp
test/Preprocessor/e
Author: ahatanak
Date: Thu Jan 14 21:34:06 2016
New Revision: 257865
URL: http://llvm.org/viewvc/llvm-project?rev=257865&view=rev
Log:
[CodeGen] Attach attributes to thread local wrapper function.
This commit is a follow-up to r251734, r251476, and r249735, which fixes
a bug where function attrib
Thanks for the review!
I tweaked it a bit so that this only warns on function-type macros in
-pedantic mode. That way, the warning can even be used in practice :-)
On Thu, Jan 14, 2016 at 10:33 PM, Nico Weber wrote:
> thakis updated this revision to Diff 44958.
> thakis added a comment.
>
> For
Author: rsmith
Date: Thu Jan 14 21:24:18 2016
New Revision: 257863
URL: http://llvm.org/viewvc/llvm-project?rev=257863&view=rev
Log:
When copying whitespace flags from the token naming a macro argument onto the
first token of the expansion, don't forget to copy the "is at the start of a
line" toke
thakis updated this revision to Diff 44958.
thakis added a comment.
For function-type macros, make the warning only show up with -pedantic
http://reviews.llvm.org/D15866
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticLexKinds.td
lib/Lex/PPExpressions.cpp
te
Author: rtrieu
Date: Thu Jan 14 20:55:17 2016
New Revision: 257861
URL: http://llvm.org/viewvc/llvm-project?rev=257861&view=rev
Log:
Save the integer type for integral template arguments.
Save the integer type when diffing integers in template type diffing. When
integers are different sizes, pri
dblaikie added a subscriber: dblaikie.
dblaikie accepted this revision.
dblaikie added a reviewer: dblaikie.
dblaikie added a comment.
This revision is now accepted and ready to land.
Looks good - thanks!
http://reviews.llvm.org/D16206
___
cfe-commi
hokein marked 11 inline comments as done.
Comment at: clang-tidy/ClangTidy.h:65
@@ -56,3 +64,3 @@
/// \c CheckOptions. If the corresponding key is not present, returns
/// \p Default.
template
Makes sense. I just refer from `std::string get(StringRef Loc
Author: rtrieu
Date: Thu Jan 14 19:08:56 2016
New Revision: 257853
URL: http://llvm.org/viewvc/llvm-project?rev=257853&view=rev
Log:
Make template type diffing use the new desguared iterator.
If available, use the canonical template argument to fill in information for
template type diffing instea
hokein updated this revision to Diff 44951.
hokein added a comment.
Address review comments.
http://reviews.llvm.org/D16113
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidy.h
clang-tidy/google/GlobalNamesInHeadersCheck.cpp
clang-tidy/google/GlobalNamesInHeadersCheck.h
clang-tidy/g
thakis created this revision.
thakis added a reviewer: rtrieu.
thakis added a subscriber: cfe-commits.
-Wdelete-non-virtual-dtor warns if A is a type with virtual functions but
without virtual dtor has its constructor called via `delete a`. This makes the
warning also fire if the dtor is called
pcc updated this revision to Diff 44945.
pcc marked an inline comment as done.
pcc added a comment.
- Add note about win32 function name mangling
- Stop using -whole-archive to link the stats runtime
http://reviews.llvm.org/D16175
Files:
docs/SanitizerStats.rst
docs/UsersManual.rst
docs/i
On 14 January 2016 at 15:05, Zhao, Weiming wrote:
> I agree what you said about different code generated with clang and GCC
> generates. In this case, we should throw an error (err_late_asm_label).
>
> But in this example, there is no use of the function. They are just
> redundant declarations an
This revision was automatically updated to reflect the committed changes.
Closed by commit rL257839: [CUDA] Warn undeclared identifiers in CUDA kernel
calls (authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D15858?vs=44933&id=44938#toc
Repository:
rL LLVM
http://reviews
Author: jlebar
Date: Thu Jan 14 17:31:30 2016
New Revision: 257839
URL: http://llvm.org/viewvc/llvm-project?rev=257839&view=rev
Log:
[CUDA] Warn undeclared identifiers in CUDA kernel calls
Value, type, and instantiation dependence were not being handled
correctly for CUDAKernelCallExpr AST nodes.
Author: rtrieu
Date: Thu Jan 14 17:30:12 2016
New Revision: 257838
URL: http://llvm.org/viewvc/llvm-project?rev=257838&view=rev
Log:
Change the TSTiterator in Template Type Diffing.
Modify the TSTiterator to have two internal iterators, which will walk
the provided sugared type and the desugared
pcc updated this revision to Diff 44936.
pcc added a comment.
- Switch to an alternative in-memory representation that avoids the need for
linker magic
http://reviews.llvm.org/D16175
Files:
docs/SanitizerStats.rst
docs/UsersManual.rst
docs/index.rst
include/clang/AST/ASTConsumer.h
in
On Thu, Jan 14, 2016 at 03:05:26PM -0800, Zhao, Weiming via cfe-commits wrote:
> I agree what you said about different code generated with clang and GCC
> generates. In this case, we should throw an error (err_late_asm_label).
>
> But in this example, there is no use of the function. They are just
jhen marked an inline comment as done.
jhen added a comment.
Thanks for the review rsmith!
http://reviews.llvm.org/D15858
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jhen updated this revision to Diff 44933.
jhen added a comment.
- Add extra test for OK parameter pack
http://reviews.llvm.org/D15858
Files:
include/clang/AST/Expr.h
include/clang/AST/ExprCXX.h
lib/AST/Expr.cpp
test/SemaCUDA/cxx11-kernel-call.cu
test/SemaCUDA/kernel-call.cu
Index: te
I agree what you said about different code generated with clang and GCC
generates. In this case, we should throw an error (err_late_asm_label).
But in this example, there is no use of the function. They are just
redundant declarations and there is no actual code generated.
So I suggest we just
weimingz updated this revision to Diff 44931.
weimingz added a comment.
if the new decl is not used, we can just give warnings
http://reviews.llvm.org/D16171
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
test/Sema/asm-label.c
Index: test/Sema/asm-label.c
===
Author: rtrieu
Date: Thu Jan 14 16:56:39 2016
New Revision: 257831
URL: http://llvm.org/viewvc/llvm-project?rev=257831&view=rev
Log:
Refactor template type diffing
1) Instead of using pairs of From/To* fields, combine fields into a struct
TemplateArgInfo and have two in each DiffNode.
2) Use defa
Author: cbieneman
Date: Thu Jan 14 16:48:45 2016
New Revision: 257828
URL: http://llvm.org/viewvc/llvm-project?rev=257828&view=rev
Log:
[CMake] Move the install logic for libclang's headers into the libclang
CMakelists
This makes it so if you disable building libclang you won't install the heade
rsmith accepted this revision.
rsmith added a reviewer: rsmith.
rsmith added a comment.
LGTM, thanks!
Comment at: test/SemaCUDA/cxx11-kernel-call.cu:8
@@ +7,3 @@
+template void k1Wrapper() {
+ void (*f)() = [] { k1<<>>(); }; // expected-error
{{initializer contains unexpanded
Author: cbieneman
Date: Thu Jan 14 16:45:12 2016
New Revision: 257827
URL: http://llvm.org/viewvc/llvm-project?rev=257827&view=rev
Log:
[CMake] Set SVN_REVISION if CLANG_APPEND_VC_REV=On
This matches autoconf's ability to put clang revisions in the clang --version
spew.
Modified:
cfe/trunk/
On 14 January 2016 at 10:38, Weiming Zhao via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> weimingz added a comment.
>
> Hi Nick,
>
> Below is a reduced code:
> t.c:
>
> static long double acoshl (long double __x) __asm__ ("" "acosh") ; //
> this is from /arm-linux-gnueabi/libc/usr/includ
This revision was automatically updated to reflect the committed changes.
Closed by commit rL257809: [CUDA] Invoke ptxas and fatbinary during
compilation. (authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D16082?vs=44586&id=44921#toc
Repository:
rL LLVM
http://reviews.l
This revision was automatically updated to reflect the committed changes.
Closed by commit rL257810: [CUDA] Add test for compiling CUDA code with -S.
(authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D16081?vs=44542&id=44922#toc
Repository:
rL LLVM
http://reviews.llvm.o
Author: jlebar
Date: Thu Jan 14 15:41:21 2016
New Revision: 257808
URL: http://llvm.org/viewvc/llvm-project?rev=257808&view=rev
Log:
Don't build jobs for the same Action + ToolChain twice.
Summary:
Right now if the Action graph is a DAG and we encounter an action twice,
we will run it twice.
Thi
Author: jlebar
Date: Thu Jan 14 15:41:31 2016
New Revision: 257810
URL: http://llvm.org/viewvc/llvm-project?rev=257810&view=rev
Log:
[CUDA] Add test for compiling CUDA code with -S.
Reviewers: tra
Subscribers: cfe-commits, jhen
Differential Revision: http://reviews.llvm.org/D16081
Added:
c
Author: jlebar
Date: Thu Jan 14 15:41:27 2016
New Revision: 257809
URL: http://llvm.org/viewvc/llvm-project?rev=257809&view=rev
Log:
[CUDA] Invoke ptxas and fatbinary during compilation.
Summary:
Previously we compiled CUDA device code to PTX assembly and embedded
that asm as text in our host bin
This revision was automatically updated to reflect the committed changes.
Closed by commit rL257807: [CUDA] Add tests for compiling CUDA files with -E.
(authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D16080?vs=44823&id=44920#toc
Repository:
rL LLVM
http://reviews.llvm
Author: jlebar
Date: Thu Jan 14 15:41:18 2016
New Revision: 257807
URL: http://llvm.org/viewvc/llvm-project?rev=257807&view=rev
Log:
[CUDA] Add tests for compiling CUDA files with -E.
Reviewers: tra
Subscribers: cfe-commits, jhen
Differential Revision: http://reviews.llvm.org/D16080
Added:
This could be tested - though I'm not sure if there's precedent for testing
the types of builtins for other targets, for example. Might be worth
checking?
On Thu, Jan 14, 2016 at 6:26 AM, Krzysztof Parzyszek via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: kparzysz
> Date: Thu Jan 1
echristo accepted this revision.
echristo added a comment.
This is terrible, but the only other option is fixing bind arch and inverting
the graph which is a major rewrite to the driver.
So, LGTM.
-eric
http://reviews.llvm.org/D16082
___
cfe-comm
Author: ruiu
Date: Thu Jan 14 15:00:27 2016
New Revision: 257802
URL: http://llvm.org/viewvc/llvm-project?rev=257802&view=rev
Log:
Update for LLVM function name change.
Modified:
cfe/trunk/include/clang/AST/CharUnits.h
cfe/trunk/include/clang/AST/StmtOpenMP.h
cfe/trunk/include/clang/A
jhen added a comment.
rsmith, I think the patch is ready to be committed. Please take a look if you
have a moment. Thanks for your help.
http://reviews.llvm.org/D15858
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
-G isn't handled there at the moment but ClangAs::AddMIPSTargetArgs() and
Clang::AddMIPSTargetArgs() would be the right place to add it in the Linux
toolchain when we add it.
The cleanup I'm referring to is that someone hoisted the bulk of the code out
of the big switch-statement in Clang::Cons
rsmith added a comment.
I think you missed this from my previous review:
> This should be checked and diagnosed in Sema, not in CodeGen.
Comment at: lib/CodeGen/CGDeclCXX.cpp:333-337
@@ +332,7 @@
+ [](const CXXMethodDecl *Method) { return Method->isVirtual(); }))
+
rsmith accepted this revision.
This revision is now accepted and ready to land.
Comment at: lib/Lex/PPExpressions.cpp:104-105
@@ +103,4 @@
+ // #else branch. Emit a warning about this undefined behavior.
+ if (beginLoc.isMacroID())
+PP.Diag(beginLoc, diag::warn_defined_in_m
krasin1 added a subscriber: krasin1.
krasin1 accepted this revision.
krasin1 added a reviewer: krasin1.
krasin1 added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lib/Driver/SanitizerArgs.cpp:560
@@ +559,3 @@
+ LinkerOptionFlag = "--linker-option
carlo.bertolli updated this revision to Diff 44912.
carlo.bertolli added a comment.
Remove duplicated error-messages and replace with error-messages2 and 3
Repository:
rL LLVM
http://reviews.llvm.org/D15220
Files:
include/clang/AST/OpenMPClause.h
include/clang/AST/RecursiveASTVisitor.h
Sorry, but I fail to see where in AddMIPSTargetArgs the -G options are handled?
What is the general idea about the "new style" cleanup?
-Dimitry
> On 14 Jan 2016, at 18:13, Daniel Sanders wrote:
>
> Did you get an answer to this question? I think it's just that the FreeBSD
> class hasn't ref
ldionne updated this revision to Diff 44907.
ldionne marked 4 inline comments as done.
ldionne added a comment.
Address Richard Smith's review comments:
- Remove IndexType parameter, and make Index a std::size_t
- Remove assertion about APSInt::GetExtValue()
- Other style changes
Still left to d
Anastasia added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7670
@@ +7669,3 @@
+ "%0 can only be used as a function parameter">;
+def err_opencl_atomic_init_addressspace : Error<
+ "initialization of atomic variables is restricted to variables in glob
Anastasia added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:2082
@@ +2081,3 @@
+if (BuiltinID == Builtin::BIget_pipe_num_packets)
+ Name = "get_pipe_num_packets";
+else
prepend "__" here too!
Comment at: lib/Sema/SemaChec
weimingz added a comment.
Hi Nick,
Below is a reduced code:
t.c:
static long double acoshl (long double __x) __asm__ ("" "acosh") ; // this
is from /arm-linux-gnueabi/libc/usr/include/bits/mathcalls.h
extern long double acoshl (long double) __asm__ ("" "__acoshl_finite") ; //
this is from
sbenza added inline comments.
Comment at: clang-tidy/performance/FasterStringFindCheck.cpp:29
@@ +28,3 @@
+Class = Class.trim();
+ return std::vector(Classes.begin(), Classes.end());
+}
aaron.ballman wrote:
> I think hasName() will assert if given an empty st
sbenza updated this revision to Diff 44901.
sbenza marked an inline comment as done.
sbenza added a comment.
More checks in argument parsing.
http://reviews.llvm.org/D16152
Files:
clang-tidy/performance/CMakeLists.txt
clang-tidy/performance/FasterStringFindCheck.cpp
clang-tidy/performance
aaron.ballman added inline comments.
Comment at: clang-tidy/performance/FasterStringFindCheck.cpp:29
@@ +28,3 @@
+Class = Class.trim();
+ return std::vector(Classes.begin(), Classes.end());
+}
I think hasName() will assert if given an empty string, so this sh
Did you get an answer to this question? I think it's just that the FreeBSD
class hasn't refactored to that style yet.
That switch statement is getting quite large so it would be a nice cleanup to
switch to that style.
> -Original Message-
> From: cfe-commits [mailto:cfe-commits-boun...@l
sbenza marked 2 inline comments as done.
sbenza added a comment.
http://reviews.llvm.org/D16152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sbenza updated this revision to Diff 44889.
sbenza marked 2 inline comments as done.
sbenza added a comment.
Added support for non 'char' chars.
http://reviews.llvm.org/D16152
Files:
clang-tidy/performance/CMakeLists.txt
clang-tidy/performance/FasterStringFindCheck.cpp
clang-tidy/performa
pxli168 added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:593
@@ -592,2 +592,3 @@
+def err_no_declarators : Error<"declaration does not declare anything">;
def ext_typedef_without_a_name : ExtWarn<"typedef requires a name">,
InGroup;
---
alexfh added inline comments.
Comment at: clang-tidy/ClangTidyOptions.h:216
@@ +215,3 @@
+/// HeaderFileExtensions.
+bool endWithHeaderFileExtensions(llvm::StringRef FileName,
+ llvm::StringRef HeaderFileExtensions);
aaron.ballman w
sbenza marked an inline comment as done.
Comment at: clang-tidy/performance/FasterStringFindCheck.cpp:51
@@ +50,3 @@
+ const auto StringFindFunctions =
+ anyOf(hasName("find"), hasName("rfind"), hasName("find_first_of"),
+hasName("find_first_not_of"), hasName("fi
sbenza updated this revision to Diff 44886.
sbenza marked 4 inline comments as done.
sbenza added a comment.
Added template and macro tests.
Fixed warning message.
http://reviews.llvm.org/D16152
Files:
clang-tidy/performance/CMakeLists.txt
clang-tidy/performance/FasterStringFindCheck.cpp
Author: djg
Date: Thu Jan 14 10:00:13 2016
New Revision: 257774
URL: http://llvm.org/viewvc/llvm-project?rev=257774&view=rev
Log:
[WebAssembly] Configure some simple include paths and runtime library settings.
Modified:
cfe/trunk/lib/Driver/ToolChains.cpp
cfe/trunk/lib/Driver/ToolChains.h
pxli168 updated this revision to Diff 44881.
pxli168 added a comment.
Add prefix "__" to CodeGen builtin function name.
http://reviews.llvm.org/D15914
Files:
include/clang/Basic/Builtins.def
include/clang/Basic/Builtins.h
include/clang/Basic/DiagnosticSemaKinds.td
lib/Basic/Builtins.cpp
alexfh added inline comments.
Comment at: clang-tidy/performance/FasterStringFindCheck.cpp:25
@@ +24,3 @@
+ SmallVector Classes;
+ Option.split(Classes, ",");
+ return std::vector(Classes.begin(), Classes.end());
aaron.ballman wrote:
> alexfh wrote:
> > aaron.b
hubert.reinterpretcast added inline comments.
Comment at: lib/AST/ASTContext.cpp:4635
@@ +4634,3 @@
+ // If the two sides have Float128Rank and LongDoubleRank and the two types
+ // have the same representation on this platform, they have equal rank.
+ if ((LHSR == LongDoubleRa
aaron.ballman added inline comments.
Comment at: clang-tidy/ClangTidyOptions.h:216
@@ +215,3 @@
+/// HeaderFileExtensions.
+bool endWithHeaderFileExtensions(llvm::StringRef FileName,
+ llvm::StringRef HeaderFileExtensions);
alexfh w
aaron.ballman added inline comments.
Comment at: clang-tidy/performance/FasterStringFindCheck.cpp:25
@@ +24,3 @@
+ SmallVector Classes;
+ Option.split(Classes, ",");
+ return std::vector(Classes.begin(), Classes.end());
alexfh wrote:
> aaron.ballman wrote:
> >
alexfh added a comment.
Thanks for addressing the comments. However, the main concern is this:
In http://reviews.llvm.org/D16183#326759, @alexfh wrote:
> I'm not sure `tooling::Replacement` is the best place to store check name.
> Maybe create a separate wrapper class and serialize it instead
alexfh added inline comments.
Comment at: clang-tidy/performance/FasterStringFindCheck.cpp:25
@@ +24,3 @@
+ SmallVector Classes;
+ Option.split(Classes, ",");
+ return std::vector(Classes.begin(), Classes.end());
aaron.ballman wrote:
> It might be nice for this
alexfh added inline comments.
Comment at: clang-tidy/ClangTidyOptions.h:216
@@ +215,3 @@
+/// HeaderFileExtensions.
+bool endWithHeaderFileExtensions(llvm::StringRef FileName,
+ llvm::StringRef HeaderFileExtensions);
aaron.ballman w
pxli168 added a comment.
I think we'd better to ask about to add this in. The pipe type support actually
have no use without builtins to read or write it.
Comment at: lib/CodeGen/CGBuiltin.cpp:1981
@@ +1980,3 @@
+ const char *Name =
+ (BuiltinID == Builtin::BIread
aaron.ballman added inline comments.
Comment at: clang-tidy/ClangTidyOptions.h:216
@@ +215,3 @@
+/// HeaderFileExtensions.
+bool endWithHeaderFileExtensions(llvm::StringRef FileName,
+ llvm::StringRef HeaderFileExtensions);
alexfh w
aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman added a reviewer: aaron.ballman.
Comment at: clang-tidy/performance/FasterStringFindCheck.cpp:25
@@ +24,3 @@
+ SmallVector Classes;
+ Option.split(Classes, ",");
+ return std::vector(Classes.begin(), Classes.end());
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you!
http://reviews.llvm.org/D16112
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
Author: kparzysz
Date: Thu Jan 14 08:26:36 2016
New Revision: 257765
URL: http://llvm.org/viewvc/llvm-project?rev=257765&view=rev
Log:
[Hexagon] Change all builtins returning "bool" to return "int" instead
Modified:
cfe/trunk/include/clang/Basic/BuiltinsHexagon.def
Modified: cfe/trunk/includ
aaron.ballman added a comment.
At a high level, is there a reason why these should be supported on block, but
not on ObjC method declarations? It smells like these may be useful there as
well, which could also simplify the patch slightly.
Comment at: include/clang/Basic/Attr.t
Elijah_Th updated this revision to Diff 44876.
Elijah_Th added a comment.
- small format changes
- removed unnecessary StringRef
http://reviews.llvm.org/D16183
Files:
tools/clang/include/clang/Tooling/Core/Replacement.h
tools/clang/include/clang/Tooling/ReplacementsYaml.h
tools/clang/lib/
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you!
http://reviews.llvm.org/D15709
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
Author: djasper
Date: Thu Jan 14 07:36:46 2016
New Revision: 257763
URL: http://llvm.org/viewvc/llvm-project?rev=257763&view=rev
Log:
clang-format: Fix incorrectly enforced linebreak with ColumnLimit 0.
Before:
[]
.();
After:
[].();
Modified:
cfe/trunk/lib/
On Thu, Jan 14, 2016 at 02:05:21AM +, Weiming Zhao via cfe-commits wrote:
> r255371 errors on redeclaring with a conflicting asm label.
> This patch changes errors to warnings to prevent breaking existing codes.
I'm not sure I agree with this. We have triggered this in NetBSD in two
different
aaron.ballman added a comment.
In http://reviews.llvm.org/D15373#315457, @a.makarov wrote:
> I've updated the patch. Please, re-review it again.
> About creating attributed type - I think we shouldn't create it if we
> ignored specified CC attribute. Ignoring specified CC attribute (and emittin
Elijah_Th created this revision.
Elijah_Th added reviewers: klimek, alexfh, djasper, cfe-commits.
Herald added a subscriber: klimek.
See details in https://llvm.org/bugs/show_bug.cgi?id=26132
http://reviews.llvm.org/D16183
Files:
tools/clang/include/clang/Tooling/Core/Replacement.h
tools/cla
a.makarov added a comment.
Ping
http://reviews.llvm.org/D15373
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
For your consideration:
Attached is a patch that adds Python 3 compatibility (without losing Python
2 compatibility) to Clang’s Python bindings.
The patch also includes PEP8 formatting cleanups, and a setup.py file to
make it easier to install the bindings into a working Python development
enviro
alexfh added inline comments.
Comment at: clang-tidy/tool/ClangTidyMain.cpp:78
@@ +77,3 @@
+static cl::opt
+HeaderFileExtensions("header-file-extensions",
+ cl::desc("File extensions that regard as header file.\n"
hokein wrote:
> alexfh wrote:
alexfh added a comment.
I'm not sure `tooling::Replacement` is the best place to store check name.
Maybe create a separate wrapper class and serialize it instead
(clang-apply-replacements will have to be changed to support this format as
well). This could be `ClangTidyDiagnostic` or just `Diagn
Author: s.egerton
Date: Thu Jan 14 07:01:48 2016
New Revision: 257762
URL: http://llvm.org/viewvc/llvm-project?rev=257762&view=rev
Log:
[mips] Added support for -Wa,-mips32 and similar.
Reviewers: vkalintiris, dsanders
Subscribers: cfe-commits
Differential Revision: http://reviews.llvm.org/D150
alexfh added a comment.
> ... What about a configuration option to also report near misses when only a
> qualifier is missing?
Might be a useful thing. We should first check if it makes sense to always
ignore a qualifier.
Comment at: clang-tidy/misc/VirtualNearMissCheck.cpp:
pgousseau accepted this revision.
pgousseau added a comment.
This revision is now accepted and ready to land.
LGTM!
Thanks Artom for finding the bug and new test case, sorry for missing those in
my patch!
Removing "!IsNotTruncated" is definitely worth trying.
Please commit if code owners are happ
d.zobnin.bugzilla updated this revision to Diff 44859.
d.zobnin.bugzilla added a comment.
Thanks for the review! Updated the patch: added Subjects line for the attribute
and removed the "err_attr_wrong_decl" diagnostics.
http://reviews.llvm.org/D16112
Files:
include/clang/AST/Decl.h
includ
alexfh added a comment.
Awesome! See a few comments inline.
Comment at: clang-tidy/performance/FasterStringFindCheck.cpp:51
@@ +50,3 @@
+ const auto StringFindFunctions =
+ anyOf(hasName("find"), hasName("rfind"), hasName("find_first_of"),
+hasName("find_first_
Renato,
Thanks! -- I committed a fix already:
http://llvm.org/viewvc/llvm-project?view=revision&revision=257757
Yours,
Andrey
On Thu, Jan 14, 2016 at 2:57 PM, Renato Golin wrote:
> On 14 January 2016 at 10:41, Andrey Bokhanko via cfe-commits
> wrote:
>> Author: asbokhan
>> Date: Thu Jan 14 04
1 - 100 of 115 matches
Mail list logo
