Hahnfeld added a comment.
Will this somewhen receive a final review and get merged?
http://reviews.llvm.org/D9888
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF created this revision.
EricWF added reviewers: mclow.lists, rsmith.
EricWF added a subscriber: cfe-commits.
According to the C++ standard isn't allowed to define `true`
`false` or `bool`. However these macros are sometimes defined by the compilers
`stdbool.h`.
Clang defines the macros w
craig.topper added inline comments.
Comment at: lib/Headers/f16cintrin.h:47
@@ +46,3 @@
+})
+
+
Would it be possible to do this without temporaries? Temporaries in macros can
cause -Wshadow warnings if the macro is used multiple times.
Repository:
rL LLVM
ht
hokein marked 3 inline comments as done.
Comment at: clang-tidy/google/GlobalNamesInHeadersCheck.h:26
@@ +25,3 @@
+/// - `HeaderFileExtensions`: a comma-separated list of filename extensions
of
+/// header files (no need to includ "."). "h" by default.
+/// For extensio
hokein updated this revision to Diff 45349.
hokein added a comment.
Update comments.
http://reviews.llvm.org/D16113
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidy.h
clang-tidy/google/GlobalNamesInHeadersCheck.cpp
clang-tidy/google/GlobalNamesInHeadersCheck.h
clang-tidy/google/Un
Author: ericwf
Date: Tue Jan 19 23:44:11 2016
New Revision: 258292
URL: http://llvm.org/viewvc/llvm-project?rev=258292&view=rev
Log:
Use TEST_STD_VER instead of __has_feature to detect noexcept. This fixes the
test with GCC.
Modified:
libcxx/trunk/test/libcxx/strings/iterators.exceptions.pas
Author: marshall
Date: Tue Jan 19 23:41:24 2016
New Revision: 258291
URL: http://llvm.org/viewvc/llvm-project?rev=258291&view=rev
Log:
More string fixes for noexcept cases. Apparently I didn't get them all in
r258281.
Modified:
libcxx/trunk/test/libcxx/strings/iterators.exceptions.pass.cpp
EricWF created this revision.
EricWF added a reviewer: mclow.lists.
EricWF added a subscriber: cfe-commits.
This bug was originally fixed in http://reviews.llvm.org/D7201.
However it was broken again by the fix to
https://llvm.org/bugs/show_bug.cgi?id=22605.
This patch re-fixes __wrap_iter wit
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258290: Fix infinite loop when ::new or ::delete are found
in member initializer list… (authored by ABataev).
Changed prior to commit:
http://reviews.llvm.org/D16216?vs=45295&id=45347#toc
Repository:
Author: abataev
Date: Tue Jan 19 23:25:51 2016
New Revision: 258290
URL: http://llvm.org/viewvc/llvm-project?rev=258290&view=rev
Log:
Fix infinite loop when ::new or ::delete are found in member initializer list,
by Denis Zobnin
Fix for an infinite loop on parsing ::new or ::delete in member init
Author: ericwf
Date: Tue Jan 19 22:59:57 2016
New Revision: 258287
URL: http://llvm.org/viewvc/llvm-project?rev=258287&view=rev
Log:
Mark some test XFAIL for GCC 4.9 due to missing is_trivial* traits
Modified:
libcxx/trunk/test/std/iterators/stream.iterators/istream.iterator/types.pass.cpp
adek05 updated this revision to Diff 45344.
adek05 added a comment.
@aaron.ballman comments. If it looks good, please commit it for me :)
http://reviews.llvm.org/D16278
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry.cpp
d.zobnin.bugzilla added a subscriber: ABataev.
d.zobnin.bugzilla added a comment.
I am going to ask @ABataev to commit this. Hope to get commit access soon (this
is my 5th patch) :)
http://reviews.llvm.org/D16216
___
cfe-commits mailing list
cfe-co
Author: ericwf
Date: Tue Jan 19 22:06:46 2016
New Revision: 258284
URL: http://llvm.org/viewvc/llvm-project?rev=258284&view=rev
Log:
Mark some tests as XFAIL with GCC due to compiler bugs
Modified:
libcxxabi/trunk/test/catch_array_01.pass.cpp
libcxxabi/trunk/test/catch_function_01.pass.cp
Author: marshall
Date: Tue Jan 19 21:37:46 2016
New Revision: 258281
URL: http://llvm.org/viewvc/llvm-project?rev=258281&view=rev
Log:
Got the test backwards in r258279. Fixed that and de-tabbed
Modified:
libcxx/trunk/test/support/test_iterators.h
Modified: libcxx/trunk/test/support/test_ite
silvas added a subscriber: silvas.
silvas added a comment.
This may sound stupid, but: can you benchmark the time it takes to build some
project (that actually uses intrinsics in most translation units, e.g. a game)
with the headers w/ and w/o the doxygen comments to check that all the extra
co
Author: marshall
Date: Tue Jan 19 21:19:15 2016
New Revision: 258279
URL: http://llvm.org/viewvc/llvm-project?rev=258279&view=rev
Log:
Fix up the tests I added for string exceptions to be skipped when exceptions
are disabled
Modified:
libcxx/trunk/test/std/strings/basic.string/string.modifi
Glad to see that emutls is useful for Cygwin too.
The diff in rL257984 do not look like depending on rL257718.
It might work with my earlier implementation of emutls, before rL257718.
Anyway, I did not test on Cygwin, and don't care if rL257984 is in 3.8 or
not.
Thanks.
On Tue, Jan 19, 2016 at 4:
Hi Hans,
Sorry to make this more complicated, but can you also include the follow-up
libc++abi commit r258277.
/Eric
On Tue, Jan 19, 2016 at 7:08 PM, Marshall Clow
wrote:
>
>
> On Tue, Jan 19, 2016 at 3:48 PM, Eric Fiselier wrote:
>
>> Hi Hans,
>>
>> I fixed the problem that caused Nico to re
Author: ericwf
Date: Tue Jan 19 21:04:50 2016
New Revision: 258277
URL: http://llvm.org/viewvc/llvm-project?rev=258277&view=rev
Log:
Fix link flags order in RUN command.
Modified:
libcxxabi/trunk/test/incomplete_type.sh.cpp
Modified: libcxxabi/trunk/test/incomplete_type.sh.cpp
URL:
http://l
Hi Richard,
>> + // The advance from '>>' to '>' in a ObjectiveC template argument list
>> needs
>> + // to be properly reflected in the token cache to allow correct
>> interaction
>> + // between annotation and backtracking.
>> + if (ObjCGenericList && PrevTok.getKind() == tok::greatergreater
arpith-jacob created this revision.
arpith-jacob added reviewers: kkwli0, hfinkel, ABataev, sfantao, carlo.bertolli.
arpith-jacob added subscribers: fraggamuffin, caomhin, cfe-commits.
OpenMP [2.10.1, Restrictions, p. 97]
At least one map clause must appear on the directive.
http://reviews.llvm.o
alexfh added a comment.
In http://reviews.llvm.org/D16183#329475, @Elijah_Th wrote:
> What kind of wrapper should it be?
> I was thinking of this kind:
>
> class ExtendedReplacement : public Replacement {
No, I meant a different thing: serialize ClangTidyError or make a specialized
structur
On Wed, Jan 13, 2016 at 9:42 AM, Hans Wennborg wrote:
> Marshall, Eric,
>
> Please check that this was OK, as I don't usually commit to libc++.
>
> It's good.
-- Marshall
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
On Tue, Jan 19, 2016 at 3:48 PM, Eric Fiselier wrote:
> Hi Hans,
>
> I fixed the problem that caused Nico to revert this. I would like to
> re-land this in 3.8.
> This depends on libc++ commit r258217 also landing in 3.8.
>
> @Marshall can you OK this?
>
>
This is fine with me. (both r258217 and
On Tue, Jan 19, 2016 at 3:34 PM, Eric Fiselier wrote:
> Hi Hans,
>
> I would like to merge the following commits into 3.8.
>
> 1. r258196 (libc++)
> 2. r258198 (libc++)
> 3. r258201 (libc++abi)
>
> These commits simply add missing license headers.
>
> @Marshall Can you please OK this?
>
>
I am fi
> On Jan 19, 2016, at 4:23 PM, David Blaikie wrote:
>
>
>
> On Tue, Jan 19, 2016 at 4:04 PM, Adrian Prantl wrote:
>
>> On Jan 19, 2016, at 3:52 PM, David Blaikie wrote:
>>
>>
>>
>> On Tue, Jan 19, 2016 at 3:42 PM, Adrian Prantl via cfe-commits
>> wrote:
>> Author: adrian
>> Date: Tue J
Author: adrian
Date: Tue Jan 19 19:29:34 2016
New Revision: 258272
URL: http://llvm.org/viewvc/llvm-project?rev=258272&view=rev
Log:
Module Debugging: Fine-tune the condition that determines whether a type
can be found in a module.
There are externally visible anonymous types that can be found:
Author: ericwf
Date: Tue Jan 19 19:26:30 2016
New Revision: 258270
URL: http://llvm.org/viewvc/llvm-project?rev=258270&view=rev
Log:
Add link to 3rd party GDB pretty-printers
Modified:
libcxx/trunk/docs/UsingLibcxx.rst
Modified: libcxx/trunk/docs/UsingLibcxx.rst
URL:
http://llvm.org/viewvc/
jlebar added a comment.
Fixed and submitted.
Repository:
rL LLVM
http://reviews.llvm.org/D16331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
jlebar marked 3 inline comments as done.
Closed by commit rL258263: [CUDA] Only allow __global__ on free functions and
static member functions. (authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D16261
This revision was automatically updated to reflect the committed changes.
jlebar marked 2 inline comments as done.
Closed by commit rL258264: [CUDA] Bail, rather than crash, on va_arg in device
code. (authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D16331?vs=45305&id=45325
Author: jlebar
Date: Tue Jan 19 18:27:00 2016
New Revision: 258264
URL: http://llvm.org/viewvc/llvm-project?rev=258264&view=rev
Log:
[CUDA] Bail, rather than crash, on va_arg in device code.
Reviewers: tra
Subscribers: echristo, jhen, cfe-commits
Differential Revision: http://reviews.llvm.org/D
Author: jlebar
Date: Tue Jan 19 18:26:57 2016
New Revision: 258263
URL: http://llvm.org/viewvc/llvm-project?rev=258263&view=rev
Log:
[CUDA] Only allow __global__ on free functions and static member functions.
Summary:
Warn for NVCC compatibility if you declare a static member function or
inline f
Author: davidxl
Date: Tue Jan 19 18:24:52 2016
New Revision: 258261
URL: http://llvm.org/viewvc/llvm-project?rev=258261&view=rev
Log:
Reference the updated function name /NFC
Modified:
cfe/trunk/lib/CodeGen/CoverageMappingGen.cpp
Modified: cfe/trunk/lib/CodeGen/CoverageMappingGen.cpp
URL:
h
On Tue, Jan 19, 2016 at 4:04 PM, Adrian Prantl wrote:
>
> On Jan 19, 2016, at 3:52 PM, David Blaikie wrote:
>
>
>
> On Tue, Jan 19, 2016 at 3:42 PM, Adrian Prantl via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: adrian
>> Date: Tue Jan 19 17:42:53 2016
>> New Revision: 258251
Hey Duncan,
I know this isn't required, but would it be possible to put this on
phabricator?
/Eric
On Mon, Jan 18, 2016 at 4:34 PM, Duncan P. N. Exon Smith <
dexonsm...@apple.com> wrote:
> ping
>
> > On 2016-Jan-11, at 16:23, Duncan P. N. Exon Smith
> wrote:
> >
> > ping
> >
> >> On 2016-Jan-0
> On Jan 19, 2016, at 3:52 PM, David Blaikie wrote:
>
>
>
> On Tue, Jan 19, 2016 at 3:42 PM, Adrian Prantl via cfe-commits
> mailto:cfe-commits@lists.llvm.org>> wrote:
> Author: adrian
> Date: Tue Jan 19 17:42:53 2016
> New Revision: 258251
>
> URL: http://llvm.org/viewvc/llvm-project?rev=25
Ah yes, I was confused. No need to pick up r257984. Sorry for the noise.
On Wed, Jan 20, 2016 at 8:54 AM Hans Wennborg wrote:
> On Tue, Jan 19, 2016 at 3:43 PM, NAKAMURA Takumi
> wrote:
> > May I push it (llvm and clang) into release_38?
> > It depends on r257718.
>
> r257718 was committed afte
tra added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:3620-3629
@@ -3619,2 +3619,12 @@
}
+ if (const auto *Method = dyn_cast(FD)) {
+if (Method->isInstance()) {
+ S.Diag(Method->getLocStart(), diag::err_kern_is_nonstatic_method)
+ << Method;
+
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
Small nit. LGTM otherwise.
Comment at: lib/Sema/SemaExpr.cpp:11732
@@ +11731,3 @@
+ // CUDA device code does not support varargs.
+ if (getLangOpts().CUDAIsDevice) {
+if (cons
On Tue, Jan 19, 2016 at 3:43 PM, NAKAMURA Takumi wrote:
> May I push it (llvm and clang) into release_38?
> It depends on r257718.
r257718 was committed after the branch. Are you suggesting we merge that too?
This looks like a pretty significant change. Can't it wait until 3.9?
> 2016-01-16 12
On Tue, Jan 19, 2016 at 3:42 PM, Adrian Prantl via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: adrian
> Date: Tue Jan 19 17:42:53 2016
> New Revision: 258251
>
> URL: http://llvm.org/viewvc/llvm-project?rev=258251&view=rev
> Log:
> Module Debugging: Don't emit external type referenc
Hi Hans,
I fixed the problem that caused Nico to revert this. I would like to
re-land this in 3.8.
This depends on libc++ commit r258217 also landing in 3.8.
@Marshall can you OK this?
/Eric
On Tue, Jan 19, 2016 at 4:42 PM, Eric Fiselier via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> A
Author: adrian
Date: Tue Jan 19 17:42:44 2016
New Revision: 258250
URL: http://llvm.org/viewvc/llvm-project?rev=258250&view=rev
Log:
Module Debugging: Make sure that anonymous tag decls that define global
variables are visited.
This shouldn't encourage anyone to put global variables into clang mo
Author: adrian
Date: Tue Jan 19 17:42:56 2016
New Revision: 258252
URL: http://llvm.org/viewvc/llvm-project?rev=258252&view=rev
Log:
Module Debugging: Add Objective-C testcases for anonymous tag decls. (NFC)
rdar://problem/24199640
Modified:
cfe/trunk/test/Modules/ExtDebugInfo.m
cfe/trun
Author: adrian
Date: Tue Jan 19 17:42:53 2016
New Revision: 258251
URL: http://llvm.org/viewvc/llvm-project?rev=258251&view=rev
Log:
Module Debugging: Don't emit external type references to anonymous types.
Even if they exist in the module, they can't be matched with the forward
declaration in the
Author: hans
Date: Tue Jan 19 17:41:31 2016
New Revision: 258247
URL: http://llvm.org/viewvc/llvm-project?rev=258247&view=rev
Log:
Creating release directory for release_380.
Added:
libunwind/tags/RELEASE_380/
___
cfe-commits mailing list
cfe-commi
Author: ericwf
Date: Tue Jan 19 17:42:10 2016
New Revision: 258249
URL: http://llvm.org/viewvc/llvm-project?rev=258249&view=rev
Log:
Recommit r256322: Fix PR25898 - Check for incomplete pointers types in
can_catch(...)
This patch re-commits r256322 and r256323. They were reverted due to a OS X
t
Author: hans
Date: Tue Jan 19 17:41:06 2016
New Revision: 258236
URL: http://llvm.org/viewvc/llvm-project?rev=258236&view=rev
Log:
Creating release candidate rc1 from release_380 branch
Added:
libcxxabi/tags/RELEASE_380/rc1/ (props changed)
- copied from r258235, libcxxabi/branches/re
Author: hans
Date: Tue Jan 19 17:41:33 2016
New Revision: 258248
URL: http://llvm.org/viewvc/llvm-project?rev=258248&view=rev
Log:
Creating release candidate rc1 from release_380 branch
Added:
libunwind/tags/RELEASE_380/rc1/
- copied from r258247, libunwind/branches/release_38/
___
jlebar added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:3620-3629
@@ -3619,2 +3619,12 @@
}
+ if (const auto *Method = dyn_cast(FD)) {
+if (Method->isInstance()) {
+ S.Diag(Method->getLocStart(), diag::err_kern_is_nonstatic_method)
+ << Method;
+
Author: hans
Date: Tue Jan 19 17:41:04 2016
New Revision: 258235
URL: http://llvm.org/viewvc/llvm-project?rev=258235&view=rev
Log:
Creating release directory for release_380.
Added:
libcxxabi/tags/RELEASE_380/
___
cfe-commits mailing list
cfe-commi
Author: ericwf
Date: Tue Jan 19 17:40:49 2016
New Revision: 258228
URL: http://llvm.org/viewvc/llvm-project?rev=258228&view=rev
Log:
Revert r258222 because it's missing files. Will re-commit complete patch
Modified:
libcxxabi/trunk/src/private_typeinfo.cpp
Modified: libcxxabi/trunk/src/priva
Author: hans
Date: Tue Jan 19 17:40:59 2016
New Revision: 258233
URL: http://llvm.org/viewvc/llvm-project?rev=258233&view=rev
Log:
Creating release directory for release_380.
Added:
libcxx/tags/RELEASE_380/
___
cfe-commits mailing list
cfe-commits@
Author: hans
Date: Tue Jan 19 17:41:02 2016
New Revision: 258234
URL: http://llvm.org/viewvc/llvm-project?rev=258234&view=rev
Log:
Creating release candidate rc1 from release_380 branch
Added:
libcxx/tags/RELEASE_380/rc1/ (props changed)
- copied from r258233, libcxx/branches/release_
May I push it (llvm and clang) into release_38?
It depends on r257718.
2016-01-16 12:48 GMT+09:00 NAKAMURA Takumi :
> chapuni committed rL257984: [Cygwin] Use -femulated-tls by default since
> r257718 introduced the new pass..
>
> [Cygwin] Use -femulated-tls by default since r257718 introduced th
Thanks!
On Jan 19, 2016 3:34 PM, "Nico Weber" wrote:
> I think I've fixed all warnings by now, and I've reenabled the warning for
> LLVM builds (in r258210; that commit's commit message links to the
> individual fixes.)
>
> On Tue, Jan 19, 2016 at 3:56 PM, Nico Weber wrote:
>
>> r258181 should s
Author: ericwf
Date: Tue Jan 19 17:37:51 2016
New Revision: 258222
URL: http://llvm.org/viewvc/llvm-project?rev=258222&view=rev
Log:
Recommit r256322: Fix PR25898 - Check for incomplete pointers types in
can_catch(...)
This patch re-commits r256322 and r256323. They were reverted due to a OS X
t
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
Small diags not. LGTM otherwise.
Comment at: lib/Sema/SemaDeclAttr.cpp:3620-3629
@@ -3619,2 +3619,12 @@
}
+ if (const auto *Method = dyn_cast(FD)) {
+if (Method->isInstance(
I think I've fixed all warnings by now, and I've reenabled the warning for
LLVM builds (in r258210; that commit's commit message links to the
individual fixes.)
On Tue, Jan 19, 2016 at 3:56 PM, Nico Weber wrote:
> r258181 should stop the bleeding. I'll look at fixing the warnings now.
>
> On Tue
Hi Hans,
I would like to merge the following commits into 3.8.
1. r258196 (libc++)
2. r258198 (libc++)
3. r258201 (libc++abi)
These commits simply add missing license headers.
@Marshall Can you please OK this?
/Eric
___
cfe-commits mailing list
cfe-c
Author: chapuni
Date: Tue Jan 19 17:21:13 2016
New Revision: 258219
URL: http://llvm.org/viewvc/llvm-project?rev=258219&view=rev
Log:
StmtOpenMP.h: Fix a warning in r258165. [-Wdocumentation]
Modified:
cfe/trunk/include/clang/AST/StmtOpenMP.h
Modified: cfe/trunk/include/clang/AST/StmtOpenMP.
Author: chapuni
Date: Tue Jan 19 17:21:18 2016
New Revision: 258220
URL: http://llvm.org/viewvc/llvm-project?rev=258220&view=rev
Log:
StmtOpenMP.h: Fix a warning in r258177. [-Wdocumentation]
Modified:
cfe/trunk/include/clang/AST/StmtOpenMP.h
Modified: cfe/trunk/include/clang/AST/StmtOpenMP.
tra marked 3 inline comments as done.
Comment at: lib/Sema/SemaCUDA.cpp:436
@@ +435,3 @@
+ if (CD->isTrivial())
+return true;
+
jlebar wrote:
> The test passes if I comment out this if statement. I'm not sure if that's
> expected; this may or may not be ent
tra updated this revision to Diff 45312.
tra marked 2 inline comments as done.
tra added a comment.
Addressed Justin's comments.
http://reviews.llvm.org/D15305
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/CodeGen/CGDeclCXX.cpp
lib/CodeGen/CodeGenModule
Hi Hans,
Please merge this commit into 3.8. I need it in order to un-revert the
libc++abi commit r256323.
Marshall can you OK this?
/Eric
On Tue, Jan 19, 2016 at 4:06 PM, Eric Fiselier via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ericwf
> Date: Tue Jan 19 17:06:29 2016
> New
probinson added a comment.
I don't feel comfortable enough with Clang to review the code part.
The tests are generally good (one inline comment) but it seems like they could
be done all in one test file, which is more efficient in terms of test run time.
Comment at: test/CodeGe
Author: ericwf
Date: Tue Jan 19 17:06:29 2016
New Revision: 258217
URL: http://llvm.org/viewvc/llvm-project?rev=258217&view=rev
Log:
Fix enviroment variables when running shell scripts
Modified:
libcxx/trunk/test/libcxx/test/config.py
Modified: libcxx/trunk/test/libcxx/test/config.py
URL:
h
Author: cbieneman
Date: Tue Jan 19 17:01:38 2016
New Revision: 258214
URL: http://llvm.org/viewvc/llvm-project?rev=258214&view=rev
Log:
[CMake] Don't apply Export set to clang tools
I can't apply export to tools without getting some strange CMake spew. The
behavior here is a bit unexpected. CMak
aaron.ballman closed this revision.
aaron.ballman added a comment.
Thanks! I've commit in r258213.
http://reviews.llvm.org/D16301
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: aaronballman
Date: Tue Jan 19 16:54:26 2016
New Revision: 258213
URL: http://llvm.org/viewvc/llvm-project?rev=258213&view=rev
Log:
Allow __attribute__((mode)) to appertain to field declarations again. Corrects
compile issues with LibreOffice.
Patch by Stephan Bergmann
Modified:
cfe/
sberg updated this revision to Diff 45310.
sberg added a comment.
oops, had erroneously based it on some other local patch; rebased now
http://reviews.llvm.org/D16301
Files:
include/clang/Basic/Attr.td
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/AttributeList.h
lib/Sem
Author: cbieneman
Date: Tue Jan 19 16:41:51 2016
New Revision: 258209
URL: http://llvm.org/viewvc/llvm-project?rev=258209&view=rev
Log:
[CMake] Creating add_clang_tool macro to wrap add_clang_executable and generate
install actions and targets.
This change brings forward the LLVM convention that
probinson added a comment.
Looks like this was never committed?
http://reviews.llvm.org/D9929
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar updated this revision to Diff 45305.
jlebar added a comment.
Rename test file.
http://reviews.llvm.org/D16331
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaExpr.cpp
test/SemaCUDA/va-arg.cu
Index: test/SemaCUDA/va-arg.cu
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added subscribers: cfe-commits, jhen, echristo.
http://reviews.llvm.org/D16331
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaExpr.cpp
test/SemaCUDA/vararg.cu
Index: test/SemaCUDA/vararg.cu
=
cmatthews added a subscriber: cmatthews.
cmatthews added a comment.
LGTM too.
http://reviews.llvm.org/D16115
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
LGTM too.
> On Jan 19, 2016, at 1:30 PM, Devin Coughlin wrote:
>
> dcoughlin added a comment.
>
> Ping.
>
> Any objections to adding a new 'ClangAnalyzer' directory to test-suite?
>
>
> http://reviews.llvm.org/D16115
>
>
>
___
cfe-commits maili
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM, thanks! Do you need someone to commit for you?
http://reviews.llvm.org/D16216
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
Author: ericwf
Date: Tue Jan 19 16:07:10 2016
New Revision: 258201
URL: http://llvm.org/viewvc/llvm-project?rev=258201&view=rev
Log:
Add missing license headers
Modified:
libcxxabi/trunk/test/libcxxabi/test/config.py
libcxxabi/trunk/test/support/timer.hpp
Modified: libcxxabi/trunk/test/l
Author: ericwf
Date: Tue Jan 19 15:58:49 2016
New Revision: 258198
URL: http://llvm.org/viewvc/llvm-project?rev=258198&view=rev
Log:
Add more missing license headers
Modified:
libcxx/trunk/src/include/atomic_support.h
libcxx/trunk/utils/gen_link_script/gen_link_script.py
libcxx/trunk/
aaron.ballman added a comment.
Can you please rebase this off ToT and upload the latest diff? This is not
applying cleanly for me.
http://reviews.llvm.org/D16301
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
Author: ericwf
Date: Tue Jan 19 15:52:04 2016
New Revision: 258196
URL: http://llvm.org/viewvc/llvm-project?rev=258196&view=rev
Log:
Add missing license headers
Modified:
libcxx/trunk/test/libcxx/compiler.py
libcxx/trunk/test/libcxx/test/config.py
libcxx/trunk/test/libcxx/test/executo
sberg added a comment.
Please somebody push this for me; I don't have commit access. Thanks
http://reviews.llvm.org/D16301
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Tue Jan 19 15:51:07 2016
New Revision: 258195
URL: http://llvm.org/viewvc/llvm-project?rev=258195&view=rev
Log:
Mark slow ASAN/MSAN tests as XFAIL for now.
Modified:
libcxx/trunk/test/std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members
ahatanak added a subscriber: ahatanak.
ahatanak added a comment.
This looks LGTM.
http://reviews.llvm.org/D12664
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dcoughlin added a comment.
Ping.
Any objections to adding a new 'ClangAnalyzer' directory to test-suite?
http://reviews.llvm.org/D16115
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
jlebar added a comment.
Checked Thrust as we discussed. It doesn't seem to be getting hung up here.
http://reviews.llvm.org/D16261
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Equally as good. Thanks.
On Tue, Jan 19, 2016 at 2:09 PM, Hans Wennborg wrote:
> Actually, I'll go ahead and merge Nico's revert to 3.8 for now to
> unbreak the build there, and then I'll be happy to merge fixes when
> you've looked into it. Sorry for the double messaging.
>
> On Tue, Jan 19, 20
d.zobnin.bugzilla updated this revision to Diff 45295.
d.zobnin.bugzilla added a comment.
Thank you for the review! Updated the patch: parser now skips the rest of the
initializers if the previous one was invalid, added several checks to the test.
http://reviews.llvm.org/D16216
Files:
lib/Pa
jlebar added a comment.
Thank you for the review.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6418
@@ +6417,3 @@
+def warn_nvcc_compat_kern_is_method : Warning<
+ "kernel function %0 is a member function; this may not be accepted by nvcc">,
+ InGroup;
--
jlebar updated this revision to Diff 45297.
jlebar marked an inline comment as done.
jlebar added a comment.
Address tra's review.
http://reviews.llvm.org/D16261
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaCUDA.cpp
lib/Sema/SemaDeclAttr.cpp
test/SemaCUDA/bad-attribute
Merged to 3.8 in r258186. (See discussion on the r256323 commit).
On Fri, Jan 15, 2016 at 7:44 AM, Nico Weber via cfe-commits
wrote:
> Author: nico
> Date: Fri Jan 15 09:44:14 2016
> New Revision: 257896
>
> URL: http://llvm.org/viewvc/llvm-project?rev=257896&view=rev
> Log:
> Revert r256322 (and
Author: hans
Date: Tue Jan 19 15:06:49 2016
New Revision: 258186
URL: http://llvm.org/viewvc/llvm-project?rev=258186&view=rev
Log:
Merging r257896:
r257896 | nico | 2016-01-15 07:44:14 -0800 (Fri, 15 Jan 2016) | 1 line
Rever
Actually, I'll go ahead and merge Nico's revert to 3.8 for now to
unbreak the build there, and then I'll be happy to merge fixes when
you've looked into it. Sorry for the double messaging.
On Tue, Jan 19, 2016 at 9:43 AM, Hans Wennborg wrote:
> That sounds great. Thanks!
>
> On Tue, Jan 19, 2016
r258181 should stop the bleeding. I'll look at fixing the warnings now.
On Tue, Jan 19, 2016 at 3:46 PM, Nico Weber wrote:
> Back at my desk now, looking.
>
> On Tue, Jan 19, 2016 at 3:44 PM, Diego Novillo
> wrote:
>
>>
>>
>> On Tue, Jan 19, 2016 at 3:43 PM, Nico Weber wrote:
>>
>>> I mean you
Back at my desk now, looking.
On Tue, Jan 19, 2016 at 3:44 PM, Diego Novillo wrote:
>
>
> On Tue, Jan 19, 2016 at 3:43 PM, Nico Weber wrote:
>
>> I mean you could pass a -Wno flag. It's undefined behavior that's
>> actually causing bugs in practice; it should probably be on by default.
>>
>
> B
sfantao closed this revision.
sfantao added a comment.
Committed revision 258179.
Thanks,
Samuel
http://reviews.llvm.org/D16280
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: sfantao
Date: Tue Jan 19 14:40:49 2016
New Revision: 258179
URL: http://llvm.org/viewvc/llvm-project?rev=258179&view=rev
Log:
[OpenMP] Detect implicit map type to report unspecified map type for target
enter/exit data directives.
Support for the following OpenMP 4.5 restriction on 'targe
1 - 100 of 199 matches
Mail list logo
