korli created this revision.
korli added a reviewer: rsmith.
korli added a subscriber: cfe-commits.
korli set the repository for this revision to rL LLVM.
Herald added a subscriber: aemerson.
[ Copied from [[ https://llvm.org/bugs/show_bug.cgi?id=26404 |
https://llvm.org/bugs/show_bug.cgi?id=2640
rjmccall added inline comments.
Comment at: include/clang/Basic/TargetCXXABI.h:118
@@ -115,1 +117,3 @@
+/// in LLVM 3.2.
+PS4
};
I'm not sure why you added a new C++ ABI kind here. The bug fix you're opting
out of is not at all specific to C++, and th
Author: abataev
Date: Mon Feb 1 22:59:52 2016
New Revision: 259465
URL: http://llvm.org/viewvc/llvm-project?rev=259465&view=rev
Log:
[OPENMP 4.0] Allow to use 'omp simd' directive inside other simd-regions.
Modified:
cfe/trunk/lib/Sema/SemaOpenMP.cpp
cfe/trunk/test/OpenMP/nesting_of_regi
majnemer added a subscriber: majnemer.
Comment at: lib/Parse/ParseStmt.cpp:1719-1724
@@ -1718,6 +1718,8 @@
if (ForRange) {
+ExprResult CorrectedRange =
+Actions.CorrectDelayedTyposInExpr(ForRangeInit.RangeExpr.get());
ForRangeStmt = Actions.ActOnCXXForRangeStmt
majnemer added a subscriber: majnemer.
majnemer added a comment.
I believe this change is correct but I believe we can handle this a little more
efficiently.
I wonder if it would be better if we instead inserted a special EOF token at
the end of `Toks`. If any errors occur, consume tokens unti
Author: arpith
Date: Mon Feb 1 22:00:47 2016
New Revision: 259464
URL: http://llvm.org/viewvc/llvm-project?rev=259464&view=rev
Log:
[OpenMP] Prevent nesting of target constructs within target code execution
regions.
Summary:
This patch enhances Sema to check for the following restriction:
Open
nwilson added inline comments.
Comment at: include/clang/AST/DeclTemplate.h:374
@@ +373,3 @@
+ bool isConcept() const { return TemplatedDecl.getInt(); }
+ void setConcept(bool IC) { TemplatedDecl.setInt(true); }
+
rsmith wrote:
> I would prefer to not have a set
yaxunl updated this revision to Diff 46608.
yaxunl added a comment.
Add test for negative unroll hint value as suggested by Xiuli.
http://reviews.llvm.org/D16686
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Basic/DiagnosticParseKinds.td
include/clang/
pxli168 added inline comments.
Comment at: test/CodeGenOpenCL/generic_mangling.cl:1
@@ +1,2 @@
+// RUN: %clang_cc1 -ffake-address-space-map -emit-llvm -ffp-contract=off -x cl
-cl-std=CL2.0 -o - %s | FileCheck %s
+
Is this enough for the new added MicrosoftMangle?
Thank you for you advise, I will make these fixed in some later commit.
-Original Message-
From: meta...@gmail.com [mailto:meta...@gmail.com] On Behalf Of Richard Smith
Sent: Tuesday, February 2, 2016 5:53 AM
To: Xiuli Pan
Cc: cfe-commits
Subject: Re: r258782 - Recommit: R258773 [OpenCL]
pxli168 added inline comments.
Comment at: test/SemaOpenCL/unroll-hint.cl:22
@@ +21,2 @@
+}
+#endif
It seems the negative integer invalid test is missing?
I think it was in your last diff.
http://reviews.llvm.org/D16686
__
pxli168 accepted this revision.
pxli168 added a comment.
Thanks, LGTM!
http://reviews.llvm.org/D16692
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: alexfh, LegalizeAdulthood, aaron.ballman.
Eugene.Zelenko added a subscriber: cfe-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
This fix for PR26332. I checked it on my work code base.
Build and regres
dexonsmith added a comment.
Marshall, thanks for the link to #2464. That does look scary.
Nevertheless, I think this -- and the other over-eager allocations
in {unordered_,}{multi,}{map,set} -- are worth optimizing as long
as we can do it in a standards-compliant way. It's a pretty serious
regr
Marshall, thanks for the link to #2464. That does look scary.
Nevertheless, I think this -- and the other over-eager allocations
in {unordered_,}{multi,}{map,set} -- are worth optimizing as long
as we can do it in a standards-compliant way. It's a pretty serious
regression in performance compare
This revision was automatically updated to reflect the committed changes.
Closed by commit rL259453: [asan] Add iOS support for Address Sanitizer
(authored by zaks).
Changed prior to commit:
http://reviews.llvm.org/D15624?vs=45720&id=46605#toc
Repository:
rL LLVM
http://reviews.llvm.org/D15
Author: zaks
Date: Mon Feb 1 20:04:48 2016
New Revision: 259453
URL: http://llvm.org/viewvc/llvm-project?rev=259453&view=rev
Log:
[asan] Add iOS support for Address Sanitizer
Differential Revision: http://reviews.llvm.org/D15624
Modified:
cfe/trunk/lib/Driver/ToolChains.cpp
cfe/trunk/li
rsmith added inline comments.
Comment at: include/clang/AST/DeclTemplate.h:374
@@ +373,3 @@
+ bool isConcept() const { return TemplatedDecl.getInt(); }
+ void setConcept(bool IC) { TemplatedDecl.setInt(true); }
+
I would prefer to not have a setter at all, but i
dexonsmith updated this revision to Diff 46603.
dexonsmith added a comment.
Eric, I think this addresses all of your review comments.
There are a couple of prep NFC commits that I sent for review:
http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20160201/148661.html
http://lists.llvm.org
On Thu, Jan 28, 2016 at 8:23 AM, Vassil Vassilev wrote:
> Would this patch be more reasonable? It follows what
> RegisterTemplateSpecialization (introduced in r245779) does. AFAICT this
> adds an update record far less often.
It's still adding redundant update records. We'll write the
appropriate
compnerd added a comment.
I think it would be better if we could actually create a helper to get the
profiling library name for a specific library, and use that in both locations.
Do we have a test for the math case at the very least?
http://reviews.llvm.org/D16264
_
dexonsmith created this revision.
dexonsmith added a reviewer: EricWF.
dexonsmith added a subscriber: cfe-commits.
Instead of duplicating code in unordered_map::emplace(), use
__hash_table::__emplace_unique().
http://reviews.llvm.org/D16792
Files:
include/unordered_map
Index: include/unordere
dexonsmith created this revision.
dexonsmith added a reviewer: EricWF.
dexonsmith added a subscriber: cfe-commits.
When `!defined(_LIBCPP_DEBUG)`, unordered_map::emplace_hint() forwards
to emplace(). Do the same when `defined(_LIBCPP_DEBUG)`.
This has no real functionality change, just unifies t
rsmith added inline comments.
Comment at: lib/AST/RecordLayoutBuilder.cpp:1598-1599
@@ -1597,1 +1597,4 @@
+// PS4 remains compatible to pre r257462 behavior.
+bool isPS4ABI = (Context.getTargetInfo().getCXXABI().getKind() ==
TargetCXXABI::PS4);
+
Please
rsmith added a subscriber: rsmith.
Comment at: test/CodeGen/aapcs-bitfield.c:312-317
@@ +311,8 @@
+
+ // BE: %[[PTR3:.*]] = bitcast %struct.st5a* %[[PTR2]] to i32*
+ // BE-NEXT: %[[LD:.*]] = load volatile i32, i32* %[[PTR3]], align 4
+ // BE-NEXT: %[[CLR:.*]] = and i32 %[[LD]],
On Mon, Feb 1, 2016 at 2:10 PM, Richard Smith wrote:
> On Thu, Jan 14, 2016 at 2:57 PM, Richard Trieu via cfe-commits
> wrote:
> > Author: rtrieu
> > Date: Thu Jan 14 16:56:39 2016
> > New Revision: 257831
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=257831&view=rev
> > Log:
> > Refactor
Author: rtrieu
Date: Mon Feb 1 18:36:59 2016
New Revision: 259445
URL: http://llvm.org/viewvc/llvm-project?rev=259445&view=rev
Log:
Template Type Diffing change
When all the arguments of a template are elided, print "A<...>" instead of
"A<[2 * ...]>". Also remove comment fragment that means not
dexonsmith added a subscriber: dexonsmith.
dexonsmith added a comment.
Ping.
Marshall, does this look okay?
http://reviews.llvm.org/D16467
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
Ping.
Marshall, does this look okay?
> On 2016-Jan-25, at 10:32, Duncan P. N. Exon Smith via cfe-commits
> wrote:
>
> dexonsmith updated this revision to Diff 45879.
> dexonsmith added a comment.
>
> Addressed Marshall's review comments: deferring to
> match_results::operator[]() rather than
nwilson marked 5 inline comments as done.
nwilson added a comment.
Marking some comments Done which were fixed in previous updates.
http://reviews.llvm.org/D13357
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
Sunil_Srivastava created this revision.
Sunil_Srivastava added reviewers: rjmccall, DmitryPolukhin, rsmith, probinson.
Sunil_Srivastava added a subscriber: cfe-commits.
This is the round 2 of the PS4 ABI. In this round:
1) A new value PS4 has been added to TargetCXXABI::Kind. It is being used for
nwilson updated this revision to Diff 46588.
nwilson added a comment.
- Fix a couple of comments to reflect the Patch.
- Clang-format the changes in this Patch.
http://reviews.llvm.org/D13357
Files:
include/clang/AST/DeclTemplate.h
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaD
LegalizeAdulthood added inline comments.
Comment at: clang-tidy/readability/SimplifyBooleanExprCheck.h:21-22
@@ -20,71 +20,4 @@
/// them to use the appropriate boolean expression directly.
///
-/// Examples:
-///
-/// ===
Hello everyone,
LLVM buildmaster will be updated and restarted after 7 PM Pacific time
today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
thakis closed this revision.
thakis added a comment.
r259428, thanks! Went with the for-each loop but left the structure as-is -- I
find the comments helpful and it's not clear where they should go else.
http://reviews.llvm.org/D16478
___
cfe-commi
Author: nico
Date: Mon Feb 1 16:31:51 2016
New Revision: 259428
URL: http://llvm.org/viewvc/llvm-project?rev=259428&view=rev
Log:
Always build a new TypeSourceInfo for function templates with parameters
RecursiveASTVisitor::TraverseFunctionHelper() traverses a function's
ParmVarDecls by going to
Author: matze
Date: Mon Feb 1 16:18:58 2016
New Revision: 259424
URL: http://llvm.org/viewvc/llvm-project?rev=259424&view=rev
Log:
Fix build problem by lower SmallSet to a reasonable value
Modified:
clang-tools-extra/trunk/modularize/PreprocessorTracker.cpp
Modified: clang-tools-extra/trunk
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lib/Sema/SemaTemplateInstantiate.cpp:1525-1530
@@ -1524,18 +1524,8 @@
for (unsigned I = 0, E = FP.getNumParams(); I != E; ++I) {
-ParmVarDecl *P = FP.g
On Thu, Jan 14, 2016 at 2:57 PM, Richard Trieu via cfe-commits
wrote:
> Author: rtrieu
> Date: Thu Jan 14 16:56:39 2016
> New Revision: 257831
>
> URL: http://llvm.org/viewvc/llvm-project?rev=257831&view=rev
> Log:
> Refactor template type diffing
>
> 1) Instead of using pairs of From/To* fields,
Author: arpith
Date: Mon Feb 1 16:02:05 2016
New Revision: 259418
URL: http://llvm.org/viewvc/llvm-project?rev=259418&view=rev
Log:
Undoing commit r259366 to debug buildbot failure.
> http://reviews.llvm.org/D16758
Modified:
cfe/trunk/include/clang/Basic/OpenMPKinds.h
cfe/trunk/lib/Basi
thakis updated this revision to Diff 46578.
thakis added a comment.
restore accidentally dropped test
http://reviews.llvm.org/D16478
Files:
lib/Sema/SemaTemplateInstantiate.cpp
unittests/ASTMatchers/ASTMatchersTest.cpp
Index: unittests/ASTMatchers/ASTMatchersTest.cpp
==
On Mon, Feb 1, 2016 at 1:53 PM, Richard Smith wrote:
> On Thu, Jan 28, 2016 at 11:25 AM, Hans Wennborg wrote:
>> I don't think we have a specific code owner for OpenCL in Clang, which
>> means Richard is the owner.
>>
>> Richard, what do you think?
>
> Is there a reason we want to push this new f
thakis marked an inline comment as done.
Comment at: lib/Sema/SemaTemplateInstantiate.cpp:1519-1521
@@ -1518,5 +1518,5 @@
TypeLoc TL = T->getTypeLoc().IgnoreParens();
if (!TL.getAs())
return false;
Ack.
http://reviews.llvm.org/D16478
__
thakis updated this revision to Diff 46577.
thakis added a comment.
just return true
http://reviews.llvm.org/D16478
Files:
lib/Sema/SemaTemplateInstantiate.cpp
Index: lib/Sema/SemaTemplateInstantiate.cpp
===
--- lib/Sema/SemaTem
On Thu, Jan 28, 2016 at 11:25 AM, Hans Wennborg wrote:
> I don't think we have a specific code owner for OpenCL in Clang, which
> means Richard is the owner.
>
> Richard, what do you think?
Is there a reason we want to push this new feature into 3.8 rather
than waiting for the next release?
> On
On Mon, Jan 25, 2016 at 8:03 PM, Xiuli Pan via cfe-commits
wrote:
> Author: pxl
> Date: Mon Jan 25 22:03:48 2016
> New Revision: 258782
>
> URL: http://llvm.org/viewvc/llvm-project?rev=258782&view=rev
> Log:
> Recommit: R258773 [OpenCL] Pipe builtin functions
> Fix arc patch fuzz error.
> Summary:
Marshall: ping?
On Tue, Jan 26, 2016 at 11:08 AM, Hans Wennborg wrote:
> On Tue, Jan 19, 2016 at 9:21 AM, Hans Wennborg wrote:
>> On Tue, Jan 19, 2016 at 12:01 AM, Dimitry Andric wrote:
>>> On 19 Jan 2016, at 01:50, Marshall Clow via cfe-commits
>>> wrote:
Author: marshall
Date
Thanks! r259414.
On Mon, Feb 1, 2016 at 1:36 PM, Richard Smith wrote:
> LGTM for 3.8.
>
> On Thu, Jan 21, 2016 at 1:10 PM, Hans Wennborg wrote:
>> Richard, it was suggested (in
>> https://llvm.org/bugs/show_bug.cgi?id=26059#c7) that this gets merged
>> to 3.8. I believe this falls under your own
aaron.ballman added inline comments.
Comment at: clang-tidy/readability/SimplifyBooleanExprCheck.h:21-22
@@ -20,71 +20,4 @@
/// them to use the appropriate boolean expression directly.
///
-/// Examples:
-///
-/// ===
-//
Thanks! r259412.
On Mon, Feb 1, 2016 at 1:32 PM, Richard Smith wrote:
> LGTM for 3.8.
>
> On Wed, Jan 13, 2016 at 4:03 PM, Hans Wennborg wrote:
>> Thanks! Richard, what say the code owner?
>>
>> On Wed, Jan 13, 2016 at 3:59 PM, George Burgess IV
>> wrote:
>>> FYI: This patch should to be merged
C++11 narrowing only happens during certain conversions while this warning
checks all conversions.
We might be able to avoid char array initialization, but it would be a
little tricky. These warning usually have little information about where
the conversion is coming from, so distinguishing array
LegalizeAdulthood added inline comments.
Comment at: clang-tidy/readability/SimplifyBooleanExprCheck.h:21-22
@@ -20,71 +20,4 @@
/// them to use the appropriate boolean expression directly.
///
-/// Examples:
-///
-/// ===
LGTM for 3.8.
On Thu, Jan 21, 2016 at 1:10 PM, Hans Wennborg wrote:
> Richard, it was suggested (in
> https://llvm.org/bugs/show_bug.cgi?id=26059#c7) that this gets merged
> to 3.8. I believe this falls under your ownership.
>
> On Thu, Jan 21, 2016 at 4:54 AM, Alexey Bataev via cfe-commits
> wr
Author: aaronballman
Date: Mon Feb 1 15:28:33 2016
New Revision: 259409
URL: http://llvm.org/viewvc/llvm-project?rev=259409&view=rev
Log:
Code clean up; NFC.
Patch by Alexander Riccio.
Modified:
cfe/trunk/lib/StaticAnalyzer/Core/CheckerRegistry.cpp
Modified: cfe/trunk/lib/StaticAnalyzer/Co
LGTM for 3.8.
On Wed, Jan 13, 2016 at 4:03 PM, Hans Wennborg wrote:
> Thanks! Richard, what say the code owner?
>
> On Wed, Jan 13, 2016 at 3:59 PM, George Burgess IV
> wrote:
>> FYI: This patch should to be merged into the clang 3.8.0 branch.
>>
>> Thank you!
>> George
>>
>> On Wed, Jan 13, 201
sepavloff updated this revision to Diff 46575.
sepavloff added a comment.
Added regression test.
http://reviews.llvm.org/D15450
Files:
lib/CodeGen/CodeGenAction.cpp
unittests/Frontend/CMakeLists.txt
unittests/Frontend/CodeGenActionTest.cpp
Index: unittests/Frontend/CodeGenActionTest.cpp
aaron.ballman added inline comments.
Comment at: C:/LLVM/llvm/tools/clang/lib/StaticAnalyzer/Core/MemRegion.cpp:1396
@@ -1395,3 +1395,3 @@
const auto &ReferencedBlockVars = AC->getReferencedBlockVars(BC->getDecl());
- auto NumBlockVars =
+ const auto NumBlockVars =
std
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: alexfh, LegalizeAdulthood, aaron.ballman.
Eugene.Zelenko added a subscriber: cfe-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
This fix for PR25894. I checked it on my work code base.
Build and regres
eugenis added a comment.
In http://reviews.llvm.org/D16738#340175, @EricWF wrote:
> > This also could be fixed in a different way by replacing C-style
>
> > casts with reinterpret_cast<>, which, from my reading of the
>
> > standard, is allowed in this context.
>
>
> I agree that using `void*`
ariccio marked an inline comment as done.
ariccio added a comment.
As said in comment, I disagree with the no need for `const` here.
Comment at: C:/LLVM/llvm/tools/clang/lib/StaticAnalyzer/Core/MemRegion.cpp:1396
@@ -1395,3 +1395,3 @@
const auto &ReferencedBlockVars = AC->get
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Some minor things, but feel free to commit after addressing them.
I agree that we should figure out what to do about the zero/undef
initialization separately.
Comment at: li
rsmith added a comment.
This is a bug -- we intend to reuse `Stmt` nodes across the template and its
instantiations, but we should have separate `Decl` nodes in each instantiation
(otherwise the `Decl`'s parent will be wrong etc).
Comment at: lib/Sema/SemaTemplateInstantiate.c
Richard,
On Fri, Jan 15, 2016 at 5:32 PM, Richard Smith
wrote:
> On Fri, Jan 15, 2016 at 5:29 PM, Richard Smith
> wrote:
> > On Fri, Jan 15, 2016 at 4:22 PM, Artem Belevich wrote:
> >> tra added inline comments.
> >>
> >>
> >> Comment at: lib/CodeGen/CodeGenModule.cpp:2334
> >
Thanks Paul!
-Original Message-
From: Robinson, Paul [mailto:paul_robin...@playstation.sony.com]
Sent: Monday, February 1, 2016 11:46 PM
To: Igor Chesnokov; Anton Korobeynikov
Cc: cfe-commits (cfe-commits@lists.llvm.org)
Subject: RE: [PATCH] D16754: Bug 15785 - OpenCL errors using vector/
yaxunl updated this revision to Diff 46570.
yaxunl marked 7 inline comments as done.
yaxunl added a comment.
Revised as Anastasia suggested.
http://reviews.llvm.org/D16686
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Basic/DiagnosticParseKinds.td
incl
> Hi Anton,
>
> Okey, nevermore.
> But what to do with a bug which needs simply be closed (NABs)?
> I believe they also need a review/approval.
>
> Igor
Bugs do not have such a strict process, compared to patches.
If you don't feel confident in closing the bug directly, you can
Author: eugenezelenko
Date: Mon Feb 1 13:47:24 2016
New Revision: 259393
URL: http://llvm.org/viewvc/llvm-project?rev=259393&view=rev
Log:
Sort checks alphabetically in ReadabilityTidyModule.cpp.
Modified:
clang-tools-extra/trunk/clang-tidy/readability/ReadabilityTidyModule.cpp
Modified:
c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL259383: Fix attribute((mode([word|unwind_word]))) for x32
(authored by rnk).
Changed prior to commit:
http://reviews.llvm.org/D16779?vs=46558&id=46559#toc
Repository:
rL LLVM
http://reviews.llvm.org
Author: rnk
Date: Mon Feb 1 12:58:24 2016
New Revision: 259383
URL: http://llvm.org/viewvc/llvm-project?rev=259383&view=rev
Log:
Fix attribute((mode([word|unwind_word]))) for x32
Patch by H.J. Lu
```
typedef unsigned int gcc_word __attribute__((mode(word)));
```
and
```
typedef unsigned int gc
Author: pcc
Date: Mon Feb 1 12:55:50 2016
New Revision: 259382
URL: http://llvm.org/viewvc/llvm-project?rev=259382&view=rev
Log:
docs: Clarify that cfi-unrelated-cast is based on lifetime.
Also restore Makefile.sphinx which is needed to build the documentation.
Added:
cfe/trunk/docs/Makefil
hjl.tools added a comment.
Yes, please. Thanks.
http://reviews.llvm.org/D16779
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Should I land this for you?
http://reviews.llvm.org/D16779
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
Anastasia added a subscriber: Anastasia.
Comment at: lib/Sema/SemaDecl.cpp:2038
@@ +2037,3 @@
+ // returns 0. The're many implicit typedefs in OpenCL, e.g. atomic_flag.
+ if (Old->isImplicit() || New->isImplicit()) {
+return;
Braces are not needed.
hjl.tools created this revision.
hjl.tools added reviewers: rnk, rafael.
hjl.tools added a subscriber: cfe-commits.
```
typedef unsigned int gcc_word __attribute__((mode(word)));
```
and
```
typedef unsigned int gcc_unwind_word __attribute__((mode(unwind_word)));
```
define the largest unsigned i
Anastasia added inline comments.
Comment at: include/clang/Parse/Parser.h:2200
@@ -2199,1 +2199,3 @@
void ParseOpenCLQualifiers(ParsedAttributes &Attrs);
+ /// \brief Parses opencl_unroll_hint attribute if language is OpenCL 2.0+.
+ /// \return false if error happens.
---
jpienaar added a comment.
@jlebar: We defer it to your and Richard's approval. Thanks
http://reviews.llvm.org/D15305
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: d0k
Date: Mon Feb 1 11:42:01 2016
New Revision: 259376
URL: http://llvm.org/viewvc/llvm-project?rev=259376&view=rev
Log:
Move LocInfoType from Sema to AST.
While transient and only used during parsing, LocInfoTypes are still used
from ASTDumper and are part of the AST.
Added:
cfe/tr
aprantl added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:2099
@@ -2098,1 +2098,3 @@
+llvm::DIMacro *CGDebugInfo::CreateMacro(llvm::DIMacroFile *Parent, bool
IsUndef,
+SourceLocation LineLoc, StringRef Name,
aaron.ballman added a comment.
In http://reviews.llvm.org/D16526#340785, @LegalizeAdulthood wrote:
> In http://reviews.llvm.org/D16526#334938, @aaron.ballman wrote:
>
> > I'm of two minds on this [...]
>
>
> I just need a thumbs up/down on this.
>
> Thumbs down, I discard the review.
>
> Thumbs u
LegalizeAdulthood added a comment.
In http://reviews.llvm.org/D16526#334938, @aaron.ballman wrote:
> I'm of two minds on this [...]
I just need a thumbs up/down on this.
Thumbs down, I discard the review.
Thumbs up, you take the patch.
Patch by Richard Thomson.
http://reviews.llvm.org/D165
On Fri, Jan 29, 2016 at 4:50 PM, Alexey Samsonov wrote:
>
> On Fri, Jan 29, 2016 at 3:16 PM, Hans Wennborg wrote:
>>
>> Yes, that seems like a good idea. Go ahead and merge (or let me know
>> if you'd prefer me to do it).
>
>
> I'd appreciate if you could do it. Thanks!
r259371. Thanks.
>> On F
rnk added inline comments.
Comment at: include/clang/AST/ASTContext.h:1771-1782
@@ -1770,1 +1770,14 @@
+ /// Return true is the given types are compatible in C from MSVC's point of
+ /// view.
+ //
+ // Conditions:
+ // 1. Both types are equally-qualified, sized and align
aaron.ballman added inline comments.
Comment at: clang-tidy/readability/SimplifyBooleanExprCheck.h:21-22
@@ -20,71 +20,4 @@
/// them to use the appropriate boolean expression directly.
///
-/// Examples:
-///
-/// ===
-//
LegalizeAdulthood added inline comments.
Comment at: clang-tidy/readability/SimplifyBooleanExprCheck.h:21-22
@@ -20,71 +20,4 @@
/// them to use the appropriate boolean expression directly.
///
-/// Examples:
-///
-/// ===
LegalizeAdulthood added inline comments.
Comment at: clang-tidy/modernize/RawStringLiteralCheck.cpp:88
@@ +87,3 @@
+}
+
+bool containsDelimiter(StringRef Bytes, const std::string &Delimiter) {
alexfh wrote:
> aaron.ballman wrote:
> > I think Alex's point is: why n
rmaprath added a comment.
Ping?
http://reviews.llvm.org/D16586
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM!
http://reviews.llvm.org/D16692
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
alexfh added a comment.
Thank you for adding more test cases! Could you address one more comment in a
follow-up, please?
Comment at: test/clang-tidy/readability-redundant-control-flow.cpp:193
@@ +192,3 @@
+// CHECK-FIXES-NEXT: {{^return;$}}
+// CHECK-FIXES-NEXT: {{^ *}$}}
+
This revision was automatically updated to reflect the committed changes.
Closed by commit rL259366: [OpenMP] Prevent nesting of target constructs within
target code execution… (authored by arpith).
Changed prior to commit:
http://reviews.llvm.org/D16758?vs=46496&id=46544#toc
Repository:
rL
majnemer added a comment.
MSVC permits:
typedef int foo;
typedef float foo;
This is crazy and most certainly not 'benign'. I think that we should insist
that the underlying types not just be the same size and alignment but the same
kind of scalar type. If two types are integral or enumerat
Author: arpith
Date: Mon Feb 1 10:32:47 2016
New Revision: 259366
URL: http://llvm.org/viewvc/llvm-project?rev=259366&view=rev
Log:
[OpenMP] Prevent nesting of target constructs within target code execution
regions.
Summary:
This patch enhances Sema to check for the following restriction:
Open
alexfh added inline comments.
Comment at: clang-tidy/modernize/RawStringLiteralCheck.cpp:80
@@ +79,3 @@
+return false;
+
+ const size_t NewLinePos = Text.find(R"(\n)");
aaron.ballman wrote:
> This is why I would still prefer to block on fixing StringLiteral.
>> Yes, that is what I mean. It is odd that -frtti changes us from "this
>> is not available anywhere, use linkonce_odr" to "it is available
>> elsewhere, use an external declaration".
>
> Yes, I agree, it's weird (although the transition is in the other
> direction, really, since there's no such f
hokein marked 3 inline comments as done.
Comment at: clang-tidy/misc/IncorrectRoundings.cpp:39
@@ +38,3 @@
+namespace tidy {
+void IncorrectRoundings::registerMatchers(MatchFinder *MatchFinder) {
+ // Match a floating literal with value 0.5.
Done. The `ASTMatcher
ayartsev updated this revision to Diff 46538.
ayartsev added a comment.
Updated the patch, please review.
http://reviews.llvm.org/D16317
Files:
lib/StaticAnalyzer/Checkers/CStringChecker.cpp
test/Analysis/string.c
Index: test/Analysis/string.c
==
hokein updated this revision to Diff 46539.
hokein added a comment.
Address Alex's comments.
http://reviews.llvm.org/D16764
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/IncorrectRoundings.cpp
clang-tidy/misc/IncorrectRoundings.h
clang-tidy/misc/MiscTidyModule.cpp
docs/clang-t
aaron.ballman added inline comments.
Comment at: clang-tidy/readability/SimplifyBooleanExprCheck.h:21-22
@@ -20,71 +20,4 @@
/// them to use the appropriate boolean expression directly.
///
-/// Examples:
-///
-/// ===
-//
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
With one small nit to the diagnostic wording for consistency, LGTM! I will go
ahead and make that change, then commit on your behalf. You may want to talk to
Chris Lattner about
aaron.ballman closed this revision.
aaron.ballman added a comment.
I have commit in r259362. Thank you!
http://reviews.llvm.org/D16259
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: aaronballman
Date: Mon Feb 1 09:31:15 2016
New Revision: 259362
URL: http://llvm.org/viewvc/llvm-project?rev=259362&view=rev
Log:
Add a new check, readability-redundant-control-flow, that check for some forms
of redundant control flow statements. Currently checks for return statements at
1 - 100 of 127 matches
Mail list logo
