On Tuesday, 9 February 2016, 18:09:37 CET, Marshall Clow wrote:
> On Thu, Feb 4, 2016 at 3:17 PM, Niels Ole Salscheider via cfe-commits <
>
> cfe-commits@lists.llvm.org> wrote:
> > Author: olesalscheider
> > Date: Thu Feb 4 17:17:20 2016
> > New Revision: 259842
> >
> > URL: http://llvm.org/view
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rL LLVM
http://reviews.llvm.org/D17064
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
LegalizeAdulthood added inline comments.
Comment at:
clang-tools-extra/trunk/clang-tidy/misc/MisplacedWideningCastCheck.cpp:21-23
@@ +20,5 @@
+void MisplacedWideningCastCheck::registerMatchers(MatchFinder *Finder) {
+ auto Calc = expr(anyOf(binaryOperator(anyOf(
+
[Please reply *only* to the list and do not include my email directly
in the To: or Cc: of your reply; otherwise I will not see your reply.
Thanks.]
In article ,
Richard via cfe-commits writes:
> make check-all passes for me. I don't see what the problem is in the logs
> either.
OK, I fou
Author: ahatanak
Date: Wed Feb 10 00:06:06 2016
New Revision: 260360
URL: http://llvm.org/viewvc/llvm-project?rev=260360&view=rev
Log:
[Sema] Issue a warning for integer overflow in nested struct initializer
r257357 fixed clang to warn on integer overflow in struct initializers.
However, it didn'
flx created this revision.
flx added a reviewer: alexfh.
flx added a subscriber: cfe-commits.
flx set the repository for this revision to rL LLVM.
Fix oversight not checking the value of the Optional returned by
isExpensiveToCopy().
Repository:
rL LLVM
http://reviews.llvm.org/D17064
Files:
rsmith added a subscriber: rsmith.
rsmith added a comment.
The direction here generally seems fine to me.
Comment at: lib/Driver/ToolChain.cpp:538
@@ -536,7 +537,3 @@
ToolChain::CXXStdlibType ToolChain::GetCXXStdlibType(const ArgList &Args)
const{
- if (Arg *A = Args.getLastA
zaks.anna added a comment.
Looks good, below are some comments which are mostly nits.
What's the plan for bringing this out of alpha? Is it pending evaluation on
real code?
Comment at: lib/StaticAnalyzer/Checkers/ObjCSuperDeallocChecker.cpp:11
@@ +10,3 @@
+// This defines ObjC
Eugene.Zelenko updated this revision to Diff 47415.
Eugene.Zelenko added a comment.
More fixes.
Repository:
rL LLVM
http://reviews.llvm.org/D17060
Files:
include/clang/Analysis/Analyses/ThreadSafetyUtil.h
lib/ARCMigrate/ObjCMT.cpp
lib/AST/ASTDiagnostic.cpp
lib/AST/CommentLexer.cpp
LegalizeAdulthood updated this revision to Diff 47414.
LegalizeAdulthood added a comment.
Fixes StringRef problem that crashes tests in release builds only.
http://reviews.llvm.org/D16308
Files:
clang-tidy/readability/SimplifyBooleanExprCheck.cpp
clang-tidy/readability/SimplifyBooleanExprCh
ahatanak updated this revision to Diff 47413.
ahatanak added a comment.
Rename and add variables. Add comments to make it clearer what the code is
doing.
http://reviews.llvm.org/D16843
Files:
lib/Sema/TypeLocBuilder.cpp
lib/Sema/TypeLocBuilder.h
test/SemaObjCXX/typeloc-data-alignment.mm
jlebar added a comment.
Okay, I see why things don't work as expected without this patch but do work
for e.g. macos universal binaries.
The reason is, we build a completely separate set of actions for each
invocation of cc1 -- one for the host compilation, and one for each device
arch. Then t
dcoughlin updated this revision to Diff 47412.
dcoughlin added a comment.
Updated this to address Anna's comments.
- I've made the state smaller. It is just now a set of SymbolRefs for methods
instances that have been dealloc'd.
- I've hoisted isSuperDeallocMessage() to early return when possibl
Author: cbieneman
Date: Tue Feb 9 20:17:21 2016
New Revision: 260350
URL: http://llvm.org/viewvc/llvm-project?rev=260350&view=rev
Log:
[CMake] For multi-stage builds to be deterministic we need to disable
timestamps.
Duh! With this change I've verified -O3 builds are deterministic.
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL260348: Get rid of another SAME-NOT. FileCheck does not have
this suffix. (authored by probinson).
Changed prior to commit:
http://reviews.llvm.org/D17062?vs=47410&id=47411#toc
Repository:
rL LLVM
h
Author: probinson
Date: Tue Feb 9 20:08:24 2016
New Revision: 260348
URL: http://llvm.org/viewvc/llvm-project?rev=260348&view=rev
Log:
Get rid of another SAME-NOT. FileCheck does not have this suffix.
Differential Revision: http://reviews.llvm.org/D17062
Modified:
cfe/trunk/test/Driver/cuda
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
This looks good to me.
> Saving a larger locale refactor for later (but oh boy is it coming).
Looking forward to it.
http://reviews.llvm.org/D16639
On Thu, Feb 4, 2016 at 3:17 PM, Niels Ole Salscheider via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: olesalscheider
> Date: Thu Feb 4 17:17:20 2016
> New Revision: 259842
>
> URL: http://llvm.org/viewvc/llvm-project?rev=259842&view=rev
> Log:
> Fix the search path for CMake files
probinson created this revision.
probinson added reviewers: jroelofs, jlebar.
probinson added a subscriber: cfe-commits.
Inspired by r260334, found another bogus SAME-NOT suffix. FileCheck does not
have this combo.
http://reviews.llvm.org/D17062
Files:
test/Driver/cuda-options.cu
Index: tes
Author: chapuni
Date: Tue Feb 9 19:45:51 2016
New Revision: 260347
URL: http://llvm.org/viewvc/llvm-project?rev=260347&view=rev
Log:
clang/test/Index/skip-parsed-bodies/compile_commands.json: Appease targeting
msvc.
Modified:
cfe/trunk/test/Index/skip-parsed-bodies/compile_commands.json
Mo
> The paren check looks redundant.
> And this one.
Fixed in r260346.
On Tue, Feb 9, 2016 at 5:29 PM, Robinson, Paul
wrote:
> Well I'll be-- thanks!
> See post-commit comments, see below, tidying up just a bit.
> --paulr
>
>> -Original Message-
>> From: cfe-commits [mailto:cfe-commits-bou
Author: jlebar
Date: Tue Feb 9 19:34:17 2016
New Revision: 260346
URL: http://llvm.org/viewvc/llvm-project?rev=260346&view=rev
Log:
Remove some unnecessary CHECK-SAMEs in ModuleDebugInfo.{cpp,m}.
Suggested by Paul Robinson.
Modified:
cfe/trunk/test/Modules/ModuleDebugInfo.cpp
cfe/trunk/
Author: chapuni
Date: Tue Feb 9 19:29:57 2016
New Revision: 260344
URL: http://llvm.org/viewvc/llvm-project?rev=260344&view=rev
Log:
libclang: Enable skip-parsed-bodies on win32.
I guess it would be working since Rafael's r187619.
Modified:
cfe/trunk/test/Index/skip-parsed-bodies/compile_co
hintonda added a comment.
This patch fixes bug 26077.
https://llvm.org/bugs/show_bug.cgi?id=26077
http://reviews.llvm.org/D16971
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Well I'll be-- thanks!
See post-commit comments, see below, tidying up just a bit.
--paulr
> -Original Message-
> From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of
> Justin Lebar via cfe-commits
> Sent: Tuesday, February 09, 2016 4:38 PM
> To: cfe-commits@lists.llv
On Tue, Feb 9, 2016 at 4:15 PM, Cong Liu wrote:
> Hi Richard,
>
> Thank you for your reply. Yes, the case I need to deal with is like what you
> said:
>>
>> If you want to make the assumption that the primary template will be
>> used for an unknown specialization, you'll need something like that
>
Author: cbieneman
Date: Tue Feb 9 19:09:59 2016
New Revision: 260341
URL: http://llvm.org/viewvc/llvm-project?rev=260341&view=rev
Log:
[CMake] Pass LLVM_EXTERNAL_*_SOURCE_DIR variables to subsequent stages
For multi-stage builds we need to pass any overridden source directory
variables. Without
Author: cbieneman
Date: Tue Feb 9 19:09:56 2016
New Revision: 260340
URL: http://llvm.org/viewvc/llvm-project?rev=260340&view=rev
Log:
[CMake] Fixing the 3-stage cmake cache.
I had hoped this would work from a single cache file, but turns out there is a
bug I can't quite figure out relating to
jpienaar marked 3 inline comments as done.
jpienaar added a comment.
Updated thanks.
Comment at: lib/CodeGen/TargetInfo.cpp:6498
@@ +6497,3 @@
+
+ Class classify(QualType Ty) const;
+
We only had one DefaultNumRegisterParameters that we supported
(DefaultNumRe
jlebar updated this revision to Diff 47409.
jlebar marked 2 inline comments as done.
jlebar added a comment.
Update per tra's review.
http://reviews.llvm.org/D17056
Files:
lib/CodeGen/CodeGenModule.cpp
test/CodeGenCUDA/convergent.cu
Index: test/CodeGenCUDA/convergent.cu
===
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm if you clarify that bit
Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1676
@@ -1675,2 +1675,3 @@
- llvm::GlobalValue::LinkageTypes VFTableLinkage = CGM.getVTableLinkage(RD);
+
On Thu, Feb 4, 2016 at 3:17 PM, Niels Ole Salscheider via cfe-commits
wrote:
> Author: olesalscheider
> Date: Thu Feb 4 17:17:20 2016
> New Revision: 259842
>
> URL: http://llvm.org/viewvc/llvm-project?rev=259842&view=rev
> Log:
> Fix the search path for CMake files
>
> This allows to find the LL
On Wed, Jan 20, 2016 at 12:48 AM, Eric Fiselier via cfe-commits
wrote:
> The direction and change LGTM. Feel free to commit once the change has some
> tests.
Thanks, I updated the existing tests to no longer XFAIL Apple systems
with recent Clang and committed as r260337.
> On Fri, Jan 8, 2016 at
Author: rsmith
Date: Tue Feb 9 18:59:02 2016
New Revision: 260337
URL: http://llvm.org/viewvc/llvm-project?rev=260337&view=rev
Log:
Fix overload sets of strchr, strpbrk, strrchr, memchr and strstr from
and wcschr, wcspbrk, wcsrchr, wmemchr, and wcsstr from to
provide a const-correct overload se
jpienaar updated this revision to Diff 47408.
jpienaar added a comment.
Added clang-level tests.
http://reviews.llvm.org/D17002
Files:
lib/Basic/Targets.cpp
lib/CodeGen/TargetInfo.cpp
lib/Driver/Driver.cpp
lib/Driver/ToolChains.h
lib/Driver/Tools.cpp
lib/Driver/Tools.h
test/CodeGe
majnemer created this revision.
majnemer added reviewers: rnk, hans, thakis, rsmith.
majnemer added a subscriber: cfe-commits.
Referencing a dllimported vtable is impossible in a constexpr
constructor. It would be friendlier to C++ programmers if we
synthesized a copy of the vftable which referen
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: hans, aaron.ballman.
Eugene.Zelenko added a subscriber: cfe-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
I checked this patch on my own build on RHEL 6. Regressions were OK.
Repository:
rL LLVM
ht
On Feb 9, 2016, at 7:46 PM, Duncan P. N. Exon Smith
wrote:
>
>
>> On 2016-Feb-09, at 16:40, Howard Hinnant wrote:
>>
>> On Feb 9, 2016, at 7:17 PM, Duncan P. N. Exon Smith via cfe-commits
>> wrote:
>>>
>>> Any other ideas for improving the failure mode?
>>
>> Here’s a suggestion:
>>
>> h
> On 2016-Feb-09, at 16:40, Howard Hinnant wrote:
>
> On Feb 9, 2016, at 7:17 PM, Duncan P. N. Exon Smith via cfe-commits
> wrote:
>>
>> Any other ideas for improving the failure mode?
>
> Here’s a suggestion:
>
> https://github.com/llvm-mirror/libcxx/blob/master/include/vector#L1658
>
> M
alexfh added inline comments.
Comment at: clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp:88
@@ +87,3 @@
+if (InitializerBefore != nullptr)
+ return InitializerBefore->getRParenLoc().getLocWithOffset(1);
+auto StartLocation = InitializerAfter != nullptr
--
tra added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:1880
@@ +1879,3 @@
+// Conservatively, mark all functions in CUDA as convergent (meaning, they
+// may call an intrinsicly convergent op, such as __syncthreads(), and so
+// can't have certain optimiz
This revision was automatically updated to reflect the committed changes.
Closed by commit rL260334: Get rid of CHECK-SAME-NOT in tests. (authored by
jlebar).
Changed prior to commit:
http://reviews.llvm.org/D17051?vs=47385&id=47397#toc
Repository:
rL LLVM
http://reviews.llvm.org/D17051
Fi
Author: jlebar
Date: Tue Feb 9 18:38:15 2016
New Revision: 260334
URL: http://llvm.org/viewvc/llvm-project?rev=260334&view=rev
Log:
Get rid of CHECK-SAME-NOT in tests.
Summary: This isn't a FileCheck directive; it does nothing.
Reviewers: jroelofs
Subscribers: cfe-commits, majnemer
Differenti
It's best not to commit things without approval once they've been sent for
review (the assumption being that if you asked for review it's because the
change needed review - time doesn't change that fact) - if approval was
given off-list (eg: on IRC) it's best to mention who gave it & where (&
ideal
On Feb 9, 2016, at 7:17 PM, Duncan P. N. Exon Smith via cfe-commits
wrote:
>
> Any other ideas for improving the failure mode?
Here’s a suggestion:
https://github.com/llvm-mirror/libcxx/blob/master/include/vector#L1658
Make this easy to activate.
Howard
_
jlebar marked 2 inline comments as done.
Comment at: test/Modules/ModuleDebugInfo.cpp:10
@@ -9,3 +9,3 @@
// RUN: cat %t-mod.ll | FileCheck %s
// RUN: cat %t-mod.ll | FileCheck --check-prefix=CHECK-NEG %s
jroelofs wrote:
> jlebar wrote:
> > jlebar wrote:
> > >
jroelofs accepted this revision.
jroelofs added a reviewer: jroelofs.
jroelofs added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: test/Modules/ModuleDebugInfo.cpp:10
@@ -9,3 +9,3 @@
// RUN: cat %t-mod.ll | FileCheck %s
// RUN: cat %t-mod.ll | F
jlebar marked 3 inline comments as done.
Comment at: test/Modules/ModuleDebugInfo.cpp:10
@@ -9,3 +9,3 @@
// RUN: cat %t-mod.ll | FileCheck %s
// RUN: cat %t-mod.ll | FileCheck --check-prefix=CHECK-NEG %s
jlebar wrote:
> jlebar wrote:
> > jroelofs wrote:
> > >
jlebar created this revision.
jlebar added a reviewer: majnemer.
jlebar added subscribers: tra, echristo, jhen, cfe-commits.
This is important for e.g. the following case:
void sync() { __syncthreads(); }
void foo() {
do_something();
sync();
do_something_else():
}
Without this
hintonda added a comment.
Great, thanks. Btw, I don't have commit access, so could you commit for me?
thanks don
http://reviews.llvm.org/D13622
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
Ah, so the cost isn't necessarily the same. I don't think this
is worth it then. (Although, paradoxically, it opens up an avenue
for testing, via a custom allocator which counts On 2016-Feb-09, at 16:14, Marshall Clow wrote:
>
> mclow.lists added a comment.
>
>> Since `__new_last` and `__end_
dexonsmith added a comment.
Ah, so the cost isn't necessarily the same. I don't think this
is worth it then. (Although, paradoxically, it opens up an avenue
for testing, via a custom allocator which counts http://reviews.llvm.org/D17053
___
cfe-comm
Author: kromanova
Date: Tue Feb 9 18:12:24 2016
New Revision: 260333
URL: http://llvm.org/viewvc/llvm-project?rev=260333&view=rev
Log:
This patch adds doxygen comments for all the intrinsincs in the header file
f16cintrin.h. The doxygen comments are automatically generated based on Sony's
intri
This revision was automatically updated to reflect the committed changes.
Closed by commit rL260333: This patch adds doxygen comments for all the
intrinsincs in the header file… (authored by kromanova).
Changed prior to commit:
http://reviews.llvm.org/D17021?vs=47299&id=47394#toc
Repository:
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D13622
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hi Richard,
Thank you for your reply. Yes, the case I need to deal with is like what
you said:
> If you want to make the assumption that the primary template will be
> used for an unknown specialization, you'll need something like that
> function in ASTMatchFinder.
For example,
1. templa
mclow.lists added a comment.
> Since `__new_last` and `__end_` are raw pointers, < should be the same cost
> as !=.
`pointer` is an alias for `allocator_traits<_Alloc>::pointer`, which might not
be a raw pointer.
http://reviews.llvm.org/D17053
_
dexonsmith added a subscriber: dexonsmith.
dexonsmith added a comment.
I'm not sure I disagree. What got me slightly motivated was seeing
that UBSan doesn't catch this.
http://reviews.llvm.org/D17053
___
cfe-commits mailing list
cfe-commits@lists.l
jroelofs added inline comments.
Comment at: test/Modules/ModuleDebugInfo.cpp:25
@@ -25,1 +24,3 @@
+// CHECK-SAME:dwoId:
+// CHECK-SAME:)
jlebar wrote:
> jroelofs wrote:
> > This `CHECK-SAME` line and all the others are sti
I'm not sure I disagree. What got me slightly motivated was seeing
that UBSan doesn't catch this.
> On 2016-Feb-09, at 16:04, Marshall Clow wrote:
>
> mclow.lists added a comment.
>
> Undefined behavior is just that, undefined.
>
> I'm not that interested in "fixing" this; I don't think it's
chapuni resigned from this revision.
chapuni edited reviewers, added: rnk; removed: chapuni.
chapuni added a comment.
I haven't worked in this. I guess it just works. :)
http://reviews.llvm.org/D13622
___
cfe-commits mailing list
cfe-commits@lists.l
jlebar marked an inline comment as done.
Comment at: test/Modules/ModuleDebugInfo.cpp:10
@@ -9,3 +9,3 @@
// RUN: cat %t-mod.ll | FileCheck %s
// RUN: cat %t-mod.ll | FileCheck --check-prefix=CHECK-NEG %s
jlebar wrote:
> jroelofs wrote:
> > While you're here, m
jlebar added inline comments.
Comment at: test/Modules/ModuleDebugInfo.cpp:10
@@ -9,3 +9,3 @@
// RUN: cat %t-mod.ll | FileCheck %s
// RUN: cat %t-mod.ll | FileCheck --check-prefix=CHECK-NEG %s
jroelofs wrote:
> While you're here, may as well shorten these thre
mclow.lists added a comment.
Undefined behavior is just that, undefined.
I'm not that interested in "fixing" this; I don't think it's broken.
http://reviews.llvm.org/D17053
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
hubert.reinterpretcast added inline comments.
Comment at: lib/Basic/TargetInfo.cpp:231
@@ +230,3 @@
+if (hasFloat128Type() &&
+&getFloat128Format() == &llvm::APFloat::IEEEquad)
+ return Float128;
Is it necessary to check that `__float128` is IEEE
dexonsmith created this revision.
dexonsmith added reviewers: mclow.lists, EricWF.
dexonsmith added a subscriber: cfe-commits.
The following program is obviously broken:
#include
int main(int argc, const char * argv[]) {
std::vector v;
v.push_back(0);
v.pop_back()
jroelofs added a subscriber: jroelofs.
Comment at: test/Modules/ModuleDebugInfo.cpp:10
@@ -9,3 +9,3 @@
// RUN: cat %t-mod.ll | FileCheck %s
// RUN: cat %t-mod.ll | FileCheck --check-prefix=CHECK-NEG %s
While you're here, may as well shorten these three lines t
Hi Hans,
Please wait before merging this as it breaks LLVM bootstraps when using the
-gcc-toolchain option and the system's default gcc installation does not
provide libatomic. We have to check LIBCXX_GCC_TOOLCHAIN in our test. I'll
create a patch tomorrow and I'll let you know when it's okay t
Author: vkalintiris
Date: Tue Feb 9 17:38:28 2016
New Revision: 260323
URL: http://llvm.org/viewvc/llvm-project?rev=260323&view=rev
Log:
Revert "Introduce a cmake module to figure out whether we need to link with
libatomic."
This reverts commit r260235. It breaks LLVM's bootstrap when building
jlebar created this revision.
jlebar added a reviewer: majnemer.
jlebar added a subscriber: cfe-commits.
This isn't a FileCheck directive; it does nothing.
http://reviews.llvm.org/D17051
Files:
test/CodeGenCXX/optnone-and-attributes.cpp
test/CodeGenCXX/optnone-class-members.cpp
test/CodeGe
On Tue, Feb 9, 2016 at 2:43 PM, Jorge Teixeira
wrote:
> Richard,
>
> Can you be more specific?
>
> I assume you mean something like my newly attached .h file that tests
> very basic implementation compliance (i.e., it's required, but not
> sufficient), but I would need a bit more guidance about th
Author: rsmith
Date: Tue Feb 9 16:48:14 2016
New Revision: 260311
URL: http://llvm.org/viewvc/llvm-project?rev=260311&view=rev
Log:
Update documentation to reflect that libc++abi provides __cxa_thread_atexit
(and has for quite a while). Also document that we have not yet implemented the
new inh
Author: rsmith
Date: Tue Feb 9 16:34:35 2016
New Revision: 260307
URL: http://llvm.org/viewvc/llvm-project?rev=260307&view=rev
Log:
PR26349: correctly check whether a digit sequence is empty in the presence of
digit separators.
Modified:
cfe/trunk/include/clang/Lex/LiteralSupport.h
cfe/
Author: jvesely
Date: Tue Feb 9 16:17:45 2016
New Revision: 260302
URL: http://llvm.org/viewvc/llvm-project?rev=260302&view=rev
Log:
configure: Introduce per device defines
Make cl_khr_fp64 define per-device.
This patch does not change the generated Makefile (for llvm 3.6, 3.7)
v2: Make the dev
Author: jvesely
Date: Tue Feb 9 16:17:48 2016
New Revision: 260304
URL: http://llvm.org/viewvc/llvm-project?rev=260304&view=rev
Log:
configure: Remove llvm 3.6 defines
we require llvm 3.7
reviewer: tstellard
Signed-off-by: Jan Vesely
Modified:
libclc/trunk/configure.py
Modified: libclc/t
Author: jvesely
Date: Tue Feb 9 16:17:46 2016
New Revision: 260303
URL: http://llvm.org/viewvc/llvm-project?rev=260303&view=rev
Log:
configure: Remove cl_khr_fp64 for device that don't support doubles
Also remove definitions if provided by clang (3.7+)
This halves the size of builtin.opt.{cedar,
Author: jvesely
Date: Tue Feb 9 16:17:42 2016
New Revision: 260301
URL: http://llvm.org/viewvc/llvm-project?rev=260301&view=rev
Log:
math: Fix log2 vectorization on non-fp64 hw
reviewer: tstellard
Signed-off-by: Jan Vesely
Modified:
libclc/trunk/generic/lib/math/log2.cl
Modified: libclc/t
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Thanks, lgtm!
http://reviews.llvm.org/D15373
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
eliben added a subscriber: eliben.
eliben added a comment.
Clang-level tests?
Comment at: lib/Basic/Targets.cpp:5873
@@ +5872,3 @@
+"-m:e" // ELF name manging
+"-p:32:32" // 32-bit pointers work aligned
+"-i64:64" // 64 bit integers, 64 bit aligne
rsmith closed this revision.
rsmith added a comment.
In r260278.
http://reviews.llvm.org/D15861
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rsmith
Date: Tue Feb 9 15:04:04 2016
New Revision: 260278
URL: http://llvm.org/viewvc/llvm-project?rev=260278&view=rev
Log:
Add Tooling functionality to get a name for a QualType that can be used to name
that type from the global scope.
Patch by Sterling Augustine, derived (with permissi
On Tue, Feb 9, 2016 at 3:59 PM, Reid Kleckner wrote:
> On Tue, Feb 9, 2016 at 12:32 PM, Aaron Ballman
> wrote:
>>
>> On Tue, Feb 9, 2016 at 2:53 PM, Reid Kleckner via cfe-commits
>> wrote:
>> > Author: rnk
>> > Date: Tue Feb 9 13:53:30 2016
>> > New Revision: 260267
>> >
>> > URL: http://llvm.o
On Tue, Feb 9, 2016 at 12:07 PM, David Li via llvm-commits <
llvm-comm...@lists.llvm.org> wrote:
> This revision was automatically updated to reflect the committed changes.
> Closed by commit rL260270: [PGO] Fix issue: explicitly defaulted assignop
> is not profiled (authored by davidxl).
>
In ge
jeanphilippeD added a comment.
Hi Manuel,
Thank you very much for the review.
I do not have commit access, would you be able to commit this patch for me.
Kind Regards,
Jean-Philippe
http://reviews.llvm.org/D16524
___
cfe-commits mailing list
cfe-c
Author: rsmith
Date: Tue Feb 9 14:59:05 2016
New Revision: 260277
URL: http://llvm.org/viewvc/llvm-project?rev=260277&view=rev
Log:
Simplify and rename ASTMatchFinder's getCXXRecordDecl to make it more obvious
what it's actually trying to do.
Modified:
cfe/trunk/lib/ASTMatchers/ASTMatchFinde
On Tue, Feb 9, 2016 at 12:32 PM, Aaron Ballman
wrote:
> On Tue, Feb 9, 2016 at 2:53 PM, Reid Kleckner via cfe-commits
> wrote:
> > Author: rnk
> > Date: Tue Feb 9 13:53:30 2016
> > New Revision: 260267
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=260267&view=rev
> > Log:
> > Pass /bigob
Patch looks good. Please also add a testcase to test/Headers.
On Tue, Feb 9, 2016 at 12:08 PM, Hubert Tong via cfe-commits
wrote:
> I see no immediate issue with this patch, but I am not one of the usual
> reviewers for this part of the code base.
>
> -- HT
>
>
> On Tue, Feb 9, 2016 at 2:56 PM, J
Author: ehsan
Date: Tue Feb 9 14:49:24 2016
New Revision: 260276
URL: http://llvm.org/viewvc/llvm-project?rev=260276&view=rev
Log:
Fix the test added in r260266
Modified:
cfe/trunk/test/Frontend/plugins.c
Modified: cfe/trunk/test/Frontend/plugins.c
URL:
http://llvm.org/viewvc/llvm-project/
dblaikie added inline comments.
Comment at: cfe/trunk/test/Profile/def-assignop.cpp:27
@@ +26,3 @@
+
+int main() {
+ A a1, a2;
This doesn't need to be main or have an int return. Just make it a void
function (with some generic name) & drop the "return 0" to keep
On Tue, Feb 9, 2016 at 2:53 PM, Reid Kleckner via cfe-commits
wrote:
> Author: rnk
> Date: Tue Feb 9 13:53:30 2016
> New Revision: 260267
>
> URL: http://llvm.org/viewvc/llvm-project?rev=260267&view=rev
> Log:
> Pass /bigobj when building lib/ASTMatchers/Dynamic/Registry.cpp
>
> This is the third
Thanks Hubert. Somehow I omitted that prefix when typing the macros,
and I did not noticed it when I was testing because on my arch
DECIMAL_DIG is defined to be the LDBL version...
Updated patch is attached.
JT
On Tue, Feb 9, 2016 at 1:41 PM, Hubert Tong
wrote:
> There is a __LDBL_DECIMAL_DIG__
On Tue, Feb 9, 2016 at 9:03 AM, Cong Liu via cfe-commits
wrote:
> Hi Richard,
>
> I need to use the function (line 747 of ASTMatchFinder.cpp):
>
> static CXXRecordDecl *getAsCXXRecordDecl(const Type *TypeNode)
>
> in the misc-virtual-near-miss check of clang-tidy, because it can correctly
> get
I see no immediate issue with this patch, but I am not one of the usual
reviewers for this part of the code base.
-- HT
On Tue, Feb 9, 2016 at 2:56 PM, Jorge Teixeira
wrote:
> Thanks Hubert. Somehow I omitted that prefix when typing the macros,
> and I did not noticed it when I was testing beca
Author: davidxl
Date: Tue Feb 9 14:02:59 2016
New Revision: 260270
URL: http://llvm.org/viewvc/llvm-project?rev=260270&view=rev
Log:
[PGO] Fix issue: explicitly defaulted assignop is not profiled
Differential Revision: http://reviews.llvm.org/D16947
Added:
cfe/trunk/test/Profile/def-as
This revision was automatically updated to reflect the committed changes.
Closed by commit rL260270: [PGO] Fix issue: explicitly defaulted assignop is
not profiled (authored by davidxl).
Changed prior to commit:
http://reviews.llvm.org/D16947?vs=47239&id=47351#toc
Repository:
rL LLVM
http:/
Author: rnk
Date: Tue Feb 9 13:53:30 2016
New Revision: 260267
URL: http://llvm.org/viewvc/llvm-project?rev=260267&view=rev
Log:
Pass /bigobj when building lib/ASTMatchers/Dynamic/Registry.cpp
This is the third time it has crossed the 2^16 section limit. We've
already spent time optimizing this
On Tue, Feb 9, 2016 at 11:44 AM, David Blaikie wrote:
>
>
> On Tue, Feb 9, 2016 at 11:41 AM, Xinliang David Li
> wrote:
>>
>> On Tue, Feb 9, 2016 at 11:30 AM, David Blaikie wrote:
>> >
>> >
>> > On Tue, Feb 9, 2016 at 11:26 AM, Xinliang David Li
>> > wrote:
>> >>
>> >> On Tue, Feb 9, 2016 at 11
Author: ehsan
Date: Tue Feb 9 13:43:13 2016
New Revision: 260266
URL: http://llvm.org/viewvc/llvm-project?rev=260266&view=rev
Log:
clang-cl: Enable plugins on Windows
Modified:
cfe/trunk/test/Frontend/plugins.c
cfe/trunk/test/lit.cfg
Modified: cfe/trunk/test/Frontend/plugins.c
URL:
htt
Author: ehsan
Date: Tue Feb 9 13:43:11 2016
New Revision: 260265
URL: http://llvm.org/viewvc/llvm-project?rev=260265&view=rev
Log:
clang-cl: Support loading plugins on Windows
This builds on the support being added to LLVM to import and export
registries from DLLs. This will allow us to pick up
On Tue, Feb 9, 2016 at 11:41 AM, Xinliang David Li
wrote:
> On Tue, Feb 9, 2016 at 11:30 AM, David Blaikie wrote:
> >
> >
> > On Tue, Feb 9, 2016 at 11:26 AM, Xinliang David Li
> > wrote:
> >>
> >> On Tue, Feb 9, 2016 at 11:14 AM, David Blaikie
> wrote:
> >> >
> >> >
> >> > On Mon, Feb 8, 2016
1 - 100 of 191 matches
Mail list logo
