pxli168 requested a review of this revision.
pxli168 added a comment.
Need to refine access qualifier with pipe type.
Comment at: lib/Sema/SemaDeclAttr.cpp:5052
@@ +5051,3 @@
+ if (D->hasAttr()) {
+S.Diag(D->getLocation(), diag::err_opencl_multiple_access_qualifiers)
+
pxli168 updated this revision to Diff 48046.
pxli168 marked 3 inline comments as done.
pxli168 added a comment.
Update doc for OpenCL access qualifier, still find where to handle access
qualifier for pipe type.
http://reviews.llvm.org/D16040
Files:
include/clang/Basic/Attr.td
include/clang
Hi Tim,
> -Original Message-
> From: tnortho...@apple.com [mailto:tnortho...@apple.com]
> Sent: Monday, February 15, 2016 5:43 PM
> To: Hahnfeld, Jonas
> Cc: cfe-commits@lists.llvm.org
> Subject: Re: r260755 - Darwin: pass -stdlib=libc++ down to cc1 whenever
> we're targeting libc++
>
> H
nikola added a comment.
Ping.
http://reviews.llvm.org/D15509
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nikola added a comment.
Ping.
http://reviews.llvm.org/D15588
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: akirtzidis
Date: Mon Feb 15 23:39:33 2016
New Revision: 260937
URL: http://llvm.org/viewvc/llvm-project?rev=260937&view=rev
Log:
[Frontend] Make sure WrapperFrontendAction updates CurrentInput after calling
BeginSourceFileAction.
I don't have a test case to add unfortunately.
Modified:
Author: chapuni
Date: Mon Feb 15 21:17:13 2016
New Revision: 260929
URL: http://llvm.org/viewvc/llvm-project?rev=260929&view=rev
Log:
clang/test/Driver/ps4-linker-win.c: Tweak substitutions if %PATH% ends with
'\\', or lit complains with "parser error".
Modified:
cfe/trunk/test/Driver/ps4-li
Author: vedantk
Date: Mon Feb 15 20:14:44 2016
New Revision: 260927
URL: http://llvm.org/viewvc/llvm-project?rev=260927&view=rev
Log:
Simplify users of StringRef::{l,r}trim (clang) (NFC)
r260925 introduced a version of the *trim methods which is preferable
when trimming a single kind of character
steven_watanabe created this revision.
steven_watanabe added reviewers: rsmith, eli.friedman.
steven_watanabe added a subscriber: cfe-commits.
Currently clang -cc1 -ast-print puts the struct
definition in the wrong place, like this:
struct {} typedef S;
The reason that this happens is th
manmanren added inline comments.
Comment at: lib/Sema/TypeLocBuilder.cpp:130
@@ +129,3 @@
+ else if (CurrentlyHasPadding) {
+// Remove 4-byte padding.
+memmove(&Buffer[Index + 4], &Buffer[Index], NumBytesAtAlign4);
Expand this comment a little
Thanks for the catch! Those checks aren’t necessary at all. I’ve removed them
in r260921.
> On Feb 14, 2016, at 1:08 PM, Duncan P. N. Exon Smith
> wrote:
>
>
>> On 2016-Feb-10, at 22:36, Akira Hatanaka via cfe-commits
>> wrote:
>>
>> Author: ahatanak
>> Date: Thu Feb 11 00:36:35 2016
>> Ne
Author: ahatanak
Date: Mon Feb 15 18:46:03 2016
New Revision: 260921
URL: http://llvm.org/viewvc/llvm-project?rev=260921&view=rev
Log:
Remove unnecessary regex in the test cases I fixed in r260496.
Modified:
cfe/trunk/test/CodeGenObjC/exceptions-asm-attribute.m
cfe/trunk/test/CodeGenObjC/
benlangmuir added a comment.
Okay, let's go with the two-path solution. Thanks!
http://reviews.llvm.org/D17104
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
> On 2016-Feb-10, at 19:10, Marshall Clow wrote:
>
> On Wed, Feb 10, 2016 at 2:46 PM, Duncan P. N. Exon Smith via cfe-commits
> wrote:
> I'm hoping only a year or two (or three...)?
>
> As I pointed out to Eric on IRC, those files have had a "deprecation warning"
> every time they are includ
ahatanak updated this revision to Diff 48033.
ahatanak added a comment.
The bug is in the handling of elements whose LocalAlignment is 8, so I've fixed
just that part.
I'll resend a patch to simplify the logic of TypeLocBuilder::pushImpl later as
it's not urgent.
http://reviews.llvm.org/D1684
hintonda added inline comments.
Comment at: lib/Sema/SemaTemplate.cpp:7848
@@ -7842,2 +7847,3 @@
+ }
}
}
Got it...
http://reviews.llvm.org/D17215
___
cfe-commits mailing list
cfe-commits@lis
hintonda updated this revision to Diff 48031.
hintonda added a comment.
- Added assert and additional test
http://reviews.llvm.org/D17215
Files:
lib/Sema/SemaTemplate.cpp
test/SemaCXX/pr14211-crash-on-invalid.cpp
Index: test/SemaCXX/pr14211-crash-on-invalid.cpp
jbcoe marked 2 inline comments as done.
jbcoe added a comment.
http://reviews.llvm.org/D16376
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jbcoe removed rL LLVM as the repository for this revision.
jbcoe updated this revision to Diff 48028.
jbcoe added a comment.
Minor fixes from review.
http://reviews.llvm.org/D16376
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/DeprecatedSpecialMemberGenerationCheck.cpp
clang-tidy/
timonvo added a comment.
Note that I avoided using a local macro at first because I didn't want to
export any additional symbols/macros from this file. But I've moved to use one
now. Note that I changed the name slightly to be more in line with libunwind's
naming (it uses _LIBUNWIND_ARM_EHABI a
timonvo updated this revision to Diff 48026.
timonvo added a comment.
Added local macro for enhanced readability.
http://reviews.llvm.org/D15883
Files:
lib/Headers/unwind.h
Index: lib/Headers/unwind.h
===
--- lib/Headers/unwind.
ayartsev added a comment.
Ping.
http://reviews.llvm.org/D16317
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjmccall added inline comments.
Comment at: lib/Sema/SemaTemplate.cpp:7845
@@ -7842,1 +7844,3 @@
+ } else
+NonTemplateMatch = Method;
}
hintonda wrote:
> rjmccall wrote:
> > Could you add an assertion here that NonTemplateMatch is sti
timonvo added a comment.
Hi compnerd, thanks for getting back to me. I've updated the code.
I was wondering though, where did you see @nbjoerg's comment? I couldn't find
any reference to it here or on cfe-commits.
http://reviews.llvm.org/D15883
__
timonvo updated this revision to Diff 48015.
timonvo added a comment.
Guard ARM EHABI enums using \#ifs (compnerd/nbjoerg's advice).
http://reviews.llvm.org/D15883
Files:
lib/Headers/unwind.h
Index: lib/Headers/unwind.h
===
---
compnerd added a comment.
It was on the mailing list, which won't show up on phabricator (email is still
the defacto review system).
Why not create a local macro and use that to make this easier to read?
#if defined(__arm__) && !defined(__USING_SJLJ_EXCEPTIONS__) &&
!defined(__ARM_DWARF_EH__
zaks.anna added a comment.
Please, test these changes.
Thanks!
Anna.
Comment at: C:/LLVM/llvm/tools/clang/utils/analyzer/CmpRuns.py:31
@@ -30,3 +30,3 @@
import plistlib
-import CmpRuns
+import CmpRuns # ?
ariccio wrote:
> This file imports itself?
>
> I wa
+ Mike
If you like this… Mike has been setting up a bot running it. Which is super
awesome!
-Chris
> On Feb 14, 2016, at 1:40 PM, Duncan P. N. Exon Smith
> wrote:
>
>>
>> On 2016-Feb-08, at 22:01, Chris Bieneman via cfe-commits
>> wrote:
>>
>> Author: cbieneman
>> Date: Tue Feb 9 00:01:
ariccio added a comment.
I've added a few comments where I think the changes are not quite clear.
Comment at: C:/LLVM/llvm/tools/clang/utils/analyzer/CmpRuns.py:159
@@ -147,3 +158,3 @@
if 'clang_version' in data:
-if self.clang_version == None:
+
ariccio added inline comments.
Comment at: C:/LLVM/llvm/tools/clang/utils/analyzer/CmpRuns.py:194
@@ -182,3 +193,3 @@
# Backward compatibility API.
-def loadResults(path, opts, root = "", deleteEmpty=True):
+def loadResults(path, opts, root="", deleteEmpty=True):
return load
ariccio added a comment.
In http://reviews.llvm.org/D17253#353000, @zaks.anna wrote:
> Not sure how you got these changes, but some of them seem wrong and some seem
> inconsistently applied.
>
> Has this been tested?
Not yet, I was toying with running the first SARD test under it, and read
th
ldionne updated this revision to Diff 48012.
ldionne added a comment.
Address some remaining issues:
- Rename __nth_element to __type_pack_element, as suggested by Richard Smith
- Fix template parameter position issue in createTypePackElementParameterList
AFAICT, the only remaining issue is whet
ariccio added a comment.
Whoops, forgot to submit my earlier comments. Responding to comments right
now...
Comment at: C:/LLVM/llvm/tools/clang/utils/analyzer/CmpRuns.py:31
@@ -30,3 +30,3 @@
import plistlib
-import CmpRuns
+import CmpRuns # ?
This file impo
hintonda added inline comments.
Comment at: lib/Sema/SemaTemplate.cpp:7845
@@ -7842,1 +7844,3 @@
+ } else
+NonTemplateMatch = Method;
}
rjmccall wrote:
> Could you add an assertion here that NonTemplateMatch is still null? That
> sh
compnerd added a subscriber: compnerd.
compnerd requested changes to this revision.
compnerd added a reviewer: compnerd.
compnerd added a comment.
This revision now requires changes to proceed.
These should be guarded by a check to ensure that they are not defined when
EHABI is not in effect at @
rjmccall added inline comments.
Comment at: lib/Sema/SemaTemplate.cpp:7845
@@ -7842,1 +7844,3 @@
+ } else
+NonTemplateMatch = Method;
}
Could you add an assertion here that NonTemplateMatch is still null? That
should definitely neve
timonvo added a comment.
Could someone please take a look at this patch as well as
http://reviews.llvm.org/D15781? Thanks!
http://reviews.llvm.org/D15883
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
Author: sylvestre
Date: Mon Feb 15 14:38:54 2016
New Revision: 260912
URL: http://llvm.org/viewvc/llvm-project?rev=260912&view=rev
Log:
fix an indent issue in the doc which causes sphinx to fail with some versions
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/readability-simplify-
zaks.anna requested changes to this revision.
zaks.anna added a comment.
This revision now requires changes to proceed.
Not sure how you got these changes, but some of them seem wrong and some seem
inconsistently applied.
Has this been tested?
Comment at: C:/LLVM/llvm/tools/cl
manmanren added a comment.
Thanks for working on this!
Manman
Comment at: lib/Sema/TypeLocBuilder.cpp:99
@@ +98,3 @@
+// element was pushed.
+RemoveOrInsertPadding = NumBytesAtAlign4 != 0;
+ }
This patch seems to do two things:
1> simplify the logic of
manmanren added a subscriber: manmanren.
manmanren added a comment.
Hi Akira,
Can you give a high-level explanation of how this patch fixes the problem? This
patch enforces that the capacity is 8-byte aligned, is it required to solve the
alignment issue here?
Thanks,
Manman
http://reviews.ll
LegalizeAdulthood added inline comments.
Comment at: test/clang-tidy/readability-non-const-parameter.cpp:3
@@ +2,3 @@
+
+// Currently the checker only warns about pointer arguments.
+//
How hard is it to extend it to references?
Certainly the confusion about what
LegalizeAdulthood added a subscriber: LegalizeAdulthood.
Comment at: docs/clang-tidy/checks/readability-non-const-parameter.rst:15
@@ +14,3 @@
+
+ // warning here; p should be const
+ char f1(char *p) {
With pointers, there are always two layers of constness:
LegalizeAdulthood added inline comments.
Comment at: docs/clang-tidy/checks/readability-ternary-operator.rst:10
@@ +9,3 @@
+And it gets transformed into::
+ (condition ? expression0 : expression1);
+
Why add the parentheses around the entire statement? They seem
aaron.ballman marked 2 inline comments as done.
aaron.ballman added a comment.
Ping
http://reviews.llvm.org/D15935
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added inline comments.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:4821
@@ +4820,3 @@
+/// initializer for i.
+AST_MATCHER(Expr, nullPointerConstant) {
+ return Matcher(
sbenza wrote:
> aaron.ballman wrote:
> > aaron.ballman wrote:
> > > s
joker.eph created this revision.
joker.eph added a reviewer: tejohnson.
joker.eph added a subscriber: cfe-commits.
Herald added a subscriber: joker.eph.
Use the new pipeline implemented in D17115
http://reviews.llvm.org/D17272
Files:
lib/CodeGen/BackendUtil.cpp
Index: lib/CodeGen/BackendUtil.
aaron.ballman added a comment.
A few minor nits, but one question (to me) remains: should this be in misc, or
is this a cppcoreguideline? I think the check, as is, is acceptable (and can
possibly be extended to be a rule-of-five check aliased under
cppcoreguidelines), but wanted to understand o
hintonda added a comment.
Btw, I don't have commit access, so if accepted, could you please commit for me.
http://reviews.llvm.org/D17215
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
hintonda updated this revision to Diff 47999.
hintonda added a comment.
- Renamed variables to make code self-documenting
http://reviews.llvm.org/D17215
Files:
lib/Sema/SemaTemplate.cpp
test/SemaCXX/pr14211-crash-on-invalid.cpp
Index: test/SemaCXX/pr14211-crash-on-invalid.cpp
=
aaboud updated this revision to Diff 47997.
aaboud marked an inline comment as done.
aaboud added a comment.
Applied Adrian comment.
http://reviews.llvm.org/D16135
Files:
include/clang/AST/ASTConsumer.h
lib/AST/ASTConsumer.cpp
lib/CodeGen/CGDebugInfo.cpp
lib/CodeGen/CGDebugInfo.h
lib/
rjmccall added inline comments.
Comment at: lib/Sema/SemaTemplate.cpp:7829
@@ -7828,2 +7828,3 @@
UnresolvedSet<8> Matches;
+ FunctionDecl *Specialization = nullptr;
TemplateSpecCandidateSet FailedCandidates(D.getIdentifierLoc());
Please name this variable N
uweigand added a subscriber: uweigand.
uweigand added a comment.
I'm not sure this is the right approach. In any case, it differs from how the
option is handled in GCC.
-mzvector enables the language *syntax* extension, i.e. allows use of the
"vector unsigned int" etc. data types. Note that t
carlo.bertolli set the repository for this revision to rL LLVM.
carlo.bertolli updated this revision to Diff 47995.
carlo.bertolli added a comment.
Added comment for boolean parameter.
Repository:
rL LLVM
http://reviews.llvm.org/D17148
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/C
carlo.bertolli marked an inline comment as done.
carlo.bertolli added a comment.
I updated the patch to reflect the comments. I will wait for an answer to the
comment asking to split the emit function for push_num_teams. Thanks!
Comment at: lib/CodeGen/CGOpenMPRuntime.h:1009-10
Hi Jonas,
Thanks for looking at the patch!
> On 13 Feb 2016, at 01:26, Hahnfeld, Jonas wrote:
> as I did the change: Sorry that it broke for you on Darwin! I could not test
> myself and there doesn't seem to be a build-bot…
No worries. I think it only triggered in the stage 2 Green Dragon bots
Author: tnorthover
Date: Mon Feb 15 10:38:10 2016
New Revision: 260898
URL: http://llvm.org/viewvc/llvm-project?rev=260898&view=rev
Log:
Darwin: fix stdlib handling when CLANG_DEFAULT_STDLIB is set
I'd accidentally skipped the CMake check in a premature optimisation. I'd also
put the original tes
Hal Finkel wrote on 15.02.2016 16:30:15:
> > Hmm, it looks like Nemanja already added this:
> >
> > SingleSource/UnitTests/C++11/ stdthreadbug.cpp
> >
> > But the test is restricted to run only on ppc64le:
> >
> > #if defined(_LITTLE_ENDIAN) && defined(__PPC64__)
> > ...
> >
> > I think there's n
danielmarjamaki added a comment.
In http://reviews.llvm.org/D15332#352556, @danielmarjamaki wrote:
>
> I see no warning when running on Clang source code (files in
> llvm/tools/clang/lib/...).
For information I rerun with --header-filter=* and got some results.. I will
triage those..
ht
- Original Message -
> From: "Ulrich Weigand"
> To: "Hal Finkel"
> Cc: cfe-commits@lists.llvm.org
> Sent: Monday, February 15, 2016 9:06:42 AM
> Subject: Re: r259931 - [SystemZ] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP
> macros
>
>
>
> Hal Finkel wrote on 09.02.2016 18:16:21:
>
> > >
Hal Finkel wrote on 09.02.2016 18:16:21:
> > I guess any application that uses C++11 threads should show this
> > problem immediately.
>
> I'm not sure we have anything like that in our test suite. Could you
> add a simple test?
Hmm, it looks like Nemanja already added this:
SingleSource/UnitTe
jmolloy added a comment.
Hi Pawel,
Thanks for this - it generally looks good to me. Just one comment.
James
Comment at: lib/Target/AArch64/InstPrinter/AArch64InstPrinter.h:107
@@ -106,3 @@
- template
- void printAMIndexedWB(const MCInst *MI, unsigned OpNum,
-
jmolloy resigned from this revision.
jmolloy removed a reviewer: jmolloy.
jmolloy added a comment.
I'm not the right person to review this.
http://reviews.llvm.org/D16586
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
aaboud updated this revision to Diff 47988.
aaboud added a comment.
Simplified LIT tests according to David comment.
http://reviews.llvm.org/D15977
Files:
lib/CodeGen/CGDebugInfo.cpp
lib/CodeGen/CGDebugInfo.h
lib/CodeGen/CGDecl.cpp
test/CodeGenCXX/debug-info-lb.cpp
Index: lib/CodeGen/C
On Sun, Feb 14, 2016 at 11:00 PM, Felix Berger via cfe-commits
wrote:
> Author: flx
> Date: Sun Feb 14 22:00:39 2016
> New Revision: 260872
>
> URL: http://llvm.org/viewvc/llvm-project?rev=260872&view=rev
> Log:
> Add isAnyPointer() matchers. Register missing matchers.
>
> Summary:
> The isAnyPoin
Hi Hans,
Could we please add the description of OpenCL support into the release notes?
It covers a larger time frame than just the current release but since it hasn't
been in the release notes before, I hope it's fine. It would be good to inform
what we were working on in the past.
I propose t
Author: asbokhan
Date: Mon Feb 15 04:44:27 2016
New Revision: 260882
URL: http://llvm.org/viewvc/llvm-project?rev=260882&view=rev
Log:
PR26449: Tests for builtin_classify_type fix
In my previous commit (rL260881) I forget to svn add tests. This commit adds
them.
Differential Revision: http://rev
andreybokhanko added a comment.
John, thank you for all these tireless re-reviews -- very much appreciated!
Yours,
Andrey
Repository:
rL LLVM
http://reviews.llvm.org/D16846
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
This revision was automatically updated to reflect the committed changes.
Closed by commit rL260881: PR26449: Fixes for bugs in __builtin_classify_type
implementation (authored by asbokhan).
Changed prior to commit:
http://reviews.llvm.org/D16846?vs=47475&id=47966#toc
Repository:
rL LLVM
ht
Author: asbokhan
Date: Mon Feb 15 04:39:04 2016
New Revision: 260881
URL: http://llvm.org/viewvc/llvm-project?rev=260881&view=rev
Log:
PR26449: Fixes for bugs in __builtin_classify_type implementation
This patch fixes the following bugs in __builtin_classify_type implementation:
1) Support for me
danielmarjamaki updated this revision to Diff 47962.
danielmarjamaki added a comment.
Run this check on C++ code also. I have rerun the add_new_check python script.
Minor code cleanups.
I have run this on the debian packages again. In 1806 projects there were 9691
warnings. I have so far triage
AndyG added a comment.
Richard, are you happy with this latest version? Can I proceed to commit it?
Thanks.
http://reviews.llvm.org/D15636
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
hokein marked an inline comment as done.
Comment at:
test/clang-tidy/readability-braces-around-statements-assert-failure.cpp:1
@@ -1,2 +1,2 @@
-// RUN: %check_clang_tidy %s readability-braces-around-statements %t
+// RUN: clang-tidy -checks='-*,readability-braces-around-statement
hokein updated this revision to Diff 47959.
hokein marked an inline comment as done.
hokein added a comment.
Minimize test case.
http://reviews.llvm.org/D17134
Files:
clang-tidy/readability/BracesAroundStatementsCheck.cpp
test/clang-tidy/readability-braces-around-statements-assert-failure.c
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.h:1009-1015
@@ +1008,9 @@
+
+ /// \brief Emits call to void __kmpc_push_num_teamss(ident_t *loc, kmp_int32
+ /// global_tid, kmp_int32 num_teams, kmp_int32 thread_limit) to generate code
+ /// for num_teams
ABataev added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:2937-2943
@@ -2936,2 +2936,9 @@
QualType BaseTy = Base.getType();
+ // If the base is a pointer, we actually need to compute the offset in the
+ // pointee.
+ if (BaseTy->isAnyPointerType()) {
+auto RBase
Am Tuesday 09 February 2016, 17:06:58 schrieb Richard Smith:
> On Thu, Feb 4, 2016 at 3:17 PM, Niels Ole Salscheider via cfe-commits
>
> wrote:
> > Author: olesalscheider
> > Date: Thu Feb 4 17:17:20 2016
> > New Revision: 259842
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=259842&view=
Author: abataev
Date: Mon Feb 15 02:07:17 2016
New Revision: 260877
URL: http://llvm.org/viewvc/llvm-project?rev=260877&view=rev
Log:
[OPENMP] Remove extra sync barriers for 'firstprivate' clause.
Sync barrier will be emitted after generation of firstprivate variables
only if one of the firstpriva
78 matches
Mail list logo
