r262817 - [CLANG][AVX512][BUILTIN] Adding vpmultishiftqb{128|256|512}

Author: mzuckerm Date: Mon Mar 7 02:29:10 2016 New Revision: 262817 URL: http://llvm.org/viewvc/llvm-project?rev=262817&view=rev Log: [CLANG][AVX512][BUILTIN] Adding vpmultishiftqb{128|256|512} Differential Revision: http://reviews.llvm.org/D17914 Modified: cfe/trunk/include/clang/Basic/Bu

r262818 - [MS ABI] Mangle symbols names longer than 4096 characters correctly

Author: majnemer Date: Mon Mar 7 02:51:17 2016 New Revision: 262818 URL: http://llvm.org/viewvc/llvm-project?rev=262818&view=rev Log: [MS ABI] Mangle symbols names longer than 4096 characters correctly Really long symbols are hashed using MD5 and prefixed/suffixed with the usual sigils. There i

Re: [PATCH] D17762: Fix an assertion failure in setPointOfInstantiation.

hokein added a comment. In http://reviews.llvm.org/D17762#367182, @bkramer wrote: > This doesn't look right to me. Aborting tree transform on a bad source > location seems just wrong. Where is the invalid source location coming from? > Also the backtrace seems related to typo correction, maybe

r262820 - [CLANG][AVX512][BUILTIN] Adding new feature flag header file and new builtin vpmadd52{h|l}uq{128|256|512}{mask|maskz}

Author: mzuckerm Date: Mon Mar 7 03:55:55 2016 New Revision: 262820 URL: http://llvm.org/viewvc/llvm-project?rev=262820&view=rev Log: [CLANG][AVX512][BUILTIN] Adding new feature flag header file and new builtin vpmadd52{h|l}uq{128|256|512}{mask|maskz} Differential Revision: http://reviews.llvm.

Re: [PATCH] D17762: Fix an assertion failure in setPointOfInstantiation.

hokein updated this revision to Diff 49939. hokein added a comment. Update. http://reviews.llvm.org/D17762 Files: lib/Sema/SemaExpr.cpp test/Sema/PR25668.cpp Index: test/Sema/PR25668.cpp === --- /dev/null +++ test/Sema/PR25668

Re: [modules] PR24954

ping... On 22/02/16 21:51, Vassil Vassilev wrote: On 02/02/16 02:52, Richard Smith via cfe-commits wrote: On Thu, Jan 28, 2016 at 8:23 AM, Vassil Vassilev wrote: Would this patch be more reasonable? It follows what RegisterTemplateSpecialization (introduced in r245779) does. AFAICT this adds

Re: [PATCH] D17762: Fix an assertion failure in setPointOfInstantiation.

bkramer added a comment. I'm still not sure if this is the right way to fix it. Maybe @rsmith has an opinion? http://reviews.llvm.org/D17762 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

Re: [PATCH] D17766: [ms-inline-asm][AVX512] Add ability to use k registers in MS inline asm + fix bag with curly braces

myatsina added a subscriber: cfe-commits. myatsina updated this revision to Diff 49945. myatsina marked an inline comment as done. myatsina added a comment. Updated test to reflect changes in the llvm part of the review (http://reviews.llvm.org/D17767) Repository: rL LLVM http://reviews.llvm

Re: [PATCH] D17764: Add attributes for AMD GPU Tools

tstellarAMD added inline comments. Comment at: include/clang/Basic/AttrDocs.td:969-973 @@ +968,7 @@ + +Clang supports the ``__attribute__((amdgpu_tools_num_reserved_vgpr()))`` +attribute on AMD Southern Islands GPUs and later. If specified, it causes AMD +GPU Backend to reserve ``

Re: [PATCH] D17811: [clang-tidy] Add check to detect dangling references in value handlers.

alexfh added inline comments. Comment at: clang-tidy/misc/DanglingHandleCheck.cpp:24 @@ +23,3 @@ + +std::vector parseClasses(StringRef Option) { + SmallVector Classes; A very similar code has been added recently to clang-tidy/utils/HeaderFileExtensionsUtils.*. M

Re: [PATCH] D17926: [clang-tidy] Don't delete unused parameter in class override method in anonymous namespace.

alexfh added inline comments. Comment at: clang-tidy/misc/UnusedParametersCheck.cpp:20 @@ +19,3 @@ +namespace { +bool isOverrideMethod(const FunctionDecl *Function) { + if (const auto *MD = dyn_cast(Function)) There's a matcher for this: `isOverride`. Repositor

Re: [PATCH] D17908: Add Visual Studio Visualizers for more Clang types

aaron.ballman added inline comments. Comment at: clang.natvis:1-3 @@ -1,4 +1,4 @@

Re: [PATCH] D17853: Disable tail-call optimization for X86 interrupt handlers

This revision was automatically updated to reflect the committed changes. Closed by commit rL262830: Resolved Bug 26414. (authored by aaboud). Changed prior to commit: http://reviews.llvm.org/D17853?vs=49746&id=49953#toc Repository: rL LLVM http://reviews.llvm.org/D17853 Files: cfe/trunk/

r262830 - Resolved Bug 26414.

Author: aaboud Date: Mon Mar 7 08:22:46 2016 New Revision: 262830 URL: http://llvm.org/viewvc/llvm-project?rev=262830&view=rev Log: Resolved Bug 26414. https://llvm.org/bugs/show_bug.cgi?id=26414 Since interrupt handler must be returned with iret, tail call can't be used. Differential Revision:

Re: [PATCH] D17446: ASTMatchers: add new statement/decl matchers

aaron.ballman added inline comments. Comment at: docs/LibASTMatchersReference.html:512 @@ +511,3 @@ +MatcherStmt>addrLabelExprMatcherAddrLabelExpr>... +Matche

Re: [PATCH] D17926: [clang-tidy] Don't delete unused parameter in class override method in anonymous namespace.

hokein updated this revision to Diff 49954. hokein added a comment. Use internal isOverride method. http://reviews.llvm.org/D17926 Files: clang-tidy/misc/UnusedParametersCheck.cpp test/clang-tidy/misc-unused-parameters.cpp Index: test/clang-tidy/misc-unused-parameters.cpp =

Re: [PATCH] D17926: [clang-tidy] Don't delete unused parameter in class override method in anonymous namespace.

hokein marked an inline comment as done. hokein added a comment. http://reviews.llvm.org/D17926 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16376: clang-tidy check: misc-deprecated-special-member-functions

aaron.ballman added a comment. In http://reviews.llvm.org/D16376#360527, @jbcoe wrote: > The Sema diagnostic warning is only produced if a deprecated special member > function is used whereas I want to find places where it would be > compiler-generated and explicitly delete them. This is useful

Re: [PATCH] D17926: [clang-tidy] Don't delete unused parameter in class override method in anonymous namespace.

alexfh added inline comments. Comment at: clang-tidy/misc/UnusedParametersCheck.cpp:80 @@ +79,3 @@ + UsedByRef() || + !ast_matchers::match(cxxMethodDecl(isOverride()), *Function, + *Result.Context) I meant, you can use it inside

Re: [PATCH] D17908: Add Visual Studio Visualizers for more Clang types

Better yet, just delete the number On Mon, Mar 7, 2016 at 6:21 AM Aaron Ballman wrote: > aaron.ballman added inline comments. > > > Comment at: clang.natvis:1-3 > @@ -1,4 +1,4 @@ > > Do you know if these visualizers will work in MSVC 2013 as well, or are > you using MSVC 2015

Re: [PATCH] D17908: Add Visual Studio Visualizers for more Clang types

zturner added a subscriber: zturner. zturner added a comment. Better yet, just delete the number http://reviews.llvm.org/D17908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17908: Add Visual Studio Visualizers for more Clang types

aaron.ballman added a comment. In http://reviews.llvm.org/D17908#368969, @zturner wrote: > Better yet, just delete the number The number is sort of helpful since it's the only documentation as to what least common denominator we support. I don't have a strong attachment to the number, however

Re: [PATCH] D17908: Add Visual Studio Visualizers for more Clang types

zturner added a comment. Natvis has hardly changed at all since it was introduced, so I'm guessing the lowest common denominator is always going to be our minimum required VS version http://reviews.llvm.org/D17908 ___ cfe-commits mailing list cfe-co

Re: [PATCH] D17908: Add Visual Studio Visualizers for more Clang types

Natvis has hardly changed at all since it was introduced, so I'm guessing the lowest common denominator is always going to be our minimum required VS version On Mon, Mar 7, 2016 at 7:09 AM Aaron Ballman wrote: > aaron.ballman added a comment. > > In http://reviews.llvm.org/D17908#368969, @zturner

Re: [PATCH] D17908: Add Visual Studio Visualizers for more Clang types

aaron.ballman added a comment. In http://reviews.llvm.org/D17908#368972, @zturner wrote: > Natvis has hardly changed at all since it was introduced, so I'm guessing > the lowest common denominator is always going to be our minimum required VS > version Awesome! Sold on removing the date. htt

Re: [PATCH] D17567: [GCC] PR23529 Sema part of attrbute abi_tag support

aaron.ballman added inline comments. Comment at: docs/ItaniumMangleAbiTags.rst:2 @@ +1,3 @@ + +Abi Tags + ABI tags (since it's an acronym). Elsewhere as well. Comment at: docs/ItaniumMangleAbiTags.rst:30 @@ +29,3 @@ + +All tags th

Re: [PATCH] D17908: Add Visual Studio Visualizers for more Clang types

mspertus added a comment. I believe that it will all work on VS2013 (and have kicked off a build to confirm). I guess I would rather drop the number so it doesn't get out of sync whenever the base compiler version changes. http://reviews.llvm.org/D17908 _

Re: [PATCH] D16993: Add missing __builtin_bitreverse8

arsenm retitled this revision from "Add documentation for bitreverse builtins" to "Add missing __builtin_bitreverse8". arsenm updated the summary for this revision. arsenm updated this revision to Diff 49960. http://reviews.llvm.org/D16993 Files: docs/LanguageExtensions.rst include/clang/Bas

Re: [PATCH] D16529: [clang-tidy] Add modernize-raw-string-literal check

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In http://reviews.llvm.org/D16529#366433, @LegalizeAdulthood wrote: > Squeak. This has been waiting on review for over two weeks Sorry for the delay, I was at WG21 meetings

Re: [PATCH] D16971: [Sema] PR26077 Fixed crash when partial specialization is missing required parameters

hintonda added a comment. ping... http://reviews.llvm.org/D16971 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D17933: Set MaxAtomicInlineWidth properly for i386, i486, and x86-64 cpus without cmpxchg16b.

jyknight created this revision. jyknight added a reviewer: t.p.northover. jyknight added a subscriber: cfe-commits. Herald added subscribers: dschuff, jfb, aemerson. Also, remove all the manual definition of __GCC_HAVE_SYNC_COMPARE_AND_SWAP_* macros. Instead, define it based on MaxAtomicInlineWidt

r262832 - Reapply r262741 [OPENMP] Codegen for distribute directive

Author: cbertol Date: Mon Mar 7 10:04:49 2016 New Revision: 262832 URL: http://llvm.org/viewvc/llvm-project?rev=262832&view=rev Log: Reapply r262741 [OPENMP] Codegen for distribute directive This patch provide basic implementation of codegen for teams directive, excluding all clauses except dis

Re: [PATCH] D17248: [Sema] PR26444 fix crash when alignment value is >= 2**16

hintonda added a comment. I don't have commit access, so could someone commit for me. Thanks... http://reviews.llvm.org/D17248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r262833 - [OPENMP] Codegen for distribute directive: fix bug in ordering of parameters.

Author: cbertol Date: Mon Mar 7 10:19:13 2016 New Revision: 262833 URL: http://llvm.org/viewvc/llvm-project?rev=262833&view=rev Log: [OPENMP] Codegen for distribute directive: fix bug in ordering of parameters. Modified: cfe/trunk/lib/CodeGen/CGStmtOpenMP.cpp Modified: cfe/trunk/lib/CodeGen

Re: [PATCH] D17926: [clang-tidy] Don't delete unused parameter in class override method in anonymous namespace.

hokein added inline comments. Comment at: clang-tidy/misc/UnusedParametersCheck.cpp:80 @@ +79,3 @@ + UsedByRef() || + !ast_matchers::match(cxxMethodDecl(isOverride()), *Function, + *Result.Context) alexfh wrote: > I meant, you c

Re: [PATCH] D17002: [lanai] Add Lanai backend to clang driver

jpienaar updated this revision to Diff 49969. jpienaar added a comment. Updated to use resetDataLayout. http://reviews.llvm.org/D17002 Files: lib/Basic/Targets.cpp lib/CodeGen/TargetInfo.cpp lib/Driver/Driver.cpp lib/Driver/ToolChains.h lib/Driver/Tools.cpp lib/Driver/Tools.h test

Re: [PATCH] D17248: [Sema] PR26444 fix crash when alignment value is >= 2**16

majnemer closed this revision. majnemer added a comment. I committed this a few days ago in http://reviews.llvm.org/rL262466. Closing this differential. http://reviews.llvm.org/D17248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://

r262834 - [CLANG][AVX512][BUILTIN] Adding new feature flag headed files and new BUILTIN vpermi2varq{i|t}{128|256|512}{mask|maskz}

Author: mzuckerm Date: Mon Mar 7 11:04:11 2016 New Revision: 262834 URL: http://llvm.org/viewvc/llvm-project?rev=262834&view=rev Log: [CLANG][AVX512][BUILTIN] Adding new feature flag headed files and new BUILTIN vpermi2varq{i|t}{128|256|512}{mask|maskz} Differential Revision: http://reviews.llv

Re: [PATCH] D17248: [Sema] PR26444 fix crash when alignment value is >= 2**16

hintonda added a comment. Great, thanks David. http://reviews.llvm.org/D17248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r262837 - Describe the magic numbers returned by getEHDataRegisterNumber.

Author: joerg Date: Mon Mar 7 11:18:41 2016 New Revision: 262837 URL: http://llvm.org/viewvc/llvm-project?rev=262837&view=rev Log: Describe the magic numbers returned by getEHDataRegisterNumber. Modified: cfe/trunk/include/clang/Basic/TargetInfo.h Modified: cfe/trunk/include/clang/Basic/Tar

r262838 - Implement __builtin_eh_return_data_regno for SPARC and SPARC64.

Author: joerg Date: Mon Mar 7 11:19:15 2016 New Revision: 262838 URL: http://llvm.org/viewvc/llvm-project?rev=262838&view=rev Log: Implement __builtin_eh_return_data_regno for SPARC and SPARC64. Added: cfe/trunk/test/CodeGen/builtins-sparc.c Modified: cfe/trunk/lib/Basic/Targets.cpp Mod

Re: r262838 - Implement __builtin_eh_return_data_regno for SPARC and SPARC64.

On Mon, Mar 07, 2016 at 05:19:16PM -, Joerg Sonnenberger via cfe-commits wrote: > Author: joerg > Date: Mon Mar 7 11:19:15 2016 > New Revision: 262838 > > URL: http://llvm.org/viewvc/llvm-project?rev=262838&view=rev > Log: > Implement __builtin_eh_return_data_regno for SPARC and SPARC64. Ha

r262842 - [ms-inline-asm][AVX512] Add ability to use k registers in MS inline asm + fix bag with curly braces

Author: myatsina Date: Mon Mar 7 12:10:25 2016 New Revision: 262842 URL: http://llvm.org/viewvc/llvm-project?rev=262842&view=rev Log: [ms-inline-asm][AVX512] Add ability to use k registers in MS inline asm + fix bag with curly braces Until now curly braces could only be used in MS inline assemb

Re: [PATCH] D17766: [ms-inline-asm][AVX512] Add ability to use k registers in MS inline asm + fix bag with curly braces

This revision was automatically updated to reflect the committed changes. Closed by commit rL262842: [ms-inline-asm][AVX512] Add ability to use k registers in MS inline asm + fix… (authored by myatsina). Changed prior to commit: http://reviews.llvm.org/D17766?vs=49945&id=49978#toc Repository:

r262845 - python binding: expose compile command filename

Author: papin_g Date: Mon Mar 7 12:44:42 2016 New Revision: 262845 URL: http://llvm.org/viewvc/llvm-project?rev=262845&view=rev Log: python binding: expose compile command filename Reviewers: compnerd, skalinichev Differential Revision: http://reviews.llvm.org/D17278 Modified: cfe/trunk/bi

r262847 - [CLANG][AVX512][BUILTIN] Add builtin vcomi{ss|sd}

Author: mzuckerm Date: Mon Mar 7 13:15:00 2016 New Revision: 262847 URL: http://llvm.org/viewvc/llvm-project?rev=262847&view=rev Log: [CLANG][AVX512][BUILTIN] Add builtin vcomi{ss|sd} Differential Revision: http://reviews.llvm.org/D17919 Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.

Re: [PATCH] D16993: Add missing __builtin_bitreverse8

arsenm added a comment. I directly copied this from the bit reverse intrinsic documentation, so that will need to be fixed too From: Arthur O'Dwyer Sent: Monday, March 7, 2016 11:56 AM To: reviews+http://reviews.llvm.org/d16993+public+3e6e84ed28c57...@reviews.

Re: [PATCH] D16044: getVariableName() for MemRegion

Alexander_Droste added a comment. Hi Devin, thanks for taking the time! Yes, this is kind of implicitly tested by the MPI patch but I agree that it is necessary to add tests to MemRegion. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:160 @@ -153,1 +159

Re: [PATCH] D17764: Add attributes for AMD GPU Tools

kzhuravl-AMD marked 2 inline comments as done. kzhuravl-AMD added a comment. http://reviews.llvm.org/D17764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17764: Add attributes for AMD GPU Tools

kzhuravl-AMD updated this revision to Diff 49990. kzhuravl-AMD added a comment. Review Feedback - Updated diff http://reviews.llvm.org/D17764 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def li

r262851 - Module Debugging: Fix a crash when emitting debug info for nested tag types

Author: adrian Date: Mon Mar 7 14:58:52 2016 New Revision: 262851 URL: http://llvm.org/viewvc/llvm-project?rev=262851&view=rev Log: Module Debugging: Fix a crash when emitting debug info for nested tag types whose DeclContext is not yet complete by deferring their emission. rdar://problem/249186

Re: [PATCH] D16044: getVariableName() for MemRegion

dcoughlin added inline comments. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:160 @@ -153,1 +159,3 @@ + /// \returns variable name for memory region + std::string getVariableName() const; }; Alexander_Droste wrote: > dcoughlin wrote:

[libcxx] r262866 - non-member swap for array was mistakenly taking const ref params. Fixed and added test. Thanks to Ben Craig for the catch

Author: marshall Date: Mon Mar 7 15:57:10 2016 New Revision: 262866 URL: http://llvm.org/viewvc/llvm-project?rev=262866&view=rev Log: non-member swap for array was mistakenly taking const ref params. Fixed and added test. Thanks to Ben Craig for the catch Modified: libcxx/trunk/include/arra

Re: [PATCH] D17700: [clang-format] Proposal for changes to Objective-C block formatting

tonyarnold added a comment. > Blocks aren't the same as braces Yeah, good point. I guess I was just seeing the brace in the block, but that's the wrong way to think about it. http://reviews.llvm.org/D17700 ___ cfe-commits mailing list cfe-commits

[PATCH] D17941: add fix-its for format-security warnings

bob.wilson created this revision. bob.wilson added reviewers: bcraig, rjmccall, dblaikie. bob.wilson added a subscriber: cfe-commits. Herald added a subscriber: mcrosier. The format-security warning is a special case of format-nonliteral that applies when there are no arguments besides the format

[libcxx] r262871 - Implement P0025R0: 'An algorithm to clamp a value between a pair of boundary values' for C++17

Author: marshall Date: Mon Mar 7 16:43:49 2016 New Revision: 262871 URL: http://llvm.org/viewvc/llvm-project?rev=262871&view=rev Log: Implement P0025R0: 'An algorithm to clamp a value between a pair of boundary values' for C++17 Added: libcxx/trunk/test/std/algorithms/alg.sorting/alg.clamp/

r262872 - Implement support for [[nodiscard]] in C++1z that is based off existing support for warn_unused_result, and treat it as an extension pre-C++1z. This also means extending the existing warn_un

Author: aaronballman Date: Mon Mar 7 16:44:55 2016 New Revision: 262872 URL: http://llvm.org/viewvc/llvm-project?rev=262872&view=rev Log: Implement support for [[nodiscard]] in C++1z that is based off existing support for warn_unused_result, and treat it as an extension pre-C++1z. This also mean

Re: [PATCH] D17811: [clang-tidy] Add check to detect dangling references in value handlers.

sbenza added inline comments. Comment at: clang-tidy/misc/DanglingHandleCheck.cpp:24 @@ +23,3 @@ + +std::vector parseClasses(StringRef Option) { + SmallVector Classes; alexfh wrote: > A very similar code has been added recently to > clang-tidy/utils/HeaderFileEx

Re: [PATCH] D17811: [clang-tidy] Add check to detect dangling references in value handlers.

sbenza updated this revision to Diff 49998. sbenza marked 3 inline comments as done. sbenza added a comment. Minor fixes http://reviews.llvm.org/D17811 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/DanglingHandleCheck.cpp clang-tidy/misc/DanglingHandleCheck.h clang-tidy/misc/Mis

Re: [PATCH] D15729: Load compiler plugins in ASTUnit, too

kfunk updated this revision to Diff 4. kfunk added a comment. This revision is now accepted and ready to land. Remove TODO statement http://reviews.llvm.org/D15729 Files: include/clang/Frontend/CompilerInstance.h lib/Frontend/ASTUnit.cpp lib/Frontend/CompilerInstance.cpp lib/Fronten

Re: [PATCH] D15921: [analyzer] Utility to match function calls.

zaks.anna added a comment. > Side note: Has anybody ever considered just treating fopen and fclose like > malloc and free? Yes, there are a few checkers that follow the same open/close rule and could in theory be merged together. Comment at: cfe/trunk/lib/StaticAnalyzer/Chec

Re: [PATCH] D15729: Load compiler plugins in ASTUnit, too

kfunk added a comment. Okay, just gave this another look. Unit test seems fine as-is. Let's call `loadPlugins` there explicitly. @LLVM/Clang devs: Please review! I'm especially interested in whether you think there's a better location for calling `CompilerInstance::loadPlugins` than in `ASTUni

Re: [PATCH] D17908: Add Visual Studio Visualizers for more Clang types

mspertus added a comment. Hmm, testing reveals that the preexisting clang.natvis does not work in VS2013! Natvis: E:\Users\mspertus\Documents\Visual Studio 2013\Visualizers\clang.natvis(59,21): Error: identifier "clang::TypeAlignmentInBits" is undefined If I change all clang.natvis occurrenc

Re: [PATCH] D17908: Add Visual Studio Visualizers for more Clang types

aaron.ballman added a comment. In http://reviews.llvm.org/D17908#369337, @mspertus wrote: > Hmm, testing reveals that the preexisting clang.natvis does not work in > VS2013! > > Natvis: E:\Users\mspertus\Documents\Visual Studio > 2013\Visualizers\clang.natvis(59,21): Error: identifier > "cla

[PATCH] D17947: [Driver] [Darwin] Fix linking libclang_rt.profile_*sim.a

beanz created this revision. beanz added reviewers: zaks.anna, bogner. beanz added a subscriber: cfe-commits. isTarget*() calls are order-dependent. This is because iOS Sim *is* iOS. This means checks for the simulator version of the platform must always be ahead of checks for the embedded platf

r262881 - P0188R1: add support for standard [[fallthrough]] attribute. This is almost

Author: rsmith Date: Mon Mar 7 18:32:55 2016 New Revision: 262881 URL: http://llvm.org/viewvc/llvm-project?rev=262881&view=rev Log: P0188R1: add support for standard [[fallthrough]] attribute. This is almost exactly the same as clang's existing [[clang::fallthrough]] attribute, which has been upd

r262882 - Add accidentally forgotten testcase from r262881.

Author: rsmith Date: Mon Mar 7 18:34:49 2016 New Revision: 262882 URL: http://llvm.org/viewvc/llvm-project?rev=262882&view=rev Log: Add accidentally forgotten testcase from r262881. Added: cfe/trunk/test/CXX/dcl.dcl/dcl.attr/dcl.attr.fallthrough/ cfe/trunk/test/CXX/dcl.dcl/dcl.attr/dcl.a

r262887 - Define __has_cpp_attribute(fallthrough) to a more reasonable value. (What year is it?!)

Author: rsmith Date: Mon Mar 7 18:40:32 2016 New Revision: 262887 URL: http://llvm.org/viewvc/llvm-project?rev=262887&view=rev Log: Define __has_cpp_attribute(fallthrough) to a more reasonable value. (What year is it?!) Modified: cfe/trunk/include/clang/Basic/Attr.td cfe/trunk/test/Prep

r262888 - Move [[nodiscard]] tests into test/CXX tree.

Author: rsmith Date: Mon Mar 7 18:44:49 2016 New Revision: 262888 URL: http://llvm.org/viewvc/llvm-project?rev=262888&view=rev Log: Move [[nodiscard]] tests into test/CXX tree. Added: cfe/trunk/test/CXX/dcl.dcl/dcl.attr/dcl.attr.nodiscard/ cfe/trunk/test/CXX/dcl.dcl/dcl.attr/dcl.attr.nod

r262889 - Use class="svn" for features with SVN status.

Author: rsmith Date: Mon Mar 7 18:45:37 2016 New Revision: 262889 URL: http://llvm.org/viewvc/llvm-project?rev=262889&view=rev Log: Use class="svn" for features with SVN status. Modified: cfe/trunk/www/cxx_status.html Modified: cfe/trunk/www/cxx_status.html URL: http://llvm.org/viewvc/llvm

r262894 - [analyzer] Fix missed leak from MSVC specific allocation functions

Author: zaks Date: Mon Mar 7 19:21:51 2016 New Revision: 262894 URL: http://llvm.org/viewvc/llvm-project?rev=262894&view=rev Log: [analyzer] Fix missed leak from MSVC specific allocation functions Add the wide character strdup variants (wcsdup, _wcsdup) and the MSVC version of alloca (_alloca) a

Re: [PATCH] D17688: Fix missed leak from MSVC specific allocation functions

This revision was automatically updated to reflect the committed changes. Closed by commit rL262894: [analyzer] Fix missed leak from MSVC specific allocation functions (authored by zaks). Changed prior to commit: http://reviews.llvm.org/D17688?vs=49845&id=50013#toc Repository: rL LLVM http:

Re: [PATCH] D17947: [Driver] [Darwin] Fix linking libclang_rt.profile_*sim.a

zaks.anna added a comment. You should be able to use the switch like in Darwin::getOSLibraryNameSuffix(), right? That's much better. http://reviews.llvm.org/D17947 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

r262895 - Add doxygen comments to bmiintrin.h's intrinsics.

Author: kromanova Date: Mon Mar 7 19:36:59 2016 New Revision: 262895 URL: http://llvm.org/viewvc/llvm-project?rev=262895&view=rev Log: Add doxygen comments to bmiintrin.h's intrinsics. The doxygen comments are automatically generated based on Sony's intrinsics document. I got an OK from Eric Ch

Re: [PATCH] D17908: Add Visual Studio Visualizers for more Clang types

mspertus updated this revision to Diff 50015. mspertus added a comment. Updated in response to review comments to fix issues around MSVC versions http://reviews.llvm.org/D17908 Files: clang.natvis Index: clang.natvis === --- cl

[PATCH] D17950: Implement is_always_lock_free

jfb created this revision. jfb added reviewers: mclow.lists, rsmith. jfb added a subscriber: cfe-commits. Herald added subscribers: dschuff, jfb. This was voted into C++17 at last week's Jacksonville meeting. The final P0152R1 paper will be in the upcoming post-Jacksonville mailing, and is also

[PATCH] D17951: Implement is_always_lock_free

jfb created this revision. jfb added reviewers: mclow.lists, rsmith. jfb added a subscriber: cfe-commits. This was voted into C++17 at last week's Jacksonville meeting. The final P0152R1 paper will be in the upcoming post-Jacksonville mailing, and is also available here: http://jfbastien.githu

Re: [PATCH] D17950: Implement is_always_lock_free

jfb added a comment. I'll check with GCC folks whether they want to share macros the same way we're already sharing `__GCC_ATOMIC_*_LOCK_FREE`. The new macros I propose are `__LLVM__ATOMIC_*_BYTES_LOCK_FREE` and `__LLVM_LOCK_FREE_IS_SIZE_BASED`. Let's do a first sanity-check round of code revie

Re: [PATCH] D17950: Implement is_always_lock_free

jfb added inline comments. Comment at: lib/Frontend/InitPreprocessor.cpp:480 @@ +479,3 @@ + if (LangOpts.CPlusPlus1z) { +Builder.defineMacro("__cpp_lib_atomic_is_always_lock_free", "201603"); + } How do you pick these numbers before the standard is actually

Re: [PATCH] D17951: Implement is_always_lock_free

jfb added inline comments. Comment at: include/atomic:840 @@ +839,3 @@ +#define ATOMIC_LLONG_LOCK_FREE __GCC_ATOMIC_LLONG_LOCK_FREE +#define ATOMIC_POINTER_LOCK_FREE __GCC_ATOMIC_POINTER_LOCK_FREE + Moving these from the bottom of the file since I need them.

[PATCH] D17952: [Clang] Accept absolute paths in the -fuse-ld option

whitequark created this revision. whitequark added a reviewer: majnemer. whitequark added a subscriber: cfe-commits. whitequark set the repository for this revision to rL LLVM. Herald added a subscriber: aemerson. This patch extends the -fuse-ld option to accept a full path to an executable and us

Re: [PATCH] D17952: [Clang] Accept absolute paths in the -fuse-ld option

silvas added a subscriber: silvas. silvas added a comment. Some nits but this looks fine to me. I've been wanting this for a while now. Comment at: cfe/trunk/lib/Driver/ToolChain.cpp:347 @@ +346,3 @@ + +if (UseLinker[0] == '/') { + // If we're passed -fuse-ld= with what

Re: [PATCH] D17952: [Clang] Accept absolute paths in the -fuse-ld option

whitequark marked an inline comment as done. Comment at: cfe/trunk/lib/Driver/ToolChain.cpp:352 @@ +351,3 @@ +return UseLinker; +} else { + // If we're passed -fuse-ld= with no argument, or with the argument ld, silvas wrote: > No need for else af

Re: [PATCH] D17952: [Clang] Accept absolute paths in the -fuse-ld option

whitequark updated this revision to Diff 50021. whitequark added a comment. Windows compatibility Repository: rL LLVM http://reviews.llvm.org/D17952 Files: cfe/trunk/lib/Driver/ToolChain.cpp Index: cfe/trunk/lib/Driver/ToolChain.cpp

Re: [PATCH] D17952: [Clang] Accept absolute paths in the -fuse-ld option

silvas added inline comments. Comment at: cfe/trunk/lib/Driver/ToolChain.cpp:352 @@ +351,3 @@ +return UseLinker; +} else { + // If we're passed -fuse-ld= with no argument, or with the argument ld, Makes sense. Repository: rL LLVM http://revie

Re: [PATCH] D17908: Add Visual Studio Visualizers for more Clang types

mspertus updated this revision to Diff 50022. mspertus added a comment. Based on Eric Feiveson's comment that I can suppress the numeric value of an enum visualization with ", en" I have uploaded a new diff. By suppressing the numeric values, instead of the verbose TemplateArgumentLoc visualizat

Re: [PATCH] D15944: [OpenMP] Parsing and sema support for target update directive

kkwli0 marked 3 inline comments as done. Comment at: include/clang/AST/OpenMPClause.h:3196 @@ -3195,1 +3195,3 @@ +/// \brief This represents clause 'from' in the '#pragma omp ...' +/// directives. ABataev wrote: > New clauses must be added in separate patches af

Re: [PATCH] D15944: [OpenMP] Parsing and sema support for target update directive

kkwli0 updated this revision to Diff 50024. kkwli0 marked 2 inline comments as done. kkwli0 added a comment. I rebase the patch to the latest trunk and make use of the infrastructure form parsing and sema. http://reviews.llvm.org/D15944 Files: include/clang-c/Index.h include/clang/AST/Open

r262915 - Sema: Treat 'strict' availability flag like unavailable

Author: dexonsmith Date: Tue Mar 8 00:12:54 2016 New Revision: 262915 URL: http://llvm.org/viewvc/llvm-project?rev=262915&view=rev Log: Sema: Treat 'strict' availability flag like unavailable This is a follow-up to r261512, which made the 'strict' availability attribute flag behave like 'unavail