Re: [PATCH] D18219: Add -cuda-relaxed-constexpr, which lets CUDA device code call constexpr functions.

jlebar added a comment. Abandoning this for now -- it is a maze of twisty passages all alike. Some std math functions are constexpr, and making them host+device affects all our existing math overloads in fun and exciting ways. We may need this at some point, but for now I'm going to try

Re: [PATCH] D17951: Implement is_always_lock_free

EricWF added a comment. In http://reviews.llvm.org/D17951#376546, @bcraig wrote: > Visual Studio has a flag, /Zc:wchar_t-, that turns wchar_t into a short. > This flag is for people that need to maintain ABI compatibility with ancient > Visual Studios (MSVC6? MSVC5?). It is definitely

Re: [PATCH] D17893: Sema: Add semantic analysis for the C++ ABI stability attributes and whitelist.

joker.eph added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:4999 @@ +4998,3 @@ +return; + } + pcc wrote: > joker.eph wrote: > > joker.eph wrote: > > > Isn't this correct by the loop which starts with `DC = > > > InnermostExternalDC`? > >

Re: [PATCH] D18265: [clang-tidy] New: checker misc-assign-operator-return

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. I think will be reasonable to merge misc-assign-operator-return and misc-assign-operator-signature into one check. http://reviews.llvm.org/D18265 ___ cfe-commits

[PATCH] D18231: [Clang-tools-extra] Fix Clang-tidy modernize-deprecated-headers warnings; other minor fixes

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: alexfh, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I checked this patch on my own build on RHEL 6. Regressions were OK. Repository: rL LLVM

Re: [PATCH] D16749: [OpenMP] Map clause codegeneration.

sfantao added a comment. Hi Alexey, I am afraid I don't understand what you are trying to accomplish with this. I was unable to compile your patch as is, I think what you intended is something like this: // If we are mapping a field of 'this' we attempt to generate a //

Re: [PATCH] D16360: unordered_map: Avoid unnecessary mallocs when no insert occurs

> On 2016-Mar-16, at 12:31, Duncan P. N. Exon Smith > wrote: > >> >> On 2016-Mar-16, at 12:20, Eric Fiselier wrote: >> >> EricWF added a comment. >> >> Adding inline comments for the implementation. Comments on the tests to >> follow shortly. >> >> >>

Re: [PATCH] D18138: Add -fnative-half-arguments-and-returns

olista01 accepted this revision. olista01 added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D18138 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r263654 - [OPENMP] Support for codegen of private clause of target, host side

Author: cbertol Date: Wed Mar 16 14:04:22 2016 New Revision: 263654 URL: http://llvm.org/viewvc/llvm-project?rev=263654=rev Log: [OPENMP] Support for codegen of private clause of target, host side This patch adds support for codegen of private clause of target and a regression test for host

Re: [PATCH] D16360: unordered_map: Avoid unnecessary mallocs when no insert occurs

EricWF added a comment. Adding inline comments for the implementation. Comments on the tests to follow shortly. Comment at: include/__hash_table:103 @@ -102,1 +102,3 @@ +template +struct __extract_key; Could you make `__extract_key` behave the same way as

Re: [PATCH] D18163: Add visualizers for more clang types. Create more C++-like visualizations for existing Clang types

mspertus updated this revision to Diff 50820. mspertus added a comment. Added reference types and a more accurate AttributedType enum. I am working on additional items for the future (class members, function types, etc.) but those will take longer, and I think it is worthwhile to get this

Re: [PATCH] D18261: Show members of DeclContexts (i.e., class members) in Visual Studio native visualizers

aaron.ballman added a comment. Mostly LGTM with one question about a comment. Comment at: clang.natvis:77 @@ +76,3 @@ + + + The only hard-wiring I see uses 3 bits, so is this comment still accurate? http://reviews.llvm.org/D18261

Re: [PATCH] D18138: Add -fnative-half-arguments-and-returns

pirama added a comment. Thanks for the review! Repository: rL LLVM http://reviews.llvm.org/D18138 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17951: Implement is_always_lock_free

EricWF added inline comments. Comment at: include/atomic:859 @@ +858,3 @@ +template <> _LIBCPP_CONSTEXPR bool __libcpp_always_lock_free = 2 == ATOMIC_CHAR32_T_LOCK_FREE; +template <> _LIBCPP_CONSTEXPR bool __libcpp_always_lock_free = 2 == ATOMIC_WCHAR_T_LOCK_FREE; +template <>

[PATCH] D18300: [clang-tidy] ProTypeMemberInitCheck - check that field decls do not have in-class initializer

flx created this revision. flx added reviewers: alexfh, JVApen. flx added a subscriber: cfe-commits. flx set the repository for this revision to rL LLVM. This fixes bug https://llvm.org/bugs/show_bug.cgi?id=26747 Repository: rL LLVM http://reviews.llvm.org/D18300 Files:

[PATCH] D18261: Show members of DeclContexts (i.e., class members) in Visual Studio native visualizers

mspertus created this revision. mspertus added reviewers: aaron.ballman, zturner. mspertus added a subscriber: cfe-commits. This change shows members of `DeclContext` objects in the Visual Studio debugger. It will also cast a `TagType` like a class or a struct to a `DeclContext`, so its methods

[PATCH] D18289: Attach profile summary information to module

eraman created this revision. eraman added a reviewer: vsk. eraman added subscribers: cfe-commits, davidxl. This allows optimization passes to make use of detailed profile summary. Once this is in and the optimization passes are made to use this, the "MaxFunctionCount" flag will be removed as

Re: [PATCH] D17951: Implement is_always_lock_free

jfb updated this revision to Diff 50903. jfb added a comment. - Size is based on __a_ not _Tp - Check value is consistent with C macros http://reviews.llvm.org/D17951 Files: include/atomic test/std/atomics/atomics.lockfree/isalwayslockfree.pass.cpp

Re: [PATCH] D17701: [Sema] Teach SemaCast to allow reinterpret_casts of overloaded functions with only one addressable candidate

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. OK, though I'm hoping either there aren't many more of these cases or we can treat them more generally somehow. Comment at: lib/Sema/SemaCast.cpp:1771-1782 @@ +1770,14 @@ +

Re: [PATCH] D17893: Sema: Add semantic analysis for the C++ ABI stability attributes and whitelist.

pcc added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:4999 @@ +4998,3 @@ +return; + } + joker.eph wrote: > joker.eph wrote: > > Isn't this correct by the loop which starts with `DC = InnermostExternalDC`? > `s/correct/already covered/` That loop

Re: [PATCH] D18191: [clang-tidy] Add check for function parameters that are const& to builtin types

LegalizeAdulthood added a subscriber: LegalizeAdulthood. LegalizeAdulthood added a comment. There is utility in the definition of a function in saying that an argument is `const int i` instead of `int i`. The const-ness declares the intent that this local variable is not going to be modified.

Re: [PATCH] D18199: CodeGen: Implement IR generation for the relative vtable ABI (PR26723).

pcc added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:1153 @@ -1152,3 +1152,3 @@ unsigned Virtuality = 0; - unsigned VIndex = 0; + unsigned VIndex = -1u; rsmith wrote: > Is this what debug info consumers expect for the non-virtual case? The

Re: [PATCH] D18011: [modules] Diagnose insufficient privileges when trying to load the modulemap

rsmith added a comment. I would prefer that we solve this problem generically for all files that Clang tries to open, not just for module map files. (Note, for instance, that PR20468 concerns files referenced by module map files, such as their nominated headers, not the module map files

Re: [PATCH] D17893: Sema: Add semantic analysis for the C++ ABI stability attributes and whitelist.

pcc added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:4935-4943 @@ +4934,11 @@ + + bool HasStableAttr = Record->hasAttr(); + bool HasUnstableAttr = Record->hasAttr(); + if (HasStableAttr && HasUnstableAttr) { +Diag(Record->getLocation(), diag::err_abi_mismatch)

Re: [PATCH] D18203: [OPENMP] Implementation of codegen for firstprivate clause of target directive

carlo.bertolli updated this revision to Diff 50845. carlo.bertolli added a comment. Update against trunk as dependence was committed to trunk. Repository: rL LLVM http://reviews.llvm.org/D18203 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/CodeGen/CGOpenMPRuntime.cpp

Re: [PATCH] D18191: [clang-tidy] Add check for function parameters that are const& to builtin types

etienneb added a subscriber: etienneb. etienneb added a comment. drive-by, some comments. Comment at: clang-tidy/misc/ConstRefBuiltinCheck.cpp:51 @@ +50,3 @@ + << Parameter->getFunctionScopeIndex() + << Function->getName() + << Fix; Function is

[PATCH] D18299: Better visualization of clang::BuiltinType in VisualStudio

mspertus created this revision. mspertus added reviewers: aaron.ballman, zturner, aemerson. mspertus added a subscriber: cfe-commits. Whenever possible, use C++ names for visualizing builtin types. E.g., `long double` instead of `LongDouble` Committed as revision 263891 for post-commit review

Re: [PATCH] D18297: Visualizer for clang::FunctionProtoType

mspertus added a comment. Based on Aaron's agreement to conducting post-commit reviews, I've committed this as revision 263890. Please let me know if I should not have done so. (This change is a lot smaller and simpler than I feared when I commented on my roadmap in diff

[PATCH] D18264: [clang-tidy] misc-assign-operator-signature checker checks return value of all assign operators

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: alexfh, hokein. baloghadamsoftware added subscribers: cfe-commits, xazax.hun. The return value of every assign operator should be Type&, not only for copy and move assign operators. This check and its test was

Re: [PATCH] D16749: [OpenMP] Map clause codegeneration.

ABataev added a comment. Samuel, I have a patch that improves handling of map clauses with data members. Unfortunately, I cannot commit it because I can't create tests for it. Please, apply this patch to your map clause codegen changes. It uses common technique for handling non-static data

Re: [PATCH] D15332: new clang-tidy checker readability-non-const-parameter

rsmith added inline comments. Comment at: test/clang-tidy/readability-non-const-parameter.cpp:116-134 @@ +115,21 @@ + +// CHECK-MESSAGES: :[[@LINE+1]]:18: warning: parameter 'p' can be const +int return1(int *p) { + // CHECK-FIXES: {{^}}int return1(const int *p) {{{$}} + return

Re: [PATCH] D17893: Sema: Add semantic analysis for the C++ ABI stability attributes and whitelist.

pcc added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8380 @@ +8379,3 @@ +def warn_unused_abi_stability_attr : Warning< + "unused C++ ABI stability attribute on non-dynamic class">, + InGroup>;

[PATCH] D18276: [OpenMP] Allow reduction on pointer dereference

Hahnfeld created this revision. Hahnfeld added reviewers: ABataev, hfinkel, carlo.bertolli, sfantao. Hahnfeld added a subscriber: cfe-commits. Pointer dereference is equal to access of first array element which is already allowed for the `reduction` clause. While at it also add test for CodeGen

Re: [PATCH] D18203: [OPENMP] Implementation of codegen for firstprivate clause of target directive

carlo.bertolli closed this revision. carlo.bertolli added a comment. Committed revision 263837. Repository: rL LLVM http://reviews.llvm.org/D18203 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D18263: [clang-tools-extra] Add release notes documentation

LegalizeAdulthood created this revision. LegalizeAdulthood added a reviewer: alexfh. LegalizeAdulthood added a subscriber: cfe-commits. Add a file for Extra Clang Tools release notes, based on 3.9 release notes file for Clang. http://reviews.llvm.org/D18263 Files: docs/ReleaseNotes.rst

Re: [PATCH] D18263: [clang-tools-extra] Add release notes documentation

LegalizeAdulthood updated this revision to Diff 51013. LegalizeAdulthood added a comment. Sort check names in list http://reviews.llvm.org/D18263 Files: docs/ReleaseNotes.rst docs/clang-tidy/checks/list.rst docs/index.rst Index: docs/index.rst

[PATCH] D18271: Avoid -Wshadow warnings about constructor parameters named after fields

rnk created this revision. rnk added reviewers: rsmith, rtrieu. rnk added a subscriber: cfe-commits. Emit a new warning if such parameters are modified in the body of the constructor. Fixes PR16088. http://reviews.llvm.org/D18271 Files: include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D18253: Switch AMDGPU Linker to amdphdrs + update test

kzhuravl-AMD created this revision. kzhuravl-AMD added a reviewer: tstellarAMD. kzhuravl-AMD added a subscriber: cfe-commits. http://reviews.llvm.org/D18253 Files: lib/Driver/Tools.cpp lib/Driver/Tools.h test/Driver/amdgpu-toolchain.c Index: test/Driver/amdgpu-toolchain.c

Re: [PATCH] D18199: CodeGen: Implement IR generation for the relative vtable ABI (PR26723).

pcc updated this revision to Diff 50905. pcc added a comment. - Do not set virtual index in debug info for relative-ABI virtual functions http://reviews.llvm.org/D18199 Files: docs/UsersManual.rst lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGVTables.cpp lib/CodeGen/CGVTables.h

Re: [PATCH] D17784: Check if LLVM_PREFIX is defined before using it.

This revision was automatically updated to reflect the committed changes. Closed by commit rL263766: Remove usage of LLVM_PREFIX. (authored by chaoren). Changed prior to commit: http://reviews.llvm.org/D17784?vs=50993=50994#toc Repository: rL LLVM http://reviews.llvm.org/D17784 Files:

Re: [PATCH] D17893: Sema: Add semantic analysis for the C++ ABI stability attributes and whitelist.

pcc added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:4935-4943 @@ +4934,11 @@ + + bool HasStableAttr = Record->hasAttr(); + bool HasUnstableAttr = Record->hasAttr(); + if (HasStableAttr && HasUnstableAttr) { +Diag(Record->getLocation(), diag::err_abi_mismatch)

Re: [PATCH] D16989: Change interpretation of function definition in friend declaration of template class.

rsmith added a comment. Can we instead not add the function to the redeclaration chain until it's instantiated (like we do if it's dependent)? http://reviews.llvm.org/D16989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r263784 - Revert r263783 as buildbot failure is being investigated.

Author: arpith Date: Fri Mar 18 07:39:40 2016 New Revision: 263784 URL: http://llvm.org/viewvc/llvm-project?rev=263784=rev Log: Revert r263783 as buildbot failure is being investigated. Removed: cfe/trunk/test/OpenMP/nvptx_target_codegen.cpp Modified:

Re: [PATCH] D18231: [Clang-tools-extra] Fix Clang-tidy modernize-deprecated-headers warnings; other minor fixes

etienneb added a subscriber: etienneb. etienneb added a comment. lgtm Repository: rL LLVM http://reviews.llvm.org/D18231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18289: Attach profile summary information to module

vsk added a comment. Thanks! Some inline comments -- Comment at: lib/CodeGen/CodeGenModule.cpp:399 @@ -398,1 +398,3 @@ getModule().setMaximumFunctionCount(PGOReader->getMaximumFunctionCount()); +auto *SummaryMD = PGOReader->getSummary().getMD(getModule().getContext());

Re: [PATCH] D18217: [libcxx] Fix -Wdeprecated warnings

hintonda added a comment. Yes, those were mostly in comments. I'd just done a simple find/grep that didn't take context into account. I agree that multiple checkins would be best which will make it much easy to review. http://reviews.llvm.org/D18217

Re: [PATCH] D17951: Implement is_always_lock_free

EricWF added a comment. @jfb: Actually I changed my mind about guarding the new tests. Can you move the new tests (other than the missing additions) to a new test file? Then add `// UNSUPPORTED: c++98, c++03, c++11, c++14` to the top of it? http://reviews.llvm.org/D17951

r263713 - clang-format: [JS] Make requoting of JavaScript string literals only

Author: djasper Date: Thu Mar 17 08:03:41 2016 New Revision: 263713 URL: http://llvm.org/viewvc/llvm-project?rev=263713=rev Log: clang-format: [JS] Make requoting of JavaScript string literals only change affected ranges. Modified: cfe/trunk/lib/Format/Format.cpp

Re: [PATCH] D18217: [libcxx] Fix -Wdeprecated warnings

mclow.lists added a comment. One idea is to do this in two steps - do the `throw()` stuff in one patch, and the defaulted fns in a second one. http://reviews.llvm.org/D18217 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D18217: [libcxx] Fix -Wdeprecated warnings

mclow.lists added a comment. > Okay, but should I fix the 146 cases of " = default;" that were already there? If there are `= default` in code that can be used from C++03, then they ought to be fixed. Note that many of the ones that turn up in a text search are in the synopsis - not in the

Re: [PATCH] D14286: ASTImporter: expressions, pt.1

a.sidorin updated this revision to Diff 51027. a.sidorin added a comment. Serge, thank you for help! GNUNullExpr was 'long' on my platform. I weakened a matcher to check only if it has integer type. ParenListExpr issue was also successfully reproduced with 'fdelayed-template-parsing' and fixed.

r263888 - [Sema] Make type deduction work with some overloadable functions

Author: gbiv Date: Sat Mar 19 16:51:45 2016 New Revision: 263888 URL: http://llvm.org/viewvc/llvm-project?rev=263888=rev Log: [Sema] Make type deduction work with some overloadable functions Some functions can't have their address taken. If we encounter an overload set where only one of the

Re: [PATCH] D15591: [Bugfix] Make type deduction work more nicely with unaddressable functions

This revision was automatically updated to reflect the committed changes. Closed by commit rL263888: [Sema] Make type deduction work with some overloadable functions (authored by gbiv). Changed prior to commit: http://reviews.llvm.org/D15591?vs=49337=51120#toc Repository: rL LLVM

r263837 - [OPENMP] Implementation of codegen for firstprivate clause of target directive

Author: cbertol Date: Fri Mar 18 16:43:32 2016 New Revision: 263837 URL: http://llvm.org/viewvc/llvm-project?rev=263837=rev Log: [OPENMP] Implementation of codegen for firstprivate clause of target directive This patch implements the following aspects: It extends sema to check that a variable

Re: [PATCH] D17701: [Sema] Teach SemaCast to allow reinterpret_casts of overloaded functions with only one addressable candidate

This revision was automatically updated to reflect the committed changes. Closed by commit rL263887: [Sema] Allow casting of some overloaded functions (authored by gbiv). Changed prior to commit: http://reviews.llvm.org/D17701?vs=49334=51119#toc Repository: rL LLVM

r263887 - [Sema] Allow casting of some overloaded functions

Author: gbiv Date: Sat Mar 19 16:36:10 2016 New Revision: 263887 URL: http://llvm.org/viewvc/llvm-project?rev=263887=rev Log: [Sema] Allow casting of some overloaded functions Some functions can't have their address taken. If we encounter an overload set where only one of the candidates can have

Re: [PATCH] D17701: [Sema] Teach SemaCast to allow reinterpret_casts of overloaded functions with only one addressable candidate

george.burgess.iv marked an inline comment as done. Comment at: lib/Sema/SemaCast.cpp:1771-1782 @@ +1770,14 @@ + + DeclAccessPair DAP; + FunctionDecl *Found = Self.resolveAddressOfOnlyViableOverloadCandidate(E, DAP); + if (!Found) +return false; + +

Re: [PATCH] D16360: unordered_map: Avoid unnecessary mallocs when no insert occurs

> On 2016-Mar-16, at 15:41, Eric Fiselier wrote: > > EricWF accepted this revision. > EricWF added a comment. > This revision is now accepted and ready to land. > > LGTM after change in inline comment. > > > > Comment at: include/__hash_table:114 > @@ +113,3 @@

Re: [PATCH] D18217: [libcxx] Fix -Wdeprecated warnings

hintonda added a comment. Okay, but should I fix the 146 cases of " = default;" that were already there? That's a lot of churn, so I don't want to step on anyone... http://reviews.llvm.org/D18217 ___ cfe-commits mailing list

Re: [PATCH] D17950: Implement is_always_lock_free

On 3/18/2016 1:50 AM, Joerg Sonnenberger via cfe-commits wrote: On Thu, Mar 17, 2016 at 05:56:17PM +, JF Bastien via cfe-commits wrote: C++ atomics are explicitly designed to avoid problems with touching adjacent bytes: if `atomic` where `sizeof(T) == 1` requires a 4-byte `cmpxchg` then

Re: [PATCH] D18191: [clang-tidy] Add check for function parameters that are const& to builtin types

sdowney updated this revision to Diff 50986. sdowney added a comment. Add tests with functions generated with MACROS http://reviews.llvm.org/D18191 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/ConstRefBuiltinCheck.cpp clang-tidy/misc/ConstRefBuiltinCheck.h

r263747 - Re-add (user defined) move ops to UnresolvedSetImpl to allow UnresolvedSet to be implicitly movable

Author: dblaikie Date: Thu Mar 17 15:45:38 2016 New Revision: 263747 URL: http://llvm.org/viewvc/llvm-project?rev=263747=rev Log: Re-add (user defined) move ops to UnresolvedSetImpl to allow UnresolvedSet to be implicitly movable Modified: cfe/trunk/include/clang/AST/UnresolvedSet.h

Re: [PATCH] D18263: [clang-tools-extra] Add release notes documentation

alexfh added a comment. Looks good with one comment. Thank you, Richard! Comment at: docs/clang-tidy/checks/list.rst:91 @@ -90,2 +90,3 @@ performance-implicit-cast-in-loop + performance-unnecessary-copy-initialization.rst readability-braces-around-statements

Re: [PATCH] D17950: Implement is_always_lock_free

jfb added a comment. In http://reviews.llvm.org/D17950#376965, @jfb wrote: > In http://reviews.llvm.org/D17950#376349, @jyknight wrote: > > > This conflicts with http://reviews.llvm.org/D17933. Most of this change > > also seems unnecessary. > > > > - I think the `is_always_lock_free` function

Re: [PATCH] D18219: Add -cuda-relaxed-constexpr, which lets CUDA device code call constexpr functions.

jlebar added a comment. Actually, this isn't enough. It works fine for std::complex, but it screws with our existing std math business, because some of the host functions that we're trying to override are constexpr, and now they're treated as constexpr host-device.

Re: [PATCH] D16749: [OpenMP] Map clause codegeneration.

ABataev added a comment. Samuel, this will be captured. But foo() will use original A. This cannot be changed. But Inside the region all reference to this->A will be replaced by the CapturedDecl A. It will allow proper codegen for inner captured contexts. For example, such code won't be handled

[PATCH] D18297: Visualizer for clang::FunctionProtoType

mspertus created this revision. mspertus added reviewers: aaron.ballman, zturner, aemerson. mspertus added a subscriber: cfe-commits. Visualizer for clang::FunctionProtoType Displays return type and parameters for the Function Protoype object in the Locals window. For example, the prototype

Re: [PATCH] D16360: unordered_map: Avoid unnecessary mallocs when no insert occurs

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM after change in inline comment. Comment at: include/__hash_table:114 @@ +113,3 @@ +template +struct __can_extract_key<_Pair, _Key, pair<_First, _Second>> +:

Re: [PATCH] D17950: Implement is_always_lock_free

On Thu, Mar 17, 2016 at 05:56:17PM +, JF Bastien via cfe-commits wrote: > C++ atomics are explicitly designed to avoid problems with touching > adjacent bytes: if `atomic` where `sizeof(T) == 1` requires a 4-byte > `cmpxchg` then it's up to the frontend to make sure `sizeof >= 4` > (or

Re: [PATCH] D16579: Warn if friend function depends on template parameters.

sepavloff updated this revision to Diff 51017. sepavloff added a comment. Do not emit warning on class methods. http://reviews.llvm.org/D16579 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDecl.cpp test/CXX/drs/dr3xx.cpp

[PATCH] D18286: [OPENMP] private and firstprivate clauses of teams code generation for nvptx

carlo.bertolli created this revision. carlo.bertolli added reviewers: ABataev, kkwli0, Hahnfeld. carlo.bertolli added subscribers: sfantao, caomhin, arpith-jacob, cfe-commits. carlo.bertolli set the repository for this revision to rL LLVM. Herald added a subscriber: jholewinski. This patch adds

Re: [PATCH] D9888: [OPENMP] Driver support for OpenMP offloading

rsmith added a comment. @echristo, you asked for time to review this; if you still want to, please can you do so? @tra, it looks like you're happy with this design (and with moving the CUDA offloading support in this direction), please let us know if not! Comment at:

Re: [PATCH] D18199: CodeGen: Implement IR generation for the relative vtable ABI (PR26723).

pcc added a comment. There's a correctness issue with this change that I'll need to resolve before this goes in; see http://lists.llvm.org/pipermail/cfe-dev/2016-March/048025.html http://reviews.llvm.org/D18199 ___ cfe-commits mailing list

[PATCH] D18296: [Sema] Handle UTF-8 invalid format string specifiers

bruno created this revision. bruno added a reviewer: rsmith. bruno added subscribers: cfe-commits, dexonsmith. Improve invalid format string specifier handling by printing out invalid specifiers characters with \x, \u and \U. Previously clang would print gargabe whenever the character is

[PATCH] D18272: Add AMDGPU specific target options: -mamdgpu-tools-insert-nops and -mamdgpu-tools-reserve-trap-vgprs + add test

kzhuravl-AMD created this revision. kzhuravl-AMD added reviewers: arsenm, tstellarAMD. kzhuravl-AMD added subscribers: bpurnomo, cfe-commits. http://reviews.llvm.org/D18272 Files: include/clang/Driver/Options.td lib/Driver/Tools.cpp test/Driver/amdgpu-features.c Index:

Re: [PATCH] D13419: Fix several problems at the intersection of template instantiations and visibility

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rL LLVM http://reviews.llvm.org/D13419 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D18270: Typesafe visualization of PointerIntPairs in Visual Studio

mspertus created this revision. mspertus added reviewers: aaron.ballman, zturner, aemerson. mspertus added a subscriber: cfe-commits. In the `` of `PointerIntPair` , I cast the pointer to the actual type, so VS can leverage it while visualizing, not unlike the recent change to `PointerUnion`

Re: [PATCH] D18270: Typesafe visualization of PointerIntPairs in Visual Studio

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! > Note to Reviewers: I will continue to make frequent changes to the MSVC > visualizers. While these are worthwhile, I don't want to overwhelm the > reviewers. Is it OK

Re: [PATCH] D18105: [OPENMP] Support for codegen of private clause of target, host side

carlo.bertolli closed this revision. carlo.bertolli added a comment. Committed revision 263654. Repository: rL LLVM http://reviews.llvm.org/D18105 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D18221: [Concepts] Implement subsection [dcl.spec.concept]p7 of the Concepts TS

nwilson added inline comments. Comment at: lib/Sema/SemaDecl.cpp:7837 @@ -7819,1 +7836,3 @@ +NewFD->setInvalidDecl(true); +return NewFD; } Please let me know if there are thoughts about better error recovery here. I did this because we

Re: [PATCH] D16965: Fix for Bug 14644 - clang confuses scope operator for global namespace giving extra qualification on member

ryee88 added inline comments. Comment at: lib/Sema/SemaDecl.cpp:3803 @@ +3802,3 @@ + +// Per C++ standard [n3485] 3.4.4 Elaborated type specifiers, section 3: +// "Cannot introduce an qualified". aaron.ballman wrote: > Can drop the N-paper reference,

r263783 - [OpenMP] Base support for target directive codegen on NVPTX device.

Author: arpith Date: Fri Mar 18 06:47:43 2016 New Revision: 263783 URL: http://llvm.org/viewvc/llvm-project?rev=263783=rev Log: [OpenMP] Base support for target directive codegen on NVPTX device. Summary: Reworked test case after buildbot failure on windows. This patch adds base support for

Re: [PATCH] D18274: [clang-tidy] Add boost module

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. I think you also need to add new module to clang-tidy/plugin/CMakeLists.txt. http://reviews.llvm.org/D18274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D18149: Add check for unneeded copies of locals

fowles updated this revision to Diff 50879. http://reviews.llvm.org/D18149 Files: clang-tidy/performance/UnnecessaryCopyInitialization.cpp clang-tidy/performance/UnnecessaryCopyInitialization.h docs/clang-tidy/checks/performance-unnecessary-copy-initialization.rst

Re: [PATCH] D17988: Fix destructor definition of invalid classes

This revision was automatically updated to reflect the committed changes. Closed by commit rL263639: Fix destructor definition of invalid classes (authored by ogoffart). Changed prior to commit: http://reviews.llvm.org/D17988?vs=50124=50822#toc Repository: rL LLVM

Re: [PATCH] D17893: Sema: Add semantic analysis for the C++ ABI stability attributes and whitelist.

aaron.ballman added a comment. Attribute side of things looks good, but I leave it to others to decide if the ABI functionality makes sense (it does to me, but I'm no ABI expert). http://reviews.llvm.org/D17893 ___ cfe-commits mailing list

Re: [PATCH] D17893: Sema: Add semantic analysis for the C++ ABI stability attributes and whitelist.

joker.eph added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:4999 @@ +4998,3 @@ +return; + } + joker.eph wrote: > Isn't this correct by the loop which starts with `DC = InnermostExternalDC`? `s/correct/already covered/`

Re: [PATCH] Canonicalize UnaryTransformType types when they don't have a known underlying type

ping... On 10/03/16 15:33, Vassil Vassilev wrote: Would this one more reasonable to commit. As you suggested if the base type is dependent, create a unique canonical UnaryTransformType with the canonical form of the base type as its base type and with DependentTy as its underlying type, then

[PATCH] D18274: [clang-tidy] Add boost module

Prazek created this revision. Prazek added reviewers: alexfh, mclow.lists. Prazek added a subscriber: cfe-commits. http://reviews.llvm.org/D18274 Files: clang-tidy/CMakeLists.txt clang-tidy/boost/BoostTidyModule.cpp clang-tidy/boost/CMakeLists.txt clang-tidy/tool/CMakeLists.txt

Re: r263785 - Make LookupResult movable again.

On Fri, Mar 18, 2016 at 6:31 AM, Benjamin Kramer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: d0k > Date: Fri Mar 18 08:31:00 2016 > New Revision: 263785 > > URL: http://llvm.org/viewvc/llvm-project?rev=263785=rev > Log: > Make LookupResult movable again. > This shouldn't've

Re: [PATCH] D18139: [Cxx1z] Implement Lambda Capture of *this by Value as [=, *this] (P0018R3)

rsmith added a comment. Couple more things: 1. Please add some testing to tests/CXX/expr/expr.prim/expr.prim.lambda 2. Please update cxx_status.html http://reviews.llvm.org/D18139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D16360: unordered_map: Avoid unnecessary mallocs when no insert occurs

dexonsmith updated this revision to Diff 50883. dexonsmith added a comment. Eric sent me his preferred tests, which look fine to me. I've applied them to this patch. http://reviews.llvm.org/D16360 Files: include/__hash_table

Re: [PATCH] D18262: [clang-tidy] Skip reporting of not applicable fixes.

alexfh added a comment. Thank you, Etienne! Please add a regression test. Comment at: ClangTidy.cpp:144 @@ -138,1 +143,3 @@ + +Diag << FixItHint::CreateReplacement(Range, Fix.getReplacementText()); ++TotalFixes; aaron.ballman wrote: >

Re: [PATCH] D18123: Fix implicit copy ctor and copy assignment operator warnings when -Wdeprecated passed.

On Wed, Mar 16, 2016 at 11:38 AM, don hinton via cfe-commits < cfe-commits@lists.llvm.org> wrote: > hintonda updated this revision to Diff 50843. > hintonda added a comment. > > Added FIXME comment, and reformated with clang-format. > > > http://reviews.llvm.org/D18123 > > Files: >

Re: [PATCH] D17392: Embed bitcode in object file (clang cc1 part)

rsmith added a comment. From a code standpoint, this looks fine to me, but I'd like to understand a bit more about what you aim to achieve with the various parts here. Comment at: include/clang/Frontend/CodeGenOptions.def:57 @@ -56,1 +56,3 @@ +CODEGENOPT(EmbedBitcode , 1,

r263689 - [index] Make sure that declarations of builtin functions are indexed.

Author: akirtzidis Date: Wed Mar 16 23:28:19 2016 New Revision: 263689 URL: http://llvm.org/viewvc/llvm-project?rev=263689=rev Log: [index] Make sure that declarations of builtin functions are indexed. rdar://25154630 Modified: cfe/trunk/lib/Index/IndexingContext.cpp

Re: [PATCH] D17951: Implement is_always_lock_free

jfb updated this revision to Diff 50846. jfb added a comment. - Split up tests. http://reviews.llvm.org/D17951 Files: include/atomic test/std/atomics/atomics.lockfree/isalwayslockfree.pass.cpp test/std/atomics/atomics.lockfree/lockfree.pass.cpp Index:

Re: r263687 - Add an optional named argument (replacement = "xxx") to AvailabilityAttr.

Sorry, working on it. Manman On Thu, Mar 17, 2016 at 12:45 PM, Kostya Serebryany wrote: > This change is causing ubsan bot to complain > > . > Please fix or

Re: [PATCH] D18123: Fix implicit copy ctor and copy assignment operator warnings when -Wdeprecated passed.

hintonda updated this revision to Diff 50823. hintonda added a comment. Address FIXME now that Sema::LookupInlineAsmField() has been fixed. http://reviews.llvm.org/D18123 Files: include/clang/AST/UnresolvedSet.h include/clang/Sema/Lookup.h Index: include/clang/Sema/Lookup.h

Re: [PATCH] D17746: Fix PR26741 -- __builtin_object_size is not consistently conservative with C++ inheritance

rsmith added a comment. Can you explain a bit more about the problem? It seems to me that if I have: struct Base { char k[1]; }; struct Derived : Base {}; ... then the 'k' subobject of a `Derived` object is known to be exactly 1 byte long -- it doesn't seem obviously appropriate for

  1   2   3   >