chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.
LGTM, nice!
http://reviews.llvm.org/D18648
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.
Minor tweak, but with that LGTM once the LLVM side is in place.
Comment at: lib/CodeGen/BackendUtil.cpp:347
@@ +346,3 @@
+PassManagerBuilder::EP_EarlyAsPossible,
kimgr added a subscriber: kimgr.
kimgr added a comment.
A test case would be nice here. You can repro on all systems by passing
`-fdelayed-template-parsing` explicitly.
http://reviews.llvm.org/D18852
___
cfe-commits mailing list
cfe-commits@lists.l
alexfh added a comment.
Please add a test file with -fms-compatibility or -fdelayed-template-parsing.
http://reviews.llvm.org/D18852
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh added a comment.
A couple of nits.
Comment at: clang-tidy/misc/MisplacedWideningCastCheck.cpp:64
@@ -62,5 +63,3 @@
unsigned RHSWidth = getMaxCalculationWidth(Context, Bop->getRHS());
-if (Bop->getOpcode() == BO_Mul)
- return LHSWidth + RHSWidth;
-if (Bop
alexfh added a comment.
Wait, it looks like you've updated the patch from an incorrect branch: I see
only clang-tidy/misc/MisplacedWideningCastCheck.cpp file here.
http://reviews.llvm.org/D18783
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
vkalintiris accepted this revision.
vkalintiris added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D18761
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
Author: d0k
Date: Thu Apr 7 05:14:54 2016
New Revision: 265654
URL: http://llvm.org/viewvc/llvm-project?rev=265654&view=rev
Log:
Move class into an anonymous namespace. NFC.
Modified:
cfe/trunk/lib/CodeGen/TargetInfo.cpp
Modified: cfe/trunk/lib/CodeGen/TargetInfo.cpp
URL:
http://llvm.org/v
Author: alexfh
Date: Thu Apr 7 05:17:23 2016
New Revision: 265655
URL: http://llvm.org/viewvc/llvm-project?rev=265655&view=rev
Log:
[docs] Update version (http://llvm.org/PR27253)
Modified:
clang-tools-extra/trunk/docs/conf.py
Modified: clang-tools-extra/trunk/docs/conf.py
URL:
http://llvm
On 07/04/16 07:41, Saleem Abdulrasool via cfe-commits wrote:
Author: compnerd
Date: Thu Apr 7 00:41:11 2016
New Revision: 265640
URL: http://llvm.org/viewvc/llvm-project?rev=265640&view=rev
Log:
Basic: thread CodeGenOptions into TargetInfo
This threads CodeGenOptions into the TargetInfo hierar
DmitryPolukhin updated this revision to Diff 52906.
DmitryPolukhin added a comment.
- rebase after committing llvm patch
http://reviews.llvm.org/D15524
Files:
include/clang/AST/DeclBase.h
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Basic/DiagnosticSemaKinds
Author: abataev
Date: Thu Apr 7 07:45:37 2016
New Revision: 265668
URL: http://llvm.org/viewvc/llvm-project?rev=265668&view=rev
Log:
[OPENMP 4.0] Parsing/sema analysis for 'simdlen' clause in 'declare simd'
construct.
OpenMP 4.0 defines '#pragma omp declare simd' construct that may have
associat
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Awesome! Thanks for the fix!
http://reviews.llvm.org/D18829
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
Formatting is broken. `clang-format -style=file`, please.
http://reviews.llvm.org/D18833
___
cfe-commits mailing list
cfe-commits@lists
arnetheduck planned changes to this revision.
arnetheduck added a comment.
Thanks for the comments - I'll see when I have time to get back to this as the
current patch happens to take care of my (rather limited) use case..
Comment at: lib/Format/UnwrappedLineParser.cpp:1086
@@
alexfh added a comment.
Please regenerate the patch with the full context.
Comment at: clang-tidy/ClangTidy.cpp:39
@@ -38,1 +38,3 @@
#include "clang/Tooling/Tooling.h"
+#include "llvm/ADT/SmallString.h"
+#include "llvm/ADT/SmallVector.h"
Did you make these chan
faisalv added a comment.
*ping*
http://reviews.llvm.org/D18510
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
faisalv added a comment.
*ping*
http://reviews.llvm.org/D18495
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: etienneb
Date: Thu Apr 7 09:18:53 2016
New Revision: 265671
URL: http://llvm.org/viewvc/llvm-project?rev=265671&view=rev
Log:
[clang-tidy] Fix FP with readability-redundant-string-init for default arguments
Summary:
Clang-tidy is reporting a warning of redundant string initialisation
on
Author: marshall
Date: Thu Apr 7 09:20:31 2016
New Revision: 265672
URL: http://llvm.org/viewvc/llvm-project?rev=265672&view=rev
Log:
Fix bug #27260 - add missing swap(reference, reference) to vector.
Added:
libcxx/trunk/test/std/containers/sequences/vector.bool/reference.swap.pass.cpp
Modi
DmitryPolukhin added a comment.
Richard, Reid and David,
Friendly ping, please take a look to this patch. If there are no more
comments/suggestion, I think it is better to commit this patch iterate on GCC
abi_tag support based on users' feedback.
http://reviews.llvm.org/D18035
etienneb updated this revision to Diff 52915.
etienneb added a comment.
add unittests.
http://reviews.llvm.org/D18852
Files:
clang-tidy/performance/UnnecessaryValueParamCheck.cpp
test/clang-tidy/performance-unnecessary-value-param-delayed.cpp
Index: test/clang-tidy/performance-unnecessary-
Author: marshall
Date: Thu Apr 7 09:24:16 2016
New Revision: 265674
URL: http://llvm.org/viewvc/llvm-project?rev=265674&view=rev
Log:
Added a noexcept test
Modified:
libcxx/trunk/test/std/containers/sequences/vector.bool/reference.swap.pass.cpp
Modified:
libcxx/trunk/test/std/containers/s
Author: spatel
Date: Thu Apr 7 09:29:05 2016
New Revision: 265675
URL: http://llvm.org/viewvc/llvm-project?rev=265675&view=rev
Log:
make __builtin_isfinite more efficient (PR27145)
isinf (is infinite) and isfinite should be implemented with the same function
except we change the comparison opera
This revision was automatically updated to reflect the committed changes.
Closed by commit rL265675: make __builtin_isfinite more efficient (PR27145)
(authored by spatel).
Changed prior to commit:
http://reviews.llvm.org/D18648?vs=52214&id=52917#toc
Repository:
rL LLVM
http://reviews.llvm.o
etienneb updated this revision to Diff 52919.
etienneb added a comment.
alexfh comments.
http://reviews.llvm.org/D18833
Files:
clang-tidy/misc/MisplacedWideningCastCheck.cpp
Index: clang-tidy/misc/MisplacedWideningCastCheck.cpp
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D18833
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D18852
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
etienneb updated this revision to Diff 52921.
etienneb added a comment.
nits, lower case names.
http://reviews.llvm.org/D18833
Files:
clang-tidy/misc/MisplacedWideningCastCheck.cpp
Index: clang-tidy/misc/MisplacedWideningCastCheck.cpp
=
alexfh added a comment.
Missed a couple of nits.
Comment at: clang-tidy/misc/MisplacedWideningCastCheck.cpp:98
@@ -96,40 +97,3 @@
-static llvm::SmallDenseMap createRelativeIntSizesMap() {
- llvm::SmallDenseMap Result;
- Result[BuiltinType::UChar] = 1;
- Result[BuiltinType::
Author: mzuckerm
Date: Thu Apr 7 09:44:08 2016
New Revision: 265677
URL: http://llvm.org/viewvc/llvm-project?rev=265677&view=rev
Log:
Fixing duplicate declaration "_mm256 _mm_set_epi32" in revision 262177
Differential Revision: http://reviews.llvm.org/D17685
Modified:
cfe/trunk/lib/Headers
etienneb updated this revision to Diff 52924.
etienneb marked an inline comment as done.
etienneb added a comment.
fix nits.
http://reviews.llvm.org/D18833
Files:
clang-tidy/misc/MisplacedWideningCastCheck.cpp
Index: clang-tidy/misc/MisplacedWideningCastCheck.cpp
Author: etienneb
Date: Thu Apr 7 09:52:52 2016
New Revision: 265679
URL: http://llvm.org/viewvc/llvm-project?rev=265679&view=rev
Log:
[clang-tidy] Fix infinite loop in MisplacedWideningCastCheck.
Summary:
In Release mode, the check was infinite looping over chromium code base.
It seems there is
Author: d0k
Date: Thu Apr 7 09:55:25 2016
New Revision: 265680
URL: http://llvm.org/viewvc/llvm-project?rev=265680&view=rev
Log:
[clang-tidy] Remove unnecessary getName() on Decls and Types feeding into a
DiagnosticBuilder
Going through a string removes some of the smarts of the diagnosic print
Author: etienneb
Date: Thu Apr 7 09:58:13 2016
New Revision: 265681
URL: http://llvm.org/viewvc/llvm-project?rev=265681&view=rev
Log:
[clang-tidy] fix a crash with -fdelayed-template-parsing in
UnnecessaryValueParamCheck.
Summary:
This is the same kind of bug than [[ http://reviews.llvm.org/D18
Thanks!
On Thu, Apr 7, 2016 at 4:55 PM, Benjamin Kramer via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: d0k
> Date: Thu Apr 7 09:55:25 2016
> New Revision: 265680
>
> URL: http://llvm.org/viewvc/llvm-project?rev=265680&view=rev
> Log:
> [clang-tidy] Remove unnecessary getName() on
etienneb updated this revision to Diff 52926.
etienneb marked 2 inline comments as done.
etienneb added a comment.
Revert last diff (invalid patchset).
http://reviews.llvm.org/D18783
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/StringLiteralWith
etienneb updated this revision to Diff 52927.
etienneb added a comment.
nit
http://reviews.llvm.org/D18783
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/StringLiteralWithEmbeddedNulCheck.cpp
clang-tidy/misc/StringLiteralWithEmbeddedNulCheck.h
alexfh added inline comments.
Comment at: clang-tidy/misc/SuspiciousStringCompareCheck.cpp:73
@@ +72,3 @@
+ functionDecl(
+ hasAnyName("__builtin_memcmp",
+ "__builtin_strcasecmp",
I'd initialize the list as a comma/semicolon-sep
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: docs/clang-tidy/checks/misc-string-literal-with-embedded-nul.rst:6
@@ +5,3 @@
+
+Find occurences of string literal with embedded NUL character and validate
+their usage.
-
alexfh added a comment.
Actually, did you think about adding this as a clang diagnostic?
Richard, what do you think about complaining in Clang about `int i = true;`
kind of code?
Comment at: clang-tidy/modernize/BoolToIntegerConversionCheck.cpp:49
@@ +48,3 @@
+diag(BoolLit
etienneb updated this revision to Diff 52930.
etienneb marked 3 inline comments as done.
etienneb added a comment.
fix doc.
http://reviews.llvm.org/D18783
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/StringLiteralWithEmbeddedNulCheck.cpp
clang
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG with one nit.
Comment at: clang-tidy/misc/StringLiteralWithEmbeddedNulCheck.cpp:70
@@ +69,3 @@
+diag(SL->getLocStart(), "suspicious embedded NUL character");
+
Prazek added a comment.
In http://reviews.llvm.org/D18821#394486, @alexfh wrote:
> Actually, did you think about adding this as a clang diagnostic?
>
> Richard, what do you think about complaining in Clang about `int i = true;`
> kind of code?
Glad to hear that :)
http://reviews.llvm.org/D18
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG with a nit.
Comment at: clang-tidy/misc/MultipleStatementMacroCheck.cpp:99
@@ +98,3 @@
+
+ diag(InnerRanges.back().first, "multiple statement macro spans unbraced "
+
alexfh added inline comments.
Comment at: clang-tidy/modernize/BoolToIntegerConversionCheck.cpp:47
@@ +46,3 @@
+ const auto Type = Cast->getType().getLocalUnqualifiedType();
+ if (isPreprocessorIndependent(BoolLiteral, Result)) {
+diag(BoolLiteral->getLocation(), "implicitly
jlebar added inline comments.
Comment at: lib/CodeGen/BackendUtil.cpp:347
@@ +346,3 @@
+PassManagerBuilder::EP_EarlyAsPossible,
+[this](const PassManagerBuilder &, legacy::PassManagerBase &PM) {
+ TM->addEarlyAsPossiblePasses(PM);
chandler
alexfh added a comment.
LG
Repository:
rL LLVM
http://reviews.llvm.org/D18797
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
etienneb updated this revision to Diff 52935.
etienneb added a comment.
nit
http://reviews.llvm.org/D18783
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/StringLiteralWithEmbeddedNulCheck.cpp
clang-tidy/misc/StringLiteralWithEmbeddedNulCheck.h
Author: etienneb
Date: Thu Apr 7 11:16:36 2016
New Revision: 265691
URL: http://llvm.org/viewvc/llvm-project?rev=265691&view=rev
Log:
[clang-tidy] add new checker for string literal with NUL character.
Summary:
This patch adds the support for detecting suspicious string
literals and their //inco
aprantl accepted this revision.
aprantl added a reviewer: aprantl.
aprantl added a comment.
This revision is now accepted and ready to land.
This landed a long time ago as r246192.
Repository:
rL LLVM
http://reviews.llvm.org/D11958
___
cfe-commit
On Thu, 7 Apr 2016 15:48:56 +, Alexander Kornienko via cfe-commits said:
>Actually, did you think about adding this as a clang diagnostic?
>
>Richard, what do you think about complaining in Clang about `int i =
>true;` kind of code?
If you don't mind a lurker interjecting... :) I think that'
This revision was automatically updated to reflect the committed changes.
Closed by commit rL265698: Mention
readability-static-definition-in-anonymous-namespace in release notes.
(authored by eugenezelenko).
Changed prior to commit:
http://reviews.llvm.org/D18797?vs=52712&id=52939#toc
Reposi
Author: eugenezelenko
Date: Thu Apr 7 12:28:35 2016
New Revision: 265698
URL: http://llvm.org/viewvc/llvm-project?rev=265698&view=rev
Log:
Mention readability-static-definition-in-anonymous-namespace in release notes.
Consistency in using ` and ``.
Differential revision: http://reviews.llvm.org
Anastasia added a comment.
In http://reviews.llvm.org/D17821#393496, @bader wrote:
> In http://reviews.llvm.org/D17821#393387, @Anastasia wrote:
>
> > Regarding, extending this approach for OpenCL pipe types too. I was
> > thinking we could change current implementation to have ReadPipeType and
alexfh added a comment.
Let's try to turn this to a productive lane. I'm not against adding this
functionality, if it's actually useful, but as is the patch doesn't meet the
bar. Right now, there are a few action items.
First, could you split the refactorings and send me as a separate patch? Th
Author: rksimon
Date: Thu Apr 7 12:38:24 2016
New Revision: 265700
URL: http://llvm.org/viewvc/llvm-project?rev=265700&view=rev
Log:
Minor Wdocumentation fix. NFCI.
Modified:
cfe/trunk/include/clang/Parse/Parser.h
Modified: cfe/trunk/include/clang/Parse/Parser.h
URL:
http://llvm.org/viewvc
Anastasia added a comment.
In http://reviews.llvm.org/D17412#391351, @Matt wrote:
> In http://reviews.llvm.org/D17412#391322, @Anastasia wrote:
>
> > Cool, thanks! I think we should commit this ASAP.
> >
> > @Xiuli/@Matt, do you have any more comments here?
>
>
> Hi! I think that "Matt" for this
sbenza added inline comments.
Comment at: clang-tidy/misc/AssignOperatorCheck.cpp:63
@@ +62,3 @@
+
+ Finder->addMatcher(returnStmt(IsBadReturnStatement,
hasAncestor(IsGoodAssign))
+ .bind("returnStmt"),
baloghadamsoftware wrote:
> sbenza
Author: compnerd
Date: Thu Apr 7 12:49:44 2016
New Revision: 265702
URL: http://llvm.org/viewvc/llvm-project?rev=265702&view=rev
Log:
Basic: move CodeGenOptions from Frontend
This is a mechanical move of CodeGenOptions from libFrontend to libBasic. This
fixes the layering violation introduced e
alexfh added inline comments.
Comment at: clang-tidy/ClangTidyOptions.cpp:269
@@ +268,3 @@
+ ->CheckSources[ClangTidyOptions::ConfigCommandlineOptionOrFile]
+ .push_back(ClangTidyOptions::StringPair(*ParsedOptions->Checks,
+
alexfh added inline comments.
Comment at: clang-tidy/tool/ClangTidyMain.cpp:281
@@ +280,3 @@
+.push_back(ClangTidyOptions::StringPair(
+Checks, "command-line option '-checks'"));
+ }
alexfh wrote:
> Please pull this string literal to a constan
alexfh added inline comments.
Comment at: docs/clang-tidy/checks/misc-const-ref-builtin.rst:28
@@ +27,2 @@
+
+The instantiation of g will not be flagged.
nit: enclose `g` with double backquotes, please. Same with other inline code
snippets (`int`, `double`, etc.)
kimgr added a comment.
The RUN line looks weird to me, but I'm no lit expert...
Comment at: test/clang-tidy/performance-unnecessary-value-param-delayed.cpp:1
@@ +1,2 @@
+// RUN: %check_clang_tidy %s performance-unnecessary-value-param %t -- --
-fdelayed-template-parsing
+
-
etienneb marked an inline comment as done.
Comment at: test/clang-tidy/performance-unnecessary-value-param-delayed.cpp:1
@@ +1,2 @@
+// RUN: %check_clang_tidy %s performance-unnecessary-value-param %t -- --
-fdelayed-template-parsing
+
kimgr wrote:
> Are the doub
alexfh added a comment.
A couple of nits.
Comment at: clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp:181
@@ +180,3 @@
+ Init->isMemberInitializer()
+ ? static_cast(Init->getMember())
+ : static_cast(
If you're doing th
Author: marshall
Date: Thu Apr 7 13:13:41 2016
New Revision: 265706
URL: http://llvm.org/viewvc/llvm-project?rev=265706&view=rev
Log:
Recommit r263036 with additional inlining, so that it will continue to work
with existing system dylibs. Implements LWG#2583
Modified:
libcxx/trunk/include/s
alexfh added inline comments.
Comment at: test/clang-tidy/cppcoreguidelines-interfaces-global-init.cpp:7
@@ +6,3 @@
+
+extern int ExternGlobal;
+static int GlobalScopeBadInit1 = ExternGlobal;
What happens if you add:
extern int ExternGlobal;
extern int Extern
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: clang-tidy/modernize/UseBoolLiteralsCheck.cpp:39
@@ +38,3 @@
+
+ return LiteralSource.size() >= 1 && isDigit(LiteralSource.front());
+}
Use `!x.empty()` instead
kimgr added inline comments.
Comment at: test/clang-tidy/performance-unnecessary-value-param-delayed.cpp:1
@@ +1,2 @@
+// RUN: %check_clang_tidy %s performance-unnecessary-value-param %t -- --
-fdelayed-template-parsing
+
etienneb wrote:
> kimgr wrote:
> > Are th
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
The main concern here is that the clang-apply-replacements tool should be able
to read this format. See the
clang/tools/extra/clang-tidy/tool/run-clang-tidy.py script for an example
bader added a comment.
In http://reviews.llvm.org/D17821#394620, @Anastasia wrote:
> Yes, I think it's better to go in a separate commit, not to complicate this
> one too much. Also since there are not many comment here, I think we should
> try to commit it ASAP otherwise rebasing would be an i
alexfh added a comment.
Actually, removal of `static` is not the right thing for LLVM:
> Because of this, we have a simple guideline: make anonymous namespaces as
> small as possible, and only use them for class declarations.
http://llvm.org/docs/CodingStandards.html#anonymous-namespaces
Rep
alexfh added a comment.
Richard, is there anything else that blocks this patch?
Comment at: lib/Sema/SemaDecl.cpp:6372
@@ +6371,3 @@
+ if (isa(OldDC)) {
+if (isa(ShadowedDecl))
+ return SDK_Field;
How about `return isa(ShadowedDecl) ? SDK_Field : SDK_S
rsmith requested changes to this revision.
rsmith added a comment.
This revision now requires changes to proceed.
Why do you think this is ill-formed? Using a type with internal linkage as the
type of an extern "C" function is explicitly permitted by the C++ standard.
[basic.link]p8 says:
"A ty
erik.pilkington added a comment.
Ping!
http://reviews.llvm.org/D17451
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: mren
Date: Thu Apr 7 14:30:20 2016
New Revision: 265711
URL: http://llvm.org/viewvc/llvm-project?rev=265711&view=rev
Log:
NFC: simplify code in BuildInstanceMessage.
Instead of searching the global pool multiple times: in
LookupFactoryMethodInGlobalPool, LookupInstanceMethodInGlobalPool,
Author: mren
Date: Thu Apr 7 14:32:24 2016
New Revision: 265712
URL: http://llvm.org/viewvc/llvm-project?rev=265712&view=rev
Log:
[ObjC kindof] Use type bound to filter out the candidate methods.
rdar://21306753
Modified:
cfe/trunk/include/clang/Sema/Sema.h
cfe/trunk/lib/Sema/SemaDeclOb
tmsriram updated this revision to Diff 52945.
tmsriram added a comment.
Cleanup the code to use a local variable to store *Res.getLangOpts()
http://reviews.llvm.org/D18843
Files:
lib/Frontend/CompilerInvocation.cpp
Index: lib/Frontend/CompilerInvocation.cpp
==
Author: kzhuravl
Date: Thu Apr 7 14:54:19 2016
New Revision: 265713
URL: http://llvm.org/viewvc/llvm-project?rev=265713&view=rev
Log:
[AMDGPU] Implement get_local_size for amdgcn--amdhsa triple
Differential Revision: http://reviews.llvm.org/D18284
Added:
libclc/trunk/amdgcn-amdhsa/
libc
rnk added a comment.
We had a conversation about this change around the office the other week, and
people were concerned about false negatives like the trim_in_place one.
Basically, I don't have time to discover all the ways you can modify your
parameters:
struct B {
A a;
B(A a) : a(
rsmith added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:1615
@@ -1614,2 +1614,3 @@
IdResolver.RemoveDecl(D);
+ShadowingDecls.erase(D);
}
This'd be a good place to produce a -Wshadow-constructor or similar warning if
D is still in the map.
===
michael_miller updated this revision to Diff 52950.
michael_miller marked 15 inline comments as done.
michael_miller added a comment.
Removed a superfluous cast and added periods to some comments.
http://reviews.llvm.org/D18584
Files:
clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp
Author: rsmith
Date: Thu Apr 7 15:47:37 2016
New Revision: 265718
URL: http://llvm.org/viewvc/llvm-project?rev=265718&view=rev
Log:
[modules] Allow differences in flags that only affect preprocessor predefines
(and __has_feature checks) between explicitly-specified module files and the
current co
mgehre added a comment.
By the way, is there a tool to generate parts of the test based on clang
output, i.e.
something that will prefix the output of clang with "CHECK: " and "CHECK-NEXT:"
so I can copy-and-paste
it into my test file?
http://reviews.llvm.org/D15031
echristo accepted this revision.
echristo added a comment.
This all seems reasonable to me, one inline rewording comment, and check with
rjmccall before committing.
Thanks!
Comment at: include/clang/Basic/AttrDocs.td:2371
@@ +2370,3 @@
+
+Not all targets support this attribute
korli removed rL LLVM as the repository for this revision.
korli updated this revision to Diff 52953.
korli added a comment.
Thanks for the review, and sorry for the late reply.
This updated diff takes rsmith's comments into account, adding a test
test/Driver/haiku.c, a case for CST_Libcxx where
erik.pilkington created this revision.
erik.pilkington added a reviewer: rsmith.
erik.pilkington added a subscriber: cfe-commits.
Previously, clang would incorrectly reject the following:
```
struct S {};
template struct D : T {};
template void Foo(D);
int fn() {
D, 0> v;
Foo(v);
Author: rsmith
Date: Thu Apr 7 16:46:12 2016
New Revision: 265728
URL: http://llvm.org/viewvc/llvm-project?rev=265728&view=rev
Log:
Replace Sema-level implementation of -fassume-sane-operator-new with a
CodeGen-level implementation. Instead of adding an attribute to clang's
FunctionDecl, add the
rsmith added inline comments.
Comment at: lib/Sema/SemaTemplateDeduction.cpp:1424-1426
@@ -1423,2 +1423,5 @@
+ SmallVector DeducedOrig(Deduced.begin(),
+ Deduced.end());
+
// Try to deduce template arguments fr
mgehre updated this revision to Diff 52959.
mgehre added a comment.
Update for review comments
- Change name from ObjLeavesScope to LifetimeEnds
- Make sure that trivially destructible objects end their lifetime after
non-trivial destructible objects
- Add test
- Add analyzer option to enable Li
rjmccall added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:2371
@@ +2370,3 @@
+
+Not all targets support this attribute. ELF targets support this attribute
when using binutils v2.20.1 or higher and glibc v2.11.1 or higher. Non-ELF
targets currently do not supp
echristo added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:2371
@@ +2370,3 @@
+
+Not all targets support this attribute. ELF targets support this attribute
when using binutils v2.20.1 or higher and glibc v2.11.1 or higher. Non-ELF
targets currently do not supp
erik.pilkington updated this revision to Diff 52961.
erik.pilkington added a comment.
Invert some control flow for clarity, avoid unnecessary copy of deduced
template arguments.
http://reviews.llvm.org/D18868
Files:
lib/Sema/SemaTemplateDeduction.cpp
test/CXX/temp/temp.fct.spec/temp.deduct
jfb created this revision.
jfb added reviewers: jyknight, reames.
jfb added a subscriber: cfe-commits.
Depends on http://reviews.llvm.org/D18875
This makes the C11 / C++11 *ABI* atomic ordering accessible from LLVM, as
discussed in http://reviews.llvm.org/D18200#inline-151433
http://reviews.llv
rsmith accepted this revision.
This revision is now accepted and ready to land.
Comment at: lib/Sema/SemaTemplateDeduction.cpp:1449-1451
@@ +1448,5 @@
+
+ const RecordType *RecordT = Arg->getAs();
+ if (!RecordT)
+return Result;
+
Can you move th
tigerleapgorge created this revision.
tigerleapgorge added a reviewer: rsmith.
tigerleapgorge added a subscriber: cfe-commits.
17 OpenMP tests have their expected diagnostics updated.
The changes to each file are identical.
http://reviews.llvm.org/D18879
Files:
test/OpenMP/for_collapse_message
probinson added a subscriber: probinson.
Comment at: include/clang/Basic/AttrDocs.td:2371
@@ +2370,3 @@
+
+Not all targets support this attribute. ELF targets support this attribute
when using binutils v2.20.1 or higher and glibc v2.11.1 or higher. Non-ELF
targets currently do
jlebar created this revision.
jlebar added a reviewer: rsmith.
jlebar added subscribers: tra, cfe-commits.
See comments in patch; we were assuming that some stdlib math functions
would be defined in namespace std, when in fact the spec says they
should be defined in the global namespace. libstdc+
This revision was automatically updated to reflect the committed changes.
Closed by commit rL265751: [CUDA] Tweak math forward declares so we're
compatible with libstdc++4.9. (authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D18882?vs=52979&id=52980#toc
Repository:
rL LL
1 - 100 of 114 matches
Mail list logo
