r266278 - [Clang][AVX512][Builtin] Adding intrinsics of vpmovus{d|q}{b|w|d}{128|256|512} instruction set

2016-04-13 Thread Michael Zuckerman via cfe-commits
Author: mzuckerm Date: Thu Apr 14 01:48:09 2016 New Revision: 266278 URL: http://llvm.org/viewvc/llvm-project?rev=266278&view=rev Log: [Clang][AVX512][Builtin] Adding intrinsics of vpmovus{d|q}{b|w|d}{128|256|512} instruction set Differential Revision: http://reviews.llvm.org/D19050 Modified:

r266277 - Make sure the LLVMContext outlive the CompilerInstance

2016-04-13 Thread Mehdi Amini via cfe-commits
Author: mehdi_amini Date: Thu Apr 14 00:37:41 2016 New Revision: 266277 URL: http://llvm.org/viewvc/llvm-project?rev=266277&view=rev Log: Make sure the LLVMContext outlive the CompilerInstance From: Mehdi Amini Modified: cfe/trunk/unittests/CodeGen/BufferSourceTest.cpp Modified: cfe/trunk/

r266276 - Do not use llvm:getGlobalContext() in unittests

2016-04-13 Thread Mehdi Amini via cfe-commits
Author: mehdi_amini Date: Thu Apr 14 00:34:32 2016 New Revision: 266276 URL: http://llvm.org/viewvc/llvm-project?rev=266276&view=rev Log: Do not use llvm:getGlobalContext() in unittests Currently trying to nuke this API from LLVM. From: Mehdi Amini Modified: cfe/trunk/unittests/CodeGen/Buf

Re: [PATCH] D18369: [OpenCL] Upstreaming khronos OpenCL 1.2/2.0 header files.

2016-04-13 Thread Xiuli PAN via cfe-commits
pxli168 added inline comments. Comment at: lib/Headers/opencl.h:13721-13726 @@ +13720,8 @@ + +/** + * Queue a memory fence to ensure correct ordering of memory + * operations between work-items of a work-group to + * image memory. + */ +#define CLK_IMAGE_MEM_FENCE 0x04 +

Re: [PATCH] D19071: [OpenCL] Add predefined macros.

2016-04-13 Thread Xiuli PAN via cfe-commits
pxli168 added inline comments. Comment at: lib/Frontend/InitPreprocessor.cpp:421 @@ +420,3 @@ +switch (LangOpts.OpenCLVersion) { +case 0: +case 100: What is 0 stand for as OpenCLVersion, it seems the default OpenCLVersion if we did not pass any -cl-st

Re: [PATCH] D19059: Reorder ASTNodeKind::AllKindInfo to match NodeKindId.

2016-04-13 Thread Alexander Kornienko via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL266268: Reorder ASTNodeKind::AllKindInfo to match NodeKindId. (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D19059?vs=53569&id=53647#toc Repository: rL LLVM http://reviews.l

r266268 - Reorder ASTNodeKind::AllKindInfo to match NodeKindId.

2016-04-13 Thread Alexander Kornienko via cfe-commits
Author: alexfh Date: Wed Apr 13 19:47:40 2016 New Revision: 266268 URL: http://llvm.org/viewvc/llvm-project?rev=266268&view=rev Log: Reorder ASTNodeKind::AllKindInfo to match NodeKindId. Summary: AllKindInfo is being indexed by NodeKindId, so the order must match. Extended ASTTypeTraits tests to

Re: [clang-tools-extra] r266265 - clang-tools-extra/test/clang-tidy/readability-deleted-default.cpp: Add -fno-ms-compatibility.

2016-04-13 Thread Alexander Kornienko via cfe-commits
Thanks! I was planning to do this myself, but got side-tracked. On Thu, Apr 14, 2016 at 1:50 AM, NAKAMURA Takumi via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: chapuni > Date: Wed Apr 13 18:50:45 2016 > New Revision: 266265 > > URL: http://llvm.org/viewvc/llvm-project?rev=266265&v

r266266 - [modules] Remove CXX_BASE_SPECIFIERS_OFFSETS table. Instead of storing an ID of

2016-04-13 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Apr 13 19:29:55 2016 New Revision: 266266 URL: http://llvm.org/viewvc/llvm-project?rev=266266&view=rev Log: [modules] Remove CXX_BASE_SPECIFIERS_OFFSETS table. Instead of storing an ID of a table entry in the corresponding decl, store an offset from the current record to t

[clang-tools-extra] r266265 - clang-tools-extra/test/clang-tidy/readability-deleted-default.cpp: Add -fno-ms-compatibility.

2016-04-13 Thread NAKAMURA Takumi via cfe-commits
Author: chapuni Date: Wed Apr 13 18:50:45 2016 New Revision: 266265 URL: http://llvm.org/viewvc/llvm-project?rev=266265&view=rev Log: clang-tools-extra/test/clang-tidy/readability-deleted-default.cpp: Add -fno-ms-compatibility. Modified: clang-tools-extra/trunk/test/clang-tidy/readability-de

[PATCH] D19084: [clang-analyzer] fix warnings emitted on clang code base

2016-04-13 Thread Apelete Seketeli via cfe-commits
apelete created this revision. apelete added a subscriber: cfe-commits. The following warnings were reported while running clang analyzer on Clang code base: API: argument with 'nonnull' attribute passed null, on file: - lib/AST/NestedNameSpecifier.cpp. Logic error: called C++ object pointer is

r266264 - ObjC kindof: order the methods in global pool relative to availability.

2016-04-13 Thread Manman Ren via cfe-commits
Author: mren Date: Wed Apr 13 18:43:56 2016 New Revision: 266264 URL: http://llvm.org/viewvc/llvm-project?rev=266264&view=rev Log: ObjC kindof: order the methods in global pool relative to availability. r265877 tries to put methods that are deprecated or unavailable to the front of the global poo

Re: [PATCH] D19072: [CodeGen] Split CGDebugInfo into CGDebugInfo and CGDebugDwarf

2016-04-13 Thread Reid Kleckner via cfe-commits
rnk marked 2 inline comments as done. Comment at: lib/CodeGen/CodeGenModule.h:292 @@ -291,3 +291,3 @@ CGCUDARuntime* CUDARuntime; - CGDebugInfo* DebugInfo; + std::unique_ptr DebugInfo; ObjCEntrypoints *ObjCData; echristo wrote: > aprantl wrote: > > This co

r266263 - [CodeGen] Avoid ctor/dtor boilerplate with some C++11

2016-04-13 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Wed Apr 13 18:37:17 2016 New Revision: 266263 URL: http://llvm.org/viewvc/llvm-project?rev=266263&view=rev Log: [CodeGen] Avoid ctor/dtor boilerplate with some C++11 Non-owning pointers that cache LLVM types and constants can use 'nullptr' default member initializers so that we

Re: [PATCH] D19072: [CodeGen] Split CGDebugInfo into CGDebugInfo and CGDebugDwarf

2016-04-13 Thread Eric Christopher via cfe-commits
echristo added inline comments. Comment at: lib/CodeGen/CodeGenModule.h:292 @@ -291,3 +291,3 @@ CGCUDARuntime* CUDARuntime; - CGDebugInfo* DebugInfo; + std::unique_ptr DebugInfo; ObjCEntrypoints *ObjCData; aprantl wrote: > This could be a separate useful N

Re: [PATCH] D19072: [CodeGen] Split CGDebugInfo into CGDebugInfo and CGDebugDwarf

2016-04-13 Thread Adrian Prantl via cfe-commits
aprantl added inline comments. Comment at: lib/CodeGen/CodeGenModule.h:292 @@ -291,3 +291,3 @@ CGCUDARuntime* CUDARuntime; - CGDebugInfo* DebugInfo; + std::unique_ptr DebugInfo; ObjCEntrypoints *ObjCData; This could be a separate useful NFC commit. http:

r266254 - [modules] Remove CXX_CTOR_INITIALIZERS_OFFSETS table. Instead of storing an ID

2016-04-13 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Apr 13 16:57:08 2016 New Revision: 266254 URL: http://llvm.org/viewvc/llvm-project?rev=266254&view=rev Log: [modules] Remove CXX_CTOR_INITIALIZERS_OFFSETS table. Instead of storing an ID of a table entry in the corresponding decl, store an offset from the current record to

Re: [PATCH] D18271: Avoid -Wshadow warnings about constructor parameters named after fields

2016-04-13 Thread Reid Kleckner via cfe-commits
rnk added a comment. ping http://reviews.llvm.org/D18271 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17392: Embed bitcode in object file (clang cc1 part)

2016-04-13 Thread Steven Wu via cfe-commits
steven_wu added a comment. ping. The currently -fembed-bitcode option is only half working. I don't want to leave it like that too long. http://reviews.llvm.org/D17392 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

Re: r266178 - constexpr -> const to appease MSVC bots.

2016-04-13 Thread Sean Silva via cfe-commits
Thanks! -- Sean Silva On Wed, Apr 13, 2016 at 12:47 AM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Wed Apr 13 02:47:38 2016 > New Revision: 266178 > > URL: http://llvm.org/viewvc/llvm-project?rev=266178&view=rev > Log: > constexpr -> const to appe

[PATCH] D19074: [CUDA] removed unneeded __nvvm_reflect_anchor()

2016-04-13 Thread Artem Belevich via cfe-commits
tra created this revision. tra added reviewers: jlebar, majnemer. tra added a subscriber: cfe-commits. Since r265060 LLVM infers correct __nvvm_reflect attributes. http://reviews.llvm.org/D19074 Files: lib/Headers/__clang_cuda_runtime_wrapper.h Index: lib/Headers/__clang_cuda_runtime_wrappe

Re: [PATCH] D18997: [SemaObjC] Properly diagnose type arguments and protocols mix in parameterized classes

2016-04-13 Thread Bruno Cardoso Lopes via cfe-commits
bruno closed this revision. bruno added a comment. Committed r266245 http://reviews.llvm.org/D18997 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r266245 - [SemaObjC] Properly handle mix between type arguments and protocols.

2016-04-13 Thread Bruno Cardoso Lopes via cfe-commits
Author: bruno Date: Wed Apr 13 15:59:07 2016 New Revision: 266245 URL: http://llvm.org/viewvc/llvm-project?rev=266245&view=rev Log: [SemaObjC] Properly handle mix between type arguments and protocols. Under certain conditions clang currently fails to properly diagnostic ObjectC parameter list whe

Re: [PATCH] D18823: Implementation of VlA of GNU C++ extension

2016-04-13 Thread Richard Smith via cfe-commits
rsmith added inline comments. Comment at: llvm/tools/clang/lib/Sema/SemaType.cpp:2163-2165 @@ -2161,3 +2162,5 @@ if (!T->isDependentType() && isCompleteType(Loc, BaseT) && - !BaseT.isPODType(Context) && !BaseT->isObjCLifetimeType()) { + RD && !RD->hasDefau

Re: [PATCH] D19071: [OpenCL] Add predefined macros.

2016-04-13 Thread Alexey Bader via cfe-commits
bader added a comment. LGTM http://reviews.llvm.org/D19071 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16396: Warn if variable cannot be implicitly instantiated

2016-04-13 Thread Richard Smith via cfe-commits
rsmith added a comment. I would prefer to avoid adding the `%qt` format if we can. But if we do provide it, the template parameter names we use should match what was written in the declaration of the template itself. Comment at: lib/AST/Decl.cpp:1423 @@ +1422,3 @@ +/// +/// is

Re: [PATCH] D19063: clang-format: Fixed line merging of more than two lines

2016-04-13 Thread Maxime Beaulieu via cfe-commits
mxbOctasic added inline comments. Comment at: unittests/Format/FormatTest.cpp:285 @@ +284,3 @@ + + EXPECT_EQ("class Foo\n" +"{\n" djasper wrote: > How does this break? I generally add an Before and After of one of the test > cases into my patch descr

r266242 - Make sure CheckDestructor gets called on dllimported classes if the vtable is used (PR27319)

2016-04-13 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Apr 13 15:21:15 2016 New Revision: 266242 URL: http://llvm.org/viewvc/llvm-project?rev=266242&view=rev Log: Make sure CheckDestructor gets called on dllimported classes if the vtable is used (PR27319) Modified: cfe/trunk/lib/Sema/SemaDeclCXX.cpp cfe/trunk/test/Code

Re: [PATCH] D14274: Add alloc_size attribute to clang

2016-04-13 Thread George Burgess IV via cfe-commits
george.burgess.iv updated this revision to Diff 53611. george.burgess.iv added a comment. Now that `allocsize` is in LLVM (r266032), this isn't blocked. Yay! Rebased, added a few tests, did a few tiny refactors, and fixed an overflow bug when the user tried to allocate `2**63 < N < 2**64` bytes

[PATCH] D19071: [OpenCL] Add predefined macros.

2016-04-13 Thread Yaxun Liu via cfe-commits
yaxunl created this revision. yaxunl added reviewers: Anastasia, bader, pxli168. yaxunl added subscribers: tstellarAMD, cfe-commits. OpenCL spec 1.2/2.0 requires `__OPENCL_C_VERSION__` to be defined based on -cl-std option. This patch implements that. OpenCL spec 1.0/1.1 does not have a predefin

Re: [PATCH] D19014: [clang-tidy] Add new checker for suspicious sizeof expressions

2016-04-13 Thread Etienne Bergeron via cfe-commits
etienneb updated this revision to Diff 53609. etienneb marked 2 inline comments as done. etienneb added a comment. alexfh@ comment: top-down approach. http://reviews.llvm.org/D19014 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/SizeofExpressionCh

Re: [PATCH] D19014: [clang-tidy] Add new checker for suspicious sizeof expressions

2016-04-13 Thread Etienne Bergeron via cfe-commits
etienneb added inline comments. Comment at: clang-tidy/misc/SizeofExpressionCheck.cpp:28 @@ +27,3 @@ + return Node.getValue().getZExtValue() > N; +} + alexfh wrote: > There are no firm rules. It mostly depends on how generic/useful in other > tools the matcher c

Re: [PATCH] D19064: clang-format: Allow include of clangFormat.h in managed context

2016-04-13 Thread Maxime Beaulieu via cfe-commits
mxbOctasic updated this revision to Diff 53608. mxbOctasic added a comment. Removed empty line. http://reviews.llvm.org/D19064 Files: include/clang/Format/Format.h lib/Format/Format.cpp Index: lib/Format/Format.cpp === --- lib

Re: [PATCH] D19068: Lit C++11 Compatibility Patch #7

2016-04-13 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL266239: Lit C++11 Compatibility Patch #7 (authored by lcharles). Changed prior to commit: http://reviews.llvm.org/D19068?vs=53603&id=53607#toc Repository: rL LLVM http://reviews.llvm.org/D19068 Fil

r266239 - Lit C++11 Compatibility Patch #7

2016-04-13 Thread Charles Li via cfe-commits
Author: lcharles Date: Wed Apr 13 15:00:45 2016 New Revision: 266239 URL: http://llvm.org/viewvc/llvm-project?rev=266239&view=rev Log: Lit C++11 Compatibility Patch #7 13 tests have been updated for C++11 compatibility. Differential Revision: http://reviews.llvm.org/D19068 Modified: cfe/trun

Re: [PATCH] D18596: [MSVC] PR27132: Proper mangling for __unaligned qualifier

2016-04-13 Thread Reid Kleckner via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Thanks! This looks great. Comment at: test/SemaCXX/MicrosoftExtensions.cpp:89 @@ +88,3 @@ +void foo_unaligned(int *arg) {} +void foo_unaligned(__unaligned int *arg) {} +void foo_una

Re: [PATCH] D19069: clang-format: Fixed various brace wrapping and block merging bugs

2016-04-13 Thread Daniel Jasper via cfe-commits
djasper added inline comments. Comment at: lib/Format/UnwrappedLineParser.cpp:1388-1390 @@ -1372,3 +1387,5 @@ parseBlock(/*MustBeDeclaration=*/false); -if (Style.BraceWrapping.BeforeElse) +if (Style.BraceWrapping.BeforeElse || +Style.BraceWrapping.AfterControl

Re: [PATCH] D19065: clang-format: Last line in incomplete block is indented incorrectly

2016-04-13 Thread Daniel Jasper via cfe-commits
djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D19065 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

Re: [PATCH] D19064: clang-format: Allow include of clangFormat.h in managed context

2016-04-13 Thread Daniel Jasper via cfe-commits
djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. Comment at: include/clang/Format/Format.h:30 @@ +29,3 @@ +namespace vfs { + +class FileSystem; nit: Remove this empty line. http://reviews.llv

Re: [PATCH] D19063: clang-format: Fixed line merging of more than two lines

2016-04-13 Thread Daniel Jasper via cfe-commits
djasper added a comment. Nice catch. Comment at: unittests/Format/FormatTest.cpp:285 @@ +284,3 @@ + + EXPECT_EQ("class Foo\n" +"{\n" How does this break? I generally add an Before and After of one of the test cases into my patch descriptions. htt

Re: [PATCH] D19058: clang-format: Pointer `*` is seen as multiplication in C-style casts

2016-04-13 Thread Daniel Jasper via cfe-commits
djasper added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:1272 @@ +1271,3 @@ +// Casts are never binary operators, regardless of IsExpression +if (NextToken->isOneOf(tok::r_paren, tok::greater)) + return TT_PointerOrReference; I think i

r266233 - [VFS] Move default values to in-class member initialization. NFC

2016-04-13 Thread Bruno Cardoso Lopes via cfe-commits
Author: bruno Date: Wed Apr 13 14:28:16 2016 New Revision: 266233 URL: http://llvm.org/viewvc/llvm-project?rev=266233&view=rev Log: [VFS] Move default values to in-class member initialization. NFC Modified: cfe/trunk/lib/Basic/VirtualFileSystem.cpp Modified: cfe/trunk/lib/Basic/VirtualFileSy

r266234 - [CrashReproducer] Setup 'use-external-names' in YAML files.

2016-04-13 Thread Bruno Cardoso Lopes via cfe-commits
Author: bruno Date: Wed Apr 13 14:28:21 2016 New Revision: 266234 URL: http://llvm.org/viewvc/llvm-project?rev=266234&view=rev Log: [CrashReproducer] Setup 'use-external-names' in YAML files. Hide the real paths when rebuilding from VFS by setting up the crash reproducer to use 'use-external-name

r266235 - [CrashReproducer] Add test to run the reproducer script + modules

2016-04-13 Thread Bruno Cardoso Lopes via cfe-commits
Author: bruno Date: Wed Apr 13 14:28:24 2016 New Revision: 266235 URL: http://llvm.org/viewvc/llvm-project?rev=266235&view=rev Log: [CrashReproducer] Add test to run the reproducer script + modules Now that we have basic support in place, make sure the reproducer script works with modules for a s

Re: [PATCH] D18265: [clang-tidy] New: checker misc-assign-operator-return

2016-04-13 Thread Samuel Benzaquen via cfe-commits
sbenza added inline comments. Comment at: clang-tidy/misc/AssignOperatorCheck.cpp:63 @@ +62,3 @@ + + Finder->addMatcher(returnStmt(IsBadReturnStatement, hasAncestor(IsGoodAssign)) + .bind("returnStmt"), baloghadamsoftware wrote: > sbenza

Re: [PATCH] D19069: clang-format: Fixed various brace wrapping and block merging bugs

2016-04-13 Thread Maxime Beaulieu via cfe-commits
mxbOctasic added inline comments. Comment at: lib/Format/UnwrappedLineParser.cpp:789-790 @@ -773,4 +788,4 @@ if (FormatTok->Tok.is(tok::l_brace)) { -if (Style.BraceWrapping.AfterObjCDeclaration) - addUnwrappedLine(); +CompoundStatementIndenter Inden

[PATCH] D19069: clang-format: Fixed various brace wrapping and block merging bugs

2016-04-13 Thread Maxime Beaulieu via cfe-commits
mxbOctasic created this revision. mxbOctasic added a reviewer: djasper. mxbOctasic added subscribers: cameron314, cfe-commits. Herald added a subscriber: klimek. Multiple brace wrapping flag combination were broken. First, IndentBraces + !AfterControlStatement caused the whole If-Else construct

Re: [PATCH] D19066: clang-format: `SpaceAfterTemplate` and `SpacesInBraces` options

2016-04-13 Thread Daniel Jasper via cfe-commits
djasper added a comment. Please read http://clang.llvm.org/docs/ClangFormatStyleOptions.html#adding-additional-style-options. The "template" option was discussed multiple times and I remain convinced that the costs outweigh the benefit here. For the other option: - Can you make statements wrt

[PATCH] D19068: Lit C++11 Compatibility Patch #7

2016-04-13 Thread Charles Li via cfe-commits
tigerleapgorge created this revision. tigerleapgorge added a reviewer: rsmith. tigerleapgorge added a subscriber: cfe-commits. 13 tests have been updated for C++11 compatibility. CXX/class.access/class.access.dcl/p1.cpp Access declarations are deprecated in C++11. As a result, there are 4 ty

r266226 - Remove redundant null-check; NFC

2016-04-13 Thread Hubert Tong via cfe-commits
Author: hubert.reinterpretcast Date: Wed Apr 13 13:41:03 2016 New Revision: 266226 URL: http://llvm.org/viewvc/llvm-project?rev=266226&view=rev Log: Remove redundant null-check; NFC Modified: cfe/trunk/lib/Parse/ParseDeclCXX.cpp Modified: cfe/trunk/lib/Parse/ParseDeclCXX.cpp URL: http://llv

r266224 - libclang: Use early-return to reduce indentation.

2016-04-13 Thread David Blaikie via cfe-commits
Author: dblaikie Date: Wed Apr 13 13:36:19 2016 New Revision: 266224 URL: http://llvm.org/viewvc/llvm-project?rev=266224&view=rev Log: libclang: Use early-return to reduce indentation. & since I'll get blamed for all the lines anyway, remove some else-after-return and otherwise tidy things up. M

Re: r265994 - libclang: fix two memory leaks (PR26292)

2016-04-13 Thread David Blaikie via cfe-commits
Didn't seem to be too invasive - r266222. On Tue, Apr 12, 2016 at 10:54 AM, Hans Wennborg wrote: > While useful, that would require a lot of restructuring, I think. > > This file seems to mostly be dealing with C-style objects; > ExprEvalResult doesn't even have a C++ destructor. I'm not going t

r266222 - Simplify memory management of CXEvalResultKind/ExprEvalResult using unique_ptr and a dtor

2016-04-13 Thread David Blaikie via cfe-commits
Author: dblaikie Date: Wed Apr 13 13:23:33 2016 New Revision: 266222 URL: http://llvm.org/viewvc/llvm-project?rev=266222&view=rev Log: Simplify memory management of CXEvalResultKind/ExprEvalResult using unique_ptr and a dtor This doesn't seem to need to be a C type, C only handles a void*, so us

[PATCH] D19066: clang-format: `SpaceAfterTemplate` and `SpacesInBraces` options

2016-04-13 Thread Maxime Beaulieu via cfe-commits
mxbOctasic created this revision. mxbOctasic added a reviewer: djasper. mxbOctasic added subscribers: cameron314, cfe-commits. Herald added a subscriber: klimek. This patch adds two new spacing options. `SpaceAfterTemplate` inserts a space between the template keyword and the opening chevron. `

r266219 - [analyzer] Nullability: Suppress diagnostic on bind with cast.

2016-04-13 Thread Devin Coughlin via cfe-commits
Author: dcoughlin Date: Wed Apr 13 12:59:24 2016 New Revision: 266219 URL: http://llvm.org/viewvc/llvm-project?rev=266219&view=rev Log: [analyzer] Nullability: Suppress diagnostic on bind with cast. Update the nullability checker to allow an explicit cast to nonnull to suppress a warning on an as

[PATCH] D19063: clang-format: Fixed line merging of more than two lines

2016-04-13 Thread Maxime Beaulieu via cfe-commits
mxbOctasic created this revision. mxbOctasic added a reviewer: djasper. mxbOctasic added subscribers: cameron314, cfe-commits. Herald added a subscriber: klimek. `getNextMergedLine` merged pairs of adjacent lines instead of merging them all with the first one. Consider `AnnotatedLine` `A`, `B` a

[PATCH] D19064: clang-format: Allow include of clangFormat.h in managed context

2016-04-13 Thread Maxime Beaulieu via cfe-commits
mxbOctasic created this revision. mxbOctasic added a reviewer: djasper. mxbOctasic added subscribers: cameron314, cfe-commits. Herald added a subscriber: klimek. Including `VirtualFileSystem.h` in the clangFormat.h indirectly includes ``. This header is blocked when compiling with /clr. I added a

[PATCH] D19065: clang-format: Last line in incomplete block is indented incorrectly

2016-04-13 Thread Maxime Beaulieu via cfe-commits
mxbOctasic created this revision. mxbOctasic added a reviewer: djasper. mxbOctasic added subscribers: cameron314, cfe-commits. Herald added a subscriber: klimek. This bug occurred when the end of the file was reached while parsing a block. The indentation of the last line was reset to the initial

Re: [PATCH] D19056: [MSVC] Fix check for wchar_t type in case of -fno-wchar

2016-04-13 Thread Reid Kleckner via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: test/SemaCXX/no-wchar.cpp:12 @@ +11,2 @@ +void foo1(wchar_t * t = L""); +// expected-warning@-1 {{conversion from string literal to 'wchar_t *' (aka 'unsigned shor

Re: [PATCH] D18821: Add modernize-bool-to-integer-conversion

2016-04-13 Thread Piotr Padlewski via cfe-commits
Prazek added a comment. In http://reviews.llvm.org/D18821#399079, @alexfh wrote: > In http://reviews.llvm.org/D18821#399064, @Prazek wrote: > > > In http://reviews.llvm.org/D18821#398843, @alexfh wrote: > > > > > BTW, why is the check in the 'modernize' module? It doesn't seem to make > > > anyt

r266213 - [OrderFiles] Don't allow lit to run dtrace multithreaded

2016-04-13 Thread Chris Bieneman via cfe-commits
Author: cbieneman Date: Wed Apr 13 12:12:56 2016 New Revision: 266213 URL: http://llvm.org/viewvc/llvm-project?rev=266213&view=rev Log: [OrderFiles] Don't allow lit to run dtrace multithreaded Dtrace is implemented to try and minimize performance impact on the process being traced. This results

r266212 - AArch64: allow 64-bit access to sysregs.

2016-04-13 Thread Tim Northover via cfe-commits
Author: tnorthover Date: Wed Apr 13 12:08:55 2016 New Revision: 266212 URL: http://llvm.org/viewvc/llvm-project?rev=266212&view=rev Log: AArch64: allow 64-bit access to sysregs. Although all the registers are actually 32-bits, I think we have to assume the high 32-bits could be RES0 (the ARM ARM

r266211 - ARM: make Darwin's "-arch armv7em" default to hard-float.

2016-04-13 Thread Tim Northover via cfe-commits
Author: tnorthover Date: Wed Apr 13 12:08:51 2016 New Revision: 266211 URL: http://llvm.org/viewvc/llvm-project?rev=266211&view=rev Log: ARM: make Darwin's "-arch armv7em" default to hard-float. We've already paid the price for separate "armv7m" and "armv7em" slices (support in other tools), it's

[libcxx] r266209 - Qualify calls to addressof to avoid getting ADL. Fixes PR#27254.

2016-04-13 Thread Marshall Clow via cfe-commits
Author: marshall Date: Wed Apr 13 12:02:23 2016 New Revision: 266209 URL: http://llvm.org/viewvc/llvm-project?rev=266209&view=rev Log: Qualify calls to addressof to avoid getting ADL. Fixes PR#27254. Modified: libcxx/trunk/include/__mutex_base libcxx/trunk/include/shared_mutex Modified:

Re: [PATCH] D18637: Extract key to avoid preemptive mallocs in insert/emplace in associative containers

2016-04-13 Thread Duncan P. N. Exon Smith via cfe-commits
> On 2016-Apr-13, at 09:50, Eric Fiselier wrote: > > EricWF added inline comments. > > > Comment at: > test/std/containers/associative/set/insert_and_emplace_allocator_requirements.pass.cpp:29 > @@ +28,3 @@ > +template > +void PrintInfo(int line, Arg&& arg) > +{ > ---

Re: [PATCH] D18637: Extract key to avoid preemptive mallocs in insert/emplace in associative containers

2016-04-13 Thread Eric Fiselier via cfe-commits
EricWF added inline comments. Comment at: test/std/containers/associative/set/insert_and_emplace_allocator_requirements.pass.cpp:29 @@ +28,3 @@ +template +void PrintInfo(int line, Arg&& arg) +{ mclow.lists wrote: > In general, we want tests to be silent on succe

Re: [PATCH] D18217: [libcxx] Fix -Wdeprecated warnings

2016-04-13 Thread don hinton via cfe-commits
hintonda added a comment. Will do -- moved and started new job, so got a bit behind. Btw, I have a new checker that's under review that will take care of the noexcept for you. And I think someone else has something that might take care of the implicit copy/assignment. So this should be trivia

Re: [PATCH] D18876: NFC: unify clang / LLVM atomic ordering

2016-04-13 Thread James Y Knight via cfe-commits
jyknight added a comment. The large amount of casting to/from integers for AtomicOrderingCABI makes me think that it probably ought not actually be converted to an enum class after all. http://reviews.llvm.org/D18876 ___ cfe-commits mailing list c

Re: [PATCH] D17469: [libcxx] Add deployment knobs to tests (for Apple platforms)

2016-04-13 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. This direction looks fine to me. All the test changes look fine to me. http://reviews.llvm.org/D17469 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D19062: Add functions in ctype.h to builtin function database (Fix)

2016-04-13 Thread Taewook Oh via cfe-commits
twoh created this revision. twoh added a reviewer: aaron.ballman. twoh added subscribers: joerg, cfe-commits, rsmith. Add functions declared in ctype.h to builtin function database. All functions are annotated with nothrow and const attribute, which enables better optimization. This patch has

Re: [PATCH] D18217: [libcxx] Fix -Wdeprecated warnings

2016-04-13 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. Let's retire this patch, then. I'll be watching for your replacement patches. http://reviews.llvm.org/D18217 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

Re: [PATCH] D18637: Extract key to avoid preemptive mallocs in insert/emplace in associative containers

2016-04-13 Thread Marshall Clow via cfe-commits
mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. This looks good to me, except for the noisy tests. Comment at: test/std/containers/associative/set/insert_and_emplace_allocator_requirements.pass.cpp:29 @@ +28,3 @@

Re: [PATCH] D19059: Reorder ASTNodeKind::AllKindInfo to match NodeKindId.

2016-04-13 Thread Alexander Kornienko via cfe-commits
alexfh marked an inline comment as done. alexfh added a comment. http://reviews.llvm.org/D19059 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19059: Reorder ASTNodeKind::AllKindInfo to match NodeKindId.

2016-04-13 Thread Alexander Kornienko via cfe-commits
alexfh updated this revision to Diff 53569. alexfh added a comment. Added a Decl descendant for a test. http://reviews.llvm.org/D19059 Files: lib/AST/ASTTypeTraits.cpp unittests/AST/ASTTypeTraitsTest.cpp unittests/ASTMatchers/Dynamic/ParserTest.cpp unittests/ASTMatchers/Dynamic/Registry

Re: [PATCH] D19059: Reorder ASTNodeKind::AllKindInfo to match NodeKindId.

2016-04-13 Thread Samuel Benzaquen via cfe-commits
sbenza added a comment. Those tests are testing the code completion you get in clang-query. The type list must match what that matcher supports. `hasParent` is declared as const internal::ArgumentAdaptingMatcherFunc< internal::HasParentMatcher, internal::TypeList, internal::T

Re: [PATCH] D19059: Reorder ASTNodeKind::AllKindInfo to match NodeKindId.

2016-04-13 Thread Alexander Kornienko via cfe-commits
alexfh updated this revision to Diff 53566. alexfh added a comment. - Added a test http://reviews.llvm.org/D19059 Files: lib/AST/ASTTypeTraits.cpp unittests/AST/ASTTypeTraitsTest.cpp unittests/ASTMatchers/Dynamic/ParserTest.cpp unittests/ASTMatchers/Dynamic/RegistryTest.cpp Index: unit

[PATCH] D19058: clang-format: Pointer `*` is seen as multiplication in C-style casts

2016-04-13 Thread Maxime Beaulieu via cfe-commits
mxbOctasic created this revision. mxbOctasic added a reviewer: djasper. mxbOctasic added subscribers: cameron314, cfe-commits. Herald added a subscriber: klimek. The `*` was treated as multiplication operator in complex pointer type casts. e.g. (type *const)bar (type *restrict)bar Patch by came

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

2016-04-13 Thread Nemanja Ivanovic via cfe-commits
nemanjai closed this revision. nemanjai added a comment. Committed revision 266186. Repository: rL LLVM http://reviews.llvm.org/D15120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D19059: Reorder ASTNodeKind::AllKindInfo to match NodeKindId.

2016-04-13 Thread Alexander Kornienko via cfe-commits
alexfh created this revision. alexfh added a reviewer: sbenza. alexfh added a subscriber: cfe-commits. Herald added a subscriber: klimek. AllKindInfo is being indexed by NodeKindId, so the order must match. I've updated the tests, though I'm not sure what exactly they verify and whether the new st

r266202 - [Clang][AVX512][Builtin] Adding support to intrinsics of pmovs{d|q}{b|w|d}{128|256|512} instruction set

2016-04-13 Thread Michael Zuckerman via cfe-commits
Author: mzuckerm Date: Wed Apr 13 10:02:04 2016 New Revision: 266202 URL: http://llvm.org/viewvc/llvm-project?rev=266202&view=rev Log: [Clang][AVX512][Builtin] Adding support to intrinsics of pmovs{d|q}{b|w|d}{128|256|512} instruction set Differential Revision: http://reviews.llvm.org/D19023 M

Re: [PATCH] D18970: Add functions in ctype.h to builtin function database

2016-04-13 Thread Taewook Oh via cfe-commits
Sure, I'll take a look. Thanks! -- Taewook On 4/13/16, 8:00 AM, "Aaron Ballman" wrote: >aaron.ballman added a comment. > >I reverted this in r266201; it was causing build bot failures like: > >https://urldefense.proofpoint.com/v2/url?u=http-3A__lab.llvm.org-3A8011_bu >ilders_clang-2Dppc64be-2Dl

Re: [PATCH] D18970: Add functions in ctype.h to builtin function database

2016-04-13 Thread Aaron Ballman via cfe-commits
aaron.ballman added a comment. I reverted this in r266201; it was causing build bot failures like: http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/3517 Can you please take a look? Thanks! http://reviews.llvm.org/D18970 ___ cfe-commit

r266201 - Reverting r266199; it causes build bot failures.

2016-04-13 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Wed Apr 13 09:53:52 2016 New Revision: 266201 URL: http://llvm.org/viewvc/llvm-project?rev=266201&view=rev Log: Reverting r266199; it causes build bot failures. http://lab.llvm.org:8011/builders/clang-s390x-linux/builds/3255 http://lab.llvm.org:8011/builders/clang-ppc64

[PATCH] D19057: [analyzer] Let TK_PreserveContents span across the whole base region.

2016-04-13 Thread Artem Dergachev via cfe-commits
NoQ created this revision. NoQ added reviewers: zaks.anna, dcoughlin. NoQ added a subscriber: cfe-commits. Essentially, if `s` is a structure, and `foo(const void *)` is evaluated conservatively, then `foo(&s)` does not invalidate `s`, but `foo(&(s.x))` invalidates the whole `s`, because the sto

Re: [PATCH] D18970: Add functions in ctype.h to builtin function database

2016-04-13 Thread Aaron Ballman via cfe-commits
aaron.ballman closed this revision. aaron.ballman added a comment. Commit in r266199, thank you! http://reviews.llvm.org/D18970 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r266199 - Add functions declared in ctype.h to builtin function database. All functions are annotated with nothrow and pure attribute, which enables better optimization.

2016-04-13 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Wed Apr 13 08:55:58 2016 New Revision: 266199 URL: http://llvm.org/viewvc/llvm-project?rev=266199&view=rev Log: Add functions declared in ctype.h to builtin function database. All functions are annotated with nothrow and pure attribute, which enables better optimizatio

Re: [PATCH] D19014: [clang-tidy] Add new checker for suspicious sizeof expressions

2016-04-13 Thread Malcolm Parsons via cfe-commits
malcolm.parsons added a subscriber: malcolm.parsons. Comment at: docs/clang-tidy/checks/misc-sizeof-expression.rst:16 @@ +15,3 @@ +A common mistake is to query the ``sizeof`` of an integer literal. This is +equivalent to query the size of it's type (probably ``int``). The intent o

Re: [PATCH] D18823: Implementation of VlA of GNU C++ extension

2016-04-13 Thread Vladimir Yakovlev via cfe-commits
vbyakovl updated this revision to Diff 53548. vbyakovl added a comment. Sema/SemaType.cpp: Vla works in C++ by default. An error is printed if a class has not default constructor. test/SemaCXX/c99-variable-length-array.cpp: Changes is removed test/SemaCXX/vla.cpp: changes is removed. test/CodeGen

r266198 - [OPENMP 4.0] Fixed DSA analysis for taskloop directives.

2016-04-13 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Wed Apr 13 08:36:48 2016 New Revision: 266198 URL: http://llvm.org/viewvc/llvm-project?rev=266198&view=rev Log: [OPENMP 4.0] Fixed DSA analysis for taskloop directives. Patch make clang to perform analysis for task-based directives also for taskloop-based directives. Modifi

Re: [PATCH] D16396: Warn if variable cannot be implicitly instantiated

2016-04-13 Thread Serge Pavlov via cfe-commits
sepavloff updated this revision to Diff 53547. sepavloff added a comment. Updated patch according to review notes. The patch adds diagnostics for undefined function templates, in a similar way as for template variables. These two warnings are classified into different groups. Warnings on undefin

r266195 - [Clang][AVX512][Builtin] Adding support for VBROADCAST and VPBROADCASTB/W/D/Q instruction set

2016-04-13 Thread Michael Zuckerman via cfe-commits
Author: mzuckerm Date: Wed Apr 13 07:58:01 2016 New Revision: 266195 URL: http://llvm.org/viewvc/llvm-project?rev=266195&view=rev Log: [Clang][AVX512][Builtin] Adding support for VBROADCAST and VPBROADCASTB/W/D/Q instruction set Differential Revision: http://reviews.llvm.org/D19012 Modified:

Re: [PATCH] D18473: AMDGPU: Add test for generic builtin behavior

2016-04-13 Thread Tom Stellard via cfe-commits
tstellarAMD accepted this revision. This revision is now accepted and ready to land. Comment at: lib/Basic/Targets.cpp:1854-1857 @@ -1853,1 +1853,6 @@ + bool isCLZForZeroUndef() const override { +// It is -1 instead of expected for intrinsic. +return true; + } + --

Re: [PATCH] D18652: [Inline asm] Correctly parse GCC-style asm line following MS-style asm line

2016-04-13 Thread Denis Zobnin via cfe-commits
d.zobnin.bugzilla added a reviewer: rsmith. d.zobnin.bugzilla removed a subscriber: rsmith. d.zobnin.bugzilla updated this revision to Diff 53543. d.zobnin.bugzilla added a comment. Richard, thank you for the review! I've created a static function to check if this is a GCC asm statement as you r

r266166 - [PPC64][VSX] Add a couple of new data types for vec_vsx_ld and vec_vsx_st intrinsics and fix incorrect testcases with minor refactoring

2016-04-13 Thread Chuang-Yu Cheng via cfe-commits
Author: cycheng Date: Wed Apr 13 00:16:31 2016 New Revision: 266166 URL: http://llvm.org/viewvc/llvm-project?rev=266166&view=rev Log: [PPC64][VSX] Add a couple of new data types for vec_vsx_ld and vec_vsx_st intrinsics and fix incorrect testcases with minor refactoring New added data types: ve

[PATCH] D19056: [MSVC] Fix check for wchar_t type in case of -fno-wchar

2016-04-13 Thread Dmitry Polukhin via cfe-commits
DmitryPolukhin created this revision. DmitryPolukhin added a reviewer: rnk. DmitryPolukhin added a subscriber: cfe-commits. The example below should work identically with and without compiler native wchar_t support. void foo(wchar_t * t = L""); http://reviews.llvm.org/D19056 Files: lib/Sema/

[clang-tools-extra] r266191 - Complete support for C++ Core Guidelines Type.6: Always initialize a member variable.

2016-04-13 Thread Alexander Kornienko via cfe-commits
Author: alexfh Date: Wed Apr 13 06:35:47 2016 New Revision: 266191 URL: http://llvm.org/viewvc/llvm-project?rev=266191&view=rev Log: Complete support for C++ Core Guidelines Type.6: Always initialize a member variable. Summary: Added the remaining features needed to satisfy C++ Core Guideline T

Re: [PATCH] D18584: Complete support for C++ Core Guidelines Type.6: Always initialize a member variable.

2016-04-13 Thread Alexander Kornienko via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL266191: Complete support for C++ Core Guidelines Type.6: Always initialize a member… (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D18584?vs=53480&id=53537#toc Repository: rL

Re: [PATCH] D18961: Add a readability-deleted-default clang-tidy check.

2016-04-13 Thread Alexander Kornienko via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL266190: [clang-tidy] Add a readability-deleted-default clang-tidy check. (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D18961?vs=53533&id=53536#toc Repository: rL LLVM http:

[clang-tools-extra] r266190 - [clang-tidy] Add a readability-deleted-default clang-tidy check.

2016-04-13 Thread Alexander Kornienko via cfe-commits
Author: alexfh Date: Wed Apr 13 06:33:40 2016 New Revision: 266190 URL: http://llvm.org/viewvc/llvm-project?rev=266190&view=rev Log: [clang-tidy] Add a readability-deleted-default clang-tidy check. Checks if constructors and assignment operators that are marked '= default' are actually deleted by

Re: [PATCH] D17815: [libc++abi] Use fallback_malloc to allocate __cxa_eh_globals in case of dynamic memory exhaustion.

2016-04-13 Thread Igor Kudrin via cfe-commits
ikudrin added a comment. Ping... http://reviews.llvm.org/D17815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   >