Re: [PATCH] D20942: [LockFileManager] Improve error output by adding error messages

benlangmuir accepted this revision. benlangmuir added a comment. This revision is now accepted and ready to land. LGTM. Some minor suggestions. Comment at: include/llvm/Support/LockFileManager.h:87 @@ +86,3 @@ + + /// \brief Get error message + std::string getErrorMessage()

Re: [PATCH] D20929: [libcxx] Fix join.pass.cpp segfault after r271475

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. Thanks for the patch. http://reviews.llvm.org/D20929 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20909: [clang-tidy] Ignore function context in misc-unused-using-decls.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:109 @@ -100,1 +108,3 @@ + // giving an incorrect message, we mark all of them as used. for (auto : Contexts) { +

Re: Don't pass --build-id by default.

- Original Message - > From: "Rafael Espíndola" > To: "Hal Finkel" > Cc: "cfe-commits cfe" > Sent: Thursday, June 2, 2016 7:06:26 PM > Subject: Re: Don't pass --build-id by default. > > > This is going to break a

cmake patch for building latest clang vs latest llvm

This patch adjusts the path for the cmake directory to work properly on systems with libsuffix=64. Not sure if it is the preferred way of fixing that but it fixed the build for me. --- CMakeLists.txt.old 2016-06-03 00:19:08.676041254 +0200 +++ CMakeLists.txt 2016-06-03 00:19:48.778920468 +0200 @@

Re: [PATCH] D18035: [GCC] PR23529 Mangler part of attrbute abi_tag support

hfinkel added a subscriber: hfinkel. hfinkel added a comment. FYI: There is now a specification, see: http://sourcerytools.com/pipermail/cxx-abi-dev/2016-June/002919.html http://reviews.llvm.org/D18035 ___ cfe-commits mailing list

Re: [PATCH] D20942: [LockFileManager] Improve error output by adding error messages

bruno added a subscriber: llvm-commits. bruno added a comment. Adding the right list for this +llvm-commits http://reviews.llvm.org/D20942 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D20942: [LockFileManager] Improve error output by adding error messages

bruno created this revision. bruno added a reviewer: benlangmuir. bruno added subscribers: cfe-commits, dexonsmith. This is currently used by clang to lock access to modules; improve the error message so that clang can use better output messages from locking error issues.

Re: Don't pass --build-id by default.

On 2 June 2016 at 17:06, Rafael Espíndola wrote: >> This is going to break a lot of my local rpm packaging scripts, and I >> suspect the same is true for others. This is not a huge deal, but I wonder >> if we should emulate GCC is this regard and provide some CMake

Re: Don't pass --build-id by default.

> This is going to break a lot of my local rpm packaging scripts, and I suspect > the same is true for others. This is not a huge deal, but I wonder if we > should emulate GCC is this regard and provide some CMake option to keep the > current behavior? Yes, a cmake option is probably best.

r271609 - Delete configure left over.

Author: rafael Date: Thu Jun 2 18:45:37 2016 New Revision: 271609 URL: http://llvm.org/viewvc/llvm-project?rev=271609=rev Log: Delete configure left over. Removed: cfe/trunk/include/clang/Config/config.h.in Removed: cfe/trunk/include/clang/Config/config.h.in URL:

[PATCH] D20939: Update for DiagnosticInfoStackSize changes

arsenm created this revision. arsenm added a subscriber: cfe-commits. http://reviews.llvm.org/D20939 Files: lib/CodeGen/CodeGenAction.cpp test/Misc/backend-resource-limit-diagnostics.cl Index: test/Misc/backend-resource-limit-diagnostics.cl

Re: [PATCH] D20903: Make system_error::message() thread safe. Fixes PR25598.

erik65536 added a subscriber: erik65536. erik65536 added a comment. The C++ spec states that `error_category::message()` shall not change the value of `errno` (See section 19.5). So `errno` will have to be saved and restored if `strerror_r()` fails. The POSIX version of `strerror_r()` returns

Re: Don't pass --build-id by default.

- Original Message - > From: "Rafael Espíndola via cfe-commits" > To: "cfe-commits cfe" > Sent: Thursday, June 2, 2016 5:55:25 PM > Subject: Don't pass --build-id by default. > > We do it just because gcc in some distributions do

Re: Don't pass --build-id by default.

I'm not a person who can sign it off, but it looks good to me. On Thu, Jun 2, 2016 at 3:55 PM, Rafael Espíndola wrote: > We do it just because gcc in some distributions do it. > > I can see why --build-id is useful for distributions, but given the > cost on day to

Re: [PATCH] D20933: Preallocate ExplodedNode hash table

zaks.anna added a comment. Does FoldingSet already have reserve? (I do not see it.) My understanding is that you propose to allocate all the nodes that would be required to store the maximum number of nodes we allow, lowering the malloc traffic. The current implementation just doubles the

Don't pass --build-id by default.

We do it just because gcc in some distributions do it. I can see why --build-id is useful for distributions, but given the cost on day to day edit+build cycles, any distro using clang should really just pass -Wl,--build-id in rpmbuild (or corresponding tool). Even upstream gcc is not as

Re: [PATCH] D20929: [libcxx] Fix join.pass.cpp segfault after r271475

rmaprath added a comment. Will commit tomorrow if there are no objections. Feel free to commit if it looks all right. / Asiri http://reviews.llvm.org/D20929 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D20933: Preallocate ExplodedNode hash table

bcraig created this revision. bcraig added reviewers: zaks.anna, krememek, jordan_rose. bcraig added a subscriber: cfe-commits. This depends on http://reviews.llvm.org/D20930 Rehashing the ExplodedNode table is very expensive. The hashing itself is expensive, and the general activity of

Re: [PATCH] D20328: [libcxx] Externally threaded libc++ variant

bcraig added inline comments. Comment at: include/__threading_support:201 @@ +200,3 @@ +# if !defined(__has_include) || __has_include(<__static_threading>) +#include<__static_threading> +# else This #include deserves a comment. Some perplexed developer is

Re: [PATCH] D20874: [libcxx] Two more threading dependencies

bcraig added inline comments. Comment at: include/__threading_support:187 @@ +186,3 @@ +{ +std::terminate(); +} rmaprath wrote: > bcraig wrote: > > Why does this need to go in threading_support? Seems like this is mostly > > orthogonal to threading.

[PATCH] D20929: [libcxx] Fix join.pass.cpp segfault after r271475

rmaprath created this revision. rmaprath added a reviewer: EricWF. rmaprath added a subscriber: cfe-commits. After r271475 [1], I'm seeing a segfault in `join.pass.cpp` on my system. The test calls `std::thread::join()` twice and expects it to throw a system_error. It looks like my pthread

Re: [PATCH] D20883: [cmake] Fix builds with LLVM_ENABLE_PIC=0

chapuni added a subscriber: chapuni. chapuni added a comment. Have you tested if it might work? In fact, it didn't work. Comment at: cfe/trunk/test/CMakeLists.txt:78 @@ +77,3 @@ + + if(TARGET llvm-lto) +set(LLVM_TEST_DEPENDS ${LLVM_TEST_DEPENDS} llvm-lto)

RE: r269670 - [OpenCL] Add supported OpenCL extensions to target info.

Sorry for the delay. In ParsePragma.cpp: void Parser::HandlePragmaOpenCLExtension() { assert(Tok.is(tok::annot_pragma_opencl_extension)); OpenCLExtData data = OpenCLExtData::getFromOpaqueValue(Tok.getAnnotationValue()); unsigned state = data.getInt(); IdentifierInfo *ename =

r271579 - clangFrontend: Make intrinsics_gen optional for standalone build.

Author: chapuni Date: Thu Jun 2 15:24:07 2016 New Revision: 271579 URL: http://llvm.org/viewvc/llvm-project?rev=271579=rev Log: clangFrontend: Make intrinsics_gen optional for standalone build. FIXME: intrinsics_gen may be exported from llvm. Modified: cfe/trunk/lib/Frontend/CMakeLists.txt

Re: [PATCH] D20635: clang-rename: fix renaming heap allocations

This revision was automatically updated to reflect the committed changes. Closed by commit rL271572: clang-rename: fix renaming heap allocations (authored by vmiklos). Changed prior to commit: http://reviews.llvm.org/D20635?vs=58467=59447#toc Repository: rL LLVM

[clang-tools-extra] r271572 - clang-rename: fix renaming heap allocations

Author: vmiklos Date: Thu Jun 2 15:00:22 2016 New Revision: 271572 URL: http://llvm.org/viewvc/llvm-project?rev=271572=rev Log: clang-rename: fix renaming heap allocations The check failed, 'Cla *C = new Cla();' was renamed to 'D *C = new Cla();'. Reviewers: klimek Differential Revision:

Re: [PATCH] D20053: [clang-tidy] Add misc-unnecessary-mutable check.

mnbvmar marked 14 inline comments as done. mnbvmar added a comment. http://reviews.llvm.org/D20053 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20053: [clang-tidy] Add misc-unnecessary-mutable check.

mnbvmar added inline comments. Comment at: clang-tidy/misc/UnnecessaryMutableCheck.cpp:47 @@ +46,3 @@ + + void RunSearch(const Decl *Declaration) { +auto *Body = Declaration->getBody(); Unless I miss something, the moment we set FoundNonConstUse to true, we

Re: [PATCH] D20053: [clang-tidy] Add misc-unnecessary-mutable check.

mnbvmar updated this revision to Diff 59445. mnbvmar added a comment. Fixes done. Added macro test. Docs should be working now. Updated docs. http://reviews.llvm.org/D20053 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp

Re: [PATCH] D20908: Add a few missing Clang regression tests

rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. LGTM. Thanks! http://reviews.llvm.org/D20908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r271565 - [cmake] Fix-up r271533

Author: labath Date: Thu Jun 2 13:49:42 2016 New Revision: 271565 URL: http://llvm.org/viewvc/llvm-project?rev=271565=rev Log: [cmake] Fix-up r271533 I was appending to the wrong variable (over-zealous copy-paste from llvm on my part). Modified: cfe/trunk/test/CMakeLists.txt Modified:

Re: [PATCH] D20871: [Clang][AVX512][Intrinsics] Adding two definitions _mm512_setzero and _mm512_setzero_epi32

RKSimon added a comment. Can you add tests for the existing _mm512_setzero_* intrinsics as well please? http://reviews.llvm.org/D20871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20444: [OpenCL] Include opencl-c.h by default as a clang module

yaxunl updated this revision to Diff 59431. yaxunl added a comment. Improve diag msg for fblocks. http://reviews.llvm.org/D20444 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Basic/LangOptions.def include/clang/Driver/CC1Options.td

r271544 - [docs] Add a limitations section to SourceBasedCodeCoverage.rst

Author: vedantk Date: Thu Jun 2 12:19:45 2016 New Revision: 271544 URL: http://llvm.org/viewvc/llvm-project?rev=271544=rev Log: [docs] Add a limitations section to SourceBasedCodeCoverage.rst Modified: cfe/trunk/docs/SourceBasedCodeCoverage.rst Modified:

Re: [PATCH] D20917: [clang-tidy] Add RemoveStars option to the modernize-use-auto check

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Comment at: docs/clang-tidy/checks/modernize-use-auto.rst:155 @@ +154,3 @@ +-- +If the option is set to non-zero (default is ``0``), the check will remove stars +from the non-typedef pointer types when replacing

Re: r271427 - [driver][arm] add armv7 and thumb include and lib paths

Ismail, I saw that android-ndk-standalone.cpp has already -stdlib=libstdc++. Could you tell me or just go ahead and make the necessary change? Thanks. On Thu, Jun 2, 2016 at 9:52 AM, Ismail Donmez wrote: > Hi, > > On Wed, Jun 1, 2016 at 11:48 PM, Chih-Hung Hsieh via

Re: [PATCH] D20857: [clang-tidy] Add modernize-explicit-operator-bool check.

Eugene.Zelenko added a comment. I think single check will be better from user's point of view. Comment at: docs/clang-tidy/checks/modernize-explicit-operator-bool.rst:12 @@ +11,3 @@ +have no ``operator ==`` overloads, an implicit ``operator bool`` would allow +``a == b`` to

Re: [PATCH] D20490: [Parser] Fix a crash on invalid where a delayed TypoExpr was corrected twice

erik.pilkington added a comment. Ping!! http://reviews.llvm.org/D20490 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D20923: [Sema] Fix a crash on invalid where invalid defaulted function is called

erik.pilkington created this revision. erik.pilkington added a reviewer: rsmith. erik.pilkington added a subscriber: cfe-commits. Previously, clang would crash on the test case below, because it misinterprets the `operator=(bool)` call as a move assignment operator.

Re: r271427 - [driver][arm] add armv7 and thumb include and lib paths

Hi, On Wed, Jun 1, 2016 at 11:48 PM, Chih-Hung Hsieh via cfe-commits wrote: > Author: chh > Date: Wed Jun 1 15:48:46 2016 > New Revision: 271427 > > URL: http://llvm.org/viewvc/llvm-project?rev=271427=rev > Log: > [driver][arm] add armv7 and thumb include and lib

Re: [PATCH] D20902: [include-fixer] added GNU symbols hardcoded header mapping.

ioeric updated this revision to Diff 59411. ioeric added a comment. - Addressed reviewer's comment. http://reviews.llvm.org/D20902 Files: include-fixer/find-all-symbols/STLPostfixHeaderMap.cpp Index: include-fixer/find-all-symbols/STLPostfixHeaderMap.cpp

[PATCH] D20922: [libcxx] [test] Rename global "x" to "testcases" in complex.number/cases.h and make it const for safety.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Rename global "x" to "testcases" in complex.number/cases.h and make it const for safety. Fixes MSVC warning C4459 "declaration of 'x' hides global declaration". NOTE: As the

Re: [PATCH] D20917: [clang-tidy] Add RemoveStars option to the modernize-use-auto check

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. The description threw me for a loop, but the behavior described in the documentation and tested by the tests matches what I would expect. LGTM! http://reviews.llvm.org/D20917

[PATCH] D20920: [libcxx] [test] Rename d to dbl in order to avoid shadowing distributions named d.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Rename d to dbl in order to avoid shadowing distributions named d. This was almost always declared as double d, except in rand.dist.uni.real where it was D::result_type d

Re: [PATCH] D20883: [cmake] Fix builds with LLVM_ENABLE_PIC=0

This revision was automatically updated to reflect the committed changes. Closed by commit rL271533: [cmake] Fix builds with LLVM_ENABLE_PIC=0 (authored by labath). Changed prior to commit: http://reviews.llvm.org/D20883?vs=59293=59405#toc Repository: rL LLVM http://reviews.llvm.org/D20883

r271533 - [cmake] Fix builds with LLVM_ENABLE_PIC=0

Author: labath Date: Thu Jun 2 11:35:24 2016 New Revision: 271533 URL: http://llvm.org/viewvc/llvm-project?rev=271533=rev Log: [cmake] Fix builds with LLVM_ENABLE_PIC=0 Summary: When this flag is specified, the target llvm-lto is not built, but is still used as a dependency of the test targets.

Re: [PATCH] D20898: [clang-format] skip empty lines and comments in the top of the code when inserting new headers.

djasper added a comment. Could we very easily use the FormatTokenLexer for this? I.e. find the first non-comment token an start from there? http://reviews.llvm.org/D20898 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D20919: [libcxx] [test] Rename b to b2 in order to avoid shadowing between nested catch blocks.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Rename b to b2 in order to avoid shadowing between nested catch blocks. Fixes MSVC warning C6246 "Local declaration of 'b' hides declaration of the same name in outer scope."

Re: [PATCH] D20444: [OpenCL] Include opencl-c.h by default as a clang module

Anastasia added inline comments. Comment at: test/Frontend/opencl-blocks.cl:11 @@ +10,3 @@ +#if __OPENCL_C_VERSION__ < CL_VERSION_2_0 && !defined(BLOCKS) + // expected-error@-2{{blocks support disabled - compile with -fblocks or pick a deployment target that supports them}}

[PATCH] D20918: [libcxx] [test] Silence more "unreferenced local variable" warnings.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Silence more "unreferenced local variable" warnings. http://reviews.llvm.org/D20918 Files: test/std/depr/depr.c.headers/wchar_h.pass.cpp Index:

Re: [PATCH] D20444: [OpenCL] Include opencl-c.h by default as a clang module

yaxunl added inline comments. Comment at: test/Headers/opencl-c-header.cl:53-54 @@ +52,4 @@ + +// === +// Compile for OpenCL 2.0 for the first time. The module should change. +// RUN: %clang_cc1 -cc1 -triple spir-unknown-unknown -emit-llvm -o - -cl-std=CL2.0

Re: [PATCH] D20917: [clang-tidy] Add RemoveStars option to the modernize-use-auto check

sbenza added a comment. Is it a typo in the description when it says that when RemoveStar is on we will write 'auto*' instead if 'auto'? http://reviews.llvm.org/D20917 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20898: [clang-format] skip empty lines and comments in the top of the code when inserting new headers.

ioeric added a subscriber: ioeric. ioeric added a comment. ping http://reviews.llvm.org/D20898 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20883: [cmake] Fix builds with LLVM_ENABLE_PIC=0

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D20883 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20444: [OpenCL] Include opencl-c.h by default as a clang module

yaxunl updated this revision to Diff 59398. yaxunl marked an inline comment as done. yaxunl added a comment. Add a test for -fblocks as Anastasia suggested. http://reviews.llvm.org/D20444 Files: include/clang/Basic/LangOptions.def include/clang/Driver/CC1Options.td

[PATCH] D20917: [clang-tidy] Add RemoveStars option to the modernize-use-auto check

alexfh created this revision. alexfh added reviewers: sbenza, aaron.ballman. alexfh added a subscriber: cfe-commits. Add RemoveStars option to the modernize-use-auto check. With the new option turned on (by default) the check will change `MyType *t = new MyType;` to `auto *t = new MyType;`

Re: [PATCH] D20878: [Coverage] Do not push a new region after a CXXTryStmt

vsk added a comment. In http://reviews.llvm.org/D20878#446690, @ikudrin wrote: > Is there a case where this patch makes things better than they were before? > Is it possible to improve handling of exceptions instead? This patch removes something which doesn't appear to serve a useful purpose.

Re: [PATCH] D20871: [Clang][AVX512][Intrinsics] Adding two definitions _mm512_setzero and _mm512_setzero_epi32

m_zuckerman updated this revision to Diff 59389. http://reviews.llvm.org/D20871 Files: lib/Headers/avx512fintrin.h test/CodeGen/avx512f-builtins.c Index: test/CodeGen/avx512f-builtins.c === --- test/CodeGen/avx512f-builtins.c

Re: [PATCH] D20871: [Clang][AVX512][Intrinsics] Adding two definitions _mm512_setzero and _mm512_setzero_epi32

m_zuckerman added a comment. Yes its API http://reviews.llvm.org/D20871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20903: Make system_error::message() thread safe. Fixes PR25598.

mclow.lists added a comment. In general, I'm OK with this - but I'm concerned about that there's not really any provision for the case where `strerror_r` does not exist. Also, there's no reason to have a thread local static array here, if you're going to immediately copy it into a

Re: [PATCH] D20444: [OpenCL] Include opencl-c.h by default as a clang module

bader accepted this revision. Comment at: test/Headers/opencl-c-header.cl:30-31 @@ +29,4 @@ + +// === +// Compile for OpenCL 2.0 for the first time. The module should change. +// RUN: %clang_cc1 -cc1 -emit-llvm -o - -cl-std=CL2.0 -finclude-default-header -fmodules

Re: [PATCH] D20635: clang-rename: fix renaming heap allocations

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D20635 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20866: [Clang][AVX512]Adding set4 intrinsics

m_zuckerman updated this revision to Diff 59379. http://reviews.llvm.org/D20866 Files: lib/Headers/avx512fintrin.h test/CodeGen/avx512f-builtins.c Index: test/CodeGen/avx512f-builtins.c === --- test/CodeGen/avx512f-builtins.c

Re: [PATCH] D20857: [clang-tidy] Add modernize-explicit-operator-bool check.

etienneb added inline comments. Comment at: test/clang-tidy/modernize-operator-void-pointer.cpp:39 @@ +38,3 @@ +class SomethingGoodNonConstVoidPtr { + // A non-const void* is unlikely to to be meant as operator bool before C++11 + // let us use explicit. You

[PATCH] D20909: [clang-tidy] Ignore function context in misc-unused-using-decls.

hokein created this revision. hokein added a reviewer: alexfh. hokein added a subscriber: cfe-commits. Make the check's behavior more correct when handling using-decls in multiple scopes. http://reviews.llvm.org/D20909 Files: clang-tidy/misc/UnusedUsingDeclsCheck.cpp

[clang-format] recursive alignment

I'm calling this "recursive alignment", but what it really fixes is issues with AlignConsecutiveAssignments and AlignConsecutiveDeclarations such as this: OLD: int fun1(int a); double fun2(int b); NEW intfun1(int a); double fun2(int b); Also... OLD: void fun(int x = 1) {

[PATCH] D20908: Add a few missing Clang regression tests

SjoerdMeijer created this revision. SjoerdMeijer added a reviewer: rengolin. SjoerdMeijer added a subscriber: cfe-commits. Add a few missing Clang regression tests for Cortex-A53, Cortex-A57, Cortex-A72 http://reviews.llvm.org/D20908 Files: test/Preprocessor/arm-target-features.c Index:

Re: [PATCH] D20561: Warn when taking address of packed member

rogfer01 marked an inline comment as done. rogfer01 added a comment. http://reviews.llvm.org/D20561 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20561: Warn when taking address of packed member

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I think the patch LGTM (with a minor formatting nit). @rsmith, what are your thoughts? Comment at: test/SemaCXX/address-packed.cpp:92 @@ +91,3 @@ +void g1() +{

Re: [PATCH] D20857: [clang-tidy] Add modernize-explicit-operator-bool check.

aaron.ballman added a comment. In http://reviews.llvm.org/D20857#446784, @murrayc wrote: > In http://reviews.llvm.org/D20857#446732, @etienneb wrote: > > > Enabling/disabling can be done with options (see SizeofExpressionCheck). > > > Thanks. Am I being asked to combine the checks? I would

Re: [PATCH] D20857: [clang-tidy] Add modernize-explicit-operator-bool check.

murrayc added inline comments. Comment at: clang-tidy/modernize/OperatorVoidPointerCheck.cpp:27 @@ +26,3 @@ + Finder->addMatcher(cxxConversionDecl(returns(pointerType(pointee( + isConstQualified(), voidType(, +

Re: [PATCH] D20428: Tracking exception specification source locations

aaron.ballman added a comment. @rsmith: Ping http://reviews.llvm.org/D20428 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20857: [clang-tidy] Add modernize-explicit-operator-bool check.

etienneb added a comment. In http://reviews.llvm.org/D20857#446784, @murrayc wrote: > In http://reviews.llvm.org/D20857#446732, @etienneb wrote: > > > Enabling/disabling can be done with options (see SizeofExpressionCheck). > > > Thanks. Am I being asked to combine the checks? I'll let alexfh@

Re: [PATCH] D20857: [clang-tidy] Add modernize-explicit-operator-bool check.

murrayc added a comment. In http://reviews.llvm.org/D20857#446732, @etienneb wrote: > Enabling/disabling can be done with options (see SizeofExpressionCheck). Thanks. Am I being asked to combine the checks? http://reviews.llvm.org/D20857 ___

Re: [PATCH] D20857: [clang-tidy] Add modernize-explicit-operator-bool check.

murrayc updated this revision to Diff 59367. murrayc added a comment. With suggested changes. Ran clang-format (LLVM style). Used voidType() matcher. http://reviews.llvm.org/D20857 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ExplicitOperatorBoolCheck.cpp

Re: [PATCH] D20328: [libcxx] Externally threaded libc++ variant

rmaprath updated this revision to Diff 59363. rmaprath added a comment. Addressed review comments from @bcraig. @EricWF: Gentle ping. http://reviews.llvm.org/D20328 Files: CMakeLists.txt include/__config include/__config_site.in include/__dynamic_threading

Re: [PATCH] D20857: [clang-tidy] Add modernize-explicit-operator-bool check.

etienneb added a comment. In http://reviews.llvm.org/D20857#446654, @murrayc wrote: > In http://reviews.llvm.org/D20857#446101, @etienneb wrote: > > > I wonder if these two checks should not be merge in one checker. > > > Personally I find it cleaner to keep them separate, but I would be happy

Re: [clang-tools-extra] r261991 - [clang-tidy] Fix a crash issue when clang-tidy runs with compilation database.

Thank you, Tom. I'm not very familiar with the release process and it will indeed be better, if you merge the patch. On Thu, Jun 2, 2016 at 3:27 AM, Tom Stellard wrote: > On Wed, Jun 01, 2016 at 11:19:44PM +0200, Edoardo P. wrote: > > Ping. > > > > Deadline to merge the

r271509 - Suppress clang/test/CodeGen/lifetime-asan.c for targeting mingw.

Author: chapuni Date: Thu Jun 2 05:54:45 2016 New Revision: 271509 URL: http://llvm.org/viewvc/llvm-project?rev=271509=rev Log: Suppress clang/test/CodeGen/lifetime-asan.c for targeting mingw. clang.EXE: error: unsupported option '-fsanitize=address' for target 'x86_64-w64-windows-gnu'

Re: [PATCH] D20864: Adding support for Cortex-A73

This revision was automatically updated to reflect the committed changes. Closed by commit rL271507: This adds target support and tests for Cortex-A73 (authored by SjoerdMeijer). Changed prior to commit: http://reviews.llvm.org/D20864?vs=59219=59357#toc Repository: rL LLVM

r271507 - This adds target support and tests for Cortex-A73

Author: sjoerdmeijer Date: Thu Jun 2 05:48:37 2016 New Revision: 271507 URL: http://llvm.org/viewvc/llvm-project?rev=271507=rev Log: This adds target support and tests for Cortex-A73 Differential Revision: http://reviews.llvm.org/D20864 Modified: cfe/trunk/lib/Basic/Targets.cpp

Re: [PATCH] D20902: [include-fixer] added GNU symbols hardcoded header mapping.

bkramer added a comment. Can we limit this to actual glibc headers, i.e. the output of `dpkg-query -L libc6-dev` on Debian/Ubuntu? There are some unrelated headers in there, I don't think we should have them in this list. http://reviews.llvm.org/D20902

Re: [PATCH] D20867: [PCH] Fix timestamp check on windows hosts.

pgousseau added inline comments. Comment at: test/PCH/include-timestamp.cpp:8 @@ +7,3 @@ +// RUN: sleep 1 +// RUN: not %clang_cc1 -include-pch %t %s 2>&1 | FileCheck -check-prefix=CHECK-TIMESTAMP %s + Without the sleep the test fails for me, as it seems the call

[PATCH] D20903: Make system_error::message() thread safe. Fixes PR25598.

EricWF created this revision. EricWF added reviewers: mclow.lists, majnemer. EricWF added a subscriber: cfe-commits. Herald added a subscriber: emaste. system_error::message() uses `strerror` for the generic and system categories. This function is not thread safe. The fix is to use

Re: [PATCH] D20867: [PCH] Fix timestamp check on windows hosts.

pgousseau updated this revision to Diff 59355. pgousseau added a comment. Following Bruno's comments: - Update input files' name to match http://reviews.llvm.org/D20243 review. - Add llvm-bcanalyzer checks http://reviews.llvm.org/D20867 Files: include/clang/Driver/CC1Options.td

[PATCH] D20902: [include-fixer] added GNU symbols hardcoded header mapping.

ioeric created this revision. ioeric added reviewers: bkramer, klimek. ioeric added subscribers: hokein, cfe-commits. [include-fixer] added GNU symbols hardcoded header mapping. http://reviews.llvm.org/D20902 Files: include-fixer/find-all-symbols/STLPostfixHeaderMap.cpp Index:

Re: [PATCH] D20878: [Coverage] Do not push a new region after a CXXTryStmt

ikudrin added a comment. So, our tool isn't accurate in the case of throwing an exception. Is there a case where this patch makes things better than they were before? Is it possible to improve handling of exceptions instead? http://reviews.llvm.org/D20878

[libcxx] r271502 - Add not_fn test for throwing operator!

Author: ericwf Date: Thu Jun 2 03:37:00 2016 New Revision: 271502 URL: http://llvm.org/viewvc/llvm-project?rev=271502=rev Log: Add not_fn test for throwing operator! Modified: libcxx/trunk/test/std/utilities/function.objects/func.not_fn/not_fn.pass.cpp Modified:

Re: [PATCH] D20635: clang-rename: fix renaming heap allocations

vmiklos added a comment. Can I help anything with reviewing this, please? http://reviews.llvm.org/D20635 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r271501 - Fix TEST_HAS_NO_EXCEPTIONS misspelling in the test suite.

Author: ericwf Date: Thu Jun 2 03:19:02 2016 New Revision: 271501 URL: http://llvm.org/viewvc/llvm-project?rev=271501=rev Log: Fix TEST_HAS_NO_EXCEPTIONS misspelling in the test suite. Modified:

Re: [PATCH] D20857: [clang-tidy] Add modernize-explicit-operator-bool check.

murrayc added a comment. In http://reviews.llvm.org/D20857#446101, @etienneb wrote: > I wonder if these two checks should not be merge in one checker. Personally I find it cleaner to keep them separate, but I would be happy to combine them if that's wanted. I guessed that it would be easier

Re: [PATCH] D20857: [clang-tidy] Add modernize-explicit-operator-bool check.

murrayc updated this revision to Diff 59346. murrayc added a comment. These are the commits amended with the suggested changes. Many thanks for the suggestions. (I'm not quite sure what arcanist will do, so hopefully this will not create a mess.) http://reviews.llvm.org/D20857 Files:

Re: [PATCH] D20861: [AVX512] add missing integer to float conversion

This revision was automatically updated to reflect the committed changes. Closed by commit rL271499: [X86][AVX512] add intrinsics of Scalar FP to integer (authored by abadouh). Changed prior to commit: http://reviews.llvm.org/D20861?vs=59210=59348#toc Repository: rL LLVM

r271499 - [X86][AVX512] add intrinsics of Scalar FP to integer

Author: abadouh Date: Thu Jun 2 03:11:35 2016 New Revision: 271499 URL: http://llvm.org/viewvc/llvm-project?rev=271499=rev Log: [X86][AVX512] add intrinsics of Scalar FP to integer Differential Revision: http://reviews.llvm.org/D20861 Modified: cfe/trunk/lib/Headers/avx512fintrin.h

Re: [PATCH] D20811: [analyzer] Model some library functions

NoQ added a comment. Yeah, good point, the "Std" part should definitely appear in the name, not sure about the "C" thing, as we could probably expand this checker to model some simple C++ functions as well (and then we'd make a separate checker section to move from unix. to cplusplus. or

r271498 - [Clang][AVX512][INTRINSICS] adding round cvt and fix regular cvtps_ph

Author: mzuckerm Date: Thu Jun 2 02:44:08 2016 New Revision: 271498 URL: http://llvm.org/viewvc/llvm-project?rev=271498=rev Log: [Clang][AVX512][INTRINSICS] adding round cvt and fix regular cvtps_ph Differential Revision: http://reviews.llvm.org/D20870 Modified:

Re: [PATCH] D20870: [Clang][AVX512][INTRINSICS] adding round cvt and fix regular cvtps_ph

This revision was automatically updated to reflect the committed changes. Closed by commit rL271498: [Clang][AVX512][INTRINSICS] adding round cvt and fix regular cvtps_ph (authored by mzuckerm). Changed prior to commit: http://reviews.llvm.org/D20870?vs=59232=59345#toc Repository: rL LLVM

Re: [PATCH] D20561: Warn when taking address of packed member

rogfer01 updated this revision to Diff 59342. rogfer01 marked 3 inline comments as done. rogfer01 added a comment. Remove fix-it as it is not suitable for this diagnostic. http://reviews.llvm.org/D20561 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaExpr.cpp

Re: [PATCH] D20561: Warn when taking address of packed member

rogfer01 marked 3 inline comments as done. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:5392 @@ -5388,1 +5391,3 @@ +def note_address_of_packed_member_silence : Note< + "place parentheses around the '%0' expression to silence this warning">;

  1   2   >