rmaprath added a comment.
LGTM. I'll leave you to commit if Marshall has no objection.
Thanks!
/ Asiri
http://reviews.llvm.org/D21407
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
Author: chapuni
Date: Thu Jun 16 01:08:09 2016
New Revision: 272874
URL: http://llvm.org/viewvc/llvm-project?rev=272874&view=rev
Log:
clang/test/Driver/cuda-march.cu: Tweak not to match "clang" to other place like
"path-to-clang-foo".
Modified:
cfe/trunk/test/Driver/cuda-march.cu
Modified:
Author: gbiv
Date: Wed Jun 15 21:30:33 2016
New Revision: 272867
URL: http://llvm.org/viewvc/llvm-project?rev=272867&view=rev
Log:
[Lex] Try to fix a 'comparison is always false' warning. NFC.
Modified:
cfe/trunk/lib/Lex/PPDirectives.cpp
Modified: cfe/trunk/lib/Lex/PPDirectives.cpp
URL:
htt
Author: rnk
Date: Wed Jun 15 20:21:28 2016
New Revision: 272862
URL: http://llvm.org/viewvc/llvm-project?rev=272862&view=rev
Log:
[DebugInfo] Enable generation of unique identifiers for externally visible MS
ABI types
We implemented the mangling for this a long time ago.
Added:
cfe/trunk/te
Actually, in the last three months we've recently added support for pushing
arguments in a call sequence. I think we should wire this up to an LLVM
function attribute. It should be a tiny bit of work in
llvm/lib/Target/X86/X86FrameLowering.cpp and
clang/lib/CodeGen/CodeGenModule.cpp:SetLLVMFunction
Author: probinson
Date: Wed Jun 15 19:42:36 2016
New Revision: 272859
URL: http://llvm.org/viewvc/llvm-project?rev=272859&view=rev
Log:
Allow 'nodebug' on local variables.
Parameters and non-static members of aggregates are still excluded,
and probably should remain that way.
Differential Revisio
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272859: Allow 'nodebug' on local variables. (authored by
probinson).
Changed prior to commit:
http://reviews.llvm.org/D19754?vs=60930&id=60940#toc
Repository:
rL LLVM
http://reviews.llvm.org/D19754
Hi,
This fixes https://llvm.org/bugs/show_bug.cgi?id=28145
Please let me know if something needs to changed for inclusion.
--
-Austin
GPG: 14FB D7EA A041 937B
From fd4aa56c027d8ccc38ffb7484b19194804982cbe Mon Sep 17 00:00:00 2001
From: Austin English
Date: Wed, 15 Jun 2016 18:40:51 -0500
Subje
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272857: [CUDA] Don't pass top-level -march down to device
cc1 or ptxas. (authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D21419?vs=60932&id=60935#toc
Repository:
rL LLVM
http:/
Author: jlebar
Date: Wed Jun 15 18:46:11 2016
New Revision: 272857
URL: http://llvm.org/viewvc/llvm-project?rev=272857&view=rev
Log:
[CUDA] Don't pass top-level -march down to device cc1 or ptxas.
Summary:
Previously if you did e.g.
$ clang -march=haswell -x cuda foo.cu
we would pass "-march=
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D21419
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar updated this revision to Diff 60932.
jlebar added a comment.
Fix tests for real this time.
http://reviews.llvm.org/D21419
Files:
lib/Driver/ToolChains.cpp
test/Driver/cuda-march.cu
Index: test/Driver/cuda-march.cu
===
-
tra added inline comments.
Comment at: test/Driver/cuda-march.cu:22-28
@@ +21,9 @@
+
+// SM30:clang
+// SM30: "-cc1"
+// SM30-SAME: "-triple" "nvptx
+// SM30-SAME: "-target-cpu" "sm_30"
+// SM30: ptxas
+// SM30-SAME: "--gpu-name" "sm_30"
+
+// HASWELL:clang
You do
dblaikie accepted this revision.
dblaikie added a comment.
Sure, looks good - thanks. Will discuss the broader test issues
later/separately.
http://reviews.llvm.org/D19754
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
jlebar added inline comments.
Comment at: test/Driver/cuda-march.cu:15-16
@@ +14,4 @@
+
+// RUN: %clang -### -target x86_64-linux-gnu -c -march=skylake
--cuda-gpu-arch=sm_30 %s 2>&1 | \
+// RUN: FileCheck -check-prefix SKYLAKE -check-prefix SM30 %s
+
tra wrote:
>
jlebar updated this revision to Diff 60931.
jlebar added a comment.
Remove redundant test.
http://reviews.llvm.org/D21419
Files:
lib/Driver/ToolChains.cpp
test/Driver/cuda-march.cu
Index: test/Driver/cuda-march.cu
===
--- /dev
probinson marked an inline comment as done.
Comment at: test/CodeGenCXX/debug-info-nodebug.cpp:50
@@ -49,2 +49,3 @@
NODEBUG static int static_local = 6;
+ NODEBUGint normal_local = 7;
}
const case removed.
http://reviews.llvm.org/D19754
_
Author: eugenis
Date: Wed Jun 15 18:29:26 2016
New Revision: 272856
URL: http://llvm.org/viewvc/llvm-project?rev=272856&view=rev
Log:
Fix sanitizer-ld test.
Modified:
cfe/trunk/test/Driver/sanitizer-ld.c
Modified: cfe/trunk/test/Driver/sanitizer-ld.c
URL:
http://llvm.org/viewvc/llvm-project
probinson updated this revision to Diff 60930.
probinson added a comment.
Removed the apparently redundant test for a const local variable.
Yes, I'm back to this after way longer than expected. I believe, for this
patch specifically, the extra const local variable was the only identifiable
pro
tra added inline comments.
Comment at: test/Driver/cuda-march.cu:15-16
@@ +14,4 @@
+
+// RUN: %clang -### -target x86_64-linux-gnu -c -march=skylake
--cuda-gpu-arch=sm_30 %s 2>&1 | \
+// RUN: FileCheck -check-prefix SKYLAKE -check-prefix SM30 %s
+
These look redu
rsmith added inline comments.
Comment at: include/llvm/module.modulemap:121-126
@@ -106,8 +120,8 @@
// FIXME: Is this the right place for these?
module Pass { header "Pass.h" export * }
module PassSupport { header "PassSupport.h" export * }
module PassAnalysisSupport
rsmith accepted this revision.
rsmith added a reviewer: rsmith.
rsmith added a comment.
This revision is now accepted and ready to land.
Makes sense to me.
Repository:
rL LLVM
http://reviews.llvm.org/D21390
___
cfe-commits mailing list
cfe-commit
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added subscribers: echristo, cfe-commits.
Previously if you did e.g.
$ clang -march=haswell -x cuda foo.cu
we would pass "-march=haswell -march=sm_20" down to the ptxas tool.
This causes it to assert, and rightly so!
http://re
george.burgess.iv added a comment.
(: ƃuıd
http://reviews.llvm.org/D17462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: eugenis
Date: Wed Jun 15 18:05:21 2016
New Revision: 272853
URL: http://llvm.org/viewvc/llvm-project?rev=272853&view=rev
Log:
Fix linking of DFSan + coverage.
Broken in r272717 because of no test coverage.
Modified:
cfe/trunk/lib/Driver/SanitizerArgs.cpp
cfe/trunk/test/Driver/san
Should be fixed in r272852
--Artem
On Wed, Jun 15, 2016 at 3:16 PM, Artem Belevich wrote:
> Miklos,
>
> TokenName produces unused variable warning in builds with asserts disabled.
> Could you add LLVM_ATTRIBUTE_UNUSED to it?
>
> Thanks,
> --Artem
>
>
> On Wed, Jun 15, 2016 at 11:35 AM, Miklos V
Author: tra
Date: Wed Jun 15 18:04:42 2016
New Revision: 272852
URL: http://llvm.org/viewvc/llvm-project?rev=272852&view=rev
Log:
[clang-tools] mark TokenName as unused
Otherwise it produces compiler warning if asserts are disabled.
Modified:
clang-tools-extra/trunk/clang-rename/USRLocFinder
Miklos,
TokenName produces unused variable warning in builds with asserts disabled.
Could you add LLVM_ATTRIBUTE_UNUSED to it?
Thanks,
--Artem
On Wed, Jun 15, 2016 at 11:35 AM, Miklos Vajna via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: vmiklos
> Date: Wed Jun 15 13:35:41 2016
erik.pilkington updated this revision to Diff 60908.
erik.pilkington added a comment.
This new patch replaces the call to `RebuildPackExpansion` with a direct call
to `getPackExpansionType`. Also use `None` instead of `NumExpansions` as
argument.
As far as the `assert(*NumExpansions == 1)`, I d
davide added a comment.
ping?
http://reviews.llvm.org/D20748
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272840: [x86] translate SSE packed FP comparison builtins to
IR (authored by spatel).
Changed prior to commit:
http://reviews.llvm.org/D21268?vs=60473&id=60905#toc
Repository:
rL LLVM
http://reviews
Author: spatel
Date: Wed Jun 15 16:20:04 2016
New Revision: 272840
URL: http://llvm.org/viewvc/llvm-project?rev=272840&view=rev
Log:
[x86] translate SSE packed FP comparison builtins to IR
As noted in the code comment, a potential follow-on would be to remove
the builtins themselves. Other than o
EricWF created this revision.
EricWF added reviewers: mclow.lists, rmaprath.
EricWF added a subscriber: cfe-commits.
Currently the implementation of [util.smartptr.shared.atomic] is provided only
when using Clang, and not with GCC. This is a relic of not having a GCC
implementation of , even th
Author: etienneb
Date: Wed Jun 15 15:34:33 2016
New Revision: 272832
URL: http://llvm.org/viewvc/llvm-project?rev=272832&view=rev
Log:
Add support to clang-cl driver for /GS switch
Summary:
This patch is adding command-line support for the MSVC buffer security check.
The buffer security check is
Author: danalbert
Date: Wed Jun 15 15:20:32 2016
New Revision: 272827
URL: http://llvm.org/viewvc/llvm-project?rev=272827&view=rev
Log:
Add an Android version check for GNU strerror_r.
Summary:
Android didn't gain GNU's strerror_r until Marshmallow. If we're
building libc++ against something olde
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272827: Add an Android version check for GNU strerror_r.
(authored by danalbert).
Changed prior to commit:
http://reviews.llvm.org/D21402?vs=60887&id=60893#toc
Repository:
rL LLVM
http://reviews.llv
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM.
I would have preferred to always use the POSIX version, but it's impossible to
turn of GNU extensions without breaking the linux build.
http://reviews.llvm.org/D21402
__
danalbert created this revision.
danalbert added reviewers: mclow.lists, EricWF.
danalbert added a subscriber: cfe-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
Android didn't gain GNU's strerror_r until Marshmallow. If we're
building libc++ against something older (we build
r272825,
Thanks,
Rafael
On 15 June 2016 at 04:28, Lei Zhang wrote:
> 2016-06-14 20:55 GMT+08:00 Rafael Espíndola :
>> On 13 June 2016 at 21:07, Lei Zhang wrote:
>>> 2016-06-14 5:00 GMT+08:00 Rafael Espíndola :
Do you need someone to commit it for you?
>>>
>>> Yes, please :)
>>
>> Committe
Author: rafael
Date: Wed Jun 15 15:02:22 2016
New Revision: 272825
URL: http://llvm.org/viewvc/llvm-project?rev=272825&view=rev
Log:
Add a few Musl related tests that already pass.
Patch by Lei Zhang.
Modified:
cfe/trunk/test/Driver/linux-ld.c
Modified: cfe/trunk/test/Driver/linux-ld.c
URL:
Author: ericwf
Date: Wed Jun 15 14:59:16 2016
New Revision: 272824
URL: http://llvm.org/viewvc/llvm-project?rev=272824&view=rev
Log:
Fix [libcxxabi] Fix warning about uninitialized const member.
Modified:
libcxxabi/trunk/test/catch_member_data_pointer_01.pass.cpp
Modified: libcxxabi/trunk/te
Author: ericwf
Date: Wed Jun 15 14:48:26 2016
New Revision: 272823
URL: http://llvm.org/viewvc/llvm-project?rev=272823&view=rev
Log:
Fix warning about uninitialized const member. NFC
Modified:
libcxxabi/trunk/test/catch_member_data_pointer_01.pass.cpp
Modified: libcxxabi/trunk/test/catch_mem
Author: ericwf
Date: Wed Jun 15 14:41:52 2016
New Revision: 272822
URL: http://llvm.org/viewvc/llvm-project?rev=272822&view=rev
Log:
Fix warning in tuple tests. The test suite should now run clean with most
warnings enabled
Modified:
libcxx/trunk/test/std/utilities/tuple/tuple.general/tuple.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272821: [libcxxabi] Reorder base class initializers in
libc++abi tests to prevent… (authored by EricWF).
Changed prior to commit:
http://reviews.llvm.org/D21396?vs=60876&id=60881#toc
Repository:
rL L
Author: ericwf
Date: Wed Jun 15 14:33:01 2016
New Revision: 272821
URL: http://llvm.org/viewvc/llvm-project?rev=272821&view=rev
Log:
[libcxxabi] Reorder base class initializers in libc++abi tests to prevent
-Wreorder
Summary:
This patch fixes -Wreorder warnings on test classes with virtual bases
howard.hinnant added a comment.
Look good to me.
http://reviews.llvm.org/D21396
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF created this revision.
EricWF added reviewers: mclow.lists, howard.hinnant.
EricWF added a subscriber: cfe-commits.
This patch fixes -Wreorder warnings on test classes with virtual bases. Since
the compiler is performing the reordering anyway this change *should* have NFC.
However the tes
It would be awesome if this kind of shadowing warning could be put into
-Wall. My recollection on the last set of -Wshadow reviews is that most
shadowing warnings are from ctor arguments being used to initialize
members. Here's the last discussion / review regarding shadowing
http://reviews.l
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272820: cc1_main: Do not print statistics twice in
-disable_free mode. (authored by matze).
Changed prior to commit:
http://reviews.llvm.org/D21338?vs=60732&id=60877#toc
Repository:
rL LLVM
http://r
Author: matze
Date: Wed Jun 15 14:24:55 2016
New Revision: 272820
URL: http://llvm.org/viewvc/llvm-project?rev=272820&view=rev
Log:
cc1_main: Do not print statistics twice in -disable_free mode.
llvm statistics are currently printed when the destructor of a "static
ManagedStatic StatInfo" in llvm
Maybe we should add a new warning in Clang for this. -Wshadow diagnosis's
this but -Wshadow isn't a part of -Wall or -Wextra so it's of limited
utility.
A separate warning for shadowing 'x' caused by "T(x)" might be useful.
Do people actually use "T(x)" in the wild to default construct 'x'?
/Eric
Author: ericwf
Date: Wed Jun 15 14:07:19 2016
New Revision: 272819
URL: http://llvm.org/viewvc/llvm-project?rev=272819&view=rev
Log:
Suppress warnings about the operations currently under test.
Modified:
libcxxabi/trunk/test/catch_class_03.pass.cpp
libcxxabi/trunk/test/catch_class_04.pass
Makes sense. Here's hoping parameter deduction for constructors makes
it in!
(better link)
http://open-std.org/JTC1/SC22/WG21/docs/papers/2016/p0091r2.html
On 6/15/2016 1:54 PM, Eric Fiselier wrote:
I've had a change of heart. I think that lock_guard<> has some utility
in generic code, a
I've had a change of heart. I think that lock_guard<> has some utility in
generic code, and I'm not sure removing it is a good idea. For example a
function like:
template
void ExecuteUnderLocks(Func&& fn, Locks&... locks) {
lock_guard g(locks...);
fn();
}
I checked the proposal and it's clea
On 6/15/2016 1:15 PM, Eric Fiselier wrote:
On Wed, Jun 15, 2016 at 11:45 AM, Craig, Ben via cfe-commits
mailto:cfe-commits@lists.llvm.org>> wrote:
Does this change (and the paper) permit declarations like the
following?
lock_guard<> guard();
If that syntax is allowed, then
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Assuming that it's guaranteed that the other path would always print out the
statistics, LGTM
Repository:
rL LLVM
http://reviews.llvm.org/D21338
__
Author: vmiklos
Date: Wed Jun 15 13:35:41 2016
New Revision: 272816
URL: http://llvm.org/viewvc/llvm-project?rev=272816&view=rev
Log:
clang-rename: implement renaming of classes with a dtor
The declaration wasn't renamed. Also neither part of the declaration
wasn't renamed.
Reviewers: klimek
Di
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272816: clang-rename: implement renaming of classes with a
dtor (authored by vmiklos).
Changed prior to commit:
http://reviews.llvm.org/D21364?vs=60801&id=60869#toc
Repository:
rL LLVM
http://review
Maybe a comma-separated attachments?
The tables relay positioning and font.
Thanks
Galina
On Tue, Jun 14, 2016 at 6:59 PM, Sean Silva wrote:
> Some of these tables are getting quite mangled somewhere along the line
> (email client? mailing list handling? idk). Could you re-send with the
> tab
rnk accepted this revision.
rnk added a reviewer: rnk.
rnk added a comment.
lgtm
Surely this is going to break something, but let's throw the switch and find
out.
http://reviews.llvm.org/D20347
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
On Wed, Jun 15, 2016 at 11:05 AM, David Blaikie wrote:
> Perhaps we shouldn't emit it if it's the logical platform default as it
> (to my naive understanding) appears to be here?
>
It is only the default for member functions, and member functions can be
cdecl (the free function default). I think
On Wed, Jun 15, 2016 at 11:45 AM, Craig, Ben via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Does this change (and the paper) permit declarations like the following?
>
> lock_guard<> guard();
>
> If that syntax is allowed, then this is also likely allowed...
>
> lock_guard<>(guard);
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Sure! LGTM
http://reviews.llvm.org/D19274
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
On Wed, Jun 15, 2016 at 10:59 AM, Reid Kleckner wrote:
> On Thu, Jun 9, 2016 at 8:59 AM, David Blaikie wrote:
>
>> Reid - is this intended fallout? (seems plausible, but just checking)
>>
>> Is MinGW a good analogy for any of this work? (does it produce DWARF?
>> Does it use the Windows ABI? Doe
On Thu, Jun 9, 2016 at 8:59 AM, David Blaikie wrote:
> Reid - is this intended fallout? (seems plausible, but just checking)
>
> Is MinGW a good analogy for any of this work? (does it produce DWARF? Does
> it use the Windows ABI? Does it emit Calling Convention attributes?)
>
It is intended fall
Does this change (and the paper) permit declarations like the following?
lock_guard<> guard();
If that syntax is allowed, then this is also likely allowed...
lock_guard<>(guard);
I would really like the prior two examples to not compile. Here is a
common bug that I see in the wild...
rengolin added inline comments.
Comment at: lib/Basic/Targets.cpp:5709
@@ -5716,3 +5708,3 @@
void getTargetDefines(const LangOptions &Opts,
MacroBuilder &Builder) const override {
We'll have to re-work these parts anyway. When I was l
Author: ericwf
Date: Wed Jun 15 12:25:05 2016
New Revision: 272809
URL: http://llvm.org/viewvc/llvm-project?rev=272809&view=rev
Log:
Add -Wno-unused-command-line-argument when running the test suite to prevent
errors
Modified:
libcxx/trunk/test/libcxx/test/config.py
Modified: libcxx/trunk/t
Author: spatel
Date: Wed Jun 15 12:18:50 2016
New Revision: 272807
URL: http://llvm.org/viewvc/llvm-project?rev=272807&view=rev
Log:
[x86] generate IR for SSE integer min/max builtins
Sibling patch to r272806:
http://reviews.llvm.org/rL272806
Modified:
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
Author: ericwf
Date: Wed Jun 15 12:04:40 2016
New Revision: 272804
URL: http://llvm.org/viewvc/llvm-project?rev=272804&view=rev
Log:
Fix const default initialization of lock_guard<>
Modified:
libcxx/trunk/include/mutex
Modified: libcxx/trunk/include/mutex
URL:
http://llvm.org/viewvc/llvm-pr
ioeric abandoned this revision.
ioeric added a comment.
Abandon this patch in favor of http://reviews.llvm.org/D21382
http://reviews.llvm.org/D21375
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
RKSimon added a comment.
It seems like part of the need for this is because the _mm_cmp_ps style
intrinsics are defined as macros (to get around the problem of trying to use an
immediate as an argument):
#define _mm_cmp_ps(a, b, c) __extension__ ({ \
(__m128)__builtin_ia32_cmpps((__v4sf)(
Author: d0k
Date: Wed Jun 15 11:51:04 2016
New Revision: 272803
URL: http://llvm.org/viewvc/llvm-project?rev=272803&view=rev
Log:
[clang-tidy] Remove dead code. NFC.
Modified:
clang-tools-extra/trunk/clang-tidy/modernize/LoopConvertUtils.cpp
clang-tools-extra/trunk/clang-tidy/modernize/Lo
ahatanak added a comment.
Sorry for my late reply.
Comment at: lib/Sema/SemaExpr.cpp:12825
@@ -12824,1 +12824,3 @@
+ // BlockContext.
+ } else if (!Rec.IsArrayBound) {
// C++1y [expr.const]p2:
rsmith wrote:
> This isn't correct; you still need
mclow.lists marked 8 inline comments as done.
mclow.lists added a comment.
http://reviews.llvm.org/D21343
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mclow.lists updated this revision to Diff 60856.
mclow.lists added a comment.
Updated based on comments here and elsewhere.
- Do the abs once, rather than at every level of recursion
- Add tests for `bool`.
- Constexpr
Also, add an assertion to detect overflow in `lcm`.
I have not yet incorpora
Author: lerochris
Date: Wed Jun 15 11:08:13 2016
New Revision: 272798
URL: http://llvm.org/viewvc/llvm-project?rev=272798&view=rev
Log:
[Sparc] setjmp and longjmp intrinsic support update to add unit tests and
remove accidentally checked-in code.
Related to revision r272782
Modified:
cfe/tr
john.brawn created this revision.
john.brawn added reviewers: ehsan, reames, chapuni.
john.brawn added subscribers: llvm-commits, cfe-commits.
john.brawn set the repository for this revision to rL LLVM.
Herald added a subscriber: klimek.
Currently the Registry class contains the vestiges of a prev
Author: d0k
Date: Wed Jun 15 10:46:10 2016
New Revision: 272795
URL: http://llvm.org/viewvc/llvm-project?rev=272795&view=rev
Log:
Apply performance-unnecessary-value-param to clang-tidy.
With minor manual tweaks. No functionality change intended.
Modified:
clang-tools-extra/trunk/clang-tidy/
etienneb added a subscriber: etienneb.
etienneb added a comment.
I was wondering why we didn't created that Matcher: IgnoreImplicit
I believe it's more commonly used than 'ignoringExprWithCleanups'.
It can be implemented by calling 'Stmt.IgnoreImplicit'.
/// Skip past any implicit AST nodes w
Author: rsingh
Date: Wed Jun 15 09:21:28 2016
New Revision: 272790
URL: http://llvm.org/viewvc/llvm-project?rev=272790&view=rev
Log:
Reverting r272777 because one of the tests
added in the llvm patch is causing an assertion
to fail.
Modified:
cfe/trunk/include/clang/Basic/BuiltinsARM.def
Author: d0k
Date: Wed Jun 15 09:20:56 2016
New Revision: 272789
URL: http://llvm.org/viewvc/llvm-project?rev=272789&view=rev
Log:
Apply some suggestions from clang-tidy's performance-unnecessary-value-param.
No functionality change intended.
Modified:
cfe/trunk/lib/AST/ASTDiagnostic.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272788: Don't use static variables in LambdaCapture
(authored by john.brawn).
Changed prior to commit:
http://reviews.llvm.org/D20732?vs=58787&id=60831#toc
Repository:
rL LLVM
http://reviews.llvm.or
Author: john.brawn
Date: Wed Jun 15 09:14:51 2016
New Revision: 272788
URL: http://llvm.org/viewvc/llvm-project?rev=272788&view=rev
Log:
Don't use static variables in LambdaCapture
When static variables are used in inline functions in header files anything that
uses that function ends up with a r
Author: ctopper
Date: Wed Jun 15 09:06:34 2016
New Revision: 272787
URL: http://llvm.org/viewvc/llvm-project?rev=272787&view=rev
Log:
[AVX512] Use native IR for mask pcmpeq/pcmpgt intrinsics.
Modified:
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
cfe/trunk/test/CodeGen/avx512bw-builtins.c
cfe/
RKSimon added a subscriber: RKSimon.
RKSimon added a reviewer: RKSimon.
Comment at: lib/Headers/bmiintrin.h:296
@@ -290,1 +295,3 @@
+}
+
#ifdef __x86_64__
Why not just #define to __tzcnt_u32 like the (many) other duplicate tzcnt
intrinsics we have:
```
#define
aturetsk added inline comments.
Comment at: lib/Driver/Tools.cpp:3657
@@ +3656,3 @@
+ if (IsIAMCU && types::isCXX(Input.getType()))
+D.Diag(diag::err_drv_cxx_not_supported) <<
getToolChain().getTriple().str();
+
aturetsk wrote:
> bruno wrote:
> > aturetsk wr
bmharper set the repository for this revision to rL LLVM.
bmharper updated this revision to Diff 60830.
bmharper added a comment.
Fix the recent two issues mentioned by Beren, ie the single-statement scopes
(for loop without braces), and operator[] alignment.
Repository:
rL LLVM
http://revie
jyknight accepted this revision.
jyknight added a comment.
This revision is now accepted and ready to land.
Fine with me.
Repository:
rL LLVM
http://reviews.llvm.org/D20732
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
On Wed, Jun 15, 2016 at 12:44:48PM -, Chris Dewhurst via cfe-commits wrote:
> Modified: cfe/trunk/lib/Basic/Targets.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/Targets.cpp?rev=272782&r1=272781&r2=272782&view=diff
> ==
Author: lerochris
Date: Wed Jun 15 07:44:47 2016
New Revision: 272782
URL: http://llvm.org/viewvc/llvm-project?rev=272782&view=rev
Log:
[Sparc] Change to let clang know that setjmp and longjmp intrinsics are
implemented in the back-end.
Differential Revision: http://reviews.llvm.org/D19798
Modi
ioeric created this revision.
ioeric added reviewers: djasper, klimek.
ioeric added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Not sure if this is intended, but there are two identical sets of
declarations of applyAllReplacements.
http://reviews.llvm.org/D21375
Files:
includ
m_zuckerman created this revision.
m_zuckerman added reviewers: AsafBadouh, igorb, delena.
m_zuckerman added a subscriber: cfe-commits.
http://reviews.llvm.org/D21373
Files:
lib/Headers/bmiintrin.h
test/CodeGen/bmi-builtins.c
Index: test/CodeGen/bmi-builtins.c
===
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272777: [ARM] Add mrrc/mrrc2 intrinsics and update existing
mcrr/mcrr2 intrinsics. (authored by rsingh).
Changed prior to commit:
http://reviews.llvm.org/D21179?vs=60504&id=60815#toc
Repository:
rL L
Author: rsingh
Date: Wed Jun 15 06:32:18 2016
New Revision: 272777
URL: http://llvm.org/viewvc/llvm-project?rev=272777&view=rev
Log:
[ARM] Add mrrc/mrrc2 intrinsics and update existing mcrr/mcrr2 intrinsics.
Patch adds intrinsics for mrrc/mrrc2. The
intrinsics for mrrc/mrrc2 return a single
uint6
Author: abataev
Date: Wed Jun 15 06:24:54 2016
New Revision: 272776
URL: http://llvm.org/viewvc/llvm-project?rev=272776&view=rev
Log:
Revert accidential "[MSVC] Late parsing of in-class defined member functions in
template"
This reverts commit 0253605771b8bd9d414aba74fe2742c730d6fd1a.
Modified:
Author: abataev
Date: Wed Jun 15 06:20:48 2016
New Revision: 272775
URL: http://llvm.org/viewvc/llvm-project?rev=272775&view=rev
Log:
[OPENMP] Fix crash for 'schedule|dist_schedule' clauses during
instantiation.
Added checks for non-dependent context when trygin to capture
non-constant schedule c
Author: abataev
Date: Wed Jun 15 06:19:39 2016
New Revision: 272774
URL: http://llvm.org/viewvc/llvm-project?rev=272774&view=rev
Log:
[MSVC] Late parsing of in-class defined member functions in template
classes.
MSVC actively uses unqualified lookup in dependent bases, lookup at the
instantiation
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272773: [include-fixer] Correct two wrong header mappings.
(authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D21371?vs=60812&id=60814#toc
Repository:
rL LLVM
http://reviews.llvm
Author: hokein
Date: Wed Jun 15 06:15:12 2016
New Revision: 272773
URL: http://llvm.org/viewvc/llvm-project?rev=272773&view=rev
Log:
[include-fixer] Correct two wrong header mappings.
Reviewers: bkramer
Subscribers: ioeric, cfe-commits
Differential Revision: http://reviews.llvm.org/D21371
Modi
1 - 100 of 116 matches
Mail list logo
