Author: ctopper
Date: Tue Jun 21 01:53:58 2016
New Revision: 273249
URL: http://llvm.org/viewvc/llvm-project?rev=273249&view=rev
Log:
[AVX512] Move the 128-bit and 256-bit lzcnt intrinsics to avx512vlcdintrin.h
where they belong.
Modified:
cfe/trunk/lib/Headers/avx512vlcdintrin.h
cfe/tru
ioeric updated this revision to Diff 61340.
ioeric added a comment.
- fixed commenting.
http://reviews.llvm.org/D21547
Files:
include/clang/Tooling/Core/Replacement.h
lib/Tooling/Core/Replacement.cpp
unittests/Tooling/RefactoringTest.cpp
Index: unittests/Tooling/RefactoringTest.cpp
=
berenm added a comment.
In http://reviews.llvm.org/D21279#462578, @bmharper wrote:
> 2. friend functions: I don't really understand why the current behavior is
> what it is, but I think it's reasonable to argue that it actually improves
> readability by drawing attention to the fact these are f
djasper added inline comments.
Comment at: include/clang/Tooling/Core/Replacement.h:68
@@ +67,3 @@
+/// \brief Less-than operator between two Ranges.
+bool operator<(const Range &LHS, const Range &RHS);
+
Can we keep these private for now?
Commen
probinson added a comment.
In http://reviews.llvm.org/D20647#462797, @Ilod wrote:
> There is no longer a flag to treat implicit and explicit inline functions
> exactly the same way, I don't kow if it's really useful (it can be if we want
> to use the threshold difference between InlineHint and
m_zuckerman updated this revision to Diff 61351.
http://reviews.llvm.org/D21373
Files:
lib/Headers/bmiintrin.h
test/CodeGen/bmi-builtins.c
Index: test/CodeGen/bmi-builtins.c
===
--- test/CodeGen/bmi-builtins.c
+++ test/CodeGen/b
m_zuckerman added inline comments.
Comment at: lib/Headers/bmiintrin.h:296
@@ +295,3 @@
+/// This intrinsic corresponds to the \c TZCNT instruction.
+///
+/// \param __X
We can't use #define Here. The __mm_tzcnt_32(a) intrinsics is deferent from
__tzcnt_u32 in t
DmitryPolukhin updated this revision to Diff 61352.
DmitryPolukhin added a comment.
- removed wrong asserts that I used for an experiment
http://reviews.llvm.org/D18035
Files:
lib/AST/ItaniumMangle.cpp
lib/Sema/SemaDeclAttr.cpp
test/CodeGenCXX/mangle-abi-tag.cpp
test/PCH/attrs.c
test/
DmitryPolukhin updated this revision to Diff 61350.
DmitryPolukhin added a comment.
This patch set contains serious refactoring to make it closer to what Richard
suggested. Unfortunately there is no way to fully implement Richard's idea
because we have to mangle twice name of functions and varia
ioeric updated this revision to Diff 61359.
ioeric marked 6 inline comments as done.
ioeric added a comment.
- Use mergeReplacements to calculate the new affected ranges.
http://reviews.llvm.org/D21547
Files:
include/clang/Tooling/Core/Replacement.h
lib/Tooling/Core/Replacement.cpp
unitte
Anastasia added inline comments.
Comment at: include/clang/Basic/DiagnosticFrontendKinds.td:220
@@ +219,2 @@
+def warn_option_depre_ocl_version : Warning<
+ "Option %0 is deprecated for this OpenCL version">, InGroup;
Looks good. If we could output the current O
ioeric added inline comments.
Comment at: include/clang/Tooling/Core/Replacement.h:253
@@ +252,3 @@
+std::vector
+calculateRangesAfterReplacements(const Replacements &Replaces,
+ const std::vector &Ranges);
getShiftedRanges sounds l
rogfer01 added a comment.
Ping?
Thank you very much.
http://reviews.llvm.org/D20561
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM with a tiny wording nit.
Comment at: include/clang/Basic/AttrDocs.td:2444
@@ +2443,3 @@
+In RenderScript, ``kernel`` functions are used to express data-para
2016-06-20 19:05 GMT+08:00 Lei Zhang :
> 2016-06-18 8:52 GMT+08:00 Rafael Espíndola :
>> There are probably a few more places that need to be patched.
>>
>> In particular, take a look at lib/Target/ARM. There are things like
>> computeTargetABI and isTargetHardFloat that probably need to be
>> upda
djasper added a comment.
Nice :)
Comment at: include/clang/Tooling/Core/Replacement.h:62
@@ +61,3 @@
+ /// \brief Whether this range is less-than \p RHS or not.
+ bool operator<(const Range &RHS) const {
+if (Offset != RHS.getOffset())
Can we just add a la
Hello Lei,
The changes to llvm and clang look ok to me. I've got some suggestions
for testing.
For the clang patch, it looks like there isn't a test to check that
musleabihf implies hard floating point. It looks like
Driver/arm-mfpu.c CHECK-HF might be a good candidate to add a test.
For the llv
ioeric updated this revision to Diff 61375.
ioeric marked 5 inline comments as done and an inline comment as not done.
ioeric added a comment.
- Addressed reviewer's comments.
http://reviews.llvm.org/D21547
Files:
include/clang/Tooling/Core/Replacement.h
lib/Tooling/Core/Replacement.cpp
u
RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lib/Headers/bmiintrin.h:284
@@ -283,2 +283,3 @@
///bits in the operand.
+
static __inline__ unsigned int __RELAXED_FN_ATTRS
Why the n
ioeric added inline comments.
Comment at: include/clang/Tooling/Core/Replacement.h:69
@@ +68,3 @@
+ /// \brief Whether this range equals to \p RHS or not.
+ bool operator==(const Range &RHS) const {
+return Offset == RHS.getOffset() && Length == RHS.getLength();
Author: prazek
Date: Tue Jun 21 10:23:27 2016
New Revision: 273275
URL: http://llvm.org/viewvc/llvm-project?rev=273275&view=rev
Log:
[clang-tidy] Add modernize-use-emplace
Summary: Add check that replaces call of push_back to emplace_back
Reviewers: hokein
Differential Revision: http://reviews.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL273275: [clang-tidy] Add modernize-use-emplace (authored by
Prazek).
Changed prior to commit:
http://reviews.llvm.org/D20964?vs=61214&id=61381#toc
Repository:
rL LLVM
http://reviews.llvm.org/D20964
Author: evandro
Date: Tue Jun 21 10:55:29 2016
New Revision: 273280
URL: http://llvm.org/viewvc/llvm-project?rev=273280&view=rev
Log:
[AArch64] Change the preferred alignment for char and short to word alignment
Differential Revision: http://reviews.llvm.org/D21414
Modified:
cfe/trunk/lib/Ba
pirama updated this revision to Diff 61390.
pirama added a comment.
computation -> computations.
http://reviews.llvm.org/D21212
Files:
docs/ReleaseNotes.rst
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
Index: include/clang/Basic/AttrDocs.td
Author: pirama
Date: Tue Jun 21 11:09:30 2016
New Revision: 273283
URL: http://llvm.org/viewvc/llvm-project?rev=273283&view=rev
Log:
Add documentation for RenderScript changes
Summary:
- Document the new 'kernel' attribute
- Mention RenderScript support in the Release Notes.
Reviewers: rsmith
S
This revision was automatically updated to reflect the committed changes.
Closed by commit rL273283: Add documentation for RenderScript changes (authored
by pirama).
Changed prior to commit:
http://reviews.llvm.org/D21212?vs=61390&id=61391#toc
Repository:
rL LLVM
http://reviews.llvm.org/D21
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
A couple of small comments, otherwise looks good.
Comment at: lib/Tooling/Core/Replacement.cpp:284
@@ +283,3 @@
+ std::sort(Ranges.begin(), Ranges.end(),
+[](co
Author: djasper
Date: Tue Jun 21 12:00:20 2016
New Revision: 273285
URL: http://llvm.org/viewvc/llvm-project?rev=273285&view=rev
Log:
clang-format: [JS] Add a Closure Compiler JSDoc tags to the default
Google configuration so that it isn't line-wrapped.
Modified:
cfe/trunk/lib/Format/Format.c
staronj added inline comments.
Comment at: clang-tidy/performance/ReturningTypeCheck.cpp:132
@@ +131,3 @@
+ // "constructedType"
+ auto HasTypeSameAsConstructed = hasType(hasCanonicalType(
+ ignoringRefsAndConsts(equalsBoundNode("constructedType";
Praze
staronj removed rL LLVM as the repository for this revision.
staronj updated this revision to Diff 61402.
staronj marked 8 inline comments as done.
staronj added a comment.
1. Name changed to return-value-copy.
2. Changed warning message.
3. Fixed check description.
http://reviews.llvm.org/D2130
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Another consequence of doing it this way is that the /Ob1 decision will survive
through LTO, for better or worse.
In http://reviews.llvm.org/D20647#461135, @probinson wrote:
> I'm still bemus
Author: tra
Date: Tue Jun 21 12:35:31 2016
New Revision: 273289
URL: http://llvm.org/viewvc/llvm-project?rev=273289&view=rev
Log:
[aarch64] Update datalayout for aarch64 tests
This brings the tests in sync with the changes in r273280.
Modified:
cfe/trunk/test/CodeGen/aarch64-type-sizes.c
hans added inline comments.
Comment at: test/Driver/cl-options.c:283
@@ -282,3 +282,2 @@
// RUN:/nologo \
-// RUN:/Ob1 \
// RUN:/openmp- \
You're removing it from the ignored flags here, but I don't see any code change
or test for how clang-cl's sup
ioeric updated this revision to Diff 61405.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- removed redundant return type in lambda function.
http://reviews.llvm.org/D21547
Files:
include/clang/Tooling/Core/Replacement.h
lib/Tooling/Core/Replacement.cpp
unittests/Toolin
ioeric added inline comments.
Comment at: lib/Tooling/Core/Replacement.cpp:285
@@ +284,3 @@
+[](const Range &LHS, const Range &RHS) -> bool {
+ if (LHS.getOffset() != RHS.getOffset())
+return LHS.getOffset() < RHS.getOffset();
-
Author: ioeric
Date: Tue Jun 21 12:56:31 2016
New Revision: 273290
URL: http://llvm.org/viewvc/llvm-project?rev=273290&view=rev
Log:
Added calculateRangesAfterReplaments() to calculate affacted ranges in the new
code.
Summary:
Added calculateRangesAfterReplaments() to calculate original ranges a
This revision was automatically updated to reflect the committed changes.
Closed by commit rL273290: Added calculateRangesAfterReplaments() to calculate
affacted ranges in the… (authored by ioeric).
Changed prior to commit:
http://reviews.llvm.org/D21547?vs=61405&id=61407#toc
Repository:
rL
arsenm added a comment.
ping
http://reviews.llvm.org/D5896
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ioeric
Date: Tue Jun 21 12:59:57 2016
New Revision: 273291
URL: http://llvm.org/viewvc/llvm-project?rev=273291&view=rev
Log:
[clang-apply-replacements] use Range::operator==() instead of self-defined
operator.
Modified:
clang-tools-extra/trunk/unittests/clang-apply-replacements/Refo
Prazek added inline comments.
Comment at: clang-tidy/performance/ReturnValueCopyCheck.cpp:107-108
@@ +106,4 @@
+ InnerMatcher) {
+ return hasDeclaration(
+ cxxRecordDecl(hasDescendant(cxxConstructorDecl(InnerMatcher;
+}
You have bug
Ilod marked an inline comment as done.
Comment at: test/Driver/cl-options.c:283
@@ -282,3 +282,2 @@
// RUN:/nologo \
-// RUN:/Ob1 \
// RUN:/openmp- \
hans wrote:
> You're removing it from the ignored flags here, but I don't see any code
> change or
Prazek added inline comments.
Comment at: clang-tidy/performance/ReturnValueCopyCheck.cpp:53
@@ +52,3 @@
+/// matches the given matcher.
+AST_MATCHER_P(QualType, ignoringRefsAndConsts,
+ ast_matchers::internal::Matcher, InnerMatcher) {
This one is use
RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.
LGTM - the compile warning is clear and it could be a problem if we allow
undefined values through on pre-AVX targets.
The only other thing we could do is handle these in CGBuiltin and 'acce
hubert.reinterpretcast added a comment.
Ping.
http://reviews.llvm.org/D19770
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D21517
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
sbenza added inline comments.
Comment at: clang-tools-extra/trunk/clang-tidy/modernize/UseEmplaceCheck.cpp:34
@@ +33,3 @@
+ hasDeclaration(functionDecl(hasName("push_back"))),
+ on(hasType(cxxRecordDecl(hasAnyName("std::vector", "llvm::SmallVector",
+
Author: rnk
Date: Tue Jun 21 13:39:55 2016
New Revision: 273296
URL: http://llvm.org/viewvc/llvm-project?rev=273296&view=rev
Log:
[MS] Don't expect vftables to be provided for extern template instantiations
MSVC doesn't provide them. PR28223
I left behind the machinery in case we want to resurre
This revision was automatically updated to reflect the committed changes.
Closed by commit rL273296: [MS] Don't expect vftables to be provided for extern
template instantiations (authored by rnk).
Changed prior to commit:
http://reviews.llvm.org/D21544?vs=61331&id=61414#toc
Repository:
rL LL
Ilod updated this revision to Diff 61418.
Ilod added a comment.
Fixed passing argument from clang driver to cc1.
Added driver tests.
http://reviews.llvm.org/D20647
Files:
include/clang/Driver/CLCompatOptions.td
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.h
lib/
Ilod marked 2 inline comments as done.
Ilod added a comment.
http://reviews.llvm.org/D20647
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: dehao
Date: Tue Jun 21 14:16:41 2016
New Revision: 273298
URL: http://llvm.org/viewvc/llvm-project?rev=273298&view=rev
Log:
Invoke PruneEH pass before Sample Profile pass.
Summary: We need to call PruneEH pass before AutoFDO pass so that some
EH-related calls can get inlined in Sample Pr
ashi1 updated this revision to Diff 61423.
ashi1 marked 2 inline comments as done.
ashi1 added a comment.
Revised based on Anastasia's comments. Also clang-test run passes, the
testcases should be working correctly.
http://reviews.llvm.org/D21031
Files:
include/clang/Basic/DiagnosticFrontend
Author: rafael
Date: Tue Jun 21 14:19:31 2016
New Revision: 273300
URL: http://llvm.org/viewvc/llvm-project?rev=273300&view=rev
Log:
Delete dead code.
Found by gcc 6.
Modified:
cfe/trunk/lib/AST/ItaniumMangle.cpp
cfe/trunk/lib/Frontend/CompilerInvocation.cpp
Modified: cfe/trunk/lib/AST/
Author: vmiklos
Date: Tue Jun 21 14:48:57 2016
New Revision: 273304
URL: http://llvm.org/viewvc/llvm-project?rev=273304&view=rev
Log:
clang-rename: add a -old-name option
This is similar to -offset with the following differences:
1) -offset can refer to local variables as well.
2) -old-name mak
This revision was automatically updated to reflect the committed changes.
Closed by commit rL273304: clang-rename: add a -old-name option (authored by
vmiklos).
Changed prior to commit:
http://reviews.llvm.org/D21517?vs=61255&id=61430#toc
Repository:
rL LLVM
http://reviews.llvm.org/D21517
hans created this revision.
hans added a reviewer: rjmccall.
hans added a subscriber: cfe-commits.
It currently only takes 2048 gotos to overflow the FixupDepth bitfield, causing
silent miscompilation. Apparently some parser generators run into this (see PR).
I don't know that that data structur
Author: rnk
Date: Tue Jun 21 14:51:52 2016
New Revision: 273305
URL: http://llvm.org/viewvc/llvm-project?rev=273305&view=rev
Log:
Revert "[MS] Don't expect vftables to be provided for extern template
instantiations"
This reverts commit r273296, it broke the Windows self-host.
Modified:
cfe/
hans accepted this revision.
hans added a comment.
In http://reviews.llvm.org/D20647#463590, @Ilod wrote:
> Fixed passing argument from clang driver to cc1.
> Added driver tests.
lgtm, thanks!
http://reviews.llvm.org/D20647
___
cfe-commits maili
yaxunl created this revision.
yaxunl added reviewers: Anastasia, bader, pxli168.
yaxunl added subscribers: cfe-commits, tstellarAMD.
Currently Clang use int32 to represent sampler_t, which have been a source of
issue for some backends, because in some backends sampler_t cannot be
represented by
arsenm updated this revision to Diff 61432.
arsenm added a comment.
Update for trunk
http://reviews.llvm.org/D5896
Files:
include/clang/Basic/Builtins.def
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/builtins.c
Index: test/CodeGen/builtins.c
Author: rsmith
Date: Tue Jun 21 15:10:11 2016
New Revision: 273309
URL: http://llvm.org/viewvc/llvm-project?rev=273309&view=rev
Log:
Refactor scope building in JumpDiagnostics for simplicity. This fixes a
(currently theoretical) bug where recursive calls to BuildScopeInformation
would do the wrong
This revision was automatically updated to reflect the committed changes.
Closed by commit rL273310: Fix clang-tidy patterns to adapt to newly added
ExprWithCleanups nodes. (authored by timshen).
Changed prior to commit:
http://reviews.llvm.org/D21243?vs=60992&id=61434#toc
Repository:
rL LLV
Author: timshen
Date: Tue Jun 21 15:11:20 2016
New Revision: 273310
URL: http://llvm.org/viewvc/llvm-project?rev=273310&view=rev
Log:
Fix clang-tidy patterns to adapt to newly added ExprWithCleanups nodes.
Summary: This is a fix for the new ExprWithCleanups introduced by clang's
temporary variab
timshen added a comment.
http://reviews.llvm.org/D21243 is committed. Let's do this again.
Repository:
rL LLVM
http://reviews.llvm.org/D20498
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
Author: spatel
Date: Tue Jun 21 15:22:55 2016
New Revision: 273311
URL: http://llvm.org/viewvc/llvm-project?rev=273311&view=rev
Log:
[x86] AVX FP compare builtins should require AVX target feature (PR28112)
This is a fix for PR28112:
https://llvm.org/bugs/show_bug.cgi?id=28112
The FP comparison
This revision was automatically updated to reflect the committed changes.
Closed by commit rL273311: [x86] AVX FP compare builtins should require AVX
target feature (PR28112) (authored by spatel).
Changed prior to commit:
http://reviews.llvm.org/D21306?vs=60596&id=61437#toc
Repository:
rL LL
timshen abandoned this revision.
timshen added a comment.
> I was wondering why we didn't created that Matcher: IgnoreImplicit
Actually you are right. There already exists a IgnoreImplict in clang-tidy and
I just switched to that.
Abandoning this patch.
Thanks!
http://reviews.llvm.org/D2124
Author: timshen
Date: Tue Jun 21 15:29:17 2016
New Revision: 273312
URL: http://llvm.org/viewvc/llvm-project?rev=273312&view=rev
Log:
Re-commit "[Temporary] Add an ExprWithCleanups for each C++
MaterializeTemporaryExpr."
Since D21243 fixes relative clang-tidy tests.
This reverts commit a71d9fbd
Author: vmiklos
Date: Tue Jun 21 15:30:40 2016
New Revision: 273314
URL: http://llvm.org/viewvc/llvm-project?rev=273314&view=rev
Log:
Fix build of ClangRenameTests
Adapt the test to the code change introduced in r273304.
Modified:
clang-tools-extra/trunk/unittests/clang-rename/USRLocFindingT
timshen added a comment.
Committed as r273312.
Repository:
rL LLVM
http://reviews.llvm.org/D20498
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Prazek added a comment.
Thank you Samuel, that it is valuable review!
I wanted to add the functionality of specifing stuff by options later.
should we revert this patch? It seems that those bugs are not so critical (at
least on llvm http://reviews.llvm.org/D21507).
Anyway, I will fix it in one w
I think this change has buffer overflow. It breaks asan build:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/13946
FAIL: Clang-Unit ::
Tooling/ToolingTests/Range.RangesWithNonOverlappingReplacements (9361
of 9474)
TEST 'Clang-Unit ::
Tooling/ToolingTest
Thanks Mike! I am working on a fix.
On Tue, Jun 21, 2016 at 10:44 PM Mike Aizatsky wrote:
> I think this change has buffer overflow. It breaks asan build:
>
> http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/13946
>
> FAIL: Clang-Unit ::
> Tooling/ToolingTests/Range.RangesWi
Author: ioeric
Date: Tue Jun 21 15:49:50 2016
New Revision: 273319
URL: http://llvm.org/viewvc/llvm-project?rev=273319&view=rev
Log:
Trying to fix a buffer overflow that broke buildbot
sanitizer-x86_64-linux-fast/builds/13946.
Modified:
cfe/trunk/lib/Tooling/Core/Replacement.cpp
Modified: c
Sent a patch trying to fix this. http://reviews.llvm.org/rL273319
On Tue, Jun 21, 2016 at 10:52 PM Eric Liu wrote:
> Thanks Mike! I am working on a fix.
>
> On Tue, Jun 21, 2016 at 10:44 PM Mike Aizatsky
> wrote:
>
>> I think this change has buffer overflow. It breaks asan build:
>>
>> http://l
zaks.anna added a comment.
Thanks for the patch! Here are the comments, most of which are nits.
Could you add the high level description of what we are doing somewhere or
maybe just describe the meaning of FunctionSpec since it encodes how functions
are modeled.
Also, we should explain why we
pirama abandoned this revision.
pirama added a comment.
Abandoning this revision. Patches for an alternative approach are listed above.
http://reviews.llvm.org/D20709
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
yaxunl updated this revision to Diff 61443.
yaxunl added a comment.
Add test deleted by accident.
http://reviews.llvm.org/D21567
Files:
include/clang/AST/ASTContext.h
include/clang/AST/BuiltinTypes.def
include/clang/AST/OperationKinds.def
include/clang/AST/Type.h
include/clang/Basic/D
hubert.reinterpretcast added a comment.
Ping.
http://reviews.llvm.org/D19322
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
I think this broke the build on windows:
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/7421/steps/build/logs/stdio
Cheers,
Rafael
On 21 June 2016 at 16:29, Tim Shen via cfe-commits
wrote:
> Author: timshen
> Date: Tue Jun 21 15:29:17 2016
> New Rev
Author: pirama
Date: Tue Jun 21 16:35:11 2016
New Revision: 273321
URL: http://llvm.org/viewvc/llvm-project?rev=273321&view=rev
Log:
Emit the DWARF tag for the RenderScript language
Summary:
If the RenderScript LangOpt is set, either via '-x renderscript' or the '.rs'
file extension, set the DWAR
This revision was automatically updated to reflect the committed changes.
Closed by commit rL273321: Emit the DWARF tag for the RenderScript language
(authored by pirama).
Changed prior to commit:
http://reviews.llvm.org/D21451?vs=61038&id=61452#toc
Repository:
rL LLVM
http://reviews.llvm.o
Author: ericwf
Date: Tue Jun 21 16:54:23 2016
New Revision: 273323
URL: http://llvm.org/viewvc/llvm-project?rev=273323&view=rev
Log:
Allow the libc++ build/source paths to contain symlinks.
The filesystem tests were expecting the paths to the build/source directories
did not contain any symlinks.
The issue should be fixed in r273323.
Thanks for the report and for your patience.
/Eric
On Mon, Jun 20, 2016 at 11:27 PM, Eric Fiselier wrote:
> Hi Artem,
>
> Sorry for the delay, I've been busy with school all day.
> I'll check in a fix tomorrow morning.
>
> Sorry again,
>
> /Eric
>
> On Mon
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
LGTM. Please, measure that this does not regress memory consumption just to be
sure.
Thanks!
Anna.
http://reviews.llvm.org/D21229
___
cfe
Author: ericwf
Date: Tue Jun 21 17:11:16 2016
New Revision: 273325
URL: http://llvm.org/viewvc/llvm-project?rev=273325&view=rev
Log:
Implement LWG issue 2725. The issue should move this meeting
Modified:
libcxx/trunk/include/experimental/filesystem
libcxx/trunk/test/std/experimental/file
Author: rafael
Date: Tue Jun 21 17:24:45 2016
New Revision: 273327
URL: http://llvm.org/viewvc/llvm-project?rev=273327&view=rev
Log:
Delete dead code.
Found by gcc 6.
Modified:
cfe/trunk/lib/Frontend/Rewrite/RewriteModernObjC.cpp
Modified: cfe/trunk/lib/Frontend/Rewrite/RewriteModernObjC.cp
Author: ericwf
Date: Tue Jun 21 17:42:42 2016
New Revision: 273328
URL: http://llvm.org/viewvc/llvm-project?rev=273328&view=rev
Log:
Implement LWG issue 2720. Replace perms::resolve_symlinks with
perms::symlink_nofollow.
This changes how filesystem::permissions(p, perms) handles symlinks. Previo
The PIC and PIE levels are not independent. In fact, if PIE is defined
it is always the same as PIC.
This is clear in the driver where ParsePICArgs returns a PIC level and
a IsPIE boolean. Unfortunately that is currently lost and we pass two
redundant levels down the pipeline.
This patch keeps a
hfinkel added a comment.
Why are you removing 'F' from all of the builtin definitions? And if you need
to, why are you not removing them from copysign?
http://reviews.llvm.org/D5896
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
On Tue, Jun 21, 2016 at 06:53:03PM -0400, Rafael Espíndola via cfe-commits
wrote:
> diff --git a/lib/Frontend/InitPreprocessor.cpp
> b/lib/Frontend/InitPreprocessor.cpp
> index 27ef59a..6b93c69 100644
> --- a/lib/Frontend/InitPreprocessor.cpp
> +++ b/lib/Frontend/InitPreprocessor.cpp
> @@ -873,10
echristo added a reviewer: aaron.ballman.
echristo added a comment.
Couple of inline comments. Also adding Aaron since he normally reviews the
attributes :)
-eric
Comment at: include/clang/Driver/Options.td:753
@@ +752,3 @@
+ HelpText<"Generate XRay instrumentation sleds on f
Author: ericwf
Date: Tue Jun 21 18:19:13 2016
New Revision: 273334
URL: http://llvm.org/viewvc/llvm-project?rev=273334&view=rev
Log:
Fix PR27684 - std::tuple no longer accepts reference to incomplete type in some
cases.
Libc++ has to deduce the 'allocator_arg_t' parameter as 'AllocArgT' for the
arsenm added a comment.
In http://reviews.llvm.org/D5896#463883, @hfinkel wrote:
> Why are you removing 'F' from all of the builtin definitions? And if you need
> to, why are you not removing them from copysign?
That marks them as emitting a libcall. It should also be removed from copysign
h
arsenm updated this revision to Diff 61468.
arsenm added a comment.
It appears removing the F isn't actually necessary, unremove it
http://reviews.llvm.org/D5896
Files:
include/clang/Basic/Builtins.def
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/builtins.c
Index: test/CodeGen/builtins.c
=
Author: dcoughlin
Date: Tue Jun 21 19:20:00 2016
New Revision: 273340
URL: http://llvm.org/viewvc/llvm-project?rev=273340&view=rev
Log:
[analyzer] Teach trackNullOrUndefValue() about class property accessors.
Teach trackNullOrUndefValue() how to properly look through PseudoObjectExprs
to find the
Author: ericwf
Date: Tue Jun 21 19:21:50 2016
New Revision: 273341
URL: http://llvm.org/viewvc/llvm-project?rev=273341&view=rev
Log:
Move native_handle thread tests to test/libcxx
Added:
libcxx/trunk/test/libcxx/thread/thread.condition/
libcxx/trunk/test/libcxx/thread/thread.condition/thr
Author: ericwf
Date: Tue Jun 21 19:32:28 2016
New Revision: 273342
URL: http://llvm.org/viewvc/llvm-project?rev=273342&view=rev
Log:
Allow placement new array test to consume extra bytes as specified by the
standard.
Modified:
libcxx/trunk/test/std/language.support/support.dynamic/new.delet
arsenm updated this revision to Diff 61472.
arsenm added a comment.
Attach right diff
http://reviews.llvm.org/D5896
Files:
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/builtins.c
Index: test/CodeGen/builtins.c
===
--- test/CodeGen/b
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
Silence unused variable warnings in invoke.pass.cpp.
Fixes MSVC warning C4101 "unreferenced local variable".
http://reviews.llvm.org/D21581
Files:
test/std/utilities/functi
1 - 100 of 163 matches
Mail list logo
