Re: [PATCH] D20561: Warn when taking address of packed member

rogfer01 reopened this revision. rogfer01 added a comment. This revision is now accepted and ready to land. I suggest that we handle the reference binding diagnostic in another change and leave this one only for the address taking diagnostic. Repository: rL LLVM https://reviews.llvm.org/D205

Re: [PATCH] D20561: Warn when taking address of packed member

rogfer01 added a comment. In https://reviews.llvm.org/D20561#484421, @jyknight wrote: > This seems to trigger even for the implicitly generated copier of a packed > struct. E.g. > > #include > > void copyit(epoll_event&out, const epoll_event &in) { > out = in; > } > > > > Is that

Re: [PATCH] D22351: [include-fixer] Move cursor to #include line in vim after inserting a missing header.

djasper added a comment. FWIW, I think I'd like this behavior as it shows me what is actually being done. I can undo/redo to double-check or C-O to get back to where I was. Of course making it configurable seems like the right thing to do. Comment at: include-fixer/tool/clang-

Re: [PATCH] D22367: [include-fixer] Always add as few as possible qualifiers to the unidentified symbol.

hokein updated this revision to Diff 64104. hokein marked an inline comment as done. hokein added a comment. Add comment. https://reviews.llvm.org/D22367 Files: include-fixer/IncludeFixerContext.cpp unittests/include-fixer/IncludeFixerTest.cpp Index: unittests/include-fixer/IncludeFixerTes

[clang-tools-extra] r275542 - [include-fixer] Always add as few as possible qualifiers to the unidentified symbol.

Author: hokein Date: Fri Jul 15 03:12:48 2016 New Revision: 275542 URL: http://llvm.org/viewvc/llvm-project?rev=275542&view=rev Log: [include-fixer] Always add as few as possible qualifiers to the unidentified symbol. Reviewers: bkramer Subscribers: cfe-commits Differential Revision: https://r

Re: [PATCH] D22367: [include-fixer] Always add as few as possible qualifiers to the unidentified symbol.

This revision was automatically updated to reflect the committed changes. Closed by commit rL275542: [include-fixer] Always add as few as possible qualifiers to the unidentified… (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D22367?vs=64104&id=64107#toc Repository:

Re: [PATCH] D22351: [include-fixer] Move cursor to #include line in vim after inserting a missing header.

hokein updated this revision to Diff 64110. hokein added a comment. Avoid a hacky way to get #include line number. https://reviews.llvm.org/D22351 Files: include-fixer/tool/clang-include-fixer.py Index: include-fixer/tool/clang-include-fixer.py ===

Re: [PATCH] D22351: [include-fixer] Move cursor to #include line in vim after inserting a missing header.

hokein marked an inline comment as done. hokein added a comment. https://reviews.llvm.org/D22351 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20561: Warn when taking address of packed member

rogfer01 added a comment. I've opened https://llvm.org/bugs/show_bug.cgi?id=28571 to track the reference binding issue. Repository: rL LLVM https://reviews.llvm.org/D20561 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

Re: [PATCH] D20561: Warn when taking address of packed member

rogfer01 updated the summary for this revision. rogfer01 removed rL LLVM as the repository for this revision. rogfer01 updated this revision to Diff 64114. rogfer01 added a comment. Remove the diagnostic for the binding of references. https://reviews.llvm.org/D20561 Files: include/clang/Basic

Re: [PATCH] D21748: Implement tooling::Replacements as a class.

ioeric added inline comments. Comment at: lib/Tooling/Core/Replacement.cpp:300 @@ +299,3 @@ +Replacements Replacements::merge(const Replacement &R) const { + Replacements Rs; + llvm::consumeError(Rs.add(R)); klimek wrote: > I'd probably add a single-replacement

Re: [PATCH] D22374: [analyzer] Copy and move constructors - ExprEngine extended for "almost trivial" copy and move constructors

xazax.hun added a comment. Note that, once a constructor is not available, we will conservatively treat it as nontrivial. This is not the case however for most of the templated code. Since the STL use templates heavily I think this patch is a great step forward in improving the modeling of C++

Re: [PATCH] D22292: [libunwind] Fix unw_getcontext for ARMv6-m

rmaprath added a subscriber: olista01. rmaprath added a comment. Update: We've hit a minor issue with the patch, we're confident it can be sorted by next week. I will ask @olista01 to put the final patch for review next week, as I'm on holidays. Hope this is OK. Cheers, / Asiri https://revie

[clang-tools-extra] r275545 - [clang-rename] add few tests

Author: omtcyfz Date: Fri Jul 15 05:21:33 2016 New Revision: 275545 URL: http://llvm.org/viewvc/llvm-project?rev=275545&view=rev Log: [clang-rename] add few tests Thiis patch introduces few additional tests including one case the tool does not handle yet, which should be fixed in the future. Di

Re: [PATCH] D22102: [clang-rename] extend testset

This revision was automatically updated to reflect the committed changes. Closed by commit rL275545: [clang-rename] add few tests (authored by omtcyfz). Changed prior to commit: https://reviews.llvm.org/D22102?vs=63939&id=64119#toc Repository: rL LLVM https://reviews.llvm.org/D22102 Files:

[clang-tools-extra] r275550 - [clang-rename] apply stylistic fixes

Author: omtcyfz Date: Fri Jul 15 06:29:16 2016 New Revision: 275550 URL: http://llvm.org/viewvc/llvm-project?rev=275550&view=rev Log: [clang-rename] apply stylistic fixes Modified: clang-tools-extra/trunk/clang-rename/USRFinder.cpp clang-tools-extra/trunk/clang-rename/USRFindingAction.h

[clang-tools-extra] r275556 - [clang-rename] fix testset

Author: omtcyfz Date: Fri Jul 15 07:22:38 2016 New Revision: 275556 URL: http://llvm.org/viewvc/llvm-project?rev=275556&view=rev Log: [clang-rename] fix testset Make yet unsupported tests marked with FIXME pass so that buildbot doesn't fail. Added: clang-tools-extra/trunk/test/clang-rename/C

[PATCH] D22408: [clang-rename] add support for overridden functions

omtcyfz created this revision. omtcyfz added reviewers: bkramer, alexfh, klimek. omtcyfz added a subscriber: cfe-commits. add implementation and tests for virtual function renaming https://reviews.llvm.org/D22408 Files: clang-rename/USRFindingAction.cpp test/clang-rename/VirtualFunctionFindI

r275558 - Removing a few more :option: tags that we do not have corresponding .. option directives for; these are causing the sphinx bot to fail (http://lab.llvm.org:8011/builders/clang-sphinx-docs/bu

Author: aaronballman Date: Fri Jul 15 07:55:47 2016 New Revision: 275558 URL: http://llvm.org/viewvc/llvm-project?rev=275558&view=rev Log: Removing a few more :option: tags that we do not have corresponding .. option directives for; these are causing the sphinx bot to fail (http://lab.llvm.org:8

Re: [PATCH] D19311: [analyzer] Self Assignment Checker

baloghadamsoftware updated this revision to Diff 64135. baloghadamsoftware added a comment. Test updated. https://reviews.llvm.org/D19311 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitor.h lib/StaticAnalyzer/Checkers

Re: [PATCH] D19311: [analyzer] Self Assignment Checker

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added a comment. https://reviews.llvm.org/D19311 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r275560 - Removing a few more :option: tags that we do not have corresponding .. option directives for; these are causing the sphinx bot to fail (http://lab.llvm.org:8011/builders/clang-sphinx-docs/bu

Author: aaronballman Date: Fri Jul 15 08:13:45 2016 New Revision: 275560 URL: http://llvm.org/viewvc/llvm-project?rev=275560&view=rev Log: Removing a few more :option: tags that we do not have corresponding .. option directives for; these are causing the sphinx bot to fail (http://lab.llvm.org:8

Re: [PATCH] D21814: clang-rename: support multiple renames with one invocation

klimek added a comment. In https://reviews.llvm.org/D21814#478879, @vmiklos wrote: > As far as I see `tooling::CommonOptionsParser` (in its current form) does not > handle cl::SubCommand instances. Should I fix that or would it be OK to > switch to using `cl::ParseCommandLineOptions` directly i

Re: [PATCH] D21814: clang-rename: support multiple renames with one invocation

vmiklos added a comment. The alternative is to change the `CommonOptionsParser` ctor to take a vector of `OptionCategory&`, and in that case we can add the -extra-arg-before and other options to all subcommands, but that means he'll have to adapt all client code, i.e. all tools in clang-tools-e

Re: [PATCH] D21814: clang-rename: support multiple renames with one invocation

klimek added a comment. In https://reviews.llvm.org/D21814#485410, @vmiklos wrote: > The alternative is to change the `CommonOptionsParser` ctor to take a vector > of `OptionCategory&`, and in that case we can add the -extra-arg-before and > other options to all subcommands, but that means he'l

Re: [PATCH] D19771: Rework FixedSizeTemplateParameterListStorage

hubert.reinterpretcast abandoned this revision. hubert.reinterpretcast added a comment. This is superseded by https://reviews.llvm.org/D19322. https://reviews.llvm.org/D19771 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

Re: [PATCH] D18639: Use __builtin_isnan/isinf/isfinite in complex

scanon added a comment. I am not the right person to review the C++ template details, but everything else seems OK to me. https://reviews.llvm.org/D18639 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

Re: [PATCH] D22096: [OpenMP] Sema and parsing for 'target parallel for simd' pragma

I will take a look and put up a patch for it. Kelvin On Fri, Jul 15, 2016 at 2:46 AM, Alexey Bataev wrote: > Kelvin, > Please look at these messages and fix the tests. Or tell me and I will > fix them > > Best regards, > Alexey Bataev > = > Software Engineer > Intel Compiler Team >

Re: [PATCH] D22171: [ObjC Availability] Implement parser support for Objective-C's @available

erik.pilkington added a comment. Ping! https://reviews.llvm.org/D22171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21814: clang-rename: support multiple renames with one invocation

vmiklos added a comment. I'm a bit confused. On one hand, I want to use tooling::CommonOptionsParser to parse the options, which needs a cl::OptionCategory as a parameter. On the other hand, I want to parse the options, based on that I'll know what subcommand was requested, and then I can choo

r275570 - XRay: Remove duplicate checks for xray instrumentation flags

Author: dberris Date: Fri Jul 15 10:46:39 2016 New Revision: 275570 URL: http://llvm.org/viewvc/llvm-project?rev=275570&view=rev Log: XRay: Remove duplicate checks for xray instrumentation flags Modified: cfe/trunk/lib/Driver/Tools.cpp Modified: cfe/trunk/lib/Driver/Tools.cpp URL: http://ll

Re: [PATCH] D22374: [analyzer] Copy and move constructors - ExprEngine extended for "almost trivial" copy and move constructors

baloghadamsoftware updated this revision to Diff 64149. baloghadamsoftware added a comment. Revised version based on comments. https://reviews.llvm.org/D22374 Files: lib/StaticAnalyzer/Core/ExprEngineCXX.cpp test/Analysis/ctor.mm Index: test/Analysis/ctor.mm ===

Re: [PATCH] D22374: [analyzer] Copy and move constructors - ExprEngine extended for "almost trivial" copy and move constructors

baloghadamsoftware marked 6 inline comments as done. baloghadamsoftware added a comment. https://reviews.llvm.org/D22374 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21567: [OpenCL] Generate struct type for sampler_t and function call for the initializer

yaxunl marked 11 inline comments as done. Comment at: test/CodeGenOpenCL/sampler.cl:2 @@ +1,3 @@ +// RUN: %clang_cc1 %s -emit-llvm -triple spir-unknown-unknown -o - -O0 | FileCheck %s + +#define CLK_ADDRESS_CLAMP_TO_EDGE 2 Fixed and moved to sema test. ===

Re: [PATCH] D21567: [OpenCL] Generate struct type for sampler_t and function call for the initializer

yaxunl updated this revision to Diff 64154. yaxunl added a comment. Turn on -Wspir-compat for spir target by default. Diagnose invalid sampler value at Sema instead of Codegen. https://reviews.llvm.org/D21567 Files: include/clang/AST/OperationKinds.def include/clang/Basic/DiagnosticGroups.

Re: [PATCH] D22183: [SemObjC] Fix TypoExpr handling in TransformObjCDictionaryLiteral

bruno updated this revision to Diff 64162. bruno added a comment. Thanks for the review Manman, I found a much better approach. Updated the patch to reflect that! https://reviews.llvm.org/D22183 Files: lib/Parse/ParseObjc.cpp test/SemaObjC/objc-array-literal.m test/SemaObjC/objc-dictiona

r275577 - AMDGPU: Add Clang Builtin for v_lerp_u8

Author: wdng Date: Fri Jul 15 11:43:03 2016 New Revision: 275577 URL: http://llvm.org/viewvc/llvm-project?rev=275577&view=rev Log: AMDGPU: Add Clang Builtin for v_lerp_u8 Differential Revision: http://reviews.llvm.org/D22380 Modified: cfe/trunk/include/clang/Basic/BuiltinsAMDGPU.def cfe/

Re: [PATCH] D22096: [OpenMP] Sema and parsing for 'target parallel for simd' pragma

kkwli0 added a comment. I update the test cases in https://reviews.llvm.org/D22417. Repository: rL LLVM https://reviews.llvm.org/D22096 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

Re: [PATCH] D19544: Pass for translating math intrinsics to math library calls.

mmasten added a comment. Thanks for reviewing. One concern I have going forward is the number of entries that will appear in the switch statement inside addVectorizableFunctionsFromVecLib(). I assume that the right thing to do is to replace this with something that is TableGen'd? Also, I just w

r275589 - [objcmt] Don't add an #import of Foundation unnecessarily, if the NS_ENUM macro is already defined.

Author: akirtzidis Date: Fri Jul 15 13:11:27 2016 New Revision: 275589 URL: http://llvm.org/viewvc/llvm-project?rev=275589&view=rev Log: [objcmt] Don't add an #import of Foundation unnecessarily, if the NS_ENUM macro is already defined. Modified: cfe/trunk/lib/ARCMigrate/ObjCMT.cpp cfe/t

r275590 - [AST] Keep track of the left brace source location of a tag decl.

Author: akirtzidis Date: Fri Jul 15 13:11:33 2016 New Revision: 275590 URL: http://llvm.org/viewvc/llvm-project?rev=275590&view=rev Log: [AST] Keep track of the left brace source location of a tag decl. This is useful for source modification tools. There will be a follow-up commit using it. Mod

Re: [PATCH] D22171: [ObjC Availability] Implement parser support for Objective-C's @available

manmanren accepted this revision. manmanren added a comment. This revision is now accepted and ready to land. LGTM. Manman https://reviews.llvm.org/D22171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

Re: [PATCH] D22334: Fix for Bug 28172 : clang crashes on invalid code (with too few arguments to __builtin_signbit) without any proper diagnostics.

george.burgess.iv accepted this revision. george.burgess.iv added a comment. This revision is now accepted and ready to land. LGTM; thanks for the patch! https://reviews.llvm.org/D22334 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://

Re: [PATCH] D22334: Fix for Bug 28172 : clang crashes on invalid code (with too few arguments to __builtin_signbit) without any proper diagnostics.

majnemer added a subscriber: majnemer. majnemer requested changes to this revision. majnemer added a reviewer: majnemer. majnemer added a comment. This revision now requires changes to proceed. I feel like this needs further validation. For example, we crash on: int x = __builtin_signbit("1");

r275600 - [objcmt] Fix a buffer overflow crash than can occur while modernizing enums.

Author: akirtzidis Date: Fri Jul 15 14:22:34 2016 New Revision: 275600 URL: http://llvm.org/viewvc/llvm-project?rev=275600&view=rev Log: [objcmt] Fix a buffer overflow crash than can occur while modernizing enums. Note that due to the nature of the crash it requires libgmalloc or asan for it to

Re: r275600 - [objcmt] Fix a buffer overflow crash than can occur while modernizing enums.

> On Jul 15, 2016, at 12:22 PM, Argyrios Kyrtzidis via cfe-commits > wrote: > > Author: akirtzidis > Date: Fri Jul 15 14:22:34 2016 > New Revision: 275600 > > URL: http://llvm.org/viewvc/llvm-project?rev=275600&view=rev > Log: > [objcmt] Fix a buffer overflow crash than can occur while moderni

Re: r275600 - [objcmt] Fix a buffer overflow crash than can occur while modernizing enums.

> On Jul 15, 2016, at 12:58 PM, Ben Langmuir wrote: > >> >> On Jul 15, 2016, at 12:22 PM, Argyrios Kyrtzidis via cfe-commits >> wrote: >> >> Author: akirtzidis >> Date: Fri Jul 15 14:22:34 2016 >> New Revision: 275600 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=275600&view=rev >> Log

Re: [PATCH] D15914: [OpenCL] Pipe builtin functions

vpykhtin added a subscriber: vpykhtin. vpykhtin added a comment. Hi, is there an intention to make this SPIR 2.0 (provisional) conformant? This would require changing resulting builtin names, changing pipe argument to "struct opencl.pipe*" and adding two trailing "size, alignment" parameters. I

Re: [PATCH] D22273: Treat enumerator_too_large as an extension in MS ABI mode

DaveBartolomeo abandoned this revision. DaveBartolomeo added a comment. I'll attempt to fix the underlying issue https://llvm.org/bugs/show_bug.cgi?id=27098 instead. https://reviews.llvm.org/D22273 ___ cfe-commits mailing list cfe-commits@lists.llv

r275609 - [test/objcmt] Add a follow-up test case for r275600.

Author: akirtzidis Date: Fri Jul 15 15:40:24 2016 New Revision: 275609 URL: http://llvm.org/viewvc/llvm-project?rev=275609&view=rev Log: [test/objcmt] Add a follow-up test case for r275600. Modified: cfe/trunk/test/ARCMT/whitelisted/header1.h cfe/trunk/test/ARCMT/whitelisted/header1.h.res

Re: r275600 - [objcmt] Fix a buffer overflow crash than can occur while modernizing enums.

> On Jul 15, 2016, at 1:03 PM, Argyrios Kyrtzidis wrote: > >> >> On Jul 15, 2016, at 12:58 PM, Ben Langmuir > > wrote: >> >>> >>> On Jul 15, 2016, at 12:22 PM, Argyrios Kyrtzidis via cfe-commits >>> mailto:cfe-commits@lists.llvm.org>> wrote: >>> >>> Author: akirt

r275610 - Sema: support __declspec(dll*) on ObjC interfaces

Author: compnerd Date: Fri Jul 15 15:41:10 2016 New Revision: 275610 URL: http://llvm.org/viewvc/llvm-project?rev=275610&view=rev Log: Sema: support __declspec(dll*) on ObjC interfaces Extend the __declspec(dll*) attribute to cover ObjC interfaces. This was requested by Microsoft for their ObjC

r275612 - Push alias-declarations and alias-template declarations into scope even if

Author: rsmith Date: Fri Jul 15 15:53:25 2016 New Revision: 275612 URL: http://llvm.org/viewvc/llvm-project?rev=275612&view=rev Log: Push alias-declarations and alias-template declarations into scope even if they're redeclarations. This is necessary in order for name lookup to correctly find the m

Re: [PATCH] D22392: [Sema] Fix an invalid nullability warning for binary conditional operators

ahatanak added inline comments. Comment at: lib/Sema/SemaExpr.cpp:7007 @@ +7006,3 @@ +/// expression. +static QualType modifyNullability(QualType ResTy, Expr *RHSExpr, + ASTContext &Ctx) { doug.gregor wrote: > This name could be im

r275622 - AMDGPU: Update for rsq intrinsic changes

Author: arsenm Date: Fri Jul 15 16:33:02 2016 New Revision: 275622 URL: http://llvm.org/viewvc/llvm-project?rev=275622&view=rev Log: AMDGPU: Update for rsq intrinsic changes Modified: cfe/trunk/include/clang/Basic/BuiltinsAMDGPU.def cfe/trunk/lib/CodeGen/CGBuiltin.cpp cfe/trunk/test/C

r275623 - AMDGPU: Remove legacy ldexp builtin

Author: arsenm Date: Fri Jul 15 16:33:06 2016 New Revision: 275623 URL: http://llvm.org/viewvc/llvm-project?rev=275623&view=rev Log: AMDGPU: Remove legacy ldexp builtin Modified: cfe/trunk/include/clang/Basic/BuiltinsAMDGPU.def cfe/trunk/lib/CodeGen/CGBuiltin.cpp cfe/trunk/test/CodeGe

r275624 - Revert r275481, r275490. This broke modules bootstrap.

Author: rsmith Date: Fri Jul 15 16:33:46 2016 New Revision: 275624 URL: http://llvm.org/viewvc/llvm-project?rev=275624&view=rev Log: Revert r275481, r275490. This broke modules bootstrap. Removed: cfe/trunk/test/Modules/Inputs/unused-global-init/ cfe/trunk/test/Modules/unused-global-init.

[PATCH] D22426: Fix automatic detection of ARM MSVC toolset in clang.exe

DaveBartolomeo created this revision. DaveBartolomeo added reviewers: rnk, majnemer, cfe-commits. Herald added subscribers: rengolin, aemerson. Clang was failing to find the ARM version of the MSVC link.exe, even though it could correctly find link.exe for x86 and x64. Clang looks in the %VCINST

Re: [PATCH] D22392: [Sema] Fix an invalid nullability warning for binary conditional operators

ahatanak added a comment. I'm thinking about taking the following steps to compute the nullability of ternary operators. The first step is to compute the "merged" nullability of the LHS and RHS. For normal ternary operators (not the shorthand version): - If both LHS and RHS have the same nulla

Re: [PATCH] D21104: [CodeGen][ObjC] Block captures should inherit the type of the captured field in the enclosing lambda or block

ahatanak updated this revision to Diff 64199. ahatanak added a comment. Rebase. https://reviews.llvm.org/D21104 Files: lib/CodeGen/CGBlocks.cpp lib/CodeGen/CGBlocks.h test/CodeGenObjCXX/lambda-expressions.mm Index: test/CodeGenObjCXX/lambda-expressions.mm

r275630 - [index] Create different USR if a property is a class property.

Author: akirtzidis Date: Fri Jul 15 17:18:19 2016 New Revision: 275630 URL: http://llvm.org/viewvc/llvm-project?rev=275630&view=rev Log: [index] Create different USR if a property is a class property. Avoids USR conflicts between class & instance properties of the same name. Modified: cfe/tr

Re: [PATCH] D21814: clang-rename: support multiple renames with one invocation

vmiklos updated this revision to Diff 64204. https://reviews.llvm.org/D21814 Files: clang-rename/tool/ClangRename.cpp test/clang-rename/ClassFindByName.cpp test/clang-rename/ClassReplacements.cpp test/clang-rename/ClassSimpleRenaming.cpp test/clang-rename/ClassTest.cpp test/clang-rena

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos added a comment. I've implemented the requested split of options, now there are two new rename-at and rename-all subcommands. The only common options is -i and -new-name, nothing else is shared, apart from the common options added by `tooling::CommonOptionsParser`. The code is modeled a

r275645 - [CUDA][OpenMP] Create generic offload action

Author: sfantao Date: Fri Jul 15 18:13:27 2016 New Revision: 275645 URL: http://llvm.org/viewvc/llvm-project?rev=275645&view=rev Log: [CUDA][OpenMP] Create generic offload action Summary: This patch replaces the CUDA specific action by a generic offload action. The offload action may have multip

Re: [PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

silvas accepted this revision. silvas added a comment. This revision is now accepted and ready to land. Once all of David's comments are addressed this LGTM. Repository: rL LLVM https://reviews.llvm.org/D21823 ___ cfe-commits mailing list cfe-com

Re: [PATCH] D19544: Pass for translating math intrinsics to math library calls.

hfinkel added a comment. In https://reviews.llvm.org/D19544#485677, @mmasten wrote: > Thanks for reviewing. One concern I have going forward is the number of > entries that will appear in the switch statement inside > addVectorizableFunctionsFromVecLib(). I assume that the right thing to do is

Re: [PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

davidxl accepted this revision. davidxl added a comment. lgtm Repository: rL LLVM https://reviews.llvm.org/D21823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r275645 - [CUDA][OpenMP] Create generic offload action

I'm looking into it. Thanks for letting me know.   Samuel   - Original message -From: Kostya Serebryany To: Samuel F Antao/Watson/IBM@IBMUSCc: cfe-commits Subject: Re: r275645 - [CUDA][OpenMP] Create generic offload actionDate: Fri, Jul 15, 2016 7:37 PM  Our windows bot is unhappy:  http://

r275650 - Attempt to fix breakage caused by r275645 for Windows bots.

Author: sfantao Date: Fri Jul 15 18:51:21 2016 New Revision: 275650 URL: http://llvm.org/viewvc/llvm-project?rev=275650&view=rev Log: Attempt to fix breakage caused by r275645 for Windows bots. Modified: cfe/trunk/include/clang/Driver/Action.h cfe/trunk/lib/Driver/Action.cpp Modified: cf

Re: r275115 - Prevent the creation of empty (forwarding) blocks resulting from nested ifs.

This change broke several MIPS builders: https://dmz-portal.mips.com/bb/builders/LLVM%20with%20integrated%20assembler%20and%20fPIC%20and%20-O0 and https://dmz-portal.mips.com/bb/builders/LLVM%20with%20integrated%20assembler%20and%20fPIC%20and%20-O0%20and%20fast%20isel%20and%20mips%20fast%20isel

Re: [PATCH] D22426: Fix automatic detection of ARM MSVC toolset in clang.exe

compnerd added a subscriber: compnerd. compnerd accepted this revision. compnerd added a reviewer: compnerd. compnerd added a comment. This revision is now accepted and ready to land. I imagine that at this point, most usage is still based around the x86 toolchain rather than x64 (I didnt even no

r275651 - Use std::string instead of StringRef when generating the auxiliar triple in the frontend tool.

Author: sfantao Date: Fri Jul 15 19:15:56 2016 New Revision: 275651 URL: http://llvm.org/viewvc/llvm-project?rev=275651&view=rev Log: Use std::string instead of StringRef when generating the auxiliar triple in the frontend tool. Modified: cfe/trunk/lib/Driver/Tools.cpp Modified: cfe/trunk/

[PATCH] D22431: clang-format: [JS] nested and tagged template strings.

mprobst created this revision. mprobst added a reviewer: djasper. mprobst added a subscriber: cfe-commits. Herald added a subscriber: klimek. https://reviews.llvm.org/D22431 Files: lib/Format/FormatTokenLexer.cpp lib/Format/FormatTokenLexer.h lib/Format/TokenAnnotator.cpp unittests/Format

r275653 - Reimplement ExternalSemaSource delegation in terms of

Author: rsmith Date: Fri Jul 15 19:35:14 2016 New Revision: 275653 URL: http://llvm.org/viewvc/llvm-project?rev=275653&view=rev Log: Reimplement ExternalSemaSource delegation in terms of MultiplexExternalSemaSource to remove one of the places that needs updating every time the ExternalSemaSource i

r275654 - [ObjC] Implement @available in the Parser and AST

Author: epilk Date: Fri Jul 15 19:35:23 2016 New Revision: 275654 URL: http://llvm.org/viewvc/llvm-project?rev=275654&view=rev Log: [ObjC] Implement @available in the Parser and AST This patch adds a new AST node: ObjCAvailabilityCheckExpr, and teaches the Parser and Sema to generate it. This nod

Re: [PATCH] D22171: [ObjC Availability] Implement parser support for Objective-C's @available

This revision was automatically updated to reflect the committed changes. Closed by commit rL275654: [ObjC] Implement @available in the Parser and AST (authored by epilk). Changed prior to commit: https://reviews.llvm.org/D22171?vs=63603&id=64215#toc Repository: rL LLVM https://reviews.llvm

Re: [PATCH] D22431: clang-format: [JS] nested and tagged template strings.

mprobst added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:1821 @@ -1819,1 +1820,3 @@ +(Right.is(TT_TemplateString) && Right.TokenText.startswith("}"))) + return 100; } I've chosen 100 by fair dice roll. Please advise on how to pick a

r275655 - Remove extra semi-colon. Fixes warning and Werror bots.

Author: echristo Date: Fri Jul 15 19:58:34 2016 New Revision: 275655 URL: http://llvm.org/viewvc/llvm-project?rev=275655&view=rev Log: Remove extra semi-colon. Fixes warning and Werror bots. Modified: cfe/trunk/lib/Driver/Action.cpp Modified: cfe/trunk/lib/Driver/Action.cpp URL: http://llvm

Re: [PATCH] D22426: Fix automatic detection of ARM MSVC toolset in clang.exe

DaveBartolomeo added a comment. In https://reviews.llvm.org/D22426#486100, @compnerd wrote: > I imagine that at this point, most usage is still based around the x86 > toolchain rather than x64 (I didnt even notice the x64 tools until recently). > That is, any reason that we shouldnt be using x

Re: [PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

jakev added a comment. Fantastic. Sean or David, could one of you commit this for me? It would be much appreciated. Repository: rL LLVM https://reviews.llvm.org/D21823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

r275668 - [Driver] Add flags for enabling both types of PGO Instrumentation

Author: silvas Date: Fri Jul 15 21:54:58 2016 New Revision: 275668 URL: http://llvm.org/viewvc/llvm-project?rev=275668&view=rev Log: [Driver] Add flags for enabling both types of PGO Instrumentation The flags: Enable IR-level instrumentation -fprofile-generate or -fprofile-generate= When applying

Re: [PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

This revision was automatically updated to reflect the committed changes. Closed by commit rL275668: [Driver] Add flags for enabling both types of PGO Instrumentation (authored by silvas). Changed prior to commit: https://reviews.llvm.org/D21823?vs=64056&id=64222#toc Repository: rL LLVM htt

Re: [PATCH] D22237: clang-rename: fix renaming member functions

omtcyf0 added a comment. Hi! Sorry for a late response. The issue is that you only deal with the consequences of this "bug". Overridden functions simply have different USRs, so the solution is just to add relevant USRs. Trying to deal with it in `USRLocFinder.cpp` doesn't seem right; the chan