r278908 - Add missing tests

Author: rogfer01 Date: Wed Aug 17 01:52:15 2016 New Revision: 278908 URL: http://llvm.org/viewvc/llvm-project?rev=278908&view=rev Log: Add missing tests Change r278483 was missing the tests Differential Revision: https://reviews.llvm.org/D20561 Added: cfe/trunk/test/Sema/address-packed-mem

Re: [PATCH] D23045: [Include-fixer] Install executables and support scripts

hokein added a comment. Sorry for the delay. I totally missed it. Comment at: include-fixer/find-all-symbols/tool/CMakeLists.txt:22 @@ +21,2 @@ + DESTINATION share/clang + COMPONENT find-all-symbols) Eugene.Zelenko wrote: > hokein wrote: > > I think we can put

Re: [PATCH] D12192: Add clang support for AAP

edward-jones abandoned this revision. edward-jones added a comment. We have closed the accompanying LLVM patch https://reviews.llvm.org/D12191, so this patch is no longer relevant. https://reviews.llvm.org/D12192 ___ cfe-commits mailing list cfe-co

Re: [PATCH] D23585: [ASTMatchers] Add narrowing matcher: hasExternalFormalLinkage

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: docs/LibASTMatchersReference.html:2774 @@ -2773,1 +2773,3 @@ +MatcherNamedDecl>hasExternalFormalLinkage +Matches N

Re: [PATCH] D23168: emit_DW_AT_noreturn flag

vleschuk updated this revision to Diff 68321. vleschuk added a comment. More context in text. https://reviews.llvm.org/D23168 Files: lib/AST/Decl.cpp lib/CodeGen/CGDebugInfo.cpp test/Frontend/dinoreturn.c test/Frontend/dinoreturn.cpp test/Frontend/dinoreturn.m Index: test/Frontend/di

Re: [PATCH] D23455: [Tooling] Parse compilation database command lines properly on Windows

alexfh added a comment. In https://reviews.llvm.org/D23455#516760, @zturner wrote: > In https://reviews.llvm.org/D23455#516753, @alexfh wrote: > > > In https://reviews.llvm.org/D23455#515527, @rnk wrote: > > > > > In https://reviews.llvm.org/D23455#515486, @brad.king wrote: > > > > > > > > the fe

Re: [PATCH] D22220: [clang-tidy] Add check 'misc-move-forwarding-reference'

mboehme updated this revision to Diff 68322. mboehme added a comment. Reponses to reviewer comments https://reviews.llvm.org/D0 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/MoveForwardingReferenceCheck.cpp clang-tidy/misc/MoveForwardingRef

Re: [PATCH] D22507: Clang-tidy - Enum misuse check

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-tidy/misc/EnumMisuseCheck.cpp:28 @@ +27,3 @@ +llvm::APSInt BeginVal = EnumDec->enumerator_begin()->getInitVal(); +{ + const auto MinMaxVal = std::minmax_element

Re: [PATCH] D22220: [clang-tidy] Add check 'misc-move-forwarding-reference'

mboehme marked 2 inline comments as done. Comment at: clang-tidy/misc/MoveForwardingReferenceCheck.cpp:46-56 @@ +45,13 @@ +// std::move(). This will hopefully prevent erroneous replacements if the +// code does unusual things (e.g. create an alias for std::move() in +/

Port tools/clang-format/git-clang-format to work Python beyond 2.7

Since Python3 may deliberately not be available on Linux Systems (to prevent people from writing non-futureproof code), git-clang-format should not only work with Python2.7. This patch adds support for Python3. From 20175b753d8ef9f00f33fe04484dce1c0148ff7c Mon Sep 17 00:00:00 2001 From: Andreas

Re: [PATCH] D22725: [clang-tidy] Add check 'modernize-use-algorithm'

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-tidy/modernize/UseAlgorithmCheck.cpp:37 @@ +36,3 @@ +static bool areTypesCompatible(QualType Left, QualType Right) { + return getStrippedType(Left) == getStrippedType(Right

Re: [PATCH] D23543: Adapt to TraverseLambdaCapture interface change from D23204

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D23543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

Re: [PATCH] D23204: Visit lambda capture inits from RecursiveASTVisitor::TraverseLambdaCapture().

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LGTM with a couple of nits. Comment at: unittests/Tooling/RecursiveASTVisitorTestExprVisitor.cpp:221 @@ +220,3 @@ + } + { +DeclRefExprVisitor Visitor; n

Re: [PATCH] D23343: [clang-tidy] modernize-make-{smart_ptr} private ctor bugfix

alexfh added inline comments. Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:35 @@ +34,3 @@ + auto CanCallCtor = unless(has(ignoringImpCasts(cxxConstructExpr( + hasDeclaration(decl(anyOf(isPrivate(), isProtected(; + Prazek wrote: > aaron.ball

[PATCH] D23602: Port tools/clang-format/git-clang-format to work Python beyond 2.7

abergmeier-dsfishlabs created this revision. abergmeier-dsfishlabs added a reviewer: djasper. abergmeier-dsfishlabs added a subscriber: cfe-commits. abergmeier-dsfishlabs set the repository for this revision to rL LLVM. abergmeier-dsfishlabs changed the edit policy of this Differential Revision fr

Re: [PATCH] D23596: [Documentation] Remove duplicated checks groups descriptions form clang-tidy/index.rst

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: docs/clang-tidy/index.rst:344 @@ -343,4 +343,3 @@ verifies conformance of the code to a certain coding style, it probably deserves -a separate module and a directory in ``clang-

Re: [PATCH] D23353: [clang-tidy] Add check 'misc-use-after-move'

alexfh added inline comments. Comment at: clang-tidy/misc/UseAfterMoveCheck.cpp:659 @@ +658,3 @@ + UseAfterMove Use; + if (finder.find(FunctionBody, MovingCall, MovedVariable, &Use)) { +emitDiagnostic(MovingCall, MovedVariable, Use, this, Result.Context); om

Re: [PATCH] D23167: emit_DW_AT_noreturn flag

vleschuk updated this revision to Diff 68327. vleschuk marked an inline comment as done. vleschuk added a comment. Added test for noreturn flag for test/Assembler/disubprogram.ll https://reviews.llvm.org/D23167 Files: include/llvm/IR/DebugInfoFlags.def include/llvm/IR/DebugInfoMetadata.h

Re: [PATCH] D23167: emit_DW_AT_noreturn flag

vleschuk updated this revision to Diff 68328. vleschuk added a comment. Full context https://reviews.llvm.org/D23167 Files: include/llvm/IR/DebugInfoFlags.def include/llvm/IR/DebugInfoMetadata.h include/llvm/Support/Dwarf.h lib/CodeGen/AsmPrinter/DwarfUnit.cpp lib/Support/Dwarf.cpp

Re: [PATCH] D23168: emit_DW_AT_noreturn flag

vleschuk updated this revision to Diff 68329. vleschuk marked an inline comment as done. vleschuk added a comment. Full context https://reviews.llvm.org/D23168 Files: lib/AST/Decl.cpp lib/CodeGen/CGDebugInfo.cpp test/Frontend/dinoreturn.c test/Frontend/dinoreturn.cpp test/Frontend/din

Re: [PATCH] D23167: emit_DW_AT_noreturn flag

vleschuk updated this revision to Diff 68330. vleschuk added a comment. Full context https://reviews.llvm.org/D23167 Files: include/llvm/IR/DebugInfoFlags.def include/llvm/IR/DebugInfoMetadata.h include/llvm/Support/Dwarf.h lib/CodeGen/AsmPrinter/DwarfUnit.cpp lib/Support/Dwarf.cpp

Re: [libcxx] r278904 - Support allocators with explicit conversion constructors. Fixes bug #29000

Marshall, this is maybe a good candidate for merging to release_39? -Dimitry > On 17 Aug 2016, at 07:58, Marshall Clow via cfe-commits > wrote: > > Author: marshall > Date: Wed Aug 17 00:58:40 2016 > New Revision: 278904 > > URL: http://llvm.org/viewvc/llvm-project?rev=278904&view=rev > Log:

Re: [PATCH] D23167: emit_DW_AT_noreturn flag

vleschuk marked 2 inline comments as done. vleschuk added a comment. Replied on doxygen-related comment: I do not think we should use different styles within one file. https://reviews.llvm.org/D23167 ___ cfe-commits mailing list cfe-commits@lists.l

Re: [PATCH] D23168: emit_DW_AT_noreturn flag

vleschuk added a comment. Could somebody take a look at it and commit if no ojections? https://reviews.llvm.org/D23168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23528: [OpenMP] Sema and parsing for 'teams distribute simd' pragma

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D23528 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

Re: [PATCH] D21695: [clang] Version support for UBSan handlers

filcab added a comment. In https://reviews.llvm.org/D21695#514080, @vsk wrote: > Running sanitized programs in production sounds strange to me. But, if there > isn't really a cost to supporting this, I suppose it's fine. It does, and most likely this change wouldn't affect them, as I would gue

[clang-tools-extra] r278922 - [include-fixer] Update -help message.

Author: hokein Date: Wed Aug 17 06:31:19 2016 New Revision: 278922 URL: http://llvm.org/viewvc/llvm-project?rev=278922&view=rev Log: [include-fixer] Update -help message. Modified: clang-tools-extra/trunk/include-fixer/tool/ClangIncludeFixer.cpp Modified: clang-tools-extra/trunk/include-fixe

Re: [PATCH] D23585: [ASTMatchers] Add narrowing matcher: hasExternalFormalLinkage

thegameg added a subscriber: alexfh. thegameg updated this revision to Diff 68332. thegameg added a comment. LibASTMatchersReference.html regenerated using `dump_ast_matchers.py`. https://reviews.llvm.org/D23585 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.

Re: [PATCH] D23585: [ASTMatchers] Add narrowing matcher: hasExternalFormalLinkage

aaron.ballman added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:5490-5497 @@ +5489,10 @@ +/// +/// From clang/Basic/Linkage.h: +/// > UniqueExternalLinkage: +/// > External linkage within a unique namespace. +/// > From the language perspective, these enti

Re: [PATCH] D23585: [ASTMatchers] Add narrowing matcher: hasExternalFormalLinkage

thegameg marked an inline comment as done. thegameg added a comment. https://reviews.llvm.org/D23585 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23585: [ASTMatchers] Add narrowing matcher: hasExternalFormalLinkage

thegameg updated this revision to Diff 68340. thegameg added a comment. Update documentation according to @aarnon.ballman's remarks. https://reviews.llvm.org/D23585 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp unit

Re: [PATCH] D23585: [ASTMatchers] Add narrowing matcher: hasExternalFormalLinkage

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, thank you! https://reviews.llvm.org/D23585 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23585: [ASTMatchers] Add narrowing matcher: hasExternalFormalLinkage

thegameg added a comment. Thank you for the review. I don't have commit access, would you commit this for me, please? Thanks! https://reviews.llvm.org/D23585 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

r278926 - Add an AST matcher for external formal linkage.

Author: aaronballman Date: Wed Aug 17 08:10:42 2016 New Revision: 278926 URL: http://llvm.org/viewvc/llvm-project?rev=278926&view=rev Log: Add an AST matcher for external formal linkage. Patch by Visoiu Mistrih Modified: cfe/trunk/docs/LibASTMatchersReference.html cfe/trunk/include/clang

Re: [PATCH] D23585: [ASTMatchers] Add narrowing matcher: hasExternalFormalLinkage

aaron.ballman added a comment. I've commit in r278926. (I can't close because @alexfh hasn't accepted yet; Alex, can you accept & close?) https://reviews.llvm.org/D23585 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

Re: [PATCH] D23167: emit_DW_AT_noreturn flag

vleschuk added a comment. Could somebody commit this, please? https://reviews.llvm.org/D23167 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r278882 - If possible, set the stack rlimit to at least 8MiB on cc1 startup, and work

On Wed, Aug 17, 2016 at 01:05:08AM -, Richard Smith via cfe-commits wrote: > Author: rsmith > Date: Tue Aug 16 20:05:07 2016 > New Revision: 278882 > > URL: http://llvm.org/viewvc/llvm-project?rev=278882&view=rev > Log: > If possible, set the stack rlimit to at least 8MiB on cc1 startup, and w

Re: [PATCH] D21959: [X86] Add xgetbv xsetbv intrinsics

guyblank added a comment. Sorry about that, forgot that i changed the ms_intrin test. about the failure, I think that xsaveintrin.h is not being included because it requires the xsave feature - which should be on if the target supports it. do you know what in which target the failure occurred? a

Re: [PATCH] D23585: [ASTMatchers] Add narrowing matcher: hasExternalFormalLinkage

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D23585 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D23610: [ARM] Add pre-defined macros for ROPI, RWPI and FPIC

olista01 created this revision. olista01 added reviewers: rengolin, t.p.northover. olista01 added a subscriber: cfe-commits. olista01 set the repository for this revision to rL LLVM. Herald added subscribers: samparker, rengolin, aemerson. This adds pre-defined macros to test for code being compil

Re: [PATCH] D23585: [ASTMatchers] Add narrowing matcher: hasExternalFormalLinkage

alexfh added a comment. In https://reviews.llvm.org/D23585#517942, @aaron.ballman wrote: > I've commit in r278926. (I can't close because @alexfh hasn't accepted yet; > Alex, can you accept & close?) Sure. Done. BTW, Phabricator can close revisions automatically on commit: http://llvm.org/do

Re: [PATCH] D23555: [analyzer] CloneDetector now checks template arguments of function calls.

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM once the @NoQ remarks are addressed. https://reviews.llvm.org/D23555 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

Re: r278882 - If possible, set the stack rlimit to at least 8MiB on cc1 startup, and work

This is the first use of "llvm/Config/config.h" in the clang tree, which breaks out-of-tree builds for me (since llvm's config.h isn't installed). Would using "llvm/Config/llvm-config.h" suffice instead? I'm trying that now... ~Will On Wed, Aug 17, 2016 at 8:36 AM Joerg Sonnenberger via cfe-comm

Re: [PATCH] D23492: Make function local tags visible.

v.g.vassilev removed rL LLVM as the repository for this revision. v.g.vassilev updated this revision to Diff 68349. v.g.vassilev added a comment. Do not instantiate function declarations which are not visible. https://reviews.llvm.org/D23492 Files: include/clang/Sema/Sema.h lib/Sema/SemaTem

Re: r278882 - If possible, set the stack rlimit to at least 8MiB on cc1 startup, and work

(Seems to fix the build here, FWIW. If sounds reasonable can someone commit this? Thanks!) ~Will On Wed, Aug 17, 2016 at 9:39 AM Will Dietz wrote: > This is the first use of "llvm/Config/config.h" in the clang tree, which > breaks out-of-tree builds for me (since llvm's config.h isn't installe

Re: [PATCH] D23204: Visit lambda capture inits from RecursiveASTVisitor::TraverseLambdaCapture().

mboehme updated this revision to Diff 68352. mboehme marked an inline comment as done. mboehme added a comment. Changes in response to reviewer comments https://reviews.llvm.org/D23204 Files: include/clang/AST/RecursiveASTVisitor.h lib/Index/IndexBody.cpp unittests/Tooling/RecursiveASTVis

Re: [PATCH] D23204: Visit lambda capture inits from RecursiveASTVisitor::TraverseLambdaCapture().

mboehme marked 3 inline comments as done. Comment at: unittests/Tooling/RecursiveASTVisitorTestExprVisitor.cpp:239 @@ +238,3 @@ + EXPECT_TRUE(Visitor.runOver( +"void f() { int i; [a = i + 1]{}; }", +DeclRefExprVisitor::Lang_CXX14)); alexfh wrote: > So, C+

Re: [PATCH] D23343: [clang-tidy] modernize-make-{smart_ptr} private ctor bugfix

malcolm.parsons added a subscriber: malcolm.parsons. Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:32-33 @@ -31,1 +31,4 @@ + // Calling make_smart_ptr from within a member function of a type with a + // private or protected constructor would be ill-formed. + auto Can

Re: [PATCH] D23550: [analyzer] Small cleanups when checkers retrieving statements from exploded nodes.

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks for cleaning this up! Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:2628 @@ -2647,3 +2627,3 @@ // FIXME: We will eventually need to handle non-statement-base

Re: [PATCH] D21959: [X86] Add xgetbv xsetbv intrinsics

rnk added a comment. The source isn't that interesting, it includes intrin.h and immintrin.h before using _xgetbv. I think the issue is that Nico added the _MSC_VER check to intrin.h in http://reviews.llvm.org/D20291: #if !defined(_MSC_VER) || __has_feature(modules) || defined(__XSAVE__) #incl

r278933 - Visit lambda capture inits from RecursiveASTVisitor::TraverseLambdaCapture().

Author: mboehme Date: Wed Aug 17 09:59:53 2016 New Revision: 278933 URL: http://llvm.org/viewvc/llvm-project?rev=278933&view=rev Log: Visit lambda capture inits from RecursiveASTVisitor::TraverseLambdaCapture(). Summary: rL277342 made RecursiveASTVisitor visit lambda capture initialization expres

Re: [PATCH] D23204: Visit lambda capture inits from RecursiveASTVisitor::TraverseLambdaCapture().

This revision was automatically updated to reflect the committed changes. mboehme marked an inline comment as done. Closed by commit rL278933: Visit lambda capture inits from RecursiveASTVisitor::TraverseLambdaCapture(). (authored by mboehme). Changed prior to commit: https://reviews.llvm.org/D

Re: [PATCH] D23492: Make function local tags visible.

v.g.vassilev updated this revision to Diff 68354. v.g.vassilev added a comment. Add forgotten change. https://reviews.llvm.org/D23492 Files: include/clang/Sema/Sema.h lib/Sema/SemaTemplate.cpp lib/Sema/SemaTemplateInstantiate.cpp lib/Sema/SemaTemplateInstantiateDecl.cpp test/Modules/I

[clang-tools-extra] r278934 - Adapt to TraverseLambdaCapture interface change from D23204

Author: mboehme Date: Wed Aug 17 10:00:22 2016 New Revision: 278934 URL: http://llvm.org/viewvc/llvm-project?rev=278934&view=rev Log: Adapt to TraverseLambdaCapture interface change from D23204 Summary: Depends on D23204. This is intended to be submitted immediately after D23204 lands. Reviewer

Re: [PATCH] D23543: Adapt to TraverseLambdaCapture interface change from D23204

This revision was automatically updated to reflect the committed changes. Closed by commit rL278934: Adapt to TraverseLambdaCapture interface change from D23204 (authored by mboehme). Changed prior to commit: https://reviews.llvm.org/D23543?vs=68138&id=68358#toc Repository: rL LLVM https://

Re: [PATCH] D16317: [Analyzer] Fix for PR23790: bind real value returned from strcmp when modelling strcmp.

NoQ closed this revision. NoQ added a comment. Committed in r270154 (long time ago). https://reviews.llvm.org/D16317 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Upgrade and fix clang-format-vs

Hello, This patch for clang-format-vs includes the following: - Upgrade to VS 2015, including .NET framework upgrade from 4.0 to 4.5, and upgrading Microsoft.VisualStudio references to v14 versions - Fix build by removing dependency on "Key.snk" file which was never checked in (and not really req

Re: [PATCH] D23361: [OpenCL] AMDGCN: Fix size_t type

yaxunl updated this revision to Diff 68360. yaxunl added a comment. Fix lit test. Use DataLayout::getIntPtrType as Matt suggested. https://reviews.llvm.org/D23361 Files: include/clang/Basic/TargetInfo.h lib/Basic/TargetInfo.cpp lib/Basic/Targets.cpp lib/CodeGen/CGExprScalar.cpp lib/Co

Re: [PATCH] D13126: New static analyzer checker for loss of sign/precision

NoQ accepted this revision. NoQ added a reviewer: NoQ. NoQ added a comment. This revision is now accepted and ready to land. Looks good! Comment at: lib/StaticAnalyzer/Checkers/ConversionChecker.cpp:67 @@ +66,3 @@ + const Stmt *Parent = PM.getParent(Cast); + if (!Parent) +

Re: [PATCH] D23353: [clang-tidy] Add check 'misc-use-after-move'

mboehme updated this revision to Diff 68365. mboehme added a comment. Remove braces around single-line bodies of if statements https://reviews.llvm.org/D23353 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/UseAfterMoveCheck.cpp clang-tidy/misc/U

Re: [PATCH] D23353: [clang-tidy] Add check 'misc-use-after-move'

mboehme updated this revision to Diff 68366. mboehme added a comment. Remove braces around another single-line if statement block https://reviews.llvm.org/D23353 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/UseAfterMoveCheck.cpp clang-tidy/mis

Re: [PATCH] D23353: [clang-tidy] Add check 'misc-use-after-move'

mboehme marked 2 inline comments as done. Comment at: clang-tidy/misc/UseAfterMoveCheck.cpp:659 @@ +658,3 @@ + UseAfterMove Use; + if (finder.find(FunctionBody, MovingCall, MovedVariable, &Use)) { +emitDiagnostic(MovingCall, MovedVariable, Use, this, Result.Context); ---

Re: [PATCH] D21978: [analyzer] Add LocationContext to SymbolMetadata

This revision was automatically updated to reflect the committed changes. Closed by commit rL278937: [analyzer] Add LocationContext information to SymbolMetadata. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D21978?vs=62696&id=68368#toc Repository: rL LLVM http

r278937 - [analyzer] Add LocationContext information to SymbolMetadata.

Author: dergachev Date: Wed Aug 17 10:37:52 2016 New Revision: 278937 URL: http://llvm.org/viewvc/llvm-project?rev=278937&view=rev Log: [analyzer] Add LocationContext information to SymbolMetadata. Like SymbolConjured, SymbolMetadata also needs to be uniquely identified by the moment of its birth

Re: [PATCH] D13126: New static analyzer checker for loss of sign/precision

This revision was automatically updated to reflect the committed changes. Closed by commit rL278941: [analyzer] Add a checker for loss of sign or precision in integral casts. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D13126?vs=67817&id=68372#toc Repository: r

Re: [PATCH] D23167: emit_DW_AT_noreturn flag

aprantl closed this revision. aprantl added a comment. Committed as r278940. Thanks! https://reviews.llvm.org/D23167 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23168: emit_DW_AT_noreturn flag

aprantl added a comment. Note that I moved the test cases to the appropriate CodeGenXYZ directories. https://reviews.llvm.org/D23168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r278941 - [analyzer] Add a checker for loss of sign or precision in integral casts.

Author: dergachev Date: Wed Aug 17 11:02:45 2016 New Revision: 278941 URL: http://llvm.org/viewvc/llvm-project?rev=278941&view=rev Log: [analyzer] Add a checker for loss of sign or precision in integral casts. This new checker tries to find execution paths on which implicit integral casts cause d

r278942 - Debug info: Mark noreturn functions with DIFlagNoReturn.

Author: adrian Date: Wed Aug 17 11:20:32 2016 New Revision: 278942 URL: http://llvm.org/viewvc/llvm-project?rev=278942&view=rev Log: Debug info: Mark noreturn functions with DIFlagNoReturn. This affects functions with the C++11 [[ noreturn ]] and C11 _Noreturn specifiers. Patch by Victor Leschuk

Re: [PATCH] D23168: emit_DW_AT_noreturn flag

aprantl added a comment. Committed as r278942. Thanks! https://reviews.llvm.org/D23168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23343: [clang-tidy] modernize-make-{smart_ptr} private ctor bugfix

alexfh added inline comments. Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:32-33 @@ -31,1 +31,4 @@ + // Calling make_smart_ptr from within a member function of a type with a + // private or protected constructor would be ill-formed. + auto CanCallCtor = unless(has(i

Re: [PATCH] D23343: [clang-tidy] modernize-make-{smart_ptr} private ctor bugfix

Prazek added inline comments. Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:32-33 @@ -31,1 +31,4 @@ + // Calling make_smart_ptr from within a member function of a type with a + // private or protected constructor would be ill-formed. + auto CanCallCtor = unless(has(i

Re: [PATCH] D23343: [clang-tidy] modernize-make-{smart_ptr} private ctor bugfix

Prazek marked 8 inline comments as done. Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:35 @@ +34,3 @@ + auto CanCallCtor = unless(has(ignoringImpCasts(cxxConstructExpr( + hasDeclaration(decl(anyOf(isPrivate(), isProtected(; + alexfh wrote: >

Re: [PATCH] D23343: [clang-tidy] modernize-make-{smart_ptr} private ctor bugfix

Prazek marked 2 inline comments as done. Prazek added a comment. https://reviews.llvm.org/D23343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23343: [clang-tidy] modernize-make-{smart_ptr} private ctor bugfix

alexfh added inline comments. Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:35 @@ +34,3 @@ + auto CanCallCtor = unless(has(ignoringImpCasts(cxxConstructExpr( + hasDeclaration(decl(anyOf(isPrivate(), isProtected(; + Prazek wrote: > alexfh wro

r278946 - Simplify condition. (NFC)

Author: adrian Date: Wed Aug 17 11:42:15 2016 New Revision: 278946 URL: http://llvm.org/viewvc/llvm-project?rev=278946&view=rev Log: Simplify condition. (NFC) Modified: cfe/trunk/lib/AST/Decl.cpp Modified: cfe/trunk/lib/AST/Decl.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST

Re: [PATCH] D23353: [clang-tidy] Add check 'misc-use-after-move'

Prazek added a comment. In https://reviews.llvm.org/D23353#516314, @mboehme wrote: > In https://reviews.llvm.org/D23353#511362, @Prazek wrote: > > > I will review it later, but my first thoughts: > > > > 1. I think we should make some other group, because misc seems to be > > overloaded. I discu

Re: [PATCH] D21675: New ODR checker for modules

dblaikie added inline comments. Comment at: lib/AST/DeclBase.cpp:1810-1812 @@ +1809,5 @@ + void VisitNamedDecl(const NamedDecl *D) { +if (IdentifierInfo *II = D->getIdentifier()) { + ID.AddString(II->getName()); +} +Inherited::VisitNamedDecl(D);

Re: [PATCH] D16989: Change interpretation of function definition in friend declaration of template class.

sepavloff updated this revision to Diff 68376. sepavloff added a comment. Rebased the patch https://reviews.llvm.org/D16989 Files: include/clang/Sema/Sema.h lib/Sema/SemaDecl.cpp test/SemaCXX/PR25848.cpp test/SemaCXX/friend2.cpp Index: test/SemaCXX/friend2.cpp =

Re: [PATCH] D21968: [libcxx] Externally threaded libc++ variant - Take 2

compnerd added a subscriber: compnerd. Comment at: CMakeLists.txt:139 @@ -138,1 +138,3 @@ option(LIBCXX_HAS_PTHREAD_API "Ignore auto-detection and force use of pthread API" OFF) +option(LIBCXX_HAS_EXTERNAL_THREAD_API + "Build libc++ with an externalized threading API. -

Re: [PATCH] D23353: [clang-tidy] Add check 'misc-use-after-move'

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-tidy/misc/UseAfterMoveCheck.cpp:29 @@ +28,3 @@ +/// Provides information about the evaluation order of (sub-)expressions within +/// a CFGBlock. +/// Please

[clang-tools-extra] r278949 - [Include-fixer] Install executables and support scripts

Author: eugenezelenko Date: Wed Aug 17 12:27:56 2016 New Revision: 278949 URL: http://llvm.org/viewvc/llvm-project?rev=278949&view=rev Log: [Include-fixer] Install executables and support scripts Differential revision: https://reviews.llvm.org/D23045 Modified: clang-tools-extra/trunk/include

Re: [PATCH] D23045: [Include-fixer] Install executables and support scripts

This revision was automatically updated to reflect the committed changes. Closed by commit rL278949: [Include-fixer] Install executables and support scripts (authored by eugenezelenko). Changed prior to commit: https://reviews.llvm.org/D23045?vs=66414&id=68384#toc Repository: rL LLVM https:

Re: [PATCH] D23455: [Tooling] Parse compilation database command lines properly on Windows

aaron.ballman added a comment. In https://reviews.llvm.org/D23455#517774, @alexfh wrote: > In https://reviews.llvm.org/D23455#516760, @zturner wrote: > > > In https://reviews.llvm.org/D23455#516753, @alexfh wrote: > > > > > In https://reviews.llvm.org/D23455#515527, @rnk wrote: > > > > > > > In h

Re: [PATCH] D23455: [Tooling] Parse compilation database command lines properly on Windows

rnk added a comment. So, I actually went ahead and generated some MSYS makefiles and made a compile_commands.json, and it doesn't work with clang-tidy. You get this kind of output: [ { "directory": "C:/src/test_proj", "command": "\"/C/Program Files/mingw-w64/x86_64-6.1.0-win32-seh-

Re: [PATCH] D23455: [Tooling] Parse compilation database command lines properly on Windows

zturner added a comment. We could also provide a command line option to clang-tidy that lets the user specify the command line syntax of the compilation database. It could choose a smart default (i.e. what we do in this patch after using `llvm::sys::getProcessTriple()`) but if the command line

r278952 - Module debug info: Fix a bug in handling record decls without fields.

Author: adrian Date: Wed Aug 17 13:27:24 2016 New Revision: 278952 URL: http://llvm.org/viewvc/llvm-project?rev=278952&view=rev Log: Module debug info: Fix a bug in handling record decls without fields. The previous condition would erroneously mark all CXXRecordDecls that didn't have any fields a

Re: [PATCH] D23596: [Documentation] Remove duplicated checks groups descriptions form clang-tidy/index.rst

Eugene.Zelenko added a reviewer: aaron.ballman. Eugene.Zelenko updated this revision to Diff 68390. Eugene.Zelenko added a comment. Rephrase text and add link to Clang-tidy directory. Will be good idea is native English speaker will look on this change. Repository: rL LLVM https://reviews.ll

[PATCH] D23618: [LibTooling] Allow compilation database to explicitly specify compilation database file and source root

zturner created this revision. zturner added reviewers: djasper, alexfh, klimek. zturner added a subscriber: cfe-commits. Herald added a subscriber: klimek. Allow explicit specification of a compilation database file and source root. While trying to create a compilation database test for D23455,

Re: [PATCH] D23455: [Tooling] Parse compilation database command lines properly on Windows

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D23455#518312, @rnk wrote: > So, I actually went ahead and generated some MSYS makefiles and made a > compile_commands.json, and it doesn't work with clang-tidy. Yo

Re: [PATCH] D23455: [Tooling] Parse compilation database command lines properly on Windows

alexfh added a comment. In https://reviews.llvm.org/D23455#518317, @zturner wrote: > We could also provide a command line option to clang-tidy that lets the user > specify the command line syntax of the compilation database. It could choose > a smart default (i.e. what we do in this patch afte

Re: [PATCH] D23618: [LibTooling] Allow compilation database to explicitly specify compilation database file and source root

alexfh added a comment. Full context diffs, please (http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface). https://reviews.llvm.org/D23618 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

Re: [PATCH] D23610: [ARM] Add pre-defined macros for ROPI, RWPI and FPIC

t.p.northover added inline comments. Comment at: lib/Basic/Targets.cpp:5316 @@ +5315,3 @@ +if (Opts.PICLevel) + Builder.defineMacro("__APCS_FPIC", "1"); +if (Opts.ROPI) These names are pretty bad from a modern perspective (with APCS deprecated and al

Re: [PATCH] D23618: [LibTooling] Allow compilation database to explicitly specify compilation database file and source root

Strange, I thought i did. Will re upload On Wed, Aug 17, 2016 at 12:14 PM Alexander Kornienko wrote: > alexfh added a comment. > > Full context diffs, please ( > http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface > ). > > > https://reviews.llvm.org/D23618 > > > >

r278956 - [CodeGen][ObjC] Fix infinite recursion in getObjCEncodingForTypeImpl.

Author: ahatanak Date: Wed Aug 17 14:42:22 2016 New Revision: 278956 URL: http://llvm.org/viewvc/llvm-project?rev=278956&view=rev Log: [CodeGen][ObjC] Fix infinite recursion in getObjCEncodingForTypeImpl. Check that ExpandStructures is true before visiting the list of ivars. rdar://problem/27135

Re: [PATCH] D22929: [CodeGen][ObjC] Fix infinite recursion in getObjCEncodingForTypeImpl

This revision was automatically updated to reflect the committed changes. Closed by commit rL278956: [CodeGen][ObjC] Fix infinite recursion in getObjCEncodingForTypeImpl. (authored by ahatanak). Changed prior to commit: https://reviews.llvm.org/D22929?vs=65969&id=68400#toc Repository: rL LLV

Re: [PATCH] D23618: [LibTooling] Allow compilation database to explicitly specify compilation database file and source root

zturner updated this revision to Diff 68404. zturner added a comment. Added full context diff. https://reviews.llvm.org/D23618 Files: include/clang/Tooling/CompilationDatabase.h include/clang/Tooling/JSONCompilationDatabase.h lib/Tooling/CommonOptionsParser.cpp lib/Tooling/CompilationDa

[libclc] r278962 - Implement vstore_half{,n}

Author: jvesely Date: Wed Aug 17 15:02:11 2016 New Revision: 278962 URL: http://llvm.org/viewvc/llvm-project?rev=278962&view=rev Log: Implement vstore_half{,n} Signed-off-by: Jan Vesely Added: libclc/trunk/generic/lib/shared/vstore_half.inc Modified: libclc/trunk/generic/include/clc/sha

r278963 - [GraphWriter] Change GraphWriter to use NodeRef in GraphTraits

Author: timshen Date: Wed Aug 17 15:02:38 2016 New Revision: 278963 URL: http://llvm.org/viewvc/llvm-project?rev=278963&view=rev Log: [GraphWriter] Change GraphWriter to use NodeRef in GraphTraits Summary: Corresponding LLVM patch: D23580 Reviewers: dblaikie Subscribers: cfe-commits Differenti

Re: [PATCH] D23581: [GraphWriter] Change GraphWriter to use NodeRef in GraphTraits

This revision was automatically updated to reflect the committed changes. Closed by commit rL278963: [GraphWriter] Change GraphWriter to use NodeRef in GraphTraits (authored by timshen). Changed prior to commit: https://reviews.llvm.org/D23581?vs=68258&id=68406#toc Repository: rL LLVM https

  1   2   >