r279035 - [Driver] Use llvm-config.h, not config.h to unbreak out-of-tree builds

Author: vedantk Date: Thu Aug 18 01:43:07 2016 New Revision: 279035 URL: http://llvm.org/viewvc/llvm-project?rev=279035&view=rev Log: [Driver] Use llvm-config.h, not config.h to unbreak out-of-tree builds llvm/Config/config.h has intentionally been excluded from llvm installations (see: llvm/CMak

Re: r278882 - If possible, set the stack rlimit to at least 8MiB on cc1 startup, and work

Done in clang/r279035. thanks, vedant > On Aug 17, 2016, at 7:43 AM, Will Dietz via cfe-commits > wrote: > > (Seems to fix the build here, FWIW. If sounds reasonable can someone commit > this? Thanks!) > > ~Will > > On Wed, Aug 17, 2016 at 9:39 AM Will Dietz wrote: > This is the first use

Re: [PATCH] D23602: Port tools/clang-format/git-clang-format to work Python beyond 2.7

vsk added a subscriber: vsk. Comment at: tools/clang-format/git-clang-format:303 @@ -300,3 +302,3 @@ allowed_extensions = frozenset(allowed_extensions) - for filename in dictionary.keys(): + for filename in list(dictionary.keys()): base_ext = filename.rsplit('.', 1)

r279034 - Remove debugging aids from this test and fix its expectations.

Author: rsmith Date: Thu Aug 18 01:15:19 2016 New Revision: 279034 URL: http://llvm.org/viewvc/llvm-project?rev=279034&view=rev Log: Remove debugging aids from this test and fix its expectations. Modified: cfe/trunk/test/Modules/pr28438.cpp Modified: cfe/trunk/test/Modules/pr28438.cpp URL:

[Ping] StaticAnalyzer: Fix GCC 6 indention warning in ArrayBoundCheckerV2.cpp

Hi! I know my patch is of minor importantance. Could still somebody be so kind to review and maybe to apply it to trunk? Thanks Christoph Am 16.08.2016 um 15:41 schrieb Christoph Grüninger via cfe-commits: > Dear Clang developers, > please find attached a tiny patch which fixes a indentation war

[PATCH] D23643: [Driver] Report invalid -mtune/-mcpu parameters when -arch=arm64

vsk created this revision. vsk added reviewers: t.p.northover, rengolin. vsk added a subscriber: cfe-commits. Herald added subscribers: samparker, rengolin, aemerson. Fix a crash-on-invalid in which -mtune/-mcpu are set to nonsense values while -arch=arm64. This patch extends an arm cortex test

r279028 - [sanitizer-coverag] update the docs in __sanitizer_cov_trace_cmp

Author: kcc Date: Wed Aug 17 20:26:36 2016 New Revision: 279028 URL: http://llvm.org/viewvc/llvm-project?rev=279028&view=rev Log: [sanitizer-coverag] update the docs in __sanitizer_cov_trace_cmp Modified: cfe/trunk/docs/SanitizerCoverage.rst Modified: cfe/trunk/docs/SanitizerCoverage.rst URL

r279024 - PR28438: Update the information on an identifier with local definitions before

Author: rsmith Date: Wed Aug 17 20:16:55 2016 New Revision: 279024 URL: http://llvm.org/viewvc/llvm-project?rev=279024&view=rev Log: PR28438: Update the information on an identifier with local definitions before trying to write out its macro graph, in case we imported a module that added another m

Re: [libcxx] r279008 - make the associative containers do the right thing for propogate_on_container_assignment. Fixes bug #29001. Tests are only for right now - more complete tests will come wh

On Wed, Aug 17, 2016 at 4:24 PM, Marshall Clow via cfe-commits wrote: > Author: marshall > Date: Wed Aug 17 18:24:02 2016 > New Revision: 279008 > > URL: http://llvm.org/viewvc/llvm-project?rev=279008&view=rev > Log: > make the associative containers do the right thing for > propogate_on_containe

Re: Please take r279008 for the release

On Wed, Aug 17, 2016 at 5:27 PM, Marshall Clow wrote: > Unlike the #278904, this does fix a bug - and a non-trivial one at that. Thanks! I've merged it in r279017. ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

[libcxx] r279017 - Merging r279008:

Author: hans Date: Wed Aug 17 19:23:33 2016 New Revision: 279017 URL: http://llvm.org/viewvc/llvm-project?rev=279017&view=rev Log: Merging r279008: r279008 | marshall | 2016-08-17 16:24:02 -0700 (Wed, 17 Aug 2016) | 1 line m

[libcxx] r279015 - Merging r278904:

Author: hans Date: Wed Aug 17 19:20:59 2016 New Revision: 279015 URL: http://llvm.org/viewvc/llvm-project?rev=279015&view=rev Log: Merging r278904: r278904 | marshall | 2016-08-16 22:58:40 -0700 (Tue, 16 Aug 2016) | 1 line S

Re: [libcxx] r278904 - Support allocators with explicit conversion constructors. Fixes bug #29000

On Wed, Aug 17, 2016 at 5:25 PM, Marshall Clow wrote: > On Wed, Aug 17, 2016 at 3:14 PM, Hans Wennborg wrote: >> >> I'd rather not take this actually, as it looks like a large change, >> isn't fixing a regression, and it's time to start wrapping up the >> release. >> > This is actually a pretty s

Please take r279008 for the release

Unlike the #278904, this does fix a bug - and a non-trivial one at that. -- Marshall ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [libcxx] r278904 - Support allocators with explicit conversion constructors. Fixes bug #29000

On Wed, Aug 17, 2016 at 3:14 PM, Hans Wennborg wrote: > I'd rather not take this actually, as it looks like a large change, > isn't fixing a regression, and it's time to start wrapping up the > release. > > This is actually a pretty small change - almost all the changes are in the tests. I'd lik

Re: [PATCH] D23125: Modules: add command line option to support loading prebuilt modules on demand, without parsing any module map

manmanren added inline comments. Comment at: lib/Frontend/CompilerInstance.cpp:1503 @@ +1502,3 @@ +if (!Module || !Module->getASTFile() || +std::string(Module->getASTFile()->getName()) != ModuleFileName) { + // Error out if Module does not refer to the

Re: [PATCH] D23627: [CUDA] Improve handling of math functions.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM, but we may want someone familiar with math library to take a look. Comment at: clang/lib/Headers/__clang_cuda_cmath.h:125-133 @@ -122,8 +124,11 @@ __DEVICE__ float modf(float

Re: [PATCH] D23125: Modules: add command line option to support loading prebuilt modules on demand, without parsing any module map

rsmith added inline comments. Comment at: lib/Frontend/CompilerInstance.cpp:1503 @@ +1502,3 @@ +if (!Module || !Module->getASTFile() || +std::string(Module->getASTFile()->getName()) != ModuleFileName) { + // Error out if Module does not refer to the fi

Re: [PATCH] D23125: Modules: add command line option to support loading prebuilt modules on demand, without parsing any module map

manmanren added a comment. Cheers, Manman Comment at: lib/Frontend/CompilerInstance.cpp:1502 @@ +1501,3 @@ +Module = PP->getHeaderSearchInfo().lookupModule(ModuleName); +if (!Module || !Module->getASTFile() || +std::string(Module->getASTFile()->getNa

Re: [PATCH] D23125: Modules: add command line option to support loading prebuilt modules on demand, without parsing any module map

manmanren updated this revision to Diff 68456. https://reviews.llvm.org/D23125 Files: docs/Modules.rst include/clang/Basic/DiagnosticCommonKinds.td include/clang/Driver/Options.td include/clang/Lex/HeaderSearch.h include/clang/Lex/HeaderSearchOptions.h include/clang/Serialization/Modu

[clang-tools-extra] r279009 - [Release notes] Mention Emacs integration in Include-fixer.

Author: eugenezelenko Date: Wed Aug 17 18:36:22 2016 New Revision: 279009 URL: http://llvm.org/viewvc/llvm-project?rev=279009&view=rev Log: [Release notes] Mention Emacs integration in Include-fixer. Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified: clang-tools-extra/trunk/do

[libcxx] r279008 - make the associative containers do the right thing for propogate_on_container_assignment. Fixes bug #29001. Tests are only for right now - more complete tests will come when w

Author: marshall Date: Wed Aug 17 18:24:02 2016 New Revision: 279008 URL: http://llvm.org/viewvc/llvm-project?rev=279008&view=rev Log: make the associative containers do the right thing for propogate_on_container_assignment. Fixes bug #29001. Tests are only for right now - more complete tests w

Re: [PATCH] D23596: [Documentation] Remove duplicated checks groups descriptions form clang-tidy/index.rst

This revision was automatically updated to reflect the committed changes. Closed by commit rL279006: [Documentation] Remove duplicated checks groups descriptions from clang… (authored by eugenezelenko). Changed prior to commit: https://reviews.llvm.org/D23596?vs=68447&id=68449#toc Repository:

[clang-tools-extra] r279006 - [Documentation] Remove duplicated checks groups descriptions from clang-tidy/index.rst.

Author: eugenezelenko Date: Wed Aug 17 18:20:00 2016 New Revision: 279006 URL: http://llvm.org/viewvc/llvm-project?rev=279006&view=rev Log: [Documentation] Remove duplicated checks groups descriptions from clang-tidy/index.rst. Differential revision: https://reviews.llvm.org/D23596 Modified:

Re: [PATCH] D23627: [CUDA] Improve handling of math functions.

jlebar added inline comments. Comment at: clang/lib/Headers/__clang_cuda_cmath.h:125-133 @@ -122,8 +124,11 @@ __DEVICE__ float modf(float __x, float *__iptr) { return ::modff(__x, __iptr); } -__DEVICE__ float nexttoward(float __from, float __to) { +__DEVICE__ float nexttoward(fl

Re: [PATCH] D23125: Modules: add command line option to support loading prebuilt modules on demand, without parsing any module map

rsmith added inline comments. Comment at: lib/Frontend/CompilerInstance.cpp:1502 @@ +1501,3 @@ +Module = PP->getHeaderSearchInfo().lookupModule(ModuleName); +if (!Module) { + getDiagnostics().Report(ModuleNameLoc, diag::err_module_prebuilt) ---

Re: [PATCH] D23596: [Documentation] Remove duplicated checks groups descriptions form clang-tidy/index.rst

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Thanks! Repository: rL LLVM https://reviews.llvm.org/D23596 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

r279004 - Support object-file-wrapped modules in clang -module-file-info.

Author: adrian Date: Wed Aug 17 18:13:53 2016 New Revision: 279004 URL: http://llvm.org/viewvc/llvm-project?rev=279004&view=rev Log: Support object-file-wrapped modules in clang -module-file-info. rdar://problem/24504815 Modified: cfe/trunk/include/clang/Frontend/FrontendActions.h cfe/tr

r279005 - Print the module format in clang -module-file-info.

Author: adrian Date: Wed Aug 17 18:14:00 2016 New Revision: 279005 URL: http://llvm.org/viewvc/llvm-project?rev=279005&view=rev Log: Print the module format in clang -module-file-info. Modified: cfe/trunk/lib/Frontend/FrontendActions.cpp cfe/trunk/test/Modules/module_file_info.m Modified

Re: [PATCH] D23596: [Documentation] Remove duplicated checks groups descriptions form clang-tidy/index.rst

Eugene.Zelenko marked an inline comment as done. Eugene.Zelenko added a comment. Repository: rL LLVM https://reviews.llvm.org/D23596 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23596: [Documentation] Remove duplicated checks groups descriptions form clang-tidy/index.rst

Eugene.Zelenko updated this revision to Diff 68447. Eugene.Zelenko added a comment. Address Alexander's comments. Repository: rL LLVM https://reviews.llvm.org/D23596 Files: docs/clang-tidy/index.rst Index: docs/clang-tidy/index.rst =

Re: [PATCH] D23596: [Documentation] Remove duplicated checks groups descriptions form clang-tidy/index.rst

Eugene.Zelenko marked 3 inline comments as done. Eugene.Zelenko added a comment. Repository: rL LLVM https://reviews.llvm.org/D23596 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23125: Modules: add command line option to support loading prebuilt modules on demand, without parsing any module map

manmanren added a comment. Thanks, Manman Comment at: lib/Frontend/CompilerInstance.cpp:1502 @@ +1501,3 @@ +Module = PP->getHeaderSearchInfo().lookupModule(ModuleName); +if (!Module) { + getDiagnostics().Report(ModuleNameLoc, diag::err_module_prebuilt)

Re: [PATCH] D23125: Modules: add command line option to support loading prebuilt modules on demand, without parsing any module map

manmanren updated this revision to Diff 68442. https://reviews.llvm.org/D23125 Files: docs/Modules.rst include/clang/Basic/DiagnosticCommonKinds.td include/clang/Driver/Options.td include/clang/Lex/HeaderSearch.h include/clang/Lex/HeaderSearchOptions.h include/clang/Serialization/Modu

Re: [PATCH] D23493: Fix PR28366: Teach the const-expression evaluator to be more fault tolerant with non-const enclosing local variables, or otherwise fold them if const.

rsmith added inline comments. Comment at: lib/AST/ExprConstant.cpp:4795-4797 @@ +4794,5 @@ + if (VD->hasLocalStorage() && Info.CurrentCall->Index > 1) { +// Only if the DeclContext of VD is the same as the called function do we +// set the Frame to the Current CallStackFr

Re: [clang-tools-extra] r278949 - [Include-fixer] Install executables and support scripts

On Wed, Aug 17, 2016 at 10:27 AM, Eugene Zelenko via cfe-commits wrote: > Author: eugenezelenko > Date: Wed Aug 17 12:27:56 2016 > New Revision: 278949 > > URL: http://llvm.org/viewvc/llvm-project?rev=278949&view=rev > Log: > [Include-fixer] Install executables and support scripts > > Differential

Re: [PATCH] D23596: [Documentation] Remove duplicated checks groups descriptions form clang-tidy/index.rst

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: docs/clang-tidy/index.rst:343 @@ +342,3 @@ +are located in subdirectories of +``clang-tidy/ ``_. +

Re: [PATCH] D23627: [CUDA] Improve handling of math functions.

tra added inline comments. Comment at: clang/lib/Headers/__clang_cuda_cmath.h:125-133 @@ -122,8 +124,11 @@ __DEVICE__ float modf(float __x, float *__iptr) { return ::modff(__x, __iptr); } -__DEVICE__ float nexttoward(float __from, float __to) { +__DEVICE__ float nexttoward(float

Re: [libcxx] r278904 - Support allocators with explicit conversion constructors. Fixes bug #29000

I'd rather not take this actually, as it looks like a large change, isn't fixing a regression, and it's time to start wrapping up the release. On Wed, Aug 17, 2016 at 3:46 AM, Dimitry Andric wrote: > Marshall, this is maybe a good candidate for merging to release_39? > > -Dimitry > >> On 17 Aug 2

Re: Nomination for 3.9: r278786 - Left shifts of negative values are defined if -fwrapv is set

r278989. Thanks, Hans On Tue, Aug 16, 2016 at 6:46 PM, Richard Smith wrote: > Looks fine to me. (At one point we were deliberately not following GCC in > making -fwrapv affect left shift, because it's a bit operation rather than > an arithmetic one, but this is ultimately supposed to be a GCC-co

Re: [PATCH] D23531: [Darwin] Stop linking libclang_rt.eprintf.a

This revision was automatically updated to reflect the committed changes. Closed by commit rL278988: [Darwin] Stop linking libclang_rt.eprintf.a (authored by cbieneman). Changed prior to commit: https://reviews.llvm.org/D23531?vs=68102&id=68429#toc Repository: rL LLVM https://reviews.llvm.o

r278988 - [Darwin] Stop linking libclang_rt.eprintf.a

Author: cbieneman Date: Wed Aug 17 16:54:30 2016 New Revision: 278988 URL: http://llvm.org/viewvc/llvm-project?rev=278988&view=rev Log: [Darwin] Stop linking libclang_rt.eprintf.a Summary: The eprintf library was added before the general OS X builtins library existed as a place to store one buil

Re: [PATCH] D23125: Modules: add command line option to support loading prebuilt modules on demand, without parsing any module map

rsmith added a comment. Just a couple of things, but this basically LGTM. Comment at: docs/Modules.rst:217 @@ +216,3 @@ +``-fprebuilt-module-path=`` + Specify the path to the prebuilt modules. If specified, we will look for modules in this directory for a given top-level modul

r278987 - [CMake] Adding toolchain targets to PGO and Apple CMake caches

Author: cbieneman Date: Wed Aug 17 16:51:38 2016 New Revision: 278987 URL: http://llvm.org/viewvc/llvm-project?rev=278987&view=rev Log: [CMake] Adding toolchain targets to PGO and Apple CMake caches The Xcode toolchain targets are useful on OS X hosts because you can construct and install multip

r278984 - Add test missed from r278983.

Author: rsmith Date: Wed Aug 17 16:42:10 2016 New Revision: 278984 URL: http://llvm.org/viewvc/llvm-project?rev=278984&view=rev Log: Add test missed from r278983. Added: cfe/trunk/test/SemaTemplate/instantiation-depth-default.cpp Added: cfe/trunk/test/SemaTemplate/instantiation-depth-default

r278983 - PR18417: Increase -ftemplate-depth to the value 1024 recommended by the C++

Author: rsmith Date: Wed Aug 17 16:41:45 2016 New Revision: 278983 URL: http://llvm.org/viewvc/llvm-project?rev=278983&view=rev Log: PR18417: Increase -ftemplate-depth to the value 1024 recommended by the C++ standard's Annex B. We now attempt to increase the process's stack rlimit to 8MiB on star

[PATCH] D23628: Fix unittests after windows command line parsing

zturner created this revision. zturner added a reviewer: alexfh. zturner added a subscriber: cfe-commits. Herald added a subscriber: klimek. After submitting the windows command line parsing patch, it broke all the command line parsing unittests, because now they were trying parse gnu command li

[PATCH] D23627: [CUDA] Improve handling of math functions.

jlebar created this revision. jlebar added a reviewer: tra. jlebar added a subscriber: cfe-commits. A bunch of related changes here to our CUDA math headers. - The second arg to nexttoward is a double (well, technically, long double, but we don't have that), not a float. - Add a forward-declar

Re: [PATCH] D20132: [libclang] Add clang_getAllSkippedRanges function

rsmith accepted this revision. This revision is now accepted and ready to land. Comment at: unittests/libclang/LibclangTest.cpp:16-20 @@ -15,4 +15,7 @@ #include "gtest/gtest.h" #include #include +#include +#include +#include #define DEBUG_TYPE "libclang-test"

Re: [PATCH] D23314: [analyzer] CloneDetector allows comparing clones for suspicious variable pattern errors.

teemperor updated this revision to Diff 68422. teemperor marked 11 inline comments as done. teemperor added a comment. - Made warning messages more 'clangish' as pointed out by Vassil (Thanks!) - Improved the class/variable names as pointed out by Artem (Thanks a lot!) - CloneChecker's functions a

Re: [PATCH] D23314: [analyzer] CloneDetector allows comparing clones for suspicious variable pattern errors.

teemperor added inline comments. Comment at: test/Analysis/copypaste/suspicious-clones.cpp:11 @@ +10,3 @@ +return a; + return b; // expected-note{{Suggestion is based on the useage of this variable in a similar piece of code.}} +} v.g.vassilev wrote: > This

Re: [PATCH] D23595: [Clang] Fix some Clang-tidy modernize-use-using and Include What You Use warnings

Eugene.Zelenko marked an inline comment as done. Comment at: include/clang/Basic/IdentifierTable.h:103 @@ -95,1 +102,3 @@ +return getLength() == StrLen-1 && + memcmp(getNameStart(), Str, StrLen-1) == 0; } memcpy result is three state, so applying

Re: [PATCH] D23492: Make function local tags visible.

rsmith added inline comments. Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:3608-3609 @@ -3600,1 +3607,4 @@ + + // TODO: Check if we could sink these diagnostics in + // DiagnoseUninstantiableTemplate. if (!Pattern && !PatternDecl->isDefaulted()) { If

Re: [PATCH] D23595: [Clang] Fix some Clang-tidy modernize-use-using and Include What You Use warnings

Eugene.Zelenko updated this revision to Diff 68423. Eugene.Zelenko added a comment. Apply Clang-format. Repository: rL LLVM https://reviews.llvm.org/D23595 Files: include/clang/AST/RecursiveASTVisitor.h include/clang/Basic/IdentifierTable.h include/clang/Frontend/ASTUnit.h include/cl

Re: [PATCH] D23492: Make function local tags visible.

rsmith added inline comments. Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:3597-3599 @@ -3595,4 +3596,5 @@ // FIXME: Check that the definition is visible before trying to instantiate // it. This requires us to track the instantiation stack in order to know // wh

[clang-tools-extra] r278979 - Revert "Add a test for clang-tidy using the clang-cl driver."

Author: zturner Date: Wed Aug 17 16:01:13 2016 New Revision: 278979 URL: http://llvm.org/viewvc/llvm-project?rev=278979&view=rev Log: Revert "Add a test for clang-tidy using the clang-cl driver." This reverts commit fd1908ce445eba4544d64cc68b3c03249e4bf614. This should be the correct CL to rever

[clang-tools-extra] r278978 - Revert "Revert "[Include-fixer] Install executables and support scripts""

Author: zturner Date: Wed Aug 17 15:58:14 2016 New Revision: 278978 URL: http://llvm.org/viewvc/llvm-project?rev=278978&view=rev Log: Revert "Revert "[Include-fixer] Install executables and support scripts"" This reverts commit 2aff596257e1c45fa54baae823ecbe61a785174e. I'm having a bad day appar

[clang-tools-extra] r278977 - Revert "[Include-fixer] Install executables and support scripts"

Author: zturner Date: Wed Aug 17 15:56:47 2016 New Revision: 278977 URL: http://llvm.org/viewvc/llvm-project?rev=278977&view=rev Log: Revert "[Include-fixer] Install executables and support scripts" This reverts commit b725a314a9b7f746c37f70909ec3c4dcb6d9f6b5. The patch that made this test work

r278976 - Revert "[Tooling] Parse compilation database command lines on Windows."

Author: zturner Date: Wed Aug 17 15:55:35 2016 New Revision: 278976 URL: http://llvm.org/viewvc/llvm-project?rev=278976&view=rev Log: Revert "[Tooling] Parse compilation database command lines on Windows." This reverts commit 27a874790fc79f6391ad3703d7c790f51ac6ae1f. After the introduction of wi

Re: [PATCH] D23524: [libc++abi] Fix backtrace_test.pass.cpp failure seemingly caused by inlining differences.

danalbert added a comment. Maybe `__attribute__((noinline))` every function instead? https://reviews.llvm.org/D23524 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22766: Handle -mlong-calls on Hexagon

kparzysz updated this revision to Diff 68416. kparzysz added a comment. Moving mno_long_calls to m_Group as well. I'm hoping this is all that's needed: what I understand as "custom handling" is still needed, since this option is only valid for ARM and Hexagon. The Hexagon way of handling targe

Re: [PATCH] D23573: [OpenCL] AMDGPU: add support of cl_khr_subgroups

This revision was automatically updated to reflect the committed changes. Closed by commit rL278972: [OpenCL] AMDGPU: add support of cl_khr_subgroups (authored by yaxunl). Changed prior to commit: https://reviews.llvm.org/D23573?vs=68227&id=68418#toc Repository: rL LLVM https://reviews.llvm

r278972 - [OpenCL] AMDGPU: add support of cl_khr_subgroups

Author: yaxunl Date: Wed Aug 17 15:39:49 2016 New Revision: 278972 URL: http://llvm.org/viewvc/llvm-project?rev=278972&view=rev Log: [OpenCL] AMDGPU: add support of cl_khr_subgroups Patch by Aaron En Ye Shi. Differential Revision: https://reviews.llvm.org/D23573 Modified: cfe/trunk/lib/Basi

[clang-tools-extra] r278968 - Add a test for clang-tidy using the clang-cl driver.

Author: zturner Date: Wed Aug 17 15:14:10 2016 New Revision: 278968 URL: http://llvm.org/viewvc/llvm-project?rev=278968&view=rev Log: Add a test for clang-tidy using the clang-cl driver. Reviewed By: alexfh Differential Revision: https://reviews.llvm.org/D23480 Added: clang-tools-extra/trunk

Re: [PATCH] D23480: Add a test for clang-tidy using the clang cl driver

This revision was automatically updated to reflect the committed changes. Closed by commit rL278968: Add a test for clang-tidy using the clang-cl driver. (authored by zturner). Changed prior to commit: https://reviews.llvm.org/D23480?vs=67948&id=68413#toc Repository: rL LLVM https://reviews

Re: [PATCH] D21724: [RFC] Enhance synchscope representation (clang)

kzhuravl abandoned this revision. kzhuravl added a comment. This patch is not required at this point since we left SynchronizationScope enum intact and did not rename existing members https://reviews.llvm.org/D21724 ___ cfe-commits mailing list cfe

r278964 - [Tooling] Parse compilation database command lines on Windows.

Author: zturner Date: Wed Aug 17 15:04:35 2016 New Revision: 278964 URL: http://llvm.org/viewvc/llvm-project?rev=278964&view=rev Log: [Tooling] Parse compilation database command lines on Windows. When a compilation database is used on Windows, the command lines cannot be parsed using the standar

Re: [PATCH] D23455: [Tooling] Parse compilation database command lines properly on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rL278964: [Tooling] Parse compilation database command lines on Windows. (authored by zturner). Changed prior to commit: https://reviews.llvm.org/D23455?vs=67947&id=68407#toc Repository: rL LLVM https

Re: [PATCH] D23581: [GraphWriter] Change GraphWriter to use NodeRef in GraphTraits

This revision was automatically updated to reflect the committed changes. Closed by commit rL278963: [GraphWriter] Change GraphWriter to use NodeRef in GraphTraits (authored by timshen). Changed prior to commit: https://reviews.llvm.org/D23581?vs=68258&id=68406#toc Repository: rL LLVM https

r278963 - [GraphWriter] Change GraphWriter to use NodeRef in GraphTraits

Author: timshen Date: Wed Aug 17 15:02:38 2016 New Revision: 278963 URL: http://llvm.org/viewvc/llvm-project?rev=278963&view=rev Log: [GraphWriter] Change GraphWriter to use NodeRef in GraphTraits Summary: Corresponding LLVM patch: D23580 Reviewers: dblaikie Subscribers: cfe-commits Differenti

[libclc] r278962 - Implement vstore_half{,n}

Author: jvesely Date: Wed Aug 17 15:02:11 2016 New Revision: 278962 URL: http://llvm.org/viewvc/llvm-project?rev=278962&view=rev Log: Implement vstore_half{,n} Signed-off-by: Jan Vesely Added: libclc/trunk/generic/lib/shared/vstore_half.inc Modified: libclc/trunk/generic/include/clc/sha

Re: [PATCH] D23618: [LibTooling] Allow compilation database to explicitly specify compilation database file and source root

zturner updated this revision to Diff 68404. zturner added a comment. Added full context diff. https://reviews.llvm.org/D23618 Files: include/clang/Tooling/CompilationDatabase.h include/clang/Tooling/JSONCompilationDatabase.h lib/Tooling/CommonOptionsParser.cpp lib/Tooling/CompilationDa

Re: [PATCH] D22929: [CodeGen][ObjC] Fix infinite recursion in getObjCEncodingForTypeImpl

This revision was automatically updated to reflect the committed changes. Closed by commit rL278956: [CodeGen][ObjC] Fix infinite recursion in getObjCEncodingForTypeImpl. (authored by ahatanak). Changed prior to commit: https://reviews.llvm.org/D22929?vs=65969&id=68400#toc Repository: rL LLV

r278956 - [CodeGen][ObjC] Fix infinite recursion in getObjCEncodingForTypeImpl.

Author: ahatanak Date: Wed Aug 17 14:42:22 2016 New Revision: 278956 URL: http://llvm.org/viewvc/llvm-project?rev=278956&view=rev Log: [CodeGen][ObjC] Fix infinite recursion in getObjCEncodingForTypeImpl. Check that ExpandStructures is true before visiting the list of ivars. rdar://problem/27135

Re: [PATCH] D23618: [LibTooling] Allow compilation database to explicitly specify compilation database file and source root

Strange, I thought i did. Will re upload On Wed, Aug 17, 2016 at 12:14 PM Alexander Kornienko wrote: > alexfh added a comment. > > Full context diffs, please ( > http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface > ). > > > https://reviews.llvm.org/D23618 > > > >

Re: [PATCH] D23610: [ARM] Add pre-defined macros for ROPI, RWPI and FPIC

t.p.northover added inline comments. Comment at: lib/Basic/Targets.cpp:5316 @@ +5315,3 @@ +if (Opts.PICLevel) + Builder.defineMacro("__APCS_FPIC", "1"); +if (Opts.ROPI) These names are pretty bad from a modern perspective (with APCS deprecated and al

Re: [PATCH] D23618: [LibTooling] Allow compilation database to explicitly specify compilation database file and source root

alexfh added a comment. Full context diffs, please (http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface). https://reviews.llvm.org/D23618 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

Re: [PATCH] D23455: [Tooling] Parse compilation database command lines properly on Windows

alexfh added a comment. In https://reviews.llvm.org/D23455#518317, @zturner wrote: > We could also provide a command line option to clang-tidy that lets the user > specify the command line syntax of the compilation database. It could choose > a smart default (i.e. what we do in this patch afte

Re: [PATCH] D23455: [Tooling] Parse compilation database command lines properly on Windows

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D23455#518312, @rnk wrote: > So, I actually went ahead and generated some MSYS makefiles and made a > compile_commands.json, and it doesn't work with clang-tidy. Yo

[PATCH] D23618: [LibTooling] Allow compilation database to explicitly specify compilation database file and source root

zturner created this revision. zturner added reviewers: djasper, alexfh, klimek. zturner added a subscriber: cfe-commits. Herald added a subscriber: klimek. Allow explicit specification of a compilation database file and source root. While trying to create a compilation database test for D23455,

Re: [PATCH] D23596: [Documentation] Remove duplicated checks groups descriptions form clang-tidy/index.rst

Eugene.Zelenko added a reviewer: aaron.ballman. Eugene.Zelenko updated this revision to Diff 68390. Eugene.Zelenko added a comment. Rephrase text and add link to Clang-tidy directory. Will be good idea is native English speaker will look on this change. Repository: rL LLVM https://reviews.ll

r278952 - Module debug info: Fix a bug in handling record decls without fields.

Author: adrian Date: Wed Aug 17 13:27:24 2016 New Revision: 278952 URL: http://llvm.org/viewvc/llvm-project?rev=278952&view=rev Log: Module debug info: Fix a bug in handling record decls without fields. The previous condition would erroneously mark all CXXRecordDecls that didn't have any fields a

Re: [PATCH] D23455: [Tooling] Parse compilation database command lines properly on Windows

zturner added a comment. We could also provide a command line option to clang-tidy that lets the user specify the command line syntax of the compilation database. It could choose a smart default (i.e. what we do in this patch after using `llvm::sys::getProcessTriple()`) but if the command line

Re: [PATCH] D23455: [Tooling] Parse compilation database command lines properly on Windows

rnk added a comment. So, I actually went ahead and generated some MSYS makefiles and made a compile_commands.json, and it doesn't work with clang-tidy. You get this kind of output: [ { "directory": "C:/src/test_proj", "command": "\"/C/Program Files/mingw-w64/x86_64-6.1.0-win32-seh-

Re: [PATCH] D23455: [Tooling] Parse compilation database command lines properly on Windows

aaron.ballman added a comment. In https://reviews.llvm.org/D23455#517774, @alexfh wrote: > In https://reviews.llvm.org/D23455#516760, @zturner wrote: > > > In https://reviews.llvm.org/D23455#516753, @alexfh wrote: > > > > > In https://reviews.llvm.org/D23455#515527, @rnk wrote: > > > > > > > In h

Re: [PATCH] D23045: [Include-fixer] Install executables and support scripts

This revision was automatically updated to reflect the committed changes. Closed by commit rL278949: [Include-fixer] Install executables and support scripts (authored by eugenezelenko). Changed prior to commit: https://reviews.llvm.org/D23045?vs=66414&id=68384#toc Repository: rL LLVM https:

[clang-tools-extra] r278949 - [Include-fixer] Install executables and support scripts

Author: eugenezelenko Date: Wed Aug 17 12:27:56 2016 New Revision: 278949 URL: http://llvm.org/viewvc/llvm-project?rev=278949&view=rev Log: [Include-fixer] Install executables and support scripts Differential revision: https://reviews.llvm.org/D23045 Modified: clang-tools-extra/trunk/include

Re: [PATCH] D23353: [clang-tidy] Add check 'misc-use-after-move'

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-tidy/misc/UseAfterMoveCheck.cpp:29 @@ +28,3 @@ +/// Provides information about the evaluation order of (sub-)expressions within +/// a CFGBlock. +/// Please

Re: [PATCH] D21968: [libcxx] Externally threaded libc++ variant - Take 2

compnerd added a subscriber: compnerd. Comment at: CMakeLists.txt:139 @@ -138,1 +138,3 @@ option(LIBCXX_HAS_PTHREAD_API "Ignore auto-detection and force use of pthread API" OFF) +option(LIBCXX_HAS_EXTERNAL_THREAD_API + "Build libc++ with an externalized threading API. -

Re: [PATCH] D16989: Change interpretation of function definition in friend declaration of template class.

sepavloff updated this revision to Diff 68376. sepavloff added a comment. Rebased the patch https://reviews.llvm.org/D16989 Files: include/clang/Sema/Sema.h lib/Sema/SemaDecl.cpp test/SemaCXX/PR25848.cpp test/SemaCXX/friend2.cpp Index: test/SemaCXX/friend2.cpp =

Re: [PATCH] D21675: New ODR checker for modules

dblaikie added inline comments. Comment at: lib/AST/DeclBase.cpp:1810-1812 @@ +1809,5 @@ + void VisitNamedDecl(const NamedDecl *D) { +if (IdentifierInfo *II = D->getIdentifier()) { + ID.AddString(II->getName()); +} +Inherited::VisitNamedDecl(D);

Re: [PATCH] D23353: [clang-tidy] Add check 'misc-use-after-move'

Prazek added a comment. In https://reviews.llvm.org/D23353#516314, @mboehme wrote: > In https://reviews.llvm.org/D23353#511362, @Prazek wrote: > > > I will review it later, but my first thoughts: > > > > 1. I think we should make some other group, because misc seems to be > > overloaded. I discu

r278946 - Simplify condition. (NFC)

Author: adrian Date: Wed Aug 17 11:42:15 2016 New Revision: 278946 URL: http://llvm.org/viewvc/llvm-project?rev=278946&view=rev Log: Simplify condition. (NFC) Modified: cfe/trunk/lib/AST/Decl.cpp Modified: cfe/trunk/lib/AST/Decl.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST

Re: [PATCH] D23343: [clang-tidy] modernize-make-{smart_ptr} private ctor bugfix

alexfh added inline comments. Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:35 @@ +34,3 @@ + auto CanCallCtor = unless(has(ignoringImpCasts(cxxConstructExpr( + hasDeclaration(decl(anyOf(isPrivate(), isProtected(; + Prazek wrote: > alexfh wro

Re: [PATCH] D23343: [clang-tidy] modernize-make-{smart_ptr} private ctor bugfix

Prazek marked 2 inline comments as done. Prazek added a comment. https://reviews.llvm.org/D23343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23343: [clang-tidy] modernize-make-{smart_ptr} private ctor bugfix

Prazek marked 8 inline comments as done. Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:35 @@ +34,3 @@ + auto CanCallCtor = unless(has(ignoringImpCasts(cxxConstructExpr( + hasDeclaration(decl(anyOf(isPrivate(), isProtected(; + alexfh wrote: >

Re: [PATCH] D23343: [clang-tidy] modernize-make-{smart_ptr} private ctor bugfix

Prazek added inline comments. Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:32-33 @@ -31,1 +31,4 @@ + // Calling make_smart_ptr from within a member function of a type with a + // private or protected constructor would be ill-formed. + auto CanCallCtor = unless(has(i

Re: [PATCH] D23343: [clang-tidy] modernize-make-{smart_ptr} private ctor bugfix

alexfh added inline comments. Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:32-33 @@ -31,1 +31,4 @@ + // Calling make_smart_ptr from within a member function of a type with a + // private or protected constructor would be ill-formed. + auto CanCallCtor = unless(has(i

Re: [PATCH] D23168: emit_DW_AT_noreturn flag

aprantl added a comment. Committed as r278942. Thanks! https://reviews.llvm.org/D23168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r278942 - Debug info: Mark noreturn functions with DIFlagNoReturn.

Author: adrian Date: Wed Aug 17 11:20:32 2016 New Revision: 278942 URL: http://llvm.org/viewvc/llvm-project?rev=278942&view=rev Log: Debug info: Mark noreturn functions with DIFlagNoReturn. This affects functions with the C++11 [[ noreturn ]] and C11 _Noreturn specifiers. Patch by Victor Leschuk

  1   2   >