lhchavez marked 2 inline comments as done.
Comment at: cfe/trunk/tools/clang-format/git-clang-format:323
@@ -312,1 +322,3 @@
+def create_tree_from_commit(commit, filenames):
+ """Create a new git tree with the given files from `commit`.
lhchavez wrote:
> lodato
lhchavez updated this revision to Diff 7.
lhchavez marked an inline comment as done.
lhchavez added a comment.
Got rid of create_tree_from_commit
https://reviews.llvm.org/D24319
Files:
tools/clang-format/git-clang-format
Index: tools/clang-format/git-clang-format
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281294: clang-format: Add Java detection to
git-clang-format. (authored by srhines).
Changed prior to commit:
https://reviews.llvm.org/D24401?vs=71104&id=71107#toc
Repository:
rL LLVM
https://review
Author: srhines
Date: Tue Sep 13 00:00:20 2016
New Revision: 281294
URL: http://llvm.org/viewvc/llvm-project?rev=281294&view=rev
Log:
clang-format: Add Java detection to git-clang-format.
Summary: This change adds "java" to the list of known extensions that
clang-format supports.
Patch by Luis
lhchavez updated this revision to Diff 71104.
lhchavez added a comment.
Rebased to r281293
https://reviews.llvm.org/D24401
Files:
tools/clang-format/git-clang-format
Index: tools/clang-format/git-clang-format
===
--- tools/clang
Author: anemet
Date: Mon Sep 12 23:32:40 2016
New Revision: 281293
URL: http://llvm.org/viewvc/llvm-project?rev=281293&view=rev
Log:
Reapply r281276 with passing -emit-llvm in one of the tests
Original commit message:
Add -fdiagnostics-show-hotness
Summary:
I've recently added the ability for o
lhchavez marked 3 inline comments as done.
Comment at: cfe/trunk/tools/clang-format/git-clang-format:93
@@ -92,1 +92,3 @@
help='default commit to use if none is specified'),
+ p.add_argument('--single-commit', action='store_true',
+ help=('run cl
lhchavez updated this revision to Diff 71103.
lhchavez added a comment.
Using lodato's proposed interface. This patch:
- Accepts an arbitrary number of commits as arguments. Validation will be done
in main(), such that two commits are valid only when running in --diff mode.
- Allows diffing two
ahatanak added a comment.
You can create a separate patch for the changes made to lib/Headers/intrin.h
and have it reviewed before committing this patch.
Also, __dst, __x and __n should be added to the output list and "memory" to the
clobber list as majnemer pointed out. I think you can use con
meikeb marked 6 inline comments as done.
meikeb added a comment.
Thanks for taking the time and doing these great reviews! Really appreciated!
Comment at: lib/Sema/SemaChecking.cpp:4143-4150
@@ -4049,3 +4142,10 @@
if (StrE) {
- CheckFormatString(S, StrE, E, Args, HasVA
meikeb updated this revision to Diff 71090.
meikeb marked an inline comment as done.
meikeb added a comment.
Fix mentioned issues.
https://reviews.llvm.org/D23820
Files:
lib/Sema/SemaChecking.cpp
test/Sema/format-strings.c
Index: test/Sema/format-strings.c
=
lhchavez updated this revision to Diff 71097.
lhchavez added a comment.
Fix the script so it does what it advertises.
https://reviews.llvm.org/D24319
Files:
tools/clang-format/git-clang-format
Index: tools/clang-format/git-clang-format
lhchavez added a comment.
I'll post a no-op change with arcanist to fix the paths (I shouldn't have tried
to manually upload the diff), and then another one to fix the patch so that the
script actually does what it advertises and add the comment explaining the
reason for create_tree_from_commit
lhchavez updated this revision to Diff 71095.
lhchavez added a comment.
No-op update. Using arcanist to fix the diff and the paths.
https://reviews.llvm.org/D24319
Files:
tools/clang-format/git-clang-format
Index: tools/clang-format/git-clang-format
==
dlj created this revision.
dlj added a reviewer: rsmith.
dlj added a subscriber: cfe-commits.
Herald added subscribers: mgorny, beanz.
Simplify Clang's version number configuration in CMake.
Currently, the Clang version is computed as follows:
1. LLVM defines major, minor, and patch ver
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: mehdi_amini, compnerd, Prazek.
Eugene.Zelenko added a subscriber: cfe-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
Herald added a subscriber: klimek.
I checked this patch on my own build on RHEL 6. Re
Author: rtrieu
Date: Mon Sep 12 20:37:01 2016
New Revision: 281287
URL: http://llvm.org/viewvc/llvm-project?rev=281287&view=rev
Log:
Handle empty message in static_asserts.
Modified:
cfe/trunk/tools/libclang/CIndex.cpp
Modified: cfe/trunk/tools/libclang/CIndex.cpp
URL:
http://llvm.org/viewv
Author: rtrieu
Date: Mon Sep 12 20:20:40 2016
New Revision: 281286
URL: http://llvm.org/viewvc/llvm-project?rev=281286&view=rev
Log:
Fix interaction between serialization and c++1z feature.
In c++1z, static_assert is not required to have a StringLiteral message, where
previously it was required.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281285: Update Clang for D20147 ("DebugInfo: New metadata
representation for global… (authored by pcc).
Changed prior to commit:
https://reviews.llvm.org/D20415?vs=59260&id=71088#toc
Repository:
rL L
Author: pcc
Date: Mon Sep 12 20:13:19 2016
New Revision: 281285
URL: http://llvm.org/viewvc/llvm-project?rev=281285&view=rev
Log:
Update Clang for D20147 ("DebugInfo: New metadata representation for global
variables.")
Differential Revision: http://reviews.llvm.org/D20415
Modified:
cfe/trun
lhchavez updated this revision to Diff 71087.
lhchavez added a comment.
Using arcanist to fix the paths as well
https://reviews.llvm.org/D24401
Files:
tools/clang-format/git-clang-format
Index: tools/clang-format/git-clang-format
==
On Mon, Sep 12, 2016 at 6:01 PM Robinson, Paul
wrote:
> The text in the committee draft is different (e.g., the exhortation about
> non-default alignment is gone), with an example to the effect that a value
> of 8 means the entity's address is a multiple of 8 (not 2^8). So,
> alignment is concei
The text in the committee draft is different (e.g., the exhortation about
non-default alignment is gone), with an example to the effect that a value of 8
means the entity's address is a multiple of 8 (not 2^8). So, alignment is
conceived in terms of address bits, whatever those represent (not a
alexshap added a comment.
1.
For the code:
struct TestBufferStruct {
int Buffer[3];
};
struct TestBufferStruct GetTestBufferStruct() {
struct TestBufferStruct a;
return a;
}
void AcceptPointer(int *a) {
}
void TestFunc() {
AcceptArray(((GetTestBufferStruct
Author: anemet
Date: Mon Sep 12 19:16:49 2016
New Revision: 281279
URL: http://llvm.org/viewvc/llvm-project?rev=281279&view=rev
Log:
Revert "Add -fdiagnostics-show-hotness"
This reverts commit r281276.
Many bots are failing.
Removed:
cfe/trunk/test/Frontend/Inputs/optimization-remark-with-h
alexshap created this revision.
alexshap added reviewers: NoQ, bcraig, zaks.anna.
alexshap added a subscriber: cfe-commits.
alexshap set the repository for this revision to rL LLVM.
alexshap changed the visibility of this Differential Revision from "Public (No
Login Required)" to "All Users".
AST
rnk added a subscriber: rnk.
Comment at: lib/CodeGen/CGDebugInfo.cpp:608
@@ -608,2 +607,3 @@
uint64_t Size = CGM.getContext().getTypeSize(Ty);
+ uint64_t Align = 0;
IMO this is what we should be doing everywhere, rather than manually checking
AlignedAttr:
On Mon, Sep 12, 2016 at 5:09 PM Reid Kleckner via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rnk
> Date: Mon Sep 12 19:01:23 2016
> New Revision: 281278
>
> URL: http://llvm.org/viewvc/llvm-project?rev=281278&view=rev
> Log:
> [DebugInfo] Deduplicate debug info limiting logic
>
> W
On Mon, Sep 12, 2016 at 5:00 PM Paul Robinson
wrote:
> probinson added a subscriber: probinson.
>
>
> Comment at: lib/CodeGen/CGDebugInfo.cpp:3691
> @@ -3635,1 +3690,3 @@
> + if (D->hasAttr())
> +AlignInBits = D->getMaxAlignment();
>StringRef DeclName, LinkageName;
> ---
On Mon, Sep 12, 2016 at 11:41 AM, David Blaikie wrote:
> (idle thought: It'd be good to make the code common between the first time
> a type is encountered, and the later callbacks when the type is completed,
> required to be complete, vtable is emitted, etc - the inconsistency here (&
> it's spr
Author: rnk
Date: Mon Sep 12 19:01:23 2016
New Revision: 281278
URL: http://llvm.org/viewvc/llvm-project?rev=281278&view=rev
Log:
[DebugInfo] Deduplicate debug info limiting logic
We should be doing the same checks when a type is completed as we do
when a complete type is used during emission. Pr
probinson added a subscriber: probinson.
Comment at: lib/CodeGen/CGDebugInfo.cpp:3691
@@ -3635,1 +3690,3 @@
+ if (D->hasAttr())
+AlignInBits = D->getMaxAlignment();
StringRef DeclName, LinkageName;
dblaikie wrote:
> is max alignment the right thing here? S
Author: gbiv
Date: Mon Sep 12 18:50:35 2016
New Revision: 281277
URL: http://llvm.org/viewvc/llvm-project?rev=281277&view=rev
Log:
[Sema] Fix PR30346: relax __builtin_object_size checks.
This patch makes us act more conservatively when trying to determine
the objectsize for an array at the end of
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281276: Add -fdiagnostics-show-hotness (authored by anemet).
Changed prior to commit:
https://reviews.llvm.org/D23284?vs=70547&id=71078#toc
Repository:
rL LLVM
https://reviews.llvm.org/D23284
Files:
Author: anemet
Date: Mon Sep 12 18:48:16 2016
New Revision: 281276
URL: http://llvm.org/viewvc/llvm-project?rev=281276&view=rev
Log:
Add -fdiagnostics-show-hotness
Summary:
I've recently added the ability for optimization remarks to include the
hotness of the corresponding code region. This uses
Author: anemet
Date: Mon Sep 12 18:48:11 2016
New Revision: 281275
URL: http://llvm.org/viewvc/llvm-project?rev=281275&view=rev
Log:
Fix a long comment line
Modified:
cfe/trunk/include/clang/Frontend/CodeGenOptions.def
Modified: cfe/trunk/include/clang/Frontend/CodeGenOptions.def
URL:
http:
lhchavez updated this revision to Diff 71075.
lhchavez added a comment.
Generated the diff properly this time, and it now shows full context.
Repository:
rL LLVM
https://reviews.llvm.org/D24401
Files:
cfe/trunk/tools/clang-format/git-clang-format
Index: cfe/trunk/tools/clang-format/git-cl
Sorry, I was distracted by other issues after I uploaded the patch.
I will take another look of the implementation.
Thanks,
Weiming
On 9/12/2016 1:31 PM, Sam Shepperd wrote:
phabricss added a comment.
On 09/12/2016 01:26 PM, Nick Lewycky wrote:
Firstly, I thought glibc had applied a patch
doug.gregor accepted this revision.
doug.gregor added a comment.
This revision is now accepted and ready to land.
Yep, this refactor looks good!
https://reviews.llvm.org/D24059
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
doug.gregor accepted this revision.
doug.gregor added a comment.
This revision is now accepted and ready to land.
Ahhh, much cleaner. Thanks!
https://reviews.llvm.org/D23080
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
dblaikie added a comment.
Like the backend patch, should/could this be broken up into separate patches
for the different places/features that have alignment?
(probably just passing zero for alignment in general could be a simple cleanup
patch to start, if it's otherwise unused)
==
doug.gregor accepted this revision.
doug.gregor added a comment.
This revision is now accepted and ready to land.
This looks great, thank you!
https://reviews.llvm.org/D23079
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
lodato added a subscriber: lodato.
lodato added a comment.
Hi lhchavez,
This patch does not work as intended. If I understand correctly, you want to
see if a given `` has any clang-format problems. However:
1. This patch only computes `changed_lines` from `` but then runs
clang-format on the f
doug.gregor accepted this revision.
doug.gregor added a comment.
This revision is now accepted and ready to land.
I don't love the fact that it makes callers fragile, but having to do tentative
parsing for these otherwise-unambiguous cases is expensive (in compile time).
We should only use tenta
Eugene.Zelenko updated this revision to Diff 71063.
Eugene.Zelenko added a comment.
Implement Saleem suggestions.
Repository:
rL LLVM
https://reviews.llvm.org/D24439
Files:
lib/Analysis/PrintfFormatString.cpp
lib/Basic/Diagnostic.cpp
lib/Basic/SourceManager.cpp
lib/Index/IndexDecl.cp
Eugene.Zelenko marked 3 inline comments as done.
Eugene.Zelenko added a comment.
Repository:
rL LLVM
https://reviews.llvm.org/D24439
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mprobst created this revision.
mprobst added a reviewer: djasper.
mprobst added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
See (sorry, internal link): go/taze#global-symbols-dts-externs.
Before:
// taze: many, different, symbols from
// //some/long/iwyu/style/target
Af
majnemer added a subscriber: majnemer.
majnemer added a comment.
Does __uuidof walk bases to find [uuid] in cl.exe? They walk bases for the
__declspec spelling.
https://reviews.llvm.org/D24469
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
aaron.ballman added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2258
@@ -2257,1 +2257,3 @@
"uuid attribute contains a malformed GUID">;
+def err_mismatched_uuid : Error<"uiid does not match previous declaration">;
+def note_previous_uuid : Note<"prev
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: lib/Parse/ParseDecl.cpp:1456
@@ -1451,1 +1455,3 @@
+ TypeAttrTail = AL;
+ TypeAttrTail->setNext(nullptr);
mmm hand rolled singly linked
ahatanak added inline comments.
Comment at: llvm/tools/clang/lib/Sema/SemaExpr.cpp:8733
@@ -8731,2 +8732,3 @@
if (!IsCompAssign) {
-LHS = S.UsualUnaryConversions(LHS.get());
+if (S.LangOpts.OpenCL || S.LangOpts.ZVector)
+ LHS = S.UsualUnaryConversions(LHS.get());
-
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281264: config: Use _LIBCPP_TYPE_VIS_ONLY with enum class
(authored by smeenai).
Changed prior to commit:
https://reviews.llvm.org/D24065?vs=70087&id=71059#toc
Repository:
rL LLVM
https://reviews.ll
Author: smeenai
Date: Mon Sep 12 16:41:12 2016
New Revision: 281264
URL: http://llvm.org/viewvc/llvm-project?rev=281264&view=rev
Log:
config: Use _LIBCPP_TYPE_VIS_ONLY with enum class
An enum class has associated type info. In the Microsoft ABI, type info
is emitted in the COMDAT section and isn'
ayartsev updated this revision to Diff 71056.
ayartsev added a comment.
Updated the patch. Important change in Options.td was missing in the last patch
+ indentation fixed.
Still Ok to commit?
https://reviews.llvm.org/D22494
Files:
include/clang/Driver/Options.td
lib/StaticAnalyzer/Core/Pa
Hi Mike,
Can you check if https://reviews.llvm.org/D24475 fixes the issue for you?
This looks like a bug in the gcc pre-processor (in older versions of gcc).
I'm a bit hesitant because my gcc (4.8.3) bumps into a different issue
(crash!) as well, but that seem to have nothing to do with my patch
Author: compnerd
Date: Mon Sep 12 16:15:23 2016
New Revision: 281261
URL: http://llvm.org/viewvc/llvm-project?rev=281261&view=rev
Log:
CodeGen: use some range-based for loops
Use range-based for loops to simplify the logic. Add an explicit check for
MachO as the inline asm uses MachO specific di
Author: rsmith
Date: Mon Sep 12 16:07:09 2016
New Revision: 281259
URL: http://llvm.org/viewvc/llvm-project?rev=281259&view=rev
Log:
Add a couple of test files missed in r281258.
Added:
cfe/trunk/test/Modules/Inputs/merge-template-pattern-visibility/c.h
cfe/trunk/test/Modules/Inputs/merge
Author: rsmith
Date: Mon Sep 12 16:06:40 2016
New Revision: 281258
URL: http://llvm.org/viewvc/llvm-project?rev=281258&view=rev
Log:
[modules] When we merge two definitions of a function, mark the retained
definition as visible in the discarded definition's module, as we do for
other kinds of defi
bruno created this revision.
bruno added a reviewer: rnk.
bruno added subscribers: cfe-commits, ahatanak.
Support lax conversions on compound assignment expressions like:
typedef __attribute__((vector_size(8))) double float64x1_t;
typedef __attribute__((vector_size(16))) double float64x2_t;
djasper added a comment.
The problem is that it is implicit behavior, that's not easy to understand.
What's worse is that the behavior of add and merge would fundamentally be
reverse. If you add two inserts at the same location, the first one would come
first. If you merge them, the second one
OK, I'm able to reproduce locally. Looks like gcc (4.8.3 at least) does not
like my patch.
Working on a fix...
On Mon, Sep 12, 2016 at 9:43 PM, Asiri Rathnayake <
asiri.rathnay...@gmail.com> wrote:
> Hi Mike,
>
> That does look related to my change. Is this an internal build? I was
> looking out
Hi Mike,
That does look related to my change. Is this an internal build? I was
looking out for the bots on llvm.org but didn't spot any issues (yet).
Will try to reproduce locally. Would it be OK if I find a fix tomorrow?
(night time here in the UK), can revert if this is blocking you.
Cheers,
thakis updated this revision to Diff 71050.
thakis added a comment.
On conflict, keep first uuid in ast instead of having different uuids on
different redeclarations.
https://reviews.llvm.org/D24469
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/AttributeList.h
incl
thakis updated this revision to Diff 71049.
thakis added a comment.
Remove local XXXs I've since addressed.
https://reviews.llvm.org/D24469
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/AttributeList.h
include/clang/Sema/Sema.h
lib/Parse/ParseDecl.cpp
lib/Sema/S
dcoughlin created this revision.
dcoughlin added a reviewer: rizsotto.mailinglist.
dcoughlin added a subscriber: cfe-commits.
Remove the relative path hack in scan-build-py that converts a fully qualified
directory name and a fully qualified file path to a relative path before
running the analyz
thakis created this revision.
thakis added a reviewer: rnk.
thakis added subscribers: cfe-commits, aaron.ballman.
This mostly behaves cl.exe's behavior, even though clang-cl is stricter in some
corner cases and more lenient in others (see the included test).
To make the `uuid declared previously
phabricss added a comment.
On 09/12/2016 01:26 PM, Nick Lewycky wrote:
> Firstly, I thought glibc had applied a patch to fix this bug? As in, the
> error is correct and glibc fixed their bug?
I can confirm that the bug still exists in glibc 2.24 and HEAD from glibc git.
Also it appears that
Asiri,
The boot strap build has started to fail for. Your change seems to be
related, right?
[14/22] Building CXX object
projects/libcxx/lib/CMakeFiles/cxx_objects.dir/__/src/locale.cpp.o
FAILED: /usr/bin/g++ -D_DEBUG -D_GNU_SOURCE
-D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D__STDC_CONSTANT_MACROS
Author: smeenai
Date: Mon Sep 12 15:14:44 2016
New Revision: 281250
URL: http://llvm.org/viewvc/llvm-project?rev=281250&view=rev
Log:
config: Fix typo in comment
Testing commit access. NFC.
Modified:
libcxx/trunk/include/__config
Modified: libcxx/trunk/include/__config
URL:
http://llvm.org
ioeric added a comment.
In https://reviews.llvm.org/D24383#539942, @djasper wrote:
> Ok.. Thought some more and discussed with Manuel.
>
> I think we should do a partial solution for now. I still think addOrMerge is
> harmful and it is always never the right thing to use. The codepaths that
> c
rsmith added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:3842-3843
@@ -3841,2 +3841,4 @@
-static void CheckFormatString(Sema &S, const StringLiteral *FExpr,
+static void reckonUpOffset(llvm::APSInt &Offset, llvm::APSInt Addend,
+ BinaryOperat
meikeb marked 4 inline comments as done.
Comment at: lib/Sema/SemaChecking.cpp:4166-4167
@@ +4165,4 @@
+if (BinOp->isAdditiveOp()) {
+ bool LIsInt = false;
+ bool RIsInt = false;
+ // Prevent asserts triggering in EvaluateAsInt by checking if we deal
with
-
meikeb updated this revision to Diff 71043.
meikeb added a comment.
Fix the mentioned issues.
https://reviews.llvm.org/D23820
Files:
lib/Sema/SemaChecking.cpp
test/Sema/format-strings.c
Index: test/Sema/format-strings.c
===
--
Anastasia added a comment.
I have made an experiment with a simple kernel:
void foo1(void);
void foo2(void);
void foo3(void);
void foo4(void);
void foo5(void);
void foo6(void);
void foo7(void);
void foo8(void);
void foo9(void);
void foo10(void);
void test(){
foo1();
mgorny marked 3 inline comments as done.
mgorny added a comment.
And done.
https://reviews.llvm.org/D24005
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgorny updated this revision to Diff 71040.
Herald added subscribers: mgorny, beanz.
https://reviews.llvm.org/D24005
Files:
cmake/Modules/CompilerRTUtils.cmake
Index: cmake/Modules/CompilerRTUtils.cmake
===
--- cmake/Modules/Compi
vbyakovlcl created this revision.
vbyakovlcl added reviewers: ahatanak, aaron.ballman.
vbyakovlcl added subscribers: andreybokhanko, cfe-commits.
vbyakovlcl set the repository for this revision to rL LLVM.
vbyakovlcl changed the visibility of this Differential Revision from "Public
(No Login Requi
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
One comment below, otherwise LGTM.
Comment at: cmake/Modules/CompilerRTUtils.cmake:200
@@ -199,5 +199,3 @@
string(REGEX REPLACE "[ \t]*[\r\n]+[ \t]*" ";" CONFIG_OUTPUT
${CON
NoQ added a comment.
I think there's still this problem i've outlined in the comment above: you can
step into an integer-underflow if your analysis begins with unlock(). You could
just ignore all unlocks that move you below 0, which would be ok.
Could you add this test?
std::mutex m;
void
Looks like this test could be a bit simpler:
struct foo;
foo *f; // produces a forward decl
struct foo {
virtual ~foo();
};
foo f; // requires the type to be complete
A cursory glance looks like this reproduces the issue, but I may've missed
something.
Also the bracing in the new condition you
On 11 September 2016 at 21:14, Sam Shepperd via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> phabricss added a subscriber: phabricss.
> phabricss added a comment.
>
> It is still impossible to compile glibc with clang due to this bug. Could
> this patch be reviewed please.
>
Firstly, I tho
standalone and limit-debug-info are the same functionality -
-fstandalone-debug is the more modern and apt description, so perhaps just
keep that one & drop/don't provide -flimit-debug-info (since there's no
real need to be backwards compatible in the flag support in clang-cl, I
expect)?
On Fri, S
Author: rsmith
Date: Mon Sep 12 12:55:49 2016
New Revision: 281241
URL: http://llvm.org/viewvc/llvm-project?rev=281241&view=rev
Log:
Diagnostics reference: "error:" should be red, not orange.
Modified:
cfe/trunk/docs/DiagnosticsReference.rst
cfe/trunk/include/clang/Basic/DiagnosticDocs.td
Ah, hmm - we do use this technique in a few places. Oh, right - protected
in the base, final derived classes (maybe that's the missing element?). So
I think we've disabled whatever GCC warnings get in the way of that
particular cliche.
But, fair enough - thanks for the context. All power to the MS
On Mon, Sep 12, 2016 at 10:55 AM, David Blaikie via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Does that actually need a virtual dtor? The type erasure handling in
> shared_ptr would handle it so long as each instance is constructed with the
> derived type (looks like it probably is - make
Does that actually need a virtual dtor? The type erasure handling in
shared_ptr would handle it so long as each instance is constructed with the
derived type (looks like it probably is - make_shared used consistently) &
we should get a warning (or could make the base dtor protected non-virtual
to e
zaks.anna added a comment.
Let's test it on more real word bugs.
Comment at: lib/StaticAnalyzer/Checkers/BoolConversionChecker.cpp:11
@@ +10,3 @@
+// This file defines BoolConversionChecker, which checks for a particular
+// common mistake when dealing with NSNumber and OSBoolea
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm
I'm a little bit worried that we've started down a slippery slope of deciding
what is and isn't allowed in naked functions (for example, some initializers
could be allowed if we're sure they
zaks.anna added a comment.
@NoQ,
Let's test in an IDE. Can you send screenshots?
https://reviews.llvm.org/D23300
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno added a comment.
Ping!
https://reviews.llvm.org/D23852
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dkrupp marked 11 inline comments as done.
dkrupp added a comment.
issues fixed
https://reviews.llvm.org/D24307
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: jroelofs
Date: Mon Sep 12 11:14:52 2016
New Revision: 281227
URL: http://llvm.org/viewvc/llvm-project?rev=281227&view=rev
Log:
Trivial documentation fix regarding Obj-C ARC
objc_arc_weak_reference_unavailable
Fixed incorrect docs that referred to:
objc_arc_weak_unavailable
when it shou
edward-jones created this revision.
edward-jones added a reviewer: rjmccall.
edward-jones added a subscriber: cfe-commits.
llvm.flt.rounds returns an i32, but the builtin expects an integer. On targets
where integers are not 32-bits clang tries to bitcast the result, causing an
assertion failure
djasper added a comment.
Ok.. Thought some more and discussed with Manuel.
I think we should do a partial solution for now. I still think addOrMerge is
harmful and it is always never the right thing to use. The codepaths that
currently implement some version of it, should likely reconsider.
Wh
NoQ added a comment.
Random thoughts:
- This checker doesn't alter the exploded graph, so it cannot be causing or
suppressing positives in other checkers.
- We should not be adding platform-specific behavior (eg. working as if
`sizeof(int) == 1`) without actually ensuring that it is so on that
Somehow the commit message was wrong...should be "Added more test cases"
instead.
On Mon, Sep 12, 2016 at 4:38 PM Eric Liu wrote:
> ioeric updated this revision to Diff 71006.
> ioeric added a comment.
>
> - Also cleanup comments around redundant colons/commas in format::cleanup.
>
>
> https://r
ioeric updated this revision to Diff 71006.
ioeric added a comment.
- Also cleanup comments around redundant colons/commas in format::cleanup.
https://reviews.llvm.org/D24383
Files:
include/clang/Tooling/Core/Replacement.h
lib/Tooling/Core/Replacement.cpp
unittests/Tooling/RefactoringTest
ioeric added a comment.
@djasper Thanks for the insight into the problem.
For the cases you listed, I have added some test cases. Case 1-3 can be handled
as expected. And you are right, the behavior for case 4 is interesting.
But I still agree that `addOrMerge` is confusing. As you said, the in
mgorny added inline comments.
Comment at: cmake/Modules/CompilerRTUtils.cmake:200
@@ -199,5 +199,3 @@
string(REGEX REPLACE "[ \t]*[\r\n]+[ \t]*" ";" CONFIG_OUTPUT
${CONFIG_OUTPUT})
- list(GET CONFIG_OUTPUT 0 LLVM_BINARY_DIR)
- list(GET CONFIG_OUTPUT 1 LLVM_TOOLS_BINARY_DIR)
aaron.ballman added a comment.
In https://reviews.llvm.org/D23921#531883, @aaron.ballman wrote:
> Ping
Ping
https://reviews.llvm.org/D23921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
1 - 100 of 120 matches
Mail list logo
