Author: hokein
Date: Fri Oct 14 08:43:49 2016
New Revision: 284236
URL: http://llvm.org/viewvc/llvm-project?rev=284236&view=rev
Log:
[clang-move] Don't overuse Replacements::add.
Reviewers: ioeric
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D25613
Modified:
cla
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Awesome! Lg with one nit.
Comment at: clang-move/ClangMove.cpp:197
clang::tooling::Replacement
getReplacementInChangedCode(const clang::tooling::Replacements &Replacements,
hokein updated this revision to Diff 74677.
hokein added a comment.
Delete one more function.
https://reviews.llvm.org/D25613
Files:
clang-move/ClangMove.cpp
Index: clang-move/ClangMove.cpp
===
--- clang-move/ClangMove.cpp
+++ c
hokein updated this revision to Diff 74675.
hokein added a comment.
woohoo, delete more code!
https://reviews.llvm.org/D25613
Files:
clang-move/ClangMove.cpp
Index: clang-move/ClangMove.cpp
===
--- clang-move/ClangMove.cpp
+++ c
ioeric added inline comments.
Comment at: clang-move/ClangMove.cpp:472
std::string FilePath = RemoveReplacement.getFilePath().str();
addOrMergeReplacement(RemoveReplacement, &FileToReplacements[FilePath]);
For deletions, you can simply use `add`, whic
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284235: [clang-tidy] Add additional diagnostic to
misc-use-after-move (authored by mboehme).
Changed prior to commit:
https://reviews.llvm.org/D25612?vs=74671&id=74673#toc
Repository:
rL LLVM
https:
Author: mboehme
Date: Fri Oct 14 08:23:39 2016
New Revision: 284235
URL: http://llvm.org/viewvc/llvm-project?rev=284235&view=rev
Log:
[clang-tidy] Add additional diagnostic to misc-use-after-move
Summary:
This adds a diagnostic to the misc-use-after-move check that is output when the
use happens
hokein created this revision.
hokein added a reviewer: ioeric.
hokein added a subscriber: cfe-commits.
https://reviews.llvm.org/D25613
Files:
clang-move/ClangMove.cpp
Index: clang-move/ClangMove.cpp
===
--- clang-move/ClangMove.c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284233: [clang-move] Add header guard for the new header.
(authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D25610?vs=74663&id=74669#toc
Repository:
rL LLVM
https://reviews.llv
mboehme updated this revision to Diff 74671.
mboehme added a comment.
- Responses to reviewer comments
https://reviews.llvm.org/D25612
Files:
clang-tidy/misc/UseAfterMoveCheck.cpp
test/clang-tidy/misc-use-after-move.cpp
Index: test/clang-tidy/misc-use-after-move.cpp
==
Author: hokein
Date: Fri Oct 14 08:01:36 2016
New Revision: 284233
URL: http://llvm.org/viewvc/llvm-project?rev=284233&view=rev
Log:
[clang-move] Add header guard for the new header.
Summary:
The header guard generated by clang-move isn't always a perfect
style, just avoid getting the header incl
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added inline comments.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:3005
+/// \endcode
+AST_MATCHER(VarDecl, isStaticDataMember) {
+ return Node.isStaticDataMember();
How does this differ from t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284232: [libcxx] Do not declare the thread api when
__external_threading is present (authored by asiri).
Changed prior to commit:
https://reviews.llvm.org/D25468?vs=74234&id=74668#toc
Repository:
rL
Author: asiri
Date: Fri Oct 14 08:00:07 2016
New Revision: 284232
URL: http://llvm.org/viewvc/llvm-project?rev=284232&view=rev
Log:
[libcxx] Do not declare the thread api when __external_threading is present
This fixes a small omission where even when __external_threading is provided,
we attempt
hokein added inline comments.
Comment at: clang-move/ClangMove.cpp:264
+HeaderGuard += "#define " + GuardName + "\n";
+clang::tooling::Replacement HeaderGuardInclude(FileName, 0, 0,
+ HeaderGuard);
ioeric
Author: ericwf
Date: Fri Oct 14 07:56:52 2016
New Revision: 284230
URL: http://llvm.org/viewvc/llvm-project?rev=284230&view=rev
Log:
Disable Modules when building the libc++ sources.
Libc++ will not build with modules enabled. In order to support an in-tree
libc++ when LLVM_ENABLE_MODULES is ON w
mgorny retitled this revision from "[libcxx] [CMake] Build Solaris compat as
separate C lib, to avoid -std= issues" to "[libcxx] Convert Solaris support
library to C++ to fix -std=c++11 build
".
mgorny updated the summary for this revision.
mgorny updated this revision to Diff 74666.
mgorny added
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
The code looks good.
Comment at: clang-tidy/misc/UseAfterMoveCheck.cpp:579
DiagnosticIDs::Note);
+ } else if(UseLoc < MoveLoc || Use.DeclRef == MoveArg) {
+
Author: abataev
Date: Fri Oct 14 07:43:59 2016
New Revision: 284229
URL: http://llvm.org/viewvc/llvm-project?rev=284229&view=rev
Log:
Fix for PR30632: Name mangling issue.
There was a bug in the implementation of captured statements. If it has
a lambda expression in it and the same lambda express
mboehme created this revision.
mboehme added a reviewer: hokein.
mboehme added a subscriber: cfe-commits.
This adds a diagnostic to the misc-use-after-move check that is output when the
use happens on a later loop iteration than the move, for example:
A a;
for (int i = 0; i < 10; ++i) {
a
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Lg
Comment at: clang-move/ClangMove.cpp:264
+HeaderGuard += "#define " + GuardName + "\n";
+clang::tooling::Replacement HeaderGuardInclude(FileName, 0, 0,
+
mgorny added a comment.
In https://reviews.llvm.org/D25431#570227, @EricWF wrote:
> Why not just compile the sources files as C++ by changing their extensions?
> This change seems all kinds of wrong because we're throwing away *all* of our
> flags, including things like `-m32` or `-target `.
mgorny added a comment.
In https://reviews.llvm.org/D25568#570222, @EricWF wrote:
> This doesn't seem right seeing as `print-libgcc_file-name` prints the
> `libgcc.a` path, and we were previously linking `libgcc_s`.
Do you have any other solution in mind? There is no switch to print the share
hokein created this revision.
hokein added a reviewer: ioeric.
hokein added a subscriber: cfe-commits.
The header guard generated by clang-move isn't always a perfect
style, just avoid getting the header included multiple times during
compiling period.
Also, we can use llvm-Header-guard clang-tid
Author: ioeric
Date: Fri Oct 14 06:48:10 2016
New Revision: 284228
URL: http://llvm.org/viewvc/llvm-project?rev=284228&view=rev
Log:
Removed duplicate header include
Reviewers: ioeric
Subscribers: klimek
Patch by Krasimir Georgiev!
Differential Revision: https://reviews.llvm.org/D25599
Modifi
EricWF abandoned this revision.
EricWF added a comment.
Another fix was committed.
https://reviews.llvm.org/D23524
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ikudrin created this revision.
ikudrin added reviewers: hansonw, compnerd, indygreg, eliben.
ikudrin added a subscriber: cfe-commits.
Please note that this patch fixes only Windows-related issues.
https://reviews.llvm.org/D25470 is required to pass all the tests.
https://reviews.llvm.org/D25608
EricWF added a comment.
Why not just compile the sources files as C++ by changing their extensions?
This change seems all kinds of wrong because we're throwing away *all* of our
flags, including things like `-m32` or `-target `.
https://reviews.llvm.org/D25431
__
EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.
This doesn't seem right seeing as `print-libgcc_file-name` prints the
`libgcc.a` path, and we were previously linking `libgcc_s`.
https://reviews.llvm.org/D25568
___
Author: ericwf
Date: Fri Oct 14 05:30:33 2016
New Revision: 284225
URL: http://llvm.org/viewvc/llvm-project?rev=284225&view=rev
Log:
Work around Clang driver segfault when --coverage is used with -c and /dev/null
Modified:
libcxx/trunk/test/libcxx/compiler.py
Modified: libcxx/trunk/test/libc
Author: ioeric
Date: Fri Oct 14 05:10:26 2016
New Revision: 284222
URL: http://llvm.org/viewvc/llvm-project?rev=284222&view=rev
Log:
Try to fix windows bot file path style failure caused by r284219.
Modified:
cfe/trunk/unittests/Tooling/RefactoringTest.cpp
Modified: cfe/trunk/unittests/Tooli
danielmarjamaki created this revision.
danielmarjamaki added reviewers: NoQ, dcoughlin.
danielmarjamaki added subscribers: cfe-commits, xazax.hun, zaks.anna, a.sidorin.
danielmarjamaki set the repository for this revision to rL LLVM.
This patch fixes false positives for such code:
#define RETUR
Author: hokein
Date: Fri Oct 14 05:07:58 2016
New Revision: 284221
URL: http://llvm.org/viewvc/llvm-project?rev=284221&view=rev
Log:
[clang-move] Matching static class member more correctly.
Reviewers: ioeric
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D25598
Modif
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284221: [clang-move] Matching static class member more
correctly. (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D25598?vs=74633&id=74650#toc
Repository:
rL LLVM
https://rev
EricWF added a comment.
I just spoke with Jonathan Wakely about this change, and he believes that it
should be ABI safe.
https://reviews.llvm.org/D25593
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
v.g.vassilev created this revision.
v.g.vassilev added reviewers: chandlerc, rsmith.
v.g.vassilev added a subscriber: cfe-commits.
v.g.vassilev set the repository for this revision to rL LLVM.
Repository:
rL LLVM
https://reviews.llvm.org/D25604
Files:
lib/Driver/ToolChains.cpp
Index: lib/D
EricWF created this revision.
EricWF added a reviewer: mclow.lists.
EricWF added a subscriber: cfe-commits.
`__libcpp_refstring` currently has two different definitions. First there is
the complete definition in `<__refstring>` but there is also a second in
``. The historical reason for this s
bkramer added a comment.
I think the assertion is correct, there's something fishy with the inputs. The
paths coming in should be absolute, and there should never be a .. at the start
in a absolute path. This only fails on a single buildbot and doesn't reproduce
anywhere else. @bruno any ideas?
v.g.vassilev created this revision.
v.g.vassilev added a reviewer: rsmith.
v.g.vassilev added a subscriber: cfe-commits.
We are using this in the context of cling, where we keep the compiler instance
alive after EOF.
The incremental processing part in clang was done mostly by me and this patch
hokein created this revision.
hokein added a reviewer: klimek.
hokein added a subscriber: cfe-commits.
https://reviews.llvm.org/D25600
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
unittests/ASTMatchers/ASTMatchersNarrowingTest.cpp
Index: unittests/ASTMa
rogfer01 updated this revision to Diff 74638.
rogfer01 added a comment.
Updated patch, now we check if the innermost base of a MemberExpr is a
DeclRefExpr and check for its declaration in case it provides stronger
alignment guarantees.
https://reviews.llvm.org/D23657
Files:
include/clang/Se
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D25598
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
Author: ioeric
Date: Fri Oct 14 04:32:06 2016
New Revision: 284219
URL: http://llvm.org/viewvc/llvm-project?rev=284219&view=rev
Log:
Deduplicate sets of replacements by file names.
Summary:
If there are multiple pairs with the same file
path after removing dots, we only keep one pair (with path
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284219: Deduplicate sets of replacements by file names.
(authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D25565?vs=74634&id=74636#toc
Repository:
rL LLVM
https://reviews.llvm.
ioeric updated this revision to Diff 74634.
ioeric added a comment.
- Merge branch 'master' of http://llvm.org/git/clang into arcpatch-D25565
- Forgot to update names in tests...
https://reviews.llvm.org/D25565
Files:
include/clang/Tooling/Core/Replacement.h
include/clang/Tooling/Refactorin
hokein created this revision.
hokein added a reviewer: ioeric.
hokein added a subscriber: cfe-commits.
https://reviews.llvm.org/D25598
Files:
clang-move/ClangMove.cpp
test/clang-move/Inputs/test.cpp
test/clang-move/Inputs/test.h
test/clang-move/move-class.cpp
Index: test/clang-move/move
Author: ericwf
Date: Fri Oct 14 04:12:53 2016
New Revision: 284217
URL: http://llvm.org/viewvc/llvm-project?rev=284217&view=rev
Log:
Mark test as unsupported without threads
Modified:
libcxxabi/trunk/test/libcxxabi/test/config.py
libcxxabi/trunk/test/thread_local_destruction_order.pass.cp
ioeric updated this revision to Diff 74632.
ioeric added a comment.
- Change name to groupReplacementsByFile
https://reviews.llvm.org/D25565
Files:
include/clang/Tooling/Core/Replacement.h
include/clang/Tooling/Refactoring.h
lib/Tooling/Core/Replacement.cpp
lib/Tooling/Refactoring.cpp
ioeric updated this revision to Diff 74631.
ioeric added a comment.
- Separate assertions to get more information.
https://reviews.llvm.org/D25597
Files:
lib/Basic/VirtualFileSystem.cpp
Index: lib/Basic/VirtualFileSystem.cpp
==
Author: ericwf
Date: Fri Oct 14 04:06:38 2016
New Revision: 284216
URL: http://llvm.org/viewvc/llvm-project?rev=284216&view=rev
Log:
Remove dead CMake target
Modified:
libcxx/trunk/cmake/Modules/HandleLibCXXABI.cmake
libcxx/trunk/lib/CMakeLists.txt
Modified: libcxx/trunk/cmake/Modules/Ha
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
I'd not rename the function. Otherwise looks good.
https://reviews.llvm.org/D25565
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
rmaprath closed this revision.
rmaprath added a comment.
Committed as r284128.
https://reviews.llvm.org/D24864
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric created this revision.
ioeric added a reviewer: bkramer.
ioeric added a subscriber: cfe-commits.
Since `remove_dots` does not delete leading "../" anymore, assertion test need
to be updated.
https://reviews.llvm.org/D25597
Files:
lib/Basic/VirtualFileSystem.cpp
Index: lib/Basic/Virtu
danielmarjamaki created this revision.
danielmarjamaki added a reviewer: NoQ.
danielmarjamaki added subscribers: cfe-commits, xazax.hun, dcoughlin.
danielmarjamaki set the repository for this revision to rL LLVM.
This patch fix false positives for loss of sign in addition and subtraction
assignme
Author: ericwf
Date: Fri Oct 14 03:47:09 2016
New Revision: 284214
URL: http://llvm.org/viewvc/llvm-project?rev=284214&view=rev
Log:
XFAIL aligned allocation tests for older Clang versions
Modified:
libcxx/trunk/test/libcxx/test/config.py
libcxx/trunk/test/std/language.support/support.dy
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284213: [x86][ms-inline-asm] use of "jmp short" in asm is
not supported (authored by mzuckerm).
Changed prior to commit:
https://reviews.llvm.org/D24958?vs=72624&id=74626#toc
Repository:
rL LLVM
htt
Author: mzuckerm
Date: Fri Oct 14 03:13:27 2016
New Revision: 284213
URL: http://llvm.org/viewvc/llvm-project?rev=284213&view=rev
Log:
[x86][ms-inline-asm] use of "jmp short" in asm is not supported
Test linked to: https://reviews.llvm.org/D24957
Committing in the name of Ziv Izhar: After check-
Author: mkurdej
Date: Fri Oct 14 03:10:08 2016
New Revision: 284212
URL: http://llvm.org/viewvc/llvm-project?rev=284212&view=rev
Log:
[clang-tidy] Fix readability-braces-around-statements false positive
Summary:
This fixes a false-positive e.g. when string literals are returned from if
statement
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks.
Repository:
rL LLVM
https://reviews.llvm.org/D25586
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
Author: ericwf
Date: Fri Oct 14 02:49:15 2016
New Revision: 284210
URL: http://llvm.org/viewvc/llvm-project?rev=284210&view=rev
Log:
XFAIL aligned allocation test failures with UBSAN
Modified:
libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/delete_align_va
mstorsjo added a comment.
> (should they be also on AArch64? I had problems with testing it for AArch64,
> so I left it)
Technically, I think they should be on AArch64 as well. But clang/LLVM probably
doesn't support AArch64/Windows yet (I guess?), so testing it probably is
impossible. When/if
Author: ericwf
Date: Fri Oct 14 02:19:52 2016
New Revision: 284209
URL: http://llvm.org/viewvc/llvm-project?rev=284209&view=rev
Log:
Add void_t and invoke feature test macros
Added:
libcxx/trunk/test/std/utilities/function.objects/func.invoke/invoke_feature_test_macro.pass.cpp
libcxx/tr
timshen created this revision.
timshen added reviewers: mclow.lists, EricWF.
timshen added a subscriber: cfe-commits.
Fixes PR21597.
https://reviews.llvm.org/D25595
Files:
libcxx/include/regex
libcxx/test/std/re/re.alg/re.alg.search/pr21597.pass.cpp
Index: libcxx/test/std/re/re.alg/re.alg
101 - 163 of 163 matches
Mail list logo
