[PATCH] D25888: Add support for __builtin_os_log_format[_buffer_size]

mehdi_amini updated this revision to Diff 75524. mehdi_amini added a comment. Address David's feedback. Thanks David! https://reviews.llvm.org/D25888 Files: clang/include/clang/Analysis/Analyses/FormatString.h clang/include/clang/Analysis/Analyses/OSLog.h

[PATCH] D25888: Add support for __builtin_os_log_format[_buffer_size]

majnemer added a comment. You could use `llvm::any_of` instead of `std::any_of`. Comment at: clang/include/clang/Analysis/Analyses/OSLog.h:84-86 + result |= 0x01; +if (getIsPublic()) + result |= 0x02; IsPublic/IsPrivate instead of magic numbers?

[PATCH] D25895: [MS ABI] Reuse getVFPtrOffsets instead of using getClassAtVTableLocation

majnemer created this revision. majnemer added reviewers: rnk, pcc. majnemer added a subscriber: cfe-commits. getClassAtVTableLocation hunts through virtual bases without using the MDC layout which is indicative of a bug. Instead, reuse the getVFPtrOffsets machinery to calculate which subobject

[PATCH] D25893: [clang] Remove redundant --check-prefix=CHECK from tests

mgrang created this revision. mgrang added reviewers: hans, mkuper, rengolin. mgrang added a subscriber: cfe-commits. mgrang added a project: clang-c. https://reviews.llvm.org/D25893 Files: test/CodeGen/ms-mm-align.c test/CodeGen/windows-on-arm-stack-probe-size.c Index:

[PATCH] D25809: [CUDA] Improved target attribute-based overloading.

jlebar accepted this revision. jlebar added inline comments. This revision is now accepted and ready to land. Comment at: lib/Sema/SemaCUDA.cpp:87 + + if ((HasHostAttr && HasDeviceAttr) || ForceCUDAHostDeviceDepth > 0) +return CFT_HostDevice; tra wrote: >

[PATCH] D25491: [libcxx] Use C++14 when building libc++ with musl

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. Comment at: CMakeLists.txt:331 + # not a constexpr in C++11 but is in C++14, so we use C++14 with musl. + set(LIBCXX_STANDARD_VER c++14) +endif()

r284907 - Mark P0012R1 as "Partial" since it's now substantially complete.

Author: rsmith Date: Fri Oct 21 20:35:34 2016 New Revision: 284907 URL: http://llvm.org/viewvc/llvm-project?rev=284907=rev Log: Mark P0012R1 as "Partial" since it's now substantially complete. Modified: cfe/trunk/www/cxx_status.html Modified: cfe/trunk/www/cxx_status.html URL:

r284906 - Add another testcase missed from r284905.

Author: rsmith Date: Fri Oct 21 20:32:45 2016 New Revision: 284906 URL: http://llvm.org/viewvc/llvm-project?rev=284906=rev Log: Add another testcase missed from r284905. Added: cfe/trunk/test/CXX/dcl.decl/dcl.init/dcl.init.ref/p4.cpp Added:

r284905 - [c++1z] P0012R1: Implement a few remaining pieces: downgrade diagnostic for

Author: rsmith Date: Fri Oct 21 20:32:19 2016 New Revision: 284905 URL: http://llvm.org/viewvc/llvm-project?rev=284905=rev Log: [c++1z] P0012R1: Implement a few remaining pieces: downgrade diagnostic for mismatched dynamic exception specifications in expressions from an error to a warning, since

[PATCH] D25206: [Parser] Correct typo after lambda capture initializer is parsed

ahatanak added inline comments. Comment at: lib/Parse/ParseExprCXX.cpp:951 Init = ParseInitializer(); + Init = Actions.CorrectDelayedTyposInExpr(Init.get()); mehdi_amini wrote: > What happens when there is no typo correction to apply? If

[PATCH] D25491: [libcxx] Use C++14 when building libc++ with musl

phosek added a comment. @EricWF is this fine with you? Repository: rL LLVM https://reviews.llvm.org/D25491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25809: [CUDA] Improved target attribute-based overloading.

tra updated this revision to Diff 75516. tra added a comment. removed pragma check from IdentifyCUDATarget for real. https://reviews.llvm.org/D25809 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h lib/Sema/SemaCUDA.cpp lib/Sema/SemaDecl.cpp

[PATCH] D25809: [CUDA] Improved target attribute-based overloading.

tra added inline comments. Comment at: lib/Sema/SemaCUDA.cpp:87 + + if ((HasHostAttr && HasDeviceAttr) || ForceCUDAHostDeviceDepth > 0) +return CFT_HostDevice; jlebar wrote: > Checking ForceCUDAHostDeviceDepth here is...yeah. Especially because the >

[PATCH] D25809: [CUDA] Improved target attribute-based overloading.

tra updated this revision to Diff 75515. tra marked 5 inline comments as done. tra added a comment. addressed jlebar's comments. https://reviews.llvm.org/D25809 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h lib/Sema/SemaCUDA.cpp lib/Sema/SemaDecl.cpp

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25845: [CUDA] Ignore implicit target attributes during function template instantiation.

jlebar added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:5628 case AttributeList::AT_CUDAHost: -handleSimpleAttributeWithExclusions(S, D, - Attr); +if

[PATCH] D25845: [CUDA] Ignore implicit target attributes during function template instantiation.

tra added inline comments. Comment at: include/clang/Sema/Sema.h:9396 + CUDAFunctionTarget IdentifyCUDATarget(const FunctionDecl *D, +bool IgnoreImplicitHDAttr = false); CUDAFunctionTarget IdentifyCUDATarget(const AttributeList *Attr);

[PATCH] D25206: [Parser] Correct typo after lambda capture initializer is parsed

mehdi_amini added inline comments. Comment at: lib/Parse/ParseExprCXX.cpp:951 Init = ParseInitializer(); + Init = Actions.CorrectDelayedTyposInExpr(Init.get()); What happens when there is no typo correction to apply?

[PATCH] D25845: [CUDA] Ignore implicit target attributes during function template instantiation.

tra updated this revision to Diff 75511. tra marked 5 inline comments as done. tra added a comment. addressed jlebar's comments. https://reviews.llvm.org/D25845 Files: include/clang/Sema/Sema.h lib/Sema/SemaCUDA.cpp lib/Sema/SemaDeclAttr.cpp lib/Sema/SemaTemplate.cpp

[PATCH] D25206: [Parser] Correct typo after lambda capture initializer is parsed

ahatanak added a comment. ping https://reviews.llvm.org/D25206 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25888: Add support for __builtin_os_log_format[_buffer_size]

mehdi_amini created this revision. mehdi_amini added a reviewer: bkramer. mehdi_amini added a subscriber: cfe-commits. Herald added subscribers: modocache, mgorny, beanz. These new builtins support a mechanism for logging OS events, using a printf-like format string to specify the layout of data

r284899 - Module: correctly set the module file kind when emitting file_modified.

Author: mren Date: Fri Oct 21 18:35:03 2016 New Revision: 284899 URL: http://llvm.org/viewvc/llvm-project?rev=284899=rev Log: Module: correctly set the module file kind when emitting file_modified. rdar://28503343 Differential Revision: http://reviews.llvm.org/D25806 Added:

[PATCH] D25806: Module: correctly set the module file kind when emitting diagnostics for file_modified

This revision was automatically updated to reflect the committed changes. Closed by commit rL284899: Module: correctly set the module file kind when emitting file_modified. (authored by mren). Changed prior to commit: https://reviews.llvm.org/D25806?vs=75326=75510#toc Repository: rL LLVM

[PATCH] D25882: Remove special error recovery for ::(id)

rnk updated this revision to Diff 75509. rnk added a comment. - Remove unused diagnostic https://reviews.llvm.org/D25882 Files: include/clang/Basic/DiagnosticParseKinds.td include/clang/Parse/Parser.h lib/Parse/ParseExprCXX.cpp test/Parser/colon-colon-parentheses.cpp Index:

r284897 - Module: improve the diagnostic message for include of non-modular header.

Author: mren Date: Fri Oct 21 18:27:37 2016 New Revision: 284897 URL: http://llvm.org/viewvc/llvm-project?rev=284897=rev Log: Module: improve the diagnostic message for include of non-modular header. Emit the actual path to the non-modular include. rdar://28897010 Modified:

[PATCH] D25640: [CUDA] [AST] Allow isInlineDefinitionExternallyVisible to be called on functions without bodies.

jlebar added a comment. Friendly ping. This assert breaks basically all cuda compilation on certain libstdc++ versions. If this change is wrong, I sort of urgently need to figure out the right thing. https://reviews.llvm.org/D25640 ___

r284895 - Remove unnecessary distinction between Ref_Compatible and

Author: rsmith Date: Fri Oct 21 18:01:55 2016 New Revision: 284895 URL: http://llvm.org/viewvc/llvm-project?rev=284895=rev Log: Remove unnecessary distinction between Ref_Compatible and Ref_Compatible_With_Added_Qualification. We always treated these two values the same way. Modified:

[PATCH] D25809: [CUDA] Improved target attribute-based overloading.

jlebar added inline comments. Comment at: test/SemaCUDA/function-template-overload.cu:44 +// explicitly specialize or instantiate function tempaltes. +template <> __host__ HType overload_hd(int a); +// expected-error@-1 {{no function template matches function template

[PATCH] D25882: Remove special error recovery for ::(id)

rnk added inline comments. Comment at: lib/Parse/ParseExprCXX.cpp:73-75 PP.EnterToken(ColonToken); if (!AtDigraph) PP.EnterToken(DigraphToken); rsmith wrote: > This seems to mess up the cached token buffer in the same way; it's a little > surprising

[PATCH] D25809: [CUDA] Improved target attribute-based overloading.

jlebar added inline comments. Comment at: lib/Sema/SemaCUDA.cpp:87 + + if ((HasHostAttr && HasDeviceAttr) || ForceCUDAHostDeviceDepth > 0) +return CFT_HostDevice; Checking ForceCUDAHostDeviceDepth here is...yeah. Especially because the other overload of

[clang-tools-extra] r284894 - [Release notes] Mention removed Clang-tidy misc-pointer-and-integral-operation check

Author: eugenezelenko Date: Fri Oct 21 17:35:58 2016 New Revision: 284894 URL: http://llvm.org/viewvc/llvm-project?rev=284894=rev Log: [Release notes] Mention removed Clang-tidy misc-pointer-and-integral-operation check Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified:

[PATCH] D25845: [CUDA] Ignore implicit target attributes during function template instantiation.

jlebar added inline comments. Comment at: include/clang/Sema/Sema.h:9396 + CUDAFunctionTarget IdentifyCUDATarget(const FunctionDecl *D, +bool IgnoreImplicitHDAttr = false); CUDAFunctionTarget IdentifyCUDATarget(const AttributeList

[PATCH] D25845: [CUDA] Ignore implicit target attributes during function template instantiation.

jlebar added a comment. To close the loop, we talked about this IRL, and I agree this is the most sane option we can come up with. The user-facing principle is that the signatures of function template specializations must match. We consider CUDA attributes to be part of the function's

[PATCH] D25882: Remove special error recovery for ::(id)

rsmith added a comment. Can you also remove the corresponding diagnostic? Comment at: lib/Parse/ParseExprCXX.cpp:73-75 PP.EnterToken(ColonToken); if (!AtDigraph) PP.EnterToken(DigraphToken); This seems to mess up the cached token buffer in the same

[PATCH] D25838: [Fuchsia] Support for 32-bit architectures

phosek retitled this revision from "[Fuchsia] Support for additional architectures" to "[Fuchsia] Support for 32-bit architectures". phosek updated the summary for this revision. phosek updated this revision to Diff 75496. Repository: rL LLVM https://reviews.llvm.org/D25838 Files:

r284890 - DR583, DR1512: Implement a rewrite to C++'s 'composite pointer type' rules.

Author: rsmith Date: Fri Oct 21 17:00:42 2016 New Revision: 284890 URL: http://llvm.org/viewvc/llvm-project?rev=284890=rev Log: DR583, DR1512: Implement a rewrite to C++'s 'composite pointer type' rules. This has two significant effects: 1) Direct relational comparisons between null pointer

Re: r284800 - DR583, DR1512: Implement a rewrite to C++'s 'composite pointer type' rules.

On Fri, Oct 21, 2016 at 1:13 AM, Renato Golin wrote: > On 21 October 2016 at 03:36, Richard Smith via cfe-commits > wrote: > > Author: rsmith > > Date: Thu Oct 20 21:36:37 2016 > > New Revision: 284800 > > > > URL:

[clang-tools-extra] r284888 - Remove 'misc-pointer-and-integral-operation' clang-tidy check. The only cases

Author: rsmith Date: Fri Oct 21 16:50:28 2016 New Revision: 284888 URL: http://llvm.org/viewvc/llvm-project?rev=284888=rev Log: Remove 'misc-pointer-and-integral-operation' clang-tidy check. The only cases it detects are ill-formed (some per C++ core issue 1512, others always have been).

r284887 - Switch SmallSetVector to use DenseSet when it overflows its inline space.

Author: jlebar Date: Fri Oct 21 16:45:01 2016 New Revision: 284887 URL: http://llvm.org/viewvc/llvm-project?rev=284887=rev Log: Switch SmallSetVector to use DenseSet when it overflows its inline space. Summary: SetVector already used DenseSet, but SmallSetVector used std::set. This leads to

[PATCH] D24431: CodeGen: Start using inrange annotations on vtable getelementptr.

pcc updated this revision to Diff 75494. pcc added a comment. Refresh https://reviews.llvm.org/D24431 Files: clang/lib/CodeGen/CGVTT.cpp clang/lib/CodeGen/ItaniumCXXABI.cpp clang/test/CodeGenCXX/const-init-cxx11.cpp clang/test/CodeGenCXX/constructor-init.cpp

[PATCH] D22296: CodeGen: New vtable group representation: struct of vtable arrays.

pcc updated this revision to Diff 75493. pcc added a comment. Refresh https://reviews.llvm.org/D22296 Files: clang/include/clang/AST/VTableBuilder.h clang/lib/AST/VTableBuilder.cpp clang/lib/CodeGen/CGCXX.cpp clang/lib/CodeGen/CGVTT.cpp clang/lib/CodeGen/CGVTables.cpp

[PATCH] D25876: [analyzer] Report CFNumberGetValue API misuse

zaks.anna updated this revision to Diff 75488. zaks.anna added a comment. Address comments from Devin. https://reviews.llvm.org/D25876 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/BasicObjCFoundationChecks.cpp test/Analysis/CFNumber.c Index:

[PATCH] D25876: [analyzer] Report CFNumberGetValue API misuse

dcoughlin added a comment. LGTM! https://reviews.llvm.org/D25876 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r284885 - [Sema] Store a SourceRange for multi-token builtin types

Author: malcolm.parsons Date: Fri Oct 21 16:13:56 2016 New Revision: 284885 URL: http://llvm.org/viewvc/llvm-project?rev=284885=rev Log: [Sema] Store a SourceRange for multi-token builtin types Summary: clang-tidy's modernize-use-auto check uses the SourceRange of a TypeLoc when replacing the

[PATCH] D25363: [Sema] Store a SourceRange for multi-token builtin types

This revision was automatically updated to reflect the committed changes. Closed by commit rL284885: [Sema] Store a SourceRange for multi-token builtin types (authored by malcolm.parsons). Changed prior to commit: https://reviews.llvm.org/D25363?vs=74975=75485#toc Repository: rL LLVM

[PATCH] D25845: [CUDA] Ignore implicit target attributes during function template instantiation.

tra added a comment. In https://reviews.llvm.org/D25845#576819, @jlebar wrote: > > This patch changes the way we match target attributes of base template vs > > attributes used in explicit instantiation or specialization so that only > > explicitly specified attributes are considered. > >

r284882 - [CUDA] Simplify some repeated diagnostic expectations in CUDA tests.

Author: jlebar Date: Fri Oct 21 15:50:47 2016 New Revision: 284882 URL: http://llvm.org/viewvc/llvm-project?rev=284882=rev Log: [CUDA] Simplify some repeated diagnostic expectations in CUDA tests. Instead of repeating the diagnostic, use "expected-note N". Test-only change. Modified:

[PATCH] D25845: [CUDA] Ignore implicit target attributes during function template instantiation.

tra updated this revision to Diff 75482. tra added a comment. Added a comment explaining expected constexpr function template matching behavior. https://reviews.llvm.org/D25845 Files: include/clang/Sema/Sema.h lib/Sema/SemaCUDA.cpp lib/Sema/SemaDeclAttr.cpp lib/Sema/SemaTemplate.cpp

[PATCH] D25595: [libcxx] Support std::regex_constants::match_not_null

This revision was automatically updated to reflect the committed changes. Closed by commit rL284881: [libcxx] Support std::regex_constants::match_not_null (authored by timshen). Changed prior to commit: https://reviews.llvm.org/D25595?vs=75186=75480#toc Repository: rL LLVM

[libcxx] r284881 - [libcxx] Support std::regex_constants::match_not_null

Author: timshen Date: Fri Oct 21 15:41:47 2016 New Revision: 284881 URL: http://llvm.org/viewvc/llvm-project?rev=284881=rev Log: [libcxx] Support std::regex_constants::match_not_null Summary: Fixes PR21597. Reviewers: mclow.lists, EricWF Subscribers: cfe-commits Differential Revision:

r284879 - Declare H and H new/delete.

Author: tra Date: Fri Oct 21 15:34:05 2016 New Revision: 284879 URL: http://llvm.org/viewvc/llvm-project?rev=284879=rev Log: Declare H and H new/delete. Modified: cfe/trunk/lib/Sema/SemaExprCXX.cpp cfe/trunk/test/SemaCUDA/overloaded-delete.cu Modified: cfe/trunk/lib/Sema/SemaExprCXX.cpp

[PATCH] D25845: [CUDA] Ignore implicit target attributes during function template instantiation.

jlebar added a comment. > This patch changes the way we match target attributes of base template vs > attributes used in explicit instantiation or specialization so that only > explicitly specified attributes are considered. Another question about this: When we have something inside of the

Re: r284577 - [modules] Do not report missing definitions of demoted constexpr variable templates.

On 21/10/16 00:19, Manman wrote: On Oct 19, 2016, at 4:19 AM, Vassil Vassilev via cfe-commits wrote: Author: vvassilev Date: Wed Oct 19 06:19:30 2016 New Revision: 284577 URL: http://llvm.org/viewvc/llvm-project?rev=284577=rev Log: [modules] Do not report missing

r284877 - Remove accidentally checked in assert.

Author: vvassilev Date: Fri Oct 21 15:30:30 2016 New Revision: 284877 URL: http://llvm.org/viewvc/llvm-project?rev=284877=rev Log: Remove accidentally checked in assert. Thanks to Manman for spotting this. Modified: cfe/trunk/lib/Sema/SemaDecl.cpp Modified: cfe/trunk/lib/Sema/SemaDecl.cpp

[PATCH] D25647: [clang-tidy] Don't use a SmallSetVector of an enum.

jlebar added a comment. Thank you for the reviews, everyone! Repository: rL LLVM https://reviews.llvm.org/D25647 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r284873 - [clang-tidy] Don't use a SmallSetVector of an enum.

Author: jlebar Date: Fri Oct 21 15:13:39 2016 New Revision: 284873 URL: http://llvm.org/viewvc/llvm-project?rev=284873=rev Log: [clang-tidy] Don't use a SmallSetVector of an enum. Summary: This doesn't work after converting SmallSetVector to use DenseSet. Instead we can just use a SmallVector.

[PATCH] D25647: [clang-tidy] Don't use a SmallSetVector of an enum.

This revision was automatically updated to reflect the committed changes. Closed by commit rL284873: [clang-tidy] Don't use a SmallSetVector of an enum. (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D25647?vs=75443=75478#toc Repository: rL LLVM

[PATCH] D25797: [CUDA] Use FunctionDeclAndLoc for the Sema::LocsWithCUDACallDiags hashtable.

This revision was automatically updated to reflect the committed changes. Closed by commit rL284869: [CUDA] Use FunctionDeclAndLoc for the Sema::LocsWithCUDACallDiags hashtable. (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D25797?vs=75231=75474#toc Repository: rL

r284869 - [CUDA] Use FunctionDeclAndLoc for the Sema::LocsWithCUDACallDiags hashtable.

Author: jlebar Date: Fri Oct 21 15:08:52 2016 New Revision: 284869 URL: http://llvm.org/viewvc/llvm-project?rev=284869=rev Log: [CUDA] Use FunctionDeclAndLoc for the Sema::LocsWithCUDACallDiags hashtable. Summary: NFC Reviewers: rnk Subscribers: cfe-commits Differential Revision:

[PATCH] D25876: [analyzer] Report CFNumberGetValue API misuse

dcoughlin added inline comments. Comment at: test/Analysis/CFNumber.c:39 + unsigned char scalar = 0; + CFNumberGetValue(x, kCFNumberSInt16Type, ); // expected-warning{{A CFNumber object that represents a 16 bit integer is used to initialize an 8 bit integer. 8 bits of the

[PATCH] D25796: [CUDA] Create __host__ and device variants of standard allocator declarations.

jlebar accepted this revision. jlebar added inline comments. This revision is now accepted and ready to land. Comment at: lib/Sema/SemaExprCXX.cpp:2596 - QualType FnType = Context.getFunctionType(Return, Params, EPI); - FunctionDecl *Alloc = -

Re: [PATCH] D25199: [ubsan] Sanitize deleted pointers

On Tue, Oct 4, 2016 at 11:43 AM, Matt Gingell wrote: > Hi Richard, > > Thanks for your analysis. > > This patch is intended to mitigate use-after-free bugs. In that context a > “define strict behavior for invalid pointer values” we could deploy in > production code would be

r284856 - Remove move constructors that are identical to the generated default move ctor.

Author: d0k Date: Fri Oct 21 13:55:07 2016 New Revision: 284856 URL: http://llvm.org/viewvc/llvm-project?rev=284856=rev Log: Remove move constructors that are identical to the generated default move ctor. Modified: cfe/trunk/include/clang/Analysis/Analyses/Consumed.h

[PATCH] D25876: [analyzer] Report CFNumberGetValue API misuse

zaks.anna created this revision. zaks.anna added reviewers: dcoughlin, NoQ. zaks.anna added subscribers: cfe-commits, rgov. This patch contains 2 improvements to the CFNumber checker: - Checking of CFNumberGetValue misuse. - Treating all CFNumber API misuse errors as non-fatal. (Previously we

[PATCH] D25845: [CUDA] Ignore implicit target attributes during function template instantiation.

jlebar added inline comments. Comment at: test/SemaCUDA/function-template-overload.cu:62 +template constexpr T overload_ce_implicit_hd(T a) { return a+1; } +// expected-note@-1 3 {{candidate template ignored: target attributes do not match}} + Oh, I didn't

[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

rSerge updated this revision to Diff 75452. rSerge added a comment. I had to add the root directories `a` and `b` manually, as I couldn't find an `svn diff` argument for that. The code file `Tools.cpp` was run via `clang-format`, then just my changes were copy-pasted. 2 tests have been added to

Re: r284815 - Remove non-existing file from modulemap.

Thanks Ben! On Fri, Oct 21, 2016 at 3:19 AM, Benjamin Kramer via cfe-commits wrote: > Author: d0k > Date: Fri Oct 21 05:19:37 2016 > New Revision: 284815 > > URL: http://llvm.org/viewvc/llvm-project?rev=284815=rev > Log: > Remove non-existing file from modulemap. > >

[PATCH] D20811: [analyzer] Model some library functions

dcoughlin accepted this revision. dcoughlin added a comment. This looks great! Comment at: lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:694 +INVALIDATION_APPROACH(EvalCallAsPure)) + CASE // Is certainly uppercase. +

[PATCH] D25579: [codeview] emit debug info for indirect virtual base classes

inglorion added a comment. We also need https://reviews.llvm.org/D25578 in before this can land. https://reviews.llvm.org/D25579 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25839: Removed unused function argument. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rL284843: Removed unused function argument. NFC. (authored by tra). Changed prior to commit: https://reviews.llvm.org/D25839?vs=75339=75447#toc Repository: rL LLVM https://reviews.llvm.org/D25839

r284843 - Removed unused function argument. NFC.

Author: tra Date: Fri Oct 21 12:15:46 2016 New Revision: 284843 URL: http://llvm.org/viewvc/llvm-project?rev=284843=rev Log: Removed unused function argument. NFC. Differential Revision: https://reviews.llvm.org/D25839 Modified: cfe/trunk/include/clang/Sema/Sema.h

[PATCH] D20811: [analyzer] Model some library functions

NoQ updated this revision to Diff 75446. NoQ added a comment. Herald added a subscriber: modocache. Update the domain-specific language for function specs/summaries. https://reviews.llvm.org/D20811 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td

[PATCH] D25731: [analyzer] NumberObjectConversion: Support OSNumber and CFNumberRef.

zaks.anna added inline comments. Comment at: test/Analysis/number-object-conversion.c:14 + if (p) {} // expected-warning{{Converting 'CFNumberRef' to a plain boolean value for branching; please compare the pointer to NULL instead to suppress this warning}} + if (!p) {} //

[PATCH] D25866: [Sema] Support implicit scalar to vector conversions

ahatanak added inline comments. Comment at: lib/Sema/SemaExpr.cpp:8044 // the vector element type and splat. - // FIXME: this should also work for regular vector types as supported in GCC. - if (!RHSVecType && isa(LHSVecType)) { + if (!RHSVecType && isa(LHSVecType)) {

[PATCH] D25796: [CUDA] Create __host__ and device variants of standard allocator declarations.

jlebar added inline comments. Comment at: lib/Sema/SemaExprCXX.cpp:2596 - QualType FnType = Context.getFunctionType(Return, Params, EPI); - FunctionDecl *Alloc = -FunctionDecl::Create(Context, GlobalCtx, SourceLocation(), - SourceLocation(), Name,

[PATCH] D25866: [Sema] Support implicit scalar to vector conversions

ahatanak added inline comments. Comment at: lib/Sema/SemaExpr.cpp:8044 // the vector element type and splat. - // FIXME: this should also work for regular vector types as supported in GCC. - if (!RHSVecType && isa(LHSVecType)) { + if (!RHSVecType && isa(LHSVecType)) {

[PATCH] D25844: [Sema][ObjC] Warn about implicitly autoreleasing indirect parameters that are captured by blocks

ahatanak updated this revision to Diff 75442. ahatanak marked an inline comment as done. ahatanak added a comment. Improve warning messages. https://reviews.llvm.org/D25844 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaExpr.cpp

[PATCH] D25647: [clang-tidy] Don't use a SmallSetVector of an enum.

jlebar added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp:103 + auto = ClassWithSpecialMembers[ID]; + if (find(Members, Kind) == Members.end()) Members.push_back(Kind); +} jlebar

[PATCH] D25647: [clang-tidy] Don't use a SmallSetVector of an enum.

jlebar updated this revision to Diff 75443. jlebar marked 5 inline comments as done. jlebar added a comment. Adjust formatting, write out type of 'auto'. https://reviews.llvm.org/D25647 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp

r284836 - Remove unnecessary x86 backend requirements from OpenMP tests

Author: rnk Date: Fri Oct 21 11:09:20 2016 New Revision: 284836 URL: http://llvm.org/viewvc/llvm-project?rev=284836=rev Log: Remove unnecessary x86 backend requirements from OpenMP tests Clang can generate LLVM IR for x86 without a registered x86 backend. Modified:

[PATCH] D23765: Fix for clang PR 29087

twoh updated this revision to Diff 75441. twoh marked an inline comment as done. twoh added a comment. Addressing comments from @sepavloff. Thanks! https://reviews.llvm.org/D23765 Files: lib/Sema/SemaExprCXX.cpp test/SemaCXX/cxx11-crashes.cpp Index: test/SemaCXX/cxx11-crashes.cpp

[PATCH] D25647: [clang-tidy] Don't use a SmallSetVector of an enum.

jlebar added a comment. Thank you very much for the review! Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp:103 + auto = ClassWithSpecialMembers[ID]; + if (find(Members, Kind) == Members.end()) Members.push_back(Kind); +

[PATCH] D25647: [clang-tidy] Don't use a SmallSetVector of an enum.

jlebar added a comment. Thank you very much for the review! Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp:103 + auto = ClassWithSpecialMembers[ID]; + if (find(Members, Kind) == Members.end()) Members.push_back(Kind); +

[PATCH] D25647: [clang-tidy] Don't use a SmallSetVector of an enum.

bkramer added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp:103 + auto = ClassWithSpecialMembers[ID]; + if (find(Members, Kind) == Members.end()) Members.push_back(Kind); +} jlebar

[PATCH] D25647: [clang-tidy] Don't use a SmallSetVector of an enum.

jlebar added a comment. Hi, friendly ping? This trivial patch is the only blocker remaining before I can land https://reviews.llvm.org/D25648, which is the first part of my Grand Set Refactoring (see mail to llvm-dev about a week ago). Repository: rL LLVM https://reviews.llvm.org/D25647

[PATCH] D25647: [clang-tidy] Don't use a SmallSetVector of an enum.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with two minor nits. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp:102 + SpecialMemberFunctionKind Kind

[PATCH] D25796: [CUDA] Create __host__ and device variants of standard allocator declarations.

jlebar added a comment. Is it not possible to write a testcase for this? https://reviews.llvm.org/D25796 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25363: [Sema] Store a SourceRange for multi-token builtin types

aaron.ballman added inline comments. Comment at: include/clang/AST/TypeLoc.h:533 +} else { + BuiltinRange.setBegin(std::min(Range.getBegin(), BuiltinRange.getBegin())); + BuiltinRange.setEnd(std::max(Range.getEnd(), BuiltinRange.getEnd()));

[PATCH] D25363: [Sema] Store a SourceRange for multi-token builtin types

malcolm.parsons added inline comments. Comment at: include/clang/AST/TypeLoc.h:533 +} else { + BuiltinRange.setBegin(std::min(Range.getBegin(), BuiltinRange.getBegin())); + BuiltinRange.setEnd(std::max(Range.getEnd(), BuiltinRange.getEnd()));

[PATCH] D25820: [Sema][Objective-C] Formatting warnings should see through Objective-C message sends

aaron.ballman accepted this revision. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Repository: rL LLVM https://reviews.llvm.org/D25820 ___

[PATCH] D25450: [clang-tidy] Fix identifier naming in macro args.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! https://reviews.llvm.org/D25450 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25450: [clang-tidy] Fix identifier naming in macro args.

jhen marked an inline comment as done. jhen added inline comments. Comment at: clang-tidy/readability/IdentifierNamingCheck.cpp:654 + RangeIsEntirelyWithinMacroArgument || !RangeContainsMacroExpansion; + Failure.ShouldFix = Failure.ShouldFix && RangeCanBeFixed; }

[PATCH] D25450: [clang-tidy] Fix identifier naming in macro args.

jhen updated this revision to Diff 75430. jhen added a comment. - Early exit if not Failure.ShouldFix https://reviews.llvm.org/D25450 Files: clang-tidy/readability/IdentifierNamingCheck.cpp test/clang-tidy/readability-identifier-naming.cpp Index:

[PATCH] D25871: Include full filename range for missing includes

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D25871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25870: Fix 'unknown documentation command' warning ranges

erikjv created this revision. erikjv added reviewers: bkramer, klimek. erikjv added a subscriber: cfe-commits. Warnings generated by -Wdocumentation-unknown-command did only have a start location, not a full source range. This resulted in only the "carret" being show in messages, and IDEs

[PATCH] D25870: Fix 'unknown documentation command' warning ranges

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Nice. Thanks! https://reviews.llvm.org/D25870 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25871: Include full filename range for missing includes

erikjv created this revision. erikjv added reviewers: bkramer, klimek. erikjv added a subscriber: cfe-commits. For the purpose of highlighting in an IDE. https://reviews.llvm.org/D25871 Files: lib/Lex/PPDirectives.cpp test/Preprocessor/missing-include-range-check.h Index:

[PATCH] D25311: Add FixItHint for missing #include (err_module_unimported_use_header)

bkramer added a comment. In https://reviews.llvm.org/D25311#574806, @bruno wrote: > I don't know the history behind the desired dependencies, I'll let others > comment whether this is OK, but my guess it that it depends on the tradeoff, > it's hard to justify 3 new deps for a change that is

[PATCH] D25869: [Driver] Add unit tests for DetectDistro()

mgorny created this revision. mgorny added reviewers: bruno, bkramer, rafael. mgorny added a subscriber: cfe-commits. Herald added a subscriber: beanz. Add a set of unit tests for the DetectDistro() function in Driver. Make the function itself (and the enum) visible in the library for the tests.

[PATCH] D25311: Add FixItHint for missing #include (err_module_unimported_use_header)

sammccall added a comment. > I don't know the history behind the desired dependencies, I'll let others > comment whether this is OK, but my guess it that it depends on the tradeoff, > it's hard to justify 3 new deps for a change that is supposed to be simple. > How hard is to implement this

  1   2   >