zaks.anna added a comment.
Hi and welcome to the project!
This patch definitely looks quite complex for a first contribution, so great
job at digging through the analyzer internals!
One higher level comment I have is that you should try and split patches
whenever possible. For example, in the
phosek updated this revision to Diff 77950.
Repository:
rL LLVM
https://reviews.llvm.org/D26649
Files:
CMakeLists.txt
Index: CMakeLists.txt
===
--- CMakeLists.txt
+++ CMakeLists.txt
@@ -511,10 +511,10 @@
set(STAMP_DIR ${CMA
mehdi_amini added a comment.
In https://reviews.llvm.org/D26649#595429, @phosek wrote:
> AFAIK lld on Darwin doesn't support LTO (last I heard it cannot even
> self-host at the moment) so I'm not sure if it makes sense to enable it
> `if(APPLE)`.
OK, we could error instead of ignoring then.
B
phosek added a comment.
AFAIK lld on Darwin doesn't support LTO (last I heard it cannot even self-host
at the moment) so I'm not sure if it makes sense to enable it `if(APPLE)`.
Repository:
rL LLVM
https://reviews.llvm.org/D26649
___
cfe-commits
mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
Comment at: lib/CodeGen/BackendUtil.cpp:422
// Set up the per-function pass manager.
+ FPM.add(new TargetLibraryInfoWrapperPass(*TLII));
if (Co
Author: marshall
Date: Mon Nov 14 23:03:22 2016
New Revision: 286932
URL: http://llvm.org/viewvc/llvm-project?rev=286932&view=rev
Log:
Missed one of the try blocks the first time :-(. Thanks to Renato for the heads
up.
Modified:
libcxx/trunk/test/std/strings/basic.string/string.cons/T_size_s
mehdi_amini added a comment.
What about the following logic?
if(BOOTSTRAP_LLVM_ENABLE_LLD)
add_dependencies(clang-bootstrap-deps lld)
endif()
if(APPLE)
# on Darwin we need to set DARWIN_LTO_LIBRARY so that -flto will work
# using the just-built compiler, and we need t
mehdi_amini requested changes to this revision.
mehdi_amini added inline comments.
This revision now requires changes to proceed.
Comment at: CMakeLists.txt:516
if(BOOTSTRAP_LLVM_ENABLE_LTO OR LLVM_ENABLE_LTO AND NOT
LLVM_BUILD_INSTRUMENTED)
-add_dependencies(clang-bootst
krasin added inline comments.
Comment at: lib/CodeGen/CGExprCXX.cpp:93
+
+ EmitTypeCheck(CodeGenFunction::TCK_MemberCall,
+CallLoc, This, C.getRecordType(DD->getParent()));
pcc wrote:
> krasin wrote:
> > pcc wrote:
> > > pcc wrote:
> > > > Is it
mehdi_amini accepted this revision.
mehdi_amini added a reviewer: mehdi_amini.
mehdi_amini added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rL LLVM
https://reviews.llvm.org/D26649
___
cfe-commits mailing list
cf
krasin updated this revision to Diff 77941.
krasin added a comment.
Do better job with destructors.
https://reviews.llvm.org/D26559
Files:
lib/CodeGen/CGExprCXX.cpp
lib/CodeGen/MicrosoftCXXABI.cpp
test/CodeGenCXX/ubsan-vtable-checks.cpp
Index: test/CodeGenCXX/ubsan-vtable-checks.cpp
NoQ added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h:735
+ const FunctionDecl *FunctionDecl = SFC->getDecl()->getAsFunction();
+ unsigned NumArgs = FunctionDecl->getNumParams();
+ assert(ArgIdx < NumArgs && "Arg access out of ra
smeenai created this revision.
smeenai added reviewers: compnerd, hans.
smeenai added a subscriber: cfe-commits.
On MSVC, if an implicit instantiation already exists and an explicit
instantiation definition with a DLL attribute is created, the DLL
attribute still takes effect. Make clang match thi
sfertile added inline comments.
Comment at: lib/Headers/altivec.h:11908
+#define vec_extract4b(__a, __b)
\
+ vec_reve((vector unsigned long long)
\
+__builtin_vsx_xxextractuw
phosek added a comment.
In https://reviews.llvm.org/D26649#595367, @mehdi_amini wrote:
> OK, but still, LLVM_ENABLE_LLD needs to be passed to stage-2, so it needs to
> be actually BOOTSTRAP_LLVM_ENABLE_LLD.
> I looked at all the CMake `_PASSTHROUGH` and didn't find it mentioned
> anywhere. We
phosek updated this revision to Diff 77938.
phosek marked an inline comment as done.
Repository:
rL LLVM
https://reviews.llvm.org/D26649
Files:
CMakeLists.txt
Index: CMakeLists.txt
===
--- CMakeLists.txt
+++ CMakeLists.txt
@@
mehdi_amini added a comment.
In https://reviews.llvm.org/D26649#595361, @phosek wrote:
> In https://reviews.llvm.org/D26649#595356, @mehdi_amini wrote:
>
> > In https://reviews.llvm.org/D26649#595296, @phosek wrote:
> >
> > > It's sufficient, I just tested it.
> >
> >
> > How did you check it? I
phosek added a comment.
In https://reviews.llvm.org/D26649#595356, @mehdi_amini wrote:
> In https://reviews.llvm.org/D26649#595296, @phosek wrote:
>
> > It's sufficient, I just tested it.
>
>
> How did you check it? I don't understand how LLVM_ENABLE_LLD is propagated to
> stage-2?
Sufficient
mehdi_amini added a comment.
In https://reviews.llvm.org/D26649#595296, @phosek wrote:
> It's sufficient, I just tested it.
How did you check it? I don't understand how LLVM_ENABLE_LLD is propagated to
stage-2?
Comment at: CMakeLists.txt:534
+add_dependencies(LLVMgo
Eugene.Zelenko added a comment.
Yes, you are correct, I meant later.
Repository:
rL LLVM
https://reviews.llvm.org/D26649
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mehdi_amini added a comment.
In https://reviews.llvm.org/D26649#595334, @Eugene.Zelenko wrote:
> I meant that multi-stage build is processed by higher level script. So it
> should take care about consistency of source code srt versus later stages
> build options.
We have a 2-stage build direc
Eugene.Zelenko added a comment.
I meant that multi-stage build is processed by higher level script. So it
should take care about consistency of source code srt versus later stages build
options.
Repository:
rL LLVM
https://reviews.llvm.org/D26649
_
mehdi_amini added a comment.
In https://reviews.llvm.org/D26649#595301, @Eugene.Zelenko wrote:
> I think this should be handled in higher level script
> (utils/release/test-release.sh or similar), not in CMake. CMake compiler
> tests just need to fail when LLVM_ENABLE_LLD is used without actual
Author: ddcc
Date: Mon Nov 14 19:54:41 2016
New Revision: 286927
URL: http://llvm.org/viewvc/llvm-project?rev=286927&view=rev
Log:
[analyzer] Rename assumeWithinInclusiveRange*()
Summary: The name is slightly confusing, since the constraint is not
necessarily within the range unless `Assumption`
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286927: [analyzer] Rename assumeWithinInclusiveRange*()
(authored by ddcc).
Changed prior to commit:
https://reviews.llvm.org/D26644?vs=77930&id=77933#toc
Repository:
rL LLVM
https://reviews.llvm.or
ddcc updated this revision to Diff 77930.
ddcc added a comment.
Fix formatting
https://reviews.llvm.org/D26644
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintManager.h
include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h
lib/StaticAnalyzer/Checkers/StdLibraryFu
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286925: [analyzer] Minor optimization: avoid setting state
if unchanged (authored by ddcc).
Changed prior to commit:
https://reviews.llvm.org/D26642?vs=77897&id=77929#toc
Repository:
rL LLVM
https:/
Author: ddcc
Date: Mon Nov 14 19:40:58 2016
New Revision: 286925
URL: http://llvm.org/viewvc/llvm-project?rev=286925&view=rev
Log:
[analyzer] Minor optimization: avoid setting state if unchanged
Summary: Split out optimization from D26061
Reviewers: zaks.anna, dcoughlin
Subscribers: cfe-commits
Eugene.Zelenko added a comment.
I think this should be handled in higher level script
(utils/release/test-release.sh or similar), not in CMake. CMake compiler tests
just need to fail when LLVM_ENABLE_LLD is used without actually having them.
Repository:
rL LLVM
https://reviews.llvm.org/D266
mehdi_amini added a comment.
In https://reviews.llvm.org/D26649#595296, @phosek wrote:
> It's sufficient, I just tested it. I'm not actually sure if `LLVM_ENABLE_LLD`
> here is correct, `LLVM_ENABLE_LLD` forces the use of lld, but lld might not
> be available during first stage. We need `LLVM_E
phosek added a comment.
It's sufficient, I just tested it. I'm not actually sure if `LLVM_ENABLE_LLD`
here is correct, `LLVM_ENABLE_LLD` forces the use of lld, but lld might not be
available during first stage. We need `LLVM_ENABLE_LLD` to be set, but only for
the second stage (which is somethi
spyffe added a reviewer: beanz.
spyffe updated this revision to Diff 77928.
spyffe added a comment.
Updated the locations so the structure is now
a/test.c
a/Inputs/a1.c
a/Inputs/a2.c
The naming of "test.c" is no longer a requirement but only a convention. Also
`lit.site.cfg` is no longer
Eugene.Zelenko added a comment.
In https://reviews.llvm.org/D26649#595213, @mehdi_amini wrote:
> Make sense to me, but I don't think it is enough: LLVM_ENABLE_LLD should be
> passed to stage-2, and it also should be set to the absolute path of the
> stage-1 lld build.
What is search directori
faisalv updated this revision to Diff 77926.
faisalv marked an inline comment as done.
faisalv added a comment.
Simplify the check for zero captures in a lambda expression (within the assert)
by comparing the begin and end pointers directly (as opposed to using distance)
- thanks to Akira!
htt
dtarditi added a comment.
I sync'ed to the head of the tree. I tried to reproduce the failures that you
saw and couldn't.I'm building on Windows 10 x64 using Visual Studio. What
platform/OS did you build on? I built and test both Debug and RelWithDebugInfo.
Here's what I saw for RelWithD
phosek created this revision.
phosek added a reviewer: beanz.
phosek added a subscriber: cfe-commits.
phosek set the repository for this revision to rL LLVM.
Herald added a subscriber: mgorny.
These cache files can be used to build Fuchsia Clang toolchain. They also
demonstrate the use of multi-t
mehdi_amini added inline comments.
Comment at: CMakeLists.txt:516
if(BOOTSTRAP_LLVM_ENABLE_LTO OR LLVM_ENABLE_LTO AND NOT
LLVM_BUILD_INSTRUMENTED)
add_dependencies(clang-bootstrap-deps LTO)
if(APPLE)
This dep does not make sense when using either ll
mehdi_amini added a comment.
Make sense to me, but I don't think it is enough: LLVM_ENABLE_LLD should be
passed to stage-2, and it also should be set to the absolute path of the
stage-1 lld build.
Repository:
rL LLVM
https://reviews.llvm.org/D26649
___
phosek created this revision.
phosek added a reviewer: beanz.
phosek added subscribers: cfe-commits, ruiu.
phosek set the repository for this revision to rL LLVM.
Herald added subscribers: mehdi_amini, mgorny.
lld has LTO support, if requested we should add a dependency on lld rather than
LLVMgol
manmanren added a comment.
In https://reviews.llvm.org/D25916#594844, @benlangmuir wrote:
> > Does it mean that a system module should only import system modules? If a
> > system module is allowed to import non-system modules, for a non-system
> > module, we will validate diagnostic options dif
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
LGTM. Please commit!
https://reviews.llvm.org/D26642
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
LGTM, other then some indentation issues for arguments and parameters after the
rename. Please fix those and commit! And thanks for splitting this up.
Comment at:
inc
ddcc created this revision.
ddcc added reviewers: zaks.anna, dcoughlin.
ddcc added a subscriber: cfe-commits.
The name is slightly confusing, since the constraint is not necessarily within
the range unless `Assumption` is true. Split out renaming for
ConstraintManager.h from https://reviews.llvm
ddcc created this revision.
ddcc added reviewers: zaks.anna, dcoughlin.
ddcc added a subscriber: cfe-commits.
Split out optimization from https://reviews.llvm.org/D26061
https://reviews.llvm.org/D26642
Files:
lib/StaticAnalyzer/Core/RangeConstraintManager.cpp
Index: lib/StaticAnalyzer/Core/
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
LGTM!
Comment at: test/lit.cfg:109
+if not llvm_shlib_dir:
+lit_config.fatal('No LLVM shlib dir set!')
llvm_libs_dir = getattr(config, 'llvm_libs_dir', None)
-
Author: dcoughlin
Date: Mon Nov 14 16:46:02 2016
New Revision: 286901
URL: http://llvm.org/viewvc/llvm-project?rev=286901&view=rev
Log:
[analyzer] Fix crash in NullabilityChecker calling block with too few arguments
Fix a crash when checking parameter nullability on a block invocation
with fewer
Author: kuba.brecka
Date: Mon Nov 14 16:38:57 2016
New Revision: 286898
URL: http://llvm.org/viewvc/llvm-project?rev=286898&view=rev
Log:
[sanitizer] Passthrough CMAKE_OSX_DEPLOYMENT_TARGET when building compiler-rt
from clang/runtime/CMakeLists.txt
This breaks some Swift builds, because Swift's
Reverting this commit doesn't solve anything, sorry for the noise.
It seems to hit an infinite loop:
frame #17: 0x0001083d48ab clang`::Visit() [inlined]
HandleConditionalOperator + 165 at
ExprConstant.cpp:4212
frame #18: 0x0001083d4806 clang`::Visit() [inlined]
VisitConditional
pcc added inline comments.
Comment at: lib/CodeGen/CGExprCXX.cpp:93
+
+ EmitTypeCheck(CodeGenFunction::TCK_MemberCall,
+CallLoc, This, C.getRecordType(DD->getParent()));
krasin wrote:
> pcc wrote:
> > pcc wrote:
> > > Is it correct to emit a type
krasin added inline comments.
Comment at: lib/CodeGen/CGExprCXX.cpp:93
+
+ EmitTypeCheck(CodeGenFunction::TCK_MemberCall,
+CallLoc, This, C.getRecordType(DD->getParent()));
pcc wrote:
> pcc wrote:
> > Is it correct to emit a type check at this po
mgorny added inline comments.
Comment at: test/lit.cfg:109
+if not llvm_shlib_dir:
+lit_config.fatal('No LLVM shlib dir set!')
llvm_libs_dir = getattr(config, 'llvm_libs_dir', None)
beanz wrote:
> Should this really be fatal? It seems to me in ma
Hi Faisal,
Our ASan bot started complaining after this commit.
I'm not 100% sure this caused it yet, though I'm running tests.
Could you take a look?
thanks,
vedant
FAIL: Clang :: SemaCXX/constant-expression-cxx11.cpp (9393 of 29261)
TEST 'Clang :: SemaCXX/constant-expre
beanz added inline comments.
Comment at: test/lit.cfg:109
+if not llvm_shlib_dir:
+lit_config.fatal('No LLVM shlib dir set!')
llvm_libs_dir = getattr(config, 'llvm_libs_dir', None)
Should this really be fatal? It seems to me in many cases you mig
benlangmuir added a comment.
> Does it mean that a system module should only import system modules? If a
> system module is allowed to import non-system modules, for a non-system
> module, we will validate diagnostic options differently depending on whether
> a system module or a non-system mod
ahatanak added a comment.
Are there any further comments?
https://reviews.llvm.org/D25206
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ahatanak added inline comments.
Comment at: lib/AST/ExprConstant.cpp:4427
+const CXXRecordDecl *ClosureClass = MD->getParent();
+assert((std::distance(ClosureClass->captures_begin(),
+ ClosureClass->captures_end()) == 0) &&
---
Author: marshall
Date: Mon Nov 14 14:41:17 2016
New Revision: 286884
URL: http://llvm.org/viewvc/llvm-project?rev=286884&view=rev
Log:
P0503R0, adopted in Issaquah, rewords some requirements on nullptr_t and
istream_iterator. No code changes were needed, but I updated a few tests. Also
resolved
krasin updated this revision to Diff 77868.
krasin added a comment.
Add a regression test.
https://reviews.llvm.org/D26559
Files:
lib/CodeGen/CGExprCXX.cpp
test/CodeGenCXX/ubsan-null.cpp
Index: test/CodeGenCXX/ubsan-null.cpp
Author: marshall
Date: Mon Nov 14 14:38:43 2016
New Revision: 286883
URL: http://llvm.org/viewvc/llvm-project?rev=286883&view=rev
Log:
Missed a test with exceptions disabled earlier. Oops.
Modified:
libcxx/trunk/test/std/strings/basic.string/string.cons/T_size_size.pass.cpp
Modified:
libcxx
pcc added inline comments.
Comment at: lib/CodeGen/CGExprCXX.cpp:93
+
+ EmitTypeCheck(CodeGenFunction::TCK_MemberCall,
+CallLoc, This, C.getRecordType(DD->getParent()));
pcc wrote:
> Is it correct to emit a type check at this point? Looking at [0
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] Fix ordering assumptions in unordered container tests.
https://reviews.llvm.org/D26627
Files:
test/std/containers/unord/unord.multimap/unord.multimap.modif
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] Swapping non-equal non-POCS allocators is UB.
test_allocator is a non-POCS allocator. Instead of swapping containers
with A(1) and A(2), which triggers undefine
manmanren added a comment.
@ Ben,
We are hitting this issue when building large projects, but the reproducibility
is quite low.
This proposed patch is currently a little too complicated. I am thinking about
just fixing the testing case for now, and adding the check later when we start
to shar
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] Fix an improper assumption about Null Forward Iterators.
Value-initialized iterators still can't be compared to those with parents.
https://reviews.llvm.org/D
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] future_error::what() is implementation-defined.
https://reviews.llvm.org/D26625
Files:
test/std/thread/futures/futures.future_error/what.pass.cpp
Index: t
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] Fix bucket_count() assumptions.
With a max_load_factor of 1.0, the only guarantee is that
bucket_count() >= size(). (Note: setting max_load_factor without
rehas
This revision was automatically updated to reflect the committed changes.
ioeric marked an inline comment as done.
Closed by commit rL286873: [change-namespace] consider typedef/using alias
decls in the moved namespace. (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D26
Author: ioeric
Date: Mon Nov 14 13:37:55 2016
New Revision: 286873
URL: http://llvm.org/viewvc/llvm-project?rev=286873&view=rev
Log:
[change-namespace] consider typedef/using alias decls in the moved namespace.
Summary: If a TypeLoc refers to a type alias defined in the moved namespace, we
do no
Author: marshall
Date: Mon Nov 14 13:35:34 2016
New Revision: 286872
URL: http://llvm.org/viewvc/llvm-project?rev=286872&view=rev
Log:
Make one of the new tests fail correctly on pre-C++17 systems
Modified:
libcxx/trunk/test/std/utilities/memory/specialized.algorithms/specialized.addressof/a
NoQ added a comment.
Thank you for working on this! The overall approach is good. Because alpha
checkers are disabled by default, false positives can be addressed later in
subsequent commits.
Comment at: lib/StaticAnalyzer/Checkers/RecursionChecker.cpp:2
+// InfiniteRecursion
NoQ added a comment.
Welcome to phabricator! I agree that having the location context in this
callback is useful, and i'm all for reducing boilerplate in various checkers
through better API.
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h:231
P
Author: marshall
Date: Mon Nov 14 12:56:24 2016
New Revision: 286864
URL: http://llvm.org/viewvc/llvm-project?rev=286864&view=rev
Log:
Implement P0510 'Make future_error Constructible' adopted in Issaquah
Modified:
libcxx/trunk/include/future
libcxx/trunk/test/std/thread/futures/futures.f
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286863: [PPC] altivec.h functions for converting half
precision to single precision. (authored by sfertile).
Changed prior to commit:
https://reviews.llvm.org/D26534?vs=77581&id=77842#toc
Repository:
Author: sfertile
Date: Mon Nov 14 12:47:15 2016
New Revision: 286863
URL: http://llvm.org/viewvc/llvm-project?rev=286863&view=rev
Log:
[PPC] altivec.h functions for converting half precision to single precision.
Adds 2 vector functions for converting from a vector of unsigned short to a
vector of
Author: marshall
Date: Mon Nov 14 12:22:19 2016
New Revision: 286858
URL: http://llvm.org/viewvc/llvm-project?rev=286858&view=rev
Log:
Fixes for LWG 2598, 2686, 2739, 2742, 2747, and 2759, which were adopted last
week in Issaquah
Added:
libcxx/trunk/test/std/diagnostics/syserr/syserr.hash/e
Author: stulova
Date: Mon Nov 14 12:11:09 2016
New Revision: 286856
URL: http://llvm.org/viewvc/llvm-project?rev=286856&view=rev
Log:
Fix OpenCL test for buildbot by removing extra (erroneous) RUN line
Modified:
cfe/trunk/test/SemaOpenCL/cl20-device-side-enqueue.cl
Modified: cfe/trunk/test/
Anastasia closed this revision.
Anastasia added a comment.
Committed in r286849.
https://reviews.llvm.org/D26509
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: stulova
Date: Mon Nov 14 11:39:58 2016
New Revision: 286849
URL: http://llvm.org/viewvc/llvm-project?rev=286849&view=rev
Log:
[OpenCL] Fix for integer parameters of enqueue_kernel
Make handling integer parameters more flexible:
- For the number of events argument allow to pass larger
int
a.sidorin added a comment.
Hi Krzysztof!
This change seems useful: I can imagine the situation where we want to ask
current `LocationContext` in this callback. The change looks pretty intrusive
but I mostly agree with it. Initially, I have some questions about the
implementation of `getArgSVal
STL_MSFT closed this revision.
STL_MSFT added a comment.
Checked in as r286847.
https://reviews.llvm.org/D26314
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: stl_msft
Date: Mon Nov 14 11:35:14 2016
New Revision: 286847
URL: http://llvm.org/viewvc/llvm-project?rev=286847&view=rev
Log:
[libcxx] [test] D26314: Fix MSVC warning C4189 "local variable is initialized
but not referenced".
test/std/depr/depr.c.headers/inttypes_h.pass.cpp
test/std/inpu
Author: mgrang
Date: Mon Nov 14 11:31:24 2016
New Revision: 286846
URL: http://llvm.org/viewvc/llvm-project?rev=286846&view=rev
Log:
[clang docs] Minor fix in ClangCheck.rst
Reviewers: djasper, rengolin
Subscribers: Eugene.Zelenko
Tags: #clang-c
Differential Revision: https://reviews.llvm.org/
Anastasia updated the summary for this revision.
Anastasia updated this revision to Diff 77825.
Anastasia added a comment.
1. Corrected typos in CodeGen test.
2. Improved description.
https://reviews.llvm.org/D26509
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/CodeGen/CGBuiltin.cpp
Author: sgundapa
Date: Mon Nov 14 11:09:39 2016
New Revision: 286842
URL: http://llvm.org/viewvc/llvm-project?rev=286842&view=rev
Log:
Fix the unit test darwin-multiarch-arm.c for windows
Modified:
cfe/trunk/test/Driver/darwin-multiarch-arm.c
Modified: cfe/trunk/test/Driver/darwin-multiarch-
hokein updated this revision to Diff 77821.
hokein added a comment.
Remove a trailing blank line.
https://reviews.llvm.org/D26493
Files:
clang-move/ClangMove.cpp
unittests/clang-move/ClangMoveTests.cpp
Index: unittests/clang-move/ClangMoveTests.cpp
=
hokein updated this revision to Diff 77820.
hokein marked an inline comment as done.
hokein added a comment.
Fix a corner case, and add a test.
https://reviews.llvm.org/D26493
Files:
clang-move/ClangMove.cpp
unittests/clang-move/ClangMoveTests.cpp
Index: unittests/clang-move/ClangMoveTests
sfertile closed this revision.
sfertile added a comment.
committed https://reviews.llvm.org/rL286830
Repository:
rL LLVM
https://reviews.llvm.org/D26271
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
dougk updated this revision to Diff 77815.
dougk marked an inline comment as done.
dougk added a comment.
add a sentence about the change in AddressSanitizer.rst
https://reviews.llvm.org/D26454
Files:
docs/AddressSanitizer.rst
lib/CodeGen/SanitizerMetadata.cpp
lib/Sema/SemaDeclAttr.cpp
Author: tstellar
Date: Mon Nov 14 10:06:33 2016
New Revision: 286839
URL: http://llvm.org/viewvc/llvm-project?rev=286839&view=rev
Log:
Fix build since r286752.
Modified:
libclc/trunk/utils/prepare-builtins.cpp
Modified: libclc/trunk/utils/prepare-builtins.cpp
URL:
http://llvm.org/viewvc/llv
Can you add some non-trivial test cases that exercise double-rounding,
especially near the overflow boundary?
e.g. What is the expected value of x if the target does not support fp64?:
float x = 340282356779733661637539395458142568447.0;
– Steve
> On Nov 14, 2016, at 6:15 AM, Neil Hick
On Sun, Nov 13, 2016 at 1:30 PM Eric Fiselier via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> EricWF created this revision.
> EricWF added reviewers: mclow.lists, chandlerc.
> EricWF added a subscriber: cfe-commits.
>
> The title says it all.
>
> I just want to check that we agree on the ge
hokein added inline comments.
Comment at: clang-move/ClangMove.cpp:280
assert(It < CurrentNamespaces.rend());
- NewCode += "} // namespace " + *It + "\n";
+ NewCode += "} // namespace " + *It + "\n\n";
}
hokein wrote:
> ioeric wrote:
> > Wou
Anastasia closed this revision.
Anastasia added a comment.
Committed in r286836.
https://reviews.llvm.org/D26507
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: stulova
Date: Mon Nov 14 09:34:01 2016
New Revision: 286836
URL: http://llvm.org/viewvc/llvm-project?rev=286836&view=rev
Log:
[OpenCL] Change to clk_event parameter in enqueue_kernel.
- Accept NULL pointer as a valid parameter value for clk_event.
- Generate clk_event_t arguments of inter
hokein added inline comments.
Comment at: clang-move/ClangMove.cpp:280
assert(It < CurrentNamespaces.rend());
- NewCode += "} // namespace " + *It + "\n";
+ NewCode += "} // namespace " + *It + "\n\n";
}
ioeric wrote:
> Wouldn't this create
ioeric marked an inline comment as done.
ioeric added inline comments.
Comment at: unittests/change-namespace/ChangeNamespaceTests.cpp:829
"void f() {\n"
- " using na::CA;\n"
- " CA ca;\n"
+ " us
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
looks good.
Comment at: unittests/change-namespace/ChangeNamespaceTests.cpp:829
"void f() {\n"
- " using na::CA;\n"
-
Author: marshall
Date: Mon Nov 14 09:09:45 2016
New Revision: 286835
URL: http://llvm.org/viewvc/llvm-project?rev=286835&view=rev
Log:
Update C++1z status with LWG papers from Issaquah.
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.html
URL:
http://llv
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM with the change for the summary. Thanks!
https://reviews.llvm.org/D26509
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://list
rogfer01 created this revision.
rogfer01 added reviewers: EricWF, mclow.lists, rmaprath.
rogfer01 added a subscriber: cfe-commits.
Skip tests that expect an exception be thrown and/or disable
unreachable catch handlers.
https://reviews.llvm.org/D26612
Files:
test/std/strings/basic.string/stri
1 - 100 of 149 matches
Mail list logo
