mgorny added inline comments.
Comment at: tools/clang-format/git-clang-format:306
+try:
+return to_string(bytes.decode('utf-8'))
+except AttributeError: # 'str' object has no attribute 'decode'.
EricWF wrote:
> mgorny wrote:
> > This logic looks r
malcolm.parsons accepted this revision.
malcolm.parsons added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D30854
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
Author: ericwf
Date: Fri Mar 10 23:28:09 2017
New Revision: 297555
URL: http://llvm.org/viewvc/llvm-project?rev=297555&view=rev
Log:
fix test coverage capture dirs
Modified:
libcxx/trunk/test/CMakeLists.txt
Modified: libcxx/trunk/test/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-project/
EricWF updated this revision to Diff 91452.
EricWF marked an inline comment as done.
EricWF added a comment.
- rename variables so they don't conflict with type names.
https://reviews.llvm.org/D30773
Files:
tools/clang-format/git-clang-format
Index: tools/clang-format/git-clang-format
==
On Thu, Mar 9, 2017 at 9:36 AM, Nico Weber wrote:
> Consider landing the obvious bits (print function, mostly) separately and
> use this only for the interesting bits.
>
Sounds good. I just wanted to make sure I got the simple bits right as well.
If this doesn't get reviewed in the next week I'
EricWF marked 4 inline comments as done.
EricWF added inline comments.
Comment at: tools/clang-format/git-clang-format:293
+def to_bytes(str):
+# Encode to UTF-8 to get binary data.
These functions are all lifted directly from `lit/util.py`
==
EricWF updated this revision to Diff 91449.
EricWF added a comment.
Add complete implementation.
As far as I've tested this works perfectly in both python2 and python3.
https://reviews.llvm.org/D30773
Files:
tools/clang-format/git-clang-format
Index: tools/clang-format/git-clang-format
Author: ericwf
Date: Fri Mar 10 21:24:18 2017
New Revision: 297553
URL: http://llvm.org/viewvc/llvm-project?rev=297553&view=rev
Log:
Change test coverage generation to use llvm-cov instead of gcov.
Clang doesn't produce gcov compatible coverage files. This
causes lcov to break because it uses gco
Author: ericwf
Date: Fri Mar 10 20:35:37 2017
New Revision: 297547
URL: http://llvm.org/viewvc/llvm-project?rev=297547&view=rev
Log:
[coroutines] Fix diagnostics depending on the first coroutine statement.
Summary:
Some coroutine diagnostics need to point to the location of the first coroutine
k
EricWF updated this revision to Diff 91447.
EricWF added a comment.
Merge with master.
https://reviews.llvm.org/D30776
Files:
include/clang/Sema/ScopeInfo.h
lib/Sema/ScopeInfo.cpp
lib/Sema/SemaCoroutine.cpp
lib/Sema/TreeTransform.h
test/SemaCXX/coroutines.cpp
Index: test/SemaCXX/coro
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297541: [coroutines] Refactor SuspendExpr to create just one
OpaqueValue (almost NFC) (authored by GorNishanov).
Changed prior to commit:
https://reviews.llvm.org/D30775?vs=91134&id=91442#toc
Repositor
Author: gornishanov
Date: Fri Mar 10 19:30:17 2017
New Revision: 297541
URL: http://llvm.org/viewvc/llvm-project?rev=297541&view=rev
Log:
[coroutines] Refactor SuspendExpr to create just one OpaqueValue (almost NFC)
Summary:
Create only one OpaqueValue for await_ready/await_suspend/await_resume.
GorNishanov accepted this revision.
GorNishanov added a comment.
This revision is now accepted and ready to land.
Alright, then. LGTM once more!
https://reviews.llvm.org/D30776
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
kastiglione added a comment.
I'd like to add more ObjC specific matcher functionality in follow up diffs.
This diff is to to start somewhere, and get feedback.
https://reviews.llvm.org/D30854
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
kastiglione created this revision.
This adds matchers for `ObjCProtocolDecl`, `ObjCCategoryDecl`,
`ObjCMethodDecl`, `ObjCIvarDecl`, and
`ObjCPropertyDecl`. These matchers complement the existing matcher for
`ObjCInterfaceDecl`.
https://reviews.llvm.org/D30854
Files:
docs/LibASTMatchersRefer
spatel added a comment.
In https://reviews.llvm.org/D30834#698346, @craig.topper wrote:
> Have you ran the tests all the way through to assembly and made sure we don't
> regress? If we do regress, I wouldn't hold up fixing this, but we should at
> least have bugs for what breaks.
Yes - I spot
Author: ributzka
Date: Fri Mar 10 18:14:50 2017
New Revision: 297533
URL: http://llvm.org/viewvc/llvm-project?rev=297533&view=rev
Log:
Revert "Reapply [VFS] Ignore broken symlinks in the directory iterator."
Still broken on Windows and SystemZ bot ... sorry for the noise.
Modified:
cfe/trunk
Author: ericwf
Date: Fri Mar 10 18:07:08 2017
New Revision: 297532
URL: http://llvm.org/viewvc/llvm-project?rev=297532&view=rev
Log:
Fix DoNotOptimize on MSVC
Modified:
libcxx/trunk/test/support/test_macros.h
Modified: libcxx/trunk/test/support/test_macros.h
URL:
http://llvm.org/viewvc/llvm
Author: ributzka
Date: Fri Mar 10 18:01:24 2017
New Revision: 297531
URL: http://llvm.org/viewvc/llvm-project?rev=297531&view=rev
Log:
Adding debug output to investigate systemz bot issue.
Modified:
cfe/trunk/unittests/Basic/VirtualFileSystemTest.cpp
Modified: cfe/trunk/unittests/Basic/Virtu
craig.topper added a comment.
Have you ran the tests all the way through to assembly and made sure we don't
regress? If we do regress, I wouldn't hold up fixing this, but we should at
least have bugs for what breaks.
Comment at: lib/CodeGen/CGBuiltin.cpp:7384
case X86::BI_
Author: ributzka
Date: Fri Mar 10 16:49:04 2017
New Revision: 297528
URL: http://llvm.org/viewvc/llvm-project?rev=297528&view=rev
Log:
Reapply [VFS] Ignore broken symlinks in the directory iterator.
Modified the tests to accept any iteration order.
The VFS directory iterator and recursive direct
Author: ributzka
Date: Fri Mar 10 15:46:51 2017
New Revision: 297517
URL: http://llvm.org/viewvc/llvm-project?rev=297517&view=rev
Log:
Revert r297510 "[VFS] Ignore broken symlinks in the directory iterator."
The tests are failing on one of the bots.
Modified:
cfe/trunk/include/clang/Basic/Vi
Author: abpostelnicu
Date: Fri Mar 10 09:10:37 2017
New Revision: 297467
URL: http://llvm.org/viewvc/llvm-project?rev=297467&view=rev
Log:
[clang-format] Add option to break before inheritance separation operator in
class declaration.
Differential Revision: https://reviews.llvm.org/D30487
Modif
Author: ributzka
Date: Fri Mar 10 15:23:29 2017
New Revision: 297511
URL: http://llvm.org/viewvc/llvm-project?rev=297511&view=rev
Log:
[VFS] Remove the Path variable from RealFSDirIter. NFC.
This variable is set, but never used.
Modified:
cfe/trunk/lib/Basic/VirtualFileSystem.cpp
Modified:
Author: ributzka
Date: Fri Mar 10 15:23:27 2017
New Revision: 297510
URL: http://llvm.org/viewvc/llvm-project?rev=297510&view=rev
Log:
[VFS] Ignore broken symlinks in the directory iterator.
The VFS directory iterator and recursive directory iterator behave differently
from the LLVM counterparts.
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
This LGTM.
https://reviews.llvm.org/D30775
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
Nevermind, I see you've fixed. Thanks :)
On Fri, Mar 10, 2017 at 3:21 PM Eric Christopher wrote:
> Looks like this is failing on a number of bots...
>
> On Fri, Mar 10, 2017 at 1:37 PM Juergen Ributzka via Phabricator via
> cfe-commits wrote:
>
> ributzka added a comment.
>
> Thanks Bruno. Comm
EricWF added a comment.
In https://reviews.llvm.org/D30776#697258, @GorNishanov wrote:
> In https://reviews.llvm.org/D30776#697233, @EricWF wrote:
>
> > Good to know. I'll update this tomorrow.
>
>
> Well, that is just the thought. Possibly we can check for the types of
> await_ready and await_s
Looks like this is failing on a number of bots...
On Fri, Mar 10, 2017 at 1:37 PM Juergen Ributzka via Phabricator via
cfe-commits wrote:
> ributzka added a comment.
>
> Thanks Bruno. Committed in r297510.
>
>
> Repository:
> rL LLVM
>
> https://reviews.llvm.org/D30768
>
>
>
>
Author: chapuni
Date: Fri Mar 10 17:06:34 2017
New Revision: 297530
URL: http://llvm.org/viewvc/llvm-project?rev=297530&view=rev
Log:
clang/test/SemaOpenCL/overload_addrspace_resolution.cl: Appease MS mangler to
specify triple=x86_64-unknown.
Modified:
cfe/trunk/test/SemaOpenCL/overload_addr
EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.
We can't just use an arbitrary allocator type for a number of reasons:
- You just changed the type of the control block. That's ABI breaking.
- `allocator` allocates ints, nothing els
mgehre updated this revision to Diff 91424.
mgehre added a comment.
Added clang version to test and regenerated cxx_dr_status.html
https://reviews.llvm.org/D30848
Files:
include/clang/Parse/Parser.h
include/clang/Sema/Sema.h
lib/Parse/ParseDeclCXX.cpp
lib/Parse/ParseExprCXX.cpp
lib/Se
kmarshall added a comment.
NP, Anna. I filed a number of bugs for the false positives:
- https://bugs.llvm.org/show_bug.cgi?id=32229
- https://bugs.llvm.org/show_bug.cgi?id=32232
- https://bugs.llvm.org/show_bug.cgi?id=32233
- https://bugs.llvm.org/show_bug.cgi?id=32234
- https://bugs.llvm.org/sh
rsmith added inline comments.
Comment at: test/CXX/drs/dr3xx.cpp:911
-namespace dr373 { // dr373: no
- // FIXME: This is valid.
- namespace X { int dr373; } // expected-note 2{{here}}
+namespace dr373 { // dr373: yes
+ namespace X { int dr373; }
This should
mgehre updated this revision to Diff 91418.
mgehre added a comment.
clang-format
https://reviews.llvm.org/D30848
Files:
include/clang/Parse/Parser.h
include/clang/Sema/Sema.h
lib/Parse/ParseDeclCXX.cpp
lib/Parse/ParseExprCXX.cpp
lib/Sema/SemaCXXScopeSpec.cpp
test/CXX/drs/dr3xx.cpp
mgehre created this revision.
3.4.6 [basic.lookup.udir] paragraph 1:
In a using-directive or namespace-alias-definition, during the lookup for a
namespace-name or for a name in a nested-name-specifier, only namespace names
are considered.
https://reviews.llvm.org/D30848
Files:
include/clang
Quuxplusone added a comment.
I notice that the Standard implies that std::unique_ptr will work only with
*object types* T, and yet the "object" wording is missing from shared_ptr.
> A unique pointer is an object that owns another *object* and manages that
> other *object* through a pointer.
outcoldman added a comment.
The actual problem is with that clang-format does not know anything about c++17
features, because it does not set it in lang options. Not sure if that will fix
constexpr problem as well, but I could solve some other problems with
tools/clang
kzhuravl added a comment.
I am not sure if this is the right way to fix it.
https://reviews.llvm.org/D30845
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kzhuravl created this revision.
Herald added a subscriber: wdng.
For variables in generic address spaces, for example:
unsigned char V[6442450944];
...
the address space is not yet known when we get into *getConstantArrayType*, it
is 0. AMDGCN target's address space 0 has 32 bits pointers,
ributzka added a comment.
Thanks Bruno. Committed in r297510.
Repository:
rL LLVM
https://reviews.llvm.org/D30768
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297510: [VFS] Ignore broken symlinks in the directory
iterator. (authored by ributzka).
Changed prior to commit:
https://reviews.llvm.org/D30768?vs=91371&id=91403#toc
Repository:
rL LLVM
https://rev
bruno accepted this revision.
bruno added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/Basic/VirtualFileSystem.cpp:1873
vfs::directory_iterator I = FS->dir_begin(State->top()->getName(), EC);
-if (EC)
+if (EC && EC != std::errc::n
Hello Anastasia,
Added test fails on one of our new builders:
Failing Tests (1):
Clang :: SemaOpenCL/overload_addrspace_resolution.cl
http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/23/steps/test-check-all/logs/stdio
Please have a look at it?
Thanks
Galina
smeenai added a comment.
Ping.
https://reviews.llvm.org/D27387
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erik.pilkington updated this revision to Diff 91385.
erik.pilkington added a comment.
This new patch replaces the allocator from `allocator` to
`allocator`, I didn't realize `allocator` was deprecated.
Thanks,
Erik
https://reviews.llvm.org/D30837
Files:
include/memory
test/std/utilities/m
vsk added a reviewer: rsmith.
vsk added a comment.
Ping. I appreciate that there are a lot of test changes to sift through here --
please let me know if I can make the patch easier to review in any way.
https://reviews.llvm.org/D30283
___
cfe-commi
fgross created this revision.
Herald added a subscriber: JDevlieghere.
Fixed erroneously flagging of chained if statements when styled like this:
if (cond) {
}
else if (cond) {
}
else {
}
https://reviews.llvm.org/D30841
Files:
clang-tidy/readability/MisleadingIndentationCheck.cpp
Author: gkistanova
Date: Fri Mar 10 13:34:15 2017
New Revision: 297497
URL: http://llvm.org/viewvc/llvm-project?rev=297497&view=rev
Log:
Attempt to fix Windows buildbot.
Modified:
cfe/trunk/test/Modules/dependency-dump-dependent-module.m
cfe/trunk/test/Modules/dependency-dump.m
Modified:
mgorny added a comment.
Ping II.
https://reviews.llvm.org/D24921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgorny marked 5 inline comments as done.
mgorny added a comment.
A gentle ping.
https://reviews.llvm.org/D29542
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgorny added a comment.
PIng.
Repository:
rL LLVM
https://reviews.llvm.org/D29851
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgorny added a comment.
Ping.
Repository:
rL LLVM
https://reviews.llvm.org/D30155
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgorny added a comment.
Another ping. Since 4.0.0 final has been tagged, I think we should get back to
working on this. @compnerd, any suggestion how to proceed here?
https://reviews.llvm.org/D26796
___
cfe-commits mailing list
cfe-commits@lists.ll
vsk updated this revision to Diff 91382.
vsk marked 4 inline comments as done.
vsk added a comment.
- Rework documentation, add better code comments, and tighten up some check
lines.
https://reviews.llvm.org/D30762
Files:
docs/UndefinedBehaviorSanitizer.rst
include/clang/Basic/Sanitizers.d
vsk marked 9 inline comments as done.
vsk added a comment.
The plan is to start off with -fsanitize=nullability, and then create a
nullability-pedantic group later if it's really necessary. I think I've
addressed all of the inline comments, and will upload a new diff shortly.
halyavin added a comment.
But std::allocator is deprecated in C++17. I don't know a good solution,
I just used int as an arbitrary type when I faced similar problem.
https://reviews.llvm.org/D30837
___
cfe-commits mailing list
cfe-commits@lists.llv
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Hi Alex,
Thanks for taking a look a this. LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D30183
___
cfe-commits mailing list
cfe-commits@lis
mgehre added a comment.
I'm sorry for the long delay!
Regarding " I think it would also be good to (eventually) add CFGElements
marking when the storage duration for underlying storage ends.":
From what I understand, this only differs from the end of lifetime in case of
objects with non-trivial
mgehre updated this revision to Diff 91378.
mgehre marked an inline comment as done.
mgehre added a comment.
Handle back-patches gotos and add test case
Turned LocalScope::const_iterator::shared_parent from O(N^2) into O(N) time
The combination with AddImplicitDtors will be added in a separate pat
erik.pilkington created this revision.
This patch adds support for `shared_ptr` types, so that the following
works:
void Func();
void Del(void (*)())
std::shared_ptr x(Func, Del);
Where previously this would fail to compile. In PR27566, the use case described
for this was a shared pointe
jprice added a comment.
Thanks - could you commit this on my behalf please?
https://reviews.llvm.org/D30830
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297485: [mips][msa] Remove range checks for non-immediate
sld.[bhwd] instructions (authored by petarj).
Changed prior to commit:
https://reviews.llvm.org/D30693?vs=91158&id=91372#toc
Repository:
rL L
Author: petarj
Date: Fri Mar 10 11:51:01 2017
New Revision: 297485
URL: http://llvm.org/viewvc/llvm-project?rev=297485&view=rev
Log:
[mips][msa] Remove range checks for non-immediate sld.[bhwd] instructions
Removes immediate range checks for these instructions, since they have GPR
rt as their inp
ributzka updated this revision to Diff 91371.
ributzka added a comment.
Remove the EC check completely.
https://reviews.llvm.org/D30768
Files:
include/clang/Basic/VirtualFileSystem.h
lib/Basic/VirtualFileSystem.cpp
unittests/Basic/VirtualFileSystemTest.cpp
Index: unittests/Basic/VirtualF
spatel created this revision.
Herald added a subscriber: mcrosier.
x86 has undef SSE/AVX intrinsics that should represent a bogus register
operand. This is not the same as LLVM's undef value which can take on multiple
bit patterns.
There are better solutions / follow-ups to this discussed here:
bader added a comment.
> Why do you think this is a bug? It seems to follow standard behavior in C to
> promote char to int if required. Just like if you would have a C code:
>
> int as_int(int i);
> void foo() {
> char src = 1;
> int dst = as_int(src);
> }
>
>
> This cod
jaykang10 added a comment.
In https://reviews.llvm.org/D30810#697760, @Anastasia wrote:
> Could you please add your test here (probably goes to test/CodeGenOpenCL)?
Oops!
I am so sorry. I missed it. I have updated it.
https://reviews.llvm.org/D30810
jaykang10 updated this revision to Diff 91355.
jaykang10 added a comment.
Changed help text for option and Added test file.
https://reviews.llvm.org/D30810
Files:
include/clang/Driver/CC1Options.td
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/CGExpr.cpp
lib/Frontend/CompilerInv
gerazo created this revision.
Do not drop the import of the whole function just because an asm statement in
it has some missing symbolic names.
https://reviews.llvm.org/D30831
Files:
lib/AST/ASTImporter.cpp
test/ASTMerge/asm/Inputs/asm-function.cpp
test/ASTMerge/asm/test.cpp
Index: tes
mehdi_amini added a comment.
Off topic, but since this is a rev lock change with LLVM, you can to all of in
a single revision with:
http://llvm.org/docs/GettingStarted.html#for-developers-to-work-with-a-git-monorepo
Repository:
rL LLVM
https://reviews.llvm.org/D30792
jroelofs added a comment.
I'll also add that we had a BOF at EuroLLVM 2014, where this got support from
the community and people generally thought it was a good plan... Just needed
someone to follow through with it.
We (wearing my CodeSourcery hat) said we would do so, but have been making slow
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! This bit was poorly tested initially as there were simply too many
things. I am wondering if we could improve these bits slowly by extending
further lib/Headers/opencl-c.h.
https
Anastasia added a comment.
In https://reviews.llvm.org/D28136#697673, @echuraev wrote:
> In https://reviews.llvm.org/D28136#634356, @Anastasia wrote:
>
> > This has been discussed during the initial review for the header:
> >
> > http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20160425/
jprice created this revision.
https://reviews.llvm.org/D30830
Files:
lib/Headers/opencl-c.h
Index: lib/Headers/opencl-c.h
===
--- lib/Headers/opencl-c.h
+++ lib/Headers/opencl-c.h
@@ -14395,10 +14395,10 @@
#if defined(cl_khr_g
jroelofs added a comment.
In https://reviews.llvm.org/D30733#697313, @Hahnfeld wrote:
> In https://reviews.llvm.org/D30733#697108, @jroelofs wrote:
>
> > As I said on https://reviews.llvm.org/D30214, it is inappropriate to be
> > installing libc++ in the resource directory... please **do not** d
Anastasia added a comment.
Could you please add your test here (probably goes to test/CodeGenOpenCL)?
Comment at: include/clang/Driver/CC1Options.td:661
+def fpreserve_vec3_type : Flag<["-"], "fpreserve-vec3-type">,
+ HelpText<"Preserve 3-component vector type operations">;
+
Author: stulova
Date: Fri Mar 10 09:23:07 2017
New Revision: 297468
URL: http://llvm.org/viewvc/llvm-project?rev=297468&view=rev
Log:
[OpenCL] Fix type compatibility check and generic AS mangling.
1. Reimplemented conditional operator so that it checks
compatibility of unqualified pointees of the
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297467: [clang-format] Add option to break before
inheritance separation operator in… (authored by Abpostelnicu).
Changed prior to commit:
https://reviews.llvm.org/D30487?vs=91335&id=91344#toc
Reposito
Anastasia added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8263
+def err_atomic_init_addressspace : Error<
+ "initialization of atomic variables is restricted to variables in global
address space">;
def err_atomic_init_constant : Error<
---
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297465: Print nested name specifiers for typedefs and type
aliases (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D29944?vs=88376&id=91342#toc
Repository:
rL LLVM
https://
Author: arphaman
Date: Fri Mar 10 09:04:58 2017
New Revision: 297465
URL: http://llvm.org/viewvc/llvm-project?rev=297465&view=rev
Log:
Print nested name specifiers for typedefs and type aliases
Printing typedefs or type aliases using clang_getTypeSpelling() is missing the
namespace they are defin
Author: xazax
Date: Fri Mar 10 08:50:12 2017
New Revision: 297461
URL: http://llvm.org/viewvc/llvm-project?rev=297461&view=rev
Log:
[analyzer] Extend block in critical section check with C11 and Pthread APIs.
Patch by Zoltan Daniel Torok!
Differential Revision: https://reviews.llvm.org/D29567
Abpostelnicu updated this revision to Diff 91335.
Abpostelnicu marked an inline comment as done.
Abpostelnicu added a comment.
Fixed two spell errors.
Repository:
rL LLVM
https://reviews.llvm.org/D30487
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/Co
arphaman added a comment.
In https://reviews.llvm.org/D29944#697587, @redm123 wrote:
> I guess so. I don't think I'm allowed to commit. So I would appreciate it.
Sure, I will commit it right now.
> Which release version would that be in? 4.1 I guess?
It will be in the next major release: 5.0
Hi Akira,
Thank you very much! Please let me know if I need to take any further steps
beyond this email to cfe-commits in order for the patch and the unit test to be
committed.
Thanks,
David
> On Mar 9, 2017, at 4:46 PM, Akira Hatanaka wrote:
>
> Hi David,
>
> The patch looks good to me.
krasimir abandoned this revision.
krasimir added a comment.
this is nonsense
https://reviews.llvm.org/D30822
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kimgr added a comment.
A few more 'inhertiance' left, otherwise spelling looks good to me :-)
Comment at: lib/Format/TokenAnnotator.cpp:679
Tok->Type = TT_CtorInitializerComma;
+ else if (Contexts.back().InInhertianceList)
+Tok->Type = TT_InheritanceComma;
Abpostelnicu updated this revision to Diff 91334.
Repository:
rL LLVM
https://reviews.llvm.org/D30487
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/ContinuationIndenter.cpp
lib/Format/Format.cpp
lib/Format/FormatToken.h
lib/Format/TokenAnnotator.c
echuraev added a comment.
In https://reviews.llvm.org/D28136#634356, @Anastasia wrote:
> This has been discussed during the initial review for the header:
> http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20160425/157187.html
>
> The main issue is after preprocessing the header the origi
a.sidorin added a comment.
I have no any objection on this change.
Repository:
rL LLVM
https://reviews.llvm.org/D30798
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
NoQ added a comment.
I'd like to clarify that in case of path-sensitive analysis there are actually
three warning classes to consider.
1. Warnings that reside completely in system headers and indicate bugs in
system headers, most likely falsely.
2. Warnings that originate from the main file and
Abpostelnicu added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:355
+ if (Current.is(TT_InheritanceColon))
+State.Stack.back().NoLineBreak = true;
djasper wrote:
> Can you leave a comment here:
>
> // Don't break within the inheritan
djasper added inline comments.
Comment at: lib/Format/TokenAnnotator.cpp:2666
return true;
+ if (Left.is(TT_InheritanceComma) &&
+ Style.BreakBeforeInheritanceComma)
Do these now fit on one line?
Repository:
rL LLVM
https://reviews.llvm.org/D30487
Abpostelnicu updated this revision to Diff 91330.
Abpostelnicu marked an inline comment as done.
Repository:
rL LLVM
https://reviews.llvm.org/D30487
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/ContinuationIndenter.cpp
lib/Format/Format.cpp
lib/For
echuraev updated this revision to Diff 91327.
https://reviews.llvm.org/D28136
Files:
lib/Headers/opencl-c.h
test/SemaOpenCL/as_type.cl
Index: test/SemaOpenCL/as_type.cl
===
--- test/SemaOpenCL/as_type.cl
+++ test/SemaOpenCL/as_t
xazax.hun added a comment.
In https://reviews.llvm.org/D30798#697115, @zaks.anna wrote:
> I've committed the change, but would very much appreciate community feedback
> here if if there is any!
I agree with the change. Users are usually not interested in the results from
the standard library,
Author: krasimir
Date: Fri Mar 10 07:09:29 2017
New Revision: 297455
URL: http://llvm.org/viewvc/llvm-project?rev=297455&view=rev
Log:
[clang-format] Use a reference in loop variable; NFC
Modified:
cfe/trunk/lib/Format/UnwrappedLineParser.cpp
Modified: cfe/trunk/lib/Format/UnwrappedLineParse
redm123 added a comment.
I guess so. I don't think I'm allowed to commit. So I would appreciate it.
Which release version would that be in? 4.1 I guess?
Thanks for your help!
https://reviews.llvm.org/D29944
___
cfe-commits mailing list
cfe-commits
john.brawn updated this revision to Diff 91311.
john.brawn added a comment.
Rebase on top of recent driver changes.
Repository:
rL LLVM
https://reviews.llvm.org/D30582
Files:
lib/Driver/ToolChains/Clang.cpp
test/Driver/fast-math.c
Index: test/Driver/fast-math.c
=
1 - 100 of 124 matches
Mail list logo
