Re: [libcxx] r299734 - Allow a standard library to implement conditional noexcept for optional and unique_ptr hash functions.

It looks like this commit and r299735 are causing bots to fail: http://green.lab.llvm.org/green/job/libcxx_master_cmake_32/66/ The test hash_unique_ptr.pass.cpp doesn’t compile when -std=c++03 is on the command line because

[PATCH] D31401: [clangd] Extract FsPath from file:// uri

stanionascu marked 2 inline comments as done. stanionascu added a comment. Thank you for the review! If there are no other comments/suggestions, would be great if someone would merge it as I'm lacking the permission to do so. https://reviews.llvm.org/D31401

[PATCH] D31673: Allow casting C pointers declared using extern "C" to ObjC pointer types

rjmccall added inline comments. Comment at: lib/Sema/SemaExprObjC.cpp:3358 var && - var->getStorageClass() == SC_Extern && + !var->isThisDeclarationADefinition() && var->getType().isConstQualified()) { ahatanak wrote: >

[PATCH] D31798: [libc++] Drop support for CRTs older than VS 2015

This revision was automatically updated to reflect the committed changes. Closed by commit rL299743: [libc++] Drop support for CRTs older than VS 2015 (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D31798?vs=94468=94476#toc Repository: rL LLVM

[libcxx] r299743 - [libc++] Drop support for CRTs older than VS 2015

Author: smeenai Date: Thu Apr 6 21:20:52 2017 New Revision: 299743 URL: http://llvm.org/viewvc/llvm-project?rev=299743=rev Log: [libc++] Drop support for CRTs older than VS 2015 LLVM dropped support for Visual Studio versions older than 2015 quite some time ago, so I consider it safe to drop

[PATCH] D29654: [OpenMP] Integrate OpenMP target region cubin into host binary

gtbercea updated this revision to Diff 94475. gtbercea added a comment. Address some of the reviews. Repository: rL LLVM https://reviews.llvm.org/D29654 Files: lib/Driver/Driver.cpp lib/Driver/ToolChains/CommonArgs.cpp lib/Driver/ToolChains/CommonArgs.h

[libcxx] r299735 - Add noexcept(false) to more strongly indicate that not being noexcept is important for hash tests.

Author: bion Date: Thu Apr 6 18:50:33 2017 New Revision: 299735 URL: http://llvm.org/viewvc/llvm-project?rev=299735=rev Log: Add noexcept(false) to more strongly indicate that not being noexcept is important for hash tests. Modified:

[libcxx] r299734 - Allow a standard library to implement conditional noexcept for optional and unique_ptr hash functions.

Author: bion Date: Thu Apr 6 18:50:21 2017 New Revision: 299734 URL: http://llvm.org/viewvc/llvm-project?rev=299734=rev Log: Allow a standard library to implement conditional noexcept for optional and unique_ptr hash functions. These tests were unconditionally asserting that optional and

[PATCH] D31778: [Modules] Implement ODR-like semantics for tag types in C/ObjC

bruno updated this revision to Diff 94471. bruno added a comment. Update patch on top of Adrian comments https://reviews.llvm.org/D31778 Files: include/clang/AST/ASTStructuralEquivalence.h include/clang/Basic/DiagnosticASTKinds.td include/clang/Parse/Parser.h include/clang/Sema/Sema.h

[PATCH] D31778: [Modules] Implement ODR-like semantics for tag types in C/ObjC

bruno added inline comments. Comment at: include/clang/AST/ASTStructuralEquivalence.h:52 + /// \brief Whether warn or error on tag type mismatches. + bool ErrorOnTagTypeMismatch; aprantl wrote: > No need to use \brief in new code any more. We are compiling

[PATCH] D31798: [libc++] Drop support for CRTs older than VS 2015

smeenai created this revision. LLVM dropped support for Visual Studio versions older than 2015 quite some time ago, so I consider it safe to drop libc++'s support for older CRTs. The CRT in Visual Studio 2015 provides a lot of previously missing functions, so targeting it requires less special

[PATCH] D31696: Automatically add include-what-you-use for when building in tree

rnk added inline comments. Comment at: clang/tools/.gitignore:12 +#==# +# The include-what-you-use project, for when building in-tree. +include-what-you-use LLVM doesn't currently have

[PATCH] D31702: Append -w when LLVM_ENABLE_WARNINGS is Off.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D31702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31673: Allow casting C pointers declared using extern "C" to ObjC pointer types

ahatanak updated this revision to Diff 94460. ahatanak marked an inline comment as done. https://reviews.llvm.org/D31673 Files: lib/Sema/SemaExprObjC.cpp test/SemaObjCXX/arc-bridged-cast.mm Index: test/SemaObjCXX/arc-bridged-cast.mm

[PATCH] D31673: Allow casting C pointers declared using extern "C" to ObjC pointer types

ahatanak added inline comments. Comment at: lib/Sema/SemaExprObjC.cpp:3358 var && - var->getStorageClass() == SC_Extern && + !var->isThisDeclarationADefinition() && var->getType().isConstQualified()) { rjmccall wrote: >

[PATCH] D31736: Implement _interlockedbittestandset as a builtin

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: lib/CodeGen/CGBuiltin.cpp:570 +llvm::AtomicOrdering::SequentiallyConsistent); +llvm::Value *Shifted = Builder.CreateLShr(RMWI, Bit); +llvm::Value

[PATCH] D31652: [clang-format] Recognize Java logical shift assignment operator

bradfier added a comment. Thanks for that @thakis, that's a much better solution than the first attempt! Repository: rL LLVM https://reviews.llvm.org/D31652 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31652: [clang-format] Recognize Java logical shift assignment operator

bradfier updated this revision to Diff 94438. bradfier edited the summary of this revision. bradfier added a comment. Switch to a more appropriate (and much simpler) method of identifying these Java-specific operators. Also removed any references to fictitious "logical left shifts", I think I

[libcxx] r299711 - [CMake][libcxx] Use check_c_compiler_flag to check for nodefaultlibs

Author: phosek Date: Thu Apr 6 16:06:33 2017 New Revision: 299711 URL: http://llvm.org/viewvc/llvm-project?rev=299711=rev Log: [CMake][libcxx] Use check_c_compiler_flag to check for nodefaultlibs We're using -nodefaultlibs to avoid the dependency on C++ library when using

[PATCH] D25866: [Sema] Support implicit scalar to vector conversions

sdardis updated this revision to Diff 94434. sdardis marked 7 inline comments as done. sdardis added a comment. Addressed review comments. I've changed InvalidVectorOperands() to not use InvalidOperands() after updating some tests. InvalidOperands() was receiving expressions with implicit

[PATCH] D31778: [Modules] Implement ODR-like semantics for tag types in C/ObjC

aprantl added a comment. Thanks! Added a couple of superficial coding style comments. I think there should also be a test for C99 and one for C11 (and potentially ObjC2). Comment at: include/clang/AST/ASTStructuralEquivalence.h:52 + /// \brief Whether warn or error on tag

[PATCH] D31736: Implement _interlockedbittestandset as a builtin

hans added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:570 +llvm::AtomicOrdering::SequentiallyConsistent); +llvm::Value *Shifted = Builder.CreateLShr(RMWI, Bit); +llvm::Value *Truncated = rnk wrote: > Can you comment that this shifts

[PATCH] D31736: Implement _interlockedbittestandset as a builtin

hans updated this revision to Diff 94433. hans added a comment. Add comment. https://reviews.llvm.org/D31736 Files: include/clang/Basic/Builtins.def lib/CodeGen/CGBuiltin.cpp lib/Headers/intrin.h test/CodeGen/ms-intrinsics.c Index: test/CodeGen/ms-intrinsics.c

[clang-tools-extra] r299700 - [clang-tidy] Reuse FileID in getLocation

Author: chh Date: Thu Apr 6 15:19:26 2017 New Revision: 299700 URL: http://llvm.org/viewvc/llvm-project?rev=299700=rev Log: [clang-tidy] Reuse FileID in getLocation One FileID per warning will increase and overflow NextLocalOffset when input file is large with many warnings. Reusing FileID

[PATCH] D31406: [clang-tidy] Reuse FileID in getLocation

This revision was automatically updated to reflect the committed changes. Closed by commit rL299700: [clang-tidy] Reuse FileID in getLocation (authored by chh). Repository: rL LLVM https://reviews.llvm.org/D31406 Files: clang-tools-extra/trunk/clang-tidy/ClangTidy.cpp Index:

[PATCH] D31760: [lsan] Enable LSan on arm Linux, clang part

eugenis added inline comments. Comment at: lib/Driver/ToolChains/Linux.cpp:867 getTriple().getArch() == llvm::Triple::aarch64_be; + const bool IsArmArch = getTriple().getArch() == llvm::Triple::arm; SanitizerMask Res =

[PATCH] D30739: [OpenMP] "declare simd" for AArch64 Advanced SIMD.

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:6818-6819 +ISAData); +} +if (CGM.getTriple().getArch() == llvm::Triple::aarch64) { + ISADataTy ISAData[] = { else if

[PATCH] D31696: Automatically add include-what-you-use for when building in tree

kimgr added a comment. > BTW, kimgr@, is there any particular reason you haven't tried to upstream the > tool? > Maybe even as not a standalone tool but as a set of checks in clang-tidy. Lack of time, mostly. IWYU was written before there was libtooling, and follows Google style, so we've

[PATCH] D31771: [AMDGPU] Temporarily change constant address space from 4 to 2 for the new address space mapping

This revision was automatically updated to reflect the committed changes. Closed by commit rL299691: [AMDGPU] Temporarily change constant address space from 4 to 2 for the new… (authored by yaxunl). Changed prior to commit: https://reviews.llvm.org/D31771?vs=94386=94418#toc Repository: rL

r299691 - [AMDGPU] Temporarily change constant address space from 4 to 2 for the new address space mapping

Author: yaxunl Date: Thu Apr 6 14:18:36 2017 New Revision: 299691 URL: http://llvm.org/viewvc/llvm-project?rev=299691=rev Log: [AMDGPU] Temporarily change constant address space from 4 to 2 for the new address space mapping Change constant address space from 4 to 2 for the new address space

[libcxx] r299686 - Some of Eric's buildbots don't like this test. Disable it while I figure out why.

Author: marshall Date: Thu Apr 6 13:54:37 2017 New Revision: 299686 URL: http://llvm.org/viewvc/llvm-project?rev=299686=rev Log: Some of Eric's buildbots don't like this test. Disable it while I figure out why. Modified: libcxx/trunk/test/std/re/re.alg/re.alg.match/awk.pass.cpp Modified:

[PATCH] D31713: [Basic] getColumnNumber returns location of CR+LF on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rL299681: [Basic] getColumnNumber returns location of CR+LF on Windows (authored by chh). Changed prior to commit: https://reviews.llvm.org/D31713?vs=94402=94410#toc Repository: rL LLVM

r299681 - [Basic] getColumnNumber returns location of CR+LF on Windows

Author: chh Date: Thu Apr 6 13:36:50 2017 New Revision: 299681 URL: http://llvm.org/viewvc/llvm-project?rev=299681=rev Log: [Basic] getColumnNumber returns location of CR+LF on Windows When fixing a Clang-Tidy bug in D31406, reuse of FileID enabled the missing highlightRange function. Assertion

[libcxx] r299680 - Recommit awk tests with warnings removed. Initial commit r299652, reverted r299656.

Author: marshall Date: Thu Apr 6 13:34:36 2017 New Revision: 299680 URL: http://llvm.org/viewvc/llvm-project?rev=299680=rev Log: Recommit awk tests with warnings removed. Initial commit r299652, reverted r299656. Modified: libcxx/trunk/test/std/re/re.alg/re.alg.match/awk.pass.cpp

[PATCH] D31781: [Modules] Allow local submodule visibility without c++

bruno created this revision. Removing this restriction will make it handy to explore local submodule visibility without c++ being turned on. We're currently testing it out with C/ObjC. https://reviews.llvm.org/D31781 Files: lib/Frontend/CompilerInvocation.cpp Index:

r299678 - [AMDGPU] Translate reqd_work_group_size into amdgpu_flat_work_group_size

Author: rampitec Date: Thu Apr 6 13:15:44 2017 New Revision: 299678 URL: http://llvm.org/viewvc/llvm-project?rev=299678=rev Log: [AMDGPU] Translate reqd_work_group_size into amdgpu_flat_work_group_size These two attributes specify the same info in a different way. AMGPU BE only checks the

[PATCH] D31043: Update for lifetime intrinsic signature change

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D31043 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31713: [Basic] getColumnNumber returns location of CR+LF on Windows

chh updated this revision to Diff 94402. chh marked an inline comment as done. https://reviews.llvm.org/D31713 Files: lib/Basic/SourceManager.cpp Index: lib/Basic/SourceManager.cpp === --- lib/Basic/SourceManager.cpp +++

[PATCH] D31778: [Modules] Implement ODR-like semantics for tag types in C/ObjC

bruno created this revision. Allow ODR for ObjC/C in the sense that we won't keep more that one definition around (merge them). However, ensure the decl pass the structural compatibility check in C11 6.2.7/1, for that, reuse the structural equivalence checks used by the ASTImporter. Few other

[PATCH] D31404: [OpenCL] Allow alloca return non-zero private pointer

yaxunl updated this revision to Diff 94399. yaxunl marked 5 inline comments as done. yaxunl added a comment. Revised by Anastasia's comments. https://reviews.llvm.org/D31404 Files: include/clang/AST/ASTContext.h include/clang/AST/Type.h include/clang/Basic/AddressSpaces.h

[PATCH] D31696: Automatically add include-what-you-use for when building in tree

zturner added reviewers: beanz, rnk, chandlerc. zturner added a comment. Not really sure who to add as a reviewer here, so + a few random people. BTW, kimgr@, is there any particular reason you haven't tried to upstream the tool? Maybe even as not a standalone tool but as a set of checks in

[PATCH] D31404: [OpenCL] Allow alloca return non-zero private pointer

yaxunl marked 11 inline comments as done. yaxunl added inline comments. Comment at: include/clang/AST/ASTContext.h:2328 +return AddrSpaceMapMangling || + AS >= LangAS::target_first; } Anastasia wrote: > yaxunl wrote: > > yaxunl wrote: > > >

[PATCH] D29651: [OpenMP] Consider LIBRARY_PATH when selecting library paths for NVPTX targets in OpenMP mode.

ABataev added inline comments. Comment at: test/Driver/openmp-offload.c:622 +/// Check that the lib folder pointed to by the LIBRARY_PATH is correctly passsed to the loader script. +// RUN: LIBRARY_PATH=/a/b/c/lib %clang -### -fopenmp=libomp

r299671 - Fix unused lambda capture. Follow up to r299653.

Author: krasin Date: Thu Apr 6 12:42:05 2017 New Revision: 299671 URL: http://llvm.org/viewvc/llvm-project?rev=299671=rev Log: Fix unused lambda capture. Follow up to r299653. Modified: cfe/trunk/lib/Analysis/CloneDetection.cpp Modified: cfe/trunk/lib/Analysis/CloneDetection.cpp URL:

[libunwind] r299666 - Fix unused typedef. Follow up to r299575.

Author: krasin Date: Thu Apr 6 12:35:35 2017 New Revision: 299666 URL: http://llvm.org/viewvc/llvm-project?rev=299666=rev Log: Fix unused typedef. Follow up to r299575. Modified: libunwind/trunk/src/AddressSpace.hpp Modified: libunwind/trunk/src/AddressSpace.hpp URL:

[PATCH] D26794: [OpenCL] Blocks are allowed to capture arrays in OpenCL 2.0 and higher.

Anastasia added a comment. In https://reviews.llvm.org/D26794#598784, @Anastasia wrote: > I have created a bug to Khronos regarding this, but unfortunately I don't see > it being progressed yet. > https://cvs.khronos.org/bugzilla/show_bug.cgi?id=15659 > > The problem here is that I am not sure

[PATCH] D31745: [OpenCL] Added diagnostic for implicit declaration of function in OpenCL

Anastasia added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8254 "%0 cannot be used as the type of a kernel parameter">; +def err_opencl_implicit_function_decl : Error< + "implicit declaration of function %0 is invalid in OpenCL">;

[PATCH] D31417: [OpenMP] Add support for omp simd pragmas without runtime

kkwli0 added inline comments. Comment at: docs/ClangCommandLineReference.rst:1454 +.. option:: -fopenmp-simd, -fno-openmp-simd + I am not sure if it is target architecture specific or not. If it is, should we be under the target flag instead?

[PATCH] D31757: [clang-tidy] Add a clang-tidy check for possible inefficient vector operations

Eugene.Zelenko added a comment. Isn't such analysis is path-sensitive and should be implemented in Static Analyzer? Please mention this check in docs/ReleaseNotes.rst (in alphabetical order). Comment at: docs/clang-tidy/checks/performance-inefficient-vector-operation.rst:6

[PATCH] D31404: [OpenCL] Allow alloca return non-zero private pointer

Anastasia added inline comments. Comment at: include/clang/AST/ASTContext.h:2328 +return AddrSpaceMapMangling || + AS >= LangAS::target_first; } yaxunl wrote: > yaxunl wrote: > > Anastasia wrote: > > > Anastasia wrote: > > > > yaxunl wrote: > >

[PATCH] D31771: [AMDGPU] Temporarily change constant address space from 4 to 2 for the new address space mapping

t-tye added a comment. LGTM Comment at: lib/Basic/Targets.cpp:2083 Local = 3; -Constant = 4; +Constant = 2; Private = 5; t-tye wrote: > Since Constant is now the same regardless of the GIZ setting, should it be >

[PATCH] D31771: [AMDGPU] Temporarily change constant address space from 4 to 2 for the new address space mapping

t-tye accepted this revision. t-tye added a comment. This revision is now accepted and ready to land. Other than one comment: LGTM Comment at: lib/Basic/Targets.cpp:2083 Local = 3; -Constant = 4; +Constant = 2; Private = 5;

[PATCH] D31756: [cmake] Support Gentoo install for z3

ddcc accepted this revision. ddcc added a comment. This revision is now accepted and ready to land. Thanks! Repository: rL LLVM https://reviews.llvm.org/D31756 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31771: [AMDGPU] Temporarily change constant address space from 4 to 2 for the new address space mapping

yaxunl created this revision. Herald added subscribers: tpr, dstuttard, nhaehnle, wdng, kzhuravl. Change constant address space from 4 to 2 for the new address space mapping in Clang. https://reviews.llvm.org/D31771 Files: lib/Basic/Targets.cpp

[PATCH] D31769: Remove the binders `bind1st`, `bind2nd`, `men_fun`, etc from C++17

mclow.lists created this revision. As proposed in http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2014/n4190 I'm leaving `unary_function` and `binary_function` in place until I can figure out a non-ABI breaking way to remove them. To get them back in C++17, you can `-D

Re: [libcxx] r299652 - Restore Missing awk regex tests. Thanks to dexonsmith for noticing, and proposing this as https://reviews.llvm.org/D16541

Hi, I reverted in r299656. MacOS bot is broken both on 64 and 32 bits: http://green.lab.llvm.org/green/job/libcxx_master_cmake/83/ http://green.lab.llvm.org/green/job/libcxx_master_cmake_32/61/ It shouldn’t be too hard to fix though, it is full of the same error:

[clang-tools-extra] r299657 - [clang-tidy] Temporarily disable a test-case that does not work on windows.

Author: xazax Date: Thu Apr 6 10:58:57 2017 New Revision: 299657 URL: http://llvm.org/viewvc/llvm-project?rev=299657=rev Log: [clang-tidy] Temporarily disable a test-case that does not work on windows. Modified: clang-tools-extra/trunk/test/clang-tidy/misc-forwarding-reference-overload.cpp

[libcxx] r299656 - Revert "Restore Missing awk regex tests. Thanks to dexonsmith for noticing, and proposing this as https://reviews.llvm.org/D16541"

Author: mehdi_amini Date: Thu Apr 6 10:56:55 2017 New Revision: 299656 URL: http://llvm.org/viewvc/llvm-project?rev=299656=rev Log: Revert "Restore Missing awk regex tests. Thanks to dexonsmith for noticing, and proposing this as https://reviews.llvm.org/D16541; This reverts commit r299652,

[PATCH] D31766: [Clang][X86][SSE] Update MOVNTDQA non-temporal loads to generic implementation

RKSimon created this revision. MOVNTDQA non-temporal aligned vector loads can be correctly represented using generic builtin loads, allowing us to remove the existing x86 intrinsics. The LLVM companion patch will be published shortly. Repository: rL LLVM https://reviews.llvm.org/D31766

[PATCH] D31417: [OpenMP] Add support for omp simd pragmas without runtime

ABataev added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:122-123 createOpenCLRuntime(); - if (LangOpts.OpenMP) + if (LangOpts.OpenMP || LangOpts.OpenMPSimd) createOpenMPRuntime(); if (LangOpts.CUDA) I don't think you need to create

[PATCH] D31765: Skip Unicode character expansion in assembly files

salari01 created this revision. When using the C preprocessor with assembly files, either with a capital `S` file extension, or with `-xassembler-with-cpp`, the Unicode escape sequence `\u` is ignored. The `\u` pattern can be used for expanding a macro argument that starts with `u`.

[PATCH] D16541: [libc++] Renable test/std/re/re.alg/re.alg.match/awk.pass.cpp

mehdi_amini added a comment. This bot is broken: http://green.lab.llvm.org/green/job/libcxx_master_cmake_32/61/ https://reviews.llvm.org/D16541 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31404: [OpenCL] Allow alloca return non-zero private pointer

yaxunl added a comment. Ping! Any further questions? Thanks. https://reviews.llvm.org/D31404 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29651: [OpenMP] Consider LIBRARY_PATH when selecting library paths for NVPTX targets in OpenMP mode.

tstellar added a comment. Why is this necessary? Repository: rL LLVM https://reviews.llvm.org/D29651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30087: [Driver] Unify linking of OpenMP runtime. NFCI.

Hahnfeld updated this revision to Diff 94372. Hahnfeld marked 2 inline comments as done. Hahnfeld retitled this revision from "[Driver] Unify linking of OpenMP runtime" to "[Driver] Unify linking of OpenMP runtime. NFCI.". Hahnfeld edited the summary of this revision.

[PATCH] D30087: [Driver] Unify linking of OpenMP runtime. NFCI.

Hahnfeld added inline comments. Comment at: lib/Driver/ToolChains/CommonArgs.cpp:430 +bool tools::addOpenMPRuntime(ArgStringList , const ToolChain , + const ArgList , const JobAction , + bool GompNeedsRT) {

[PATCH] D29905: [OpenMP] Pass argument to device kernel by reference when map is used.

ABataev added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:358-360 + /// Do the check specified in \a Check to all component lists at a given level + /// and return true if any issue is found. + bool checkMappableExprComponentListsForDeclAtLevel(

r299653 - [analyzer] Reland r299544 "Add a modular constraint system to the CloneDetector"

Author: dergachev Date: Thu Apr 6 09:34:07 2017 New Revision: 299653 URL: http://llvm.org/viewvc/llvm-project?rev=299653=rev Log: [analyzer] Reland r299544 "Add a modular constraint system to the CloneDetector" Hopefully fix crashes by unshadowing the variable. Original commit message: A big

[PATCH] D23418: [analyzer] Added a reusable constraint system to the CloneDetector

This revision was automatically updated to reflect the committed changes. Closed by commit rL299653: [analyzer] Reland r299544 "Add a modular constraint system to the CloneDetector" (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D23418?vs=94337=94370#toc

[PATCH] D16541: [libc++] Renable test/std/re/re.alg/re.alg.match/awk.pass.cpp

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. committed as revision 299652 https://reviews.llvm.org/D16541 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r299652 - Restore Missing awk regex tests. Thanks to dexonsmith for noticing, and proposing this as https://reviews.llvm.org/D16541

Author: marshall Date: Thu Apr 6 09:32:42 2017 New Revision: 299652 URL: http://llvm.org/viewvc/llvm-project?rev=299652=rev Log: Restore Missing awk regex tests. Thanks to dexonsmith for noticing, and proposing this as https://reviews.llvm.org/D16541 Modified:

[clang-tools-extra] r299651 - [clang-tidy] Update docs and help message

Author: alexfh Date: Thu Apr 6 09:27:00 2017 New Revision: 299651 URL: http://llvm.org/viewvc/llvm-project?rev=299651=rev Log: [clang-tidy] Update docs and help message Modified: clang-tools-extra/trunk/clang-tidy/tool/ClangTidyMain.cpp clang-tools-extra/trunk/docs/clang-tidy/index.rst

[PATCH] D31745: [OpenCL] Added diagnostic for implicit declaration of function in OpenCL

yaxunl added a comment. What happens if user declared a function without parameter as `void f();` instead of `void f(void)` then try to use it? Will this be treated as implicit declaration and results in an error instead of warning? https://reviews.llvm.org/D31745

r299650 - Avoid the -Wdocumentation-unknown-command warning in Clang's C API docs

Author: arphaman Date: Thu Apr 6 09:03:25 2017 New Revision: 299650 URL: http://llvm.org/viewvc/llvm-project?rev=299650=rev Log: Avoid the -Wdocumentation-unknown-command warning in Clang's C API docs rdar://20441985 Modified: cfe/trunk/include/clang-c/Index.h Modified:

[PATCH] D31760: [lsan] Enable LSan on arm Linux, clang part

m.ostapenko created this revision. Herald added subscribers: rengolin, aemerson. This is a compiler part of https://reviews.llvm.org/D29586. Enable LSan on arm Linux. Repository: rL LLVM https://reviews.llvm.org/D31760 Files: lib/Driver/ToolChains/Linux.cpp test/Driver/fsanitize.c

[clang-tools-extra] r299649 - [clang-tidy] Add FormatStyle configuration option.

Author: alexfh Date: Thu Apr 6 08:41:29 2017 New Revision: 299649 URL: http://llvm.org/viewvc/llvm-project?rev=299649=rev Log: [clang-tidy] Add FormatStyle configuration option. Modified: clang-tools-extra/trunk/clang-tidy/ClangTidy.cpp clang-tools-extra/trunk/clang-tidy/ClangTidy.h

[PATCH] D31515: [libc++] Implement LWG 2911 - add an is_aggregate type-trait

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D31515 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31652: [clang-format] Recognize Java logical shift assignment operator

thakis added inline comments. Comment at: include/clang/Basic/TokenKinds.def:230 +PUNCTUATOR(greatergreatergreaterequal, ">>>=") +PUNCTUATOR(lesslesslessequal, "<<<=") + I think this is the wrong approach to go about this. clang is a C compiler, and its

[PATCH] D31597: [ObjC++] Conversions from specialized to non-specialized objective-c object type should be preferred over conversions to other object pointers

This revision was automatically updated to reflect the committed changes. Closed by commit rL299648: [ObjC++] Conversions from specialized to non-specialized Objective-C generic (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D31597?vs=93845=94360#toc Repository:

r299648 - [ObjC++] Conversions from specialized to non-specialized Objective-C generic

Author: arphaman Date: Thu Apr 6 08:06:34 2017 New Revision: 299648 URL: http://llvm.org/viewvc/llvm-project?rev=299648=rev Log: [ObjC++] Conversions from specialized to non-specialized Objective-C generic object types should be preferred over conversions to other object pointers This change

[PATCH] D31669: Fix lambda to block conversion in C++17 by avoiding copy elision for the lambda capture used by the created block

This revision was automatically updated to reflect the committed changes. Closed by commit rL299646: Fix lambda to block conversion in C++17 by avoiding copy elision for the (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D31669?vs=94177=94358#toc Repository: rL

r299646 - Fix lambda to block conversion in C++17 by avoiding copy elision for the

Author: arphaman Date: Thu Apr 6 07:53:43 2017 New Revision: 299646 URL: http://llvm.org/viewvc/llvm-project?rev=299646=rev Log: Fix lambda to block conversion in C++17 by avoiding copy elision for the lambda capture used by the created block The commit r288866 introduced guaranteed copy

[clang-tools-extra] r299645 - Attempt to fix build bots after r299638.

Author: xazax Date: Thu Apr 6 07:49:35 2017 New Revision: 299645 URL: http://llvm.org/viewvc/llvm-project?rev=299645=rev Log: Attempt to fix build bots after r299638. Modified: clang-tools-extra/trunk/test/clang-tidy/misc-forwarding-reference-overload.cpp Modified:

[PATCH] D31757: [clang-tidy] Add a clang-tidy check for possible inefficient vector operations

hokein updated this revision to Diff 94356. hokein added a comment. Fix a small nit. https://reviews.llvm.org/D31757 Files: clang-tidy/performance/CMakeLists.txt clang-tidy/performance/InefficientVectorOperationCheck.cpp clang-tidy/performance/InefficientVectorOperationCheck.h

[PATCH] D31757: [clang-tidy] Add a clang-tidy check for possible inefficient vector operations

hokein created this revision. Herald added a subscriber: mgorny. The "performance-inefficient-vector-operation" check finds vector oprations in for-loop statements which may cause multiple memory reallocations. This is the first version, only detects typical for-loop: std::vector v; for

[PATCH] D31756: [cmake] Support Gentoo install for z3

mgorny created this revision. Add the 'z3' subdirectory to the list of possible path suffixes for libz3 header search. The z3 headers are installed in /usr/include/z3 on Gentoo. Repository: rL LLVM https://reviews.llvm.org/D31756 Files: cmake/modules/FindZ3.cmake Index:

[PATCH] D31401: [clangd] Extract FsPath from file:// uri

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Looks good! https://reviews.llvm.org/D31401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29877: Warn about unused static file scope function template declarations.

v.g.vassilev updated this revision to Diff 94352. v.g.vassilev marked an inline comment as done. v.g.vassilev added a comment. Improve comment. https://reviews.llvm.org/D29877 Files: lib/Sema/Sema.cpp lib/Sema/SemaDecl.cpp test/SemaCXX/warn-unused-filescoped.cpp Index:

[PATCH] D29877: Warn about unused static file scope function template declarations.

v.g.vassilev updated this revision to Diff 94350. v.g.vassilev added a comment. Found out which is the right place to avoid the linkage computation issues. https://reviews.llvm.org/D29877 Files: lib/Sema/Sema.cpp lib/Sema/SemaDecl.cpp test/SemaCXX/warn-unused-filescoped.cpp Index:

[PATCH] D31746: Remove ASTUnits for closed documents and cache CompilationDatabase per directory in clangd.

krasimir added a comment. Looks great! I'm wondering, can you think of ways to test the `didClose` method similarly to how it's done for other handlers? Comment at: clangd/ASTManager.cpp:203 + // TODO(ibiryukov): at this point DocDatasLock can be unlocked in asynchronous +

[PATCH] D31652: [clang-format] Recognize Java logical shift assignment operator

bradfier added inline comments. Comment at: include/clang/Basic/LangOptions.def:95 LANGOPT(ObjC2 , 1, 0, "Objective-C 2") +LANGOPT(Java , 1, 0, "Java") BENIGN_LANGOPT(ObjCDefaultSynthProperties , 1, 0, arphaman wrote: > I don't think

[PATCH] D31652: [clang-format] Recognize Java logical shift assignment operator

bradfier added a comment. In https://reviews.llvm.org/D31652#719990, @arphaman wrote: > Are the `<<<` and `>>>` operators handled correctly? Yes, as a side-effect of CUDA kernel-call syntax which uses `>>>` and `<<<`, those tokens are recognised as punctuators. Repository: rL LLVM

[PATCH] D23418: [analyzer] Added a reusable constraint system to the CloneDetector

teemperor added a comment. I think for range loops work differently: #include #include #include struct Foo { int* begin() const { assert(false); } int* end() const { assert(false); } void bar() const { std::cout << "Different behavior" << std::endl; } }; int main() { std::vector

r299643 - [Sema] Retarget test to a specific platform for consistent datasizes

Author: sdardis Date: Thu Apr 6 06:12:14 2017 New Revision: 299643 URL: http://llvm.org/viewvc/llvm-project?rev=299643=rev Log: [Sema] Retarget test to a specific platform for consistent datasizes Attempt to satisfy llvm-clang-x86_64-expensive-checks-win by targeting x86_64-apple-darwin10 for

[PATCH] D31652: [clang-format] Recognize Java logical shift assignment operator

arphaman added inline comments. Comment at: include/clang/Basic/LangOptions.def:95 LANGOPT(ObjC2 , 1, 0, "Objective-C 2") +LANGOPT(Java , 1, 0, "Java") BENIGN_LANGOPT(ObjCDefaultSynthProperties , 1, 0, I don't think we should have a

[PATCH] D31652: [clang-format] Recognize Java logical shift assignment operator

arphaman added a comment. Are the `<<<` and `>>>` operators handled correctly? Repository: rL LLVM https://reviews.llvm.org/D31652 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r299642 - Wdocumentation fix

Author: rksimon Date: Thu Apr 6 05:49:02 2017 New Revision: 299642 URL: http://llvm.org/viewvc/llvm-project?rev=299642=rev Log: Wdocumentation fix Modified: clang-tools-extra/trunk/clang-rename/USRLocFinder.h Modified: clang-tools-extra/trunk/clang-rename/USRLocFinder.h URL:

[PATCH] D23418: [analyzer] Added a reusable constraint system to the CloneDetector

NoQ added a comment. $ cat test.c #include int main() { int i = 5; { int i = i; printf("%d\n", i); } return 0; } $ clang test.c $ ./a.out 32767 $ clang test.c -Xclang -ast-dump ... `-FunctionDecl 0x7ff82d8eac78 line:2:5 main

r299641 - [Sema] Extend GetSignedVectorType to deal with non ExtVector types

Author: sdardis Date: Thu Apr 6 05:38:03 2017 New Revision: 299641 URL: http://llvm.org/viewvc/llvm-project?rev=299641=rev Log: [Sema] Extend GetSignedVectorType to deal with non ExtVector types This improves some error messages which would otherwise refer to ext_vector_type types in contexts

[PATCH] D31667: [Sema] Extend GetSignedVectorType to deal with non ExtVector types

This revision was automatically updated to reflect the committed changes. Closed by commit rL299641: [Sema] Extend GetSignedVectorType to deal with non ExtVector types (authored by sdardis). Changed prior to commit: https://reviews.llvm.org/D31667?vs=94205=94344#toc Repository: rL LLVM

  1   2   >