jdoerrie added a comment.
Ping, please take a look at this.
https://reviews.llvm.org/D32788
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302765: [Sema] Improve redefinition errors pointing to the
same header (authored by bruno).
Changed prior to commit:
https://reviews.llvm.org/D28832?vs=95369&id=98584#toc
Repository:
rL LLVM
https:/
Author: bruno
Date: Thu May 11 01:20:07 2017
New Revision: 302765
URL: http://llvm.org/viewvc/llvm-project?rev=302765&view=rev
Log:
[Sema] Improve redefinition errors pointing to the same header
Diagnostics related to redefinition errors that point to the same header
file do not provide much info
Author: ahatanak
Date: Thu May 11 01:17:49 2017
New Revision: 302764
URL: http://llvm.org/viewvc/llvm-project?rev=302764&view=rev
Log:
Revert "[libcxxabi] Align unwindHeader on a double-word boundary."
This reverts commit r302763.
The commit caused bot failures.
Removed:
libcxxabi/trunk/tes
echuraev added a comment.
So, I think that we have to do some decision about this patch. @Anastasia, What
do you think about it? Please see my commentary above. What should we do with
this patch?
https://reviews.llvm.org/D27334
___
cfe-commits mai
smeenai added a comment.
@EricWF and I discussed this on IRC a bit. I'm not a fan of overloading
`_LIBCPP_WIN32API` for this purpose, since to me that macro is meant for
guarding Windows API functions, not for CRT functions. Eric suggested adding a
new macro `_LIBCPP_MSVCRT_LIKE`, which I'd be
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302763: [libcxxabi] Align unwindHeader on a double-word
boundary. (authored by ahatanak).
Changed prior to commit:
https://reviews.llvm.org/D33030?vs=98401&id=98583#toc
Repository:
rL LLVM
https://r
Author: ahatanak
Date: Thu May 11 00:58:52 2017
New Revision: 302763
URL: http://llvm.org/viewvc/llvm-project?rev=302763&view=rev
Log:
[libcxxabi] Align unwindHeader on a double-word boundary.
r276215 made a change to annotate _Unwind_Exception with attribute
"aligned" so that an exception object
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
One nit, otherwise looks good.
Comment at: lib/Format/UnwrappedLineFormatter.cpp:368
// We don't merge short records.
- if (Line.First->isOneOf(tok::kw_class, t
Author: ericwf
Date: Thu May 11 00:05:06 2017
New Revision: 302762
URL: http://llvm.org/viewvc/llvm-project?rev=302762&view=rev
Log:
Revert "Rename c++abi.a on Windows to libc++abi to avoid name conflicts"
This reverts commit r302759
Modified:
libcxxabi/trunk/src/CMakeLists.txt
Modified: li
Author: ericwf
Date: Wed May 10 22:49:48 2017
New Revision: 302761
URL: http://llvm.org/viewvc/llvm-project?rev=302761&view=rev
Log:
Allow undefined symbols when linking libc++abi.dll on Windows
Modified:
libcxxabi/trunk/CMakeLists.txt
Modified: libcxxabi/trunk/CMakeLists.txt
URL:
http://ll
ahatanak updated this revision to Diff 98578.
ahatanak added a comment.
Rebase.
https://reviews.llvm.org/D25001
Files:
lib/Serialization/ASTReaderDecl.cpp
test/Modules/Inputs/merge-non-prototype-fn/header2.h
test/Modules/Inputs/merge-non-prototype-fn/module.map
test/Modules/merge-non-pr
Author: ericwf
Date: Wed May 10 22:29:59 2017
New Revision: 302760
URL: http://llvm.org/viewvc/llvm-project?rev=302760&view=rev
Log:
Fix Libc++abi linking under MinGW64
Modified:
libcxxabi/trunk/cmake/config-ix.cmake
libcxxabi/trunk/src/CMakeLists.txt
Modified: libcxxabi/trunk/cmake/conf
Author: ericwf
Date: Wed May 10 22:18:29 2017
New Revision: 302759
URL: http://llvm.org/viewvc/llvm-project?rev=302759&view=rev
Log:
Rename c++abi.a on Windows to libc++abi to avoid name conflicts
Modified:
libcxxabi/trunk/src/CMakeLists.txt
Modified: libcxxabi/trunk/src/CMakeLists.txt
URL:
Author: chapuni
Date: Wed May 10 21:43:47 2017
New Revision: 302758
URL: http://llvm.org/viewvc/llvm-project?rev=302758&view=rev
Log:
Prune unused \param(s) of clang::Parser::ParseTemplateIdAfterTemplateName() in
r302737. [-Wdocumentation]
Modified:
cfe/trunk/lib/Parse/ParseTemplate.cpp
Mod
Author: chapuni
Date: Wed May 10 21:39:30 2017
New Revision: 302757
URL: http://llvm.org/viewvc/llvm-project?rev=302757&view=rev
Log:
clang/test/CodeGenCXX/array-default-argument.cpp: Satisfy targets that have
x86_thiscallcc.
Modified:
cfe/trunk/test/CodeGenCXX/array-default-argument.cpp
Mo
Author: ericwf
Date: Wed May 10 21:01:05 2017
New Revision: 302755
URL: http://llvm.org/viewvc/llvm-project?rev=302755&view=rev
Log:
Don't use posix_memalign under MinGW
Modified:
libcxxabi/trunk/src/stdlib_new_delete.cpp
Modified: libcxxabi/trunk/src/stdlib_new_delete.cpp
URL:
http://llvm.
Author: ericwf
Date: Wed May 10 21:00:25 2017
New Revision: 302754
URL: http://llvm.org/viewvc/llvm-project?rev=302754&view=rev
Log:
Apply libc++ MinGW CMake fix to libc++abi
Modified:
libcxxabi/trunk/cmake/config-ix.cmake
Modified: libcxxabi/trunk/cmake/config-ix.cmake
URL:
http://llvm.org
zaks.anna added a comment.
Thank you for the patch! Could you please re-submit the patch with context?
Instructions on how to do that can be found here:
http://llvm.org/docs/Phabricator.html
Repository:
rL LLVM
https://reviews.llvm.org/D32449
__
george.burgess.iv added a comment.
I'd be happy with that approach. Do you like it, Aaron?
FWIW, I did a bit of archaeology, and it looks like the commit that added the
requirement that all overloads must have `overloadable` (r64414) did so to keep
users from "trying to be too sneaky for their
rsmith added a comment.
I'd like to suggest an alternative design: don't add a new attribute., and
instead change the semantics of `__attribute__((overloadable))` to permit at
most one non-overloadable function in an overload set. That one function would
implicitly get the `transparently_overlo
EricWF created this revision.
This patch corrects the build errors I encountered when building on MinGW64.
https://reviews.llvm.org/D33082
Files:
include/__locale
include/locale
include/stdio.h
include/support/win32/locale_win32.h
include/wchar.h
src/new.cpp
src/support/win32/loca
Author: rsmith
Date: Wed May 10 19:17:17 2017
New Revision: 302750
URL: http://llvm.org/viewvc/llvm-project?rev=302750&view=rev
Log:
PR22877: When constructing an array via a constructor with a default argument
in list-initialization, run cleanups for the default argument after each
iteration of t
george.burgess.iv added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:2921
+ const auto *NewOvl = New->getAttr();
+ if (NewOvl->isTransparent() != OldOvl->isTransparent()) {
+assert(!NewOvl->isImplicit() &&
aaron.ballman wrote:
> Can `NewOv
george.burgess.iv updated this revision to Diff 98569.
george.burgess.iv marked 7 inline comments as done.
george.burgess.iv added a comment.
- Addressed all feedback
- Now we emit a warning when `transparently_overloadable` "overrides"
`overloadable`, rather than an error
https://reviews.llvm.
mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D33030#751723, @ahatanak wrote:
> If field unwindHeader is annotated with the aligned attribute, both the field
> and struct __cxa_exception are aligned.
EricWF updated this revision to Diff 98562.
EricWF added a comment.
- Fix unterminated preprocessor directive.
https://reviews.llvm.org/D33080
Files:
include/__bit_reference
include/__config
include/__hash_table
include/__mutex_base
include/__split_buffer
include/__std_stream
incl
Author: ericwf
Date: Wed May 10 18:29:13 2017
New Revision: 302743
URL: http://llvm.org/viewvc/llvm-project?rev=302743&view=rev
Log:
Workaround -W#warnings on Windows until the correct fixes can land
Modified:
libcxx/trunk/utils/libcxx/test/config.py
Modified: libcxx/trunk/utils/libcxx/test/
ahatanak added a comment.
In https://reviews.llvm.org/D33030#751187, @mehdi_amini wrote:
> Something still isn't clear to me: the issue IIUC is not with the
> `unwindHeader` itself, but with the misaligned thrown object that is
> allocated right after the __cxa_exception itself. Isn't it?
>
> T
EricWF updated this revision to Diff 98561.
EricWF added a comment.
- Remove failing test. This patch cannot be easily tested because the system's
libc might also mess with the definitions of `min` and `max`.
https://reviews.llvm.org/D33080
Files:
include/__bit_reference
include/__config
EricWF created this revision.
Herald added a subscriber: krytarowski.
This patch improves how libc++ handles min/max macros within the headers.
Previously libc++ would undef them and emit a warning.
This patch changes libc++ to use `#pragma push_macro` to save the macro before
undefining it, an
Author: chapuni
Date: Wed May 10 17:30:44 2017
New Revision: 302741
URL: http://llvm.org/viewvc/llvm-project?rev=302741&view=rev
Log:
clang/lib/Tooling/RefactoringCallbacks.cpp: Avoid std::errc::bad_message.
Modified:
cfe/trunk/lib/Tooling/RefactoringCallbacks.cpp
Modified: cfe/trunk/lib/Too
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
https://reviews.llvm.org/D32977
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
ddcc updated this revision to Diff 98545.
ddcc added a comment.
Rebase
https://reviews.llvm.org/D28953
Files:
include/clang/StaticAnalyzer/Checkers/SValExplainer.h
lib/StaticAnalyzer/Core/SValBuilder.cpp
lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp
test/Analysis/bitwise-ops.c
test/An
Author: adrian
Date: Wed May 10 17:14:23 2017
New Revision: 302740
URL: http://llvm.org/viewvc/llvm-project?rev=302740&view=rev
Log:
Partially revert r302685 and swith Apple-style full LTO builds to
-gline-tables-only. The memory consumption is apparently still too
much for some of the green drago
ddcc added a comment.
It's been a while since I looked at the code, but I don't believe that all of
the new constraints are necessarily unsupported by the current range constraint
manager. Rather, they were just not being generated by the SimpleSValBuilder.
The changes pass the testsuite for bo
bruno accepted this revision.
bruno added a comment.
Hi Sean,
LGTM! One comment below.
Comment at: tools/clang-import-test/clang-import-test.cpp:263
+AddExternalSource(*CI, Imports);
+ }
No need for the curly braces here
https://reviews.llvm.org/D3298
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302739: [libc++abi] Disable libc++ extern templates
project-wide (authored by smeenai).
Changed prior to commit:
https://reviews.llvm.org/D32329?vs=96061&id=98540#toc
Repository:
rL LLVM
https://rev
Author: smeenai
Date: Wed May 10 16:52:39 2017
New Revision: 302739
URL: http://llvm.org/viewvc/llvm-project?rev=302739&view=rev
Log:
[libc++abi] Disable libc++ extern templates project-wide
libc++abi can't depend on libc++, so disable extern templates in libc++
headers project-wide. This was pre
smeenai added a comment.
Confirmed that there are no ABI changed on both Linux and macOS.
https://reviews.llvm.org/D32329
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302738: [Myriad] Pass -Xclang and -mllvm flags to
moviCompile (authored by jyknight).
Changed prior to commit:
https://reviews.llvm.org/D33020?vs=98369&id=98538#toc
Repository:
rL LLVM
https://revie
Author: jyknight
Date: Wed May 10 16:48:13 2017
New Revision: 302738
URL: http://llvm.org/viewvc/llvm-project?rev=302738&view=rev
Log:
[Myriad] Pass -Xclang and -mllvm flags to moviCompile
Patch by Walter Lee.
Differential Revision: https://reviews.llvm.org/D33020
Modified:
cfe/trunk/lib/Dr
Author: rsmith
Date: Wed May 10 16:47:30 2017
New Revision: 302737
URL: http://llvm.org/viewvc/llvm-project?rev=302737&view=rev
Log:
Changes missed from r302732.
Modified:
cfe/trunk/include/clang/Parse/Parser.h
cfe/trunk/lib/Parse/ParseDeclCXX.cpp
cfe/trunk/lib/Parse/ParseExprCXX.cpp
Author: ericwf
Date: Wed May 10 16:40:58 2017
New Revision: 302736
URL: http://llvm.org/viewvc/llvm-project?rev=302736&view=rev
Log:
Remove usages of _LIBCPP_MSVC which is never defined
Modified:
libcxx/trunk/include/__config
libcxx/trunk/include/__undef_min_max
libcxx/trunk/include/e
Author: ericwf
Date: Wed May 10 16:34:58 2017
New Revision: 302734
URL: http://llvm.org/viewvc/llvm-project?rev=302734&view=rev
Log:
Fix MinGW build to use Pthread when the header is available.
Some MinGW configurations use WinPThread instead of the native
threading interfaces. When this happens
Author: rsmith
Date: Wed May 10 16:32:16 2017
New Revision: 302732
URL: http://llvm.org/viewvc/llvm-project?rev=302732&view=rev
Log:
Improve diagnosis of unknown template name.
When an undeclared identifier in a context that requires a type is followed by
'<', only look for type templates when ty
Author: ericwf
Date: Wed May 10 16:30:04 2017
New Revision: 302731
URL: http://llvm.org/viewvc/llvm-project?rev=302731&view=rev
Log:
Don't interfere with the __builtin_foo namespace under MSVC
This patch follows up on feedback received in the review for
D32988. Specifically that libc++ should not
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D33013
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
Author: bion
Date: Wed May 10 15:58:30 2017
New Revision: 302728
URL: http://llvm.org/viewvc/llvm-project?rev=302728&view=rev
Log:
Fix bad #endif in msvc_stdlib_force_include.hpp.
Modified:
libcxx/trunk/test/support/msvc_stdlib_force_include.hpp
Modified: libcxx/trunk/test/support/msvc_stdli
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302727: [libc++] Refactor Windows support headers. (authored
by EricWF).
Changed prior to commit:
https://reviews.llvm.org/D32988?vs=98528&id=98530#toc
Repository:
rL LLVM
https://reviews.llvm.org/D
Author: ericwf
Date: Wed May 10 15:57:45 2017
New Revision: 302727
URL: http://llvm.org/viewvc/llvm-project?rev=302727&view=rev
Log:
[libc++] Refactor Windows support headers.
Summary:
This patch refactors and tries to remove as much of the Windows support headers
as possible. This is needed bec
EricWF accepted this revision.
EricWF added a comment.
@compnerd I'm going to go ahead and land this and then submit a separate review
for the changes you've requested. I hope you don't mind :-)
https://reviews.llvm.org/D32988
___
cfe-commits maili
bcraig added a comment.
LGTM
https://reviews.llvm.org/D32988
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Wed May 10 15:37:43 2017
New Revision: 302724
URL: http://llvm.org/viewvc/llvm-project?rev=302724&view=rev
Log:
Implement LWG 2591 - Patch from K-Ballo
Modified:
libcxx/trunk/test/std/utilities/function.objects/func.wrap/func.wrap.func/func.wrap.func.targ/target.pass.cpp
EricWF updated this revision to Diff 98528.
EricWF added a comment.
- General cleanup changes.
Libc++ trunk currently doesn't build under MinGW, so I'm not concerned about
breaking that worse with this patch. I've set up a Appveyor builder to track
MinGW so we can get it green later.
Also I'm
Author: ericwf
Date: Wed May 10 15:19:35 2017
New Revision: 302723
URL: http://llvm.org/viewvc/llvm-project?rev=302723&view=rev
Log:
XFAIL is_trivially_copyable test for compilers that don't implement Core 2094
Modified:
libcxx/trunk/test/std/utilities/meta/meta.unary/meta.unary.prop/is_triv
ddcc added a comment.
In https://reviews.llvm.org/D28952#750558, @iris wrote:
> How can I make z3constraintmanager.cpp work in the command line?Or how to
> make z3 work?
You'll need a bleeding-edge build of Clang/LLVM, since this isn't available in
any stable release yet. First, build or inst
Author: ericwf
Date: Wed May 10 15:09:20 2017
New Revision: 302721
URL: http://llvm.org/viewvc/llvm-project?rev=302721&view=rev
Log:
Fix enable_shared_from_this test in C++11
Modified:
libcxx/trunk/test/std/utilities/memory/util.smartptr/util.smartptr.enab/enable_shared_from_this.pass.cpp
M
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302720: Fix errored return value in CheckFunctionReturnType
and add a fixit hint (authored by erichkeane).
Changed prior to commit:
https://reviews.llvm.org/D32759?vs=98504&id=98516#toc
Repository:
r
Author: erichkeane
Date: Wed May 10 15:03:16 2017
New Revision: 302720
URL: http://llvm.org/viewvc/llvm-project?rev=302720&view=rev
Log:
Fix errored return value in CheckFunctionReturnType and add a fixit hint
As discovered by ChenWJ and listed on cfe-dev, the error for Objective C
return type e
alexshap created this revision.
alexshap created this object with visibility "All Users".
1. Add missing "explicit" for single argument constructors
2. Add missing std::move in ReplaceNodeWithTemplate constructor
and switch to pass-by-value idiom
Test plan:
make check-clang
Repository:
rL LL
efriedma added a comment.
Err, oh, meant to add one minor comment: please rename "method-bad-param.mm" to
"interface-return-type.mm".
https://reviews.llvm.org/D32759
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D32759
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
stringham added a comment.
If the parameter list fits within the column limit, and there are no trailing
commas, then we don't end up wrapping the closing paren.
If it is long enough that it causes wrapping (regardless of trailing commas),
and the wrapping happens directly after the opening par
Author: ericwf
Date: Wed May 10 14:55:42 2017
New Revision: 302713
URL: http://llvm.org/viewvc/llvm-project?rev=302713&view=rev
Log:
Clean up LIT failure output by not showing the entire environment
Modified:
libcxx/trunk/utils/libcxx/test/executor.py
Modified: libcxx/trunk/utils/libcxx/test
yaxunl updated this revision to Diff 98510.
yaxunl marked an inline comment as done.
yaxunl added a comment.
Revised by John's comments.
https://reviews.llvm.org/D32977
Files:
include/clang/AST/Decl.h
lib/CodeGen/CGDecl.cpp
lib/Sema/SemaDecl.cpp
test/CodeGenOpenCL/amdgpu-debug-info-poin
stringham added a comment.
I think we should have the option whether or not a trailing comma is preset for
a few reasons:
1. clang-format doesn't support enforcing adding trailing commas
2. trailing commas aren't always supported (if you use the rest operator)
- `Uncaught SyntaxError: Rest par
Author: bion
Date: Wed May 10 14:43:31 2017
New Revision: 302710
URL: http://llvm.org/viewvc/llvm-project?rev=302710&view=rev
Log:
Update is_trivially_copyable tests with CWG 2094
Clang 5.0 implements these changes here:
https://github.com/llvm-mirror/clang/commit/87cd035326a39523eeb1b295ad36cff
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302710: Update is_trivially_copyable tests with CWG 2094
(authored by bion).
Changed prior to commit:
https://reviews.llvm.org/D33021?vs=98506&id=98508#toc
Repository:
rL LLVM
https://reviews.llvm.o
BillyONeal updated this revision to Diff 98506.
BillyONeal added a comment.
Added spaces requested by Marshal.
https://reviews.llvm.org/D33021
Files:
test/std/utilities/meta/meta.unary/meta.unary.prop/is_trivially_copyable.pass.cpp
Index:
test/std/utilities/meta/meta.unary/meta.unary.prop
Author: ericwf
Date: Wed May 10 14:35:49 2017
New Revision: 302709
URL: http://llvm.org/viewvc/llvm-project?rev=302709&view=rev
Log:
[libc++] Fix PR32979 - types with a private std::enable_shared_from_this base
break shared_ptr
Summary:
This patch fixes bugs.llvm.org/PR32979.
[util.smartptr.sh
mprobst added a comment.
So, currently clang-format doesn't really understand trailing commas in
parenthesized lists (such as parameter declarations or lists). It should, and
coincidentally I was just yesterday trying to get that working in
https://reviews.llvm.org/D33023.
Regarding the option
erichkeane updated this revision to Diff 98504.
https://reviews.llvm.org/D32759
Files:
lib/Sema/SemaType.cpp
test/SemaObjC/method-bad-param.m
test/SemaObjCXX/method-bad-param.mm
Index: lib/Sema/SemaType.cpp
===
--- lib/Sema/S
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM. The bots are already failing because I upgraded their compilers.
@BillyONeal Can you commit this soon so I can clean up any fallout?
https://reviews.llvm.org/D33021
_
yaxunl marked 3 inline comments as done.
yaxunl added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:10286
+ // these variables must be a compile time constant.
+ VDecl->getType().getAddressSpace() == LangAS::opencl_constant)
CheckForConstantInitial
erichkeane added a comment.
In https://reviews.llvm.org/D32759#751350, @efriedma wrote:
> Err, I meant the one I wrote earlier in this thread:
> https://reviews.llvm.org/D32759#748007
AH! I missed that one. I'll create a new file in SemaObjCXX then.
https://reviews.llvm.org/D32759
__
rjmccall added inline comments.
Comment at: lib/CodeGen/CGDecl.cpp:158
+ // variable in constant address space in OpenCL.
+ if (D.getStorageDuration() != SD_Automatic && !D.hasExternalStorage()) {
llvm::GlobalValue::LinkageTypes Linkage =
Please rearrange
efriedma added a comment.
Err, I meant the one I wrote earlier in this thread:
https://reviews.llvm.org/D32759#748007
https://reviews.llvm.org/D32759
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
erichkeane added a comment.
In https://reviews.llvm.org/D32759#751339, @efriedma wrote:
> Our behavior for your testcase is less than ideal (we should be generating an
> invalid declaration instead of just dropping it on the floor), but that's not
> something you need to fix here.
>
> Could you
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302707: [test] support machinery changes for EDG & C1XX /Za
(authored by CaseyCarter).
Changed prior to commit:
https://reviews.llvm.org/D32778?vs=97530&id=98503#toc
Repository:
rL LLVM
https://revi
Author: caseycarter
Date: Wed May 10 14:10:49 2017
New Revision: 302707
URL: http://llvm.org/viewvc/llvm-project?rev=302707&view=rev
Log:
[test] support machinery changes for EDG & C1XX /Za
This change works around a couple of bugs:
1. EDG doesn't like explicit constexpr in a derived class. This
efriedma added a comment.
Our behavior for your testcase is less than ideal (we should be generating an
invalid declaration instead of just dropping it on the floor), but that's not
something you need to fix here.
Could you also include the Objective-C++ testcase I wrote? Or does it not work
aaron.ballman added inline comments.
Comment at: lib/AST/ItaniumMangle.cpp:583
+// Non-transparent overloadable functions need mangling.
+if (auto *A = FD->getAttr())
+ if (!A->isTransparent())
`const auto *`
Comment at: lib/AST/Mi
rjmccall added inline comments.
Comment at: lib/CodeGen/TargetInfo.cpp:7291
+ Address adjustAddrSpaceForAutoVar(Address A, const VarDecl *VD,
+ CodeGen::CodeGenFunction &CGF) const override;
};
How about, instead of introducing a second method, we just cha
spyffe marked an inline comment as done.
spyffe added inline comments.
Comment at: lib/AST/ASTImporter.cpp:1757
D2->setAnonymousStructOrUnion(true);
+if (PrevDecl) {
+ D2->setPreviousDecl(PrevDecl);
a.sidorin wrote:
> By the way, should we do the
spyffe updated this revision to Diff 98497.
spyffe added a comment.
• Added a FIXME per Aleksei Sidorin's suggestion.
https://reviews.llvm.org/D32981
Files:
include/clang/AST/ExternalASTMerger.h
lib/AST/ASTImporter.cpp
lib/AST/ASTStructuralEquivalence.cpp
lib/AST/ExternalASTMerger.cpp
erichkeane updated this revision to Diff 98495.
erichkeane added a reviewer: eli.friedman.
erichkeane added a comment.
Added a test, found a slight difference in behavior!
https://reviews.llvm.org/D32759
Files:
lib/Sema/SemaType.cpp
test/SemaObjC/method-bad-param.m
Index: lib/Sema/SemaTyp
Author: ericwf
Date: Wed May 10 12:52:53 2017
New Revision: 302698
URL: http://llvm.org/viewvc/llvm-project?rev=302698&view=rev
Log:
Fix use of now removed %exec test substitution
Modified:
libcxxabi/trunk/test/native/arm-linux-eabi/ttype-encoding-00.pass.sh.s
libcxxabi/trunk/test/native/
stringham added a comment.
1. be used in a project of significant size (have dozens of contributors)
- We are using this at Lucid Software (https://www.lucidchart.com &
https://www.lucidpress.com) to format our JS and TS (we are using clang-format
to automatically style over 650,000 lines of c
Hello everyone,
I'm about to set up a new builder which would build LLVM and Clang with
gcc-6 and -DLLVM_ENABLE_WERROR=ON.
Please find the staged builder connected to the silent master. Currently it
shows 14 warnings we would need to resolve before we could promote the
builder to the production.
Author: epilk
Date: Wed May 10 12:18:56 2017
New Revision: 302695
URL: http://llvm.org/viewvc/llvm-project?rev=302695&view=rev
Log:
[Sema] Objective-C++ support for type trait __is_base_of
rdar://24308607
Differential revision: https://reviews.llvm.org/D32891
Added:
cfe/trunk/test/SemaObjCX
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302695: [Sema] Objective-C++ support for type trait
__is_base_of (authored by epilk).
Changed prior to commit:
https://reviews.llvm.org/D32891?vs=97905&id=98490#toc
Repository:
rL LLVM
https://revie
jtony created this revision.
The vec_xxpermdi builtin is missing from altivec.h. This has been requested by
developers working on libvpx for VP9 support for Google. Initially, I tried to
define a new intrinsic to map it to the corresponding PowerPC hard instruction
(XXPERMDI) directly. But the
mehdi_amini added a comment.
Something still isn't clear to me: the issue IIUC is not with the
`unwindHeader` itself, but with the misaligned thrown object that is allocated
right after the __cxa_exception itself. Isn't it?
Then are you aligning the `unwindHeader` field and by side-effect the s
BillyONeal added a comment.
In https://reviews.llvm.org/D33021#751145, @BillyONeal wrote:
> Hmm we actually took steps to do the opposite in std::copy -- to use
> memcpy even in the presence of volatile -- as a result of this change.
;) http://imgur.com/a/PMKPS
https://reviews.llvm.org/D
rjmccall added a comment.
The right fix is probably just to make sure that EmitLValueForField doesn't add
TBAA information when the base LValue doesn't have it. That will also fix
problems with recursive member access where the base is may_alias.
Repository:
rL LLVM
https://reviews.llvm.or
That’s a good idea, if you don’t get to it I’ll look into it at some point
later on but it will probably not be soon.
> On May 10, 2017, at 9:10 AM, Alex L wrote:
>
>
>
> On 10 May 2017 at 16:10, Argyrios Kyrtzidis via cfe-commits
> mailto:cfe-commits@lists.llvm.org>> wrote:
> Author: akirtz
BillyONeal added a comment.
In https://reviews.llvm.org/D33021#750831, @mclow.lists wrote:
> FWIW, I think this is a language change that core got wrong, and it has
> already come back to bite us. (https://bugs.llvm.org/show_bug.cgi?id=28527)
Hmm we actually took steps to do the opposite i
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302688: [clang-tidy][CMake] Make clang-tidy usable as
distribution component (authored by phosek).
Changed prior to commit:
https://reviews.llvm.org/D32815?vs=97683&id=98479#toc
Repository:
rL LLVM
Author: phosek
Date: Wed May 10 11:20:54 2017
New Revision: 302688
URL: http://llvm.org/viewvc/llvm-project?rev=302688&view=rev
Log:
[clang-tidy][CMake] Make clang-tidy usable as distribution component
Use add_clang_tool rather than add_clang_executable to support
clang-tidy as a distribution com
1 - 100 of 150 matches
Mail list logo
