r303488 - [Devirtualization] insert placement new barrier with -O0

Author: prazek Date: Sat May 20 03:56:18 2017 New Revision: 303488 URL: http://llvm.org/viewvc/llvm-project?rev=303488&view=rev Log: [Devirtualization] insert placement new barrier with -O0 Summary: To not break LTO with different optimizations levels, we should insert the barrier regardles of op

[PATCH] D32401: [Devirtualization] insert placement new barrier with -O0

This revision was automatically updated to reflect the committed changes. Closed by commit rL303488: [Devirtualization] insert placement new barrier with -O0 (authored by Prazek). Changed prior to commit: https://reviews.llvm.org/D32401?vs=96313&id=99667#toc Repository: rL LLVM https://revi

[PATCH] D31830: Emit invariant.group.barrier when using union field

Prazek added a reviewer: mehdi_amini. Prazek added a comment. Ping https://reviews.llvm.org/D31830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

Prazek added inline comments. Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.cpp:76 + + for (const auto Parent : Context->getParents(node)) { +if (isCaughtInFunction(Context, Throw, Function, Parent)) unnecessary braces Comment at: cla

[PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

Prazek added inline comments. Comment at: docs/ReleaseNotes.rst:58 +- New `misc-throw-with-noexcept + `_ check I think this should be in alphabetical order. https://reviews.llvm.o

[PATCH] D32449: Modifying PthreadLockChecker.cpp to reduce false positives.

NoQ added a comment. Thanks! Your code looks very clear now, and it seems correct to me. One last thing we definitely should do here would be add regression tests for the new functionality. I guess you already have your tests, otherwise you wouldn't know if your code works, so you'd just need t

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

aaron.ballman added a comment. As an FYI, there is a related check currently under development in clang-tidy; we probably should not duplicate this functionality in both places. See https://reviews.llvm.org/D19201 for the other review. https://reviews.llvm.org/D3 ___

[PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

aaron.ballman added a comment. As an FYI, there is a related check being implemented in clang currently; we probably should not duplicate this effort. See https://reviews.llvm.org/D3. https://reviews.llvm.org/D19201 ___ cfe-commits mailing list

[PATCH] D32936: [clang] Add support for Ananas platform

ed accepted this revision. ed added a comment. This revision is now accepted and ready to land. These changes look all right to me, except that I'd like it if someone else could take a look at `Ananas.cpp` as well. Is anyone interested in taking a look? https://reviews.llvm.org/D32936 _

[PATCH] D32449: Modifying PthreadLockChecker.cpp to reduce false positives.

malhar1995 marked 2 inline comments as done. malhar1995 added a comment. In https://reviews.llvm.org/D32449#760141, @NoQ wrote: > Thanks! Your code looks very clear now, and it seems correct to me. > > One last thing we definitely should do here would be add regression tests for > the new functi

[PATCH] D32751: [ASTImporter] Support new kinds of declarations (mostly Using*)

a.sidorin updated this revision to Diff 99668. a.sidorin added a comment. Replaced cast<> with cast_or_null<>. https://reviews.llvm.org/D32751 Files: lib/AST/ASTImporter.cpp test/ASTMerge/namespace/Inputs/namespace1.cpp test/ASTMerge/namespace/Inputs/namespace2.cpp test/ASTMerge/namespa

[PATCH] D32751: [ASTImporter] Support new kinds of declarations (mostly Using*)

a.sidorin updated this revision to Diff 99669. a.sidorin added a comment. Removed accidentally duplicated comment. https://reviews.llvm.org/D32751 Files: lib/AST/ASTImporter.cpp test/ASTMerge/namespace/Inputs/namespace1.cpp test/ASTMerge/namespace/Inputs/namespace2.cpp test/ASTMerge/nam

[PATCH] D32751: [ASTImporter] Support new kinds of declarations (mostly Using*)

a.sidorin added inline comments. Comment at: lib/AST/ASTImporter.cpp:1311 + EmptyDecl *ToD = EmptyDecl::Create(Importer.getToContext(), DC, Loc); + ToD->setLexicalDeclContext(LexicalDC); + LexicalDC->addDeclInternal(ToD); xazax.hun wrote: > Don't we need an Im

[PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

sbarzowski updated this revision to Diff 99670. sbarzowski marked 5 inline comments as done. sbarzowski added a comment. Cosmetic https://reviews.llvm.org/D19201 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/ThrowWithNoexceptCheck.cpp clang-tid

[PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

sbarzowski marked 3 inline comments as done. sbarzowski added inline comments. Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.cpp:25 + Finder->addMatcher( + cxxThrowExpr(stmt(hasAncestor(functionDecl(isNoThrow()).bind("func" + .bind("throw"), --

[PATCH] D32449: Modifying PthreadLockChecker.cpp to reduce false positives.

malhar1995 added inline comments. Comment at: lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp:143-146 +if(lstate->isSchrodingerUntouched()) + state = state->remove(lockR); +else if(lstate->isSchrodingerUnlocked()) + state = state->set(lockR, LockState::getUnl

[PATCH] D31608: [coroutines] Add emission of initial and final suspends

GorNishanov added a comment. @EricWF: Can you take a quick look? Just a sanity check. The change is rather trivial. https://reviews.llvm.org/D31608 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

r303492 - Fix PR25627: constant expressions being odr-used in template arguments.

Author: faisalv Date: Sat May 20 14:58:04 2017 New Revision: 303492 URL: http://llvm.org/viewvc/llvm-project?rev=303492&view=rev Log: Fix PR25627: constant expressions being odr-used in template arguments. This patch ensures that clang processes the expression-nodes that are generated when disam

[PATCH] D33363: [mips] Support `micromips` attribute

sdardis added inline comments. Comment at: include/clang/Basic/AttrDocs.td:1277-1278 +``__attribute__((nomicromips))`` attributes on MIPS targets. These attributes +may be attached to a function definition and instructs the backend to locally +select or turn off microMIPS code ge

[PATCH] D31588: Fix PR25627: Certain constant local variables must be usable as template arguments (without being odr-used)

faisalv accepted this revision. faisalv added a comment. This revision is now accepted and ready to land. Modified and committed as: http://llvm.org/viewvc/llvm-project?view=revision&revision=303492 https://reviews.llvm.org/D31588 ___ cfe-commits m