Author: sberg
Date: Fri Jun 30 00:22:02 2017
New Revision: 306799
URL: http://llvm.org/viewvc/llvm-project?rev=306799&view=rev
Log:
Fold exception-warnings.cpp into warn-throw-out-noexcept-func.cpp
I had failed to notice the latter existed when I recently introduced the former.
Removed:
cfe/
rogfer01 accepted this revision.
rogfer01 added a comment.
This revision is now accepted and ready to land.
This LGTM. Thanks for the refactoring and the fix.
https://reviews.llvm.org/D34686
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
Author: djasper
Date: Fri Jun 30 01:02:37 2017
New Revision: 306804
URL: http://llvm.org/viewvc/llvm-project?rev=306804&view=rev
Log:
Fix heap use after free introduced by r306769.
Modified:
cfe/trunk/lib/Driver/ToolChains/Clang.cpp
Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp
URL:
h
Author: sjoerdmeijer
Date: Fri Jun 30 01:07:34 2017
New Revision: 306805
URL: http://llvm.org/viewvc/llvm-project?rev=306805&view=rev
Log:
ARMV8-A archkind and target defines helper functions
This introduces helper functions that set target defines for different ARMV8-A
architecture kinds. It fix
This revision was automatically updated to reflect the committed changes.
Closed by commit rL306805: ARMV8-A archkind and target defines helper functions
(authored by SjoerdMeijer).
Changed prior to commit:
https://reviews.llvm.org/D34686?vs=104393&id=104830#toc
Repository:
rL LLVM
https://
On 30/06/17 01:03, Evgenii Stepanov wrote:
This change broke clang/ubsan bot.
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/6047/steps/check-clang%20ubsan/logs/stdio
It looks like the value you are initializing SavedAK with may itself
be uninitialized? I see a few constru
joey created this revision.
Herald added subscribers: Anastasia, yaxunl.
Slightly improve the diagnostic by including the function name.
This has been separated out from https://reviews.llvm.org/D33945.
https://reviews.llvm.org/D34871
Files:
Sema/Sema.cpp
SemaOpenCL/extension-begin.cl
cl
arphaman added a comment.
Ah, I see, so this is more of a stylistic warning rather than "suspicious" use
one.
In https://reviews.llvm.org/D34810#795926, @rtrieu wrote:
> What is the reason to exclude void expressions now? For the function case,
> it is more consistent to warn on all functio
Author: vvassilev
Date: Fri Jun 30 02:25:43 2017
New Revision: 306809
URL: http://llvm.org/viewvc/llvm-project?rev=306809&view=rev
Log:
Ambiguity might be also uninitialized. Use llvm::Optional.
Modified:
cfe/trunk/include/clang/Sema/Lookup.h
Modified: cfe/trunk/include/clang/Sema/Lookup.h
bader accepted this revision.
bader added a comment.
This revision is now accepted and ready to land.
LGTM.
Just one minor comment.
Thanks.
Comment at: clang/Sema/Sema.h:8435
/// \return true if type is disabled.
- bool checkOpenCLDisabledDecl(const Decl &D, const Expr &E);
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
Please re-upload the patch with full context (see
http://llvm.org/docs/Phabricator.html).
Comment at: lib/Tooling/CommonOptionsParser.cpp:119
cl::HideUnrelatedO
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
Please upload a diff with full context (http://llvm.org/docs/Phabricator.html).
Comment at: include/clang/Tooling/DiagnosticsYaml.h:86-95
-std::vector Diagnosti
arphaman added a comment.
I think I'd rather move `clang-rename` first.
Comment at: tools/extra/clang-rename/tool/ClangRename.cpp:167
FindingAction.getUSRList();
const std::vector &PrevNames = FindingAction.getUSRSpellings();
if (PrintName) {
alexs
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
LG, thx for bearing with me, this looks great.
(and sorry if I didn't send this earlier, just noticed I forgot to hit submit
:( )
Comment at: lib/Tooling/ArgumentsAdjusters.
arphaman added a comment.
I think that it's pretty much ready. I think that the test should be expanded
though. At the very least it should check that all of the node types that are
supported by `SyntaxTreeImpl::getNodeValueImpl` get matched.
https://reviews.llvm.org/D34329
yvvan created this revision.
With that patch applied my 32-bit libclang.dll built with mingw does not crash
anymore
unit tests are not affected by that change
https://reviews.llvm.org/D34873
Files:
lib/AST/ExprConstant.cpp
Index: lib/AST/ExprConstant.cpp
===
teemperor added a comment.
I didn't have time to have a close look at this patch, but it seems you're
interested in the specific TU-independent data of a Stmt to compare them. So if
you are interested in the such data and don't want to write your own function
to collect data it for each Stmt su
anemet accepted this revision.
anemet added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
https://reviews.llvm.org/D34865
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
joey added a comment.
Thanks!
Making that change, going to re-run the tests and then I'll commit.
https://reviews.llvm.org/D34871
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
anemet added a comment.
Great!
Comment at: docs/UsersManual.rst:330-332
This option, which defaults to off, controls whether Clang prints the
profile hotness associated with a diagnostics in the presence of
profile-guided optimization information. This is currently
yvvan added a comment.
In https://reviews.llvm.org/D34680#794135, @vsk wrote:
> Do you know which function clang was processing when it crashed? That would
> help us find a test case.
I have a trace:
#0 0x7ff6942b777c HandleAbort
d:\code\llvm_copy\lib\support\windows\signals.inc:405:0
#1
spetrovic created this revision.
Herald added subscribers: kristof.beyls, javed.absar, aemerson.
This patch enables option for reading thread pointer directly from coprocessor
register (-mread-tp-hard). This option is supported in llc also (
https://reviews.llvm.org/D34408 ).
https://reviews.l
xazax.hun updated this revision to Diff 104848.
xazax.hun added a comment.
- Updated to compile with trunk
- Minor style fixes
- Proper diagnostic when the index format is wrong
https://reviews.llvm.org/D34512
Files:
include/clang/Basic/DiagnosticFrontendKinds.td
include/clang/Tooling/Cross
johannes marked an inline comment as done.
johannes added a comment.
In https://reviews.llvm.org/D34329#796574, @teemperor wrote:
> I didn't have time to have a close look at this patch, but it seems you're
> interested in the specific TU-independent data of a Stmt to compare them. So
> if you
Author: d0k
Date: Fri Jun 30 06:21:27 2017
New Revision: 306822
URL: http://llvm.org/viewvc/llvm-project?rev=306822&view=rev
Log:
[Driver] Actually report errors during parsing instead of stopping when there's
an error somewhere.
This is a more principled version of r303756. That change was both
Author: d0k
Date: Fri Jun 30 06:23:24 2017
New Revision: 306823
URL: http://llvm.org/viewvc/llvm-project?rev=306823&view=rev
Log:
Revert "Modify test so that it looks for patterns in stderr as well"
This reverts commit r303735. No longer needed after r306822 sends the
diagnostics to the proper ou
Author: abataev
Date: Fri Jun 30 06:50:13 2017
New Revision: 306825
URL: http://llvm.org/viewvc/llvm-project?rev=306825&view=rev
Log:
[OPENMP] Initial support for taskloop reductions.
Add sema/parsupping ort for taskloop [simd] reductions.
Modified:
cfe/trunk/include/clang/Basic/OpenMPKinds.
teemperor added a comment.
Yes, it does indeed skip identifiers and literals for this reason :). It was
planned to make this template more configurable for use cases like yours, so
I'm totally fine with adding configuration parameters. I just opened
https://reviews.llvm.org/D34880 where I make
djasper added a comment.
Can you add a test? Tests for this kind of behavior of the clang-format command
line go in test/Format/.
Comment at: tools/clang-format/ClangFormat.cpp:380
+if (Verbose.getNumOccurrences() != 0)
+outs() << "Formatting " << FileNames[0] << '
djasper added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:71
+ const FormatStyle &Style) {
+ assert(LessTok.is(tok::less));
+ return Style.Language == FormatStyle::LK_TextProto ||
Maybe rename to opensP
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
Repository:
rL LLVM
https://reviews.llvm.org/D34696
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
Author: joey
Date: Fri Jun 30 07:23:01 2017
New Revision: 306827
URL: http://llvm.org/viewvc/llvm-project?rev=306827&view=rev
Log:
[OpenCL] Add function name to extension diagnostic
Slightly improve the diagnostic by including the function name.
Modified:
cfe/trunk/include/clang/Basic/Diagno
> On 23. Jun 2017, at 23:54, Richard Smith wrote:
>
> On 23 June 2017 at 13:34, Benjamin Kramer via cfe-commits
> mailto:cfe-commits@lists.llvm.org>> wrote:
> Since this change went in I'm seeing spurious errors whenever editing
> a header file, filed https://bugs.llvm.org/show_bug.cgi?id=33574
alexfh requested changes to this revision.
alexfh added inline comments.
This revision now requires changes to proceed.
Comment at: clang-tidy/modernize/MakeSmartPtrCheck.h:28
MakeSmartPtrCheck(StringRef Name, ClangTidyContext *Context,
-std::string makeSma
arphaman created this revision.
The fixit inserts `@synthesize` directives into the implementation.
Repository:
rL LLVM
https://reviews.llvm.org/D34886
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/Parse/ParseObjc.cpp
lib/Sema/SemaObjCProperty.cpp
gtbercea added a comment.
In https://reviews.llvm.org/D34784#795988, @hfinkel wrote:
> In https://reviews.llvm.org/D34784#795980, @gtbercea wrote:
>
> > In https://reviews.llvm.org/D34784#795934, @hfinkel wrote:
> >
> > > In https://reviews.llvm.org/D34784#795871, @gtbercea wrote:
> > >
> > > > I
Hahnfeld created this revision.
Combined directives like 'target parallel' have two captured statements. Sema
has to check the right one from the right direction.
Previously, Sema::IsOpenMPCapturedByRef would return false for mapped scalars
on combined directives. This results in a wrong signat
Author: compnerd
Date: Fri Jun 30 08:15:39 2017
New Revision: 306830
URL: http://llvm.org/viewvc/llvm-project?rev=306830&view=rev
Log:
Driver: fix option declaration
The option is a "joined" argument. Fix silly copy-paste error. This
allows the parsing to work at runtime.
Modified:
cfe/tru
Author: compnerd
Date: Fri Jun 30 08:15:38 2017
New Revision: 306829
URL: http://llvm.org/viewvc/llvm-project?rev=306829&view=rev
Log:
Driver: honor -nostdinc and -isystem-after on CrossWindows
This changes CrossWindows to look for -nostdinc instead of -nostdlibinc.
In addition, fixes a bug where
compnerd closed this revision.
compnerd added a comment.
SVN r306829
https://reviews.llvm.org/D34839
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D34888
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
rnk added a comment.
This appears to affect our behavior under the MS ABI. We still seem to use this
logic from CGVTables, even though that code is primarily Itanium related. In
http://crbug.com/738468 we're seeing the LNK4102 linker warning, which says:
"export of deleting destructor (name); i
smeenai added a comment.
Sorry about the breakage. I'll redo this limiting it to windows-itanium (and
add a comment explaining why we want it).
Repository:
rL LLVM
https://reviews.llvm.org/D34850
___
cfe-commits mailing list
cfe-commits@lists.ll
Author: rnk
Date: Fri Jun 30 09:11:49 2017
New Revision: 306835
URL: http://llvm.org/viewvc/llvm-project?rev=306835&view=rev
Log:
Revert "[CodeGen] Propagate dllexport to thunks"
This reverts r306770, it causes LNK4102 warnings in MSVC builds.
Modified:
cfe/trunk/lib/CodeGen/CGVTables.cpp
Author: rnk
Date: Fri Jun 30 09:12:14 2017
New Revision: 306836
URL: http://llvm.org/viewvc/llvm-project?rev=306836&view=rev
Log:
[MS] Test that deleting destructor thunks are not exported
The MSVC linker emits the LNK4102 warning if they are.
Added:
cfe/trunk/test/CodeGenCXX/dllexport-dtor-
hfinkel added a comment.
...
>
Okay, good, this is exactly where I was going when I said I was worried
about generalization. -march seems like one of many flags I might want to
pass to the target compilation. Moreover, it doesn't seem special in what
regard.
>>
v.g.vassilev created this revision.
Repository:
rL LLVM
https://reviews.llvm.org/D34891
Files:
include/clang/AST/Redeclarable.h
lib/AST/ExprConstant.cpp
lib/Basic/SourceManager.cpp
lib/Lex/PreprocessingRecord.cpp
lib/Sema/SemaType.cpp
lib/Serialization/ASTReader.cpp
lib/Serializa
rnk added a comment.
Have a minute to get to this? My attempt to work around the bug in Chromium was
incomplete.
https://reviews.llvm.org/D34714
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
Author: kuba.brecka
Date: Fri Jun 30 09:28:15 2017
New Revision: 306837
URL: http://llvm.org/viewvc/llvm-project?rev=306837&view=rev
Log:
[objc] Don't require null-check and don't emit memset when result is ignored
for struct-returning method calls [clang part]
This fixes an issue with the emiss
RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.
LGTM with a couple of comments.
On the LLVM side, X86.td GoldMont class looks like it needs RDRAND as well.
Comment at: lib/Basic/Targets.cpp:3310
setFeatureEnabledIm
Author: arphaman
Date: Fri Jun 30 09:36:09 2017
New Revision: 306840
URL: http://llvm.org/viewvc/llvm-project?rev=306840&view=rev
Log:
[refactor] Move clang-rename into the clang repository
The core engine of clang-rename will be used for local and global renames in the
new refactoring engine, as
Author: arphaman
Date: Fri Jun 30 09:43:00 2017
New Revision: 306841
URL: http://llvm.org/viewvc/llvm-project?rev=306841&view=rev
Log:
Use add_clang_unittest in the CMakeLists.txt for the moved unittest
The unittest was moved in r306840
Modified:
cfe/trunk/unittests/Rename/CMakeLists.txt
Mo
craig.topper added a comment.
There's a separate review for X86.d https://reviews.llvm.org/D34828
https://reviews.llvm.org/D34842
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno updated this revision to Diff 104881.
bruno added a comment.
> Digging into this a bit more, I think the root of the problem is that the
> `ND->isExternallyVisible()` call in
> `LookupResult::isHiddenDeclarationVisible` is wrong. Redeclaration lookup
> should never find hidden enumerato
Author: arphaman
Date: Fri Jun 30 09:58:36 2017
New Revision: 306843
URL: http://llvm.org/viewvc/llvm-project?rev=306843&view=rev
Log:
Move ClassReplacements.cpp test from clang-rename tests to the
clang-apply-replacements tests
The ClassReplacements.cpp test in the clang-rename tests uses
clang-
Author: arphaman
Date: Fri Jun 30 09:58:36 2017
New Revision: 306843
URL: http://llvm.org/viewvc/llvm-project?rev=306843&view=rev
Log:
Move ClassReplacements.cpp test from clang-rename tests to the
clang-apply-replacements tests
The ClassReplacements.cpp test in the clang-rename tests uses
clang-
danielcdh created this revision.
Herald added subscribers: eraman, inglorion, mehdi_amini, sanjoy.
This patch should be enabled after https://reviews.llvm.org/D34895
https://reviews.llvm.org/D34896
Files:
test/CodeGen/pgo-sample-thinlto-summary.c
Index: test/CodeGen/pgo-sample-thinlto-summa
bruno added a comment.
Hi @v.g.vassilev, sorry for the delay.
Just updated https://reviews.llvm.org/D31778. I agree with Richard's
observations, do you think you can extend it to work in the same way as
https://reviews.llvm.org/D31778 does? The structural checking is already
abstracted there (
arphaman added a comment.
I didn't notice that ClassReplacements.cpp had a dependency on
clang-apply-replacements. I moved it back to clang-tools-extra to the
clang-apply-replacements tests.
Repository:
rL LLVM
https://reviews.llvm.org/D34696
_
tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D34896
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
Author: arphaman
Date: Fri Jun 30 10:15:48 2017
New Revision: 306844
URL: http://llvm.org/viewvc/llvm-project?rev=306844&view=rev
Log:
Attempt to fix the linkage error caused by r306840 on the mingw-RA-on-linux bot
Modified:
cfe/trunk/tools/clang-rename/CMakeLists.txt
Modified: cfe/trunk/too
It worked!
On 30 June 2017 at 18:15, Alex Lorenz via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: arphaman
> Date: Fri Jun 30 10:15:48 2017
> New Revision: 306844
>
> URL: http://llvm.org/viewvc/llvm-project?rev=306844&view=rev
> Log:
> Attempt to fix the linkage error caused by r30
andrew.zhogin updated this revision to Diff 104893.
andrew.zhogin added a comment.
Herald added a subscriber: aprantl.
Updated to the current repository state.
https://reviews.llvm.org/D18240
Files:
lib/Frontend/PrintPreprocessedOutput.cpp
test/Misc/asm_hash_comments.s
Index: test/Misc/as
vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.
lgtm with a nitpick.
Comment at: include/clang/Sema/Sema.h:3351
+ ObjCInterfaceDecl *IDecl, SourceRange
AtEnd);
+ void DefaultSynthesizeProperti
Author: ctopper
Date: Fri Jun 30 11:14:02 2017
New Revision: 306850
URL: http://llvm.org/viewvc/llvm-project?rev=306850&view=rev
Log:
[X86] Add a break to the last case of a few switches to prevent accidents in
the future. NFC
Modified:
cfe/trunk/lib/Basic/Targets.cpp
Modified: cfe/trunk/li
Author: ctopper
Date: Fri Jun 30 11:14:01 2017
New Revision: 306849
URL: http://llvm.org/viewvc/llvm-project?rev=306849&view=rev
Log:
[X86] Move all atom CPUs to the same section of the switch and use fallthroughs
like we do for other CPU generations. NFC
This is prep work to add MOVBE to all At
Author: ctopper
Date: Fri Jun 30 11:14:04 2017
New Revision: 306851
URL: http://llvm.org/viewvc/llvm-project?rev=306851&view=rev
Log:
[X86] Add RDRND feature to Goldmont. Add MOVBE to all Atom CPUs.
Diffential Revision: https://reviews.llvm.org/D34842
Modified:
cfe/trunk/lib/Basic/Targets.cp
Author: ahatanak
Date: Fri Jun 30 11:50:23 2017
New Revision: 306859
URL: http://llvm.org/viewvc/llvm-project?rev=306859&view=rev
Log:
Revert "[libcxx] Annotate c++17 aligned new/delete operators with availability"
This reverts commit r306310.
r306310 causes clang to reject a call to an aligned
ahatanak updated this revision to Diff 104906.
ahatanak added a comment.
Address review comments.
- Change the error message from "invalid iOS deployment version '%0', maximum
allowable version is iOS 10" to "invalid iOS deployment version '%0', iOS 10 is
the maximum deployment target for 32-bi
Author: modocache
Date: Fri Jun 30 12:37:11 2017
New Revision: 306862
URL: http://llvm.org/viewvc/llvm-project?rev=306862&view=rev
Log:
[ORE] Use LLVM's "diagnostics hotness" spelling
Summary:
Depends on https://reviews.llvm.org/D34864.
To unify Clang and LLVM's spelling of "diagnostic[s] hotnes
Author: typz
Date: Fri Jun 30 13:00:02 2017
New Revision: 306868
URL: http://llvm.org/viewvc/llvm-project?rev=306868&view=rev
Log:
clang-format: Do not binpack initialization lists
Summary:
This patch tries to avoid binpacking when initializing lists/arrays, to allow
things like:
static int t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL306868: clang-format: Do not binpack initialization lists
(authored by Typz).
Changed prior to commit:
https://reviews.llvm.org/D34238?vs=103057&id=104914#toc
Repository:
rL LLVM
https://reviews.llv
bob.wilson added inline comments.
Comment at: lib/Driver/ToolChains/Darwin.cpp:1350
+Minor = 99;
+ }
} else if (Platform == TvOS) {
What about Micro = 99?
https://reviews.llvm.org/D34529
___
cfe-com
Author: d0k
Date: Fri Jun 30 13:24:32 2017
New Revision: 306873
URL: http://llvm.org/viewvc/llvm-project?rev=306873&view=rev
Log:
[clang-rename] Just return instead of calling exit(3) from main.
Modified:
cfe/trunk/tools/clang-rename/ClangRename.cpp
Modified: cfe/trunk/tools/clang-rename/Cla
Author: typz
Date: Fri Jun 30 13:25:55 2017
New Revision: 306874
URL: http://llvm.org/viewvc/llvm-project?rev=306874&view=rev
Log:
clang-format: add options to merge empty record body
Summary:
This patch introduces a few extra BraceWrapping options, similar to
`SplitEmptyFunction`, to allow mergi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL306874: clang-format: add options to merge empty record body
(authored by Typz).
Repository:
rL LLVM
https://reviews.llvm.org/D34395
Files:
cfe/trunk/include/clang/Format/Format.h
cfe/trunk/lib/Fo
mibintc updated this revision to Diff 104911.
mibintc added a subscriber: ilya-biryukov.
mibintc added a comment.
The previous (n-1) version didn't work: I wanted to iterate through the system
include directories to check for the existence of stdc-predef.h but clang is
using a different kind of
hokein updated this revision to Diff 104922.
hokein marked 2 inline comments as done.
hokein added a comment.
Herald added a subscriber: JDevlieghere.
Rebase and address review comments.
https://reviews.llvm.org/D34206
Files:
clang-tidy/modernize/MakeSmartPtrCheck.cpp
clang-tidy/modernize/M
hokein added inline comments.
Comment at: test/clang-tidy/modernize-make-shared-header.cpp:1
+// RUN: cp %S/Inputs/modernize-smart-ptr/shared_ptr.h %T/shared_ptr.h
+// RUN: %check_clang_tidy %s modernize-make-shared %t -- \
alexfh wrote:
> Maybe just add "-I%S/In
rsmith created this revision.
Herald added subscribers: aheejin, hiraditya, sbc100, nhaehnle, sanjoy, klimek.
This is a short-term fix for PR33650 aimed to get the modules build bots green
again.
Remove all the places where we use the LLVM_YAML_IS_(FLOW_)?SEQUENCE_VECTOR
macros to try to locall
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
I don't have any comments, this seems fine to me. Long term I think the best
solution is to get rid of these global specializations entirely, and instead
provide adapters called `flow` and
Author: rsmith
Date: Fri Jun 30 13:57:16 2017
New Revision: 306879
URL: http://llvm.org/viewvc/llvm-project?rev=306879&view=rev
Log:
Fix ODR violations due to abuse of LLVM_YAML_IS_(FLOW_)?SEQUENCE_VECTOR
This is a short-term fix for PR33650 aimed to get the modules build bots green
again.
Remo
This revision was automatically updated to reflect the committed changes.
Closed by commit rL306878: Fix ODR violations due to abuse of
LLVM_YAML_IS_(FLOW_)?SEQUENCE_VECTOR (authored by rsmith).
Changed prior to commit:
https://reviews.llvm.org/D34907?vs=104923&id=104928#toc
Repository:
rL L
Author: rsmith
Date: Fri Jun 30 13:57:39 2017
New Revision: 306881
URL: http://llvm.org/viewvc/llvm-project?rev=306881&view=rev
Log:
Fix ODR violations due to abuse of LLVM_YAML_IS_(FLOW_)?SEQUENCE_VECTOR
This is a short-term fix for PR33650 aimed to get the modules build bots green
again.
Remo
rsmith added a comment.
Committed as r306878-360881.
Repository:
rL LLVM
https://reviews.llvm.org/D34907
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: vedantk
Date: Fri Jun 30 14:02:14 2017
New Revision: 306883
URL: http://llvm.org/viewvc/llvm-project?rev=306883&view=rev
Log:
[Profile] Do not assign counters to functions without bodies
The root cause of the issues reported in D32406 and D34680 is that clang
instruments functions without
Author: vedantk
Date: Fri Jun 30 14:02:14 2017
New Revision: 306882
URL: http://llvm.org/viewvc/llvm-project?rev=306882&view=rev
Log:
Fix a typo. NFC.
Modified:
cfe/trunk/test/Profile/cxx-structors.cpp
Modified: cfe/trunk/test/Profile/cxx-structors.cpp
URL:
http://llvm.org/viewvc/llvm-proje
vsk added a comment.
Thanks for the stack trace. Clang shouldn't ever be assigning counters to decls
without bodies. As far as I can tell, this has only been happening when the
microsoft ABI is in use, which may explain why we don't hit the issue more
often. The fix required changing the way we
rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/Sema/SemaDecl.cpp:13693-13694
+ // passes the structural compatibility check in C11 6.2.7/1.
+ bool AllowODR = getLangOpts().CPl
kastiglione created this revision.
Using both -nostdinc and -nostdinc++ should not emit diagnostics.
https://reviews.llvm.org/D34909
Files:
lib/Driver/ToolChains/CrossWindows.cpp
test/Driver/windows-cross.c
Index: test/Driver/windows-cross.c
===
kastiglione added a comment.
There are other drivers with the same issue. If there's no opposition to this,
I can update those here as well.
https://reviews.llvm.org/D34909
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D34909#797252, @kastiglione wrote:
> There are other drivers with the same issue. If there's no opposition to
> this, I can update those here as well.
Yes, that'd
v.g.vassilev created this revision.
Patch by Axel Naumann!
Repository:
rL LLVM
https://reviews.llvm.org/D34912
Files:
lib/AST/TemplateBase.cpp
Index: lib/AST/TemplateBase.cpp
===
--- lib/AST/TemplateBase.cpp
+++ lib/AST/Temp
v.g.vassilev planned changes to this revision.
v.g.vassilev added a comment.
Waiting for @karies for a test case.
Repository:
rL LLVM
https://reviews.llvm.org/D34912
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
aaron.ballman added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6356-6357
+: Warning<
+ "%0 has a non-throwing exception specification but can " "still "
+ "throw">,
+
yawanng created this revision.
yawanng added a project: clang-tools-extra.
Herald added subscribers: xazax.hun, JDevlieghere, mgorny, srhines.
socket() is better to include SOCK_CLOEXEC in its type argument to avoid the
file descriptor leakage.
Repository:
rL LLVM
https://reviews.llvm.org/D3
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM, post-commit review is fine for changes like this.
Repository:
rL LLVM
https://reviews.llvm.org/D34891
___
cfe-commits mailing list
cfe-c
v.g.vassilev added a comment.
Ok, thanks! I was hesitant for the changes in libclang, because of the return
statements.
Repository:
rL LLVM
https://reviews.llvm.org/D34891
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
Author: gbiv
Date: Fri Jun 30 15:33:24 2017
New Revision: 306899
URL: http://llvm.org/viewvc/llvm-project?rev=306899&view=rev
Log:
[Parse] Use normalized attr name for late-parsing checks.
Modified:
cfe/trunk/lib/Parse/ParseDecl.cpp
cfe/trunk/test/Sema/diagnose_if.c
Modified: cfe/trunk/l
rsmith added a comment.
You should remove the code after the `assert(0)`, or you'll trigger
"unreachable code" warnings.
Repository:
rL LLVM
https://reviews.llvm.org/D34891
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
1 - 100 of 136 matches
Mail list logo