klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
Nice catch! lg
https://reviews.llvm.org/D36155
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
yamaguchi updated this revision to Diff 109281.
yamaguchi added a comment.
Modified comment.
https://reviews.llvm.org/D36209
Files:
clang/test/Driver/autocomplete.c
Index: clang/test/Driver/autocomplete.c
===
--- clang/test/Dri
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
E.g. If you add a flag that lands in between the results it breaks. Add
`-Wmajor-new-feature` and the test goes red. Same with the flag results or
changing the help test for `-std=`.
We
yamaguchi added a comment.
@ruiu
This test will break for instance, when someone add new value to
mrelocation-model because values has to be shown in row 78- 83 order, or when
someone made a new flags which start with `-Wno-invalid-pp-` because in row 96
only -Wno-invalid-pp-token is expected
ruiu added a comment.
So, does this comment actually make sense? Looks like you cannot break this
test by adding or modifying flags or by changing HelpText. (Theoretically,
it'll break if you remove -fsyntax-only, for example, but that is not
realistic.)
https://reviews.llvm.org/D36209
___
djasper added a comment.
Generally, please upload patches with full context to phabricator. (or use arc)
I think this approach is a bit inside out. We are in a codepath where we try to
find a lambda introducer and we the look one or two tokens back to see that we
aren't as we have seen "auto".
yamaguchi updated this revision to Diff 109277.
yamaguchi added a comment.
Update diff.
https://reviews.llvm.org/D36209
Files:
clang/test/Driver/autocomplete.c
Index: clang/test/Driver/autocomplete.c
===
--- clang/test/Driver/a
ruiu added a comment.
I wonder if this test is actually fragile. How can you break this test by
adding a new flag?
Comment at: clang/test/Driver/autocomplete.c:3
+// If this test had broke due to adding/modifying flags or changing HelpText,
+// please modify this file accordin
yamaguchi created this revision.
clang/test/Driver/autocomplete.c is a test for --autocomplete, and this
test might break if people add/modify flags or HelpText. So I've add
comment for future developers so that they can fix this file according
to the change they had made.
https://reviews.llvm.o
atanasyan created this revision.
atanasyan added a project: clang.
Herald added a subscriber: arichardson.
This change enables `long_call/short_call/far/near`, `micromips`, and
`interrupt` attributes on MIPS64 targets. In case of using the `mips16`
attribute with any ABI except `O32` compiler sh
This revision was automatically updated to reflect the committed changes.
Closed by commit rL309786: [CMake] Include llvm-objcopy tool in Fuchsia
toolchain (authored by phosek).
Changed prior to commit:
https://reviews.llvm.org/D36194?vs=109233&id=109265#toc
Repository:
rL LLVM
https://revi
Author: phosek
Date: Tue Aug 1 19:49:09 2017
New Revision: 309786
URL: http://llvm.org/viewvc/llvm-project?rev=309786&view=rev
Log:
[CMake] Include llvm-objcopy tool in Fuchsia toolchain
Differential Revision: https://reviews.llvm.org/D36194
Modified:
cfe/trunk/cmake/caches/Fuchsia-stage2.c
rjmccall added a comment.
Did this ever get committed?
https://reviews.llvm.org/D24461
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjmccall added a comment.
Has this proposal run aground? I'm going back over some old patches that I've
been CC'ed on and trying to make sure they're not blocking on my review.
https://reviews.llvm.org/D32199
___
cfe-commits mailing list
cfe-commi
Author: phosek
Date: Tue Aug 1 18:18:02 2017
New Revision: 309778
URL: http://llvm.org/viewvc/llvm-project?rev=309778&view=rev
Log:
[Driver] Disable static C++ library support on Fuchsia
Don't support or build static C++ libraries for Fuchsia.
Differential Revision: https://reviews.llvm.org/D36
This revision was automatically updated to reflect the committed changes.
Closed by commit rL309778: [Driver] Disable static C++ library support on
Fuchsia (authored by phosek).
Changed prior to commit:
https://reviews.llvm.org/D36202?vs=109255&id=109258#toc
Repository:
rL LLVM
https://revi
vsk added a comment.
In https://reviews.llvm.org/D34801#828382, @efriedma wrote:
> I'm going to look over the overall algorithm one more time to make sure this
> direction makes sense. The current code for ending regions on
> break/continue/return/noreturn doesn't really work well,
Maybe it's
phosek added inline comments.
Comment at: lib/Driver/ToolChains/Fuchsia.cpp:112
ToolChain.AddCXXStdlibLibArgs(Args, CmdArgs);
-if (OnlyLibstdcxxStatic)
- CmdArgs.push_back("-Bdynamic");
- }
CmdArgs.push_back("-lm");
}
mc
mcgrathr accepted this revision.
mcgrathr added a comment.
This revision is now accepted and ready to land.
LGTM. The nit below is orthogonal to this change.
Comment at: lib/Driver/ToolChains/Fuchsia.cpp:112
ToolChain.AddCXXStdlibLibArgs(Args, CmdArgs);
-if (O
phosek created this revision.
Herald added a subscriber: mgorny.
Don't support or build static C++ libraries for Fuchsia.
Repository:
rL LLVM
https://reviews.llvm.org/D36202
Files:
cmake/caches/Fuchsia-stage2.cmake
lib/Driver/ToolChains/Fuchsia.cpp
test/Driver/fuchsia.cpp
Index: test
phosek added inline comments.
Comment at: cmake/caches/Fuchsia-stage2.cmake:50
set(RUNTIMES_${target}-fuchsia_LIBCXX_ABI_VERSION 2 CACHE STRING "")
+ set(RUNTIMES_${target}-fuchsia_SANITIZER_USE_COMPILER_RT ON CACHE BOOL "")
endforeach()
mcgrathr wrote:
> ph
phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D35922
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
On Tue, Aug 1, 2017 at 4:41 PM, Richard Smith wrote:
> I assume there's an implied "merge to 5.0 branch?" question here :)
Yes :-) I lost that part somehow.
>
> Yes, horrible as lax vector conversions are, we shouldn't accidentally
> regress support for them.
r309770. Thanks.
>
>
> On 1 August
On Tue, Aug 1, 2017 at 4:34 PM, Hans Wennborg wrote:
> Merged in r309764.
>
> You cc'd me on the bug, so I noticed that :-)
>
> Just marking a bug a release blocker doesn't generally work though; it
> needs to be marked as blocking PR33849. (Though I will search for
> "release blocker" severity bu
I assume there's an implied "merge to 5.0 branch?" question here :)
Yes, horrible as lax vector conversions are, we shouldn't accidentally
regress support for them.
On 1 August 2017 at 16:28, Hans Wennborg via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Sounds good to me. Richard, what do
Merged in r309764.
You cc'd me on the bug, so I noticed that :-)
Just marking a bug a release blocker doesn't generally work though; it
needs to be marked as blocking PR33849. (Though I will search for
"release blocker" severity bugs now and then.)
On Tue, Aug 1, 2017 at 3:15 PM, Bruno Cardoso L
erik.pilkington created this revision.
This patch improves the decl-level unguarded availability warnings to use the
same messages as the function-level ones. This makes the diagnostic have
different parameters than deprecated/unavailable, so I moved some things around
in DoEmitAvailabilityWarn
efriedma added a comment.
I'm going to look over the overall algorithm one more time to make sure this
direction makes sense. The current code for ending regions on
break/continue/return/noreturn doesn't really work well, and the way we handle
multiple consecutive case statments isn't really r
Sounds good to me. Richard, what do you think?
On Tue, Aug 1, 2017 at 12:05 PM, Bruno Cardoso Lopes via cfe-commits
wrote:
> Author: bruno
> Date: Tue Aug 1 12:05:25 2017
> New Revision: 309722
>
> URL: http://llvm.org/viewvc/llvm-project?rev=309722&view=rev
> Log:
> [Sema] Fix lax conversion be
haowei updated this revision to Diff 109237.
haowei added a comment.
Add 1 line fix for the constraint on allocated handle in function
allocateSingleHandle at line 647
https://reviews.llvm.org/D36022
Files:
lib/StaticAnalyzer/Checkers/MagentaHandleChecker.cpp
test/Analysis/mxhandle.c
Inde
jakehehrlich accepted this revision.
jakehehrlich added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D36194
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
phosek created this revision.
Herald added a subscriber: mgorny.
Repository:
rL LLVM
https://reviews.llvm.org/D36194
Files:
cmake/caches/Fuchsia-stage2.cmake
Index: cmake/caches/Fuchsia-stage2.cmake
===
--- cmake/caches/Fuchsi
Author: bruno
Date: Tue Aug 1 15:10:36 2017
New Revision: 309752
URL: http://llvm.org/viewvc/llvm-project?rev=309752&view=rev
Log:
[Headers][Darwin] Allow #include_next to work on Darwin prior to 10.7
This fixes PR31504 and it's a follow up from adding #include_next
for Darwin in r289018.
rdar:
mcgrathr added inline comments.
Comment at: cmake/caches/Fuchsia-stage2.cmake:50
set(RUNTIMES_${target}-fuchsia_LIBCXX_ABI_VERSION 2 CACHE STRING "")
+ set(RUNTIMES_${target}-fuchsia_SANITIZER_USE_COMPILER_RT ON CACHE BOOL "")
endforeach()
phosek wrote:
> I
Author: yawanng
Date: Tue Aug 1 14:41:39 2017
New Revision: 309750
URL: http://llvm.org/viewvc/llvm-project?rev=309750&view=rev
Log:
[clang] Change the condition of unnecessary packed warning
Summary:
Change the condition of this unnecessary packed warning. The packed is
unnecessary when
1. the
zaks.anna added a comment.
>> I tried to keep this as a minimal starting example because this currently
>> blocks @yamaguchi 's GSoC project for bash completion. There we want to
>> complete the values for -analyzer-config and we currently don't have a good
>> way to get a complete list of av
erik.pilkington created this revision.
Previously, the presence of `__attribute__((availability(macos, ...)))` on a
declaration caused clang to make the vis of that decl implicitly default. This
is a hack that is incomparable with how we're treating availability attributes
now, and should be re
johannes abandoned this revision.
johannes added a comment.
split up in several commits starting from https://reviews.llvm.org/D36176
Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:170
+ // Ignore everything from other files.
+ if (!SrcMgr.isInMainFile(SLoc))
+return true;
-
yawanng updated this revision to Diff 109222.
yawanng added a comment.
Move tests to unitest and fix a bug.
https://reviews.llvm.org/D35743
Files:
lib/Format/TokenAnnotator.cpp
lib/Format/UnwrappedLineParser.cpp
lib/Format/UnwrappedLineParser.h
unittests/Format/FormatTest.cpp
Index: un
johannes abandoned this revision.
johannes added a comment.
moved to https://reviews.llvm.org/D36182, sorry for the noise
https://reviews.llvm.org/D35921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
arsenm closed this revision.
arsenm added a comment.
r309741
https://reviews.llvm.org/D36118
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Alex is in a different time zone, so he may not get to this today.
Do you have the time to give a review?
> On Aug 1, 2017, at 12:38 PM, Nico Weber wrote:
>
> It'd be good if this could go in today. ubsanvptr has been broken for us for
> a while now.
>
> On Mon, Jul 31, 2017 at 4:43 PM, Vedan
Author: arsenm
Date: Tue Aug 1 13:36:57 2017
New Revision: 309741
URL: http://llvm.org/viewvc/llvm-project?rev=309741&view=rev
Log:
Fix creating bitcasts with wrong address space
In a future commit AMDGPU will start passing
aggregates directly to more functions, triggering
asserts in test/CodeGe
Author: krobelus
Date: Tue Aug 1 13:17:40 2017
New Revision: 309737
URL: http://llvm.org/viewvc/llvm-project?rev=309737&view=rev
Log:
[clang-diff] Move data declarations to the public header
Modified:
cfe/trunk/include/clang/Tooling/ASTDiff/ASTDiff.h
cfe/trunk/include/clang/Tooling/ASTDi
Author: krobelus
Date: Tue Aug 1 13:17:46 2017
New Revision: 309738
URL: http://llvm.org/viewvc/llvm-project?rev=309738&view=rev
Log:
[clang-diff] Renames, NFC
Modified:
cfe/trunk/include/clang/Tooling/ASTDiff/ASTDiff.h
cfe/trunk/lib/Tooling/ASTDiff/ASTDiff.cpp
Modified: cfe/trunk/inclu
arsenm created this revision.
Herald added subscribers: t-tye, tpr, dstuttard, nhaehnle, wdng, kzhuravl.
This is an improvement over always using byval for
structs.
This will use registers until ~16 are used, and then
switch back to byval. This needs more work, since I'm
not sure it ever
Author: jmgao
Date: Tue Aug 1 12:53:31 2017
New Revision: 309731
URL: http://llvm.org/viewvc/llvm-project?rev=309731&view=rev
Log:
Revert "Thread Safety Analysis: fix assert_capability."
This reverts commit rL309725.
Broke test/Sema/attr-capabilities.c.
Modified:
cfe/trunk/include/clang/Ba
It'd be good if this could go in today. ubsanvptr has been broken for us
for a while now.
On Mon, Jul 31, 2017 at 4:43 PM, Vedant Kumar via Phabricator via
cfe-commits wrote:
> vsk created this revision.
>
> In r309007, I made -fsanitize=null a hard prerequisite for
> -fsanitize=vptr. I did not
farahhariri created this revision.
Herald added a subscriber: mgorny.
[libc++] added support for build with dataflow sanitizer
https://reviews.llvm.org/D36168
Files:
CMakeLists.txt
Index: CMakeLists.txt
===
--- CMakeLists.txt
+
mstorsjo added inline comments.
Comment at: lib/Basic/Targets/AArch64.cpp:466-467
+ case CC_X86ThisCall:
+ case CC_X86FastCall:
+ case CC_X86VectorCall:
+return CCCR_Ignore;
mstorsjo wrote:
> rnk wrote:
> > Do they really ignore __fastcall and __vectorcall
This revision was automatically updated to reflect the committed changes.
Closed by commit rL309725: Thread Safety Analysis: fix assert_capability.
(authored by jmgao).
Repository:
rL LLVM
https://reviews.llvm.org/D36122
Files:
cfe/trunk/include/clang/Basic/Attr.td
cfe/trunk/lib/Analysis/
Author: jmgao
Date: Tue Aug 1 12:18:05 2017
New Revision: 309725
URL: http://llvm.org/viewvc/llvm-project?rev=309725&view=rev
Log:
Thread Safety Analysis: fix assert_capability.
Summary:
Previously, the assert_capability attribute was completely ignored by
thread safety analysis.
Reviewers: del
This revision was automatically updated to reflect the committed changes.
Closed by commit rL309724: [CMake] Include sancov tool in Fuchsia toolchain
(authored by phosek).
Changed prior to commit:
https://reviews.llvm.org/D35930?vs=108418&id=109173#toc
Repository:
rL LLVM
https://reviews.ll
Author: phosek
Date: Tue Aug 1 12:15:32 2017
New Revision: 309724
URL: http://llvm.org/viewvc/llvm-project?rev=309724&view=rev
Log:
[CMake] Include sancov tool in Fuchsia toolchain
Differential Revision: https://reviews.llvm.org/D35930
Modified:
cfe/trunk/cmake/caches/Fuchsia-stage2.cmake
Author: bruno
Date: Tue Aug 1 12:05:25 2017
New Revision: 309722
URL: http://llvm.org/viewvc/llvm-project?rev=309722&view=rev
Log:
[Sema] Fix lax conversion between non ext vectors
r282968 introduced a regression due to the lack of proper testing.
Re-add lax conversion support between non ext ve
delesley accepted this revision.
delesley added a comment.
This revision is now accepted and ready to land.
Thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D36122
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
boris added a comment.
Ping.
https://reviews.llvm.org/D35020
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ibiryukov
Date: Tue Aug 1 11:27:58 2017
New Revision: 309720
URL: http://llvm.org/viewvc/llvm-project?rev=309720&view=rev
Log:
[clangd] Fix more MSVC compilation failures.
It turns out MSVC does not allow non-copyable classes in std::future
and std::promise template arguments.
Modified:
arphaman added a comment.
In https://reviews.llvm.org/D36156#827733, @kimgr wrote:
> High-level comment from the peanut gallery:
>
> The word "occurrences" is horrible to type and most people misspell it (you
> did great here!) Would you consider something like "SymbolMatches" or even
> "Symbol
arphaman added a comment.
Makes sense. I'll see if I can get somewhere with the regex idea.
Repository:
rL LLVM
https://reviews.llvm.org/D36083
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
Author: mprobst
Date: Tue Aug 1 10:42:16 2017
New Revision: 309713
URL: http://llvm.org/viewvc/llvm-project?rev=309713&view=rev
Log:
clang-format: [JS] no whitespace between typeof operator and l_paren.
Modified:
cfe/trunk/lib/Format/FormatToken.h
cfe/trunk/lib/Format/TokenAnnotator.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL309712: clang-format: [JS] prefer wrapping chains over empty
literals. (authored by mprobst).
Changed prior to commit:
https://reviews.llvm.org/D36139?vs=109082&id=109155#toc
Repository:
rL LLVM
htt
Author: mprobst
Date: Tue Aug 1 10:35:57 2017
New Revision: 309712
URL: http://llvm.org/viewvc/llvm-project?rev=309712&view=rev
Log:
clang-format: [JS] prefer wrapping chains over empty literals.
Summary:
E.g. don't wrap like this:
(foo.bar.baz).and.bam(Blah.of({
}))
But rather:
(
kimgr added a comment.
High-level comment from the peanut gallery:
The word "occurrences" is horrible to type and most people misspell it (you did
great here!) Would you consider something like "SymbolMatches" or even
"SymbolHits"?
Repository:
rL LLVM
https://reviews.llvm.org/D36156
___
This revision was automatically updated to reflect the committed changes.
Closed by commit rL309710: clang-format: [JS] whitespace between keywords and
parenthesized expressions. (authored by mprobst).
Repository:
rL LLVM
https://reviews.llvm.org/D36146
Files:
cfe/trunk/lib/Format/TokenAnno
Author: mprobst
Date: Tue Aug 1 10:22:15 2017
New Revision: 309710
URL: http://llvm.org/viewvc/llvm-project?rev=309710&view=rev
Log:
clang-format: [JS] whitespace between keywords and parenthesized expressions.
Summary: `throw (...)` should have a whitespace following it, as do await and
void.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL309707: clang-format: [JS] handle union types in arrow
functions. (authored by mprobst).
Repository:
rL LLVM
https://reviews.llvm.org/D36147
Files:
cfe/trunk/lib/Format/TokenAnnotator.cpp
cfe/trun
Author: mprobst
Date: Tue Aug 1 10:19:32 2017
New Revision: 309707
URL: http://llvm.org/viewvc/llvm-project?rev=309707&view=rev
Log:
clang-format: [JS] handle union types in arrow functions.
Summary: clang-format would previously fail to detect that an arrow functions
parameter block is not an
Author: ibiryukov
Date: Tue Aug 1 10:17:37 2017
New Revision: 309705
URL: http://llvm.org/viewvc/llvm-project?rev=309705&view=rev
Log:
[clangd] Fixed MSVC compilation failures.
Modified:
clang-tools-extra/trunk/clangd/ClangdUnit.h
Modified: clang-tools-extra/trunk/clangd/ClangdUnit.h
URL:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL309703: clang-format: [JS] consistenly format enums.
(authored by mprobst).
Repository:
rL LLVM
https://reviews.llvm.org/D36144
Files:
cfe/trunk/lib/Format/TokenAnnotator.cpp
cfe/trunk/unittests/F
Author: mprobst
Date: Tue Aug 1 10:12:15 2017
New Revision: 309703
URL: http://llvm.org/viewvc/llvm-project?rev=309703&view=rev
Log:
clang-format: [JS] consistenly format enums.
Summary: Previously, const enums would get formatted differently because the
modifier was not recognized.
Reviewers:
t.p.northover updated this revision to Diff 109149.
t.p.northover added a comment.
Sounds like an improvement, I've updated the diff.
https://reviews.llvm.org/D35817
Files:
clang/include/clang/Basic/DiagnosticSemaKinds.td
clang/lib/Sema/SemaChecking.cpp
clang/lib/Sema/SemaExpr.cpp
clang
mprobst created this revision.
Herald added a subscriber: klimek.
Previously, clang-format would consider the following code line to be part of
the comment and incorrectly format the rest of the file.
https://reviews.llvm.org/D36159
Files:
lib/Format/FormatTokenLexer.cpp
unittests/Format/Fo
vsk updated this revision to Diff 109142.
vsk marked 2 inline comments as done.
vsk edited the summary of this revision.
vsk added a comment.
Thanks for the review! I'll hold off on landing this until the llvm-cov changes
are in, so that people don't hit the issue where unexpected line execution
hintonda added a comment.
This is a good example of how to script lldb, but it's predicated on knowing
the diag name, which is great if you know the name.
However, this isn't my use case. I don't have the diag name, just a diagnostic
message. In order to get the diag name associated with a sp
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
Thanks, it does make sense to update llvm-cov.
LGTM:
Comment at: lib/CodeGen/CoverageMappingGen.cpp:554
+ // useful to try and create a deferred region inside o
Yes, sure, I will investigate it.
Thanks,
--Serge
2017-08-01 21:32 GMT+07:00 Alexander Kornienko :
> This change causes an assertion failure on valid code. Could you take a
> look at fixing this?
>
> A reduced test case:
>
> $ cat /tmp/SemaTemplateInstantiateDecl-crash2.cpp
> template
> constex
ilya-biryukov requested changes to this revision.
ilya-biryukov added a reviewer: ilya-biryukov.
ilya-biryukov added a comment.
Also, +1 to the comments about file extensions, we have to cover at least `.c`,
`.cc` and `.cpp` for source files, `.h` and `.hpp` for header files.
bkramer added inline comments.
Comment at: clang-tidy/google/StringReferenceMemberCheck.cpp:31
+ auto String = anyOf(namedDecl(hasName("::std::string")),
recordDecl(hasName("::string")));
auto ConstString = qualType(isConstQualified(), hasDeclaration(St
This revision was automatically updated to reflect the committed changes.
Closed by commit rL309697: clang-format: [JS] support default imports.
(authored by mprobst).
Changed prior to commit:
https://reviews.llvm.org/D36132?vs=109059&id=109136#toc
Repository:
rL LLVM
https://reviews.llvm.o
djasper added inline comments.
Comment at: lib/Format/TokenAnnotator.cpp:2009
+// Prefer breaking call chains (".foo") over empty "{}", "[]" or "()".
+if ((Left.is(tok::l_brace) && Right.is(tok::r_brace)) ||
+(Left.is(tok::l_square) && Right.is(tok::r_square)) ||
This revision was automatically updated to reflect the committed changes.
Closed by commit rL309695: clang-format: [JS] handle object types in extends
positions. (authored by mprobst).
Repository:
rL LLVM
https://reviews.llvm.org/D36131
Files:
cfe/trunk/lib/Format/TokenAnnotator.cpp
cfe/t
djasper added inline comments.
Comment at: lib/Format/TokenAnnotator.cpp:2355
+(Left.Tok.getIdentifierInfo() ||
+ Left.isOneOf(tok::kw_switch, tok::kw_case, tok::kw_delete)))
+ return false;
Why is instanceof not required in this list?
This revision was automatically updated to reflect the committed changes.
Closed by commit rL309696: [clangd] Rewrote AST and Preamble management.
(authored by ibiryukov).
Repository:
rL LLVM
https://reviews.llvm.org/D36133
Files:
clang-tools-extra/trunk/clangd/ClangdServer.cpp
clang-tool
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D36147
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D36146
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D36144
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
arphaman created this revision.
Herald added a subscriber: mgorny.
Symbol occurrences store the results of local rename and will also be used for
the global, indexed rename results. They can be converted to a set of
`AtomicChanges` as well. This is a preparation patch for both the support of
mu
Author: mprobst
Date: Tue Aug 1 08:54:43 2017
New Revision: 309697
URL: http://llvm.org/viewvc/llvm-project?rev=309697&view=rev
Log:
clang-format: [JS] support default imports.
Summary: Formerly, `import {default as X} from y;` would not be recognized as
an import.
Reviewers: djasper
Subscrib
Author: ibiryukov
Date: Tue Aug 1 08:51:38 2017
New Revision: 309696
URL: http://llvm.org/viewvc/llvm-project?rev=309696&view=rev
Log:
[clangd] Rewrote AST and Preamble management.
Summary: The new implementation allows code completion that never waits for AST.
Reviewers: bkramer, krasimir, kli
Author: mprobst
Date: Tue Aug 1 08:46:10 2017
New Revision: 309695
URL: http://llvm.org/viewvc/llvm-project?rev=309695&view=rev
Log:
clang-format: [JS] handle object types in extends positions.
Summary:
clang-format would previously drop the whitespace after `extends` in code such
as:
clas
malaperle requested changes to this revision.
malaperle added a comment.
This revision now requires changes to proceed.
Can you also update your code with the latest SVN trunk? The patch does not
apply cleanly anymore.
Comment at: clangd/ClangdServer.cpp:11
#include "ClangdSe
ilya-biryukov created this revision.
It used to call into llvm::sys::fs::make_absolute.
https://reviews.llvm.org/D36155
Files:
lib/Basic/FileManager.cpp
unittests/Basic/FileManagerTest.cpp
Index: unittests/Basic/FileManagerTest.cpp
=
jyu2 added a comment.
In https://reviews.llvm.org/D33537#827509, @baloghadamsoftware wrote:
> Test changed. I made some bad throws reachable, but the frontend check still
> does detects them.
If block contains two or more throws, that mean compiler can not statically
know throw is really thro
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
ship it!
https://reviews.llvm.org/D36133
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
klimek created this revision.
Herald added a subscriber: JDevlieghere.
https://reviews.llvm.org/D36154
Files:
clang-tidy/google/StringReferenceMemberCheck.cpp
clang-tidy/misc/DanglingHandleCheck.cpp
clang-tidy/misc/InaccurateEraseCheck.cpp
clang-tidy/misc/UseAfterMoveCheck.cpp
clang-tid
xazax.hun added a comment.
Even though it is not undefined behavior in C, it can still cause surprising
behavior for the users. I think maybe putting it into the optin package instead
of cplusplus is better. What do you think?
https://reviews.llvm.org/D33672
xazax.hun added a comment.
Even though it is not undefined behavior in C, it can still cause surprising
behavior for the users. I think maybe putting it into the optin package instead
of cplusplus is better. What do you think?
https://reviews.llvm.org/D33672
baloghadamsoftware updated this revision to Diff 109126.
baloghadamsoftware added a comment.
Herald added a subscriber: JDevlieghere.
Test changed. I made some bad throws reachable, but the frontend check still
does detects them.
https://reviews.llvm.org/D33537
Files:
clang-tidy/misc/CMakeLi
ilya-biryukov marked 3 inline comments as done.
ilya-biryukov added inline comments.
Comment at: clangd/ClangdServer.h:113
+ /// queue. The request will be run on a separate thread.
+ template void addToFront(Func &&F, Args &&...
As);
+ /// Add a new request to run function
1 - 100 of 148 matches
Mail list logo
