[PATCH] D36450: [X86][Ms-InlineAsm] Extend MS Dot operator to accept "this" + struct/class pointers aliases

coby created this revision. Herald added a subscriber: eraman. MS InlineAsm Dot operator accepts "Bases" such as "this" (cpp) and class/struct pointer typedef. This patch enhance its implementation with this behavior. Repository: rL LLVM https://reviews.llvm.org/D36450 Files: lib/Sema/Sem

[PATCH] D36159: clang-format: [JS] handle single lines comments ending in `\\`.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg Comment at: lib/Format/FormatTokenLexer.cpp:544-545 +while (BackslashPos != StringRef::npos) { + if (BackslashPos + 1 < FormatTok->TokenText.size() && +

[PATCH] D36261: [clangd] Use multiple working threads in clangd.

klimek added a comment. High-level question: Why can't we use llvm::ThreadPool? https://reviews.llvm.org/D36261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36398: [clangd] Check if CompileCommand has changed on forceReparse.

klimek added a comment. Also missing tests :) Comment at: clangd/ClangdUnitStore.cpp:45 + .first; +Result.RemovedFile = nullptr; + } else if (!compileCommandsAreEqual(It->second->getCompileCommand(), ilya-biryukov wrote: > klimek wrote: > > Jus

[PATCH] D30295: [analyzer] clarify undef shift result when shift count is negative or exceeds the bit width

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. It looks good to me but let's wait for Anna, NoQ, or Devin for the final word. Repository: rL LLVM https://reviews.llvm.org/D30295 ___ c

[PATCH] D35068: [analyzer] Detect usages of unsafe I/O functions

xazax.hun added a comment. In https://reviews.llvm.org/D35068#811437, @NoQ wrote: > It'd look good in clang-tidy (especially if extended to provide fixits), but > if Daniel is interested in having this feature in the analyzer (and picked by > clang-tidy from there), i wouldn't mind. > > I wonde

[PATCH] D35068: [analyzer] Detect usages of unsafe I/O functions

xazax.hun added inline comments. Comment at: lib/StaticAnalyzer/Checkers/CheckSecuritySyntaxOnly.cpp:622 +} +//===--===// +// Check: Use of 'sprintf', 'vsprintf', 'scanf', 'wscanf', 'fscanf', I w

[PATCH] D35955: clang-format: Add preprocessor directive indentation

djasper added a comment. Manuel: Can you take a look at the last comment here? Why does PPBranchLevel start at -1? https://reviews.llvm.org/D35955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D36261: [clangd] Use multiple working threads in clangd.

ilya-biryukov added a comment. In https://reviews.llvm.org/D36261#834902, @klimek wrote: > High-level question: Why can't we use llvm::ThreadPool? It is not an in-place replacement as it does not allow to prioritize new tasks over old ones (new tasks are usually more important for clangd as th

[PATCH] D36452: [clang-tidy] Fix another crash in make-unique check.

hokein created this revision. Herald added subscribers: xazax.hun, JDevlieghere. The crash happens when calling `reset` method without any preceding operation like "->" or ".", this could happen in a subclass of the "std::unique_ptr". https://reviews.llvm.org/D36452 Files: clang-tidy/moderniz

[PATCH] D36398: [clangd] Check if CompileCommand has changed on forceReparse.

ilya-biryukov updated this revision to Diff 110155. ilya-biryukov added a comment. Addressed review comments. - Added a test for forceReparse. - Got rid of a redundant `= nullptr` assignment. https://reviews.llvm.org/D36398 Files: clangd/ClangdServer.cpp clangd/ClangdServer.h clangd/Clan

[PATCH] D36398: [clangd] Check if CompileCommand has changed on forceReparse.

ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. In https://reviews.llvm.org/D36398#834904, @klimek wrote: > Also missing tests :) Done :-) Comment at: clangd/ClangdUnitStore.h:45-48 + struct RecreateResult { +std::shared_ptr FileInCollecti

[PATCH] D36453: [libclang] Fix PR34055 (incompatible update of clang-c/Index.h)

n.bozhenov created this revision. Fixes a regression introduced by r308218. https://reviews.llvm.org/D36453 Files: clang/include/clang-c/Index.h Index: clang/include/clang-c/Index.h === --- clang/include/clang-c/Index.h +++ cla

[PATCH] D36453: [libclang] Fix PR34055 (incompatible update of clang-c/Index.h)

n.bozhenov added a comment. If the patch is accepted, it should also be merged into 5.0, I believe. https://reviews.llvm.org/D36453 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36359: [clang-format] Put '/**' and '*/' on own lines in jsdocs ending in comment pragmas

krasimir updated this revision to Diff 110156. krasimir added a comment. - Simplify getSplitAfterLastLine https://reviews.llvm.org/D36359 Files: lib/Format/BreakableToken.cpp lib/Format/BreakableToken.h lib/Format/ContinuationIndenter.cpp unittests/Format/FormatTestJS.cpp Index: unitte

[PATCH] D36359: [clang-format] Put '/**' and '*/' on own lines in jsdocs ending in comment pragmas

krasimir updated this revision to Diff 110157. krasimir added a comment. - Remove debugging https://reviews.llvm.org/D36359 Files: lib/Format/BreakableToken.cpp lib/Format/BreakableToken.h lib/Format/ContinuationIndenter.cpp unittests/Format/FormatTestJS.cpp Index: unittests/Format/For

[PATCH] D36456: [clang-tidy] 'implicit cast' -> 'implicit conversion'

alexfh created this revision. Herald added subscribers: xazax.hun, JDevlieghere, mgorny. This patch renames checks, check options and changes messages to use correct term "implicit conversion" instead of "implicit cast" (which has been in use in Clang AST since ~10 years, but it's still technicall

[PATCH] D36456: [clang-tidy] 'implicit cast' -> 'implicit conversion'

alexfh updated this revision to Diff 110166. alexfh added a comment. Added redirections from the old check documents. https://reviews.llvm.org/D36456 Files: clang-tidy/performance/CMakeLists.txt clang-tidy/performance/ImplicitCastInLoopCheck.cpp clang-tidy/performance/ImplicitCastInLoopCh

r310345 - Revert r310291, r310300 and r310332 because of test failure on Darwin

Author: arphaman Date: Tue Aug 8 04:20:17 2017 New Revision: 310345 URL: http://llvm.org/viewvc/llvm-project?rev=310345&view=rev Log: Revert r310291, r310300 and r310332 because of test failure on Darwin The commit r310291 introduced the failure. r310332 was a test fix commit and r310300 was a f

r310347 - Darwin's toolchain should be initialized before openmp offloading

Author: arphaman Date: Tue Aug 8 04:22:21 2017 New Revision: 310347 URL: http://llvm.org/viewvc/llvm-project?rev=310347&view=rev Log: Darwin's toolchain should be initialized before openmp offloading is processed This fixes an 'openmp-offload.c' test failure introduced by r310263. Modified:

[PATCH] D29654: [OpenMP] Integrate OpenMP target region cubin into host binary

arphaman added a comment. Hi @gtbercea, I couldn't reply to the email as cfe-commits didn't even register this commit somehow, so I'm replying here. Unfortunately I had to revert this commit (r310291), + two others for a clean revert (r310300 and r310332) because it caused a test failure on mac

[PATCH] D29654: [OpenMP] Integrate OpenMP target region cubin into host binary

arphaman added a comment. The revert commit is r310345 btw https://reviews.llvm.org/D29654 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36458: Fix crash when current lexer is nullptr

bkramer added a comment. Test case? https://reviews.llvm.org/D36458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36456: [clang-tidy] 'implicit cast' -> 'implicit conversion'

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D36456 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D36458: Fix crash when current lexer is nullptr

yvvan added a comment. Do you mean the testcase that runs only for windows with ms-extensions flag and msvc includes? I don't know if clang has that kind of tests. Does it? https://reviews.llvm.org/D36458 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D35937: [clang-tidy] Add new readability non-idiomatic static access

barancsuk updated this revision to Diff 110175. barancsuk marked 4 inline comments as done. barancsuk added a comment. Further reviews addressed https://reviews.llvm.org/D35937 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp clang-tidy/readabi

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

yvvan added a comment. Please check that one https://reviews.llvm.org/D36390 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35355: Fix templated type alias completion when using global completion cache

yvvan added a comment. Ping... https://reviews.llvm.org/D35355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r308722 - Fixed failing assert in code completion.

Ping? On 21 July 2017 at 10:44, Alex L wrote: > Hans, can you please merge this to the LLVM 5.0 branch? > > AFAIK It's a recent regression that should get fixed in LLVM 5.0. > > Cheers, > Alex > > > On 21 July 2017 at 10:24, Ilya Biryukov via cfe-commits < > cfe-commits@lists.llvm.org> wrote: >

[PATCH] D36458: Fix crash when current lexer is nullptr

yvvan added a comment. And if you just meant how to reproduce: You need to parse and reparse standard header (my current one is C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\memory). I can provide the options and a command line that I have if you can't reproduce it with defau

[PATCH] D36208: [mips] Enable `long_call/short_call` attributes on MIPS64

aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:268 def TargetMips : TargetArch<["mips", "mipsel"]>; +def TargetAnyMips : TargetArch<["mips", "mipsel", "mips64", "mips64el"]>; def TargetMSP430 : TargetArch<["msp430"]>; Can you also

[PATCH] D35937: [clang-tidy] Add new readability non-idiomatic static access

barancsuk added inline comments. Comment at: clang-tidy/readability/StaticAccessedThroughInstanceCheck.cpp:23 + memberExpr(hasDeclaration(anyOf(cxxMethodDecl(isStaticStorageClass()), + varDecl(hasStaticStorageDuration(, +

[PATCH] D36327: [OpenCL] Allow targets emit optimized pipe functions for power of 2 type sizes

b-sumner added a comment. In https://reviews.llvm.org/D36327#834032, @Anastasia wrote: > In https://reviews.llvm.org/D36327#833891, @yaxunl wrote: > > > In https://reviews.llvm.org/D36327#833653, @bader wrote: > > > > > Hi Sam, > > > > > > What do you think about implementing this optimization in

[PATCH] D33672: [analyzer] INT50-CPP. Do not cast to an out-of-range enumeration checker

aaron.ballman added a comment. In https://reviews.llvm.org/D33672#830492, @gamesh411 wrote: > As for the the loss of precision problem, in the special case of char the > size of char is known. However does the analysis have the necessary > information in this stage to know the size of an int fo

[PATCH] D35755: [Solaris] gcc toolchain handling revamp

aaron.ballman added a comment. Aside from a coding style nit and the unanswered question that hopefully @tstellar can help answer, this LGTM. I'll wait to accept until we figure out the answer for Linux, however. Comment at: lib/Driver/ToolChains/Solaris.cpp:208 if (GCCIns

[PATCH] D36101: Fix usage of right shift operator in fold expressions

Rakete added a comment. Ping? https://reviews.llvm.org/D36101 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36431: Add powerpc64 to compiler-rt build infrastructure.

nemanjai added a comment. This patch appears to be perfectly fine. However, it triggers a large number of warnings. Namely, there's a large number of `warning: ISO C forbids an empty translation unit [-Wpedantic]` warnings produced. The reason is that all the code in the file is wrapped with an

[PATCH] D36411: Restore previous structure ABI for bitfields with 'packed' attribute for PS4 targets

probinson added a comment. FTR, from a PS4 perspective this is all good, but we'd like somebody from outside our team to take a look. https://reviews.llvm.org/D36411 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

bkramer added inline comments. Comment at: include/clang/Sema/Sema.h:2681 + bool PartialOverloading = false, + bool ExtraFirstArgument = false); void AddMethodCandidate(DeclAccessPair FoundDecl, I'd prefer something li

[PATCH] D35056: GCC ABI incompatibility when passing object with trivial copy ctor, trivial dtor, and non-trivial move ctor

v.g.vassilev added a comment. And thanks for working on this!! Repository: rL LLVM https://reviews.llvm.org/D35056 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36453: [libclang] Fix PR34055 (incompatible update of clang-c/Index.h)

rnk accepted this revision. rnk added a comment. Thanks, looks good! https://reviews.llvm.org/D36453 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35056: GCC ABI incompatibility when passing object with trivial copy ctor, trivial dtor, and non-trivial move ctor

v.g.vassilev added a comment. I do not feel qualified enough to review this patch but I added few minor comments. Comment at: include/clang/AST/DeclCXX.h:827 +return data().DefaultedCopyConstructorIsDeleted; + } + /// \brief \c true if a defaulted move constructor for th

[PATCH] D35755: [Solaris] gcc toolchain handling revamp

fedor.sergeev updated this revision to Diff 110190. fedor.sergeev added a comment. auto changed to MultilibSet::IncludeDirsFunc. https://reviews.llvm.org/D35755 Files: lib/Driver/ToolChains/Gnu.cpp lib/Driver/ToolChains/Gnu.h lib/Driver/ToolChains/Solaris.cpp lib/Driver/ToolChains/Solar

[PATCH] D29654: [OpenMP] Integrate OpenMP target region cubin into host binary

gtbercea added a comment. In https://reviews.llvm.org/D29654#835045, @arphaman wrote: > Hi @gtbercea, > I couldn't reply to the email as cfe-commits didn't even register this > commit somehow, so I'm replying here. > > Unfortunately I had to revert this commit (r310291), + two others for a clea

r310359 - [libclang] Fix PR34055 (incompatible update of clang-c/Index.h)

Author: n.bozhenov Date: Tue Aug 8 07:13:50 2017 New Revision: 310359 URL: http://llvm.org/viewvc/llvm-project?rev=310359&view=rev Log: [libclang] Fix PR34055 (incompatible update of clang-c/Index.h) Fixes a regression introduced by r308218. Modified: cfe/trunk/include/clang-c/Index.h Modi

[PATCH] D29654: [OpenMP] Integrate OpenMP target region cubin into host binary

arphaman added a comment. Great, thanks! I think that you can just revert my revert with the fix applied in one commit https://reviews.llvm.org/D29654 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D36453: [libclang] Fix PR34055 (incompatible update of clang-c/Index.h)

n.bozhenov closed this revision. n.bozhenov added a comment. committed r310359 https://reviews.llvm.org/D36453 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r310360 - [OPENMP][DEBUG] Set proper address space info if required by target.

Author: abataev Date: Tue Aug 8 07:25:14 2017 New Revision: 310360 URL: http://llvm.org/viewvc/llvm-project?rev=310360&view=rev Log: [OPENMP][DEBUG] Set proper address space info if required by target. Arguments, passed to the outlined function, must have correct address space info for proper De

RE: [PATCH] D34158: For Linux/gnu compatibility, preinclude if the file is available

fedor.sergeev added a comment. In https://reviews.llvm.org/D34158#834298, @mibintc wrote: > In fact I did have trouble writing the new test case to pass with the > gnu/Linux toolchain. In the file lib/Driver/ToolChains/Linux.cpp function > AddGnuIncludeArgs checks if GCCInstallation.isValid()

[PATCH] D34158: For Linux/gnu compatibility, preinclude if the file is available

mibintc updated this revision to Diff 110193. mibintc added a comment. Responding to @fedor.sergeev 's comment. This is an updated patch which pulls out the "isValid" check on GCCInstallation. Also I'm putting back the dummy sysroot tree which contains stdc-predef.h and adding a new test run to

[PATCH] D29654: [OpenMP] Integrate OpenMP target region cubin into host binary

gtbercea added a comment. In https://reviews.llvm.org/D29654#835256, @arphaman wrote: > Great, thanks! I think that you can just revert my revert with the fix > applied in one commit Hi Alex, I just commited the changes again. Let me know if it still fails for you. I think the issue was actu

[PATCH] D35755: [Solaris] gcc toolchain handling revamp

fedor.sergeev updated this revision to Diff 110194. fedor.sergeev added a comment. ugh... reverting back to llvm::Triple, since plain Triple conflicts with clang::driver::Toolchain::Triple data member. Built/tested on Solaris11 x86/SPARC, Linux x86. https://reviews.llvm.org/D35755 Files: lib

r310364 - Revert "[OPENMP][DEBUG] Set proper address space info if required by target."

Author: abataev Date: Tue Aug 8 07:44:43 2017 New Revision: 310364 URL: http://llvm.org/viewvc/llvm-project?rev=310364&view=rev Log: Revert "[OPENMP][DEBUG] Set proper address space info if required by target." This reverts commit r310360. Removed: cfe/trunk/test/OpenMP/target_parallel_debu

[PATCH] D35755: [Solaris] gcc toolchain handling revamp

aaron.ballman added inline comments. Comment at: lib/Driver/ToolChains/Gnu.h:253 +void AddDefaultGCCPrefixes(const llvm::Triple &TargetTriple, + SmallVectorImpl &Prefixes, fedor.sergeev wrote: > aaron.ballman wrote: > > Might a

[PATCH] D36159: clang-format: [JS] handle single lines comments ending in `\\`.

mprobst marked an inline comment as done. mprobst added inline comments. Comment at: lib/Format/FormatTokenLexer.cpp:544-545 +while (BackslashPos != StringRef::npos) { + if (BackslashPos + 1 < FormatTok->TokenText.size() && + FormatTok->TokenText[BackslashPos +

[PATCH] D35755: [Solaris] gcc toolchain handling revamp

fedor.sergeev marked an inline comment as not done. fedor.sergeev added inline comments. Comment at: lib/Driver/ToolChains/Gnu.h:253 +void AddDefaultGCCPrefixes(const llvm::Triple &TargetTriple, + SmallVectorImpl &Prefixes, aar

[PATCH] D36354: [clang-tidy] Implement type-based check for `gsl::owner`

aaron.ballman added inline comments. Comment at: clang-tidy/cppcoreguidelines/OwningMemoryCheck.cpp:29 +void OwningMemoryCheck::registerMatchers(MatchFinder *Finder) { + if (!getLangOpts().CPlusPlus11) { +return; Can elide the braces. Comm

r310365 - clang-format: [JS] handle single lines comments ending in `\\`.

Author: mprobst Date: Tue Aug 8 07:52:42 2017 New Revision: 310365 URL: http://llvm.org/viewvc/llvm-project?rev=310365&view=rev Log: clang-format: [JS] handle single lines comments ending in `\\`. Summary: Previously, clang-format would consider the following code line to be part of the comment

[PATCH] D36159: clang-format: [JS] handle single lines comments ending in `\\`.

This revision was automatically updated to reflect the committed changes. mprobst marked 2 inline comments as done. Closed by commit rL310365: clang-format: [JS] handle single lines comments ending in `\\`. (authored by mprobst). Repository: rL LLVM https://reviews.llvm.org/D36159 Files: cf

r310367 - clang-format: [JS] fix union type spacing in object & array types.

Author: mprobst Date: Tue Aug 8 08:00:58 2017 New Revision: 310367 URL: http://llvm.org/viewvc/llvm-project?rev=310367&view=rev Log: clang-format: [JS] fix union type spacing in object & array types. Summary: Previously, clang-format would insert whitespace in union types nested in object and ar

[PATCH] D29654: [OpenMP] Integrate OpenMP target region cubin into host binary

arphaman added a comment. Looks like it's still failing unfortunately: http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental_check/39182/console https://reviews.llvm.org/D29654 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36407: [Sema] Extend -Wenum-compare to handle mixed enum comparisons in switch statements

aaron.ballman added a comment. Can you generate the updated patch with more context (https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface)? Comment at: lib/Sema/SemaStmt.cpp:746 +static void checkEnumTypesInSwitchStmt(Sema &S, Expr *Cond, Expr *Ca

[PATCH] D29654: [OpenMP] Integrate OpenMP target region cubin into host binary

arphaman added a comment. The last RUN line in the new commit triggers the same assertion failure: Assertion failed: (CachedResults.find(ActionTC) != CachedResults.end() && "Result does not exist??"), function BuildJobsForActionNoCache, file /Users/alex/bisect/llvm/tools/clang/lib/Driver/Driv

[PATCH] D36471: [StaticAnalyzer] Try to calculate arithmetic result when operand has a range of possible values

danielmarjamaki created this revision. In the code below the division result should be a value between 5 and 25. if (a >= 10 && a <= 50) { int b = a / 2; } This patch will calculate results for additions, subtractions and divisions. I intentionally do not try to handle all possible case

[PATCH] D35937: [clang-tidy] Add new readability non-idiomatic static access

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang-tidy/readability/StaticAccessedThroughInstanceCheck.cpp:23 + memberExpr(hasDeclaration(anyOf(cxxMethodDecl(isStaticStorageClass()),

[PATCH] D36411: Restore previous structure ABI for bitfields with 'packed' attribute for PS4 targets

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D36411 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[PATCH] D29654: [OpenMP] Integrate OpenMP target region cubin into host binary

gtbercea added a comment. In https://reviews.llvm.org/D29654#835371, @arphaman wrote: > The last RUN line in the new commit triggers the same assertion failure: > > Assertion failed: (CachedResults.find(ActionTC) != CachedResults.end() && > "Result does not exist??"), function BuildJobsForActi

[clang-tools-extra] r310371 - [clang-tidy] Add new readability non-idiomatic static access check

Author: xazax Date: Tue Aug 8 08:33:48 2017 New Revision: 310371 URL: http://llvm.org/viewvc/llvm-project?rev=310371&view=rev Log: [clang-tidy] Add new readability non-idiomatic static access check Patch by: Lilla Barancsuk Differential Revision: https://reviews.llvm.org/D35937 Added: cla

[PATCH] D35937: [clang-tidy] Add new readability non-idiomatic static access

This revision was automatically updated to reflect the committed changes. Closed by commit rL310371: [clang-tidy] Add new readability non-idiomatic static access check (authored by xazax). Changed prior to commit: https://reviews.llvm.org/D35937?vs=110175&id=110209#toc Repository: rL LLVM h

[PATCH] D36471: [StaticAnalyzer] Try to calculate arithmetic result when operand has a range of possible values

xazax.hun added a comment. Can't you reuse somehow some machinery already available to evaluate the arithmetic operators? Those should already handle most of your TODOs and overflows. Repository: rL LLVM https://reviews.llvm.org/D36471 ___ cfe-

[PATCH] D36324: Integrate Kostya's clang-proto-fuzzer with LLVM.

morehouse added a comment. In https://reviews.llvm.org/D36324#834660, @kcc wrote: > Why do we need LLVM_ENABLE_RTTI=ON here? Attempting to build without it yields all kinds of protobuf errors. For example: F4944099: image.png https://reviews.llvm.org/D363

[PATCH] D29654: [OpenMP] Integrate OpenMP target region cubin into host binary

arphaman added a comment. In https://reviews.llvm.org/D29654#835392, @gtbercea wrote: > In https://reviews.llvm.org/D29654#835371, @arphaman wrote: > > > The last RUN line in the new commit triggers the same assertion failure: > > > > Assertion failed: (CachedResults.find(ActionTC) != CachedRes

[PATCH] D29654: [OpenMP] Integrate OpenMP target region cubin into host binary

arphaman added a comment. The cached results map doesn't have the key: (lldb) p CachedResults (std::__1::map, std::__1::allocator > >, clang::driver::InputInfo, std::__1::less, std::__1::allocator > > >, std::__1::allocator, std::__1::allocator > >, clang::driver::InputInfo> > >) $0 = siz

[PATCH] D29654: [OpenMP] Integrate OpenMP target region cubin into host binary

arphaman added a comment. If you look at the map then you can see that it contains very similar keys, but not the exact one: first = { first = 0x000111c017d0 second = "x86_64-apple-darwin17.0.0-host" } and first = { first = 0x000111c01320

[PATCH] D29654: [OpenMP] Integrate OpenMP target region cubin into host binary

arphaman added a comment. The "x86_64-apple-darwin17.0.0-x86_64-host" triple looks suspicious though https://reviews.llvm.org/D29654 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35955: clang-format: Add preprocessor directive indentation

klimek added a comment. In https://reviews.llvm.org/D35955#834914, @djasper wrote: > Manuel: Can you take a look at the last comment here? Why does PPBranchLevel > start at -1? It's a perhaps too-clever implementation to make sure that we can have a per-branch data structure (indexed from 0)

[PATCH] D36324: Integrate Kostya's clang-proto-fuzzer with LLVM.

morehouse updated this revision to Diff 110215. morehouse added a comment. - Formatting and code cleanup. https://reviews.llvm.org/D36324 Files: clang/CMakeLists.txt clang/cmake/modules/ProtobufMutator.cmake clang/tools/clang-fuzzer/CMakeLists.txt clang/tools/clang-fuzzer/ClangFuzzer.cp

[PATCH] D36413: Use "foo-12345.o.tmp" instead of "foo.o-12345" as temporary file name.

thakis closed this revision. thakis added a comment. r310376, thanks! https://reviews.llvm.org/D36413 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r310376 - Use "foo-12345.o.tmp" instead of "foo.o-12345" as temporary file name.

Author: nico Date: Tue Aug 8 09:21:23 2017 New Revision: 310376 URL: http://llvm.org/viewvc/llvm-project?rev=310376&view=rev Log: Use "foo-12345.o.tmp" instead of "foo.o-12345" as temporary file name. This helps some tools that do things based on the output's extension. For example, we got repo

r310377 - [OPENMP][DEBUG] Set proper address space info if required by target.

Author: abataev Date: Tue Aug 8 09:29:11 2017 New Revision: 310377 URL: http://llvm.org/viewvc/llvm-project?rev=310377&view=rev Log: [OPENMP][DEBUG] Set proper address space info if required by target. Arguments, passed to the outlined function, must have correct address space info for proper De

[PATCH] D36473: Fix broken getAttributeSpellingListIndex for pragma attributes

mikerice created this revision. We noticed when implementing a new pragma that the TableGen-generated function getAttributeSpellingListIndex() did not work for pragma attributes. It relies on the values in the enum AttributeList::Syntax and a new value AS_ContextSensitiveKeyword was added chan

[PATCH] D36471: [StaticAnalyzer] Try to calculate arithmetic result when operand has a range of possible values

danielmarjamaki updated this revision to Diff 110220. danielmarjamaki added a comment. A minor code cleanup. No functional change. Repository: rL LLVM https://reviews.llvm.org/D36471 Files: include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintManager.h lib/StaticAnalyzer/Core/ExprEn

[PATCH] D36471: [StaticAnalyzer] Try to calculate arithmetic result when operand has a range of possible values

danielmarjamaki added a comment. In https://reviews.llvm.org/D36471#835410, @xazax.hun wrote: > Can't you reuse somehow some machinery already available to evaluate the > arithmetic operators? Those should already handle most of your TODOs and > overflows. Sounds good.. I have not seen that m

[PATCH] D36407: [Sema] Extend -Wenum-compare to handle mixed enum comparisons in switch statements

rnkovacs updated this revision to Diff 110219. rnkovacs marked 2 inline comments as done. rnkovacs added a comment. Uploaded the full diff and addressed comments. Added `const` qualifiers to `GetTypeBeforeIntegralPromotion()` function. https://reviews.llvm.org/D36407 Files: lib/Sema/SemaStmt

r310379 - Revert "[OPENMP][DEBUG] Set proper address space info if required by target."

Author: abataev Date: Tue Aug 8 09:45:36 2017 New Revision: 310379 URL: http://llvm.org/viewvc/llvm-project?rev=310379&view=rev Log: Revert "[OPENMP][DEBUG] Set proper address space info if required by target." This reverts commit r310377. Removed: cfe/trunk/test/OpenMP/target_parallel_debu

[PATCH] D29654: [OpenMP] Integrate OpenMP target region cubin into host binary

gtbercea added a comment. In https://reviews.llvm.org/D29654#835429, @arphaman wrote: > The "x86_64-apple-darwin17.0.0-x86_64-host" triple looks suspicious though It looks like the triple is in the list though: second = "x86_64-apple-darwin17.0.0-x86_64-host it is entry [1]. https://reviews

[PATCH] D36324: Integrate Kostya's clang-proto-fuzzer with LLVM.

kcc added a comment. In https://reviews.llvm.org/D36324#835415, @morehouse wrote: > In https://reviews.llvm.org/D36324#834660, @kcc wrote: > > > Why do we need LLVM_ENABLE_RTTI=ON here? > > > Attempting to build without it yields all kinds of protobuf errors. For > example: > F4944099: image.p

[PATCH] D29654: [OpenMP] Integrate OpenMP target region cubin into host binary

gtbercea added a comment. Is that the last access to CachedResults before the error? https://reviews.llvm.org/D29654 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36423: [libc++] Introsort based sorting function

DIVYA added a comment. benchmarks/algorithms.bench.cpp Results With old code (in ns) BM_sort_std_common>/16384 : 730752 BM_sort_std_common>/32768 : 1.58E+06 BM_sort_std_ascending>/16384:1716

[PATCH] D29654: [OpenMP] Integrate OpenMP target region cubin into host binary

arphaman added a comment. In https://reviews.llvm.org/D29654#835501, @gtbercea wrote: > Is that the last access to CachedResults before the error? Is the assertion the last access? Yes. There must be a discrepancy between `UI.DependentBoundArch` in the loop above and `BoundArch` that's used t

[PATCH] D29654: [OpenMP] Integrate OpenMP target region cubin into host binary

gtbercea added a comment. In https://reviews.llvm.org/D29654#835507, @arphaman wrote: > In https://reviews.llvm.org/D29654#835501, @gtbercea wrote: > > > Is that the last access to CachedResults before the error? > > > Is the assertion the last access? Yes. > > There must be a discrepancy between

r310382 - [Availability] Don't make an availability attribute imply default visibility on macOS

Author: epilk Date: Tue Aug 8 10:09:09 2017 New Revision: 310382 URL: http://llvm.org/viewvc/llvm-project?rev=310382&view=rev Log: [Availability] Don't make an availability attribute imply default visibility on macOS Fixes PR33796, rdar://33655115 Differential revision: https://reviews.llvm.or

[PATCH] D36324: Integrate Kostya's clang-proto-fuzzer with LLVM.

morehouse updated this revision to Diff 110222. morehouse added a comment. - Define GOOGLE_PROTOBUF_NO_RTTI to remove RTTI requirement. https://reviews.llvm.org/D36324 Files: clang/CMakeLists.txt clang/cmake/modules/ProtobufMutator.cmake clang/tools/clang-fuzzer/CMakeLists.txt clang/too

[PATCH] D36191: [CodeGen] Don't make availability attributes imply default visibility on macos

This revision was automatically updated to reflect the committed changes. Closed by commit rL310382: [Availability] Don't make an availability attribute imply default visibility on… (authored by epilk). Changed prior to commit: https://reviews.llvm.org/D36191?vs=109218&id=110223#toc Repository

[PATCH] D36437: [clang] Get rid of "%T" expansions

rnk accepted this revision. rnk added a comment. Thanks, most of these looks like potential races between tests waiting to happen. Repository: rL LLVM https://reviews.llvm.org/D36437 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:/

[PATCH] D35056: GCC ABI incompatibility when passing object with trivial copy ctor, trivial dtor, and non-trivial move ctor

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D35056#834705, @rnk wrote: > In https://reviews.llvm.org/D35056#834689, @rsmith wrote: > > > I also removed some incorrect assumptions from the Win64 ABI code; this > > c

[PATCH] D29654: [OpenMP] Integrate OpenMP target region cubin into host binary

arphaman added a comment. No, entry 1 has a different pointer (0x000111c01320 vs 0x000111c017d0). Why is there a `DependentBoundArch` if it's always empty? https://reviews.llvm.org/D29654 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D36411: Restore previous structure ABI for bitfields with 'packed' attribute for PS4 targets

ormris added a comment. Great. Thanks for the review! I don't have commit access currently. https://reviews.llvm.org/D36411 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29654: [OpenMP] Integrate OpenMP target region cubin into host binary

hfinkel added a comment. In https://reviews.llvm.org/D29654#835392, @gtbercea wrote: > In https://reviews.llvm.org/D29654#835371, @arphaman wrote: > > > The last RUN line in the new commit triggers the same assertion failure: > ... > Hi Alex, I'm not sure why it's failing as I can't reproduce

[PATCH] D36475: [analyzer] Add "create_sink" annotation support to MagentaHandleChecker

haowei created this revision. Herald added a subscriber: xazax.hun. This patch adds "mx_create_sink" annotation support to MagentaHandleChecker to address the false positives found in Magenta unit tests. After this patch, when a call to a function contains this annotation, MagentaHandleChecker w

  1   2   >