[PATCH] D24933: Enable configuration files in clang

sepavloff marked 28 inline comments as done. sepavloff added a comment. @hfinkel Thank you for explanations! https://reviews.llvm.org/D24933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D24933: Enable configuration files in clang

sepavloff updated this revision to Diff 118315. sepavloff added a comment. Updated patch according to reviewer's notes https://reviews.llvm.org/D24933 Files: docs/UsersManual.rst include/clang/Basic/DiagnosticDriverKinds.td include/clang/Config/config.h.cmake

[PATCH] D38656: [CGExprScalar] In EmitCompare trunc the result if it has different type as E->getType()

nemanjai added a comment. In https://reviews.llvm.org/D38656#892072, @Carrot wrote: > I worked on a similar bug as 31161, and then found this one, it should be > same as in comment7. > What is the current status of the work on that bug? No one has had time to finalize a fix to it. Please go

[PATCH] D37478: [analyzer] Implement pointer arithmetic on constants

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. This looks good to me! Thanks for adding this. Do you have commit access, or do you need someone to commit it for you? https://reviews.llvm.org/D37478

[PATCH] D38659: [Sema][ObjC] Preserve syntactic sugar when removing ARCReclaimReturnedObject cast

This revision was automatically updated to reflect the committed changes. Closed by commit rL315261: [Sema][ObjC] Preserve syntactic sugar when removing (authored by ahatanak). Changed prior to commit: https://reviews.llvm.org/D38659?vs=118121=118302#toc Repository: rL LLVM

r315261 - [Sema][ObjC] Preserve syntactic sugar when removing

Author: ahatanak Date: Mon Oct 9 18:24:33 2017 New Revision: 315261 URL: http://llvm.org/viewvc/llvm-project?rev=315261=rev Log: [Sema][ObjC] Preserve syntactic sugar when removing ARCReclaimReturnedObject cast. This is a follow-up to r314370. Rather than throwing away the enclosing

[PATCH] D37897: [StaticAnalyzer] Fix ProgramState for static variables that are not written

dcoughlin requested changes to this revision. dcoughlin added a comment. This revision now requires changes to proceed. Apologies for the delay reviewing! As I noted inline, I'm pretty worried about the performance impact of this. Is it possible to do the analysis in a single traversal of the

r315256 - [Modules TS] Avoid computing the linkage of the enclosing DeclContext for a declaration in the global module.

Author: rsmith Date: Mon Oct 9 17:49:38 2017 New Revision: 315256 URL: http://llvm.org/viewvc/llvm-project?rev=315256=rev Log: [Modules TS] Avoid computing the linkage of the enclosing DeclContext for a declaration in the global module. This works around a language issue where adding a typedef

[PATCH] D38707: PR13575: Fix USR mangling for functions taking function pointers as arguments.

This revision was automatically updated to reflect the committed changes. Closed by commit rL315255: R13575: Fix USR mangling for function pointer types (authored by jkorous). Changed prior to commit: https://reviews.llvm.org/D38707?vs=118287=118300#toc Repository: rL LLVM

r315255 - R13575: Fix USR mangling for function pointer types

Author: jkorous Date: Mon Oct 9 17:35:16 2017 New Revision: 315255 URL: http://llvm.org/viewvc/llvm-project?rev=315255=rev Log: R13575: Fix USR mangling for function pointer types Differential Revision: https://reviews.llvm.org/D38707 Added: cfe/trunk/test/Index/USR/func-type.cpp Modified:

[PATCH] D38599: Remove warnings for dynamic_cast fallback.

danalbert added a comment. > Are you 100% sure that you're not just a person with broken code? Absolutely, since it isn't my code ;) I maintain the toolchain and this is a behavioral change when switching from libstdc++ to libc++. > In other words, what did this guy from 2013 get wrong? -- or,

[PATCH] D38707: PR13575: Fix USR mangling for functions taking function pointers as arguments.

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D38707 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D38711: typos in documentation?

This revision was automatically updated to reflect the committed changes. Closed by commit rL315252: Fix typos in documentation (authored by jkorous). Changed prior to commit: https://reviews.llvm.org/D38711?vs=118295=118296#toc Repository: rL LLVM https://reviews.llvm.org/D38711 Files:

r315252 - Fix typos in documentation

Author: jkorous Date: Mon Oct 9 16:45:20 2017 New Revision: 315252 URL: http://llvm.org/viewvc/llvm-project?rev=315252=rev Log: Fix typos in documentation Differential Revision: https://reviews.llvm.org/D38711 Modified: cfe/trunk/docs/InternalsManual.rst Modified:

r315251 - [Modules TS] Module ownership semantics for redeclarations.

Author: rsmith Date: Mon Oct 9 16:42:09 2017 New Revision: 315251 URL: http://llvm.org/viewvc/llvm-project?rev=315251=rev Log: [Modules TS] Module ownership semantics for redeclarations. When declaring an entity in the "purview" of a module, it's never a redeclaration of an entity in the

[PATCH] D38711: typos in documentation?

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D38711 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D38680: [libunwind] Fix handling of DW_CFA_GNU_args_size

compnerd requested changes to this revision. compnerd added a comment. This revision now requires changes to proceed. I think that the problem is that we are using the generic register name, but we need to use the target specific register name. On x86, EIP/ESP are swapped. We should also have

[PATCH] D38711: typos in documentation?

jkorous-apple created this revision. I have found two possible typos in documentation. Since English is not my first language I would like to ask for verification. https://reviews.llvm.org/D38711 Files: docs/InternalsManual.rst Index: docs/InternalsManual.rst

[PATCH] D38707: PR13575: Fix USR mangling for functions taking function pointers as arguments.

jkorous-apple added inline comments. Comment at: lib/Index/USRGeneration.cpp:757 VisitType(FT->getReturnType()); - for (const auto : FT->param_types()) + Out << '('; + for (const auto : FT->param_types()) { arphaman wrote: > I believe you

[PATCH] D38702: [Analyzer] Do not segfault on unexpected call_once implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rL315250: [Analyzer] Do not segfault on unexpected call_once implementation (authored by george.karpenkov). Changed prior to commit: https://reviews.llvm.org/D38702?vs=118291=118294#toc Repository: rL

r315250 - [Analyzer] Do not segfault on unexpected call_once implementation

Author: george.karpenkov Date: Mon Oct 9 16:20:46 2017 New Revision: 315250 URL: http://llvm.org/viewvc/llvm-project?rev=315250=rev Log: [Analyzer] Do not segfault on unexpected call_once implementation Fixes https://bugs.llvm.org/show_bug.cgi?id=34869 Differential Revision:

[PATCH] D38702: [Analyzer] Do not segfault on unexpected call_once implementation

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. Looks good to me! https://reviews.llvm.org/D38702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [clang-tools-extra] r315210 - [clangd] Added move-only function helpers.

Hello Ilya, This commit broke build on one of our builders: http://lab.llvm.org:8011/builders/clang-x86_64-linux-abi-test/builds/16435 Please have a look? Thanks Galina On Mon, Oct 9, 2017 at 9:26 AM, Ilya Biryukov via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ibiryukov >

[PATCH] D38704: [libunwind] Emulate pthread rwlocks via SRW locks for windows

zturner added a comment. I'm a little nervous about re-inventing a poor man's version of a reader writer lock. Can we not just copy LLVM's? Comment at: src/UnwindCursor.hpp:20 #ifndef _LIBUNWIND_HAS_NO_THREADS - #include + #ifdef _WIN32 +#include

[PATCH] D38702: [Analyzer] Do not segfault on unexpected call_once implementation

george.karpenkov updated this revision to Diff 118291. george.karpenkov added a comment. Review comments. https://reviews.llvm.org/D38702 Files: lib/Analysis/BodyFarm.cpp test/Analysis/call_once.cpp Index: test/Analysis/call_once.cpp

Re: [PATCH] D38464: [clangd] less boilerplate in RPC dispatch

hey Lang (& folks here) any chance there's some overlap between the RPC functionality here and the RPC functionality in ORC that could be deduplicated/refactored? On Fri, Oct 6, 2017 at 5:30 AM Ilya Biryukov via Phabricator via cfe-commits wrote: > ilya-biryukov

[PATCH] D38707: PR13575: Fix USR mangling for functions taking function pointers as arguments.

jkorous-apple updated this revision to Diff 118287. jkorous-apple added a comment. added another test https://reviews.llvm.org/D38707 Files: lib/Index/USRGeneration.cpp test/Index/USR/func-type.cpp Index: test/Index/USR/func-type.cpp

[PATCH] D38599: Remove warnings for dynamic_cast fallback.

Quuxplusone added a comment. I'm also much out of my depth here, but I'm skeptical. You're changing the comments in the code from essentially saying "This workaround helps people with broken code" to essentially saying "This indispensable functionality helps people like me who use dlopen()."

[PATCH] D38702: [Analyzer] Do not segfault on unexpected call_once implementation

dcoughlin added a comment. > @dcoughlin Any advice on how to handle different stdlib implementations? > Can we conjure a separate symbol instead of relying on a particular struct > layout? > For now this implementation will simply not go inside a differently > implemented call_once. I think

[PATCH] D38707: PR13575: Fix USR mangling for functions taking function pointers as arguments.

arphaman added inline comments. Comment at: lib/Index/USRGeneration.cpp:757 VisitType(FT->getReturnType()); - for (const auto : FT->param_types()) + Out << '('; + for (const auto : FT->param_types()) { I believe you can drop the '(' and

[PATCH] D38680: [libunwind] Fix handling of DW_CFA_GNU_args_size

mstorsjo added a comment. In https://reviews.llvm.org/D38680#892487, @compnerd wrote: > I think that the problem is that we are using the generic register name, but > we need to use the target specific register name. On x86, EIP/ESP are > swapped. You mean EBP/ESP? I think the code here

[PATCH] D38708: [AST] Flag the typo-corrected nodes for better tooling

arphaman created this revision. This patch adds a new boolean field to the `DeclRefExpr`, `MemberExpr`, `CXXCtorInitializer`, `ObjCIvarRefExpr`, `ObjCPropertyRefExpr` nodes which is set to true when these nodes have been produced during typo-correction. This is useful for Clang-based tooling

[PATCH] D38704: [libunwind] Emulate pthread rwlocks via SRW locks for windows

mstorsjo added a comment. In https://reviews.llvm.org/D38704#892479, @zturner wrote: > I'm a little nervous about re-inventing a poor man's version of a reader > writer lock. Can we not just copy LLVM's? I guess I could have a look to see how much extra either kitchen sink it would bring.

[PATCH] D38707: PR13575: Fix USR mangling for functions taking function pointers as arguments.

jkorous-apple created this revision. https://reviews.llvm.org/D38707 Files: lib/Index/USRGeneration.cpp test/Index/USR/func-type.cpp Index: test/Index/USR/func-type.cpp === --- /dev/null +++ test/Index/USR/func-type.cpp @@

[PATCH] D38704: [libunwind] Emulate pthread rwlocks via SRW locks for windows

mstorsjo created this revision. Herald added a subscriber: mehdi_amini. This makes sure that the FDE cache is thread safe. This requires building with `_WIN32_WINNT >= 0x0600`. The alternative would be to skip the FDE cache altogether if building without threads.

[PATCH] D38599: Remove warnings for dynamic_cast fallback.

jroelofs resigned from this revision. jroelofs added a comment. I'm not sure I'm the right person to review this. Repository: rL LLVM https://reviews.llvm.org/D38599 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D38599: Remove warnings for dynamic_cast fallback.

danalbert added a comment. In https://reviews.llvm.org/D38599#889842, @smeenai wrote: > Does dlopen cause issues even with `RTLD_GLOBAL`? From my testing, yes. Regardless, `RTLD_LOCAL` is how JNI libraries get loaded when `System.loadLibrary` is used, so the `strcmp` fallback is a requirement

[clang-tools-extra] r315242 - Revert r315214 since diff -Z isn't portable, this is breaking:

Author: bruno Date: Mon Oct 9 13:22:05 2017 New Revision: 315242 URL: http://llvm.org/viewvc/llvm-project?rev=315242=rev Log: Revert r315214 since diff -Z isn't portable, this is breaking: http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-expensive

[PATCH] D38679: [libunwind] Support dwarf unwinding on i386 windows

mstorsjo added inline comments. Comment at: docs/index.rst:53 NetBSD x86_64 Clang, GCC DWARF CFI +Windows i386 ClangDWARF CFI Any i386, x86_64, ARMClangSjLj FWIW, for this to actually work

[PATCH] D38679: [libunwind] Support dwarf unwinding on i386 windows

jroelofs added inline comments. Comment at: src/AddressSpace.hpp:521 unw_word_t *offset) { -#ifndef _LIBUNWIND_IS_BAREMETAL +#if !defined(_LIBUNWIND_IS_BAREMETAL) && !defined(_WIN32) Dl_info dyldInfo; mstorsjo

r315241 - PR13575: Fix test

Author: jkorous Date: Mon Oct 9 13:17:28 2017 New Revision: 315241 URL: http://llvm.org/viewvc/llvm-project?rev=315241=rev Log: PR13575: Fix test Ignore OS-specific mangled name. Modified: cfe/trunk/test/Index/USR/array-type.cpp Modified: cfe/trunk/test/Index/USR/array-type.cpp URL:

[PATCH] D38679: [libunwind] Support dwarf unwinding on i386 windows

mstorsjo updated this revision to Diff 118263. mstorsjo added a comment. Added a fixme comment about the truncated section name, flipped the ifdef in the assembly source. Didn't implement findFunctionName. https://reviews.llvm.org/D38679 Files: docs/index.rst src/AddressSpace.hpp

[PATCH] D38679: [libunwind] Support dwarf unwinding on i386 windows

mstorsjo added inline comments. Comment at: src/AddressSpace.hpp:521 unw_word_t *offset) { -#ifndef _LIBUNWIND_IS_BAREMETAL +#if !defined(_LIBUNWIND_IS_BAREMETAL) && !defined(_WIN32) Dl_info dyldInfo; mstorsjo

[PATCH] D36527: Implemented P0428R2 - Familiar template syntax for generic lambdas

hamzasood updated this revision to Diff 118261. hamzasood added a comment. - Updated lambda mangling to include explicit template parameters - Allow explicit template parameter lists on lambdas pre-c++2a as an extension. - Improved the somewhat fragile template depth handling. - Reformatted some

[PATCH] D38698: AMDGPU: Add read_exec_lo/hi builtins

arsenm closed this revision. arsenm added a comment. r315238 https://reviews.llvm.org/D38698 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r315238 - AMDGPU: Add read_exec_lo/hi builtins

Author: arsenm Date: Mon Oct 9 13:06:37 2017 New Revision: 315238 URL: http://llvm.org/viewvc/llvm-project?rev=315238=rev Log: AMDGPU: Add read_exec_lo/hi builtins Modified: cfe/trunk/include/clang/Basic/BuiltinsAMDGPU.def cfe/trunk/lib/CodeGen/CGBuiltin.cpp

[PATCH] D38698: AMDGPU: Add read_exec_lo/hi builtins

kzhuravl accepted this revision. kzhuravl added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D38698 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D38702: [Analyzer] Do not segfault on unexpected call_once implementation

george.karpenkov added a comment. Ooops, updated to https://bugs.llvm.org/show_bug.cgi?id=34869 https://reviews.llvm.org/D38702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38702: [Analyzer] Do not segfault on unexpected call_once implementation

xazax.hun added a comment. Did you link the correct bug in the description? The one you linked was closed long ago. https://reviews.llvm.org/D38702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D38702: [Analyzer] Do not segfault on unexpected call_once implementation

george.karpenkov created this revision. Herald added subscribers: szepet, xazax.hun, javed.absar. Fixes https://bugs.llvm.org/show_bug.cgi?id=30565 @dcoughlin Any advice on how to handle different stdlib implementations? Can we conjure a separate symbol instead of relying on a particular struct

[PATCH] D38643: PR13575: Fix USR mangling for fixed-size arrays.

This revision was automatically updated to reflect the committed changes. Closed by commit rL315236: PR13575: Fix USR mangling for fixed-size arrays (authored by jkorous). Changed prior to commit: https://reviews.llvm.org/D38643?vs=118247=118257#toc Repository: rL LLVM

r315236 - PR13575: Fix USR mangling for fixed-size arrays

Author: jkorous Date: Mon Oct 9 12:51:33 2017 New Revision: 315236 URL: http://llvm.org/viewvc/llvm-project?rev=315236=rev Log: PR13575: Fix USR mangling for fixed-size arrays Differential Revision: https://reviews.llvm.org/D38643 Added: cfe/trunk/test/Index/USR/

[libclc] r315235 - Implement mem_fence on ptx

Author: jketema Date: Mon Oct 9 12:43:04 2017 New Revision: 315235 URL: http://llvm.org/viewvc/llvm-project?rev=315235=rev Log: Implement mem_fence on ptx PTX does not differentiate between read and write fences. Hence, these a lowered to a mem_fence call. The mem_fence function compiles to the

[PATCH] D38679: [libunwind] Support dwarf unwinding on i386 windows

rnk added inline comments. Comment at: src/AddressSpace.hpp:388-389 + found_obj = true; + } else if (!strncmp((const char *)pish->Name, ".eh_frame", + IMAGE_SIZEOF_SHORT_NAME)) { +info.dwarf_section = begin;

[PATCH] D38679: [libunwind] Support dwarf unwinding on i386 windows

mstorsjo added inline comments. Comment at: src/AddressSpace.hpp:521 unw_word_t *offset) { -#ifndef _LIBUNWIND_IS_BAREMETAL +#if !defined(_LIBUNWIND_IS_BAREMETAL) && !defined(_WIN32) Dl_info dyldInfo; jroelofs

[libcxx] r315234 - [libc++] Support Microsoft ABI without vcruntime headers

Author: smeenai Date: Mon Oct 9 12:25:17 2017 New Revision: 315234 URL: http://llvm.org/viewvc/llvm-project?rev=315234=rev Log: [libc++] Support Microsoft ABI without vcruntime headers The vcruntime headers are hairy and clash with both libc++ headers themselves and other libraries. libc++

[PATCH] D38522: [libc++] Support Microsoft ABI without vcruntime headers

This revision was automatically updated to reflect the committed changes. Closed by commit rL315234: [libc++] Support Microsoft ABI without vcruntime headers (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D38522?vs=117613=118251#toc Repository: rL LLVM

[PATCH] D38522: [libc++] Support Microsoft ABI without vcruntime headers

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. I spoke to @EricWF on IRC last week and got his approval to commit this without review if no one had gotten to it in a couple of days, so I'm going ahead with that.

[PATCH] D38679: [libunwind] Support dwarf unwinding on i386 windows

jroelofs added inline comments. Comment at: src/AddressSpace.hpp:521 unw_word_t *offset) { -#ifndef _LIBUNWIND_IS_BAREMETAL +#if !defined(_LIBUNWIND_IS_BAREMETAL) && !defined(_WIN32) Dl_info dyldInfo; Would it

[PATCH] D38679: [libunwind] Support dwarf unwinding on i386 windows

mstorsjo added inline comments. Comment at: src/AddressSpace.hpp:388-389 + found_obj = true; + } else if (!strncmp((const char *)pish->Name, ".eh_frame", + IMAGE_SIZEOF_SHORT_NAME)) { +info.dwarf_section = begin;

r315231 - Testing commit access.

Author: hamzasood Date: Mon Oct 9 12:07:09 2017 New Revision: 315231 URL: http://llvm.org/viewvc/llvm-project?rev=315231=rev Log: Testing commit access. Modified: cfe/trunk/lib/Driver/Compilation.cpp Modified: cfe/trunk/lib/Driver/Compilation.cpp URL:

[PATCH] D38643: PR13575: Fix USR mangling for fixed-size arrays.

jkorous-apple updated this revision to Diff 118247. jkorous-apple added a comment. Single char constants don't need to be c-strings. https://reviews.llvm.org/D38643 Files: lib/Index/USRGeneration.cpp test/Index/USR/array-type.cpp Index: test/Index/USR/array-type.cpp

[PATCH] D38646: [MS] Raise the default value of _MSC_VER to 1910, which is in VS 2017

rnk added a comment. In https://reviews.llvm.org/D38646#892246, @STL_MSFT wrote: > FYI: 1910 was the value for VS 2017 RTM. 1911 is the value for VS 2017 15.3, > the first toolset update. 1912 will be the value for VS 2017 15.5, the second > toolset update. Yep. The initial draft of this

Re: [clang-tools-extra] r315214 - [clangd] Added a command-line arg to mirror clangd input into a file.

Hi, On Mon, Oct 9, 2017 at 9:58 AM, Ilya Biryukov via cfe-commits wrote: > Author: ibiryukov > Date: Mon Oct 9 09:58:16 2017 > New Revision: 315214 > > URL: http://llvm.org/viewvc/llvm-project?rev=315214=rev > Log: > [clangd] Added a command-line arg to mirror clangd

[libclc] r315228 - Make ptx barrier work irrespective of the cl_mem_fence_flags

Author: jketema Date: Mon Oct 9 11:36:48 2017 New Revision: 315228 URL: http://llvm.org/viewvc/llvm-project?rev=315228=rev Log: Make ptx barrier work irrespective of the cl_mem_fence_flags This generates a "bar.sync 0” instruction, which not only causes the threads to wait, but does acts as a

[PATCH] D38700: [Sema][Crash] Correctly handle an non-dependent noexcept expr in function template

erichkeane created this revision. It seems that all of the other templated cases are handled correctly, however the function template case was not correctly handled. This patch recovers from this condition by setting the function to noexcept after diagnosing. Previously it simply set

[PATCH] D38698: AMDGPU: Add read_exec_lo/hi builtins

arsenm created this revision. Herald added subscribers: t-tye, tpr, dstuttard, nhaehnle, wdng, kzhuravl. https://reviews.llvm.org/D38698 Files: include/clang/Basic/BuiltinsAMDGPU.def lib/CodeGen/CGBuiltin.cpp test/CodeGenOpenCL/builtins-amdgcn.cl Index:

Re: r315194 - Make SourceLocation, QualType and friends have constexpr constructors.

Looks like a bug in the compiler, the warning doesn't make any sense. Does creating a FileID() variable and passing that instead work? On Mon, Oct 9, 2017 at 8:02 PM, Galina Kistanova wrote: > Hello Benjamin, > > I look s like this commit broke build on one of our builders:

[PATCH] D38646: [MS] Raise the default value of _MSC_VER to 1910, which is in VS 2017

STL_MSFT added a comment. FYI: 1910 was the value for VS 2017 RTM. 1911 is the value for VS 2017 15.3, the first toolset update. 1912 will be the value for VS 2017 15.5, the second toolset update. Repository: rL LLVM https://reviews.llvm.org/D38646

[PATCH] D38126: Make TBAA information to be part of LValueBaseInfo

kosarev added a comment. Please take a look at https://reviews.llvm.org/D38695, if you want this by smaller pieces. Thanks. https://reviews.llvm.org/D38126 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D38695: [CodeGen] Do not construct complete LValue base info in trivial cases

kosarev created this revision. kosarev added a project: clang. Besides obvious code simplification, avoiding explicit creation of LValueBaseInfo objects makes it easier to make TBAA information to be part of such objects. This is part of https://reviews.llvm.org/D38126 reworked to be a

Re: r315194 - Make SourceLocation, QualType and friends have constexpr constructors.

Hello Benjamin, I look s like this commit broke build on one of our builders: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/5327 . . . FAILED: tools/clang/lib/Serialization/CMakeFiles/clangSerialization.dir/ASTReader.cpp.obj

[PATCH] D38656: [CGExprScalar] In EmitCompare trunc the result if it has different type as E->getType()

Carrot updated this revision to Diff 118236. Carrot marked 3 inline comments as done. https://reviews.llvm.org/D38656 Files: lib/CodeGen/CGExprScalar.cpp test/CodeGen/ppc-vector-compare.cc Index: test/CodeGen/ppc-vector-compare.cc

r315219 - AMDGPU: Fix missing declaration for __builtin_amdgcn_dispatch_ptr

Author: arsenm Date: Mon Oct 9 10:44:18 2017 New Revision: 315219 URL: http://llvm.org/viewvc/llvm-project?rev=315219=rev Log: AMDGPU: Fix missing declaration for __builtin_amdgcn_dispatch_ptr Modified: cfe/trunk/include/clang/Basic/BuiltinsAMDGPU.def

[PATCH] D38643: PR13575: Fix USR mangling for fixed-size arrays.

arphaman added inline comments. Comment at: lib/Index/USRGeneration.cpp:820 +if (const auto *const AT = dyn_cast(T)) { + Out << "{"; + switch (AT->getSizeModifier()) { You might also want to use the character literals for one char strings for

[PATCH] D38694: [ASTImporter] Support importing CXXUnresolvedConstructExpr and UnresolvedLookupExpr

szepet created this revision. This patch adds support for importing two different kind of C++ AST Node. Note: This solution is based on https://github.com/haoNoQ/clang/blob/summary-ipa-draft/lib/AST/ASTImporter.cpp#L7605 . https://reviews.llvm.org/D38694 Files: lib/AST/ASTImporter.cpp

[PATCH] D38643: PR13575: Fix USR mangling for fixed-size arrays.

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM Comment at: lib/Index/USRGeneration.cpp:819 } +if (const auto *const AT = dyn_cast(T)) { + Out << "{"; Nit: I don't think you really

[PATCH] D38679: [libunwind] Support dwarf unwinding on i386 windows

rnk added inline comments. Comment at: src/AddressSpace.hpp:388-389 + found_obj = true; + } else if (!strncmp((const char *)pish->Name, ".eh_frame", + IMAGE_SIZEOF_SHORT_NAME)) { +info.dwarf_section = begin;

[PATCH] D38679: [libunwind] Support dwarf unwinding on i386 windows

mstorsjo created this revision. This builds on some parts from https://reviews.llvm.org/D33601 - some of them were commented on before. This patch contains comments and explanations about those non-obvious parts. https://reviews.llvm.org/D38679 Files: docs/index.rst src/AddressSpace.hpp

[PATCH] D38674: [analyzer] MisusedMovedObjectChecker: More precise warning message

danielmarjamaki added a comment. LGTM https://reviews.llvm.org/D38674 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38643: PR13575: Fix USR mangling for fixed-size arrays.

jkorous-apple updated this revision to Diff 118231. jkorous-apple added a comment. clang-format https://reviews.llvm.org/D38643 Files: lib/Index/USRGeneration.cpp test/Index/USR/array-type.cpp Index: test/Index/USR/array-type.cpp

[PATCH] D38629: [clangd] Added a callback-based codeComplete in clangd.

ilya-biryukov added a comment. We had a discussion with @sammccall offline, probably > - what's the goal? Make the code read more naturally, change the async model, > or something else? Callback API is more flexible (if `std::future` that we use had `then`, they'd be equivalent). We have

[PATCH] D38629: [clangd] Added a callback-based codeComplete in clangd.

ilya-biryukov updated this revision to Diff 118225. ilya-biryukov added a comment. - Added a deprecation notice to function description. https://reviews.llvm.org/D38629 Files: clangd/ClangdServer.cpp clangd/ClangdServer.h Index: clangd/ClangdServer.h

[PATCH] D38538: Avoid printing some redundant name qualifiers in completion

ilya-biryukov added inline comments. Comment at: test/CodeCompletion/enum-switch-case-qualified.cpp:25 // RUN: %clang_cc1 -fsyntax-only -code-completion-at=%s:23:8 %s -o - | FileCheck -check-prefix=CHECK-CC1 %s -// CHECK-CC1: Blue : [#M::N::C::Color#]N::C::Blue -//

[PATCH] D37970: [clangd] Added a command-line arg to mirror clangd input into a file.

This revision was automatically updated to reflect the committed changes. Closed by commit rL315214: [clangd] Added a command-line arg to mirror clangd input into a file. (authored by ibiryukov). Changed prior to commit: https://reviews.llvm.org/D37970?vs=115628=118223#toc Repository: rL

[clang-tools-extra] r315214 - [clangd] Added a command-line arg to mirror clangd input into a file.

Author: ibiryukov Date: Mon Oct 9 09:58:16 2017 New Revision: 315214 URL: http://llvm.org/viewvc/llvm-project?rev=315214=rev Log: [clangd] Added a command-line arg to mirror clangd input into a file. Summary: The arg is useful for debugging and creating test cases. Reviewers: bkramer, krasimir

[PATCH] D38126: Make TBAA information to be part of LValueBaseInfo

kosarev updated this revision to Diff 118200. kosarev added a comment. Removed the extra ###include##. https://reviews.llvm.org/D38126 Files: lib/CodeGen/CGAtomic.cpp lib/CodeGen/CGBlocks.cpp lib/CodeGen/CGExpr.cpp lib/CodeGen/CGObjC.cpp lib/CodeGen/CGObjCRuntime.cpp

[PATCH] D38629: [clangd] Added a callback-based codeComplete in clangd.

sammccall added a comment. I'm missing some context for this one: - what's the goal? Make the code read more naturally, change the async model, or something else? - what's the end state for codeComplete specifically? will we switch to the new overload and delete the other, or is

[PATCH] D38617: Set PreprocessorOpts.GeneratePreamble=true in PrecompiledPreamble.

ilya-biryukov added a comment. In https://reviews.llvm.org/D38617#892092, @bkramer wrote: > A testcase would be nice, but this can go in to unblock things. Thanks for reviewing this! Added a test case to clangd in https://reviews.llvm.org/rL315213. Repository: rL LLVM

[PATCH] D38675: [analyzer] MisusedMovedObjectChecker: Moving the checker out of alpha state

danielmarjamaki added a reviewer: danielmarjamaki. danielmarjamaki added a comment. > However, the checker seems to work with a low false positive rate. (<15 on > the LLVM, 6 effectively different) This does not sound like a low false positive rate to me. Could you describe what the false

[clang-tools-extra] r315213 - [clangd] Added a test for r315212.

Author: ibiryukov Date: Mon Oct 9 09:53:00 2017 New Revision: 315213 URL: http://llvm.org/viewvc/llvm-project?rev=315213=rev Log: [clangd] Added a test for r315212. Added: clang-tools-extra/trunk/test/clangd/diagnostics-preamble.test Added:

[PATCH] D38617: Set PreprocessorOpts.GeneratePreamble=true in PrecompiledPreamble.

This revision was automatically updated to reflect the committed changes. Closed by commit rL315212: Set PreprocessorOpts.GeneratePreamble=true in PrecompiledPreamble. (authored by ibiryukov). Repository: rL LLVM https://reviews.llvm.org/D38617 Files: cfe/trunk/lib/Frontend/ASTUnit.cpp

r315212 - Set PreprocessorOpts.GeneratePreamble=true in PrecompiledPreamble.

Author: ibiryukov Date: Mon Oct 9 09:52:12 2017 New Revision: 315212 URL: http://llvm.org/viewvc/llvm-project?rev=315212=rev Log: Set PreprocessorOpts.GeneratePreamble=true in PrecompiledPreamble. Summary: It was previsouly set only in ASTUnit, but it should be set for all client of

[PATCH] D38538: Avoid printing some redundant name qualifiers in completion

ilya-biryukov updated this revision to Diff 118185. ilya-biryukov added a comment. Herald added a subscriber: mgorny. - Restore qualifiers for types of EnumConstantDecl. https://reviews.llvm.org/D38538 Files: include/clang/AST/QualTypeNames.h include/clang/Tooling/Core/QualTypeNames.h

[PATCH] D38627: [clangd] Added move-only function helpers.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clangd/Function.h:9 +//===--===// + +#ifndef

[PATCH] D38596: Implement attribute target multiversioning

erichkeane updated this revision to Diff 118218. erichkeane added reviewers: rnk, rsmith. erichkeane added a comment. 1 more const-auto. Also noticed I'd missed that removing the 'default' caused the function to fallthrough, so I added llvm_unreachable to the bottom.

[PATCH] D38672: [X86][AVX512] lowering shuffle f/i intrinsic - clang part

m_zuckerman accepted this revision. m_zuckerman added a comment. This revision is now accepted and ready to land. after LLVM-SIDE https://reviews.llvm.org/D38672 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D38627: [clangd] Added move-only function helpers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL315210: [clangd] Added move-only function helpers. (authored by ibiryukov). Repository: rL LLVM https://reviews.llvm.org/D38627 Files: clang-tools-extra/trunk/clangd/ClangdServer.cpp

[clang-tools-extra] r315210 - [clangd] Added move-only function helpers.

Author: ibiryukov Date: Mon Oct 9 09:26:26 2017 New Revision: 315210 URL: http://llvm.org/viewvc/llvm-project?rev=315210=rev Log: [clangd] Added move-only function helpers. Summary: They are now used in ClangdScheduler instead of deferred std::async computations. The results of `std::async` are

[PATCH] D38672: [X86][AVX512] lowering shuffle f/i intrinsic - clang part

m_zuckerman added a comment. Please add depended parent. LGTM After the parent commit (LLVM side). https://reviews.llvm.org/D38672 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   >