[PATCH] D39121: [clang-tidy] Misplaced Operator in Strlen in Alloc

2017-11-01 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware updated this revision to Diff 121102. baloghadamsoftware added a comment. Diagnostic message changed. https://reviews.llvm.org/D39121 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.txt clang-tidy/bugprone/MisplacedOperatorInStrlenInAllo

[PATCH] D39121: [clang-tidy] Misplaced Operator in Strlen in Alloc

2017-11-01 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware added a comment. OK, I will test it on some real code tomorrow, but today is a holiday here. https://reviews.llvm.org/D39121 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D39372: Make DiagnosticIDs::getAllDiagnostics static.

2017-11-01 Thread András Leitereg via Phabricator via cfe-commits
leanil updated this revision to Diff 121104. leanil added a comment. Update usages of the function. Checked with clang-tidy readability-static-accessed-through-instance. https://reviews.llvm.org/D39372 Files: include/clang/Basic/DiagnosticIDs.h lib/Basic/Diagnostic.cpp lib/Basic/Diagnosti

[clang-tools-extra] r317083 - Add LLVM_FALLTHROUGH to silence warning. NFCI.

2017-11-01 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Wed Nov 1 02:22:03 2017 New Revision: 317083 URL: http://llvm.org/viewvc/llvm-project?rev=317083&view=rev Log: Add LLVM_FALLTHROUGH to silence warning. NFCI. Modified: clang-tools-extra/trunk/clangd/ClangdUnit.cpp Modified: clang-tools-extra/trunk/clangd/ClangdUnit.cpp

r317089 - Reformat.

2017-11-01 Thread NAKAMURA Takumi via cfe-commits
Author: chapuni Date: Wed Nov 1 06:47:48 2017 New Revision: 317089 URL: http://llvm.org/viewvc/llvm-project?rev=317089&view=rev Log: Reformat. Modified: cfe/trunk/include/clang/Sema/Sema.h Modified: cfe/trunk/include/clang/Sema/Sema.h URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/incl

r317091 - Fix warnings discovered by rL317076. [-Wunused-private-field]

2017-11-01 Thread NAKAMURA Takumi via cfe-commits
Author: chapuni Date: Wed Nov 1 06:47:55 2017 New Revision: 317091 URL: http://llvm.org/viewvc/llvm-project?rev=317091&view=rev Log: Fix warnings discovered by rL317076. [-Wunused-private-field] Modified: cfe/trunk/include/clang/Sema/Sema.h Modified: cfe/trunk/include/clang/Sema/Sema.h URL:

[PATCH] D39481: [CodeGen] fix const-ness of builtin equivalents of and functions that might set errno

2017-11-01 Thread Sanjay Patel via Phabricator via cfe-commits
spatel added a comment. In https://reviews.llvm.org/D39481#912378, @efriedma wrote: > Granted, I'm not sure all of those are right... I'm pretty sure, for example, > cbrt can't set errno, and carg can. But I'd prefer to deal with that in a > separate patch. I figured we have to be ultra-cons

[PATCH] D37187: [Analyzer] Fix Bug 25609 - Assertion UNREACHABLE: 'Unexpected ProgramPoint' with widen-loops=true

2017-11-01 Thread Henry Wong via Phabricator via cfe-commits
MTC added a comment. ping? Comment at: lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:651-652 + } else if (StoreSite->getLocation().getAs()) { +os << "Reach the max loop limit."; +os << " Assigning a conjured symbol"; +if (R->canPrintPretty()) { z

[PATCH] D37808: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches

2017-11-01 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth updated this revision to Diff 121134. JonasToth added a comment. - remove double whitespace https://reviews.llvm.org/D37808 Files: clang-tidy/hicpp/CMakeLists.txt clang-tidy/hicpp/HICPPTidyModule.cpp clang-tidy/hicpp/MultiwayPathsCoveredCheck.cpp clang-tidy/hicpp/MultiwayPaths

[PATCH] D39053: [Bitfield] Add more cases to making the bitfield a separate location

2017-11-01 Thread Strahinja Petrovic via Phabricator via cfe-commits
spetrovic added a comment. I was looking if I can reslove this problem in backend. Example: C code: typedef struct { unsigned int f1 : 28; unsigned int f2 : 4; unsigned int f3 : 12; } S5; void foo(S5 *cmd) { cmd->f3 = 5; } . ll file (without the patch): %struct

[PATCH] D39239: [AST] Incorrectly qualified unscoped enumeration as template actual parameter.

2017-11-01 Thread Paul Robinson via Phabricator via cfe-commits
probinson added a comment. Have you tried the GDB suite yet? If it has no problems, and we can make LLDB happy, I'm okay with it. https://reviews.llvm.org/D39239 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D39498: [clang-format] Make parseUnaryOperator non-recursive, NFCI

2017-11-01 Thread Benjamin Kramer via Phabricator via cfe-commits
bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Comment at: lib/Format/TokenAnnotator.cpp:1671 +parse(PrecedenceArrowAndPeriod); +for (size_t I = 0, E = Tokens.size(); I < E; ++I) + // The actual preceden

[PATCH] D38284: [clang-tidy] Fix google-readability-namespace-comments handling of C++17 nested namespaces

2017-11-01 Thread Alexandru Octavian Buțiu via Phabricator via cfe-commits
predator5047 updated this revision to Diff 121152. predator5047 added a comment. Fixed assert error caused by macros. https://reviews.llvm.org/D38284 Files: clang-tidy/readability/NamespaceCommentCheck.cpp clang-tidy/readability/NamespaceCommentCheck.h test/clang-tidy/google-readability-n

[PATCH] D39498: [clang-format] Make parseUnaryOperator non-recursive, NFCI

2017-11-01 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir updated this revision to Diff 121156. krasimir added a comment. - Address review comments https://reviews.llvm.org/D39498 Files: lib/Format/TokenAnnotator.cpp Index: lib/Format/TokenAnnotator.cpp === --- lib/Format/Tok

[PATCH] D39498: [clang-format] Make parseUnaryOperator non-recursive, NFCI

2017-11-01 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:1671 +parse(PrecedenceArrowAndPeriod); +for (size_t I = 0, E = Tokens.size(); I < E; ++I) + // The actual precedence doesn't matter. bkramer wrote: > `for (FormatToken *Token :

[PATCH] D39498: [clang-format] Make parseUnaryOperator non-recursive, NFCI

2017-11-01 Thread Krasimir Georgiev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL317113: [clang-format] Make parseUnaryOperator non-recursive, NFCI (authored by krasimir). Repository: rL LLVM https://reviews.llvm.org/D39498 Files: cfe/trunk/lib/Format/TokenAnnotator.cpp Index:

r317113 - [clang-format] Make parseUnaryOperator non-recursive, NFCI

2017-11-01 Thread Krasimir Georgiev via cfe-commits
Author: krasimir Date: Wed Nov 1 11:20:41 2017 New Revision: 317113 URL: http://llvm.org/viewvc/llvm-project?rev=317113&view=rev Log: [clang-format] Make parseUnaryOperator non-recursive, NFCI Summary: This patch makes the implementation of parseUnaryOperator non-recursive. We had a problem with

[PATCH] D39478: [clang-format] Handle leading comments in using declaration

2017-11-01 Thread Daniel Jasper via Phabricator via cfe-commits
djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Some minor remarks, but generally looks good. Thanks for fixing this! Comment at: lib/Format/UsingDeclarationsSorter.cpp:136 for (size_t I = 0, E = AnnotatedLines.size()

[PATCH] D39481: [CodeGen] fix const-ness of builtin equivalents of and functions that might set errno

2017-11-01 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. I think we should assume libm complies with the C99 standard (specifically, the appendix specifying the behavior of IEEE floating-point). Otherwise, we have no basis to predict the behavior of any standard library call. From the standard: "Functions with a NaN argumen

[PATCH] D39478: [clang-format] Handle leading comments in using declaration

2017-11-01 Thread Igor Sugak via Phabricator via cfe-commits
sugak updated this revision to Diff 121165. sugak marked 3 inline comments as done. sugak added a comment. Updated per comments. @djasper : Thank you for the review! Would you commit this for me? https://reviews.llvm.org/D39478 Files: lib/Format/UsingDeclarationsSorter.cpp unittests/Format

[PATCH] D39502: [Driver] Make clang/cc conforms to UNIX standard

2017-11-01 Thread Steven Wu via Phabricator via cfe-commits
steven_wu created this revision. This is basically reverting r261774 with a tweak for clang-cl. UNIX standard states: When c99 encounters a compilation error that causes an object file not to be created, it shall write a diagnostic to standard error and continue to compile other source code operan

[PATCH] D39502: [Driver] Make clang/cc conforms to UNIX standard

2017-11-01 Thread Steven Wu via Phabricator via cfe-commits
steven_wu added a comment. More background here that doesn't fit in the commit message. The tweak for cl mode is intended for r262420. I don't see any test breakage on my machine without that hack but I leave it in there just in case. A little reasoning behind clang driver for CUDA. This is wha

[PATCH] D39504: [OpenMP] Extend "Avoid VLAs for reduction" optimization to VLAs as base

2017-11-01 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld created this revision. We can generate constant sized arrays whenever the array section has constant length, even if the base expression itself is a VLA. https://reviews.llvm.org/D39504 Files: lib/Sema/SemaOpenMP.cpp test/OpenMP/for_reduction_codegen.cpp Index: test/OpenMP/for_red

[PATCH] D39505: [OpenMP] Show error if VLAs are not supported

2017-11-01 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld created this revision. Herald added a subscriber: jholewinski. Some target devices (e.g. Nvidia GPUs) don't support dynamic stack allocation and hence no VLAs. Print errors with description instead of failing in the backend or generating code that doesn't work. This patch handles explici

[PATCH] D39504: [OpenMP] Extend "Avoid VLAs for reduction" optimization to VLAs as base

2017-11-01 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D39504 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D39279: Stringizing raw string literals containing newline

2017-11-01 Thread Taewook Oh via Phabricator via cfe-commits
twoh added a comment. Ping. Thanks! https://reviews.llvm.org/D39279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39502: [Driver] Make clang/cc conforms to UNIX standard

2017-11-01 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a comment. I have a few nitpicks, but otherwise this LGTM. I'd like to wait for someone on the CUDA side to confirm though. Comment at: lib/Driver/Compilation.cpp:185 -void Compilation::ExecuteJobs( -const JobList &Jobs, -SmallVectorImpl> &FailingCo

[PATCH] D39509: Vary toolchain selection by -fused-ld

2017-11-01 Thread Dave Lee via Phabricator via cfe-commits
kastiglione created this revision. This change allows binutils to be used for linking with MSVC. Currently, when using an MSVC target and `-fuse-ld=bfd`, the driver produces an invalid linker invocation. https://reviews.llvm.org/D39509 Files: lib/Driver/Driver.cpp test/Driver/Inputs/Windows

[libcxx] r317124 - [libc++] Don't alias quick_exit if __ANDROID_API__ < 21

2017-11-01 Thread Dan Albert via cfe-commits
Author: danalbert Date: Wed Nov 1 14:17:56 2017 New Revision: 317124 URL: http://llvm.org/viewvc/llvm-project?rev=317124&view=rev Log: [libc++] Don't alias quick_exit if __ANDROID_API__ < 21 Summary: quick_exit() and at_quick_exit() were introduced in android NDK 21: https://android.googlesource

[libunwind] r317125 - [libunwind] Don't use dl_iterate_phdr if __ANDROID_API__ < 21

2017-11-01 Thread Dan Albert via cfe-commits
Author: danalbert Date: Wed Nov 1 14:26:06 2017 New Revision: 317125 URL: http://llvm.org/viewvc/llvm-project?rev=317125&view=rev Log: [libunwind] Don't use dl_iterate_phdr if __ANDROID_API__ < 21 Summary: On ARM, dl_iterate_phdr is only implemented in the Android NDK version 21 or later: https

[PATCH] D39509: Vary Windows toolchain selection by -fused-ld

2017-11-01 Thread Dave Lee via Phabricator via cfe-commits
kastiglione updated this revision to Diff 121185. kastiglione added a comment. Use "link" as default when inspecting -fuse-ld= https://reviews.llvm.org/D39509 Files: lib/Driver/Driver.cpp test/Driver/Inputs/Windows/usr/bin/ld.bfd test/Driver/fuse-ld.c Index: test/Driver/fuse-ld.c ==

[PATCH] D39509: Vary Windows toolchain selection by -fused-ld

2017-11-01 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added inline comments. Comment at: lib/Driver/Driver.cpp:3884 +const auto A = Args.getLastArgValue(options::OPT_fuse_ld_EQ, "link"); +if (A.equals_lower("link") || A.equals_lower("lld")) + TC = `lld-link` is a valid invocation for

[PATCH] D39509: Vary Windows toolchain selection by -fused-ld

2017-11-01 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. Also title says `-fused-ld` instead of `-fuse-ld` https://reviews.llvm.org/D39509 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39509: Vary Windows toolchain selection by -fuse-ld

2017-11-01 Thread Dave Lee via Phabricator via cfe-commits
kastiglione updated this revision to Diff 121194. kastiglione added a comment. Base decision on "bfd" prefix https://reviews.llvm.org/D39509 Files: lib/Driver/Driver.cpp test/Driver/Inputs/Windows/usr/bin/ld.bfd test/Driver/fuse-ld.c Index: test/Driver/fuse-ld.c

[PATCH] D39509: Vary Windows toolchain selection by -fuse-ld

2017-11-01 Thread Dave Lee via Phabricator via cfe-commits
kastiglione updated this revision to Diff 121196. kastiglione added a comment. Inline the arg variable https://reviews.llvm.org/D39509 Files: lib/Driver/Driver.cpp test/Driver/Inputs/Windows/usr/bin/ld.bfd test/Driver/fuse-ld.c Index: test/Driver/fuse-ld.c ==

[PATCH] D39518: [analyzer] do not crash on libcxx03 call_once implementation

2017-11-01 Thread George Karpenkov via Phabricator via cfe-commits
george.karpenkov created this revision. Herald added a reviewer: EricWF. Herald added subscribers: szepet, xazax.hun, javed.absar. Addresses https://bugs.llvm.org/show_bug.cgi?id=35075 https://reviews.llvm.org/D39518 Files: lib/Analysis/BodyFarm.cpp test/Analysis/call_once.cpp Index: test

r317137 - [ASTMatchers] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).

2017-11-01 Thread Eugene Zelenko via cfe-commits
Author: eugenezelenko Date: Wed Nov 1 16:09:49 2017 New Revision: 317137 URL: http://llvm.org/viewvc/llvm-project?rev=317137&view=rev Log: [ASTMatchers] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC). Modified: cfe/trunk/include/clang/ASTMatchers/AS

[PATCH] D39520: [libcxx][CMake] Fix libc++ build when no LLVM source tree is available.

2017-11-01 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai created this revision. Herald added a subscriber: mgorny. Fixes error > CMake Error at test/CMakeLists.txt:52 (configure_lit_site_cfg): > Unknown CMake command "configure_lit_site_cfg". configure_lit_site_cfg is defined in AddLLVM module and not available without LLVM source tree. Rever

r317140 - Fix missing -Wregister warning when 'register' is applied to a function parameter.

2017-11-01 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Nov 1 16:38:37 2017 New Revision: 317140 URL: http://llvm.org/viewvc/llvm-project?rev=317140&view=rev Log: Fix missing -Wregister warning when 'register' is applied to a function parameter. Modified: cfe/trunk/lib/Sema/SemaDecl.cpp cfe/trunk/test/CXX/dcl.dcl/dcl

[PATCH] D39521: [x86 TargetInfo] Pull CPU handling for the x86 TargetInfo into a .def file.

2017-11-01 Thread Erich Keane via Phabricator via cfe-commits
erichkeane created this revision. In anticipation of multiversioned target support (and just for code sanity), this patch extracts as much of the X86 TargetInfo CPU values into its own file, unifying the support. This has the side-effect of being a touch more liberal in what it accepts than GCC,

[libcxx] r317142 - Revert "[libc++] Don't alias quick_exit if __ANDROID_API__ < 21"

2017-11-01 Thread Dan Albert via cfe-commits
Author: danalbert Date: Wed Nov 1 16:43:07 2017 New Revision: 317142 URL: http://llvm.org/viewvc/llvm-project?rev=317142&view=rev Log: Revert "[libc++] Don't alias quick_exit if __ANDROID_API__ < 21" Broke the Darwin build bots. This reverts commit f56f1bba1ade4a408d403ff050d50e837bae47df. Mod

Re: [PATCH] D39520: [libcxx][CMake] Fix libc++ build when no LLVM source tree is available.

2017-11-01 Thread Zachary Turner via cfe-commits
This will remove the ability to use llvm-lit script even if source tree is available. Can you put this behind a check that for standalone build? Also, why was this just found? shouldnt this have been failing on Apple’s libcxx for the past several months? On Wed, Nov 1, 2017 at 4:38 PM Volodymyr S

Re: [PATCH] D39520: [libcxx][CMake] Fix libc++ build when no LLVM source tree is available.

2017-11-01 Thread Volodymyr Sapsai via cfe-commits
On Nov 1, 2017, at 16:47, Zachary Turner wrote: > > This will remove the ability to use llvm-lit script even if source tree is > available. Can you please point me to the place where llvm-lit is enabled in configure_lit_site_cfg? Asking for my education, to understand lit configuration better

Re: [PATCH] D39520: [libcxx][CMake] Fix libc++ build when no LLVM source tree is available.

2017-11-01 Thread Zachary Turner via cfe-commits
On Wed, Nov 1, 2017 at 5:13 PM Volodymyr Sapsai wrote: > On Nov 1, 2017, at 16:47, Zachary Turner wrote: > > > This will remove the ability to use llvm-lit script even if source tree is > available. > > Can you please point me to the place where llvm-lit is enabled in > configure_lit_site_cfg? A

r317146 - CodeGen: simplify EH personality selection (NFC)

2017-11-01 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Wed Nov 1 17:25:40 2017 New Revision: 317146 URL: http://llvm.org/viewvc/llvm-project?rev=317146&view=rev Log: CodeGen: simplify EH personality selection (NFC) Fix a typo in the comment, reorder to ensure that the ordering matches across the ObjC/ObjC++ cases. NFCI. Modi

[PATCH] D38596: Implement attribute target multiversioning

2017-11-01 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. In https://reviews.llvm.org/D38596#910035, @erichkeane wrote: > > You should add tests for: > > > > - the PCH / Modules case (particularly regarding what happens when merging > > multiple copies of the same set of functions, for instance when they're > > defined inline)

[PATCH] D38596: Implement attribute target multiversioning

2017-11-01 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added inline comments. Comment at: lib/Basic/Targets/X86.cpp:1329 + // implementation in in GCC 7.x in gcc/config/i386/i386.c + // ::get_builtin_code_for_version. This list is simplified from that source. + const auto TargetArray = {"avx512vpopcntdq", e

[PATCH] D38596: Implement attribute target multiversioning

2017-11-01 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. In https://reviews.llvm.org/D38596#913322, @rsmith wrote: > The big pain point here is that we don't know whether a function is > multiversioned until we see the *second* version of it (or a declaration with > no target attribute or a declaration with a "default" tar

[PATCH] D39521: [x86 TargetInfo] Pull CPU handling for the x86 TargetInfo into a .def file.

2017-11-01 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. Thanks, this looks like a nice cleanup. I wonder of some of the switches over `CPUKind` (setting default features and macros) could also be moved into the .def file, but let's get this landed first and then see if that looks like an improvement. Comme

[PATCH] D39522: [clang-rename] Use add_clang_tool

2017-11-01 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai created this revision. Herald added a subscriber: mgorny. `add_clang_tool` includes a call to `add_clang_executable`, but it also sets up the install rule, and adds an `install-*` target. The latter is required for using `LLVM_DISTRIBUTION_COMPONENTS`. https://reviews.llvm.org/D39522 Fi

[PATCH] D39521: [x86 TargetInfo] Pull CPU handling for the x86 TargetInfo into a .def file.

2017-11-01 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. In https://reviews.llvm.org/D39521#913337, @rsmith wrote: > Thanks, this looks like a nice cleanup. I wonder of some of the switches over > `CPUKind` (setting default features and macros) could also be moved into the > .def file, but let's get this landed first and t

[PATCH] D39523: [clang-reorder-fields] Switch to add_clang_tool

2017-11-01 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai created this revision. Herald added a subscriber: mgorny. `add_clang_tool` invokes `add_clang_executable` internally, but it also takes care of setting up the install rule. It also adds an `install-*` build target, which is required for `LLVM_DISTRIBUTION_COMPONENTS`. https://reviews.llv

[PATCH] D39522: [clang-rename] Use add_clang_tool

2017-11-01 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D39522 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D39524: [libclang] Add dummy libclang-headers target

2017-11-01 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai created this revision. Herald added a subscriber: mgorny. `LLVM_DISTRIBUTION_COMPONENTS` assumes that each component has both `component` and `install-component` targets. Add a dummy no-op target for `libclang-headers` to placate this check. https://reviews.llvm.org/D39524 Files: tool

r317147 - PR33746: Store the 'inline'ness of a static data member with the update record

2017-11-01 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Nov 1 18:06:00 2017 New Revision: 317147 URL: http://llvm.org/viewvc/llvm-project?rev=317147&view=rev Log: PR33746: Store the 'inline'ness of a static data member with the update record for instantiating its definition. We model the 'inline'ness as being instantiated wit

[PATCH] D39523: [clang-reorder-fields] Switch to add_clang_tool

2017-11-01 Thread Shoaib Meenai via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL317149: [clang-reorder-fields] Switch to add_clang_tool (authored by smeenai). Repository: rL LLVM https://reviews.llvm.org/D39523 Files: clang-tools-extra/trunk/clang-reorder-fields/tool/CMakeLists

[clang-tools-extra] r317149 - [clang-reorder-fields] Switch to add_clang_tool

2017-11-01 Thread Shoaib Meenai via cfe-commits
Author: smeenai Date: Wed Nov 1 18:10:05 2017 New Revision: 317149 URL: http://llvm.org/viewvc/llvm-project?rev=317149&view=rev Log: [clang-reorder-fields] Switch to add_clang_tool `add_clang_tool` invokes `add_clang_executable` internally, but it also takes care of setting up the install rule.

r317150 - [clang-rename] Use add_clang_tool

2017-11-01 Thread Shoaib Meenai via cfe-commits
Author: smeenai Date: Wed Nov 1 18:11:40 2017 New Revision: 317150 URL: http://llvm.org/viewvc/llvm-project?rev=317150&view=rev Log: [clang-rename] Use add_clang_tool `add_clang_tool` includes a call to `add_clang_executable`, but it also sets up the install rule, and adds an `install-*` target.

[PATCH] D39522: [clang-rename] Use add_clang_tool

2017-11-01 Thread Shoaib Meenai via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL317150: [clang-rename] Use add_clang_tool (authored by smeenai). Repository: rL LLVM https://reviews.llvm.org/D39522 Files: cfe/trunk/tools/clang-rename/CMakeLists.txt Index: cfe/trunk/tools/clang

[PATCH] D39524: [libclang] Add dummy libclang-headers target

2017-11-01 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai updated this revision to Diff 121223. smeenai added a comment. Better comment https://reviews.llvm.org/D39524 Files: tools/libclang/CMakeLists.txt Index: tools/libclang/CMakeLists.txt === --- tools/libclang/CMakeLists.t

[PATCH] D39446: [PGO] Detect more structural changes with the stable hash

2017-11-01 Thread Vedant Kumar via Phabricator via cfe-commits
vsk updated this revision to Diff 121224. vsk marked 2 inline comments as done. vsk edited the summary of this revision. vsk added a comment. - Handle loop nesting, conditions, and out-of-order control flow. - Improve test coverage. Add a format compatibility test, and check that functions which

[PATCH] D39438: [analyzer] Diagnose stack leaks via block captures

2017-11-01 Thread Alexander Shaposhnikov via Phabricator via cfe-commits
alexshap updated this revision to Diff 121229. alexshap added a comment. Refactor the checker, add more tests. Repository: rL LLVM https://reviews.llvm.org/D39438 Files: lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp test/Analysis/stack-capture-leak-arc.mm test/Analysis/stack-c

[PATCH] D39438: [analyzer] Diagnose stack leaks via block captures

2017-11-01 Thread Alexander Shaposhnikov via Phabricator via cfe-commits
alexshap added inline comments. Comment at: test/Analysis/stack-async-leak.m:1 +// RUN: %clang_analyze_cc1 -triple x86_64-apple-darwin10 -analyzer-checker=core -fblocks -fobjc-arc -verify %s + dcoughlin wrote: > Can you add an additional run line testing the exp

[PATCH] D39438: [analyzer] Diagnose stack leaks via block captures

2017-11-01 Thread Alexander Shaposhnikov via Phabricator via cfe-commits
alexshap updated this revision to Diff 121230. alexshap added a comment. Add more tests for blocks being passed around Repository: rL LLVM https://reviews.llvm.org/D39438 Files: lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp test/Analysis/stack-capture-leak-arc.mm test/Analysis

[clang-tools-extra] r317155 - [clang-tidy] Clean up installation rules

2017-11-01 Thread Shoaib Meenai via cfe-commits
Author: smeenai Date: Wed Nov 1 18:48:20 2017 New Revision: 317155 URL: http://llvm.org/viewvc/llvm-project?rev=317155&view=rev Log: [clang-tidy] Clean up installation rules An installation rule for the executable with the correct component is already created by `add_clang_tool`, so the rule in

[libcxx] r317165 - Creating release candidate rc1 from release_501 branch

2017-11-01 Thread Tom Stellard via cfe-commits
Author: tstellar Date: Wed Nov 1 18:55:53 2017 New Revision: 317165 URL: http://llvm.org/viewvc/llvm-project?rev=317165&view=rev Log: Creating release candidate rc1 from release_501 branch Added: libcxx/tags/RELEASE_501/rc1/ (props changed) - copied from r317164, libcxx/branches/rele

[libcxx] r317164 - Creating release directory for release_501.

2017-11-01 Thread Tom Stellard via cfe-commits
Author: tstellar Date: Wed Nov 1 18:55:46 2017 New Revision: 317164 URL: http://llvm.org/viewvc/llvm-project?rev=317164&view=rev Log: Creating release directory for release_501. Added: libcxx/tags/RELEASE_501/ ___ cfe-commits mailing list cfe-comm

[libcxxabi] r317166 - Creating release directory for release_501.

2017-11-01 Thread Tom Stellard via cfe-commits
Author: tstellar Date: Wed Nov 1 18:55:55 2017 New Revision: 317166 URL: http://llvm.org/viewvc/llvm-project?rev=317166&view=rev Log: Creating release directory for release_501. Added: libcxxabi/tags/RELEASE_501/ ___ cfe-commits mailing list cfe-c

[libcxxabi] r317167 - Creating release candidate rc1 from release_501 branch

2017-11-01 Thread Tom Stellard via cfe-commits
Author: tstellar Date: Wed Nov 1 18:55:58 2017 New Revision: 317167 URL: http://llvm.org/viewvc/llvm-project?rev=317167&view=rev Log: Creating release candidate rc1 from release_501 branch Added: libcxxabi/tags/RELEASE_501/rc1/ - copied from r317166, libcxxabi/branches/release_50/ ___

[libunwind] r317178 - Creating release directory for release_501.

2017-11-01 Thread Tom Stellard via cfe-commits
Author: tstellar Date: Wed Nov 1 18:56:29 2017 New Revision: 317178 URL: http://llvm.org/viewvc/llvm-project?rev=317178&view=rev Log: Creating release directory for release_501. Added: libunwind/tags/RELEASE_501/ ___ cfe-commits mailing list cfe-c

[libunwind] r317179 - Creating release candidate rc1 from release_501 branch

2017-11-01 Thread Tom Stellard via cfe-commits
Author: tstellar Date: Wed Nov 1 18:56:32 2017 New Revision: 317179 URL: http://llvm.org/viewvc/llvm-project?rev=317179&view=rev Log: Creating release candidate rc1 from release_501 branch Added: libunwind/tags/RELEASE_501/rc1/ (props changed) - copied from r317178, libunwind/branche

[PATCH] D38986: [Analyzer] Better unreachable message in enumeration

2017-11-01 Thread George Karpenkov via Phabricator via cfe-commits
george.karpenkov added a comment. @dcoughlin @NoQ so can this be committed? https://reviews.llvm.org/D38986 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39438: [analyzer] Diagnose stack leaks via block captures

2017-11-01 Thread Alexander Shaposhnikov via Phabricator via cfe-commits
alexshap added inline comments. Comment at: test/Analysis/stack-capture-leak-arc.mm:68 + int x = 123; + int &r = x; + void (^b)(void) = ^void(void) { c++ reference Repository: rL LLVM https://reviews.llvm.org/D39438

[PATCH] D39505: [OpenMP] Show error if VLAs are not supported

2017-11-01 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: include/clang/Basic/TargetInfo.h:944 + /// \brief Whether target supports variable-length arrays. + bool isVLASupported() const { return VLASupported; } + The way you've written this makes it sound like "does the targ

[PATCH] D38986: [Analyzer] Better unreachable message in enumeration

2017-11-01 Thread Devin Coughlin via Phabricator via cfe-commits
dcoughlin added a comment. Personally, I don't think this is worth it and I find it unpleasant to add untestable code -- especially if that code is going to stick around in release builds. https://reviews.llvm.org/D38986 ___ cfe-commits mailing li

[PATCH] D39524: [libclang] Add dummy libclang-headers target

2017-11-01 Thread Argyrios Kyrtzidis via Phabricator via cfe-commits
akyrtzi accepted this revision. akyrtzi added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D39524 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[clang-tools-extra] r317187 - [clangd] Remove redundant install

2017-11-01 Thread Shoaib Meenai via cfe-commits
Author: smeenai Date: Wed Nov 1 22:02:24 2017 New Revision: 317187 URL: http://llvm.org/viewvc/llvm-project?rev=317187&view=rev Log: [clangd] Remove redundant install `add_clang_tool` already adds the install command, so the one here is redundant. Modified: clang-tools-extra/trunk/clangd/to

r317188 - [libclang] Add dummy libclang-headers target

2017-11-01 Thread Shoaib Meenai via cfe-commits
Author: smeenai Date: Wed Nov 1 22:04:00 2017 New Revision: 317188 URL: http://llvm.org/viewvc/llvm-project?rev=317188&view=rev Log: [libclang] Add dummy libclang-headers target `LLVM_DISTRIBUTION_COMPONENTS` assumes that each component has both `component` and `install-component` targets. Add a

[PATCH] D39524: [libclang] Add dummy libclang-headers target

2017-11-01 Thread Shoaib Meenai via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL317188: [libclang] Add dummy libclang-headers target (authored by smeenai). Repository: rL LLVM https://reviews.llvm.org/D39524 Files: cfe/trunk/tools/libclang/CMakeLists.txt Index: cfe/trunk/tool

[PATCH] D39251: [libunwind] Fix building for ARM with dwarf exception handling

2017-11-01 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd accepted this revision. compnerd added inline comments. This revision is now accepted and ready to land. Comment at: src/Registers.hpp:1481 + mutable uint32_t _iwmmx_control[4]; #endif }; Why the change to mark these as mutable? https://reviews.llvm

[PATCH] D39114: [XRay] Initial XRay in Darwin Support

2017-11-01 Thread Dean Michael Berris via Phabricator via cfe-commits
dberris added a comment. @kubamracek -- if you don't mind having a look at this, I'm looking for thoughts/feedback on how we can address the "blockers": - Assembly for Darwin x86_64 and how we avoid the ELF'isms (do we need to implement darwin-specific assembly for MachO?) - Syscalls, testing,