craig.topper added a comment.
Ok then we can keep the new test.
I believe the isValidFeature list was copied from the list in hasFeature. But
isValidFeature should match the names used by initFeatureMap since that's what
we use to look them up.
https://reviews.llvm.org/D39631
_
rwols updated this revision to Diff 121605.
rwols added a comment.
- Rebase to latest SVN revision.
- Use `void reply(llvm:Expected Result)` for transparent error handling.
- Use `FSProvider` from `ClangdServer` to provide a filesystem for
`format::getStyle`.
- Organize things around `llvm::Expec
mstorsjo added a comment.
In https://reviews.llvm.org/D39631#915943, @craig.topper wrote:
> Can we just add -Werror to test/CodeGen/3dnow-builtins.c to test this?
That file actually already has got `-Werror`
> I believe it should be throwing a warning currently.
It doesn't. That test enable
tberghammer added a comment.
I verified that https://reviews.llvm.org/D39545 will be fixing the problem on
the LLDB side (previously we had no proper scoped enum support in LLDB)
https://reviews.llvm.org/D39239
___
cfe-commits mailing list
cfe-comm
xgsa added inline comments.
Comment at: include/clang/AST/PrettyPrinter.h:227
+
+ /// \brief Use formatting compatible with ABI specification. It is necessary
for
+ /// saving entities into debug tables which have to be compatible with
aprantl wrote:
> xgsa wr
xgsa created this revision.
xgsa added a project: clang.
For consistency with the code proposed in https://reviews.llvm.org/D39622
Repository:
rL LLVM
https://reviews.llvm.org/D39633
Files:
include/clang/AST/PrettyPrinter.h
Index: include/clang/AST/PrettyPrinter.h
craig.topper requested changes to this revision.
craig.topper added a comment.
This revision now requires changes to proceed.
Can we just add -Werror to test/CodeGen/3dnow-builtins.c to test this? I
believe it should be throwing a warning currently.
Can we also remove mm3dnow and mm3dnowa from
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D39631
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
mstorsjo added a comment.
In https://reviews.llvm.org/D39534#915938, @jroelofs wrote:
> i.e. should this be keyed off of `__ARM_EABI__` instead?
I'm not really sure. As I quoted earlier, the exact case for enabling these
directives in the LLVM codebase right now is `(!IsMachO && !IsCOFF)`.
We
jroelofs added a comment.
In https://reviews.llvm.org/D39534#915937, @mstorsjo wrote:
> In https://reviews.llvm.org/D39534#915935, @jroelofs wrote:
>
> > In https://reviews.llvm.org/D39534#915920, @mstorsjo wrote:
> >
> > > In https://reviews.llvm.org/D39534#915916, @compnerd wrote:
> > >
> > > >
mstorsjo added a comment.
In https://reviews.llvm.org/D39534#915935, @jroelofs wrote:
> In https://reviews.llvm.org/D39534#915920, @mstorsjo wrote:
>
> > In https://reviews.llvm.org/D39534#915916, @compnerd wrote:
> >
> > > Very well, if thats the current implementation in the AsmParser, thats
>
jroelofs added a comment.
In https://reviews.llvm.org/D39534#915920, @mstorsjo wrote:
> In https://reviews.llvm.org/D39534#915916, @compnerd wrote:
>
> > Very well, if thats the current implementation in the AsmParser, thats
> > reasonable. I don't think that the directive has anything to do wi
mstorsjo created this revision.
Herald added subscribers: kristof.beyls, aemerson.
This didn't require any further changes to libunwind as long as win64 in
general is handled correctly.
https://reviews.llvm.org/D39632
Files:
docs/index.rst
Index: docs/index.rst
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317423: Add ifdefs around ELF specific parts of
UnwindRegisters*.S for arm (authored by mstorsjo).
Changed prior to commit:
https://reviews.llvm.org/D39534?vs=121245&id=121600#toc
Repository:
rL LLVM
Author: mstorsjo
Date: Sat Nov 4 14:01:31 2017
New Revision: 317423
URL: http://llvm.org/viewvc/llvm-project?rev=317423&view=rev
Log:
Add ifdefs around ELF specific parts of UnwindRegisters*.S for arm
This allows using dwarf exceptions on MinGW/ARM.
Differential Revision: https://reviews.llvm.o
mstorsjo added a comment.
In https://reviews.llvm.org/D39534#915916, @compnerd wrote:
> Very well, if thats the current implementation in the AsmParser, thats
> reasonable. I don't think that the directive has anything to do with the
> file format though.
I can agree with that. In addition t
compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.
Very well, if thats the current implementation in the AsmParser, thats
reasonable. I don't think that the directive has anything to do with the file
format though.
https://reviews.llvm.
Author: lebedevri
Date: Sat Nov 4 13:27:47 2017
New Revision: 317421
URL: http://llvm.org/viewvc/llvm-project?rev=317421&view=rev
Log:
[Sema] Document+test the -Wsign-conversion change for enums in C code [NFC]
Basically a regression after r316268.
However the diagnostic is correct, but the test
Author: aaronballman
Date: Sat Nov 4 13:06:49 2017
New Revision: 317419
URL: http://llvm.org/viewvc/llvm-project?rev=317419&view=rev
Log:
Move the clang-tblgen-targets project into the Misc folder on IDEs like Visual
Studio rather than leave it in the root directory. NFC.
Modified:
cfe/trun
Author: aaronballman
Date: Sat Nov 4 13:06:22 2017
New Revision: 317418
URL: http://llvm.org/viewvc/llvm-project?rev=317418&view=rev
Log:
Move the clang-tblgen project into the Clang tablegenning folder on IDEs like
Visual Studio rather than leave it in the root directory. NFC.
Modified:
cf
mstorsjo created this revision.
These were missed in SVN r316783, which broke compiling mingw-w64 CRT.
https://reviews.llvm.org/D39631
Files:
lib/Basic/Targets/X86.cpp
test/Headers/mm3dnow.c
Index: test/Headers/mm3dnow.c
===
Author: aaronballman
Date: Sat Nov 4 13:00:21 2017
New Revision: 317417
URL: http://llvm.org/viewvc/llvm-project?rev=317417&view=rev
Log:
Move the libclang-headers project into the Misc folder on IDEs like Visual
Studio rather than leave it in the root directory. NFC.
Modified:
cfe/trunk/to
aprantl added inline comments.
Comment at: include/clang/AST/PrettyPrinter.h:227
+
+ /// \brief Use formatting compatible with ABI specification. It is necessary
for
+ /// saving entities into debug tables which have to be compatible with
xgsa wrote:
> aprantl
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317407: [CodeGen] add remquo to list of recognized library
calls (authored by spatel).
Changed prior to commit:
https://reviews.llvm.org/D39615?vs=121536&id=121591#toc
Repository:
rL LLVM
https://re
Author: spatel
Date: Sat Nov 4 08:03:11 2017
New Revision: 317407
URL: http://llvm.org/viewvc/llvm-project?rev=317407&view=rev
Log:
[CodeGen] add remquo to list of recognized library calls
This is just an oversight because we already do recognize __builtin_remquo()
with the same signature.
http
Hahnfeld marked 3 inline comments as done.
Hahnfeld added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:944
+ /// \brief Whether target supports variable-length arrays.
+ bool isVLASupported() const { return VLASupported; }
+
rjmccall wrote:
> H
xgsa added inline comments.
Comment at: include/clang/AST/PrettyPrinter.h:68
/// \brief The number of spaces to use to indent each line.
- unsigned Indentation : 8;
+ unsigned Indentation : 7;
aprantl wrote:
> this change looks like it has the potential to
xgsa added a comment.
In https://reviews.llvm.org/D39622#915722, @aprantl wrote:
> Can you add a testcase?
Definitely, I just wanted to know if such fix is correct at all. Moreover,
could you please help me with the correct place for a test case? Possibly,
there are some similar test case I c
boris added a comment.
Hi Richard,
Thanks for still entertaining the idea. Yes, I believe, in order to support
modules (TS) the build system will have to extract module (and header while at
it) dependency information prior to compilation rather than as a byproduct of
compilation (which is how
29 matches
Mail list logo
