Typz added a comment.
ping?
https://reviews.llvm.org/D37813
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Typz added a comment.
ping ?
https://reviews.llvm.org/D33589
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Typz added a comment.
ping?
https://reviews.llvm.org/D33440
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Typz added a comment.
ping?
https://reviews.llvm.org/D32478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Thu, Nov 9, 2017 at 4:02 AM Richard Smith - zygoloid via Phabricator <
revi...@reviews.llvm.org> wrote:
> rsmith added a comment.
>
> I'm not entirely sure what's happening with this and
> https://reviews.llvm.org/D38818, but the direction looks good to me, and
> I left a couple of comments on
phosek created this revision.
Herald added a subscriber: mgorny.
The support for relax relocations is dependent on the linker and
different toolchains within the same compiler can be using different
linkers some of which may or may not support relax relocations.
Give toolchains the option
rjmccall added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:944
+ /// \brief Whether target supports variable-length arrays.
+ bool isVLASupported() const { return VLASupported; }
+
ABataev wrote:
> ABataev wrote:
> > Hahnfeld wrote:
> > > rjmc
sammccall updated this revision to Diff 122206.
sammccall added a comment.
Add test verifying that working directory is compile_flags's parent.
https://reviews.llvm.org/D39799
Files:
docs/JSONCompilationDatabase.rst
include/clang/Tooling/CompilationDatabase.h
lib/Tooling/CompilationDataba
klimek added a comment.
In https://reviews.llvm.org/D32478#806757, @Typz wrote:
> I renamed the option to `AlignAfterOperator`, is it acceptable now?
> (I also thought of `UnindentOperator`, but I think it is better to keep the
> notion of alignment)
>
> Note that this style is used in multiple
sammccall added a comment.
In https://reviews.llvm.org/D39799#919508, @ilya-biryukov wrote:
> In https://reviews.llvm.org/D39799#919494, @sammccall wrote:
>
> > e.g. IIUC, things like `#include "sibling.h"` won't look for the h file
> > next to the cc file?
>
>
> Actually, this should work as qu
djasper added a comment.
Out of curiosity, will this be able to fix the two situations that you get for
python extension?
There, you usually have a PyObject_HEAD with out semicolon in a struct and than
a PyObject_HEAD_INIT(..) in a braced init list. More info:
http://starship.python.net/crew/mwh
Author: rjmccall
Date: Thu Nov 9 01:32:32 2017
New Revision: 317776
URL: http://llvm.org/viewvc/llvm-project?rev=317776&view=rev
Log:
Fix a bug with the use of __builtin_bzero in a conditional expression.
Patch by Bharathi Seshadri!
Modified:
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
cfe/trun
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D39799#920195, @sammccall wrote:
> It's doable, but then you're fighting the infrastructure here. The same
> ambiguity can exist between any pair of C
Quolyk created this revision.
Herald added a subscriber: ilya-biryukov.
This is my first attempt to contribute to llvm. I'm trying to implement this
https://bugs.llvm.org/show_bug.cgi?id=33670. I'm struggling with writing tests
for this patch. I will be very thankful if somebody guides me trough
klimek accepted this revision.
klimek added a comment.
lg
Comment at: lib/Tooling/CompilationDatabase.cpp:312
+FixedCompilationDatabase::loadFromFile(StringRef Path, std::string &ErrorMsg) {
+ ErrorMsg.clear();
+ llvm::ErrorOr> File =
sammccall wrote:
> klime
dberris updated this revision to Diff 122210.
dberris marked an inline comment as done.
dberris added a comment.
- fixup: Use ASM macros for darwin assembly
- fixup: support weak symbols for Darwin linkage
https://reviews.llvm.org/D39114
Files:
clang/lib/Driver/XRayArgs.cpp
compiler-rt/cmak
dberris added a comment.
In https://reviews.llvm.org/D39114#914098, @kubamracek wrote:
> Hi and sorry for replying so late! All of the changes LGTM with a few nits.
All good, thanks for having a look!
>> Assembly for Darwin x86_64 and how we avoid the ELF'isms (do we need to
>> implement darw
sammccall updated this revision to Diff 122211.
sammccall added a comment.
Add fixme to upgrade out-param APIs.
https://reviews.llvm.org/D39799
Files:
docs/JSONCompilationDatabase.rst
include/clang/Tooling/CompilationDatabase.h
lib/Tooling/CompilationDatabase.cpp
test/Tooling/Inputs/fix
Author: sammccall
Date: Thu Nov 9 02:37:39 2017
New Revision: 31
URL: http://llvm.org/viewvc/llvm-project?rev=31&view=rev
Log:
[Tooling] Use FixedCompilationDatabase when `compile_flags.txt` is found.
Summary:
This is an alternative to JSONCompilationDatabase for simple projects that
don
This revision was automatically updated to reflect the committed changes.
Closed by commit rL31: [Tooling] Use FixedCompilationDatabase when
`compile_flags.txt` is found. (authored by sammccall).
Repository:
rL LLVM
https://reviews.llvm.org/D39799
Files:
cfe/trunk/docs/JSONCompilationDa
Typz added a comment.
> Sorry for the long response time. I don't see this style rule expressed
> explicitly in the Skia or QtCreator style guides - is this something that
> just happens to be done sometimes in the code bases?
This is present in code base. Those project's style guides are not p
klimek added a comment.
In https://reviews.llvm.org/D32478#920275, @Typz wrote:
> > Sorry for the long response time. I don't see this style rule expressed
> > explicitly in the Skia or QtCreator style guides - is this something that
> > just happens to be done sometimes in the code bases?
>
>
hokein added a comment.
Next time, please remember to add `cfe-commits` to the subscriber.
Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:14
+
+#include
+
Do we need this header?
Comment at: clang-tidy/objc/PropertyDeclarationCheck
sammccall created this revision.
(There must be some reason why https://reviews.llvm.org/D38077 didn't just do
this, but I don't get it!)
https://reviews.llvm.org/D39836
Files:
clangd/ClangdUnit.cpp
test/clangd/completion-priorities.test
test/clangd/completion-qualifiers.test
Index: tes
ilya-biryukov added a subscriber: klimek.
ilya-biryukov added a comment.
I personally think they're useful to have anyway, and they don't add much noise
when they're at the end of completions list.
I sometimes want to complete an item I know is there and then fix
accessibility. Do you think they
sammccall added a comment.
In https://reviews.llvm.org/D39836#920306, @ilya-biryukov wrote:
> I personally think they're useful to have anyway, and they don't add much
> noise when they're at the end of completions list.
> I sometimes want to complete an item I know is there and then fix
> acc
klimek added a comment.
In https://reviews.llvm.org/D39836#920313, @sammccall wrote:
> In https://reviews.llvm.org/D39836#920306, @ilya-biryukov wrote:
>
> > I personally think they're useful to have anyway, and they don't add much
> > noise when they're at the end of completions list.
> > I so
Author: hokein
Date: Thu Nov 9 03:30:04 2017
New Revision: 317780
URL: http://llvm.org/viewvc/llvm-project?rev=317780&view=rev
Log:
[clangd] Add rename support.
Summary:
Make clangd handle "textDocument/rename" request. The rename
functionality comes from the "local-rename" sub-tool of clang-ref
This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.
Closed by commit rL317780: [clangd] Add rename support. (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D39676?vs=122074&id=12#toc
Repository:
rL LLVM
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
This is probably one of the things that I'd like to be configurable.
In https://reviews.llvm.org/D39836#920313, @sammccall wrote:
> - they bulk up tests and debugging output
I'
Typz added a comment.
> Unless I'm missing something, I'd agree with Daniel; this is not a rule
> that's widely used, and I'd say reformatting a code base to the
> clang-formatted variant will not regress readability.
Unfortunately coding rules are not just about readability, but also about
co
Typz added a comment.
In https://reviews.llvm.org/D33440#920205, @djasper wrote:
> Out of curiosity, will this be able to fix the two situations that you get
> for python extension?
> There, you usually have a PyObject_HEAD with out semicolon in a struct and
> than a PyObject_HEAD_INIT(..) in
Author: krasimir
Date: Thu Nov 9 05:19:14 2017
New Revision: 317783
URL: http://llvm.org/viewvc/llvm-project?rev=317783&view=rev
Log:
[clang-format] Fix argument name comment, NFC
Modified:
cfe/trunk/lib/Format/ContinuationIndenter.cpp
Modified: cfe/trunk/lib/Format/ContinuationIndenter.cpp
Author: krasimir
Date: Thu Nov 9 05:22:03 2017
New Revision: 317784
URL: http://llvm.org/viewvc/llvm-project?rev=317784&view=rev
Log:
[clang-format] Fix a clang-tidy finding, NFC
Modified:
cfe/trunk/lib/Format/UnwrappedLineParser.cpp
Modified: cfe/trunk/lib/Format/UnwrappedLineParser.cpp
UR
mgorny created this revision.
The priority for destructors and operators was reduced in
https://reviews.llvm.org/rL314019.
Adjust the values used in the test appropriately to fix the test
failure.
Repository:
rL LLVM
https://reviews.llvm.org/D39838
Files:
bindings/python/tests/cindex/test
Typz updated this revision to Diff 18.
Typz marked 5 inline comments as done.
Typz added a comment.
Address review comments
https://reviews.llvm.org/D33440
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
lib/Format/FormatToken.h
lib/Format/FormatTokenLexer.cpp
lib/Forma
dberris updated this revision to Diff 19.
dberris added a comment.
- fixup: Use ASM macros for darwin assembly
- fixup: support weak symbols for Darwin linkage
- fixup: qualify symbols, use macros, limit weak symbols
- fixup: move test cases from Linux up one directory
- fixup: make clang link
dberris added subscribers: pelikan, echristo.
dberris added a comment.
Got some good progress on finally being able to make this work... here's the
current state:
- When linking the final binary, the XRay runtime can't seem to find the
`__{start,stop}_xray_{fn_idx,instr_map}` symbols. I've mark
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM.
Can we run those tests as part of `check-all` cmake target or setup a buildbot
that runs those? Seems surprising it went unnoticed for so long.
Repository:
rL LLVM
htt
malaperle added a comment.
I'm not sure it's better to use the InclusionDirective callback for this. We
need to get the includes in two places: in the preamble and non-preamble. In
the preamble we use the callback, have to store some temporary stuff because we
don't have a SourceManager in Incl
Hahnfeld added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:944
+ /// \brief Whether target supports variable-length arrays.
+ bool isVLASupported() const { return VLASupported; }
+
rjmccall wrote:
> ABataev wrote:
> > ABataev wrote:
> > > Hahn
ioeric added a comment.
In https://reviews.llvm.org/D39050#900830, @arphaman wrote:
> I think this patch should be split into a number of smaller patches to help
> the review process.
>
> Things like `tools/IndexStore`, `DirectoryWatcher` and other components that
> are not directly needed righ
ilya-biryukov created this revision.
These preambles are built by ASTUnit and clangd. Previously, preambles
were always stored on disk.
In-memory preambles are routed back to the compiler as virtual files in
a custom VFS.
Interface of ASTUnit does not allow to use in-memory preambles, as
ASTUnit
ilya-biryukov created this revision.
https://reviews.llvm.org/D39843
Files:
clangd/ClangdUnit.cpp
Index: clangd/ClangdUnit.cpp
===
--- clangd/ClangdUnit.cpp
+++ clangd/ClangdUnit.cpp
@@ -235,7 +235,7 @@
// NOTE: we use Buffer.
ilya-biryukov added a comment.
In https://reviews.llvm.org/D38639#920427, @malaperle wrote:
> I'm not sure it's better to use the InclusionDirective callback for this. We
> need to get the includes in two places: in the preamble and non-preamble. In
> the preamble we use the callback, have to s
Author: krasimir
Date: Thu Nov 9 07:12:17 2017
New Revision: 317793
URL: http://llvm.org/viewvc/llvm-project?rev=317793&view=rev
Log:
[clang-format] Apply a clang-tidy suggestion, NFC
Modified:
cfe/trunk/lib/Format/Format.cpp
Modified: cfe/trunk/lib/Format/Format.cpp
URL:
http://llvm.org/v
ilya-biryukov added inline comments.
Comment at: clangd/ClangdServer.cpp:368
std::vector Result;
- Resources->getAST().get()->runUnderLock([Pos, &Result, this](ParsedAST *AST)
{
-if (!AST)
- return;
-Result = clangd::findDefinitions(*AST, Pos, Logger);
- });
+
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D39786
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
ilya-biryukov added a comment.
After looking at the numbers, I think we should make this configurable. I'll
update this change accordingly. Not sure what should be the default, though.
I'm currently erring on the side of "in-memory by default".
Current implementation eats almost twice as much m
bkramer added inline comments.
Comment at: lib/Format/BreakableToken.cpp:48
+ static const SmallVector KnownTextProtoPrefixes{"//", "#"};
+ const SmallVectorImpl &KnownPrefixes =
+ (Style.Language == FormatStyle::LK_TextProto) ? KnownTextProtoPrefixes
Thes
Author: krasimir
Date: Thu Nov 9 07:41:23 2017
New Revision: 317794
URL: http://llvm.org/viewvc/llvm-project?rev=317794&view=rev
Log:
[clang-format] Sort using declarations by splitting on '::'
Summary: This patch improves using declarations sorting.
Reviewers: bkramer
Reviewed By: bkramer
Su
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317794: [clang-format] Sort using declarations by splitting
on '::' (authored by krasimir).
Repository:
rL LLVM
https://reviews.llvm.org/D39786
Files:
cfe/trunk/docs/ClangFormatStyleOptions.rst
cf
Author: krasimir
Date: Thu Nov 9 07:54:59 2017
New Revision: 317799
URL: http://llvm.org/viewvc/llvm-project?rev=317799&view=rev
Log:
[clang-format] Keep Sphinx happy after r317794
Modified:
cfe/trunk/docs/ClangFormatStyleOptions.rst
cfe/trunk/include/clang/Format/Format.h
Modified: cfe
arphaman added a comment.
I would prefer to make this behaviour configurable.
https://reviews.llvm.org/D39836
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: benhamilton
Date: Thu Nov 9 08:01:16 2017
New Revision: 317800
URL: http://llvm.org/viewvc/llvm-project?rev=317800&view=rev
Log:
[VirtualFileSystem] InMemoryFileSystem::addFile(): Type and Perms
Summary:
This implements a FIXME in InMemoryFileSystem::addFile(), allowing
clients to specif
sammccall added a comment.
Heh, I was just going to ask :-)
As a very first step, can we make this configurable but off-by-default? That
will address the pressing diskless-servers need.
In a typical workstation scenario, disk is plentiful (if slow) and RAM is
scarce - very likely we're running
sammccall added a comment.
I'm really happy you've made this work! I don't understand it enough to do a
meaningful review (keen to learn if you have time for a walkthrough when back
in the office).
https://reviews.llvm.org/D39842
___
cfe-commits m
benhamilton added inline comments.
Comment at: docs/clang-tidy/checks/objc-property-declaration.rst:7
+Finds property declarations in Objective-C files that do not follow the pattern
+of property names in Google's Objective-C Style Guide. The property name should
+be in the forma
benhamilton added inline comments.
Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:25
+/// we will do best effort to generate a fix, however, if the
+/// case can not be solved with a simple fix (e.g. remove prefix or change
first
+/// character), we will leave the fix
sammccall added a comment.
So I probably should have started from the other end, here :-)
I'd really like to make the completion retrieval and ranking more flexible. In
particular
- incorporating results from other sources (indexes: both in-memory and
external services).
- combining more quali
malaperle added a comment.
In https://reviews.llvm.org/D38639#920487, @ilya-biryukov wrote:
> I think we should never iterate through `SourceManager`, as it's much easier
> to get wrong than using the callbacks. I agree that all that fiddling with
> callbacks is unfortunate, but it's well worth
kubamracek added a comment.
Thanks for working on this! Can we split the patch and land parts that are
LGTM? It's getting a bit crowded here. I think the ASM changes should be a
separate patch, and the test changes as well, probably.
https://reviews.llvm.org/D39114
_
Author: abataev
Date: Thu Nov 9 09:01:35 2017
New Revision: 317811
URL: http://llvm.org/viewvc/llvm-project?rev=317811&view=rev
Log:
[OPENMP] Treat '#pragma omp target parallel for simd' as simd directive.
`#pragma omp target parallel for simd` mistakenly was not treated as a
simd directive, fix
kromanenkov added a comment.
@NoQ Do we need to change a `DeclaratorDecl` field in PointerToMember SVal to
something more common, like `ValueDecl`, to support `IndirectFieldDecl` as well?
https://reviews.llvm.org/D39800
___
cfe-commits mailing lis
kubamracek added a comment.
> When linking the final binary, the XRay runtime can't seem to find the
> `__{start,stop}_xray_{fn_idx,instr_map}` symbols. I've marked them weak, but
> they seem to either not be resolved when statically linking the binary. The
> dynamic lib version of the XRay run
Author: abataev
Date: Thu Nov 9 09:32:15 2017
New Revision: 317813
URL: http://llvm.org/viewvc/llvm-project?rev=317813&view=rev
Log:
[OPENMP] Codegen for `#pragma omp target parallel for simd`.
Added codegen for `#pragma omp target parallel for simd` and clauses.
Added:
cfe/trunk/test/OpenM
Author: arphaman
Date: Thu Nov 9 09:54:49 2017
New Revision: 317816
URL: http://llvm.org/viewvc/llvm-project?rev=317816&view=rev
Log:
Add _LIBCPP_INLINE_VISIBILITY to __compressed_pair_elem members
The commit r300140 changed the implementation of compressed_pair, but didn't add
_LIBCPP_INLINE_VI
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317816: Add _LIBCPP_INLINE_VISIBILITY to
__compressed_pair_elem members (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D39751?vs=121939&id=122261#toc
Repository:
rL LLVM
h
ABataev updated this revision to Diff 122268.
ABataev added a comment.
Update status.
https://reviews.llvm.org/D39457
Files:
docs/OpenMPSupport.rst
docs/index.rst
Index: docs/index.rst
===
--- docs/index.rst
+++ docs/index.rs
arphaman added inline comments.
Comment at: lib/Tooling/Refactoring/Extract/CaptureVariables.cpp:36
+ return true;
+// FIXME: Capture 'self'.
+if (!VD->isLocalVarDeclOrParm())
ioeric wrote:
> and `this`?
This is a different kind of expression that wo
arphaman updated this revision to Diff 122270.
arphaman marked 5 inline comments as done.
arphaman added a comment.
Address review comments
Repository:
rL LLVM
https://reviews.llvm.org/D39706
Files:
lib/Tooling/Refactoring/CMakeLists.txt
lib/Tooling/Refactoring/Extract/CaptureVariables.c
ashi1 updated this revision to Diff 122271.
ashi1 added subscribers: scchan, yaxunl, ashi1.
ashi1 added a comment.
Herald added a subscriber: eraman.
I've added the lit tests for this change, and also showing full context.
My lit test import_weak_type.ll follows similar format to import_opaque_ty
sammccall created this revision.
All results are scored, we only process CodeCompletionStrings for the winners.
We now return CompletionList rather than CompletionItem[] (both are valid).
sortText is now based on CodeCompletionResult::orderedName (mostly the same).
This is the first clangd-only c
ABataev updated this revision to Diff 122273.
ABataev added a comment.
Fixed version of OpenMP standard
https://reviews.llvm.org/D39457
Files:
docs/OpenMPSupport.rst
docs/index.rst
Index: docs/index.rst
===
--- docs/index.rst
dcoughlin added a comment.
This looks good to me. It is very clean! But please add a comment in the places
where you are assuming a two's complement value representation for signed
integers.
https://reviews.llvm.org/D39707
___
cfe-commits mailing
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317820: [analyzer] assume bitwise arithmetic axioms
(authored by george.karpenkov).
Changed prior to commit:
https://reviews.llvm.org/D39707?vs=122170&id=122278#toc
Repository:
rL LLVM
https://revie
Author: george.karpenkov
Date: Thu Nov 9 11:06:22 2017
New Revision: 317820
URL: http://llvm.org/viewvc/llvm-project?rev=317820&view=rev
Log:
[analyzer] assume bitwise arithmetic axioms
Patches the solver to assume that bitwise OR of an unsigned value with a
constant always produces a value larg
JVApen added a comment.
How does this new file know if it should handle it's flags as it does in
clang.exe or clang-cl.exe?
Repository:
rL LLVM
https://reviews.llvm.org/D39799
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists
kzhuravl added a subscriber: cfe-commits.
kzhuravl added a reviewer: aaron.ballman.
kzhuravl added a comment.
Hi Alex, can you rebase on top of trunk (I think you brought in some extra
changes from hcc branch) and upload a full diff?
Comment at: include/clang/Basic/Attr.td:132
jdenny created this revision.
[OpenMP] diagnose assign to firstprivate const
Clang does not diagnose assignments to const variables declared
firstprivate. Furthermore, codegen is broken such that, at run time,
such assignments simply have no effect. For example, the following
prints 0 not 1:
i
mgorny added a comment.
In https://reviews.llvm.org/D39838#920399, @ilya-biryukov wrote:
> LGTM.
>
> Can we run those tests as part of `check-all` cmake target or setup a
> buildbot that runs those? Seems surprising it went unnoticed for so long.
I was thinking of that but I think it'd be nice
aaron.ballman added inline comments.
Comment at: include/clang/Basic/Attr.td:1329
StringArgument<"ISA", 1>];
let Documentation = [AMDGPUFlatWorkGroupSizeDocs];
let Subjects = SubjectList<[Function], ErrorDiag, "ExpectedKernelFunction">;
Pleas
Hello!
On Wed, Nov 08, 2017 at 12:36:00PM -0800, Volodymyr Sapsai wrote:
> Thanks for the patch, Reimar. Can you please add tests to ensure this
> functionality doesn’t regress? As null character is required by the standard
> (27.7.2.3p21), a good starting point seems to be
> test/std/input.outp
Author: mgorny
Date: Thu Nov 9 12:17:41 2017
New Revision: 317828
URL: http://llvm.org/viewvc/llvm-project?rev=317828&view=rev
Log:
[python] [tests] Update priority values in code completion test
The priority for destructors and operators was reduced in r314019.
Adjust the values used in the tes
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317828: [python] [tests] Update priority values in code
completion test (authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D39838?vs=17&id=122304#toc
Repository:
rL LLVM
htt
george.karpenkov created this revision.
Herald added subscribers: szepet, xazax.hun.
This is the issue breaking the postgresql bot, purely by chance exposed through
taint checker, somehow appearing after https://reviews.llvm.org/D38358 got
committed.
The backstory is that the taint checker requ
mgorny added reviewers: jbcoe, aaron.ballman.
mgorny added a comment.
Let's try some more reviewers.
https://reviews.llvm.org/D39161
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: arphaman
Date: Thu Nov 9 12:50:59 2017
New Revision: 317832
URL: http://llvm.org/viewvc/llvm-project?rev=317832&view=rev
Log:
[index] tag declarations should use the decl role instead of ref
The 'decl' role is more canonical than the 'ref'. This helps us establish the
'specialization-of'
sammccall added a comment.
In https://reviews.llvm.org/D39799#920780, @JVApen wrote:
> How does this new file know if it should handle it's flags as it does in
> clang.exe or clang-cl.exe?
It doesn't set argv[0], so it's treated like `clang` by default.
I believe the flag `--driver-mode={gcc
arphaman added a comment.
In https://reviews.llvm.org/D39836#920587, @sammccall wrote:
> So I probably should have started from the other end, here :-)
>
> I'd really like to make the completion retrieval and ranking more flexible.
> In particular
>
> - incorporating results from other sources (
AlexVlx updated this revision to Diff 122318.
https://reviews.llvm.org/D39857
Files:
include/clang/Basic/Attr.td
lib/CodeGen/TargetInfo.cpp
lib/Sema/SemaDeclAttr.cpp
Index: lib/Sema/SemaDeclAttr.cpp
===
--- lib/Sema/SemaDeclAt
Wizard updated this revision to Diff 122319.
Wizard marked 6 inline comments as done.
Wizard added a comment.
address comments
https://reviews.llvm.org/D39829
Files:
clang-tidy/objc/CMakeLists.txt
clang-tidy/objc/ObjCTidyModule.cpp
clang-tidy/objc/PropertyDeclarationCheck.cpp
clang-tidy
Wizard added inline comments.
Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:25
+/// we will do best effort to generate a fix, however, if the
+/// case can not be solved with a simple fix (e.g. remove prefix or change
first
+/// character), we will leave the fix to th
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
This seems reasonable to me. Please commit it. @NoQ can do a post-commit review
and fix it up if he would rather address the issue differently.
https://reviews.llvm.org/D39862
__
NoQ added a comment.
I'm curious if the crash would turn into an assertion failure during
`getRawSVal()` after https://reviews.llvm.org/D38801 is committed.
The problem with this checker producing void symbols is known since
https://reviews.llvm.org/D26837. If this problem is fixed on the check
ABataev added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:14356
+if (S.IsOpenMPCapturedDecl(Var)) {
+ bool hasConst = DeclRefType.isConstQualified();
DeclRefType = DeclRefType.getUnqualifiedType();
`hasConst` must start from capital letter
francisco.lopes added a comment.
Sorting got hardcoded? libclang has it optional. If hardcoded it becomes a
performance problem, since some clients may wish to order it themselves with
private heuristics.
Repository:
rL LLVM
https://reviews.llvm.org/D39738
___
sammccall added a comment.
In https://reviews.llvm.org/D39836#920977, @arphaman wrote:
> In https://reviews.llvm.org/D39836#920587, @sammccall wrote:
>
> > So I probably should have started from the other end, here :-)
> >
> > I'd really like to make the completion retrieval and ranking more flex
AlexVlx updated this revision to Diff 122323.
AlexVlx marked 7 inline comments as done.
https://reviews.llvm.org/D39857
Files:
include/clang/Basic/Attr.td
lib/CodeGen/TargetInfo.cpp
lib/Sema/SemaDeclAttr.cpp
Index: lib/Sema/SemaDeclAttr.cpp
=
sammccall added a comment.
In https://reviews.llvm.org/D39738#921014, @francisco.lopes wrote:
> Sorting got hardcoded? libclang has it optional. If hardcoded, it becomes a
> performance problem, since some clients may wish to order it themselves with
> private heuristics.
Is the performance r
1 - 100 of 156 matches
Mail list logo