[PATCH] D39347: Fix __has_unique_object_representations based on rsmith's input

erichkeane updated this revision to Diff 124769. erichkeane added a comment. Woops, missed an 'svn add' and lost the member ptr test. Back now! https://reviews.llvm.org/D39347 Files: include/clang/AST/ASTContext.h include/clang/AST/Type.h lib/AST/ASTContext.cpp lib/AST/CXXABI.h

[PATCH] D35894: [clangd] Code hover for Clangd

malaperle added inline comments. Comment at: clangd/ClangdUnit.cpp:1173 +H.range = L.range; +Ref = getDataBufferFromSourceRange(AST, SR, L); + } malaperle wrote: > malaperle wrote: > > I get the same crash as I mentioned before if I hover on

[PATCH] D39347: Fix __has_unique_object_representations based on rsmith's input

erichkeane updated this revision to Diff 124765. https://reviews.llvm.org/D39347 Files: include/clang/AST/ASTContext.h include/clang/AST/Type.h lib/AST/ASTContext.cpp lib/AST/CXXABI.h lib/AST/ItaniumCXXABI.cpp lib/AST/MicrosoftCXXABI.cpp lib/AST/Type.cpp lib/Sema/SemaExprCXX.cpp

[PATCH] D39347: Fix __has_unique_object_representations based on rsmith's input

erichkeane added inline comments. Comment at: lib/AST/ASTContext.cpp:2213 +Field->isBitField() +? Field->getBitWidthValue(Context) +: Context.toBits(Context.getTypeSizeInChars(Field->getType())); erichkeane wrote: > rsmith wrote:

[clang-tools-extra] r319325 - [clang-tidy] make readability-simplify-bool-expr completely ignore macros

Author: alexfh Date: Wed Nov 29 09:16:09 2017 New Revision: 319325 URL: http://llvm.org/viewvc/llvm-project?rev=319325=rev Log: [clang-tidy] make readability-simplify-bool-expr completely ignore macros Modified: clang-tools-extra/trunk/clang-tidy/readability/SimplifyBooleanExprCheck.cpp

[PATCH] D40580: [clang-tidy] Adding Fuchsia checker for multiple inheritance

aaron.ballman added inline comments. Comment at: clang-tidy/fuchsia/MultipleInheritanceCheck.cpp:58 + // Interfaces should have exclusively pure methods. + for (auto method : Node->methods()) { +if (method->isUserProvided() && !method->isPure()) {

[PATCH] D40476: Switch kryo to use -mcpu=cortex-a57 when invoking the assembler

mcrosier added a comment. In https://reviews.llvm.org/D40476#936700, @mcrosier wrote: > In https://reviews.llvm.org/D40476#936372, @pirama wrote: > > > Thanks for the review. Now let's just hope the windows bots stay happy :) > > > Actually, I just checked and it looks like falkor and saphira

r319323 - [Driver] Turns out the GNU assembler does support falkor/saphira.

Author: mcrosier Date: Wed Nov 29 08:42:44 2017 New Revision: 319323 URL: http://llvm.org/viewvc/llvm-project?rev=319323=rev Log: [Driver] Turns out the GNU assembler does support falkor/saphira. Modified: cfe/trunk/lib/Driver/ToolChains/Gnu.cpp cfe/trunk/test/Driver/as-mcpu.c Modified:

[PATCH] D40574: Bounds check argument_with_type_tag attribute.

aaron.ballman added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7922-7925 +def err_type_tag_out_of_range : Error< + "type tag index %0 is greater than the number of arguments specified">; +def err_arg_tag_out_of_range : Error< + "argument tag index

Re: [llvm-dev] LLVM buildmaster is back to work now but two builders remain OFF

> Two slaves remain off for now as they produce a lot of warnings and their log files are way too big. I think https://reviews.llvm.org/D40603 will fix this issue. -Greg On 28 November 2017 at 22:13, Galina Kistanova via llvm-dev < llvm-...@lists.llvm.org> wrote: > Hello everyone, > > LLVM

r319322 - Fix function call to fix build

Author: ismail Date: Wed Nov 29 07:18:02 2017 New Revision: 319322 URL: http://llvm.org/viewvc/llvm-project?rev=319322=rev Log: Fix function call to fix build ../tools/clang/lib/Driver/ToolChains/Cuda.cpp:80:18: error: reference to non-static member function must be called; did you mean to call

[PATCH] D30691: [analyzer] Support for naive cross translational unit analysis

gerazo added a comment. Thanks George for the review. I will start working on the code right away. I've tried to answer the simpler cases. Comment at: tools/scan-build-py/libscanbuild/analyze.py:44 +CTU_FUNCTION_MAP_FILENAME = 'externalFnMap.txt' +CTU_TEMP_FNMAP_FOLDER =

r319269 - Reland "Fix vtable not receiving hidden visibility when using push(visibility)"

Author: jakehehrlich Date: Tue Nov 28 16:54:20 2017 New Revision: 319269 URL: http://llvm.org/viewvc/llvm-project?rev=319269=rev Log: Reland "Fix vtable not receiving hidden visibility when using push(visibility)" I had to reland this change in order to make the test work on windows This change

[PATCH] D40527: [libclang] Record parsing invocation to a temporary file when requested by client

jkorous-apple added inline comments. Comment at: tools/libclang/CIndexer.cpp:108 + // Write out the information about the invocation to it. + auto WriteStringKey = [&](StringRef Key, StringRef Value) { +OS << R"(")" << Key << R"(":")"; Nit: Maybe capturing

[PATCH] D40605: Better trade-off for excess characters vs. staying within the column limits.

klimek created this revision. When we break a long line like: Column limit: 21 | // foo foo foo foo foo foo foo foo foo foo foo foo The local decision when to allow protruding vs. breaking can lead to this outcome (2 excess characters, 2 breaks): // foo foo foo foo

[PATCH] D40463: [analyzer] Fix false negative on post-increment of uninitialized variable.

xazax.hun added inline comments. Comment at: lib/StaticAnalyzer/Checkers/UndefinedAssignmentChecker.cpp:64 +if (const UnaryOperator *U = dyn_cast(StoreE)) { + str = "The expression of the unary operator is an uninitialized value. " +"The computed value will

r319320 - [OPENMP] General improvement of handling of `teams distribute`

Author: abataev Date: Wed Nov 29 07:14:16 2017 New Revision: 319320 URL: http://llvm.org/viewvc/llvm-project?rev=319320=rev Log: [OPENMP] General improvement of handling of `teams distribute` directive, NFC. Some general improvements in support of `teams distribute` directive. Modified:

r319319 - Follow up of r319317, add the missing header file

Author: sylvestre Date: Wed Nov 29 07:11:53 2017 New Revision: 319319 URL: http://llvm.org/viewvc/llvm-project?rev=319319=rev Log: Follow up of r319317, add the missing header file Modified: cfe/trunk/lib/Driver/ToolChains/Cuda.cpp Modified: cfe/trunk/lib/Driver/ToolChains/Cuda.cpp URL:

[PATCH] D40527: [libclang] Record parsing invocation to a temporary file when requested by client

jkorous-apple added inline comments. Comment at: tools/libclang/CIndexer.cpp:131 + if (!File.empty()) +llvm::sys::fs::remove(File); +} Just a thought - since we are not propagating errors from constructor we are not really sure we were able to create the

r319318 - Fix 'control reaches end of non-void' warning by using llvm_unreachable.

Author: klimek Date: Wed Nov 29 07:09:12 2017 New Revision: 319318 URL: http://llvm.org/viewvc/llvm-project?rev=319318=rev Log: Fix 'control reaches end of non-void' warning by using llvm_unreachable. Modified: cfe/trunk/lib/Format/BreakableToken.cpp Modified:

[PATCH] D40548: [clangd] Prototyping index support and naive index-based global code completion. WIP

ioeric updated this revision to Diff 124745. ioeric added a comment. Herald added a subscriber: klimek. Merged with origin/master Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D40548 Files: clangd/ASTIndex.cpp clangd/ASTIndex.h clangd/CMakeLists.txt

[PATCH] D40594: [InstCombine] miscompile of __builtin_fmod

spatel added a comment. Side note: I think there is a different bug here in clang because from what I can tell, we convert the builtin or libcall to 'frem' even when errno could be set by the call. https://reviews.llvm.org/D40044 doesn't address this case because frem is an LLVM instruction

r319317 - Add the nvidia-cuda-toolkit Debian package path to search path

Author: sylvestre Date: Wed Nov 29 07:03:28 2017 New Revision: 319317 URL: http://llvm.org/viewvc/llvm-project?rev=319317=rev Log: Add the nvidia-cuda-toolkit Debian package path to search path Summary: Reported here: http://bugs.debian.org/882505 Patch by Andreas Beckmann Reviewers:

[PATCH] D40453: Add the nvidia-cuda-toolkit Debian package path to search path

This revision was automatically updated to reflect the committed changes. Closed by commit rC319317: Add the nvidia-cuda-toolkit Debian package path to search path (authored by sylvestre). Repository: rC Clang https://reviews.llvm.org/D40453 Files: lib/Driver/ToolChains/Cuda.cpp Index:

[PATCH] D39053: [Bitfield] Add more cases to making the bitfield a separate location

spetrovic added a comment. I tried to compile some important libraries for X86 and MIPS64 within Chromium with clang/llvm. I have compared results between LLVM trunk, and LLVM trunk with my patch. There is code size improvement on many libraries, here are some results: - X86 libframe

[PATCH] D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy

alexfh added a comment. A couple of late comments. Comment at: clang-tidy/fuchsia/DefaultArgumentsCheck.cpp:39 + return; +} else if (DefaultArgRange.getBegin().isMacroID()) { + diag(D->getLocStart(), No `else` after `return`, please.

[PATCH] D40562: [Sema] Ignore decls in namespaces when global decls are not wanted.

ioeric updated this revision to Diff 124740. ioeric added a comment. - Clarify comment for includeGlobals() https://reviews.llvm.org/D40562 Files: include/clang/Sema/CodeCompleteConsumer.h lib/Sema/SemaCodeComplete.cpp lib/Sema/SemaLookup.cpp test/CodeCompletion/ignore-global-decls.cpp

[PATCH] D39812: [Driver, CodeGen] pass through and apply -fassociative-math

spatel added a comment. Ping * 2. https://reviews.llvm.org/D39812 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40563: [SemaCodeComplete] Allow passing out scope specifiers in qualified-id completions via completion context.

ioeric updated this revision to Diff 124739. ioeric marked 4 inline comments as done. ioeric added a comment. - Address review comments. https://reviews.llvm.org/D40563 Files: include/clang/Sema/CodeCompleteConsumer.h lib/Sema/SemaCodeComplete.cpp Index: lib/Sema/SemaCodeComplete.cpp

[PATCH] D40563: [SemaCodeComplete] Allow passing out scope specifiers in qualified-id completions via completion context.

ioeric added inline comments. Comment at: lib/Sema/SemaCodeComplete.cpp:4609 + if (SS.isInvalid()) { +CodeCompletionContext CC(CodeCompletionContext::CCC_Name); ilya-biryukov wrote: > ilya-biryukov wrote: > > Why do we alter this code path? > Maybe we

[PATCH] D40310: Restructure how we break tokens.

This revision was automatically updated to reflect the committed changes. Closed by commit rL319314: Restructure how we break tokens. (authored by klimek). Repository: rL LLVM https://reviews.llvm.org/D40310 Files: cfe/trunk/lib/Format/BreakableToken.cpp

r319314 - Restructure how we break tokens.

Author: klimek Date: Wed Nov 29 06:29:43 2017 New Revision: 319314 URL: http://llvm.org/viewvc/llvm-project?rev=319314=rev Log: Restructure how we break tokens. This fixes some bugs in the reflowing logic and splits out the concerns of reflowing from BreakableToken. Things to do after this

[PATCH] D40588: [OpenMP] Diagnose undeclared variables on declare target clause

ABataev requested changes to this revision. ABataev added a comment. This revision now requires changes to proceed. I'm unable to reproduce a crash, the test works correctly even without you patch https://reviews.llvm.org/D40588 ___ cfe-commits

[PATCH] D40594: [InstCombine] miscompile of __builtin_fmod

spatel added reviewers: efriedma, hfinkel. spatel added a comment. I don't know the history of the frem instruction in IR, and the description in http://llvm.org/docs/LangRef.html#frem-instruction is vague. But based on the existing code, I think this is working as intended. If the instruction

[PATCH] D40580: [clang-tidy] Adding Fuchsia checker for multiple inheritance

alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed. Comment at: clang-tidy/fuchsia/MultipleInheritanceCheck.cpp:22 +AST_MATCHER(CXXRecordDecl, hasDefinition) { + if (!Node.hasDefinition()) +return false;

[PATCH] D39114: [XRay][compiler-rt][Darwin] Minimal XRay build support in Darwin

dberris closed this revision. dberris added a comment. Already commited; closing this revision out now. https://reviews.llvm.org/D39114 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40310: Restructure how we break tokens.

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D40310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D39279: Stringizing raw string literals containing newline

jkorous-apple added a comment. I am sorry I wasn't really clear. What I meant was to do something like this (pseudo-code, dealing only with newlines): if( Str.size() == 0) return; // Calculate all the extra space needed first. typename T::size_type extra_space = 0; bool

[PATCH] D40601: [XRay][clang] Introduce -fxray-always-emit-customevents

dberris created this revision. The -fxray-always-emit-customevents flag instructs clang to always emit the LLVM IR for calls to the `__xray_customevent(...)` built-in function. The default behaviour currently respects whether the function has an `[[clang::xray_never_instrument]]` attribute, and

[PATCH] D39455: [CodeGen] Add initial support for union members in TBAA

kosarev updated this revision to Diff 124726. kosarev added a comment. - Added tests with nested unions. - Rebased. https://reviews.llvm.org/D39455 Files: lib/CodeGen/CGExpr.cpp lib/CodeGen/CodeGenModule.h lib/CodeGen/CodeGenTBAA.cpp lib/CodeGen/CodeGenTBAA.h

[PATCH] D40563: [SemaCodeComplete] Allow passing out scope specifiers in qualified-id completions via completion context.

ilya-biryukov added inline comments. Comment at: lib/Sema/SemaCodeComplete.cpp:4609 + if (SS.isInvalid()) { +CodeCompletionContext CC(CodeCompletionContext::CCC_Name); ilya-biryukov wrote: > Why do we alter this code path? Maybe we should add a test or

[PATCH] D40563: [SemaCodeComplete] Allow passing out scope specifiers in qualified-id completions via completion context.

ilya-biryukov added inline comments. Comment at: include/clang/Sema/CodeCompleteConsumer.h:284 + llvm::Optional ScopeSpecifier; + Maybe add a brief comment for consistency with other decls? Comment at: lib/Sema/SemaCodeComplete.cpp:4609 +

[PATCH] D40463: [analyzer] Fix false negative on post-increment of uninitialized variable.

lebedev.ri added inline comments. Comment at: lib/StaticAnalyzer/Checkers/UndefinedAssignmentChecker.cpp:64 +if (const UnaryOperator *U = dyn_cast(StoreE)) { + str = "The expression of the unary operator is an uninitialized value. " +"The computed value will

[PATCH] D40310: Restructure how we break tokens.

klimek added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:1749 + } + if (!Reflow) { +// If we didn't reflow into the next line, the only space to consider is krasimir wrote: > nit: Maybe change this to `if (Reflow)` and

[PATCH] D39114: [XRay][compiler-rt][Darwin] Minimal XRay build support in Darwin

dberris updated this revision to Diff 124717. dberris added a comment. - [XRay][compiler-rt][Darwin] Use dynamic initialisation as an alternative https://reviews.llvm.org/D39114 Files: compiler-rt/cmake/config-ix.cmake compiler-rt/lib/xray/CMakeLists.txt

[PATCH] D34030: Fix the postorder visting of the ClassTemplateSpecializationDecl nodes in the RecursiveASTVisitor.

MontyKutyi added a comment. Ping. https://reviews.llvm.org/D34030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40596: [clangd] New conventions for JSON-marshalling functions, centralize machinery

sammccall created this revision. Herald added subscribers: cfe-commits, klimek. - JSON<->Obj interface is now ADL functions, so they play nicely with enums - recursive vector/map parsing and ObjectMapper moved to JSONExpr and tested - renamed (un)parse to (de)serialize, since text -> JSON is

[clang-tools-extra] r319309 - [clangd] Simplify common JSON-parsing patterns in Protocol.

Author: sammccall Date: Wed Nov 29 03:36:46 2017 New Revision: 319309 URL: http://llvm.org/viewvc/llvm-project?rev=319309=rev Log: [clangd] Simplify common JSON-parsing patterns in Protocol. Summary: This makes the parse() functions about as short as they can be given the current signature, and

[PATCH] D40564: [clangd] Simplify common JSON-parsing patterns in Protocol.

This revision was automatically updated to reflect the committed changes. Closed by commit rL319309: [clangd] Simplify common JSON-parsing patterns in Protocol. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D40564?vs=124585=124713#toc Repository: rL LLVM

[PATCH] D40310: Restructure how we break tokens.

krasimir added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:1749 + } + if (!Reflow) { +// If we didn't reflow into the next line, the only space to consider is nit: Maybe change this to `if (Reflow)` and switch the if-else

[PATCH] D40508: Replace long type names in IR with hashes

sepavloff added a comment. In https://reviews.llvm.org/D40508#938686, @rjmccall wrote: > In https://reviews.llvm.org/D40508#938675, @sepavloff wrote: > > > In https://reviews.llvm.org/D40508#938040, @rjmccall wrote: > > > > > My skepticism about the raw_ostream is not about the design of having

[PATCH] D40562: [Sema] Ignore decls in namespaces when global decls are not wanted.

ilya-biryukov added a comment. This is how I always perceived this option in the first place, so LGTM. But maybe its intention is different, so we should wait for @arphaman's comments. Could you also update comments of `CodeCompleteConsumer::includeGlobals` and

[PATCH] D40310: Restructure how we break tokens.

klimek added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:1707 + RemainingTokenColumns = Token->getRemainingLength( + NextLineIndex, TailOffset, ContentStartColumn); + Reflow = true; krasimir wrote: > When we're

[PATCH] D40310: Restructure how we break tokens.

klimek updated this revision to Diff 124709. klimek marked 4 inline comments as done. klimek added a comment. Address review comments. https://reviews.llvm.org/D40310 Files: lib/Format/BreakableToken.cpp lib/Format/BreakableToken.h lib/Format/ContinuationIndenter.cpp

[PATCH] D40060: [clangd] Fuzzy match scorer

ilya-biryukov added inline comments. Comment at: clangd/FuzzyMatch.cpp:118 +0x00, 0x00, 0x00, 0x00, // Control characters +0xff, 0xff, 0xff, 0xff, // Punctuation +0x55, 0x55, 0xf5, 0xff, // Numbers->Lower, more Punctuation. I'm not sure if we care,

[PATCH] D40564: [clangd] Simplify common JSON-parsing patterns in Protocol.

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. lgtm Comment at: clangd/Protocol.cpp:56 +assert(*this && "Must check this is an object before calling parse()"); +if (const json::Expr *E = O->get(Prop)) { +

[PATCH] D40528: add new check to find NSError init invocation

hokein added inline comments. Comment at: clang-tidy/objc/AvoidNserrorInitCheck.cpp:31 + diag(MatchedExpr->getLocStart(), + "use errorWithDomain:code:userInfo: to create a new NSError"); +} not sure what's the best message here. From apple's document: >

[PATCH] D40543: Pass by reference NewQualifiedName in QualifiedRenameRule

hokein added inline comments. Comment at: include/clang/Tooling/Refactoring/Rename/RenamingAction.h:79 QualifiedRenameRule(const NamedDecl *ND, - std::string NewQualifiedName) + const std::string ) : ND(ND),

[PATCH] D40594: [InstCombine] miscompile of __builtin_fmod

Quolyk created this revision. Motivation: https://bugs.llvm.org/show_bug.cgi?id=34870 I'm totally not sure this is correct https://reviews.llvm.org/D40594 Files: lib/CodeGen/CGBuiltin.cpp test/CodeGen/builtins.c Index: test/CodeGen/builtins.c

[libunwind] r319300 - Support building libunwind as a DLL

Author: mstorsjo Date: Wed Nov 29 00:21:12 2017 New Revision: 319300 URL: http://llvm.org/viewvc/llvm-project?rev=319300=rev Log: Support building libunwind as a DLL Differential Revision: https://reviews.llvm.org/D40483 Modified: libunwind/trunk/CMakeLists.txt

[libunwind] r319299 - [CMake] Use the variable from the right project in install-unwind

Author: mstorsjo Date: Wed Nov 29 00:20:57 2017 New Revision: 319299 URL: http://llvm.org/viewvc/llvm-project?rev=319299=rev Log: [CMake] Use the variable from the right project in install-unwind Modified: libunwind/trunk/src/CMakeLists.txt Modified: libunwind/trunk/src/CMakeLists.txt URL:

<    1   2